From 412a963c5869d3e59ac753b93f6407947e21ca27 Mon Sep 17 00:00:00 2001 From: Richard Levitte Date: Wed, 13 Jan 2016 17:27:06 +0100 Subject: [PATCH] Pipes on VMS do not work well with binary data, use an intermediary file VMS being a record oriented operating system, it's uncertain how the 'pipe' passes binary data from one process to another. Experience shows that we get in trouble, and it's probably due to the pipe in itself being opened in text mode (variable length records). It's safer to pass data via an intermediary file instead. Reviewed-by: Rich Salz --- test/recipes/80-test_ocsp.t | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/test/recipes/80-test_ocsp.t b/test/recipes/80-test_ocsp.t index 96e1220ed2..6e256c7122 100644 --- a/test/recipes/80-test_ocsp.t +++ b/test/recipes/80-test_ocsp.t @@ -20,15 +20,17 @@ sub test_ocsp { my $CAfile = shift; my $expected_exit = shift; + run(app(["openssl", "base64", "-d", + "-in", catfile($ocspdir,$inputfile), + "-out", "ocsp-resp-fff.dat"])); with({ exit_checker => sub { return shift == $expected_exit; } }, - sub { ok(run(pipe(app(["openssl", "base64", "-d", - "-in", catfile($ocspdir,$inputfile)]), - app(["openssl", "ocsp", "-respin", "-", - "-partial_chain", @check_time, - "-CAfile", catfile($ocspdir, $CAfile), - "-verify_other", catfile($ocspdir, $CAfile), - "-no-CApath"]))), - $title); }); + sub { ok(run(app(["openssl", "ocsp", "-respin", "ocsp-resp-fff.dat", + "-partial_chain", @check_time, + "-CAfile", catfile($ocspdir, $CAfile), + "-verify_other", catfile($ocspdir, $CAfile), + "-no-CApath"])), + $title); }); + unlink "ocsp-resp-fff.dat"; } plan tests => 10; -- 2.25.1