From 309fa55bbbc1465eb42fbe05c789a1e98c4ccb9a Mon Sep 17 00:00:00 2001 From: Ben Laurie Date: Wed, 4 Apr 2007 14:35:56 +0000 Subject: [PATCH] Return an error if the serial number is badly formed. (Coverity ID 116). --- apps/ca.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/ca.c b/apps/ca.c index 7666e35d54..291f16487a 100644 --- a/apps/ca.c +++ b/apps/ca.c @@ -2406,6 +2406,8 @@ static int do_revoke(X509 *x509, CA_DB *db, int type, char *value) row[i]=NULL; row[DB_name]=X509_NAME_oneline(X509_get_subject_name(x509),NULL,0); bn = ASN1_INTEGER_to_BN(X509_get_serialNumber(x509),NULL); + if (!bn) + goto err; if (BN_is_zero(bn)) row[DB_serial]=BUF_strdup("00"); else -- 2.25.1