From 2e6e08423b95b1b2bce7568f650c2b69d8d8fb8b Mon Sep 17 00:00:00 2001 From: Alexander Monakov Date: Tue, 4 Jul 2017 22:53:12 +0300 Subject: [PATCH] remove ineffective compiler assist from printf The switch statement has no 'default:' case and the function ends immediately following the switch, so the extra comparison did not communicate any extra information to the compiler. --- src/stdio/vfprintf.c | 2 -- src/stdio/vfwprintf.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/stdio/vfprintf.c b/src/stdio/vfprintf.c index 8c81efc2..15356f53 100644 --- a/src/stdio/vfprintf.c +++ b/src/stdio/vfprintf.c @@ -107,8 +107,6 @@ union arg static void pop_arg(union arg *arg, int type, va_list *ap) { - /* Give the compiler a hint for optimizing the switch. */ - if ((unsigned)type > MAXSTATE) return; switch (type) { case PTR: arg->p = va_arg(*ap, void *); break; case INT: arg->i = va_arg(*ap, int); diff --git a/src/stdio/vfwprintf.c b/src/stdio/vfwprintf.c index 1e6e47cc..e87ad42a 100644 --- a/src/stdio/vfwprintf.c +++ b/src/stdio/vfwprintf.c @@ -98,8 +98,6 @@ union arg static void pop_arg(union arg *arg, int type, va_list *ap) { - /* Give the compiler a hint for optimizing the switch. */ - if ((unsigned)type > MAXSTATE) return; switch (type) { case PTR: arg->p = va_arg(*ap, void *); break; case INT: arg->i = va_arg(*ap, int); -- 2.25.1