From 2bd5b4e9a0442102ab937ed771b2c11142afb744 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Wed, 7 Feb 2018 16:32:30 +0100 Subject: [PATCH] udhcp: do not setlinebuf(stdout), we don't print to stdout anymore Since bb_info_msg() was eliminated type of buffering on stdout is not important function old new delta udhcpd_main 1463 1451 -12 udhcpc_main 2735 2723 -12 setlinebuf 19 - -19 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 0/2 up/down: 0/-43) Total: -43 bytes Signed-off-by: Denys Vlasenko --- networking/udhcp/d6_dhcpc.c | 2 -- networking/udhcp/dhcpc.c | 2 -- networking/udhcp/dhcpd.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/networking/udhcp/d6_dhcpc.c b/networking/udhcp/d6_dhcpc.c index 07a8b11c1..35c99e89c 100644 --- a/networking/udhcp/d6_dhcpc.c +++ b/networking/udhcp/d6_dhcpc.c @@ -1201,8 +1201,6 @@ int udhcpc6_main(int argc UNUSED_PARAM, char **argv) /* Make sure fd 0,1,2 are open */ bb_sanitize_stdio(); - /* Equivalent of doing a fflush after every \n */ - setlinebuf(stdout); /* Create pidfile */ write_pidfile(client_config.pidfile); /* Goes to stdout (unless NOMMU) and possibly syslog */ diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c index 385fc4998..35694fbe3 100644 --- a/networking/udhcp/dhcpc.c +++ b/networking/udhcp/dhcpc.c @@ -1386,8 +1386,6 @@ int udhcpc_main(int argc UNUSED_PARAM, char **argv) /* Make sure fd 0,1,2 are open */ bb_sanitize_stdio(); - /* Equivalent of doing a fflush after every \n */ - setlinebuf(stdout); /* Create pidfile */ write_pidfile(client_config.pidfile); /* Goes to stdout (unless NOMMU) and possibly syslog */ diff --git a/networking/udhcp/dhcpd.c b/networking/udhcp/dhcpd.c index ff7450739..093239536 100644 --- a/networking/udhcp/dhcpd.c +++ b/networking/udhcp/dhcpd.c @@ -856,8 +856,6 @@ int udhcpd_main(int argc UNUSED_PARAM, char **argv) /* Make sure fd 0,1,2 are open */ bb_sanitize_stdio(); - /* Equivalent of doing a fflush after every \n */ - setlinebuf(stdout); /* Create pidfile */ write_pidfile(server_config.pidfile); -- 2.25.1