From 2b40699082d1e5d0e94811542c4f0633ab2d5989 Mon Sep 17 00:00:00 2001 From: Rich Salz Date: Mon, 28 Nov 2016 15:33:40 -0500 Subject: [PATCH] CRL critical extension bugfix More importantly, port CRL test from boringSSL crypto/x509/x509_test.cc Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/1775) --- crypto/x509/x_crl.c | 2 +- test/build.info | 6 +- test/crltest.c | 372 +++++++++++++++++++++++++++++++++++++ test/recipes/25-test_crl.t | 4 +- 4 files changed, 381 insertions(+), 3 deletions(-) create mode 100644 test/crltest.c diff --git a/crypto/x509/x_crl.c b/crypto/x509/x_crl.c index a5871ca6e5..da9c6b6157 100644 --- a/crypto/x509/x_crl.c +++ b/crypto/x509/x_crl.c @@ -213,7 +213,7 @@ static int crl_cb(int operation, ASN1_VALUE **pval, const ASN1_ITEM *it, if ((nid == NID_issuing_distribution_point) || (nid == NID_authority_key_identifier) || (nid == NID_delta_crl)) - break;; + continue; crl->flags |= EXFLAG_CRITICAL; break; } diff --git a/test/build.info b/test/build.info index 882f2dae1d..92ac237cbf 100644 --- a/test/build.info +++ b/test/build.info @@ -19,7 +19,7 @@ IF[{- !$disabled{tests} -}] randtest dhtest enginetest casttest \ bftest ssltest_old dsatest exptest rsa_test \ evp_test evp_extra_test igetest v3nametest v3ext \ - danetest p5_crpt2_test bad_dtls_test \ + crltest danetest p5_crpt2_test bad_dtls_test \ constant_time_test verify_extra_test clienthellotest \ packettest asynctest secmemtest srptest memleaktest \ dtlsv1listentest ct_test threadstest afalgtest d2i_test \ @@ -171,6 +171,10 @@ IF[{- !$disabled{tests} -}] INCLUDE[v3nametest]=../include DEPEND[v3nametest]=../libcrypto + SOURCE[crltest]=crltest.c testutil.c test_main.c + INCLUDE[crltest]=../include + DEPEND[crltest]=../libcrypto + SOURCE[v3ext]=v3ext.c INCLUDE[v3ext]=../include DEPEND[v3ext]=../libcrypto diff --git a/test/crltest.c b/test/crltest.c new file mode 100644 index 0000000000..d95f0608e3 --- /dev/null +++ b/test/crltest.c @@ -0,0 +1,372 @@ +/* + * Copyright 2015-2016 The OpenSSL Project Authors. All Rights Reserved. + * + * Licensed under the OpenSSL license (the "License"). You may not use + * this file except in compliance with the License. You can obtain a copy + * in the file LICENSE in the source distribution or at + * https://www.openssl.org/source/license.html + */ + +#include +#include "../e_os.h" +#include +#include +#include +#include +#include +#include + +#include "testutil.h" +#include "test_main.h" + +static const char *kCRLTestRoot[] = { + "-----BEGIN CERTIFICATE-----\n", + "MIIDbzCCAlegAwIBAgIJAODri7v0dDUFMA0GCSqGSIb3DQEBCwUAME4xCzAJBgNV\n", + "BAYTAlVTMRMwEQYDVQQIDApDYWxpZm9ybmlhMRYwFAYDVQQHDA1Nb3VudGFpbiBW\n", + "aWV3MRIwEAYDVQQKDAlCb3JpbmdTU0wwHhcNMTYwOTI2MTUwNjI2WhcNMjYwOTI0\n", + "MTUwNjI2WjBOMQswCQYDVQQGEwJVUzETMBEGA1UECAwKQ2FsaWZvcm5pYTEWMBQG\n", + "A1UEBwwNTW91bnRhaW4gVmlldzESMBAGA1UECgwJQm9yaW5nU1NMMIIBIjANBgkq\n", + "hkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAo16WiLWZuaymsD8n5SKPmxV1y6jjgr3B\n", + "S/dUBpbrzd1aeFzNlI8l2jfAnzUyp+I21RQ+nh/MhqjGElkTtK9xMn1Y+S9GMRh+\n", + "5R/Du0iCb1tCZIPY07Tgrb0KMNWe0v2QKVVruuYSgxIWodBfxlKO64Z8AJ5IbnWp\n", + "uRqO6rctN9qUoMlTIAB6dL4G0tDJ/PGFWOJYwOMEIX54bly2wgyYJVBKiRRt4f7n\n", + "8H922qmvPNA9idmX9G1VAtgV6x97XXi7ULORIQvn9lVQF6nTYDBJhyuPB+mLThbL\n", + "P2o9orxGx7aCtnnBZUIxUvHNOI0FaSaZH7Fi0xsZ/GkG2HZe7ImPJwIDAQABo1Aw\n", + "TjAdBgNVHQ4EFgQUWPt3N5cZ/CRvubbrkqfBnAqhq94wHwYDVR0jBBgwFoAUWPt3\n", + "N5cZ/CRvubbrkqfBnAqhq94wDAYDVR0TBAUwAwEB/zANBgkqhkiG9w0BAQsFAAOC\n", + "AQEAORu6M0MOwXy+3VEBwNilfTxyqDfruQsc1jA4PT8Oe8zora1WxE1JB4q2FJOz\n", + "EAuM3H/NXvEnBuN+ITvKZAJUfm4NKX97qmjMJwLKWe1gVv+VQTr63aR7mgWJReQN\n", + "XdMztlVeZs2dppV6uEg3ia1X0G7LARxGpA9ETbMyCpb39XxlYuTClcbA5ftDN99B\n", + "3Xg9KNdd++Ew22O3HWRDvdDpTO/JkzQfzi3sYwUtzMEonENhczJhGf7bQMmvL/w5\n", + "24Wxj4Z7KzzWIHsNqE/RIs6RV3fcW61j/mRgW2XyoWnMVeBzvcJr9NXp4VQYmFPw\n", + "amd8GKMZQvP0ufGnUn7D7uartA==\n", + "-----END CERTIFICATE-----\n", + NULL +}; + +static const char *kCRLTestLeaf[] = { + "-----BEGIN CERTIFICATE-----\n", + "MIIDkDCCAnigAwIBAgICEAAwDQYJKoZIhvcNAQELBQAwTjELMAkGA1UEBhMCVVMx\n", + "EzARBgNVBAgMCkNhbGlmb3JuaWExFjAUBgNVBAcMDU1vdW50YWluIFZpZXcxEjAQ\n", + "BgNVBAoMCUJvcmluZ1NTTDAeFw0xNjA5MjYxNTA4MzFaFw0xNzA5MjYxNTA4MzFa\n", + "MEsxCzAJBgNVBAYTAlVTMRMwEQYDVQQIDApDYWxpZm9ybmlhMRIwEAYDVQQKDAlC\n", + "b3JpbmdTU0wxEzARBgNVBAMMCmJvcmluZy5zc2wwggEiMA0GCSqGSIb3DQEBAQUA\n", + "A4IBDwAwggEKAoIBAQDc5v1S1M0W+QWM+raWfO0LH8uvqEwuJQgODqMaGnSlWUx9\n", + "8iQcnWfjyPja3lWg9K62hSOFDuSyEkysKHDxijz5R93CfLcfnVXjWQDJe7EJTTDP\n", + "ozEvxN6RjAeYv7CF000euYr3QT5iyBjg76+bon1p0jHZBJeNPP1KqGYgyxp+hzpx\n", + "e0gZmTlGAXd8JQK4v8kpdYwD6PPifFL/jpmQpqOtQmH/6zcLjY4ojmqpEdBqIKIX\n", + "+saA29hMq0+NK3K+wgg31RU+cVWxu3tLOIiesETkeDgArjWRS1Vkzbi4v9SJxtNu\n", + "OZuAxWiynRJw3JwH/OFHYZIvQqz68ZBoj96cepjPAgMBAAGjezB5MAkGA1UdEwQC\n", + "MAAwLAYJYIZIAYb4QgENBB8WHU9wZW5TU0wgR2VuZXJhdGVkIENlcnRpZmljYXRl\n", + "MB0GA1UdDgQWBBTGn0OVVh/aoYt0bvEKG+PIERqnDzAfBgNVHSMEGDAWgBRY+3c3\n", + "lxn8JG+5tuuSp8GcCqGr3jANBgkqhkiG9w0BAQsFAAOCAQEAd2nM8gCQN2Dc8QJw\n", + "XSZXyuI3DBGGCHcay/3iXu0JvTC3EiQo8J6Djv7WLI0N5KH8mkm40u89fJAB2lLZ\n", + "ShuHVtcC182bOKnePgwp9CNwQ21p0rDEu/P3X46ZvFgdxx82E9xLa0tBB8PiPDWh\n", + "lV16jbaKTgX5AZqjnsyjR5o9/mbZVupZJXx5Syq+XA8qiJfstSYJs4KyKK9UOjql\n", + "ICkJVKpi2ahDBqX4MOH4SLfzVk8pqSpviS6yaA1RXqjpkxiN45WWaXDldVHMSkhC\n", + "5CNXsXi4b1nAntu89crwSLA3rEwzCWeYj+BX7e1T9rr3oJdwOU/2KQtW1js1yQUG\n", + "tjJMFw==\n", + "-----END CERTIFICATE-----\n", + NULL +}; + +static const char *kBasicCRL[] = { + "-----BEGIN X509 CRL-----\n", + "MIIBpzCBkAIBATANBgkqhkiG9w0BAQsFADBOMQswCQYDVQQGEwJVUzETMBEGA1UE\n", + "CAwKQ2FsaWZvcm5pYTEWMBQGA1UEBwwNTW91bnRhaW4gVmlldzESMBAGA1UECgwJ\n", + "Qm9yaW5nU1NMFw0xNjA5MjYxNTEwNTVaFw0xNjEwMjYxNTEwNTVaoA4wDDAKBgNV\n", + "HRQEAwIBATANBgkqhkiG9w0BAQsFAAOCAQEAnrBKKgvd9x9zwK9rtUvVeFeJ7+LN\n", + "ZEAc+a5oxpPNEsJx6hXoApYEbzXMxuWBQoCs5iEBycSGudct21L+MVf27M38KrWo\n", + "eOkq0a2siqViQZO2Fb/SUFR0k9zb8xl86Zf65lgPplALun0bV/HT7MJcl04Tc4os\n", + "dsAReBs5nqTGNEd5AlC1iKHvQZkM//MD51DspKnDpsDiUVi54h9C1SpfZmX8H2Vv\n", + "diyu0fZ/bPAM3VAGawatf/SyWfBMyKpoPXEG39oAzmjjOj8en82psn7m474IGaho\n", + "/vBbhl1ms5qQiLYPjm4YELtnXQoFyC72tBjbdFd/ZE9k4CNKDbxFUXFbkw==\n", + "-----END X509 CRL-----\n", + NULL +}; + +static const char *kRevokedCRL[] = { + "-----BEGIN X509 CRL-----\n", + "MIIBvjCBpwIBATANBgkqhkiG9w0BAQsFADBOMQswCQYDVQQGEwJVUzETMBEGA1UE\n", + "CAwKQ2FsaWZvcm5pYTEWMBQGA1UEBwwNTW91bnRhaW4gVmlldzESMBAGA1UECgwJ\n", + "Qm9yaW5nU1NMFw0xNjA5MjYxNTEyNDRaFw0xNjEwMjYxNTEyNDRaMBUwEwICEAAX\n", + "DTE2MDkyNjE1MTIyNlqgDjAMMAoGA1UdFAQDAgECMA0GCSqGSIb3DQEBCwUAA4IB\n", + "AQCUGaM4DcWzlQKrcZvI8TMeR8BpsvQeo5BoI/XZu2a8h//PyRyMwYeaOM+3zl0d\n", + "sjgCT8b3C1FPgT+P2Lkowv7rJ+FHJRNQkogr+RuqCSPTq65ha4WKlRGWkMFybzVH\n", + "NloxC+aU3lgp/NlX9yUtfqYmJek1CDrOOGPrAEAwj1l/BUeYKNGqfBWYJQtPJu+5\n", + "OaSvIYGpETCZJscUWODmLEb/O3DM438vLvxonwGqXqS0KX37+CHpUlyhnSovxXxp\n", + "Pz4aF+L7OtczxL0GYtD2fR9B7TDMqsNmHXgQrixvvOY7MUdLGbd4RfJL3yA53hyO\n", + "xzfKY2TzxLiOmctG0hXFkH5J\n", + "-----END X509 CRL-----\n", + NULL +}; + +static const char *kBadIssuerCRL[] = { + "-----BEGIN X509 CRL-----\n", + "MIIBwjCBqwIBATANBgkqhkiG9w0BAQsFADBSMQswCQYDVQQGEwJVUzETMBEGA1UE\n", + "CAwKQ2FsaWZvcm5pYTEWMBQGA1UEBwwNTW91bnRhaW4gVmlldzEWMBQGA1UECgwN\n", + "Tm90IEJvcmluZ1NTTBcNMTYwOTI2MTUxMjQ0WhcNMTYxMDI2MTUxMjQ0WjAVMBMC\n", + "AhAAFw0xNjA5MjYxNTEyMjZaoA4wDDAKBgNVHRQEAwIBAjANBgkqhkiG9w0BAQsF\n", + "AAOCAQEAlBmjOA3Fs5UCq3GbyPEzHkfAabL0HqOQaCP12btmvIf/z8kcjMGHmjjP\n", + "t85dHbI4Ak/G9wtRT4E/j9i5KML+6yfhRyUTUJKIK/kbqgkj06uuYWuFipURlpDB\n", + "cm81RzZaMQvmlN5YKfzZV/clLX6mJiXpNQg6zjhj6wBAMI9ZfwVHmCjRqnwVmCUL\n", + "TybvuTmkryGBqREwmSbHFFjg5ixG/ztwzON/Ly78aJ8Bql6ktCl9+/gh6VJcoZ0q\n", + "L8V8aT8+Ghfi+zrXM8S9BmLQ9n0fQe0wzKrDZh14EK4sb7zmOzFHSxm3eEXyS98g\n", + "Od4cjsc3ymNk88S4jpnLRtIVxZB+SQ==\n", + "-----END X509 CRL-----\n", + NULL +}; + +/* + * This is kBasicCRL but with a critical issuing distribution point + * extension. + */ +static const char *kKnownCriticalCRL[] = { + "-----BEGIN X509 CRL-----\n", + "MIIBujCBowIBATANBgkqhkiG9w0BAQsFADBOMQswCQYDVQQGEwJVUzETMBEGA1UE\n", + "CAwKQ2FsaWZvcm5pYTEWMBQGA1UEBwwNTW91bnRhaW4gVmlldzESMBAGA1UECgwJ\n", + "Qm9yaW5nU1NMFw0xNjA5MjYxNTEwNTVaFw0xNjEwMjYxNTEwNTVaoCEwHzAKBgNV\n", + "HRQEAwIBATARBgNVHRwBAf8EBzAFoQMBAf8wDQYJKoZIhvcNAQELBQADggEBAA+3\n", + "i+5e5Ub8sccfgOBs6WVJFI9c8gvJjrJ8/dYfFIAuCyeocs7DFXn1n13CRZ+URR/Q\n", + "mVWgU28+xeusuSPYFpd9cyYTcVyNUGNTI3lwgcE/yVjPaOmzSZKdPakApRxtpKKQ\n", + "NN/56aQz3bnT/ZSHQNciRB8U6jiD9V30t0w+FDTpGaG+7bzzUH3UVF9xf9Ctp60A\n", + "3mfLe0scas7owSt4AEFuj2SPvcE7yvdOXbu+IEv21cEJUVExJAbhvIweHXh6yRW+\n", + "7VVeiNzdIjkZjyTmAzoXGha4+wbxXyBRbfH+XWcO/H+8nwyG8Gktdu2QB9S9nnIp\n", + "o/1TpfOMSGhMyMoyPrk=\n", + "-----END X509 CRL-----\n", + NULL +}; + +/* + * kUnknownCriticalCRL is kBasicCRL but with an unknown critical extension. + */ +static const char *kUnknownCriticalCRL[] = { + "-----BEGIN X509 CRL-----\n", + "MIIBvDCBpQIBATANBgkqhkiG9w0BAQsFADBOMQswCQYDVQQGEwJVUzETMBEGA1UE\n", + "CAwKQ2FsaWZvcm5pYTEWMBQGA1UEBwwNTW91bnRhaW4gVmlldzESMBAGA1UECgwJ\n", + "Qm9yaW5nU1NMFw0xNjA5MjYxNTEwNTVaFw0xNjEwMjYxNTEwNTVaoCMwITAKBgNV\n", + "HRQEAwIBATATBgwqhkiG9xIEAYS3CQABAf8EADANBgkqhkiG9w0BAQsFAAOCAQEA\n", + "GvBP0xqL509InMj/3493YVRV+ldTpBv5uTD6jewzf5XdaxEQ/VjTNe5zKnxbpAib\n", + "Kf7cwX0PMSkZjx7k7kKdDlEucwVvDoqC+O9aJcqVmM6GDyNb9xENxd0XCXja6MZC\n", + "yVgP4AwLauB2vSiEprYJyI1APph3iAEeDm60lTXX/wBM/tupQDDujKh2GPyvBRfJ\n", + "+wEDwGg3ICwvu4gO4zeC5qnFR+bpL9t5tOMAQnVZ0NWv+k7mkd2LbHdD44dxrfXC\n", + "nhtfERx99SDmC/jtUAJrGhtCO8acr7exCeYcduN7KKCm91OeCJKK6OzWst0Og1DB\n", + "kwzzU2rL3G65CrZ7H0SZsQ==\n", + "-----END X509 CRL-----\n", + NULL +}; + +/* + * kUnknownCriticalCRL2 is kBasicCRL but with a critical issuing distribution + * point extension followed by an unknown critical extension + */ +static const char *kUnknownCriticalCRL2[] = { + "-----BEGIN X509 CRL-----\n", + "MIIBzzCBuAIBATANBgkqhkiG9w0BAQsFADBOMQswCQYDVQQGEwJVUzETMBEGA1UE\n", + "CAwKQ2FsaWZvcm5pYTEWMBQGA1UEBwwNTW91bnRhaW4gVmlldzESMBAGA1UECgwJ\n", + "Qm9yaW5nU1NMFw0xNjA5MjYxNTEwNTVaFw0xNjEwMjYxNTEwNTVaoDYwNDAKBgNV\n", + "HRQEAwIBATARBgNVHRwBAf8EBzAFoQMBAf8wEwYMKoZIhvcSBAGEtwkAAQH/BAAw\n", + "DQYJKoZIhvcNAQELBQADggEBACTcpQC8jXL12JN5YzOcQ64ubQIe0XxRAd30p7qB\n", + "BTXGpgqBjrjxRfLms7EBYodEXB2oXMsDq3km0vT1MfYdsDD05S+SQ9CDsq/pUfaC\n", + "E2WNI5p8WircRnroYvbN2vkjlRbMd1+yNITohXYXCJwjEOAWOx3XIM10bwPYBv4R\n", + "rDobuLHoMgL3yHgMHmAkP7YpkBucNqeBV8cCdeAZLuhXFWi6yfr3r/X18yWbC/r2\n", + "2xXdkrSqXLFo7ToyP8YKTgiXpya4x6m53biEYwa2ULlas0igL6DK7wjYZX95Uy7H\n", + "GKljn9weIYiMPV/BzGymwfv2EW0preLwtyJNJPaxbdin6Jc=\n", + "-----END X509 CRL-----\n", + NULL +}; + + +/* + * Glue an array of strings together. Return a BIO and put the string + * into |*out| so we can free it. + */ +static BIO *glue(const char **pem, char **out) +{ + char *dest; + int i; + size_t s = 0; + + /* Glue the strings together. */ + for (i = 0; pem[i] != NULL; ++i) + s += strlen(pem[i]); + dest = *out = OPENSSL_malloc(s + 1); + if (dest == NULL) + return NULL; + for (i = 0; pem[i] != NULL; ++i) + dest += strlen(strcpy(dest, pem[i])); + return BIO_new_mem_buf(*out, s); +} + +/* + * Create a CRL from an array of strings. + */ +static X509_CRL *CRL_from_strings(const char **pem) +{ + char *p; + BIO *b = glue(pem, &p); + X509_CRL *crl = PEM_read_bio_X509_CRL(b, NULL, NULL, NULL); + + OPENSSL_free(p); + BIO_free(b); + return crl; +} + +/* + * Create an X509 from an array of strings. + */ +static X509 *X509_from_strings(const char **pem) +{ + char *p; + BIO *b = glue(pem, &p); + X509 *x = PEM_read_bio_X509(b, NULL, NULL, NULL); + + OPENSSL_free(p); + BIO_free(b); + return x; +} + +/* + * Verify |leaf| certificate (chained up to |root|). |crls| if + * not NULL, is a list of CRLs to include in the verification. It is + * also free'd before returning, which is kinda yucky but convenient. + * Returns a value from X509_V_ERR_xxx or X509_V_OK. + */ +static int verify(X509 *leaf, X509 *root, STACK_OF(X509_CRL) *crls, + unsigned long flags) +{ + X509_STORE_CTX *ctx = X509_STORE_CTX_new(); + X509_STORE *store = X509_STORE_new(); + X509_VERIFY_PARAM *param = X509_VERIFY_PARAM_new(); + STACK_OF(X509) *roots = sk_X509_new_null(); + int status = X509_V_ERR_UNSPECIFIED; + + if (ctx == NULL || store == NULL || param == NULL || roots == NULL) + goto err; + + /* Create a stack; upref the cert because we free it below. */ + X509_up_ref(root); + if (!sk_X509_push(roots, root)) + goto err; + + if (!X509_STORE_CTX_init(ctx, store, leaf, NULL)) + goto err; + X509_STORE_CTX_set0_trusted_stack(ctx, roots); + X509_STORE_CTX_set0_crls(ctx, crls); + X509_VERIFY_PARAM_set_time(param, 1474934400 /* Sep 27th, 2016 */); + X509_VERIFY_PARAM_set_depth(param, 16); + if (flags) + X509_VERIFY_PARAM_set_flags(param, flags); + X509_STORE_CTX_set0_param(ctx, param); + + ERR_clear_error(); + status = X509_verify_cert(ctx) == 1 ? X509_V_OK + : X509_STORE_CTX_get_error(ctx); +err: + sk_X509_pop_free(roots, X509_free); + sk_X509_CRL_pop_free(crls, X509_CRL_free); + X509_STORE_CTX_free(ctx); + X509_STORE_free(store); + return status; +} + +/* + * Create a stack of CRL's. Upref each one because we call pop_free on + * the stack and need to keep the CRL's around until the test exits. + * Yes this crashes on malloc failure; it forces us to debug. + */ +static STACK_OF(X509_CRL) *make_CRL_stack(X509_CRL *x1, X509_CRL *x2) +{ + STACK_OF(X509_CRL) *sk = sk_X509_CRL_new_null(); + + sk_X509_CRL_push(sk, x1); + X509_CRL_up_ref(x1); + if (x2 != NULL) { + sk_X509_CRL_push(sk, x2); + X509_CRL_up_ref(x2); + } + return sk; +} + +static int test_crl() +{ + X509 *root = X509_from_strings(kCRLTestRoot); + X509 *leaf = X509_from_strings(kCRLTestLeaf); + X509_CRL *basic_crl = CRL_from_strings(kBasicCRL); + X509_CRL *revoked_crl = CRL_from_strings(kRevokedCRL); + X509_CRL *bad_issuer_crl = CRL_from_strings(kBadIssuerCRL); + X509_CRL *known_critical_crl = CRL_from_strings(kKnownCriticalCRL); + X509_CRL *unknown_critical_crl = CRL_from_strings(kUnknownCriticalCRL); + X509_CRL *unknown_critical_crl2 = CRL_from_strings(kUnknownCriticalCRL2); + int status = 0; + + if (root == NULL || leaf == NULL || basic_crl == NULL + || revoked_crl == NULL || bad_issuer_crl == NULL + || known_critical_crl == NULL || unknown_critical_crl == NULL + || unknown_critical_crl2 == NULL) { + fprintf(stderr, "Failed to parse certificates and CRLs.\n"); + goto err; + } + + if (verify(leaf, root, make_CRL_stack(basic_crl, NULL), + X509_V_FLAG_CRL_CHECK) != X509_V_OK) { + fprintf(stderr, "Cert with CRL didn't verify.\n"); + goto err; + } + + if (verify(leaf, root, make_CRL_stack(basic_crl, revoked_crl), + X509_V_FLAG_CRL_CHECK) != X509_V_ERR_CERT_REVOKED) { + fprintf(stderr, "Revoked CRL wasn't checked.\n"); + goto err; + } + + if (verify(leaf, root, NULL, + X509_V_FLAG_CRL_CHECK) != X509_V_ERR_UNABLE_TO_GET_CRL) { + fprintf(stderr, "CRLs were not required.\n"); + goto err; + } + + if (verify(leaf, root, make_CRL_stack(bad_issuer_crl, NULL), + X509_V_FLAG_CRL_CHECK) != X509_V_ERR_UNABLE_TO_GET_CRL) { + fprintf(stderr, "Bad CRL issuer was unnoticed.\n"); + goto err; + } + + if (verify(leaf, root, make_CRL_stack(known_critical_crl, NULL), + X509_V_FLAG_CRL_CHECK) != X509_V_OK) { + fprintf(stderr, "CRL with known critical extension was rejected.\n"); + goto err; + } + + if (verify(leaf, root, make_CRL_stack(unknown_critical_crl, NULL), + X509_V_FLAG_CRL_CHECK) != + X509_V_ERR_UNHANDLED_CRITICAL_CRL_EXTENSION) { + fprintf(stderr, "CRL with unknown critical extension was accepted.\n"); + goto err; + } + + if (verify(leaf, root, make_CRL_stack(unknown_critical_crl2, NULL), + X509_V_FLAG_CRL_CHECK) != + X509_V_ERR_UNHANDLED_CRITICAL_CRL_EXTENSION) { + fprintf(stderr, "CRL with unknown critical extension (2) was accepted.\n"); + goto err; + } + + status = 1; + +err: + X509_free(root); + X509_free(leaf); + X509_CRL_free(basic_crl); + X509_CRL_free(revoked_crl); + X509_CRL_free(bad_issuer_crl); + X509_CRL_free(known_critical_crl); + X509_CRL_free(unknown_critical_crl); + X509_CRL_free(unknown_critical_crl2); + return status; +} + +void register_tests(void) +{ + ADD_TEST(test_crl); +} diff --git a/test/recipes/25-test_crl.t b/test/recipes/25-test_crl.t index f708ea8ad9..872138efe8 100644 --- a/test/recipes/25-test_crl.t +++ b/test/recipes/25-test_crl.t @@ -15,10 +15,12 @@ use OpenSSL::Test qw/:DEFAULT srctop_file/; setup("test_crl"); -plan tests => 2; +plan tests => 3; require_ok(srctop_file('test','recipes','tconversion.pl')); subtest 'crl conversions' => sub { tconversion("crl", srctop_file("test","testcrl.pem")); }; + +ok(run(test(['crltest']))); -- 2.25.1