From 2a303a583469f480938459cb5da2ba45f5b59ed2 Mon Sep 17 00:00:00 2001 From: Bodo Moeller Date: Tue, 21 Oct 2014 22:41:07 +0200 Subject: [PATCH] Fix and improve SSL_MODE_SEND_FALLBACK_SCSV documentation. Reviewed-by: Rich Salz --- doc/ssl/SSL_CTX_set_mode.pod | 8 ++++++-- ssl/ssl.h | 9 +++++++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/doc/ssl/SSL_CTX_set_mode.pod b/doc/ssl/SSL_CTX_set_mode.pod index 0bcf5d2afc..2a5aaa555e 100644 --- a/doc/ssl/SSL_CTX_set_mode.pod +++ b/doc/ssl/SSL_CTX_set_mode.pod @@ -71,12 +71,16 @@ SSL_CTX->freelist_max_len, which defaults to 32. Using this flag can save around 34k per idle SSL connection. This flag has no effect on SSL v2 connections, or on DTLS connections. -=item SSL_MODE_FALLBACK_SCSV +=item SSL_MODE_SEND_FALLBACK_SCSV Send TLS_FALLBACK_SCSV in the ClientHello. -To be set by applications that reconnect with a downgraded protocol +To be set only by applications that reconnect with a downgraded protocol version; see draft-ietf-tls-downgrade-scsv-00 for details. +DO NOT ENABLE THIS if your application attempts a normal handshake. +Only use this in explicit fallback retries, following the guidance +in draft-ietf-tls-downgrade-scsv-00. + =back =head1 RETURN VALUES diff --git a/ssl/ssl.h b/ssl/ssl.h index 70aff9dcc3..d7efc5cbc3 100644 --- a/ssl/ssl.h +++ b/ssl/ssl.h @@ -606,8 +606,13 @@ typedef struct ssl_session_st * or just freed (depending on the context's setting for freelist_max_len). */ #define SSL_MODE_RELEASE_BUFFERS 0x00000010L /* Send TLS_FALLBACK_SCSV in the ClientHello. - * To be set by applications that reconnect with a downgraded protocol - * version; see draft-ietf-tls-downgrade-scsv-00 for details. */ + * To be set only by applications that reconnect with a downgraded protocol + * version; see draft-ietf-tls-downgrade-scsv-00 for details. + * + * DO NOT ENABLE THIS if your application attempts a normal handshake. + * Only use this in explicit fallback retries, following the guidance + * in draft-ietf-tls-downgrade-scsv-00. + */ #define SSL_MODE_SEND_FALLBACK_SCSV 0x00000080L /* Note: SSL[_CTX]_set_{options,mode} use |= op on the previous value, -- 2.25.1