From 1ea2301fcfbfc85e38eb51e1144c5ac190c4c320 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Andreas=20Bie=C3=9Fmann?= Date: Thu, 10 Apr 2014 12:52:50 +0200 Subject: [PATCH] board:tricorder: always work with valid eeprom data MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Commit 890880583d84607e36b52a785a96b167728bbf73 introduced EEPROM parsing and board detection but faild to return a valid tricorder_eeprom struct for backup case. When pressing S200 while reading EEPROM we ignore the value. We returned falsely a tricorder_eeprom struct with uninitialized data which is just garbage. Initialize it by zeroing the whole structure. Signed-off-by: Andreas Bießmann Cc: Thomas Weber Signed-off-by: Andreas Bießmann --- board/corscience/tricorder/tricorder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/corscience/tricorder/tricorder.c b/board/corscience/tricorder/tricorder.c index 2dfcb271d3..9e81bf3f3f 100644 --- a/board/corscience/tricorder/tricorder.c +++ b/board/corscience/tricorder/tricorder.c @@ -79,6 +79,8 @@ static void get_eeprom(struct tricorder_eeprom *eeprom) } else { panic("Could not get board revision\n"); } + } else { + memset(eeprom, 0, TRICORDER_EEPROM_SIZE); } } -- 2.25.1