From 1aa258c4f912b0e368ee9ff922b19b8f80940487 Mon Sep 17 00:00:00 2001 From: "Schanzenbach, Martin" Date: Thu, 17 Oct 2019 17:07:05 +0200 Subject: [PATCH] some comments --- src/include/gnunet_reclaim_attribute_lib.h | 6 ++++++ src/include/gnunet_reclaim_attribute_plugin.h | 10 ++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/include/gnunet_reclaim_attribute_lib.h b/src/include/gnunet_reclaim_attribute_lib.h index 34429da51..8476e77fc 100644 --- a/src/include/gnunet_reclaim_attribute_lib.h +++ b/src/include/gnunet_reclaim_attribute_lib.h @@ -348,6 +348,12 @@ GNUNET_RECLAIM_ATTRIBUTE_number_to_typename (uint32_t type); /** * Get required size for serialization buffer + * FIXME: + * 1. The naming convention is violated here. + * It should GNUNET_RECLAIM_ATTRIBUTE_. + * It might make sense to refactor attestations into a separate folder. + * 2. The struct should be called GNUNET_RECLAIM_ATTESTATION_Data or + * GNUNET_RECLAIM_ATTRIBUTE_Attestation depending on location in source. * * @param attr the attestation to serialize * @return the required buffer size diff --git a/src/include/gnunet_reclaim_attribute_plugin.h b/src/include/gnunet_reclaim_attribute_plugin.h index bdd815dcf..e61cca5b2 100644 --- a/src/include/gnunet_reclaim_attribute_plugin.h +++ b/src/include/gnunet_reclaim_attribute_plugin.h @@ -136,8 +136,14 @@ struct GNUNET_RECLAIM_ATTRIBUTE_PluginFunctions GNUNET_RECLAIM_ATTRIBUTE_NumberToTypenameFunction number_to_typename; /** -* Attestation Conversion to string. -*/ + * FIXME: It is odd that attestation functions are withing the attribute + * plugin. An attribute type may be backed by an attestation, but not + * necessarily. + * Maybe it would make more sense to refactor this into an attestation + * plugin? + * + * Attestation Conversion to string. + */ GNUNET_RECLAIM_ATTRIBUTE_ValueToStringFunction value_to_string_attest; /** -- 2.25.1