From 13b2945a3c3de7c309ca2e44ab4cf76236ff1fdb Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Sun, 13 May 2012 17:20:01 -0400 Subject: [PATCH] remove some no-op end of string tests from regex parser these are cruft from the original code which used an explicit string length rather than null termination. i blindly converted all the checks to null terminator checks, without noticing that in several cases, the subsequent switch statement would automatically handle the null byte correctly. --- src/regex/regcomp.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/regex/regcomp.c b/src/regex/regcomp.c index 712ca80d..322a5e67 100644 --- a/src/regex/regcomp.c +++ b/src/regex/regcomp.c @@ -1052,8 +1052,6 @@ tre_parse(tre_parse_ctx_t *ctx) } case PARSE_UNION: - if (!*ctx->re) - break; switch (*ctx->re) { case CHAR_PIPE: @@ -1086,8 +1084,6 @@ tre_parse(tre_parse_ctx_t *ctx) case PARSE_POSTFIX: /* Parse postfix operators. */ - if (!*ctx->re) - break; switch (*ctx->re) { case CHAR_PLUS: -- 2.25.1