From 099e2968ed3c7d256cda048995626664082b1b30 Mon Sep 17 00:00:00 2001 From: Kazuki Yamaguchi Date: Mon, 22 Aug 2016 02:36:36 +0900 Subject: [PATCH] Fix overflow check in BN_bn2dec() Fix an off by one error in the overflow check added by 07bed46f332fc ("Check for errors in BN_bn2dec()"). Reviewed-by: Stephen Henson Reviewed-by: Matt Caswell --- crypto/bn/bn_print.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/crypto/bn/bn_print.c b/crypto/bn/bn_print.c index f6030ff14c..e5f641b99d 100644 --- a/crypto/bn/bn_print.c +++ b/crypto/bn/bn_print.c @@ -92,14 +92,13 @@ char *BN_bn2dec(const BIGNUM *a) if (BN_is_negative(t)) *p++ = '-'; - i = 0; while (!BN_is_zero(t)) { + if (lp - bn_data >= bn_data_num) + goto err; *lp = BN_div_word(t, BN_DEC_CONV); if (*lp == (BN_ULONG)-1) goto err; lp++; - if (lp - bn_data >= bn_data_num) - goto err; } lp--; /* -- 2.25.1