Don't set client_version to the ServerHello version.
authorAdam Langley <agl@google.com>
Sat, 13 Dec 2014 20:13:10 +0000 (20:13 +0000)
committerMatt Caswell <matt@openssl.org>
Tue, 16 Dec 2014 14:44:17 +0000 (14:44 +0000)
commitec1af3c4195c1dfecdd9dc7458850ab1b8b951e0
treeb4dad2b996207a34a70e23c9429c8879ed671045
parentdb812f2d70f0695fd53b386fe5e870bef8ca3c22
Don't set client_version to the ServerHello version.

The client_version needs to be preserved for the RSA key exchange.

This change also means that renegotiation will, like TLS, repeat the old
client_version rather than advertise only the final version. (Either way,
version change on renego is not allowed.) This is necessary in TLS to work
around an SChannel bug, but it's not strictly necessary in DTLS.

(From BoringSSL)

Reviewed-by: Emilia Käsper <emilia@openssl.org>
ssl/s3_clnt.c