Fix ssl_get_prev_session overrun
authorMatt Caswell <matt@openssl.org>
Fri, 10 Apr 2015 15:49:33 +0000 (16:49 +0100)
committerMatt Caswell <matt@openssl.org>
Tue, 14 Apr 2015 13:58:49 +0000 (14:58 +0100)
commit5e0a80c1c9b2b06c2d203ad89778ce1b98e0b5ad
treeb994284ef7d303eaf4d174a2426082a6bf1d1cb9
parent5e9f0eebcfa25a55177d9a7025713262367bec14
Fix ssl_get_prev_session overrun

If OpenSSL is configured with no-tlsext then ssl_get_prev_session can read
past the end of the ClientHello message if the session_id length in the
ClientHello is invalid. This should not cause any security issues since the
underlying buffer is 16k in size. It should never be possible to overrun by
that many bytes.

This is probably made redundant by the previous commit - but you can never be
too careful.

With thanks to Qinghao Tang for reporting this issue.

Reviewed-by: Rich Salz <rsalz@openssl.org>
ssl/ssl_sess.c