Richard Levitte [Thu, 11 Dec 2003 18:01:06 +0000 (18:01 +0000)]
To figure out if we're going outside the buffer, use the size of the buffer,
not the size of the integer used to index in said buffer.
PR: 794
Notified by: Rhett Garber <rhett_garber@hp.com>
Richard Levitte [Wed, 10 Dec 2003 14:31:57 +0000 (14:31 +0000)]
Document that you need to include x509.h (to get [i2d|d2i]_RSA_PUBKEY()).
Correct the typo PUKEY...
Richard Levitte [Wed, 10 Dec 2003 13:57:52 +0000 (13:57 +0000)]
Document that you need to include x509.h (to get [i2d|d2i]_DSA_PUBKEY()).
Correct the typo PUKEY...
Lutz Jänicke [Wed, 3 Dec 2003 16:29:16 +0000 (16:29 +0000)]
Restructure make targets to allow parallel make.
Submitted by: Witold Filipczyk <witekfl@poczta.gazeta.pl>
PR: #513
Richard Levitte [Mon, 1 Dec 2003 13:25:39 +0000 (13:25 +0000)]
It was pointed out to me that if the requested size is 0, we shouldn't
ty to allocate anything at all. This will allow eNULL to still work.
PR: 751
Notified by: Lutz Jaenicke
Richard Levitte [Mon, 1 Dec 2003 12:11:57 +0000 (12:11 +0000)]
Check that OPENSSL_malloc() really returned some memory.
PR: 751
Notified by: meder@mcs.anl.gov
Reviewed by: Lutz Jaenicke, Richard Levitte
Richard Levitte [Mon, 1 Dec 2003 12:06:19 +0000 (12:06 +0000)]
CRYPTO_malloc(), CRYPTO_realloc() and variants of them should return NULL
if the give size is 0.
This is a thought that came up in PR 751.
Lutz Jänicke [Mon, 1 Dec 2003 08:12:01 +0000 (08:12 +0000)]
Some more ASFLAGS settings required
PR: #735
Submitted by: Tim Rice <tim@multitalents.net>
Richard Levitte [Sat, 29 Nov 2003 10:33:28 +0000 (10:33 +0000)]
Make sure the documentation matches reality.
PR: 755
Notified by: Jakub Bogusz <qboosh@pld-linux.org>
Richard Levitte [Sat, 29 Nov 2003 10:25:42 +0000 (10:25 +0000)]
We're getting a clash with C++ because it has a type called 'list'.
Therefore, change all instances of the symbol 'list' to something else.
PR: 758
Submitted by: Frédéric Giudicelli <groups@newpki.org>
Richard Levitte [Fri, 28 Nov 2003 23:03:19 +0000 (23:03 +0000)]
RSA_size() and DH_size() return the amount of bytes in a key, and we
compared it to the amount of bits required...
PR: 770
Submitted by: c zhang <czhang2005@hotmail.com>
Richard Levitte [Fri, 28 Nov 2003 22:39:23 +0000 (22:39 +0000)]
1024 is the export key bits limit according to current regulations, not 512.
PR: 771
Submitted by: c zhang <czhang2005@hotmail.com>
Richard Levitte [Fri, 28 Nov 2003 14:51:17 +0000 (14:51 +0000)]
Make a number of changes to the OS/2 build. Submitter's comment below.
PR: 732
Submitted by: Ilya Zakharevich <nospam-abuse@ilyaz.org>
Submitter's comment:
This patch:
a) Introduces a new file os2/backwardify.pl.
b) Introduces a new mk1mf.pl variable $preamble. As you can see, it may
be used also to move some OS-specific code to VC-CE too (the the
first chunk of the patch);
c) The DESCRIPTION specifier of the .def file is made more informative:
now it contains the version number too. On OS/2 it is made conformant
to OS/2 conventions; in particular, when one runs the standard command
BLDLEVEL this.DLL
one can see:
Vendor: www.openssl.org/
Revision: 0.9.7c
Description: OpenSSL: implementation of Secure Socket Layer; DLL for library crypto. Build for EMX -Zmtd
[I did not make Win32 descriptions as informative as this - I'm afraid to
break something. Be welcome to fix this.]
d) On OS/2 the generated DLL was hardly usable (it had a shared initialized
data segment).
e) On OS/2 the generated DLLs had names like ssl.dll. However, DLL names on
OS/2 are "global data". It is hard to have several DLLs with the same
name on the system. Thus this precluded coexistence of OpenSSL with DLLs
for other SLL implementations - or other name clashes. I transparently
changed the names of the DLLs to open_ssl.dll and cryptssl.dll.
f) The file added in (a) is used to create "forwarder" DLLs, so the
applications expecting the "old" DLL names may use the new DLLs
transparently. (A presence of these DLLs on the system nullifies (e),
but makes old applications work. This is a stopgap measure until the
old applications are relinked. Systems with no old applications do not
need these DLLs, so may enjoy all the benefits of (e).)
The new DLLs are placed in os2/ and os2/noname subdirectories.
g) The makefiles created with os2/OS2-EMX.cmd did not work (some mysterious
meaningless failures). The change to util/pl/OS2-EMX.pl uses the
variable introduced in (b) to switch the Makefiles to SHELL=sh syntax.
All these backslashes are removed, and the generated Makefiles started to
work.
h) Running os2/OS2-EMX.cmd now prints out what to do next.
Richard Levitte [Fri, 28 Nov 2003 14:32:35 +0000 (14:32 +0000)]
Let's use text/plain in the example instead of crapy HTML.
PR: 777
Submitted by: Michael Shields <mshields@sunblocksystems.com>
Richard Levitte [Thu, 27 Nov 2003 16:41:26 +0000 (16:41 +0000)]
If dynamically-loadable ENGINEs are linked against a shared-library version
of libcrypto, then it is possible that when they are loaded they will share
the same static data as the loading application/library. This means it will
be too late to set memory/ERR/ex_data/[etc] callbacks, but entirely
unnecessary to try.
This change (and a great part of this comment) was implemented in
0.9.8-dev a long time ago, but slightly differently. In 0.9.8-dev, a
specific function that just returns a pointer to some static object is
used. For 0.9.7x, we couldn't do that, since the way we handle feature
freezes is, among other, to not add any more non-static functions.
Instead, we use the function ERR_get_implementation() and compare the
returned value with fns->err_fns, a member of fns that already is
there, and which therefore can safely be used in this manner.
What happens is that if the loaded ENGINE's return value from this
function matches the loading application/library's return value - they
share static data. If they don't match, the loaded ENGINE has its own
copy of libcrypto's static data and so the callbacks need to be set.
Lutz Jänicke [Mon, 24 Nov 2003 16:47:44 +0000 (16:47 +0000)]
Free "engine" resource in case of failure to prevent memory leak
PR: #778
Submitted by: George Mitchell <george@m5p.com>
Ulf Möller [Sat, 22 Nov 2003 10:42:33 +0000 (10:42 +0000)]
bn_sub_part_words() is unused in 0.9.7.
Spotted by Markus Friedl.
Dr. Stephen Henson [Thu, 20 Nov 2003 22:43:28 +0000 (22:43 +0000)]
Give CRLDP its standard name.
Max req -x509 use V1 if extensions section absent.
Geoff Thorpe [Wed, 19 Nov 2003 05:18:54 +0000 (05:18 +0000)]
Remove duplicate prototypes have already been (correctly) added to rsa.h,
as this is already included by x509.h anyway.
Lutz Jänicke [Tue, 18 Nov 2003 18:26:32 +0000 (18:26 +0000)]
Make sure to initialize AES counters to obtain proper results.
Submitted by: Kirill Kochetkov <kochet@ixbt.com>
PR: #748
Lutz Jänicke [Sun, 16 Nov 2003 16:31:22 +0000 (16:31 +0000)]
Catch error condition to prevent NULL pointer dereference.
Submitted by: Goetz Babin-Ebell <babin-ebell@trustcenter.de>
PR: #766
Lutz Jänicke [Sun, 16 Nov 2003 14:37:48 +0000 (14:37 +0000)]
Provide ASFLAGS in the subdirectories handling assembler code.
Submitted by: Tim Rice <tim@multitalents.net>
PR: #735, #765
Dr. Stephen Henson [Mon, 10 Nov 2003 01:29:27 +0000 (01:29 +0000)]
Oops!
Dr. Stephen Henson [Mon, 10 Nov 2003 01:25:11 +0000 (01:25 +0000)]
Print out GeneralizedTime and UTCTime in ASN1_STRING_print_ex().
Richard Levitte [Wed, 29 Oct 2003 06:21:25 +0000 (06:21 +0000)]
Removing those memcpy()s also took away the possibility for in and out to
be the same. Therefore, the removed memcpy()s need to be restored.
Richard Levitte [Wed, 15 Oct 2003 09:00:18 +0000 (09:00 +0000)]
Correct serious bug in AES-CBC decryption when the message length isn't
a multiple of AES_BLOCK_SIZE.
Optimize decryption of all complete blocks in AES-CBC by removing an
unnecessary memcpy().
The error was notified by James Fernandes <jf210032@exchange.DAYTONOH.NCR.com>.
The unnecessary memcpy() was found as an effect of investigating that error.
Dr. Stephen Henson [Sat, 11 Oct 2003 16:47:44 +0000 (16:47 +0000)]
Simplify cipher and digest lookup in PKCS#7 code.
Dr. Stephen Henson [Fri, 10 Oct 2003 23:24:10 +0000 (23:24 +0000)]
Retrieve correct content to sign when the
type is "other".
Richard Levitte [Tue, 7 Oct 2003 12:09:42 +0000 (12:09 +0000)]
In realloc, don't destroy the old memory area if a new one couldn't be
allocated.
Notified by Daniel Lucq <daniel@lucq.org>
Richard Levitte [Thu, 2 Oct 2003 10:41:50 +0000 (10:41 +0000)]
Check for errors from SSL_COMP_add_compression_method().
Notified by Andrew Marlow <AMARLOW1@bloomberg.net>
Richard Levitte [Thu, 2 Oct 2003 10:38:46 +0000 (10:38 +0000)]
Correct a mixup of return values
Richard Levitte [Wed, 1 Oct 2003 20:41:49 +0000 (20:41 +0000)]
Include e_os.h to get a proper definition for memmove() for the
platforms that don't have it.
Richard Levitte [Wed, 1 Oct 2003 15:04:15 +0000 (15:04 +0000)]
Remove leading and trailing spaces and tabs
Richard Levitte [Wed, 1 Oct 2003 15:03:18 +0000 (15:03 +0000)]
Avoid 'file names' with spaces
Richard Levitte [Wed, 1 Oct 2003 15:02:48 +0000 (15:02 +0000)]
Use correct case for manual page references
Richard Levitte [Tue, 30 Sep 2003 17:31:50 +0000 (17:31 +0000)]
Correct incorrect mode bits change.
Richard Levitte [Tue, 30 Sep 2003 17:22:21 +0000 (17:22 +0000)]
Correct buggy PODs (missing commas and a prepended space).
Dr. Stephen Henson [Tue, 30 Sep 2003 13:10:48 +0000 (13:10 +0000)]
In order to get the expected self signed error when
calling X509_verify_cert() in x509.c the cert should
not be added to the trusted store.
Dr. Stephen Henson [Tue, 30 Sep 2003 12:08:23 +0000 (12:08 +0000)]
Changes for release
Dr. Stephen Henson [Tue, 30 Sep 2003 12:05:44 +0000 (12:05 +0000)]
Fix for ASN1 parsing bugs.
Dr. Stephen Henson [Mon, 29 Sep 2003 20:17:37 +0000 (20:17 +0000)]
make update
Dr. Stephen Henson [Mon, 29 Sep 2003 17:10:01 +0000 (17:10 +0000)]
Fix to make it compile under Win32.
Richard Levitte [Sun, 28 Sep 2003 14:07:01 +0000 (14:07 +0000)]
Further VxWorks changes from Bob Bradley <bob@chaoticsoftware.com>, this
time involving VxWorks on MIPS
Richard Levitte [Sun, 28 Sep 2003 09:25:33 +0000 (09:25 +0000)]
make update
Richard Levitte [Sun, 28 Sep 2003 07:11:37 +0000 (07:11 +0000)]
Uhmm, It seem to have forgotten one file when I committed the MSDOS
change yesterday.
PR: 669
Richard Levitte [Sat, 27 Sep 2003 22:48:36 +0000 (22:48 +0000)]
Change the indentation from 12 to indent+4.
PR: 657
Richard Levitte [Sat, 27 Sep 2003 22:14:47 +0000 (22:14 +0000)]
Make MD5 assembler code able to handle messages larger than 2GB on 32-bit
systems and above.
PR: 664
Richard Levitte [Sat, 27 Sep 2003 21:56:12 +0000 (21:56 +0000)]
Selected changes for MSDOS, contributed by Gisle Vanem <giva@bgnett.no>.
PR: 669
Richard Levitte [Sat, 27 Sep 2003 20:29:11 +0000 (20:29 +0000)]
Add reference counting around the thread state hash table.
Unfortunately, this means that the dynamic ENGINE version just went up, and
isn't backward compatible.
PR: 678
Richard Levitte [Sat, 27 Sep 2003 19:32:09 +0000 (19:32 +0000)]
Have ssl3_ssl3_send_client_verify() change the state to SSL3_ST_SW_CERT_VRFY_B.
PR: 679
Richard Levitte [Sat, 27 Sep 2003 19:27:09 +0000 (19:27 +0000)]
Have ssl3_send_certificate_request() change the state to SSL3_ST_SW_CERT_REQ_B.
PR: 680
Richard Levitte [Sat, 27 Sep 2003 18:31:41 +0000 (18:31 +0000)]
Remove extra argument to BIO_printf().
PR: 685
Richard Levitte [Sat, 27 Sep 2003 17:55:18 +0000 (17:55 +0000)]
Include the instance in the Kerberos ticket information.
In s_server, print the received Kerberos information.
PR: 693
Richard Levitte [Sat, 27 Sep 2003 10:39:19 +0000 (10:39 +0000)]
Correct small documentation error.
PR: 698
Richard Levitte [Sat, 27 Sep 2003 07:33:28 +0000 (07:33 +0000)]
Free the Kerberos context upon freeing the SSL.
Contributed by Andrew Mann <amann@tccgi.com>
Richard Levitte [Sat, 27 Sep 2003 07:24:47 +0000 (07:24 +0000)]
Add necessary changes to be able to build on VxWorks for PPC860.
Contributed by Bob Bradley <bob@chaoticsoftware.com>
Dr. Stephen Henson [Sun, 21 Sep 2003 02:15:07 +0000 (02:15 +0000)]
In order to get the expected self signed error when
calling X509_verify_cert() in x509.c the cert should
not be added to the trusted store.
Geoff Thorpe [Mon, 8 Sep 2003 16:00:46 +0000 (16:00 +0000)]
These should be write-locks, not read-locks.
Bodo Möller [Thu, 4 Sep 2003 12:52:10 +0000 (12:52 +0000)]
certain changes have to be listed twice in this file because OpenSSL
0.9.6h forked into 0.9.6i and 0.9.7 ...
Dr. Stephen Henson [Wed, 3 Sep 2003 23:54:00 +0000 (23:54 +0000)]
New -ignore_err option in ocsp application to stop the server
exiting on the first error in a request.
Dr. Stephen Henson [Wed, 3 Sep 2003 23:42:17 +0000 (23:42 +0000)]
Only accept a client certificate if the server requests
one, as required by SSL/TLS specs.
Dr. Stephen Henson [Thu, 21 Aug 2003 12:31:17 +0000 (12:31 +0000)]
outlen should be int * in out_utf8.
Bodo Möller [Thu, 14 Aug 2003 10:33:26 +0000 (10:33 +0000)]
fix out-of-bounds check in lock_dbg_cb (was too lose to detect all
invalid cases)
PR: 674
Richard Levitte [Thu, 14 Aug 2003 06:54:29 +0000 (06:54 +0000)]
Undo the change that left LD_LIBRARY_PATH unchanged. The errors I saw
weren't due to that, but to a change on the SCO machines I used for
testing, where my $PATH was suddenly incorrect.
Bodo Möller [Mon, 11 Aug 2003 18:56:19 +0000 (18:56 +0000)]
make sure no error is left in the queue that is intentionally ignored
Richard Levitte [Mon, 11 Aug 2003 11:46:01 +0000 (11:46 +0000)]
Don't fiddle with LD_LIBRARY_PATH when building non-static.
Richard Levitte [Mon, 11 Aug 2003 09:56:17 +0000 (09:56 +0000)]
Oops, removed a little too much.
Richard Levitte [Mon, 11 Aug 2003 09:53:24 +0000 (09:53 +0000)]
make update
Richard Levitte [Mon, 11 Aug 2003 09:37:17 +0000 (09:37 +0000)]
A new branch for FIPS-related changes has been created with the name
OpenSSL-fips-0_9_7-stable.
Since the 0.9.7-stable branch is supposed to be in freeze and should
only contain bug corrections, this change removes the FIPS changes
from that branch.
Richard Levitte [Fri, 8 Aug 2003 10:08:14 +0000 (10:08 +0000)]
Avoid clashing with the regular DES functions when not compiling with
-DFIPS. This is basically only visible when building with shared
library supoort...
Richard Levitte [Thu, 7 Aug 2003 11:57:21 +0000 (11:57 +0000)]
Correct two problems, found by Martin Kochanski <cardbox@easynet.co.uk>:
1. CreateToolhelp32Snapshot returns INVALID_HANDLE_VALUE, not NULL, on error.
2. On Windows CE, a snapshot handle is closed with CloseToolhelp32Snapshot,
not CloseHandle.
Bodo Möller [Wed, 6 Aug 2003 10:38:37 +0000 (10:38 +0000)]
add OpenSSL license
fix typo
Richard Levitte [Mon, 4 Aug 2003 13:26:14 +0000 (13:26 +0000)]
make update
(I'm quite worried about what this will do to compatibility with
earlier 0.9.7 versions)
Richard Levitte [Mon, 4 Aug 2003 12:03:56 +0000 (12:03 +0000)]
Add an empty list of AES tests. At least, the test suite will pass,
and perhaps the conflict this generates on the person that hasn't yet
committed the real file will prompt him to do so :-).
Richard Levitte [Mon, 4 Aug 2003 10:12:38 +0000 (10:12 +0000)]
Inclusion of openssl/engine.h should always be wrapped with a check that
OPENSSL_NO_ENGINE is not defined.
Ben Laurie [Sun, 3 Aug 2003 12:22:35 +0000 (12:22 +0000)]
Make tests work (CFB1 still doesn't produce the right answers, strangely).
Dr. Stephen Henson [Fri, 1 Aug 2003 17:06:48 +0000 (17:06 +0000)]
Make the EFB NIDs have empty OIDs aliased to the real EFB OID.
Dr. Stephen Henson [Fri, 1 Aug 2003 13:07:29 +0000 (13:07 +0000)]
Replace C++ style comments.
Ben Laurie [Fri, 1 Aug 2003 10:31:25 +0000 (10:31 +0000)]
DES CFB8 test.
Ben Laurie [Fri, 1 Aug 2003 10:25:58 +0000 (10:25 +0000)]
Fix DES CFB-r.
Richard Levitte [Thu, 31 Jul 2003 21:41:51 +0000 (21:41 +0000)]
No C++ comments in C programs!
Richard Levitte [Thu, 31 Jul 2003 21:30:07 +0000 (21:30 +0000)]
If FDIRS is to be treated like SDIRS, let's not forget to initialize
it in Makefile.org.
Ben Laurie [Wed, 30 Jul 2003 18:30:18 +0000 (18:30 +0000)]
Whoops, forgot FIPS DES, also add EVPs for DES CFB1 and 8.
Ben Laurie [Tue, 29 Jul 2003 17:53:41 +0000 (17:53 +0000)]
Test vectors and useless samples.
Ben Laurie [Tue, 29 Jul 2003 17:05:16 +0000 (17:05 +0000)]
AES CFB8.
Ben Laurie [Tue, 29 Jul 2003 15:17:22 +0000 (15:17 +0000)]
Missing files.
Ben Laurie [Tue, 29 Jul 2003 14:34:48 +0000 (14:34 +0000)]
MMT for CFB1
Ben Laurie [Tue, 29 Jul 2003 14:06:02 +0000 (14:06 +0000)]
Reformat.
Ben Laurie [Tue, 29 Jul 2003 13:24:27 +0000 (13:24 +0000)]
The rest of the keysizes for CFB1, working AES AVS test for CFB1.
Ben Laurie [Tue, 29 Jul 2003 10:56:56 +0000 (10:56 +0000)]
Working CFB1 and test vectors.
Ben Laurie [Mon, 28 Jul 2003 15:08:00 +0000 (15:08 +0000)]
Add support for partial CFB modes, make tests work, update dependencies.
Ben Laurie [Mon, 28 Jul 2003 09:56:08 +0000 (09:56 +0000)]
New fingerprints.
Ben Laurie [Sun, 27 Jul 2003 21:13:35 +0000 (21:13 +0000)]
Build when not FIPS.
Ben Laurie [Sun, 27 Jul 2003 17:23:08 +0000 (17:23 +0000)]
Build in non-FIPS mode.
Ben Laurie [Sun, 27 Jul 2003 17:19:28 +0000 (17:19 +0000)]
Use unified diff.
Ben Laurie [Sun, 27 Jul 2003 17:00:51 +0000 (17:00 +0000)]
Unfinished FIPS stuff for review/improvement.
Ben Laurie [Sun, 27 Jul 2003 13:46:57 +0000 (13:46 +0000)]
Add untested CFB-r mode. Will be tested soon.
Bodo Möller [Mon, 21 Jul 2003 15:17:49 +0000 (15:17 +0000)]
tolerate extra data at end of client hello for SSL 3.0
PR: 659
Bodo Möller [Mon, 21 Jul 2003 15:08:03 +0000 (15:08 +0000)]
fix: 0.9.7 is based on 0.9.6h, not on 0.9.6k
typo in 0.9.6k section
Richard Levitte [Fri, 4 Jul 2003 11:41:15 +0000 (11:41 +0000)]
Make sure openssl.pc is readable by everyone.
PR: 654