Ulrich Wilkens [Wed, 28 Aug 2013 18:07:21 +0000 (20:07 +0200)]
dtinfo subdirectory dtinfogen
Ulrich Wilkens [Wed, 28 Aug 2013 17:45:57 +0000 (19:45 +0200)]
dtinfo subdirectory dtinfo
Ulrich Wilkens [Wed, 28 Aug 2013 17:16:37 +0000 (19:16 +0200)]
dtinfo subdirectory DtMmdb
Ulrich Wilkens [Sun, 25 Aug 2013 19:40:32 +0000 (21:40 +0200)]
Remove installation of motif man pages.
Pascal Stumpf [Tue, 6 Aug 2013 12:21:48 +0000 (14:21 +0200)]
dtlp: Fix the path to DtFuncs.dtsh if CDE_INSTALLATION_TOP != /usr/dt.
While here, also point the man page to the correct default location.
Ulrich Wilkens [Mon, 29 Jul 2013 23:47:52 +0000 (01:47 +0200)]
avoid identical Vector instantiations.
Pascal Stumpf [Thu, 25 Jul 2013 10:28:33 +0000 (12:28 +0200)]
dtlogin: correct path to getty.
Ulrich Wilkens [Wed, 24 Jul 2013 23:09:25 +0000 (01:09 +0200)]
lib/DtHelp: added missing include.
Pascal Stumpf [Tue, 23 Jul 2013 22:55:59 +0000 (00:55 +0200)]
include unistd.h for read(2) prototype. Fixes dtdocbook on PowerPC.
There are a lot more warnings here, but this one was an actual bug. Full
treatment pending ...
Pascal Stumpf [Tue, 23 Jul 2013 21:19:16 +0000 (23:19 +0200)]
Make dtksh build on OpenBSD/powerpc.
Pascal Stumpf [Tue, 23 Jul 2013 20:32:35 +0000 (22:32 +0200)]
OpenBSD.cf: don't include xorg.cf (leftover)
Pascal Stumpf [Tue, 23 Jul 2013 11:49:26 +0000 (13:49 +0200)]
ttsnoop: deal with iostream.h and missing sentinels.
Replacing strstream may be possible, but requires more work and a better
understanding of the code.
Pascal Stumpf [Tue, 23 Jul 2013 11:21:51 +0000 (13:21 +0200)]
Kill iostream.h deprecation warnings on *BSD.
Pascal Stumpf [Mon, 22 Jul 2013 22:59:23 +0000 (00:59 +0200)]
SECURITY fix for dtappintegrate: Use mktemp(1) to generate a template.
Using a fixed filename in /tmp is just begging for a symlink attack ...
Pascal Stumpf [Mon, 22 Jul 2013 22:19:04 +0000 (00:19 +0200)]
error.ds.src: don't hardcode /usr/dt
Pascal Stumpf [Mon, 22 Jul 2013 21:39:13 +0000 (23:39 +0200)]
Adapt dtlogin/config/_common.ksh.src for OpenBSD:
* ps(1) is totally different on BSD and Linux. The OSF commandline works fine.
* fontpath is in /usr/X11R6 on OpenBSD.
Pascal Stumpf [Mon, 22 Jul 2013 20:03:34 +0000 (22:03 +0200)]
Simplify programs/Imakefile a bit. dtksh, dtlogin and dtcm build everywhere.
Pascal Stumpf [Mon, 22 Jul 2013 20:14:45 +0000 (22:14 +0200)]
s,/usr/dt,CDE_INSTALLATION_TOP,g in dtlogin/config
Pascal Stumpf [Mon, 22 Jul 2013 19:59:15 +0000 (21:59 +0200)]
Xreset.src: Do not hardcode /usr/dt.
Pascal Stumpf [Mon, 22 Jul 2013 19:56:37 +0000 (21:56 +0200)]
Do not hardcode /usr/dt in print.dt.
Pascal Stumpf [Mon, 22 Jul 2013 16:44:04 +0000 (18:44 +0200)]
Silence lots of warnings in lib/DtHelp.
* 64bit warnings
* Missing prototypes
* explicit parentheses / brackets
There's still some work to be done, but, as always, it's a start ...
Pascal Stumpf [Mon, 22 Jul 2013 12:31:46 +0000 (14:31 +0200)]
kill a few more warnings in DtPrint
Pascal Stumpf [Mon, 22 Jul 2013 11:38:58 +0000 (13:38 +0200)]
sync warning flags betseen cc and c++ on OpenBSD
Pascal Stumpf [Mon, 22 Jul 2013 11:07:00 +0000 (13:07 +0200)]
Do not use -fpermissive in programs/nsgmls. It's not needed.
Pascal Stumpf [Mon, 22 Jul 2013 10:34:15 +0000 (12:34 +0200)]
Kill most warnings in lib/DtTerm.
Mostly missing headers, explicit parentheses and new prototypes.
Some Caveats:
* I haven't compile-tested the SVR4 getpty file, it might need another tweak
* There were operator precedence bugs in TermPrimCursor.c and TermPrimRender.c
(^ vs. !=). This might change behaviour, but at least I haven't experienced
any crashes ...
* This adds a little more dependencies for include ordering, but unless we
want to play the "headers that include headers that include headers..." game,
this is unavoidable.
Pascal Stumpf [Sun, 21 Jul 2013 20:55:09 +0000 (22:55 +0200)]
Kill lots of warnings in DtSvc.
alx [Mon, 24 Jun 2013 20:29:19 +0000 (22:29 +0200)]
dticon: fixed "rubber string" drawing on high/true color displays
Jon Trulson [Thu, 30 May 2013 21:20:09 +0000 (15:20 -0600)]
update for 2.2.0d release
Jon Trulson [Thu, 30 May 2013 21:11:21 +0000 (15:11 -0600)]
update for release
Peter Howkins [Thu, 30 May 2013 15:08:58 +0000 (16:08 +0100)]
Update date in copyright (and splash screen)
Ulrich Wilkens [Tue, 28 May 2013 22:30:06 +0000 (00:30 +0200)]
Fix screen locking for BSDs
Jon Trulson [Tue, 28 May 2013 01:34:08 +0000 (19:34 -0600)]
Revert "Enable the use of the TIRPC library on Linux."
This reverts commit
8a8619bfa8a25342d898d2cc4decd7bb66b9c060.
More work will need to be done to use tirpc on 64bit systems. It
works 'accidentally' on 32b systems. The issue is that tirpc
includes *must* be used, and there is some work required to properly
support this (like proper include paths, proper definition of XDR,
etc).
So for now, we revert this until that work can be completed and tested,
otherwise 64b linux builds are likely to have problems.
alx [Mon, 27 May 2013 00:13:27 +0000 (02:13 +0200)]
Enable X11 screen saver extension on Linux
Jon Trulson [Sun, 26 May 2013 23:50:12 +0000 (17:50 -0600)]
Merge branch 'master' into multi-monitor
Jon Trulson [Sun, 26 May 2013 23:48:55 +0000 (17:48 -0600)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Jon Trulson [Sun, 26 May 2013 23:47:00 +0000 (17:47 -0600)]
Enable the use of the TIRPC library on Linux.
This should avoid the need to run rpcbind in insecure mode. You will
need to have the libtirpc-dev package, or equivalent installed.
Peter Howkins [Mon, 20 May 2013 14:53:44 +0000 (15:53 +0100)]
dtstyle: Sort color palette names into alphabetical order for displaying.
Jon Trulson [Sat, 18 May 2013 05:22:33 +0000 (23:22 -0600)]
dtksh: fix a build issue with Kubuntu x86_64.
Remove an apparently unnecessary 'mac' definition for feature/fs and
an unnecessary struct stat forward declaration.
Jon Trulson [Sat, 18 May 2013 05:55:51 +0000 (23:55 -0600)]
Merge branch 'master' into multi-monitor
Jon Trulson [Sat, 18 May 2013 05:22:33 +0000 (23:22 -0600)]
dtksh: fix a build issue with Kubuntu x86_64.
Remove an apparently 'mac' definition for feature/fs and an
unnecessary struct stat forward declaration.
Jon Trulson [Fri, 17 May 2013 22:16:17 +0000 (16:16 -0600)]
TT RPC server: Don't search 538 million transients trying to allocate one.
Currently, mp_rpc_server.C tries 538 million ports to acquire an
available transient rpcbind port number. This is bad when rpcbind is
running in secure mode (and you are not using tirpc) - Xsession will
'hang' at the dthello (blue) screen filling up your error logs with
RPC errors.
Now, just try +- 50 (for a total of 100 ports) before bailing. The
dthello 'blue screen of death' is the most common problem in starting
CDE when rpcbind isn't set up properly. This should at least not
cause the appearance of a 'hang'.
alx [Tue, 2 Apr 2013 20:44:14 +0000 (22:44 +0200)]
Fixed dtpad server crash when closing editor window associated with primary document
Ulrich Wilkens [Tue, 26 Mar 2013 03:08:13 +0000 (04:08 +0100)]
Build dtksh on more OSs
Jon Trulson [Wed, 27 Mar 2013 01:49:50 +0000 (19:49 -0600)]
Add basic Xinerama support via new lib/DtXinerama
This adds a basic library and support to dtsession and dtlogin to
support Xinerama/Twinview, where multimple monitors are used to make
up an X11 screen.
The main goal here is to draw dialogs and such centered on a monitor,
rather than spread out over multiple monitors.
Might need to add sorting - as on my test system, what I would
consider monitor 0, appears to actually be monitor 1. So a sort might
need to be added to sort the screens according to increasing x and y
offsets so it make sense to a user.
Also, this library is built statically and not documented. Maybe it
could be 'filled' out and refactored/redesigned in the futre if need
be and suppoerted.
It is enabled via a define, CDE_USEXINERAMA in site.def. It's a very
simple lib, so I do not expect any issues with the BSD's - it should
build and work fine, assuming your X server has the XINERAMA
extension, which I think pretty much all of them do at this point.
Jon Trulson [Tue, 12 Mar 2013 21:03:43 +0000 (15:03 -0600)]
Add initial Greek UTF-8 translations.
Supplied by Antonis Tsolomitis <antonis.tsolomitis@gmail.com>
Karsten Pedersen [Tue, 26 Feb 2013 19:12:35 +0000 (19:12 +0000)]
Fixed building on FreeBSD 8.x
Karsten Pedersen [Tue, 26 Feb 2013 19:09:17 +0000 (19:09 +0000)]
Fixed colored border around workspace buttons
Pascal Stumpf [Tue, 27 Nov 2012 20:12:23 +0000 (21:12 +0100)]
Avoid negative array subscript; break out of the loop if that happens.
Pascal Stumpf [Thu, 22 Nov 2012 14:49:51 +0000 (15:49 +0100)]
Introduce DTKORNSHELL, analogous to KORNSHELL.
DTKORNSHELL is used to specify the install location of dtksh on your system,
preventing hardcoding of /usr/dt/bin/dtksh in Shebang lines and such.
Pascal Stumpf [Thu, 22 Nov 2012 13:27:26 +0000 (14:27 +0100)]
Keep track of the length of the string in ExpandVariables().
On OpenBSD, the 'S' option to malloc(3) enables guard pages (among other
things). This loop could have triggered this trap when reading beyond the
buffer. Also, the whole "while(*ip)" construct was based on the assumption that
the memory after the string is always zero-filled.
Jon Trulson [Sun, 25 Nov 2012 02:16:58 +0000 (19:16 -0700)]
Revert "Older Linux installations do not have svcfd_create()."
This reverts commit
44e384aedb3b8aabbd3c556af28848fc58c09c60.
This code is actually needed. If svcfd_create() is not available, it
should be fixed only for those systems that it affects.
Pascal Stumpf [Tue, 20 Nov 2012 19:08:34 +0000 (20:08 +0100)]
Set NATIVEXBINDIR on OpenBSD.
Pascal Stumpf [Tue, 20 Nov 2012 21:42:29 +0000 (22:42 +0100)]
Respect CDE_CONFIGURATION_TOP and CDE_INSTALLATION_TOP.
Do not hardcode /etc/dt and /usr/dt.
Pascal Stumpf [Tue, 20 Nov 2012 18:42:33 +0000 (19:42 +0100)]
dtgreet: Do not crash if LANG is not set in the environment.
In that case, catopen() will have never been called, and we'd feed 0 as the
first argument to catgets(). This crashes, at least on OpenBSD.
Pascal Stumpf [Tue, 20 Nov 2012 21:03:30 +0000 (22:03 +0100)]
Correct paths to xterm as failsafe client on the BSDs.
Pascal Stumpf [Tue, 20 Nov 2012 09:09:16 +0000 (10:09 +0100)]
Use same SIGCHLD handling for OpenBSD as for OSF.
Peter Howkins [Tue, 20 Nov 2012 16:22:04 +0000 (16:22 +0000)]
dtaction: Resolve 8 warnings caused by -Wall
Peter Howkins [Tue, 20 Nov 2012 14:49:40 +0000 (14:49 +0000)]
dtcalc: Resolve 82 warnings causing by enabling -Wall
Pascal Stumpf [Mon, 19 Nov 2012 15:22:47 +0000 (16:22 +0100)]
On OpenBSD, use FILE_MAP_OPTIMIZED.
This has the effect of not performing a tt call each time in
ResolveLocalPathName() if we're on the local host anyway. Drastically reduces
dtfile startup time.
Pascal Stumpf [Sun, 18 Nov 2012 23:26:54 +0000 (00:26 +0100)]
Use /usr/sbin/sendmail as default mailer on OpenBSD.
Pascal Stumpf [Sun, 18 Nov 2012 22:43:05 +0000 (23:43 +0100)]
Do not build motif manpages any more.
Pascal Stumpf [Sun, 18 Nov 2012 17:36:48 +0000 (18:36 +0100)]
Remove hack adding csu objects to the linker command line on OpenBSD.
This is no longer needed now that $(CC) is used to link shared libraries.
Pascal Stumpf [Sun, 18 Nov 2012 17:25:07 +0000 (18:25 +0100)]
set AvoidNullMakeCommand on OpenBSD to avoid make warnings
Peter Howkins [Mon, 19 Nov 2012 14:28:52 +0000 (14:28 +0000)]
dtcalc: Further remove K&R function prototypes and replace with ANSI.
Peter Howkins [Fri, 16 Nov 2012 17:03:10 +0000 (17:03 +0000)]
dtcalc: Convert functions from K&R to ansi declarations.
Peter Howkins [Fri, 16 Nov 2012 15:57:36 +0000 (15:57 +0000)]
dtscreen: Resolve (all) 11 warnigns caused by -Wall
Peter Howkins [Fri, 16 Nov 2012 15:29:50 +0000 (15:29 +0000)]
dtscreen: Resolve a -Wformat-security warning.
Peter Howkins [Mon, 12 Nov 2012 17:13:36 +0000 (17:13 +0000)]
libDtSearch: Resolve 137 -Wunused-variable warnings.
Peter Howkins [Mon, 12 Nov 2012 16:26:11 +0000 (16:26 +0000)]
libDtSearch: Resolve 38 -Wformat warnings
Peter Howkins [Mon, 12 Nov 2012 15:03:37 +0000 (15:03 +0000)]
libDtPrint: Resolve 9 -Wunused-variable warnings.
Peter Howkins [Fri, 9 Nov 2012 17:20:46 +0000 (17:20 +0000)]
libdthelp: Resolve 65 -Wunused-variable warnings
Peter Howkins [Tue, 6 Nov 2012 15:07:08 +0000 (15:07 +0000)]
libcsa: Resolve 96 -Wunused-variable warnings.
This is not all of them, another ~90 exist in generated code.
Peter Howkins [Tue, 6 Nov 2012 13:56:11 +0000 (13:56 +0000)]
lidtwidget: Resolve 74 -Wunused-variable warnings
Peter Howkins [Mon, 5 Nov 2012 16:44:29 +0000 (16:44 +0000)]
dtcalc: Resolve 43 warnings that would be introduced with -Wunused-variable or -Wall
Basically 43 local variables declared in functions and then never used.
Marcin Cieslak [Wed, 24 Oct 2012 15:39:55 +0000 (17:39 +0200)]
Fix location of some SGML files
Ulrich Wilkens [Tue, 16 Oct 2012 10:14:56 +0000 (12:14 +0200)]
Fix dtappbuilder on Linux
Ulrich Wilkens [Sun, 14 Oct 2012 16:26:30 +0000 (18:26 +0200)]
dtinfo other requirements
Ulrich Wilkens [Sun, 14 Oct 2012 16:04:35 +0000 (18:04 +0200)]
dtinfo subtree clients
Ulrich Wilkens [Sun, 14 Oct 2012 15:24:56 +0000 (17:24 +0200)]
dtinfo subtree tools
Ulrich Wilkens [Sun, 14 Oct 2012 15:13:07 +0000 (17:13 +0200)]
dtinfo subtree dtinfogen
Ulrich Wilkens [Sun, 14 Oct 2012 15:03:44 +0000 (17:03 +0200)]
dtinfo subtree dtinfo
Ulrich Wilkens [Sun, 14 Oct 2012 14:38:15 +0000 (16:38 +0200)]
dtinfo subtree mmdb
Ulrich Wilkens [Sun, 14 Oct 2012 13:38:27 +0000 (15:38 +0200)]
dtinfo subtree DtMmdb
Marcin Cieslak [Sat, 6 Oct 2012 22:51:58 +0000 (00:51 +0200)]
Adobe Helvetica as -dt-interface system-
Use Adobe Helvetica as the sans serif user
interface font (among others, dtlogin, front
panel buttons, menu titles) instead of Lucida.
While there, move X Consortium comment back
to the top.
This change applies only to FreeBSD.
Peter Howkins [Mon, 8 Oct 2012 14:34:45 +0000 (15:34 +0100)]
libdthelp: resolve 46 compiler warnings
Marcin Cieslak [Fri, 5 Oct 2012 10:10:16 +0000 (12:10 +0200)]
Set CDE_RELEASE to 2.2.0
Jon Trulson [Fri, 5 Oct 2012 00:10:33 +0000 (18:10 -0600)]
Update HISTORY for 2.2.0c release
Jon Trulson [Fri, 5 Oct 2012 00:06:47 +0000 (18:06 -0600)]
update CONTRIBUTORS
Jelle Hermsen [Sat, 29 Sep 2012 11:14:57 +0000 (13:14 +0200)]
Changed a couple of ifdefs for __FreeBSD__ to CSRG_BASED. These are all clearcut cases. I left the ones I had doubts about, or where I wasn't sure about the OpenBSD side of things to look at later.
David J.McBrayer [Mon, 1 Oct 2012 16:29:20 +0000 (12:29 -0400)]
-Updated README.dtlogin -Update "# Provides:" in dtlogin LSB init script
Marcin Cieslak [Wed, 3 Oct 2012 00:33:48 +0000 (02:33 +0200)]
Remove missing xmbind and uil from UDB
Remove xmbind and uil utilities we
do not build and install from the
packing lists.
Marcin Cieslak [Tue, 2 Oct 2012 16:03:41 +0000 (18:03 +0200)]
dtfile: Fix crash when trying to open filter dialog
On 64-bit machine dtfile crashes when opening
list of file types to filter in Encaps.c:
_DtShowDialog (parent=0x805c80900, map_parent=0x0, top_rec=0x805ce3600,
dialog_data=0x805db25e0, change_proc=0x4489f0 <FilterChange+16>,
change_data=0x805ce3600, close_proc=0x4489c0 <FilterClose+16>,
close_data=0x805ce3600, workspaces=0x0, iconify_state=0 '\0',
ignoreCache=0 '\0', title=0x0, classHints=0x0) at Encaps.c:531
531 ResetFlag(NULL,fr->close);
Jon Trulson [Tue, 2 Oct 2012 01:27:36 +0000 (19:27 -0600)]
linux.cf: use -fno-strict-aliasing, define DefaultGcc2i386Opt, use indenting to improve readability
Marcin Cieslak [Tue, 2 Oct 2012 00:10:35 +0000 (02:10 +0200)]
Use -O2 -fno-strict-aliasing optimization for FreeBSD
- Switching from -O to -O2 after the dthelp problem
has been resolved
- Introducing -fno-strict-aliasing (currently FreeBSD's
default) to avoid silent change of behaviour of legacy code.
http://thiemonagel.de/2010/01/no-strict-aliasing/
http://jeffreystedfast.blogspot.de/2010/01/weird-bugs-due-to-gcc-44-and-strict.html
Analysis of C99 aliasing (we are not C99 yet):
http://davmac.wordpress.com/2010/02/26/c99-revisited/
Marcin Cieslak [Tue, 2 Oct 2012 00:10:34 +0000 (02:10 +0200)]
Don't break help with gcc -O2
libDtHelp is unable to read SDL help files
with -ftree-store-ccp optimization which
is enabled by -O2 on gcc 4.2.1.
GifUtils.c and decompress.c didn't work
properly with -ftree-store-ccp enabled.
GifUtils.c was repaired by fixing
those warnings:
GifUtils.c: In function 'create_pixmap':
GifUtils.c:1093: warning: return makes integer from pointer without a cast
GifUtils.c:1110: warning: return makes integer from pointer without a cast
GifUtils.c:1215: warning: return makes integer from pointer without a cast
GifUtils.c: In function 'gif_to_pixmap':
GifUtils.c:1242: warning: return makes integer from pointer without a cast
decompress.c didn't generate warnings, but the
only effect of the -ftree-store-cpp was to introduce
this change:
addq $1, %rax
movq %rax, (%rbx)
.L90:
- cmpl $157, %edx
+ cmpl $-99, %edx
jne .L86
movl 8(%rbx), %eax
subl $1, %eax
Which corresponds to this source code:
bufioI.h
57 #define BufFileGet(f) ((f)->left-- ? *(f)->bufp++ : (*(f)->io) (f))
42 int (*io)(/* BufFilePtr f */);
decompress.c
53 #ifdef NO_UCHAR
54 typedef char char_type;
55 #else
56 typedef unsigned char char_type;
57 #endif /* UCHAR */
58
59 static char_type magic_header[] = { "\037\235" }; /* 1F 9D */
131 if ((BufFileGet(f) != (magic_header[0] & 0xFF)) ||
132 (BufFileGet(f) != (magic_header[1] & 0xFF)))
133 {
134 return 0;
135 }
BufFileGet() returns (int), so the (unsigned char) constants
got promoted to (int) with sign extension; therefore constant
157 decimal (0x9D) became -99 decimal, sign extended
(0xffffff9D), and the comparison was always false.
Tested using:
$ gcc -v
Using built-in specs.
Target: amd64-undermydesk-freebsd
Configured with: FreeBSD/amd64 system compiler
Thread model: posix
gcc version 4.2.1
20070831 patched [FreeBSD]
Running on:
FreeBSD 10.0-CURRENT (r240948M)
built Wed Sep 26 23:33:08 CEST 2012
Marcin Cieslak [Sat, 29 Sep 2012 22:16:33 +0000 (00:16 +0200)]
dtcreate: Don't crash when clicking "Find Set..."
dtcreate crashed on 64-bit system when clicking
"Find Set.." button.
Crash happens in libXm:
new_w=0x805db4300, args=0x7fffffffb430, num_args=0x7fffffffb3dc)
at Form.c:1955
$1 = {att = {{type = 4 '\004', w = 0x805db3700, percent = 0, offset = 0,
value = 0, tempValue = 0}, {type = 1 '\001', w = 0x0, percent = 0,
offset = 10, value = 0, tempValue = 0}, {type = 3 '\003',
w = 0x805db3700, percent = 0, offset = 0, value = 0, tempValue = 0}, {
type = 3 '\003', w = 0x800000000, percent = 0, offset = 10, value = 0,
tempValue = 0}}, next_sibling = 0x0, sorted = 0 '\0',
resizable = 1 '\001', preferred_width = 0, preferred_height = 0}
(...)
at icon_selection_dialog.c:1768
1767 /* Creation of icon_scrolled_win */
1768 icon_scrolled_win = XtVaCreateManagedWidget( "icon_scrolled_win",
1769 xmScrolledWindowWidgetClass,
1770 icon_selection_dialog,
1771 XmNscrollingPolicy, XmAUTOMATIC,
1772 /* XmNnavigationType, XmTAB_GROUP, */
1773 XmNx, 282,
1774 XmNy, 84,
1775 XmNscrollBarDisplayPolicy, XmAS_NEEDED,
1776 XmNrightOffset, 10,
1777 XmNrightAttachment, XmATTACH_FORM,
1778 XmNtopOffset, 0,
1779 XmNtopWidget, icon_container_label,
1780 XmNtopAttachment, XmATTACH_WIDGET,
1781 XmNleftOffset, 0,
1782 XmNleftWidget, icon_container_label,
1783 XmNleftAttachment, XmATTACH_OPPOSITE_WIDGET,
1784 XmNbottomOffset, 10,
1785 XmNbottomWidget, XmATTACH_NONE,
1786 XmNbottomAttachment, XmATTACH_WIDGET,
1787 NULL );
What happens here is that ConstraintInitialize receives
four constraints, the last one is this:
{ type = 3 '\003', /* XmATTACH_WIDGET */
w = 0x800000000, /* malformed XmATTACH_NONE ???
percent = 0,
offset = 10, /* specified as XmNbottomOffset */
value = 0,
tempValue = 0}
XmATTACH_* values are defined in <Xm/Xm.h> as follows:
505 enum{ XmATTACH_NONE, XmATTACH_FORM,
506 XmATTACH_OPPOSITE_FORM, XmATTACH_WIDGET,
507 XmATTACH_OPPOSITE_WIDGET, XmATTACH_POSITION,
508 XmATTACH_SELF
509 } ;
What is not clear to why XmATTACH_NONE - which should be (int)0 -
becomes 0x800000000 - looks like a 64 bit bug somewhere.
Providing a long value on None (0L) as in this change fixes the
problem.
I understand is that it possible to use such an "empty" widget
is to create additional space at the bottom of the newly created
"icon_scrolled_win".
What needs to be clarified - shouldn't be such an (int) value be
automatically promoted to (long) (or XtArgVal, XtPointer, ...)
and preserve the value 0? Lots of parameters seem to be
passed as ints (for example dimensions) and they do not
appear to cause any trouble.
Jon Trulson [Sun, 30 Sep 2012 02:46:27 +0000 (20:46 -0600)]
XmPrivate.h: never try to build this automatically.
XmPrivate must be generated manually. For this you work, you must
have a freshly compiled openmotif tree, and MLIBSRC must be pointing
to it.
Otherwise, it's possible during the includes phase for an attempt to
be made to regenerate this file, which will fail on the vast majority
of systems out there.
So, to regenerate,
cd include/Xm
rm XmPrivate.h
make XmPrivate.h
Marcin Cieslak [Sat, 29 Sep 2012 22:16:31 +0000 (00:16 +0200)]
dtcreate: Add missing prototypes and more (64-bit)
- Fix missing prototypes
- Fix some 64-bit related problems (XtVaGetValues)
- Fix crash on dtcreate startup in create_applicationShell1()
- Add XmeFlushIconFileCache() prototype from <Xm/IconFileP.h>
Marcin Cieslak [Sat, 29 Sep 2012 20:23:33 +0000 (22:23 +0200)]
XmPrivate.h: Avoid whitespace problems (IMPROVED)
When applying a patch, "git am" strips
trailing whitespace, although they are
present in the git formatted-patch.
This way the committed file will be
slightly different than the file re-generated
by extractprototype.h
It shouldn't hurt, but next run of
extractprototype.h will add trailing spaces
again and the resulting diff on XmPrivate.h
will include more changes than actually
needed.
This may break some viscious circle after
applying the patch, so enabling regeneration
on LinuxArchitecture again.
This patch does not add XmeFlushIconFileCache()
needed by dtcreate.
Frederic Koehler [Fri, 28 Sep 2012 18:22:27 +0000 (14:22 -0400)]
dtcreate: Avoid trying to reuse closed help window
This fixes a segfault when trying to go to help a second
time, after closing the first window.