Glenn L McGrath [Mon, 15 Sep 2003 09:22:04 +0000 (09:22 -0000)]
Fix some memory allocation problems
----------------------------------------------------------------------
Eric Andersen [Mon, 15 Sep 2003 08:33:45 +0000 (08:33 -0000)]
Be entirely consistant when using ioctl(0, TIOCGWINSZ, &winsize)
to ensure proper fallback behavior on, i.e. serial consoles.
-Erik
Eric Andersen [Mon, 15 Sep 2003 08:13:43 +0000 (08:13 -0000)]
fix function prototype
Eric Andersen [Mon, 15 Sep 2003 08:12:53 +0000 (08:12 -0000)]
Needs prototype for close()
Eric Andersen [Mon, 15 Sep 2003 08:11:29 +0000 (08:11 -0000)]
comparison was always false due to limited range of data types.
Carefully cast to unsigned long long prior to multiply to get
the expected result.
Eric Andersen [Mon, 15 Sep 2003 08:06:15 +0000 (08:06 -0000)]
Do not shadow the global name 'accept'
Glenn L McGrath [Mon, 15 Sep 2003 06:28:45 +0000 (06:28 -0000)]
Add a test for the 'P' command and fix current implementation so it
doesnt permanently modify the pattern space.
Glenn L McGrath [Mon, 15 Sep 2003 06:12:53 +0000 (06:12 -0000)]
A test and fix for the sed 'n' command
Glenn L McGrath [Mon, 15 Sep 2003 05:53:28 +0000 (05:53 -0000)]
Test for use of newline in regex's, this feature is used by most
configure scripts.
Glenn L McGrath [Mon, 15 Sep 2003 05:42:05 +0000 (05:42 -0000)]
Fix for the sed-append-next-line test
Glenn L McGrath [Mon, 15 Sep 2003 05:35:47 +0000 (05:35 -0000)]
Test the N command
Glenn L McGrath [Mon, 15 Sep 2003 04:55:29 +0000 (04:55 -0000)]
Fix recursion problem
Glenn L McGrath [Mon, 15 Sep 2003 04:41:17 +0000 (04:41 -0000)]
Check sed doesnt go into an infinite loop (yes it does)
Glenn L McGrath [Mon, 15 Sep 2003 03:37:32 +0000 (03:37 -0000)]
Update Matteo Croce's email address
Glenn L McGrath [Sun, 14 Sep 2003 16:28:08 +0000 (16:28 -0000)]
Memory cleanups and fix for `echo "foo" | sed 's/foo/bar/;H;q'`
Glenn L McGrath [Sun, 14 Sep 2003 15:24:18 +0000 (15:24 -0000)]
Cleanup memory usage
Glenn L McGrath [Sun, 14 Sep 2003 11:10:08 +0000 (11:10 -0000)]
Update sed branch tests
Glenn L McGrath [Sun, 14 Sep 2003 09:38:24 +0000 (09:38 -0000)]
Add two new tests, sed-recurses-properly should always work
Glenn L McGrath [Sun, 14 Sep 2003 08:52:53 +0000 (08:52 -0000)]
The previous fix for 's/a/1/;s/b/2/;t one;p;:one;p' broke the case of
echo fooba | ./busybox sed -n 's/foo//;s/bar/found/p'
I really need to start adding these tests to the testsuite.
keep the substituted and altered flags seperate
Glenn L McGrath [Sun, 14 Sep 2003 07:59:28 +0000 (07:59 -0000)]
Preserve substitution flag value within the current line.
Fixed the following testcase
# cat strings |./busybox sed -n -f test3.sed
1
1
2
c
c
# cat strings
a
b
c
Glenn L McGrath [Sun, 14 Sep 2003 06:01:14 +0000 (06:01 -0000)]
Fix branching commands.
If a label isnt specified, jump to end of script, not the last command
in the script.
Print an error and exit if you try and jump to a non-existant label
Works for the following testcase
# cat strings
a
b
c
d
e
f
g
# cat strings | ./busybox sed -n '/d/b;p'
a
b
c
e
f
g
Glenn L McGrath [Sun, 14 Sep 2003 04:06:12 +0000 (04:06 -0000)]
Patch from Rob Landley
Fixed a memory leak in add_cmd/add_cmd_str by moving the allocation
of sed_cmd down to where it's actually first needed.
In get_address, if index_of_next_unescaped_regexp_delim ever failed, we
wouldn't notice because the return value was added to idx, which was
already guaranteed to be > 0. (This is buried in the changes made when
I redid get_address to be based on pointer arithmetic, because all the tests
were gratuitously dereferencing with a constant zero, which wasn't obvious.)
Comment in parse_regex_delim was wrong: 's' and 'y' both call it.
The reason "sed_cmd->num_backrefs = 0;" isn't needed is that sed_cmd was
allocated with cmalloc, which zeroes memory.
Different handling of space after \ in i...
Different handling of pattern "s/a/b s/c/d"
Cool, resursive reads don't cause a crash. :)
Fixed "sed -f blah filename - < filename" since GNU sed was handling
both - and filenames on the same line. (You can even list - more than
once, although it's immediate EOF...)
Glenn L McGrath [Sun, 14 Sep 2003 02:37:46 +0000 (02:37 -0000)]
Stupid typo
Glenn L McGrath [Sun, 14 Sep 2003 01:25:31 +0000 (01:25 -0000)]
Fix some memory allocation problems
Glenn L McGrath [Sat, 13 Sep 2003 15:12:22 +0000 (15:12 -0000)]
Fix the following testcase by disabling global substitution if the regex
is anchored to the start of line, there can be only one subst.
echo "aah" | sed 's/^a/b/g'
Glenn L McGrath [Sat, 13 Sep 2003 06:57:39 +0000 (06:57 -0000)]
Fix the following testcase by storing the state of the adress match with
the command.
# cat strings
a
b
c
d
e
f
g
# ./busybox sed '1,2d;4,$d' <strings
c
# ./busybox sed '4,$d;1,2d' <strings
# sed '4,$d;1,2d' <strings
c
# sed '1,2d;4,$d' <strings
c
Glenn L McGrath [Fri, 12 Sep 2003 11:27:15 +0000 (11:27 -0000)]
Fix compile error, Vodz, last_path_113
Glenn L McGrath [Fri, 12 Sep 2003 10:58:54 +0000 (10:58 -0000)]
Typo.
Eric Andersen [Fri, 12 Sep 2003 08:39:05 +0000 (08:39 -0000)]
As vodz just pointed out, I screwup up the call to bb_xasprintf!
Eric Andersen [Fri, 12 Sep 2003 08:32:24 +0000 (08:32 -0000)]
Remove final \n
Eric Andersen [Fri, 12 Sep 2003 07:36:46 +0000 (07:36 -0000)]
Fix obligitory typos
Eric Andersen [Fri, 12 Sep 2003 07:03:52 +0000 (07:03 -0000)]
Final changelog update
Eric Andersen [Fri, 12 Sep 2003 07:03:14 +0000 (07:03 -0000)]
Remove version #
Eric Andersen [Fri, 12 Sep 2003 06:59:52 +0000 (06:59 -0000)]
I suppose it is now Sept 12...
Eric Andersen [Fri, 12 Sep 2003 06:59:17 +0000 (06:59 -0000)]
Update webpage a bit
Glenn L McGrath [Fri, 12 Sep 2003 06:49:09 +0000 (06:49 -0000)]
Fix handling of hardlinks when OLDGNU and GNU extensions arent enabled.
Glenn L McGrath [Fri, 12 Sep 2003 06:31:28 +0000 (06:31 -0000)]
Use the typeflag to identify if its a hardlink on OLD and GNU posix
modes, fixes a bug extracting hardlinks to symlinks.
Eric Andersen [Fri, 12 Sep 2003 05:59:53 +0000 (05:59 -0000)]
Invoke run-parts on /etc/network/if-*.d per the behavior of
the upstream ifupdown code...
Eric Andersen [Fri, 12 Sep 2003 05:50:51 +0000 (05:50 -0000)]
Teach rdate to timeout in 10 seconds to avoid blocking forever
with odd or broken networking setups
Eric Andersen [Fri, 12 Sep 2003 04:49:21 +0000 (04:49 -0000)]
config option CONFIG_FEATURE_SH_APPLETS_ALWAYS_WIN must depend
on CONFIG_FEATURE_SH_STANDALONE_SHELL.
Eric Andersen [Fri, 12 Sep 2003 04:43:49 +0000 (04:43 -0000)]
Update changelog for release
Glenn L McGrath [Fri, 12 Sep 2003 00:44:50 +0000 (00:44 -0000)]
Busybox CVS version ipcalc have problems:
- Can`t use 255.255.255.255 address
- typo: double check for valid ip address and uncheck for valid mask
httpd unseted SERVER_PORT (my bug from last_patch111).
last_patch_112 from Vladimir N. Oleynik
Eric Andersen [Thu, 11 Sep 2003 08:52:22 +0000 (08:52 -0000)]
Update definition of struct serial_struct, per linux-2.6.0-test5,
to avoid stack corruption problems on some 64bit architectures
when sizeof(void*) != sizeof(int). Thanks to Atsushi Nemoto
for finding this problem.
Eric Andersen [Thu, 11 Sep 2003 08:32:40 +0000 (08:32 -0000)]
Marc A. Lehmann writes:
The tar -x command in busybox does not restore the file mode correctly.
The reason is most probably this code in
archival/libunarachive/data_extract_all.c:
chmod(file_header->name, file_header->mode);
chown(file_header->name, file_header->uid, file_header->gid);
chown clears the set*id bits (on current versions of linux :). Flipping
the order around fixes the problem.
(tested with 1.00pre3 from cvs).
Eric Andersen [Thu, 11 Sep 2003 08:25:11 +0000 (08:25 -0000)]
Patch from Philip Blundell:
On Thu, 2003-09-11 at 01:09, Glenn McGrath wrote:
> Applied
Thanks. Unfortunately there was one small bug in that last patch.
Could you apply this one as well?
p.
Glenn L McGrath [Wed, 10 Sep 2003 23:52:15 +0000 (23:52 -0000)]
add ipv6 literal support to wget
Glenn L McGrath [Wed, 10 Sep 2003 23:47:10 +0000 (23:47 -0000)]
Fix a bug where make clean complained about having both : and :: entries.
Remove tester.log on make clean
Patch by Arthur Othieno
Glenn L McGrath [Wed, 10 Sep 2003 23:35:45 +0000 (23:35 -0000)]
Vodz, last_patch_104
Glenn L McGrath [Tue, 9 Sep 2003 17:41:03 +0000 (17:41 -0000)]
If a tar entry is a regualr file ending in a '/' then its really a
directory.
From http://www.gnu.org/manual/tar/html_node/tar_123.html
REGTYPE
AREGTYPE
These flags represent a regular file. In order to be compatible with
older versions of tar, a typeflag value of AREGTYPE should be silently
recognized as a regular file. New archives should be created using
REGTYPE. Also, for backward compatibility, tar treats a regular file
whose name ends with a slash as a directory.
Glenn L McGrath [Tue, 9 Sep 2003 15:53:56 +0000 (15:53 -0000)]
Update the config file by running it from menuconfig, get rid of some
unused entries.
Glenn L McGrath [Mon, 8 Sep 2003 23:19:12 +0000 (23:19 -0000)]
Patch from Jean Wolter
expr currently always adds even if told to subtract
Glenn L McGrath [Mon, 8 Sep 2003 15:39:09 +0000 (15:39 -0000)]
Vodz, last_patch_110
no limit, no memory usage for env buffer, always call putenv().
remove small error for previous last_patch109.
Glenn L McGrath [Mon, 8 Sep 2003 14:34:23 +0000 (14:34 -0000)]
Preserve suid/sgid bits
Glenn L McGrath [Mon, 8 Sep 2003 10:59:27 +0000 (10:59 -0000)]
last_patch_109 from Vladimir N. Oleynik
Busybox`s httpd have the defect (from born):
ip 1.2.3.1 have true comparing also with
1.2.3.10-1.2.3.19 and 1.2.3.100-1.2.3.199.
Last patch removed this bug and added feature:
allow/deny rule can support network/netmask
example: 1.2.3.0/255.255.255.128
or
network/mask_bits
example: 1.2.3.0/25
now; old format
1
1.2
1.2.3
1.2.3.4
too support and converted to
1/8 1.2/16 1.2.3/24 1.2.3.4/32
automaticaly.
Also, current CVS have small problem: ignores
A:IP, (loses 'A', 'a' only work). Corrected.
Glenn L McGrath [Mon, 8 Sep 2003 00:32:49 +0000 (00:32 -0000)]
Busybox modprobe has a couple of irritating quirks:
- attempting to modprobe a module that is already loaded yields "Failed
to load module", whereas modutils quietly ignores such a request.
- if a module genuinely can't be loaded due to missing symbols or
similar problems, modprobe doesn't produce any useful diagnostics
because the output from insmod has been redirected to /dev/null.
Here's a patch to address these issue
Patch by Philip Blundell
Glenn L McGrath [Fri, 5 Sep 2003 02:37:15 +0000 (02:37 -0000)]
Small bug in silent option
Glenn L McGrath [Thu, 4 Sep 2003 08:21:36 +0000 (08:21 -0000)]
Set the default password to md5, patch by Joshua Jackson
Glenn L McGrath [Wed, 3 Sep 2003 12:18:42 +0000 (12:18 -0000)]
more crond+crontab integrating with loginutil libbb functions and deleted
patch from Thomas Gleixner to init.
Viodz last_patch_108
Glenn L McGrath [Wed, 3 Sep 2003 00:42:58 +0000 (00:42 -0000)]
To load GPLONLY symbols its is required that CHECK_TAINTED_MODULES be
enabled, if not GPLONLY symbols are ignored.
Glenn L McGrath [Tue, 2 Sep 2003 06:59:57 +0000 (06:59 -0000)]
adds the ability to use and calculate network prefix specifications instead
of netmasks. It also fixes the parameters for network and netmask to match
that of the official Red Hat version (-n for network and -m for netmask).
Patch by Joshua Jackson
Glenn L McGrath [Tue, 2 Sep 2003 02:36:18 +0000 (02:36 -0000)]
move all "-/bin/sh" "/bin/sh" and "sh" to libbb/messages.c file as one
constant.
Vodz last_patch_107
Glenn L McGrath [Mon, 1 Sep 2003 08:53:32 +0000 (08:53 -0000)]
Fix compile error and reducing size for libbb/get_console.c to previous size.
Vodz last_patch106
Glenn L McGrath [Mon, 1 Sep 2003 04:08:36 +0000 (04:08 -0000)]
Allow one to detect and handle the case where no lease could be obtained
via DHCP. (Just add a section "failed" to your script.)
Patch by Steven Scholz
Glenn L McGrath [Sun, 31 Aug 2003 01:58:18 +0000 (01:58 -0000)]
"insmod caches the symbolname in a variable before modifying it and uses
the cached value afterwards." - Jean Wolter
Glenn L McGrath [Sat, 30 Aug 2003 12:38:13 +0000 (12:38 -0000)]
save a couple of bytes
Glenn L McGrath [Sat, 30 Aug 2003 12:27:36 +0000 (12:27 -0000)]
The default behaviour for run-parts is corrected to continue if an error
is encountered in a script.
Patch by Philip Blundell
Glenn L McGrath [Sat, 30 Aug 2003 06:00:33 +0000 (06:00 -0000)]
handle GPLONLY symbols
Glenn L McGrath [Sat, 30 Aug 2003 04:47:36 +0000 (04:47 -0000)]
"Without this patch, udhcpcd output may be buffered and delayed for
for minutes if stdout is not a tty." -vda@
Glenn L McGrath [Sat, 30 Aug 2003 04:35:07 +0000 (04:35 -0000)]
Fix the substitution print subcommand, it should only print if its
own substitution matched, not previous ones.
e.g
echo fooba | sed -n 's/foo//;s/bar/found/p'
shouldnt print anything
Glenn L McGrath [Fri, 29 Aug 2003 16:19:03 +0000 (16:19 -0000)]
Remove some unwanted code, patch from Holger Schurig, confirmed by vodz
Glenn L McGrath [Fri, 29 Aug 2003 15:53:23 +0000 (15:53 -0000)]
"Due to a wrong format parameter in a printf httpd does not work when
compiled for with CONFIG_LFS (large file support).
The attached patch suggested by Vladimir fixes that." - Steven Scholz
Glenn L McGrath [Fri, 29 Aug 2003 15:48:37 +0000 (15:48 -0000)]
"A little patch for the strings applet of the busybox development tree
that substitutes two lines of code with a libbb function saving a couple
of bytes." - Tito
Glenn L McGrath [Fri, 29 Aug 2003 15:39:07 +0000 (15:39 -0000)]
Logic error, patch by Matteo Croce
Glenn L McGrath [Fri, 29 Aug 2003 15:19:44 +0000 (15:19 -0000)]
Remove stray '\n'
Glenn L McGrath [Fri, 29 Aug 2003 15:03:12 +0000 (15:03 -0000)]
Remove unused files
Glenn L McGrath [Fri, 29 Aug 2003 14:18:26 +0000 (14:18 -0000)]
Help for date -I when CONFIG_FEATURE_DATE_ISOFMT is enabled.
Patch by Steven Scholz
Glenn L McGrath [Fri, 29 Aug 2003 13:25:55 +0000 (13:25 -0000)]
Change make to $(MAKE), patch by Hideki IWAMOTO
Glenn L McGrath [Fri, 29 Aug 2003 12:23:09 +0000 (12:23 -0000)]
Substitute busybox for uClibc, patch by Hideki IWAMOTO
Glenn L McGrath [Fri, 29 Aug 2003 12:20:31 +0000 (12:20 -0000)]
* Since busybox binary is unnecessary, deleted it from prerequisites.
* Changed so that not only links but /bin/busybox might be deleted.
* When double quoted PREFIX is defined by `.config' is used,
`make uninstall' does not work correctly.
When default PREFIX `pwd`/_install defined by Rules.mak is used,
similarly it does not work correctly.
Changed $$PREFIX into $(PREFIX) in order to fix this.
Patch by Hideki IWAMOTO
Glenn L McGrath [Fri, 29 Aug 2003 11:34:08 +0000 (11:34 -0000)]
Fix for compiling with ipv6
Glenn L McGrath [Fri, 29 Aug 2003 10:58:46 +0000 (10:58 -0000)]
"This function was not updating the argc and argv pointers to reflect
the arguments it consumed, which means the calling function encountered
them as well. As a result, a command like "ip -6 addr" was yielding a usage
error." - Philip Blundell
Glenn L McGrath [Fri, 29 Aug 2003 07:47:52 +0000 (07:47 -0000)]
label's dont work in v4 tunnels, patch by Eric Spakman
Glenn L McGrath [Fri, 29 Aug 2003 07:38:56 +0000 (07:38 -0000)]
Vodz, last patch 105
Busybox "mount" applet unsupport "user" option and
result: must have _BB_SUID_NEVER applet option (my bug).
Last patch have reducing 216 bytes for "su" applet also.
Glenn L McGrath [Fri, 29 Aug 2003 07:35:08 +0000 (07:35 -0000)]
Vodz, last patch 104
Glenn L McGrath [Fri, 29 Aug 2003 07:29:30 +0000 (07:29 -0000)]
vodz, last patch 103
Glenn L McGrath [Fri, 29 Aug 2003 06:25:04 +0000 (06:25 -0000)]
Correct logic in determining size of block to download, as pointed out
by Junio C Hamano
Glenn L McGrath [Thu, 28 Aug 2003 22:12:53 +0000 (22:12 -0000)]
"Typo and/or thinko: scanning till the end of NUL terminated string
should check the byte pointed at not the pointer itself." -junkio@
Glenn L McGrath [Thu, 28 Aug 2003 22:03:19 +0000 (22:03 -0000)]
"When the initial request by wget is responded by a 3XX redirect
response sent in chunked transfer encoding, the code path to
resubmit the request to the redirected URL forgets to reset
got_clen and chunked variables in the loop. If the redirected
URL does not use chunked transfer encoding, this causes the code
that slurps the body of the response to incorrectly try to parse
out the chunk length which does not exist." - junkio@
----------------------------------------------------------------------
Glenn L McGrath [Thu, 28 Aug 2003 21:55:22 +0000 (21:55 -0000)]
"When the filesize is known from content-length header, safe_fread is
always told to read sizeof(buf). This waits until the underlying
fread() to time-out for the last part of the downloaded body. Fix
this by sending the number of remaining bytes to read when known." -
junkio@
I reworked the logic in his patch
Glenn L McGrath [Thu, 28 Aug 2003 19:54:16 +0000 (19:54 -0000)]
*** empty log message ***
Glenn L McGrath [Thu, 28 Aug 2003 19:12:23 +0000 (19:12 -0000)]
Dont unlink when testing !
Always preserve creation date
Disable the -p option its for modification date
Remove some cpio header debugging noise
Syncronise file listing behaviour with upstream.
Robert Griebl [Tue, 26 Aug 2003 11:06:39 +0000 (11:06 -0000)]
Removed some debug printfs
Glenn L McGrath [Tue, 26 Aug 2003 04:50:23 +0000 (04:50 -0000)]
Syncronise some build files with busybox-cvs-
20030819
Glenn L McGrath [Tue, 26 Aug 2003 04:28:05 +0000 (04:28 -0000)]
Woops, depend on SHA1 not the option
Glenn L McGrath [Tue, 26 Aug 2003 04:25:59 +0000 (04:25 -0000)]
SHA1 options depend on SHA1
Glenn L McGrath [Tue, 26 Aug 2003 02:14:58 +0000 (02:14 -0000)]
Fix overflow for machines greater than 4GB, return unsigned int to avoid
a cast and for greater accuracy.
Eric Andersen [Fri, 22 Aug 2003 23:08:37 +0000 (23:08 -0000)]
"staywithu" writes:
In BusyBox v1.00-pre2,
commands like ls, df with -h option report a wrong file size for files larger than 4GBtye!!
For example,
when I execute 'ls -l', it reports
-rw-r--r-- 1 root root
5368709120 Aug 17 2003 large_stream.tp
when I execute 'ls -lh', I expect that
-rw-r--r-- 1 root root 5.0G Aug 17 2003 large_stream.tp
but it reports
-rw-r--r-- 1 root root 1.0G Aug 17 2003 large_stream.tp
I fixed this bug that...
Line 31 in libbb/human_readable.c and line 275 include/libbb.h
const char *make_human_readable_str(unsigned long size
=> const char *make_human_readable_str(unsigned long long size
It's OK!
Eric Andersen [Fri, 22 Aug 2003 21:15:07 +0000 (21:15 -0000)]
trivial doc fix
Eric Andersen [Fri, 22 Aug 2003 20:53:38 +0000 (20:53 -0000)]
Fixup 'make clean' to properly clean the _install directory
Glenn L McGrath [Tue, 19 Aug 2003 03:49:00 +0000 (03:49 -0000)]
Typo