oweals/openwrt.git
17 years agoAdd a symlinkclean target to remove symlinks
Florian Fainelli [Mon, 26 Mar 2007 22:01:47 +0000 (22:01 +0000)]
Add a symlinkclean target to remove symlinks

SVN-Revision: 6720

17 years agoAlso forgot adding the adm5120_info file
Florian Fainelli [Mon, 26 Mar 2007 20:26:23 +0000 (20:26 +0000)]
Also forgot adding the adm5120_info file

SVN-Revision: 6719

17 years agofix the sdk
Felix Fietkau [Mon, 26 Mar 2007 20:17:28 +0000 (20:17 +0000)]
fix the sdk

SVN-Revision: 6718

17 years agoDisable YAFFS and NAND by default
Florian Fainelli [Mon, 26 Mar 2007 19:54:54 +0000 (19:54 +0000)]
Disable YAFFS and NAND by default

SVN-Revision: 6717

17 years agoMove the yaffs patch to be generic, shared between rb532 and adm5120
Florian Fainelli [Mon, 26 Mar 2007 19:42:33 +0000 (19:42 +0000)]
Move the yaffs patch to be generic, shared between rb532 and adm5120

SVN-Revision: 6716

17 years agoForgot adding infos header
Florian Fainelli [Mon, 26 Mar 2007 19:09:16 +0000 (19:09 +0000)]
Forgot adding infos header

SVN-Revision: 6715

17 years agoRewrite of the bootloader runtime detection (Gabor Juhos)
Florian Fainelli [Mon, 26 Mar 2007 07:37:31 +0000 (07:37 +0000)]
Rewrite of the bootloader runtime detection (Gabor Juhos)

SVN-Revision: 6713

17 years agoAdd myloader definitions
Florian Fainelli [Mon, 26 Mar 2007 07:34:45 +0000 (07:34 +0000)]
Add myloader definitions

SVN-Revision: 6712

17 years agoPreserve fw_arg0-3 to allow runtime bootloader detection (Gabor Juhos)
Florian Fainelli [Mon, 26 Mar 2007 07:32:10 +0000 (07:32 +0000)]
Preserve fw_arg0-3 to allow runtime bootloader detection (Gabor Juhos)

SVN-Revision: 6711

17 years agoAdd definitions to myloader thanks Gabor Juhos
Florian Fainelli [Mon, 26 Mar 2007 07:31:28 +0000 (07:31 +0000)]
Add definitions to myloader thanks Gabor Juhos

SVN-Revision: 6710

17 years agoenable dso support back in openssl, needed to use shared zlib compression, and should...
Nicolas Thill [Mon, 26 Mar 2007 05:04:13 +0000 (05:04 +0000)]
enable dso support back in openssl, needed to use shared zlib compression, and should fix the "error:2507006C:lib(37):func(112):reason(108)" errors. closes: #1182

SVN-Revision: 6706

17 years agoadd fix from #1516
Felix Fietkau [Sun, 25 Mar 2007 16:25:15 +0000 (16:25 +0000)]
add fix from #1516

SVN-Revision: 6697

17 years agoadd prereq check for pkg-config (required by ntfs-3g)
Felix Fietkau [Sun, 25 Mar 2007 16:22:42 +0000 (16:22 +0000)]
add prereq check for pkg-config (required by ntfs-3g)

SVN-Revision: 6696

17 years agoar7: clocks setup (prerequisite for dsl/usb) and misc cleanups.
Eugene Konev [Sun, 25 Mar 2007 05:42:16 +0000 (05:42 +0000)]
ar7: clocks setup (prerequisite for dsl/usb) and misc cleanups.

SVN-Revision: 6693

17 years agoUpdate kernel config
Florian Fainelli [Sat, 24 Mar 2007 22:51:37 +0000 (22:51 +0000)]
Update kernel config

SVN-Revision: 6690

17 years agoUse MiBSD ksh if installed (#1470)
Florian Fainelli [Sat, 24 Mar 2007 21:51:44 +0000 (21:51 +0000)]
Use MiBSD ksh if installed (#1470)

SVN-Revision: 6687

17 years agoForgot to define what CFE is
Florian Fainelli [Sat, 24 Mar 2007 21:34:51 +0000 (21:34 +0000)]
Forgot to define what CFE is

SVN-Revision: 6685

17 years agoTypo fix
Florian Fainelli [Sat, 24 Mar 2007 21:34:14 +0000 (21:34 +0000)]
Typo fix

SVN-Revision: 6684

17 years agoDo not register more than 2 ethernet porst for CFE based devices (i.e : Compex WP54G...
Florian Fainelli [Sat, 24 Mar 2007 21:31:13 +0000 (21:31 +0000)]
Do not register more than 2 ethernet porst for CFE based devices (i.e : Compex WP54G-wrt)

SVN-Revision: 6683

17 years agosplit CONFIGURE_PATH into CONFIGURE_PATH and CONFIGURE_CMD for better handling of...
Felix Fietkau [Sat, 24 Mar 2007 21:12:26 +0000 (21:12 +0000)]
split CONFIGURE_PATH into CONFIGURE_PATH and CONFIGURE_CMD for better handling of subdirectories with configure

SVN-Revision: 6681

17 years agofix CONFIGURE_PATH and add MAKE_PATH
Felix Fietkau [Sat, 24 Mar 2007 21:05:56 +0000 (21:05 +0000)]
fix CONFIGURE_PATH and add MAKE_PATH

SVN-Revision: 6680

17 years agouse recursive variable expansion for CONFIGURE_*, MAKE_* variables in the package...
Felix Fietkau [Sat, 24 Mar 2007 20:54:33 +0000 (20:54 +0000)]
use recursive variable expansion for CONFIGURE_*, MAKE_* variables in the package build so that TARGET_*FLAGS changes also apply

SVN-Revision: 6678

17 years agoAdded support for BSD pty's
Hamish Guthrie [Sat, 24 Mar 2007 17:32:32 +0000 (17:32 +0000)]
Added support for BSD pty's

SVN-Revision: 6673

17 years agotrigger a kernel module rebuild when the kernel config changes
Felix Fietkau [Sat, 24 Mar 2007 17:05:26 +0000 (17:05 +0000)]
trigger a kernel module rebuild when the kernel config changes

SVN-Revision: 6671

17 years agofix a compile error
Felix Fietkau [Sat, 24 Mar 2007 15:57:16 +0000 (15:57 +0000)]
fix a compile error

SVN-Revision: 6670

17 years agosplit libuuid from e2fsprogs and install development files
Felix Fietkau [Sat, 24 Mar 2007 15:51:43 +0000 (15:51 +0000)]
split libuuid from e2fsprogs and install development files

SVN-Revision: 6668

17 years agoset the DEVICE variable in hotplug events from ppp interfaces
Felix Fietkau [Sat, 24 Mar 2007 14:12:22 +0000 (14:12 +0000)]
set the DEVICE variable in hotplug events from ppp interfaces

SVN-Revision: 6667

17 years agorename uci-update.awk to uci.awk and add a few config_* functions
Felix Fietkau [Sat, 24 Mar 2007 13:43:04 +0000 (13:43 +0000)]
rename uci-update.awk to uci.awk and add a few config_* functions

SVN-Revision: 6666

17 years agofix uci commit
Felix Fietkau [Sat, 24 Mar 2007 13:42:55 +0000 (13:42 +0000)]
fix uci commit

SVN-Revision: 6665

17 years agomove default templates for the kernel build to kernel-defaults.mk (similar to package...
Felix Fietkau [Sat, 24 Mar 2007 13:42:54 +0000 (13:42 +0000)]
move default templates for the kernel build to kernel-defaults.mk (similar to package-defaults.mk)

SVN-Revision: 6664

17 years agosmall cleanup
Felix Fietkau [Sat, 24 Mar 2007 13:42:53 +0000 (13:42 +0000)]
small cleanup

SVN-Revision: 6663

17 years agoAdded facility to program entire device from SD-Card Fixed up MAC address init in...
Hamish Guthrie [Sat, 24 Mar 2007 12:54:38 +0000 (12:54 +0000)]
Added facility to program entire device from SD-Card Fixed up MAC address init in u-boot

SVN-Revision: 6662

17 years agoFix potential unligned access with MyLoader based devices, thanks Juhos
Florian Fainelli [Sat, 24 Mar 2007 10:22:53 +0000 (10:22 +0000)]
Fix potential unligned access with MyLoader based devices, thanks Juhos

SVN-Revision: 6659

17 years agoAdd a paragraph on how to package kernel modules
Florian Fainelli [Sat, 24 Mar 2007 10:18:36 +0000 (10:18 +0000)]
Add a paragraph on how to package kernel modules

SVN-Revision: 6658

17 years agoFix some mistakes and typos
Florian Fainelli [Sat, 24 Mar 2007 10:18:14 +0000 (10:18 +0000)]
Fix some mistakes and typos

SVN-Revision: 6657

17 years agodon't call wpa_supplicant unconditionally
Felix Fietkau [Sat, 24 Mar 2007 01:03:42 +0000 (01:03 +0000)]
don't call wpa_supplicant unconditionally

SVN-Revision: 6656

17 years agofix wep encryption setting for madwifi
Felix Fietkau [Sat, 24 Mar 2007 01:01:18 +0000 (01:01 +0000)]
fix wep encryption setting for madwifi

SVN-Revision: 6655

17 years agofix a small typo
Felix Fietkau [Sat, 24 Mar 2007 00:43:05 +0000 (00:43 +0000)]
fix a small typo

SVN-Revision: 6654

17 years agoimprove autorebuild for iptables when the kernel config changes
Felix Fietkau [Fri, 23 Mar 2007 19:19:23 +0000 (19:19 +0000)]
improve autorebuild for iptables when the kernel config changes

SVN-Revision: 6652

17 years agomake busybox autorebuild on relevant config changes
Felix Fietkau [Fri, 23 Mar 2007 19:13:08 +0000 (19:13 +0000)]
make busybox autorebuild on relevant config changes

SVN-Revision: 6651

17 years agofix a harmless warning
Felix Fietkau [Fri, 23 Mar 2007 16:48:43 +0000 (16:48 +0000)]
fix a harmless warning

SVN-Revision: 6650

17 years agoadd bcm94710a0 cache workarounds to brcm47xx-2.6 (fix #1502)
Felix Fietkau [Fri, 23 Mar 2007 16:40:42 +0000 (16:40 +0000)]
add bcm94710a0 cache workarounds to brcm47xx-2.6 (fix #1502)

SVN-Revision: 6649

17 years agosome cleanups in the metadata.pl script; allow target profiles to add overrides for...
Felix Fietkau [Fri, 23 Mar 2007 14:48:47 +0000 (14:48 +0000)]
some cleanups in the metadata.pl script; allow target profiles to add overrides for menuconfig

SVN-Revision: 6648

17 years agoadd 'deselect' property for menuconfig
Felix Fietkau [Fri, 23 Mar 2007 14:03:35 +0000 (14:03 +0000)]
add 'deselect' property for menuconfig

SVN-Revision: 6647

17 years agoMake mksyshdr safe for 64bits platforms (#1504)
Florian Fainelli [Fri, 23 Mar 2007 12:50:43 +0000 (12:50 +0000)]
Make mksyshdr safe for 64bits platforms (#1504)

SVN-Revision: 6646

17 years agoFinal image build fixups
Hamish Guthrie [Fri, 23 Mar 2007 10:24:01 +0000 (10:24 +0000)]
Final image build fixups

SVN-Revision: 6644

17 years agofix typo in UnistallDev
Nicolas Thill [Fri, 23 Mar 2007 08:11:08 +0000 (08:11 +0000)]
fix typo in UnistallDev

SVN-Revision: 6643

17 years agoadd more stability fixes for brcm47xx-2.6 on bcm4704 (from #1485)
Felix Fietkau [Fri, 23 Mar 2007 00:08:59 +0000 (00:08 +0000)]
add more stability fixes for brcm47xx-2.6 on bcm4704 (from #1485)

SVN-Revision: 6642

17 years agoAdd CFE runtime detection
Florian Fainelli [Thu, 22 Mar 2007 22:43:11 +0000 (22:43 +0000)]
Add CFE runtime detection

SVN-Revision: 6641

17 years agoAdd firmware generation for other Compex boards based on myloader, thanks to Juhos...
Florian Fainelli [Thu, 22 Mar 2007 21:36:15 +0000 (21:36 +0000)]
Add firmware generation for other Compex boards based on myloader, thanks to Juhos Gabor !

SVN-Revision: 6640

17 years agoadd brcm47xx-2.6 fixes from #1496
Felix Fietkau [Thu, 22 Mar 2007 20:23:17 +0000 (20:23 +0000)]
add brcm47xx-2.6 fixes from #1496

SVN-Revision: 6639

17 years agoAdded rule for objdump Added support for AT91 SD-Card in primary bootloader (romboot)
Hamish Guthrie [Thu, 22 Mar 2007 18:07:01 +0000 (18:07 +0000)]
Added rule for objdump Added support for AT91 SD-Card in primary bootloader (romboot)

SVN-Revision: 6638

17 years agoThere are issues with the CRC calc stuff under x86_64. This version only works on...
Hamish Guthrie [Thu, 22 Mar 2007 17:45:21 +0000 (17:45 +0000)]
There are issues with the CRC calc stuff under x86_64. This version only works on 32-bit architectures.

SVN-Revision: 6637

17 years agoNew program to generate u-boot parameter block with correct CRC to enable reprogrammi...
Hamish Guthrie [Thu, 22 Mar 2007 17:33:29 +0000 (17:33 +0000)]
New program to generate u-boot parameter block with correct CRC to enable reprogramming parameters from Linux.

SVN-Revision: 6636

17 years agoar7 misc fixes: - serial - memory probing
Eugene Konev [Thu, 22 Mar 2007 16:39:07 +0000 (16:39 +0000)]
ar7 misc fixes: - serial - memory probing

SVN-Revision: 6635

17 years agoAlso add squashfs to the possible filesystems to be mounted
Florian Fainelli [Wed, 21 Mar 2007 22:18:07 +0000 (22:18 +0000)]
Also add squashfs to the possible filesystems to be mounted

SVN-Revision: 6634

17 years agoRemove usb support for the moment
Florian Fainelli [Wed, 21 Mar 2007 21:50:58 +0000 (21:50 +0000)]
Remove usb support for the moment

SVN-Revision: 6633

17 years agobackward compatible code, if ssb is not enabled
Florian Fainelli [Wed, 21 Mar 2007 21:29:30 +0000 (21:29 +0000)]
backward compatible code, if ssb is not enabled

SVN-Revision: 6632

17 years agoInclude profiles
Florian Fainelli [Wed, 21 Mar 2007 20:11:00 +0000 (20:11 +0000)]
Include profiles

SVN-Revision: 6631

17 years agoFix a typo
Florian Fainelli [Wed, 21 Mar 2007 18:47:41 +0000 (18:47 +0000)]
Fix a typo

SVN-Revision: 6630

17 years agoEnable profiles for adm5120
Florian Fainelli [Wed, 21 Mar 2007 18:10:55 +0000 (18:10 +0000)]
Enable profiles for adm5120

SVN-Revision: 6629

17 years agoFix warnings and add more detailed informations
Florian Fainelli [Wed, 21 Mar 2007 17:23:34 +0000 (17:23 +0000)]
Fix warnings and add more detailed informations

SVN-Revision: 6628

17 years agoAdd image generation for edimax routers
Florian Fainelli [Wed, 21 Mar 2007 15:04:07 +0000 (15:04 +0000)]
Add image generation for edimax routers

SVN-Revision: 6627

17 years agoAdded primary and secondary bootloaders
Hamish Guthrie [Tue, 20 Mar 2007 09:59:17 +0000 (09:59 +0000)]
Added primary and secondary bootloaders

SVN-Revision: 6626

17 years agoprom_free_prom_memory is useless
Florian Fainelli [Tue, 20 Mar 2007 09:23:43 +0000 (09:23 +0000)]
prom_free_prom_memory is useless

SVN-Revision: 6625

17 years agoUse the bcm947xx mtd driver instead
Florian Fainelli [Tue, 20 Mar 2007 09:00:23 +0000 (09:00 +0000)]
Use the bcm947xx mtd driver instead

SVN-Revision: 6624

17 years agouml now needs init=/etc/preinit, fix example in README
Nicolas Thill [Tue, 20 Mar 2007 01:36:56 +0000 (01:36 +0000)]
uml now needs init=/etc/preinit, fix example in README

SVN-Revision: 6622

17 years agoattempt to fix uml kernel config for i386
Nicolas Thill [Tue, 20 Mar 2007 01:32:09 +0000 (01:32 +0000)]
attempt to fix uml kernel config for i386

SVN-Revision: 6621

17 years agoRe-enable adm5120 mtd driver
Florian Fainelli [Mon, 19 Mar 2007 22:42:23 +0000 (22:42 +0000)]
Re-enable adm5120 mtd driver

SVN-Revision: 6620

17 years agoadd an optional parameter to scan_interfaces() that can override the network config...
Felix Fietkau [Mon, 19 Mar 2007 22:06:31 +0000 (22:06 +0000)]
add an optional parameter to scan_interfaces() that can override the network config file (defaults to 'network')

SVN-Revision: 6619

17 years agoRemove 8250 serial driver, enable software watchdog
Florian Fainelli [Mon, 19 Mar 2007 21:52:40 +0000 (21:52 +0000)]
Remove 8250 serial driver, enable software watchdog

SVN-Revision: 6618

17 years agoCFE-ready mtd driver, needs fixing though, update kernel config
Florian Fainelli [Mon, 19 Mar 2007 21:43:06 +0000 (21:43 +0000)]
CFE-ready mtd driver, needs fixing though, update kernel config

SVN-Revision: 6617

17 years agoFix the baudrate macro
Florian Fainelli [Mon, 19 Mar 2007 19:51:26 +0000 (19:51 +0000)]
Fix the baudrate macro

SVN-Revision: 6616

17 years agoFix the uart patch
Florian Fainelli [Mon, 19 Mar 2007 19:38:12 +0000 (19:38 +0000)]
Fix the uart patch

SVN-Revision: 6615

17 years agoPreliminary ADM5120 support, marked as broken
Florian Fainelli [Mon, 19 Mar 2007 17:34:37 +0000 (17:34 +0000)]
Preliminary ADM5120 support, marked as broken

SVN-Revision: 6614

17 years agoRemove initrd code leftovers. Also fixes "Bad page state" on boot (kernel tried to...
Eugene Konev [Mon, 19 Mar 2007 17:25:06 +0000 (17:25 +0000)]
Remove initrd code leftovers. Also fixes "Bad page state" on boot (kernel tried to free initramfs twice).

SVN-Revision: 6613

17 years agoUpdated content of wireless.tex, next version will have example configs
Nicholas DePetrillo [Mon, 19 Mar 2007 15:35:55 +0000 (15:35 +0000)]
Updated content of wireless.tex, next version will have example configs

SVN-Revision: 6612

17 years agoAdd forgotten part of vlynq irq setup
Eugene Konev [Sun, 18 Mar 2007 16:00:28 +0000 (16:00 +0000)]
Add forgotten part of vlynq irq setup

SVN-Revision: 6606

17 years agoAdd acx package
Eugene Konev [Sun, 18 Mar 2007 14:43:06 +0000 (14:43 +0000)]
Add acx package

SVN-Revision: 6605

17 years agoar7-2.4 cleanup - Switch to generic init scripts (/sbin/mount_root, /bin/firstboot...
Eugene Konev [Sun, 18 Mar 2007 14:18:56 +0000 (14:18 +0000)]
ar7-2.4 cleanup - Switch to generic init scripts (/sbin/mount_root, /bin/firstboot, /etc/preinit), failsafe part moved to /etc/preinit.arch. This should fix #1449 with an added benefit of using mini_fo. - Switch to generic /etc/config/network. - ar7 flashmap: change "OpenWrt" to "rootfs_data", move ar7_mtd_cleanup out of .exit.

SVN-Revision: 6604

17 years agoMove /sys on pivot_root too
Eugene Konev [Sun, 18 Mar 2007 13:47:28 +0000 (13:47 +0000)]
Move /sys on pivot_root too

SVN-Revision: 6603

17 years agoFix a warning
Florian Fainelli [Sun, 18 Mar 2007 13:06:33 +0000 (13:06 +0000)]
Fix a warning

SVN-Revision: 6602

17 years agoAdd bssid fix from #1281
Florian Fainelli [Sun, 18 Mar 2007 12:59:44 +0000 (12:59 +0000)]
Add bssid fix from #1281

SVN-Revision: 6601

17 years agoAdd ar7-2.6 port (marked as broken for now).
Eugene Konev [Sun, 18 Mar 2007 09:40:51 +0000 (09:40 +0000)]
Add ar7-2.6 port (marked as broken for now).

SVN-Revision: 6600

17 years agoAdd srec2bin to firmware-utils
Eugene Konev [Sun, 18 Mar 2007 09:33:39 +0000 (09:33 +0000)]
Add srec2bin to firmware-utils

SVN-Revision: 6599

17 years agoMake lzma-loader sdram mapping configurable (#1169)
Eugene Konev [Sun, 18 Mar 2007 09:32:22 +0000 (09:32 +0000)]
Make lzma-loader sdram mapping configurable (#1169)

SVN-Revision: 6598

17 years agoChanged pin selections in low-level mmc driver
Hamish Guthrie [Sat, 17 Mar 2007 16:19:09 +0000 (16:19 +0000)]
Changed pin selections in low-level mmc driver

SVN-Revision: 6596

17 years agoupgrade dnsmasq to latest version, rewrite dnsmasq init script for uci, rename /bin...
Felix Fietkau [Sat, 17 Mar 2007 13:31:13 +0000 (13:31 +0000)]
upgrade dnsmasq to latest version, rewrite dnsmasq init script for uci, rename /bin/ipcalc to /bin/ipcalc.sh (fixes #1452)

SVN-Revision: 6595

17 years agoremove duplicate section to find bridge name
Travis Kemen [Sat, 17 Mar 2007 03:56:14 +0000 (03:56 +0000)]
remove duplicate section to find bridge name

SVN-Revision: 6591

17 years agofix default netmask
Felix Fietkau [Sat, 17 Mar 2007 03:15:41 +0000 (03:15 +0000)]
fix default netmask

SVN-Revision: 6589

17 years agospeed up package/install
Felix Fietkau [Sat, 17 Mar 2007 02:54:16 +0000 (02:54 +0000)]
speed up package/install

SVN-Revision: 6588

17 years agofix a small bug in the unpack code
Felix Fietkau [Fri, 16 Mar 2007 21:32:59 +0000 (21:32 +0000)]
fix a small bug in the unpack code

SVN-Revision: 6587

17 years agopackage libssp for apps that need it (only enabled for gcc4)
Felix Fietkau [Fri, 16 Mar 2007 20:37:04 +0000 (20:37 +0000)]
package libssp for apps that need it (only enabled for gcc4)

SVN-Revision: 6584

17 years agoremove some debug code that slipped into the commit
Felix Fietkau [Fri, 16 Mar 2007 20:32:32 +0000 (20:32 +0000)]
remove some debug code that slipped into the commit

SVN-Revision: 6583

17 years agoadd file type autodetection for the unpack command and nuke PKG_CAT:= in lots of...
Felix Fietkau [Fri, 16 Mar 2007 20:21:39 +0000 (20:21 +0000)]
add file type autodetection for the unpack command and nuke PKG_CAT:= in lots of places

SVN-Revision: 6582

17 years agore-enable SDK=1 and DEVELOPER=1 overrides for building all packages
Felix Fietkau [Fri, 16 Mar 2007 20:20:19 +0000 (20:20 +0000)]
re-enable SDK=1 and DEVELOPER=1 overrides for building all packages

SVN-Revision: 6581

17 years agoadd a default for PKG_BUILD_DIR and PKG_INSTALL_DIR (will use KERNEL_BUILD_DIR if...
Felix Fietkau [Fri, 16 Mar 2007 19:18:55 +0000 (19:18 +0000)]
add a default for PKG_BUILD_DIR and PKG_INSTALL_DIR (will use KERNEL_BUILD_DIR if kernel.mk is included, BUILD_DIR otherwise)

SVN-Revision: 6580

17 years agoChanged kernel configs to enable more packages. Added additional dependencies to...
Hamish Guthrie [Fri, 16 Mar 2007 18:53:35 +0000 (18:53 +0000)]
Changed kernel configs to enable more packages. Added additional dependencies to mmc module in the modules tree

SVN-Revision: 6579

17 years agoFix compilation errors with xt_portscan
Florian Fainelli [Fri, 16 Mar 2007 18:35:48 +0000 (18:35 +0000)]
Fix compilation errors with xt_portscan

SVN-Revision: 6578

17 years agoFix the serial driver with the devfs removal
Florian Fainelli [Fri, 16 Mar 2007 18:33:46 +0000 (18:33 +0000)]
Fix the serial driver with the devfs removal

SVN-Revision: 6577