Szabolcs Nagy [Mon, 12 Nov 2012 23:49:55 +0000 (00:49 +0100)]
math: raise flags in logl.c on <= 0 arguments
Szabolcs Nagy [Mon, 12 Nov 2012 23:45:51 +0000 (00:45 +0100)]
math: fix logb*.c exceptions now that ilogb raises invalid
Szabolcs Nagy [Mon, 12 Nov 2012 23:30:06 +0000 (00:30 +0100)]
math: raise flags in log2l.c on <= 0 arguments, and fix volatile
Szabolcs Nagy [Mon, 12 Nov 2012 23:21:09 +0000 (00:21 +0100)]
math: raise exception flags in log1pl.c on <= -1 arguments
Szabolcs Nagy [Mon, 12 Nov 2012 22:58:18 +0000 (23:58 +0100)]
math: raise invalid flag in ilogb*.c on +-0, +-inf and nan
Szabolcs Nagy [Mon, 12 Nov 2012 22:41:48 +0000 (23:41 +0100)]
math: fix exception behaviour of expm1l.c on inf and nan
Szabolcs Nagy [Mon, 12 Nov 2012 22:13:28 +0000 (23:13 +0100)]
math: fix long double constants in exp10l.c
Rich Felker [Sun, 11 Nov 2012 21:08:38 +0000 (16:08 -0500)]
debloat src/thread tree but putting lots of junk in one file
POSIX includes mostly-useless attribute-get functions for each
attribute-set function, presumably out of some object-oriented
dogmatism. the get functions are not useful with the simple idiomatic
usage of attributes. there are of course possible valid uses of them
(like writing wrappers for pthread init functions that perform special
actions on the presence of certain attributes), but considering how
tiny these functions are anyway, little is lost by putting them all in
one file, and some build-time cost and archive-file-size benefits are
achieved.
Rich Felker [Sun, 11 Nov 2012 20:54:20 +0000 (15:54 -0500)]
report support of TPS option in unistd.h and sysconf
also update another newish feature in sysconf, stackaddr
Rich Felker [Sun, 11 Nov 2012 20:38:04 +0000 (15:38 -0500)]
add support for thread scheduling (POSIX TPS option)
linux's sched_* syscalls actually implement the TPS (thread
scheduling) functionality, not the PS (process scheduling)
functionality which the sched_* functions are supposed to have.
omitting support for the PS option (and having the sched_* interfaces
fail with ENOSYS rather than omitting them, since some broken software
assumes they exist) seems to be the only conforming way to do this on
linux.
Rich Felker [Sun, 11 Nov 2012 18:56:37 +0000 (13:56 -0500)]
fix clobber of edx in i386 vsyscall asm
this function does not obey the normal calling convention; like a
syscall instruction, it's expected not to clobber any registers except
the return value. clobbering edx could break callers that were reusing
the value cached in edx after the syscall returns.
Rich Felker [Fri, 9 Nov 2012 19:26:25 +0000 (14:26 -0500)]
always add memory streams to stdio open file list
per interpretation for austin group issue #626, fflush(0) and exit()
must block waiting for a lock if another thread has locked a memory
stream with flockfile. this adds some otherwise-unnecessary
synchronization cost to use of memory streams, but there was already a
synchronization cost calling malloc anyway.
previously the stream was only added to the open file list in
single-threaded programs, so that upon subsequent call to
pthread_create, locking could be turned on for the stream.
Rich Felker [Fri, 9 Nov 2012 18:49:40 +0000 (13:49 -0500)]
support ldso path files without final newline
Rich Felker [Fri, 9 Nov 2012 03:41:16 +0000 (22:41 -0500)]
change ldso path file logic to replace rather than add to search path
this change was originally intended just to avoid repeated attempts to
open a nonexistant /etc/ls-musl-$(ARCH).path file, but I realized it
also prevents the default paths from being searched when such a path
file exists. despite the potential to break existing usage, I believe
the new behavior is the right behavior, and it's better to fix it
sooner rather than later. with the old behavior, it was impossible to
inhibit search of default paths which might contain musl-incompatible
libs (or even libs from a different cpu arch, on multi-arch machines).
Rich Felker [Thu, 8 Nov 2012 22:20:50 +0000 (17:20 -0500)]
fix "configure --prefix=" and improve path/arg handling in configure
previously, empty string was treated as "use default". this is
apparently not compatible with standard configure semantics where an
empty prefix puts everything under /. the new logic should be a lot
cleaner and not suffer from such issues.
Rich Felker [Thu, 8 Nov 2012 22:04:20 +0000 (17:04 -0500)]
clean up sloppy nested inclusion from pthread_impl.h
this mirrors the stdio_impl.h cleanup. one header which is not
strictly needed, errno.h, is left in pthread_impl.h, because since
pthread functions return their error codes rather than using errno,
nearly every single pthread function needs the errno constants.
in a few places, rather than bringing in string.h to use memset, the
memset was replaced by direct assignment. this seems to generate much
better code anyway, and makes many functions which were previously
non-leaf functions into leaf functions (possibly eliminating a great
deal of bloat on some platforms where non-leaf functions require ugly
prologue and/or epilogue).
Rich Felker [Thu, 8 Nov 2012 21:39:41 +0000 (16:39 -0500)]
clean up stdio_impl.h
this header evolved to facilitate the extremely lazy practice of
omitting explicit includes of the necessary headers in individual
stdio source files; not only was this sloppy, but it also increased
build time.
now, stdio_impl.h is only including the headers it needs for its own
use; any further headers needed by source files are included directly
where needed.
Rich Felker [Thu, 8 Nov 2012 19:31:49 +0000 (14:31 -0500)]
fix dlsym asm for mips
saving the return address from the delay slot is not valid -- by the
time the instruction executes, the return address has already been
replaced.
Rich Felker [Mon, 5 Nov 2012 19:30:15 +0000 (14:30 -0500)]
improve SOCK_NONBLOCK/SOCK_CLOEXEC fallback code
checking for EINVAL should be sufficient, but qemu user emulation
returns EPROTONOSUPPORT in some of the failure cases, and it seems
conceivable that other kernels doing linux-emulation could make the
same mistake. since DNS lookups and other important code might break
if the fallback does not get invoked, be extra careful and check for
either error.
note that it's important NOT to perform the fallback code on other
errors such as resource-exhaustion cases, since the fallback is not
atomic and will lead to file-descriptor leaks in multi-threaded
programs that use exec. the fallback code is only "safe" to run when
the initial failure is caused by the application's choice of
arguments, not the system state.
Rich Felker [Mon, 5 Nov 2012 19:29:04 +0000 (14:29 -0500)]
fix numerous mips abi constant definition mismatches
Rich Felker [Sun, 4 Nov 2012 22:06:31 +0000 (17:06 -0500)]
mips cache flush/ctl syscall support and header
Rich Felker [Fri, 2 Nov 2012 03:49:57 +0000 (23:49 -0400)]
remove one unnecessary static var from dynamic linker
Rich Felker [Fri, 2 Nov 2012 03:46:39 +0000 (23:46 -0400)]
fix more unused variable warnings
some of these were coming from stdio functions locking files without
unlocking them. I believe it's useful for this to throw a warning, so
I added a new macro that's self-documenting that the file will never
be unlocked to avoid the warning in the few places where it's wrong.
Rich Felker [Fri, 2 Nov 2012 02:58:17 +0000 (22:58 -0400)]
fix unused variable warnings
Rich Felker [Thu, 1 Nov 2012 07:49:43 +0000 (03:49 -0400)]
avoid breakage if somebody wrongly defines empty feature test macros
Rich Felker [Thu, 1 Nov 2012 01:27:48 +0000 (21:27 -0400)]
add dl_iterate_phdr interface
patches by Alex Caudill (npx). the dynamic-linked version is almost
identical to the final submitted patch; I just added a couple missing
lines for saving the phdr address when the dynamic linker is invoked
directly to run a program, and removed a couple to avoid introducing
another unnecessary type. the static-linked version is based on npx's
draft. it could use some improvements which are contingent on the
startup code saving some additional information for later use.
Rich Felker [Mon, 29 Oct 2012 01:17:45 +0000 (21:17 -0400)]
system is a cancellation point
ideally, system would also be cancellable while running the external
command, but I cannot find any way to make that work without either
leaking zombie processes or introducing behavior that is far outside
what the standard specifies. glibc handles cancellation by killing the
child process with SIGKILL, but this could be unsafe in that it could
leave the data being manipulated by the command in an inconsistent
state.
Rich Felker [Sun, 28 Oct 2012 22:45:11 +0000 (18:45 -0400)]
release notes for 0.9.7
Rich Felker [Sun, 28 Oct 2012 19:04:26 +0000 (15:04 -0400)]
fix shmdt syscall calling convention on old archs
Rich Felker [Sat, 27 Oct 2012 23:52:40 +0000 (19:52 -0400)]
separate getc/putc from fgetc/fputc
for conformance, two functions should not have the same address. a
conforming program could use the addresses of getc and fgetc in ways
that assume they are distinct. normally i would just use a wrapper,
but these functions are so small and performance-critical that an
extra layer of function call could make the one that's a wrapper
nearly twice as slow, so I'm just duplicating the code instead.
Rich Felker [Sat, 27 Oct 2012 00:14:19 +0000 (20:14 -0400)]
update documentation
Rich Felker [Fri, 26 Oct 2012 22:15:51 +0000 (18:15 -0400)]
further pcc fixes in configure
-lpcc only works if -nostdlib is not passed, so it's useless. instead,
use -print-file-name to look up the full pathname for libpcc.a, and
check whether that succeeds before trying to link with the result.
also, silence pcc's junk printed on stdout during tests.
Rich Felker [Fri, 26 Oct 2012 20:30:07 +0000 (16:30 -0400)]
add support for detecting pcc's compiler runtime
in old versions of pcc, the directory containing libpcc.a was not in
the library path, and other options like -print-file-name may have
been needed to locate it. however, -print-file-name itself seems to
have been added around the same time that the directory was added to
the search path, and moreover, I see no evidence that older versions
of pcc are capable of building a working musl shared library. thus, it
seems reasonable to just test whether -lpcc is accepted.
Rich Felker [Thu, 25 Oct 2012 19:40:58 +0000 (15:40 -0400)]
use explicit visibility to optimize a few hot-path function calls
on x86 and some other archs, functions which make function calls which
might go through a PLT incur a significant overhead cost loading the
GOT register prior to making the call. this load is utterly useless in
musl, since all calls are bound at library-creation time using
-Bsymbolic-functions, but the compiler has no way of knowing this, and
attempts to set the default visibility to protected have failed due to
bugs in GCC and binutils.
this commit simply manually assigns hidden/protected visibility, as
appropriate, to a few internal-use-only functions which have many
callers, or which have callers that are hot paths like getc/putc. it
shaves about 5k off the i386 libc.so with -Os. many of the
improvements are in syscall wrappers, where the benefit is just size
and performance improvement is unmeasurable noise amid the syscall
overhead. however, stdio may be measurably faster.
if in the future there are toolchains that can do the same thing
globally without introducing linking bugs, it might be worth
considering removing these workarounds.
Rich Felker [Thu, 25 Oct 2012 18:52:12 +0000 (14:52 -0400)]
configure: test not just compiling but linking with -march/-mtune
pcc wrongly passes any option beginning with -m to the linker, and
will break at link time if these options were added to CFLAGS. testing
linking lets us catch this at configure time and skip them.
Rich Felker [Thu, 25 Oct 2012 03:16:41 +0000 (23:16 -0400)]
correct locking in stdio functions that tried to be lock-free
these functions must behave as if they obtain the lock via flockfile
to satisfy POSIX requirements. since another thread can provably hold
the lock when they are called, they must wait to obtain the lock
before they can return, even if the correct return value could be
obtained without locking. in the case of fclose and freopen, failure
to do so could cause correct (albeit obscure) programs to crash or
otherwise misbehave; in the case of feof, ferror, and fwide, failure
to obtain the lock could sometimes return incorrect results. in any
case, having these functions proceed and return while another thread
held the lock was wrong.
Rich Felker [Thu, 25 Oct 2012 01:16:06 +0000 (21:16 -0400)]
greatly improve freopen behavior
1. don't open /dev/null just as a basis to copy flags; use shared
__fmodeflags function to get the right file flags for the mode.
2. handle the case (probably invalid, but whatever) case where the
original stream's file descriptor was closed; previously, the logic
re-closed it.
3. accept the "e" mode flag for close-on-exec; update dup3 to fallback
to using dup2 so we can simply call __dup3 instead of putting fallback
logic in freopen itself.
Rich Felker [Thu, 25 Oct 2012 00:03:43 +0000 (20:03 -0400)]
remove useless failure-check from freopen (can't happen)
Rich Felker [Mon, 22 Oct 2012 19:17:09 +0000 (15:17 -0400)]
simplify logic in stpcpy; avoid copying first aligned byte twice
gcc seems to be generating identical or near-identical code for both
versions, but the newer code is more expressive of what it's doing.
Rich Felker [Sun, 21 Oct 2012 23:15:11 +0000 (19:15 -0400)]
fix issues with wait constants in stdlib.h
the W* namespace is not reserved, so the nonstandard ones must be
moved under extension features. also WNOHANG and WUNTRACED were
missing.
Rich Felker [Sun, 21 Oct 2012 22:37:15 +0000 (18:37 -0400)]
as an extension, have putenv("VAR") behave as unsetenv("VAR")
the behavior of putenv is left undefined if the argument does not
contain an equal sign, but traditional implementations behave this way
and gnulib replaces putenv if it doesn't do this.
Rich Felker [Sun, 21 Oct 2012 22:28:20 +0000 (18:28 -0400)]
accept "nan(n-char-sequence)" in strtod/scanf functions
this will prevent gnulib from wrapping our strtod to handle this
useless feature.
Rich Felker [Sun, 21 Oct 2012 17:23:03 +0000 (13:23 -0400)]
fix copy/paste error in popen changes that broke signals
signal mask was not being restored after fork, but instead blocked again.
nsz [Sun, 21 Oct 2012 00:31:04 +0000 (02:31 +0200)]
complex: make _Complex_I work with gcc -std=c99 -pedantic-errors
Rich Felker [Sat, 20 Oct 2012 01:57:56 +0000 (21:57 -0400)]
support looking up thread-local objects with dlsym
Rich Felker [Sat, 20 Oct 2012 01:41:30 +0000 (21:41 -0400)]
fix breakage in dlsym for looking up RTLD_DEFAULT, etc.
this was broken during the early dynamic-linked TLS commits, which
rearranged some of the code for handling new relocation types.
Rich Felker [Fri, 19 Oct 2012 22:52:14 +0000 (18:52 -0400)]
fix struct stat size/padding on microblaze
Rich Felker [Fri, 19 Oct 2012 19:02:37 +0000 (15:02 -0400)]
fix usage of locks with vfork
__release_ptc() is only valid in the parent; if it's performed in the
child, the lock will be unlocked early then double-unlocked later,
corrupting the lock state.
Rich Felker [Fri, 19 Oct 2012 05:33:52 +0000 (01:33 -0400)]
fix crashes in static-linked multithreaded programs without TLS
Rich Felker [Fri, 19 Oct 2012 04:27:03 +0000 (00:27 -0400)]
fix order of syscall args for microblaze clone syscall
with this commit, based on testing with patches to qemu which are not
yet upstream,
Rich Felker [Fri, 19 Oct 2012 03:02:53 +0000 (23:02 -0400)]
use $CC rather than "$CC" in configure script
this is necessary to allow $CC with arguments in it
Rich Felker [Fri, 19 Oct 2012 02:13:36 +0000 (22:13 -0400)]
inline syscalls for microblaze
Rich Felker [Fri, 19 Oct 2012 02:01:24 +0000 (22:01 -0400)]
ensure microblaze __set_thread_area returns success
since it did not set the return-value register, the caller could
wrongly interpret this as failure.
Rich Felker [Fri, 19 Oct 2012 01:50:55 +0000 (21:50 -0400)]
better support for reverse-endian variants of arm/mips/microblaze
these macros are supported by more compilers
Rich Felker [Fri, 19 Oct 2012 00:26:41 +0000 (20:26 -0400)]
avoid raising spurious division-by-zero exception in printf
Rich Felker [Fri, 19 Oct 2012 00:19:53 +0000 (20:19 -0400)]
floating point environment/exceptions support for mips
Rich Felker [Thu, 18 Oct 2012 20:41:27 +0000 (16:41 -0400)]
fix parent-memory-clobber in posix_spawn (environ)
Rich Felker [Thu, 18 Oct 2012 19:58:23 +0000 (15:58 -0400)]
overhaul system() and popen() to use vfork; fix various related bugs
since we target systems without overcommit, special care should be
taken that system() and popen(), like posix_spawn(), do not fail in
processes whose commit charges are too high to allow ordinary forking.
this in turn requires special precautions to ensure that the parent
process's signal handlers do not end up running in the shared-memory
child, where they could corrupt the state of the parent process.
popen has also been updated to use pipe2, so it does not have a
fd-leak race in multi-threaded programs. since pipe2 is missing on
older kernels, (non-atomic) emulation has been added.
some silly bugs in the old code should be gone too.
Rich Felker [Thu, 18 Oct 2012 04:09:36 +0000 (00:09 -0400)]
fix (hopefully; untested) completely broken/incomplete microblaze sigsetjmp
Rich Felker [Thu, 18 Oct 2012 03:45:21 +0000 (23:45 -0400)]
fix microblaze asm relocations for shared libc
only @PLT relocations are considered functions for purposes of
-Bsymbolic-functions, so always use @PLT. it should not hurt in the
static-linked case.
Rich Felker [Wed, 17 Oct 2012 06:47:11 +0000 (02:47 -0400)]
assert() is supposed to have type void
Rich Felker [Tue, 16 Oct 2012 03:02:57 +0000 (23:02 -0400)]
add memmem function (gnu extension)
based on strstr. passes gnulib tests and a few quick checks of my own.
Rich Felker [Tue, 16 Oct 2012 01:01:48 +0000 (21:01 -0400)]
microblaze TLS relocation support, completely untested
Rich Felker [Mon, 15 Oct 2012 22:51:53 +0000 (18:51 -0400)]
add support for TLS variant I, presently needed for arm and mips
despite documentation that makes it sound a lot different, the only
ABI-constraint difference between TLS variants II and I seems to be
that variant II stores the initial TLS segment immediately below the
thread pointer (i.e. the thread pointer points to the end of it) and
variant I stores the initial TLS segment above the thread pointer,
requiring the thread descriptor to be stored below. the actual value
stored in the thread pointer register also tends to have per-arch
random offsets applied to it for silly micro-optimization purposes.
with these changes applied, TLS should be basically working on all
supported archs except microblaze. I'm still working on getting the
necessary information and a working toolchain that can build TLS
binaries for microblaze, but in theory, static-linked programs with
TLS and dynamic-linked programs where only the main executable uses
TLS should already work on microblaze.
alignment constraints have not yet been heavily tested, so it's
possible that this code does not always align TLS segments correctly
on archs that need TLS variant I.
Rich Felker [Mon, 15 Oct 2012 15:42:46 +0000 (11:42 -0400)]
block uid/gid changes during posix_spawn
usage of vfork creates a situation where a process of lower privilege
may momentarily have write access to the memory of a process of higher
privilege.
consider the case of a multi-threaded suid program which is calling
posix_spawn in one thread while another thread drops the elevated
privileges then runs untrusted (relative to the elevated privilege)
code as the original invoking user. this untrusted code can then
potentially modify the data the child process will use before calling
exec, for example changing the pathname or arguments that will be
passed to exec.
note that if vfork is implemented as fork, the lock will not be held
until the child execs, but since memory is not shared it does not
matter.
Rich Felker [Mon, 15 Oct 2012 01:10:44 +0000 (21:10 -0400)]
fix overlap of thread stacks with thread tls segments
Rich Felker [Sun, 14 Oct 2012 23:56:50 +0000 (19:56 -0400)]
fix main program TLS alignment for dynamic-linked programs
this change brings the behavior in line with the static-linked code,
which seems to be correct.
Rich Felker [Sun, 14 Oct 2012 03:53:18 +0000 (23:53 -0400)]
workaround broken hidden-visibility handling in pcc
with this change, pcc-built musl libc.so seems to work correctly. the
problem is that pcc generates GOT lookups for external-linkage symbols
even if they are hidden, rather than using GOT-relative addressing.
the entire reason we're using hidden visibility on the __libc object
is to make it accessible prior to relocations -- not to mention
inexpensive to access. unfortunately, the workaround makes it even
more expensive on pcc.
when the pcc issue is fixed, an appropriate version test should be
added so new pcc can use the much more efficient variant.
Rich Felker [Sun, 14 Oct 2012 03:46:51 +0000 (23:46 -0400)]
ensure pointer decay in inline-asm arg for i386 syscall6
this is actually a rather subtle issue: do arrays decay to pointers
when used as inline asm args? gcc says yes, but currently pcc says no.
hopefully this discrepency in pcc will be fixed, but since the
behavior is not clearly defined anywhere I can find, I'm using an
explicit operation to cause the decay to occur.
Rich Felker [Sun, 14 Oct 2012 03:25:20 +0000 (23:25 -0400)]
fix namespace clash (libc) in dynlink.c
this makes it so the #undef libc and __libc name are no longer needed,
which were problematic because the "accessor function" mode for
accessing the libc struct could not be used, breaking build on any
compiler without (working) visibility.
Rich Felker [Sun, 14 Oct 2012 03:23:29 +0000 (23:23 -0400)]
remove dead code from dynamic linker
Rich Felker [Fri, 12 Oct 2012 03:09:17 +0000 (23:09 -0400)]
comment possibly-confusing i386 vsyscall asm
Rich Felker [Fri, 12 Oct 2012 02:51:05 +0000 (22:51 -0400)]
avoid the thread-ptr-init behavior of sigaction when not installing handler
this is necessary because posix_spawn calls sigaction after vfork, and
if the thread pointer is not already initialized, initializing it in
the child corrupts the parent process's state.
Rich Felker [Fri, 12 Oct 2012 02:47:07 +0000 (22:47 -0400)]
i386 vsyscall support (vdso-provided sysenter/syscall instruction based)
this doubles the performance of the fastest syscalls on the atom I
tested it on; improvement is reportedly much more dramatic on
worst-case cpus. cannot be used for cancellable syscalls.
Rich Felker [Mon, 8 Oct 2012 15:20:31 +0000 (11:20 -0400)]
ensure that buffer for decoding auxv at startup is initially zero
Rich Felker [Mon, 8 Oct 2012 01:43:46 +0000 (21:43 -0400)]
clean up and refactor program initialization
the code in __libc_start_main is now responsible for parsing auxv,
rather than duplicating the parsing all over the place. this should
shave off a few cycles and some code size. __init_libc is left as an
external-linkage function despite the fact that it could be static, to
prevent it from being inlined and permanently wasting stack space when
main is called.
a few other minor changes are included, like eliminating per-thread
ssp canaries (they were likely broken when combined with certain
dlopen usages, and completely unnecessary) and some other unnecessary
checks. since this code gets linked into every program, it should be
as small and simple as possible.
Rich Felker [Mon, 8 Oct 2012 00:19:11 +0000 (20:19 -0400)]
fix breakage due to initializing thread pointer when loading libs
at initial program load, all libraries must be loaded before the
thread pointer can be setup, since the TP-relative addresses of all
initial TLS objects must be constant.
Rich Felker [Sun, 7 Oct 2012 03:57:51 +0000 (23:57 -0400)]
make new TLS setup block even implementation-internals signals
this is needed to ensure async-cancel-safety, i.e. to make it safe to
access TLS objects when async cancellation is enabled. otherwise, if
cancellation were acter upon after the atomic fetch/add but before the
thread saved the obtained memory, another access to the same TLS in
the cancellation handler could end up performing the atomic fetch/add
again, consuming more memory than is actually available and
overflowing into other objects on the heap.
Rich Felker [Sat, 6 Oct 2012 20:56:35 +0000 (16:56 -0400)]
don't crash if TLS library is loaded into process with no thread pointer
Rich Felker [Sat, 6 Oct 2012 20:51:03 +0000 (16:51 -0400)]
fix buggy TLS size/alignment computations in static-linked TLS
Rich Felker [Sat, 6 Oct 2012 05:36:11 +0000 (01:36 -0400)]
fix symbol acceptance/rejection rules for TLS
symbol value of 0 is not "undefined" for TLS; it's the address of the
first symbol in the TLS segment. however, non-definition TLS
references also have values of 0, so check the section.
hopefully the new logic is more clear, too.
Rich Felker [Sat, 6 Oct 2012 05:22:51 +0000 (01:22 -0400)]
TLS fixes, mainly alignment handling
compute offsets from the thread pointer statically when loading the
library, rather than repeating the logic on each thread creation. not
only is the latter less efficient at runtime; it also fails to provide
solid guarantees that the offsets will remain the same when the
initial alignment of memory is different. the new alignment handling
is both more rigorous and simpler.
the old code was also clobbering TLS bss with random image data in
some cases due to using tls_size (size of TLS segment) instead of
tls_len (length of the TLS data image).
Rich Felker [Fri, 5 Oct 2012 17:09:09 +0000 (13:09 -0400)]
fix/improve shared library ctor/dtor handling, allow recursive dlopen
some libraries call dlopen from their constructors, resulting in
recursive calls to dlopen. previously, this resulted in deadlock. I'm
now unlocking the dlopen lock before running constructors (this is
especially important since the lock also blocked pthread_create and
was being held while application code runs!) and using a separate
recursive mutex protecting the ctor/dtor state instead.
in order to prevent the same ctor from being called more than once, a
module is considered "constructed" just before the ctor runs.
also, switch from using atexit to register each dtor to using a single
atexit call to register the dynamic linker's dtor processing as just
one handler. this is necessary because atexit performs allocation and
may fail, but the library has already been loaded and cannot be
backed-out at the time dtor registration is performed. this change
also ensures that all dtors run after all atexit functions, rather
than in mixed order.
Rich Felker [Fri, 5 Oct 2012 16:09:54 +0000 (12:09 -0400)]
small dynamic linker module search fix
libraries loaded more than once by pathname should not get shortnames
that would cause them to later be used to satisfy non-pathname load
requests.
Rich Felker [Fri, 5 Oct 2012 15:51:50 +0000 (11:51 -0400)]
support for TLS in dynamic-loaded (dlopen) modules
unlike other implementations, this one reserves memory for new TLS in
all pre-existing threads at dlopen-time, and dlopen will fail with no
resources consumed and no new libraries loaded if memory is not
available. memory is not immediately distributed to running threads;
that would be too complex and too costly. instead, assurances are made
that threads needing the new TLS can obtain it in an async-signal-safe
way from a buffer belonging to the dynamic linker/new module (via
atomic fetch-and-add based allocator).
I've re-appropriated the lock that was previously used for __synccall
(synchronizing set*id() syscalls between threads) as a general
pthread_create lock. it's a "backwards" rwlock where the "read"
operation is safe atomic modification of the live thread count, which
multiple threads can perform at the same time, and the "write"
operation is making sure the count does not increase during an
operation that depends on it remaining bounded (__synccall or dlopen).
in static-linked programs that don't use __synccall, this lock is a
no-op and has no cost.
Rich Felker [Fri, 5 Oct 2012 05:15:25 +0000 (01:15 -0400)]
fix race condition in dlopen
orig_tail was being saved before the lock was obtained, allowing
dlopen failure to roll-back other dlopens that had succeeded.
Rich Felker [Fri, 5 Oct 2012 05:00:40 +0000 (01:00 -0400)]
fix incorrect TLS reloc macro names in x86_64 reloc.h
Rich Felker [Fri, 5 Oct 2012 02:48:33 +0000 (22:48 -0400)]
dynamic-linked TLS support for everything but dlopen'd libs
currently, only i386 is tested. x86_64 and arm should probably work.
the necessary relocation types for mips and microblaze have not been
added because I don't understand how they're supposed to work, and I'm
not even sure if it's defined yet on microblaze. I may be able to
reverse engineer the requirements out of gcc/binutils output.
Rich Felker [Fri, 5 Oct 2012 01:08:53 +0000 (21:08 -0400)]
remove freeing of dynamic linker data when dlopen/dlsym are not used
this was an optimization to save/recover a minimal amount of extra
memory for use by malloc, that's becoming increasingly costly to keep
around. freeing this data:
1. breaks debugging with gdb (it can't find library symbols)
2. breaks thread-local storage in shared libraries
it would be possible to disable freeing when TLS is used, but in
addition to the above breakages, tracking whether dlopen/dlsym is used
adds a cost to every symbol lookup, possibly making program startup
slower for large programs. combined with the complexity, it's not
worth it. we already save/recover plenty of memory in the dynamic
linker with reclaim_gaps.
Rich Felker [Fri, 5 Oct 2012 01:01:56 +0000 (21:01 -0400)]
beginnings of full TLS support in shared libraries
this code will not work yet because the necessary relocations are not
supported, and cannot be supported without some internal changes to
how relocation processing works (coming soon).
Rich Felker [Fri, 5 Oct 2012 00:04:13 +0000 (20:04 -0400)]
partial TLS support for dynamic-linked programs
only TLS in the main program is supported so far; TLS defined in
shared libraries will not work yet.
Rich Felker [Thu, 4 Oct 2012 20:35:46 +0000 (16:35 -0400)]
TLS (GNU/C11 thread-local storage) support for static-linked programs
the design for TLS in dynamic-linked programs is mostly complete too,
but I have not yet implemented it. cost is nonzero but still low for
programs which do not use TLS and/or do not use threads (a few hundred
bytes of new code, plus dependency on memcpy). i believe it can be
made smaller at some point by merging __init_tls and __init_security
into __libc_start_main and avoiding duplicate auxv-parsing code.
at the same time, I've also slightly changed the logic pthread_create
uses to allocate guard pages to ensure that guard pages are not
counted towards commit charge.
Rich Felker [Wed, 3 Oct 2012 15:49:58 +0000 (11:49 -0400)]
tell the assembler to mark all files as not requiring executable stack
for some reason this option is undocumented. not sure when it was
added, so I'm using a configure test. gcc was already setting the mark
correctly for C files, but assembler source files would need ugly
.note boilerplate in every single file to achieve this without the
option to the assembler.
blame whoever thought it would be a good idea to make the stack
executable by default rather than doing it the other way around...
Rich Felker [Mon, 1 Oct 2012 00:00:38 +0000 (20:00 -0400)]
add getopt reset support
based on proposed patches by Daniel Cegiełka, with minor changes:
- use a weak symbol for optreset so it doesn't clash with namespace
- also reset optpos (position in multi-option arg like -lR)
- also make getopt_long support reset
Rich Felker [Sun, 30 Sep 2012 23:44:45 +0000 (19:44 -0400)]
protect sem_open against cancellation
also fix one minor bug: failure to free the early-reserved slot when
the semaphore later found to already be mapped.
Rich Felker [Sun, 30 Sep 2012 23:35:40 +0000 (19:35 -0400)]
overhaul sem_open
this function was overly complicated and not even obviously correct.
avoid using openat/linkat just like in shm_open, and instead expand
pathname using code shared with shm_open. remove bogus (and dangerous,
with priorities) use of spinlocks.
this commit also heavily streamlines the code and ensures there are no
failure cases that can happen after a new semaphore has been created
in the filesystem, since that case is unreportable.
Rich Felker [Sun, 30 Sep 2012 21:53:54 +0000 (17:53 -0400)]
clean up, bugfixes, and general improvement for shm_open/shm_unlink
1. don't make non-cloexec file descriptors
2. cancellation safety (cleanup handlers were missing, now unneeded)
3. share name validation/mapping code between open/unlink functions
4. avoid wasteful/slow syscalls
Rich Felker [Sun, 30 Sep 2012 05:52:17 +0000 (01:52 -0400)]
define some _POSIX_* macros that were omitted; required for XSI conformance
Rich Felker [Sat, 29 Sep 2012 22:14:46 +0000 (18:14 -0400)]
more close-on-exec fixes, mostly using new "e" flag to fopen
Rich Felker [Sat, 29 Sep 2012 22:09:34 +0000 (18:09 -0400)]
add 'e' modifier (close-on-exec) to fopen and fdopen
this feature will be in the next version of POSIX, and can be used
internally immediately. there are many internal uses of fopen where
close-on-exec is needed to fix bugs.