oweals/busybox.git
18 years agoUpdate ipaddr help to match reality.
Rob Landley [Thu, 30 Mar 2006 01:59:30 +0000 (01:59 -0000)]
Update ipaddr help to match reality.

18 years agofix from David Daney, on busybox mailing list:
Paul Fox [Wed, 29 Mar 2006 23:01:33 +0000 (23:01 -0000)]
fix from David Daney, on busybox mailing list:
 > The problem is that if the zcip protocol times out at about the same
 > time another ARP packet is being received, the newly calculated timeout
 > may be set to wait forever.  This prevents the protocol from progressing
 > through its various states.
 >
 > The Fix is to set the timeout to zero if it used to be a positive
 > number, but it has already expired.  This causes the next protocol state
 > to be entered immediately instead of never.
 >
 > If OK please commit.
 >
 > Also note that if you may have to apply the patch on this page:
 >
 > http://www.science.uva.nl/research/air/wiki/LinkLocalARPMeasurements
 >
 > To the linux kernel to get proper zcip behavior.
 >

18 years ago- Rich Felker writes: fix invalid printf format strings
Bernhard Reutner-Fischer [Wed, 29 Mar 2006 22:34:47 +0000 (22:34 -0000)]
- Rich Felker writes: fix invalid printf format strings
  http://busybox.net/lists/busybox/2006-March/019568.html

   text    data     bss     dec     hex filename
 900619   10316 1038724 1949659  1dbfdb busybox.oorig
 900603   10316 1038724 1949643  1dbfcb busybox

18 years ago- warn a bit more verbosely about fmt stuff for non-release versions
Bernhard Reutner-Fischer [Wed, 29 Mar 2006 22:28:27 +0000 (22:28 -0000)]
- warn a bit more verbosely about fmt stuff for non-release versions

18 years ago- mark trunk as 1.2.0-pre0
Bernhard Reutner-Fischer [Wed, 29 Mar 2006 22:22:37 +0000 (22:22 -0000)]
- mark trunk as 1.2.0-pre0

18 years agoadd public-domain release 1_1_0 1_1_1
Paul Fox [Wed, 29 Mar 2006 19:54:02 +0000 (19:54 -0000)]
add public-domain release

18 years ago- we only need obj_gpl_license if ENABLE_FEATURE_CHECK_TAINTED_MODULE is set
Bernhard Reutner-Fischer [Wed, 29 Mar 2006 18:57:09 +0000 (18:57 -0000)]
- we only need obj_gpl_license if ENABLE_FEATURE_CHECK_TAINTED_MODULE is set

18 years ago- shrink mkswap and make v0 support optional. Thanks also to Tito for his ideas.
Bernhard Reutner-Fischer [Wed, 29 Mar 2006 17:32:24 +0000 (17:32 -0000)]
- shrink mkswap and make v0 support optional. Thanks also to Tito for his ideas.
  http://busybox.net/lists/busybox/2006-March/019326.html

   2137       8      28    2173     87d util-linux/mkswap.o.orig
   1890       8      28    1926     786 util-linux/mkswap.o.v0+v1
   1560       4      28    1592     638 util-linux/mkswap.o.v1

18 years ago- shrink dmesg a bit.
Bernhard Reutner-Fischer [Wed, 29 Mar 2006 17:26:14 +0000 (17:26 -0000)]
- shrink dmesg a bit.
  http://busybox.net/lists/busybox/2006-March/019477.html

18 years agoMore extern removal from Robert P. Day.
Rob Landley [Wed, 29 Mar 2006 16:52:56 +0000 (16:52 -0000)]
More extern removal from Robert P. Day.

18 years agofind ./ -name .cvsignore | xargs svn rm
Bernhard Reutner-Fischer [Wed, 29 Mar 2006 15:51:19 +0000 (15:51 -0000)]
find ./ -name .cvsignore | xargs svn rm

18 years agoDocumentation from Jan Kiszka
Rob Landley [Wed, 29 Mar 2006 15:35:23 +0000 (15:35 -0000)]
Documentation from Jan Kiszka

18 years agoKumar Gala tracked down a problem with NFS mounting. This is a different fix
Rob Landley [Wed, 29 Mar 2006 14:30:49 +0000 (14:30 -0000)]
Kumar Gala tracked down a problem with NFS mounting.  This is a different fix
from his, but to the same problem.

18 years agoMike Frysinger pointed out we can go
Rob Landley [Tue, 28 Mar 2006 19:40:15 +0000 (19:40 -0000)]
Mike Frysinger pointed out we can go
  CFLAGS=-I/usr/some/funky/path/to/selinux \
  LDFLAGS=-L/usr/some/funky/path/to/selinux make
So Jan Kiszka reverted part of the selinux patch.

18 years agoBernhard Fischer spotted that we shouldn't free fstype if we didn't allocate
Rob Landley [Tue, 28 Mar 2006 19:19:19 +0000 (19:19 -0000)]
Bernhard Fischer spotted that we shouldn't free fstype if we didn't allocate
it.

18 years agofix behavior of ZZ, with respect to readonly mode(s). original
Paul Fox [Tue, 28 Mar 2006 14:18:21 +0000 (14:18 -0000)]
fix behavior of ZZ, with respect to readonly mode(s).  original
patch and report from Alexander Griesser.

18 years agoremove some more config code rob missed in rev 13701 cleanup as reported by Robert...
Mike Frysinger [Tue, 28 Mar 2006 06:11:51 +0000 (06:11 -0000)]
remove some more config code rob missed in rev 13701 cleanup as reported by Robert P. J. Day

18 years agojust whitespace fixes
Mike Frysinger [Tue, 28 Mar 2006 02:35:56 +0000 (02:35 -0000)]
just whitespace fixes

18 years agosetlogcons, from Jan Kaszka.
Rob Landley [Mon, 27 Mar 2006 23:23:43 +0000 (23:23 -0000)]
setlogcons, from Jan Kaszka.

18 years agoMention that 1.1.2 should be out Juneish.
Rob Landley [Mon, 27 Mar 2006 23:22:16 +0000 (23:22 -0000)]
Mention that 1.1.2 should be out Juneish.

18 years agoensure that corrupted file extraction causes both a message and
Paul Fox [Mon, 27 Mar 2006 23:09:14 +0000 (23:09 -0000)]
ensure that corrupted file extraction causes both a message and
a failure exit code.  delay the error exit until all (good) files
have been extracted.

filesystem errors (nodes of wrong type, permission problems, etc)
still cause immediate failure.

18 years agoMore from Jan Kiszka: this is a port of the latest sysv-init SELinux patch.
Rob Landley [Mon, 27 Mar 2006 23:09:12 +0000 (23:09 -0000)]
More from Jan Kiszka: this is a port of the latest sysv-init SELinux patch.
It makes busybox invoke the libselinux library function to load the binary
policy right at system start-up. It was successfully tested on a mini-SELinux
system.  Note: requires recent libselinux. I'm using 1.28.

18 years agoFrom Jan Kiszka: This patch fixes the security labelling of the login terminal
Rob Landley [Mon, 27 Mar 2006 23:04:42 +0000 (23:04 -0000)]
From Jan Kiszka: This patch fixes the security labelling of the login terminal
and process... There still remains some stuff to clean up (the whole
set_current_security_context() appears unnecessary complex to me), but this is
now at least working.

18 years agoPatch from Jan Kiszka: In case the libselinux development installation is not
Rob Landley [Mon, 27 Mar 2006 23:00:32 +0000 (23:00 -0000)]
Patch from Jan Kiszka: In case the libselinux development installation is not
located at its default location, this patch allows to override the path via
SELINUX_INC and SELINUX_LIB when invoking make.

18 years agoSoftware Freedom Law Center and the fixes.patch thing.
Rob Landley [Mon, 27 Mar 2006 22:43:40 +0000 (22:43 -0000)]
Software Freedom Law Center and the fixes.patch thing.

18 years agoadd support for :wn (initial patch from Alexander Griesser)
Paul Fox [Mon, 27 Mar 2006 21:51:16 +0000 (21:51 -0000)]
add support for :wn  (initial patch from Alexander Griesser)

18 years agodrop obsolete version string in favor of actual BB version (from
Paul Fox [Mon, 27 Mar 2006 20:29:33 +0000 (20:29 -0000)]
drop obsolete version string in favor of actual BB version (from
Bernhard Fischer)

18 years agoTurn #if 0 into a comment.
Rob Landley [Mon, 27 Mar 2006 17:00:11 +0000 (17:00 -0000)]
Turn #if 0 into a comment.

18 years agoprevent find from ever descending into an xdev'ed directory.
Paul Fox [Mon, 27 Mar 2006 16:42:33 +0000 (16:42 -0000)]
prevent find from ever descending into an xdev'ed directory.

18 years agoMore dead code removal.
Rob Landley [Sun, 26 Mar 2006 21:49:42 +0000 (21:49 -0000)]
More dead code removal.

18 years agoRobert P Day removed some commented out code.
Rob Landley [Sun, 26 Mar 2006 21:42:40 +0000 (21:42 -0000)]
Robert P Day removed some commented out code.

18 years agoDefine both big endian and little endian macros.
Rob Landley [Sat, 25 Mar 2006 03:01:59 +0000 (03:01 -0000)]
Define both big endian and little endian macros.

18 years agoStephane Billiart found an endianness bug in insmod.
Rob Landley [Sat, 25 Mar 2006 02:49:28 +0000 (02:49 -0000)]
Stephane Billiart found an endianness bug in insmod.

18 years ago- commentary typos
Bernhard Reutner-Fischer [Fri, 24 Mar 2006 14:30:05 +0000 (14:30 -0000)]
- commentary typos

18 years ago- make sure that we see freeramdisk only once
Bernhard Reutner-Fischer [Fri, 24 Mar 2006 09:48:18 +0000 (09:48 -0000)]
- make sure that we see freeramdisk only once

18 years agoWhen cross-compiling, the install directory for shared libraries has to come
Rob Landley [Fri, 24 Mar 2006 02:42:58 +0000 (02:42 -0000)]
When cross-compiling, the install directory for shared libraries has to come
from gcc (target machine), not uname (host machine).

18 years agoremove in place of external link
Mike Frysinger [Thu, 23 Mar 2006 23:44:29 +0000 (23:44 -0000)]
remove in place of external link

18 years ago- correct typo
Bernhard Reutner-Fischer [Thu, 23 Mar 2006 16:52:59 +0000 (16:52 -0000)]
- correct typo

18 years agoBug spotted by Stephane Billiart: losetup depends on loop.c.
Rob Landley [Thu, 23 Mar 2006 16:49:22 +0000 (16:49 -0000)]
Bug spotted by Stephane Billiart: losetup depends on loop.c.

18 years agoVery nice patch from Rich Felker to portably set the stream error indicator and
Rob Landley [Thu, 23 Mar 2006 15:30:26 +0000 (15:30 -0000)]
Very nice patch from Rich Felker to portably set the stream error indicator and
thus remove a lot of nasty old code that didn't.

18 years agomake the makefile a little more flexible so we can store in either location
Mike Frysinger [Thu, 23 Mar 2006 03:47:19 +0000 (03:47 -0000)]
make the makefile a little more flexible so we can store in either location

18 years agoNews entry announcing 1.1.1.
Rob Landley [Thu, 23 Mar 2006 03:08:09 +0000 (03:08 -0000)]
News entry announcing 1.1.1.

18 years agosync busybox and udhcp trees
Mike Frysinger [Thu, 23 Mar 2006 03:05:05 +0000 (03:05 -0000)]
sync busybox and udhcp trees

18 years agofixup style
Mike Frysinger [Thu, 23 Mar 2006 02:07:41 +0000 (02:07 -0000)]
fixup style

18 years agodont printf arguments given by user for security sanity
Mike Frysinger [Thu, 23 Mar 2006 02:07:20 +0000 (02:07 -0000)]
dont printf arguments given by user for security sanity

18 years agofix typo
Mike Frysinger [Thu, 23 Mar 2006 02:06:29 +0000 (02:06 -0000)]
fix typo

18 years agoWe make both busybox and busybox_unstripped all the time now, no need to
Rob Landley [Wed, 22 Mar 2006 21:03:21 +0000 (21:03 -0000)]
We make both busybox and busybox_unstripped all the time now, no need to
specify whether or not to strip the binary.

18 years agoPatch from Rogelio Serrano to defer checking whether the tty exists until
Rob Landley [Wed, 22 Mar 2006 17:39:13 +0000 (17:39 -0000)]
Patch from Rogelio Serrano to defer checking whether the tty exists until
we actually need to spawn something on it.

18 years agoFix "seq 1 1".
Rob Landley [Wed, 22 Mar 2006 17:11:44 +0000 (17:11 -0000)]
Fix "seq 1 1".

18 years agoFix from Glenn McGrath.
Rob Landley [Wed, 22 Mar 2006 16:59:12 +0000 (16:59 -0000)]
Fix from Glenn McGrath.

18 years agoTweak allbareconfig not to pause.
Rob Landley [Wed, 22 Mar 2006 15:24:24 +0000 (15:24 -0000)]
Tweak allbareconfig not to pause.

18 years agoAnnoint 1.1.1.
Rob Landley [Wed, 22 Mar 2006 14:07:23 +0000 (14:07 -0000)]
Annoint 1.1.1.

18 years agoAnother header suggestion from Shaun Jackman.
Rob Landley [Wed, 22 Mar 2006 00:46:36 +0000 (00:46 -0000)]
Another header suggestion from Shaun Jackman.

18 years ago2006-03-21 Shaun Jackman <sjackman@gmail.com>: Include signal.h instead of sys...
Mike Frysinger [Wed, 22 Mar 2006 00:25:07 +0000 (00:25 -0000)]
2006-03-21  Shaun Jackman  <sjackman@gmail.com>: Include signal.h instead of sys/signal.h.

18 years agoFix missing copyright and license notice.
Rob Landley [Tue, 21 Mar 2006 18:20:40 +0000 (18:20 -0000)]
Fix missing copyright and license notice.

18 years agoPatch from Stuart Hughes upgrading depmod.pl
Rob Landley [Tue, 21 Mar 2006 16:35:50 +0000 (16:35 -0000)]
Patch from Stuart Hughes upgrading depmod.pl

18 years agoPatch from Shaun Jackman to make loop.c build only when needed.
Rob Landley [Tue, 21 Mar 2006 16:22:19 +0000 (16:22 -0000)]
Patch from Shaun Jackman to make loop.c build only when needed.

18 years agoTemporarily disable shared library for the 1.1.1 release.
Rob Landley [Tue, 21 Mar 2006 16:07:39 +0000 (16:07 -0000)]
Temporarily disable shared library for the 1.1.1 release.

18 years ago- workaroung pr25795 in gcc-4.1
Bernhard Reutner-Fischer [Tue, 21 Mar 2006 11:06:43 +0000 (11:06 -0000)]
- workaroung pr25795 in gcc-4.1
  http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25795

18 years agoRemove unneeded entries.
Rob Landley [Mon, 20 Mar 2006 18:40:07 +0000 (18:40 -0000)]
Remove unneeded entries.

18 years agoCleanup: remove double quotes that don't seem to be needed.
Rob Landley [Mon, 20 Mar 2006 18:39:02 +0000 (18:39 -0000)]
Cleanup: remove double quotes that don't seem to be needed.

18 years agowhitespace cleanup
Eric Andersen [Mon, 20 Mar 2006 18:07:50 +0000 (18:07 -0000)]
whitespace cleanup

18 years agoFix some obvious compile problems. Make the -f' fakeIt option actually work.
Eric Andersen [Mon, 20 Mar 2006 18:07:13 +0000 (18:07 -0000)]
Fix some obvious compile problems.  Make the -f' fakeIt option actually work.

18 years agoWilly Tarreau writes:
Eric Andersen [Mon, 20 Mar 2006 17:50:08 +0000 (17:50 -0000)]
Willy Tarreau writes:

I encountered a little typo in 'make help' : the prefix was
noted "$prefix" instead of "$(PREFIX)".

18 years agoRoy Walker writes:
Eric Andersen [Mon, 20 Mar 2006 17:37:00 +0000 (17:37 -0000)]
Roy Walker writes:

Here is a patch against the current subversion repository, that makes
udhcpc have an adjustable timeout.  Works for both foreground and before
it drops to the background.  This brings it more in-line with ISC dhcpc.

Use like so:
udhcpc --timeout=10 ...
or
udhcpc -T 10 ...

Still shooting for 1.1.1 this month?  Would really be great if you could
get this in that release.

Please give credit to Paul Pacheco - ppacheco@gmail.com.

18 years agoPatch from tito, acked by Bernhard Fischer.
Rob Landley [Mon, 20 Mar 2006 02:20:18 +0000 (02:20 -0000)]
Patch from tito, acked by Bernhard Fischer.

18 years agoUse lstat() instead of stat so /init being a symlink doesn't screw people up.
Rob Landley [Mon, 20 Mar 2006 01:43:29 +0000 (01:43 -0000)]
Use lstat() instead of stat so /init being a symlink doesn't screw people up.
(And use it consistently, for size reasons.)

18 years ago- tito writes: this patch fixes some comments in dos2unix that are wrong
Bernhard Reutner-Fischer [Sat, 18 Mar 2006 23:05:37 +0000 (23:05 -0000)]
- tito writes: this patch fixes some comments in dos2unix that are wrong
  or that reports non existent features (that i've ripped out...)

18 years ago- explain what magic numbers we're using here.
Bernhard Reutner-Fischer [Sat, 18 Mar 2006 23:02:45 +0000 (23:02 -0000)]
- explain what magic numbers we're using here.

18 years ago- whitespace cleanup (and also check against the const first and only then look
Bernhard Reutner-Fischer [Sat, 18 Mar 2006 15:59:29 +0000 (15:59 -0000)]
- whitespace cleanup (and also check against the const first and only then look
  at bb_applet_name[1])

18 years ago- fix order of includes.
Bernhard Reutner-Fischer [Sat, 18 Mar 2006 11:59:55 +0000 (11:59 -0000)]
- fix order of includes.

18 years agodeclare const id argument const for probe_{ext2,ext3,cramfs}
Mike Frysinger [Sat, 18 Mar 2006 04:17:59 +0000 (04:17 -0000)]
declare const id argument const for probe_{ext2,ext3,cramfs}

18 years agoneed string.h as well as strings.h
Mike Frysinger [Sat, 18 Mar 2006 04:13:32 +0000 (04:13 -0000)]
need string.h as well as strings.h

18 years agoneed EXT2FS_OBJS for fsck
Mike Frysinger [Sat, 18 Mar 2006 04:11:51 +0000 (04:11 -0000)]
need EXT2FS_OBJS for fsck

18 years agoMake the new chroot environment creation infrastructure more flexible about
Rob Landley [Sat, 18 Mar 2006 03:01:57 +0000 (03:01 -0000)]
Make the new chroot environment creation infrastructure more flexible about
non-absolute paths.

18 years agoMy mount testsuite. Not automatically run at the moment, need to figure out
Rob Landley [Sat, 18 Mar 2006 03:00:22 +0000 (03:00 -0000)]
My mount testsuite.  Not automatically run at the moment, need to figure out
how to (optionally) supply User Mode Linux to runtests.

18 years agoMore fixes. Type "auto" should mean unspecified from fstab as well as the
Rob Landley [Sat, 18 Mar 2006 02:58:11 +0000 (02:58 -0000)]
More fixes.  Type "auto" should mean unspecified from fstab as well as the
command line, initialize singlemount's rc to an error value so it doesn't
think it succeeded when it didn't, use absolute path when associating a
loop device (and the previous FEATURE_CLEAN_UP logic related to that was
freeing the wrong thing), move reading of /proc/filesystems to where we can
re-read it (when it's empty) for every entry on a "mount -a" so that when
/proc is mounted as the first entry, the later filesystems can autodetect
filesystem type.

18 years agoWhitespace cleanup and minor tweak (return -ERRNO instead of ERRNO so
Rob Landley [Sat, 18 Mar 2006 02:38:10 +0000 (02:38 -0000)]
Whitespace cleanup and minor tweak (return -ERRNO instead of ERRNO so
EPERM doesn't register as a successful read-only mount.

18 years agoBug fix: umount wasn't detaching loop devices unless mtab support was enabled.
Rob Landley [Fri, 17 Mar 2006 03:30:05 +0000 (03:30 -0000)]
Bug fix: umount wasn't detaching loop devices unless mtab support was enabled.
Made some whitespace cleanups while I was there.

18 years agoMore test updates.
Rob Landley [Thu, 16 Mar 2006 16:02:06 +0000 (16:02 -0000)]
More test updates.

18 years agoRedo test suite to be able to test more than one command at a time. Eliminate
Rob Landley [Thu, 16 Mar 2006 15:20:45 +0000 (15:20 -0000)]
Redo test suite to be able to test more than one command at a time.  Eliminate
$COMMAND environment variable, instead put full command line (including
command to run) in second argument.  Modify $PATH to have test versions of
commands at start of path.  (Also more infrastructure for testing as root,
work in progress...)

18 years agoRandom in-passing tweak.
Rob Landley [Thu, 16 Mar 2006 14:40:27 +0000 (14:40 -0000)]
Random in-passing tweak.

18 years agoUpdate for bug 14.
Rob Landley [Wed, 15 Mar 2006 17:09:56 +0000 (17:09 -0000)]
Update for bug 14.

18 years agoTito shrank dos2unix.
Rob Landley [Tue, 14 Mar 2006 21:49:18 +0000 (21:49 -0000)]
Tito shrank dos2unix.

18 years agoMore "extern" removals from Robert P. Day
Rob Landley [Tue, 14 Mar 2006 21:45:38 +0000 (21:45 -0000)]
More "extern" removals from Robert P. Day

18 years agoAttempt to make a warning go away without increasing size.
Rob Landley [Tue, 14 Mar 2006 21:13:48 +0000 (21:13 -0000)]
Attempt to make a warning go away without increasing size.

18 years agoMissed one.
Rob Landley [Tue, 14 Mar 2006 20:06:44 +0000 (20:06 -0000)]
Missed one.

18 years agoThe new, new mount rewrite. (Mount double prime?) Still being debugged, but
Rob Landley [Tue, 14 Mar 2006 18:16:25 +0000 (18:16 -0000)]
The new, new mount rewrite.  (Mount double prime?)  Still being debugged, but
the new infrastructure is reentrant so in theory it's capable of handling
mount -a sanely.  It can also re-use existing flags with remount, handle
-t auto, mount -a -t, and several smaller bugfixes.

18 years agoTito unified fdflush and freeramdisk. I tweaked the result a bit.
Rob Landley [Tue, 14 Mar 2006 02:40:51 +0000 (02:40 -0000)]
Tito unified fdflush and freeramdisk.  I tweaked the result a bit.

18 years agoupdate comments as to what caused the defines to change
Mike Frysinger [Mon, 13 Mar 2006 23:48:18 +0000 (23:48 -0000)]
update comments as to what caused the defines to change

18 years ago- add two comments
Bernhard Reutner-Fischer [Mon, 13 Mar 2006 20:32:48 +0000 (20:32 -0000)]
- add two comments

18 years ago- remove superfluous dependency which was fixed in r14527
Bernhard Reutner-Fischer [Mon, 13 Mar 2006 19:30:06 +0000 (19:30 -0000)]
- remove superfluous dependency which was fixed in r14527

18 years ago- revert back to r14406
Bernhard Reutner-Fischer [Mon, 13 Mar 2006 19:04:00 +0000 (19:04 -0000)]
- revert back to r14406

18 years agoPatch from Denis Vlasenko to add xstat() and use it.
Rob Landley [Mon, 13 Mar 2006 15:45:16 +0000 (15:45 -0000)]
Patch from Denis Vlasenko to add xstat() and use it.

18 years agoUpdate documentation.
Rob Landley [Mon, 13 Mar 2006 04:38:40 +0000 (04:38 -0000)]
Update documentation.

18 years ago"make help" should not build the configurator first.
Rob Landley [Mon, 13 Mar 2006 03:19:46 +0000 (03:19 -0000)]
"make help" should not build the configurator first.

18 years agoFix "rm .config;make menuconfig" to work like "rm .config; make" (I.E. do
Rob Landley [Mon, 13 Mar 2006 02:52:23 +0000 (02:52 -0000)]
Fix "rm .config;make menuconfig" to work like "rm .config; make" (I.E. do
defconfig first), and group busybox administrative settings into a sub-menu.

18 years agoCleanup patch from tito.
Rob Landley [Sun, 12 Mar 2006 19:26:01 +0000 (19:26 -0000)]
Cleanup patch from tito.

18 years agoSize reduction by Tito.
Rob Landley [Sat, 11 Mar 2006 18:22:35 +0000 (18:22 -0000)]
Size reduction by Tito.

18 years agofix building with glibc-2.4
Mike Frysinger [Fri, 10 Mar 2006 23:41:29 +0000 (23:41 -0000)]
fix building with glibc-2.4