oweals/u-boot.git
9 years agopowerpc/mpc85xx: Remove some dead code
Scott Wood [Wed, 8 Apr 2015 01:20:01 +0000 (20:20 -0500)]
powerpc/mpc85xx: Remove some dead code

U-Boot does not have system calls (the services it exposes to
standalone commands use a different mechanism), so the syscall handler
is dead code.  It's also broken code, as it assumes it is located at
0xc00 -- while even before the patch to stop relocating exception
vectors to 0, U-Boot had the syscall at 0x900.

The critical and machine check return paths are never called -- the
regular exception return path is used instead, which works because
xSRR0/1 have already been saved and can be restored via the regular
SRR0/1 (we don't care too much in U-Boot about taking a critical/mcheck
inside another exception prolog/epilog).

Also remove a few other small unused functions.

Signed-off-by: Scott Wood <scottwood@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
9 years agopowerpc/mpc85xx: Don't relocate exception vectors
Scott Wood [Wed, 8 Apr 2015 01:20:00 +0000 (20:20 -0500)]
powerpc/mpc85xx: Don't relocate exception vectors

Booke does not require exception vectors to be located at address zero.
U-Boot was doing so anyway, simply because that's how it had been done
on other PPC.  The downside of this is that once the OS is loaded to
address zero, the exception vectors have been overwritten -- which
makes it difficult to diagnose a crash that happens after that point.

The IVOR setup and trap entry code is simplified somewhat as a result.

Also, there is no longer a need to align individual exceptions on 0x100
byte boundaries.

Signed-off-by: Scott Wood <scottwood@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
9 years agopowerpc/t2080rdb: update ddr to support 1866MT/s
Shengzhou Liu [Fri, 27 Mar 2015 07:53:14 +0000 (15:53 +0800)]
powerpc/t2080rdb: update ddr to support 1866MT/s

Support SODIMM D3XP12081XL10AA 1866MT/s on T2080RDB.
Enable CONFIG_CMD_MEMTEST as well.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
9 years agoT4240RDB: Enable CONFIG_SYS_CORTINA_FW_IN_NOR config
Chunhe Lan [Tue, 24 Mar 2015 07:10:41 +0000 (15:10 +0800)]
T4240RDB: Enable CONFIG_SYS_CORTINA_FW_IN_NOR config

Now cortina driver uses macro CONFIG_SYS_CORTINA_FW_IN_NOR
to define that firmware of cortina driver is stored in the
nor flash.

Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
9 years agoboard/t208xrdb: VID support
Ying Zhang [Tue, 10 Mar 2015 06:21:36 +0000 (14:21 +0800)]
board/t208xrdb: VID support

The fuse status register provides the values from on-chip
voltage ID efuses programmed at the factory.
These values define the voltage requirements for
the chip. u-boot reads FUSESR and translates the values
into the appropriate commands to set the voltage output
value of an external voltage regulator.

Signed-off-by: Ying Zhang <b40530@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
9 years agopowerpc/t2080: enable erratum_a007186 for t2080 rev1.1
Shengzhou Liu [Mon, 9 Mar 2015 09:12:22 +0000 (17:12 +0800)]
powerpc/t2080: enable erratum_a007186 for t2080 rev1.1

T2080 rev1.1 also needs erratum a007186.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
9 years agoqemu-ppce500: Add support for 64bit CCSR map
Alexander Graf [Sat, 7 Mar 2015 01:10:09 +0000 (02:10 +0100)]
qemu-ppce500: Add support for 64bit CCSR map

QEMU 2.3 changes the address layout of the CCSR map in the PV ppce500 machine
to reside in higher address space.

Unfortunately, this exposed a glitch in u-boot for ppce500: While providing
a function to dynamically evaluate the CCSR region's position in physical
address space, we never used it. Plus we forgot to support 64bit physical
addresses.

This patch fixes that mishap, making u-boot work fine with latest QEMU again.

Signed-off-by: Alexander Graf <agraf@suse.de>
Reviewed-by: Scott Wood <scottwood@freescale.com>
Reviewed-by: York Sun <yorksun@freescale.com>
9 years agoMPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
Curt Brune [Fri, 13 Feb 2015 18:57:11 +0000 (10:57 -0800)]
MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register

According to the MPC8555/MPC8541 reference manual the SS_EN (source
synchronous enable) bit in the DDR_SDRAM_CLK_CNLT register must be set
during initialization.

>From section 9.4.1.8 of that manual:

   Source synchronous enable. This bit field must be set during
   initialization. See Section 9.6.1, "DDR SDRAM Initialization
   Sequence," details.

   0 - Reserved
   1 - The address and command are sent to the DDR SDRAMs source
       synchronously.

In addition, Freescale application note AN2805 is also very clear that
this bit must be set.

This patch reverts a change introduced by commit
457caecdbca3df21a93abff19eab12dbc61b7897.

Testing Done:

Compiled targets CONFIG_TARGET_MPC8555CDS and CONFIG_TARGET_MPC8541CDS
and inspected the generated assembly code to verify the SS_EN bit was being
set.  There is one extra instruction emitted:

  fff9b774: 65 29 80 00  oris    r9,r9,32768

Compiled the CONFIG_TARGET_MPC8548CDS target and verified that no
additional instructions were emitted related to this patch.

Booted an image on a MPC8541 based board successfully.

Signed-off-by: Curt Brune <curt@cumulusnetworks.com>
Reviewed-by: York Sun <yorksun@freescale.com>
9 years agoMerge branch 'buildman' of git://git.denx.de/u-boot-x86
Tom Rini [Sat, 18 Apr 2015 23:24:13 +0000 (19:24 -0400)]
Merge branch 'buildman' of git://git.denx.de/u-boot-x86

9 years agopatman: cover letter shows like 00/xx if more than 10 patches
Wu, Josh [Fri, 3 Apr 2015 02:51:17 +0000 (10:51 +0800)]
patman: cover letter shows like 00/xx if more than 10 patches

Make cover letter shows like 0/x, 00/xx and 000/xxx etc.

Signed-off-by: Josh Wu <josh.wu@atmel.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agobuildman: Make -V (verbose_build) really be verbose
Tom Rini [Wed, 1 Apr 2015 11:47:41 +0000 (07:47 -0400)]
buildman: Make -V (verbose_build) really be verbose

The help text for -V says we will pass V=1 but all it really did was not
pass in -s.  Change the logic to pass make V=1 with given to buildman -V or
-s to make otherwise.

Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agobuildman: Keep more outputs with the --keep-outputs flag
Tom Rini [Fri, 20 Mar 2015 14:50:38 +0000 (10:50 -0400)]
buildman: Keep more outputs with the --keep-outputs flag

When told to keep outputs, be much more liberal in what files we keep.
In addition to adding 'MLO', keep anything that matches u-boot-spl.* (so
that we keep the map file as well) and anything we generate about
'u-boot itself.  A large number of bootable formats now match this and
thus it's easier to build many targets and then boot them afterwards
using buildman.

Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agobuildman: Allow comparison of build configuration
Simon Glass [Fri, 6 Feb 2015 05:06:15 +0000 (22:06 -0700)]
buildman: Allow comparison of build configuration

It is useful to be able to see CONFIG changes made by commits. Add this
feature to buildman using the -K flag so that all CONFIG changes are
reported.

The CONFIG options exist in a number of files. Each is reported
individually as well as a summary that covers all files. The output
shows three parts: green for additions, red for removals and yellow for
changes.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agobuildman: Store build config files
Simon Glass [Fri, 6 Feb 2015 05:06:14 +0000 (22:06 -0700)]
buildman: Store build config files

Store all config file output so that we can compare changes if requested.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agobuildman: Adjust the 'aborted' heuristic for writing output
Simon Glass [Fri, 6 Feb 2015 05:06:13 +0000 (22:06 -0700)]
buildman: Adjust the 'aborted' heuristic for writing output

At present buildman tries to detect an aborted build and doesn't record a
result in that case. This is to make sure that an abort (e.g. with Ctrl-C)
does not mark the build as done. Without this option, buildman would never
retry the build unless -f/-F are provided. The effect is that aborting the
build creates 'fake errors' on whatever builds buildman happens to be
working on at the time.

Unfortunately the current test is not reliable and this detection can
trigger if a required toolchain tool is missing. In this case the toolchain
problem is never reported.

Adjust the logic to continue processing the build result, mark the build as
done (and failed), but with a return code which indicates that it should be
retried.

The correct fix is to fully and correctly detect an aborted build, quit
buildman immediately and not write any partial build results in this case.
Unfortunately this is currently beyond my powers and is left as an exercise
for the reader (and patches are welcome).

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agobuildman: Show 'make' command line when -V is used
Simon Glass [Fri, 6 Feb 2015 05:06:12 +0000 (22:06 -0700)]
buildman: Show 'make' command line when -V is used

When a verbose build it selected, show the make command before the output of
that command.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agoCreate a .cfg file containing the CONFIG options used to build
Simon Glass [Fri, 6 Feb 2015 05:06:10 +0000 (22:06 -0700)]
Create a .cfg file containing the CONFIG options used to build

At present CONFIG options are split across Kconfig and board config headers
files. Also we have multiple files containing these CONFIG options.

In order to see exactly what is being used for building, create a .cfg
file which holds these options as reported by the C preprocessor.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agoahci: mmio_base is a virtual address
Scott Wood [Fri, 17 Apr 2015 14:19:01 +0000 (09:19 -0500)]
ahci: mmio_base is a virtual address

Don't store it in a u32.

Don't dereference the bus address as if it were a virtual address
(fixes 284231e49a2b4 ("ahci: Support splitting of read transactions
into multiple chunks")).

Fixes crash on boot in MPC8641HPCN_36BIT target.

Signed-off-by: Scott Wood <scottwood@freescale.com>
Cc: Vadim Bendebury <vbendeb@chromium.org>
Acked-by: York Sun <yorksun@freescale.com>
9 years agosandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:14 +0000 (13:19 -0700)]
sandbox: exynos: Move CONFIG_SOUND_SANDBOX to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: exynos: Move CONFIG_SOUND_WM8994 to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:13 +0000 (13:19 -0700)]
sandbox: exynos: Move CONFIG_SOUND_WM8994 to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: exynos: Move CONFIG_SOUND_MAX98095 to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:12 +0000 (13:19 -0700)]
sandbox: exynos: Move CONFIG_SOUND_MAX98095 to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: exynos: Move CONFIG_I2S_SAMSUNG to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:11 +0000 (13:19 -0700)]
sandbox: exynos: Move CONFIG_I2S_SAMSUNG to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: exynos: Move CONFIG_I2S to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:10 +0000 (13:19 -0700)]
sandbox: exynos: Move CONFIG_I2S to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: exynos: Move CONFIG_CMD_SOUND to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:09 +0000 (13:19 -0700)]
sandbox: exynos: Move CONFIG_CMD_SOUND to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: exynos: Move CONFIG_SOUND to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:08 +0000 (13:19 -0700)]
sandbox: exynos: Move CONFIG_SOUND to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: Move CONFIG_TPM_TIS_SANDBOX to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:07 +0000 (13:19 -0700)]
sandbox: Move CONFIG_TPM_TIS_SANDBOX to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: Move CONFIG_SPI_FLASH_SANDBOX to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:06 +0000 (13:19 -0700)]
sandbox: Move CONFIG_SPI_FLASH_SANDBOX to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: Move CONFIG_SANDBOX_SPI to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:05 +0000 (13:19 -0700)]
sandbox: Move CONFIG_SANDBOX_SPI to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: Move CONFIG_SYS_I2C_SANDBOX to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:04 +0000 (13:19 -0700)]
sandbox: Move CONFIG_SYS_I2C_SANDBOX to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Heiko Schocher<hs@denx.de>
9 years agosandbox: Move CONFIG_SYS_VSNPRINTF to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:02 +0000 (13:19 -0700)]
sandbox: Move CONFIG_SYS_VSNPRINTF to Kconfig

Move this over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agosandbox: Move GPIO CONFIGs to Kconfig
Simon Glass [Fri, 6 Mar 2015 20:19:01 +0000 (13:19 -0700)]
sandbox: Move GPIO CONFIGs to Kconfig

Move these over to Kconfig and tidy up.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agoKconfig: Move CONFIG_BOOTSTAGE to Kconfig
Simon Glass [Tue, 3 Mar 2015 00:04:37 +0000 (17:04 -0700)]
Kconfig: Move CONFIG_BOOTSTAGE to Kconfig

Move CONFIG_BOOT_STAGE and its associated options to Kconfig. Adjust
existing users and code.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agodm: sunxi: Use driver model for Ethernet on Linksprite pcDuino3
Simon Glass [Sun, 5 Apr 2015 22:07:43 +0000 (16:07 -0600)]
dm: sunxi: Use driver model for Ethernet on Linksprite pcDuino3

Switch this board over to use driver model for Ethernet.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agodm: sunxi: Support driver model for Ethernet
Simon Glass [Sun, 5 Apr 2015 22:07:42 +0000 (16:07 -0600)]
dm: sunxi: Support driver model for Ethernet

Adjust the Ethernet initialisation code to support driver model.
It is no-longer necessary to call designware_initialize(). The device will
be probed when it is used. The PHY type and GMAC base will come from the
device tree.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agodm: net: Adjust designware driver to support driver model
Simon Glass [Sun, 5 Apr 2015 22:07:41 +0000 (16:07 -0600)]
dm: net: Adjust designware driver to support driver model

Add driver model support to the designware driver. This reuses most of the
existing code except for some duplication in the probe() method.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
9 years agodm: net: Tidy up designware driver ready for driver model
Simon Glass [Sun, 5 Apr 2015 22:07:40 +0000 (16:07 -0600)]
dm: net: Tidy up designware driver ready for driver model

Adjust the error handling to use errno.h instead of returning -1. Change
leaf functions to pass in the arguments they require rather than struct
eth_device. Apart from simplifying the code it makes is easier to reuse
these functions for driver model, since mostly they actually only use
struct dw_eth_priv (which we can keep).

Create a stub for each Ethernet operation function. This will allow use to
share code with the driver model versions.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
9 years agodm: net: Adjust PHY interface to work with CONFIG_DM_ETH
Simon Glass [Sun, 5 Apr 2015 22:07:39 +0000 (16:07 -0600)]
dm: net: Adjust PHY interface to work with CONFIG_DM_ETH

When driver model is used for Ethernet a few functions are passed a udevice
instead of an eth_device. Also add a function to find a PHY type given its
name. This will be used to decode the device tree node.

Finally, put a phy_interface field in struct eth_pdata since this is an
important part of the platform data for Ethernet.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
9 years agoAvoid calling print_eths() with driver model
Simon Glass [Sun, 5 Apr 2015 22:07:38 +0000 (16:07 -0600)]
Avoid calling print_eths() with driver model

This function is not supported with driver model.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
9 years agodm: net: Use existing Ethernet init for driver model
Simon Glass [Sun, 5 Apr 2015 22:07:37 +0000 (16:07 -0600)]
dm: net: Use existing Ethernet init for driver model

At present even with driver model is used there is still much manual init
of related devices: PHY, environment and board init. Until these requirements
are dealt with in another way we need to keep them around.

Break out the init portion of the legacy eth_initialize() into a separate
function and call it from both the legacy and driver model eth_initialize()
functions.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
9 years agodts: sunxi: Bring in Ethernet device tree bindings
Simon Glass [Sun, 5 Apr 2015 22:07:35 +0000 (16:07 -0600)]
dts: sunxi: Bring in Ethernet device tree bindings

Since we will use these bindings on sunxi, bring them in from Linux
4.0-rc1.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
9 years agoKconfig: Move CONFIG_DESIGNWARE_ETH to Kconfig
Simon Glass [Sun, 5 Apr 2015 22:07:34 +0000 (16:07 -0600)]
Kconfig: Move CONFIG_DESIGNWARE_ETH to Kconfig

Move this to Kconfig and clean up board config files that use it. Also
rename it to CONFIG_ETH_DESIGNWARE to fit with the naming that exists
in drivers/net/Kconfig.

Signed-off-by: Simon Glass <sjg@chromium.org>
Version 1:
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
9 years agosunxi: Replace the pcDuino3 config with FDT version
Simon Glass [Sun, 5 Apr 2015 22:07:33 +0000 (16:07 -0600)]
sunxi: Replace the pcDuino3 config with FDT version

We currently have Linksprite_pcDuino3 and Linksprite_pcDuino3_fdt. Drop the
former in favour of the latter.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
9 years agosandbox: Enable more network features for sandbox
Joe Hershberger [Wed, 8 Apr 2015 06:41:25 +0000 (01:41 -0500)]
sandbox: Enable more network features for sandbox

More net features enabled and supported on sandbox to allow more testing

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: Fix compile errors when SNTP enabled and not DATE
Joe Hershberger [Wed, 8 Apr 2015 06:41:24 +0000 (01:41 -0500)]
net: Fix compile errors when SNTP enabled and not DATE

When SNTP is enabled and DATE is not, to_tm() is not built in. It could
be defined when TIMESTAMP is defined, so check for that.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: Convert protocol structures to use explicit sizes
Sergey Temerkhanov [Wed, 8 Apr 2015 06:41:23 +0000 (01:41 -0500)]
net: Convert protocol structures to use explicit sizes

Convert uchar/ushort to u8/u16 respectively.

Signed-off-by: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
Signed-off-by: Sergey Temerkhanov <s.temerkhanov@gmail.com>
Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: Fix incorrect DHCP/BOOTP packets on 64-bit systems
Sergey Temerkhanov [Wed, 8 Apr 2015 06:41:22 +0000 (01:41 -0500)]
net: Fix incorrect DHCP/BOOTP packets on 64-bit systems

This commit fixes incorrect DHCP/BOOTP packet layout caused by
'ulong' type size difference on 64 and 32-bit architectures.
It also renames NetReadLong()/NetCopyLong() to
net_read_u32/net_copy_u32() accordingly.

Signed-off-by: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
Signed-off-by: Sergey Temerkhanov <s.temerkhanov@gmail.com>
Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Fix checkpatch.pl failures in net.c
Joe Hershberger [Wed, 8 Apr 2015 06:41:21 +0000 (01:41 -0500)]
net: cosmetic: Fix checkpatch.pl failures in net.c

Finish eliminating CamelCase from net.c and other failures

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Fix checkpatch.pl failures in net.h
Joe Hershberger [Wed, 8 Apr 2015 06:41:20 +0000 (01:41 -0500)]
net: cosmetic: Fix checkpatch.pl failures in net.h

There were still a few remaining complains in the legacy eth_device
definition that hadn't been addressed.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Fix checkpatch.pl failures in eth.c
Joe Hershberger [Wed, 8 Apr 2015 06:41:19 +0000 (01:41 -0500)]
net: cosmetic: Fix checkpatch.pl failures in eth.c

There were still a few failures in net/eth.c, especially in the legacy
part of the code.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Fix checkpatch.pl failures in linklocal
Joe Hershberger [Wed, 8 Apr 2015 06:41:18 +0000 (01:41 -0500)]
net: cosmetic: Fix checkpatch.pl failures in linklocal

A few new rules in checkpatch.pl since linklocal.c was added.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up cmd_net variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:17 +0000 (01:41 -0500)]
net: cosmetic: Clean up cmd_net variables and functions

Make a thorough pass through all variables and function names contained
within common/cmd_net.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up netconsole variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:16 +0000 (01:41 -0500)]
net: cosmetic: Clean up netconsole variables and functions

Make a thorough pass through all variables and function names contained
within netconsole.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up DNS variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:15 +0000 (01:41 -0500)]
net: cosmetic: Clean up DNS variables and functions

Make a thorough pass through all variables and function names contained
within dns.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up CDP variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:14 +0000 (01:41 -0500)]
net: cosmetic: Clean up CDP variables and functions

Make a thorough pass through all variables and function names contained
within cdp.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up ping variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:13 +0000 (01:41 -0500)]
net: cosmetic: Clean up ping variables and functions

Make a thorough pass through all variables and function names contained
within ping.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up SNTP variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:12 +0000 (01:41 -0500)]
net: cosmetic: Clean up SNTP variables and functions

Make a thorough pass through all variables and function names contained
within sntp.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up RARP variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:11 +0000 (01:41 -0500)]
net: cosmetic: Clean up RARP variables and functions

Make a thorough pass through all variables and function names contained
within rarp.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up NFS variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:10 +0000 (01:41 -0500)]
net: cosmetic: Clean up NFS variables and functions

Make a thorough pass through all variables and function names contained
within nfs.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up DHCP variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:09 +0000 (01:41 -0500)]
net: cosmetic: Clean up DHCP variables and functions

Make a thorough pass through all variables and function names contained
within bootp.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up ARP variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:08 +0000 (01:41 -0500)]
net: cosmetic: Clean up ARP variables and functions

Make a thorough pass through all variables and function names contained
within arp and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Clean up TFTP variables and functions
Joe Hershberger [Wed, 8 Apr 2015 06:41:07 +0000 (01:41 -0500)]
net: cosmetic: Clean up TFTP variables and functions

Make a thorough pass through all variables and function names contained
within tftp and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Fix var naming net <-> eth drivers
Joe Hershberger [Wed, 8 Apr 2015 06:41:06 +0000 (01:41 -0500)]
net: cosmetic: Fix var naming net <-> eth drivers

Update the naming convention used in the network stack functions and
variables that Ethernet drivers use to interact with it.

This cleans up the temporary hacks that were added to this interface
along with the DM support.

This patch has a few remaining checkpatch.pl failures that would be out
of the scope of this patch to fix (drivers that are in gross violation
of checkpatch.pl).

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Cleanup internal packet buffer names
Joe Hershberger [Wed, 8 Apr 2015 06:41:05 +0000 (01:41 -0500)]
net: cosmetic: Cleanup internal packet buffer names

This patch cleans up the names of internal packet buffer names that are
used within the network stack and the functions that use them.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
9 years agonet: cosmetic: Name ethaddr variables consistently
Joe Hershberger [Wed, 8 Apr 2015 06:41:04 +0000 (01:41 -0500)]
net: cosmetic: Name ethaddr variables consistently

Use "_ethaddr" at the end of variables and drop CamelCase.
Make constant values actually 'const'.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Fixup var names for DHCP strings
Joe Hershberger [Wed, 8 Apr 2015 06:41:03 +0000 (01:41 -0500)]
net: cosmetic: Fixup var names for DHCP strings

Remove CamelCase variable naming.
Move the definition to the same compilation unit as the primary use.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Fixup var names related to boot file
Joe Hershberger [Wed, 8 Apr 2015 06:41:02 +0000 (01:41 -0500)]
net: cosmetic: Fixup var names related to boot file

The variables around the bootfile were inconsistent and used CamelCase.
Update them to make the code more readable.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agonet: cosmetic: Change IPaddr_t to struct in_addr
Joe Hershberger [Wed, 8 Apr 2015 06:41:01 +0000 (01:41 -0500)]
net: cosmetic: Change IPaddr_t to struct in_addr

This patch is simply clean-up to make the IPv4 type that is used match
what Linux uses. It also attempts to move all variables that are IP
addresses use good naming instead of CamelCase. No functional change.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agopowerpc: ids8313: use "select" instead of default value in defconfig
Masahiro Yamada [Tue, 31 Mar 2015 03:48:03 +0000 (12:48 +0900)]
powerpc: ids8313: use "select" instead of default value in defconfig

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agoARM: cm_fx6: use "select" instead of default value in defconfig
Masahiro Yamada [Tue, 31 Mar 2015 03:48:02 +0000 (12:48 +0900)]
ARM: cm_fx6: use "select" instead of default value in defconfig

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agoARM: stv0991: use "select" instead of default value in defconfig
Masahiro Yamada [Tue, 31 Mar 2015 03:48:01 +0000 (12:48 +0900)]
ARM: stv0991: use "select" instead of default value in defconfig

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agoARM: bav335x: use "select" instead of default value in defconfig
Masahiro Yamada [Tue, 31 Mar 2015 03:48:00 +0000 (12:48 +0900)]
ARM: bav335x: use "select" instead of default value in defconfig

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agoARM: socfpga: use "select" instead of default value in defconfig
Masahiro Yamada [Tue, 31 Mar 2015 03:47:59 +0000 (12:47 +0900)]
ARM: socfpga: use "select" instead of default value in defconfig

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agoARM: mx6: use "select" instead of default value in defconfig
Masahiro Yamada [Tue, 31 Mar 2015 03:47:58 +0000 (12:47 +0900)]
ARM: mx6: use "select" instead of default value in defconfig

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agoARM: snapper9260: use "select" instead of default value in defconfig
Masahiro Yamada [Tue, 31 Mar 2015 03:47:57 +0000 (12:47 +0900)]
ARM: snapper9260: use "select" instead of default value in defconfig

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agoARM: rmobile: use "select" instead of default value in defconfig
Masahiro Yamada [Tue, 31 Mar 2015 03:47:56 +0000 (12:47 +0900)]
ARM: rmobile: use "select" instead of default value in defconfig

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agoARM: zynq: use "select" instead of default value in defconfig
Masahiro Yamada [Tue, 31 Mar 2015 03:47:55 +0000 (12:47 +0900)]
ARM: zynq: use "select" instead of default value in defconfig

All the Zynq boards have switch to Driver Model.
"select DM" is better than default value in each defconfig.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agoARM: UniPhier: use "select" instead of default value in defconfig
Masahiro Yamada [Tue, 31 Mar 2015 03:47:54 +0000 (12:47 +0900)]
ARM: UniPhier: use "select" instead of default value in defconfig

All the UniPhier boards have switch to Driver Model.
"select DM" is better than default value in each defconfig.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agodm: select CONFIG_DM* options
Masahiro Yamada [Tue, 31 Mar 2015 03:47:53 +0000 (12:47 +0900)]
dm: select CONFIG_DM* options

As mentioned in the previous commit, adding default values in each
Kconfig causes problems because it does not co-exist with the
"depends on" syntax.  (Please note this is not a bug of Kconfig.)
We should not do so unless we have a special reason.  Actually,
for CONFIG_DM*, we have no good reason to do so.

Generally, CONFIG_DM is not a user-configurable option.  Once we
convert a driver into Driver Model, the board only works with Driver
Model, i.e. CONFIG_DM must be always enabled for that board.
So, using "select DM" is more suitable rather than allowing users to
modify it.  Another good thing is, Kconfig warns unmet dependencies
for "select" syntax, so we easily notice bugs.

Actually, CONFIG_DM and other related options have been added
without consistency: some into arch/*/Kconfig, some into
board/*/Kconfig, and some into configs/*_defconfig.

This commit prefers "select" and cleans up the following issues.

[1] Never use "CONFIG_DM=n" in defconfig files

It is really rare to add "CONFIG_FOO=n" to disable CONFIG options.
It is more common to use "# CONFIG_FOO is not set".  But here, we
do not even have to do it.
Less than half of OMAP3 boards have been converted to Driver Model.
Adding the default values to arch/arm/cpu/armv7/omap3/Kconfig is
weird.  Instead, add "select DM" only to appropriate boards, which
eventually eliminates "CONFIG_DM=n", etc.

[2] Delete redundant CONFIGs

Sandbox sets CONFIG_DM in arch/sandbox/Kconfig and defines it again
in configs/sandbox_defconfig.
Likewise, OMAP3 sets CONFIG_DM arch/arm/cpu/armv7/omap3/Kconfig and
defines it also in omap3_beagle_defconfig and devkit8000_defconfig.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
9 years agodm: spi_flash: fix wrong dependency
Masahiro Yamada [Tue, 31 Mar 2015 03:47:52 +0000 (12:47 +0900)]
dm: spi_flash: fix wrong dependency

CONFIG_SPI does not exist in Kconfig in the first place, so the
dependency "depends on DM && SPI" is never met, i.e., DM_SPI_FLASH
can never be enabled (unless you ignore the dependency in an illegal
way.  See below.)

Actually, some defconfigs such as socfpga_*_defconfig define
CONFIG_DM_SPI_FLASH=y, but it never appears in the .config file
because of this wrong dependency.

On the other hand, all the Tegra boards enable DM_SPI_FLASH because

  config DM_SPI_FLASH
          default y

silently ignores the dependency.
Unfortunately, this style of CONFIG definition is abused everywhere
in U-Boot, so we easily miss such a wrong dependency.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Simon Glass <sjg@chromium.org>
9 years agodm: usb: Add a README for driver model
Simon Glass [Wed, 25 Mar 2015 18:23:08 +0000 (12:23 -0600)]
dm: usb: Add a README for driver model

Add some documentation describing how USB is implemented with USB. This
might make things easier for people to understand.

Signed-off-by: Simon Glass <sjg@chromium.org>
9 years agodm: usb: Add tests for the USB uclass
Simon Glass [Wed, 25 Mar 2015 18:23:05 +0000 (12:23 -0600)]
dm: usb: Add tests for the USB uclass

This adds a simple test for probing and a functional test using the flash
stick emulator, which tests a large chunk of the USB stack.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: test: Allow 'dm test' to select a particular test to run
Simon Glass [Wed, 25 Mar 2015 18:23:04 +0000 (12:23 -0600)]
dm: test: Allow 'dm test' to select a particular test to run

As well as running all tests, it is useful to be able to run a selected test.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: test: Correct printf() output nit in 'dm uclass'
Simon Glass [Wed, 25 Mar 2015 18:23:03 +0000 (12:23 -0600)]
dm: test: Correct printf() output nit in 'dm uclass'

Neither the hyphen nor the equals sign is needed.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: sandbox: Enable USB
Simon Glass [Wed, 25 Mar 2015 18:23:02 +0000 (12:23 -0600)]
dm: usb: sandbox: Enable USB

Enable USB emulation and associated features so that USB can be used in
sandbox.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: Tidy up pipe value decoding
Simon Glass [Wed, 25 Mar 2015 18:23:01 +0000 (12:23 -0600)]
dm: usb: Tidy up pipe value decoding

Add a few more shifts/masks to make it easier to decode a pipe value (rather
than just building it). We need this for USB device emulation.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: Add a generic descriptor struct
Simon Glass [Wed, 25 Mar 2015 18:23:00 +0000 (12:23 -0600)]
dm: usb: Add a generic descriptor struct

This is useful for creating lists of descriptors, and is better than using
void * for this purpose.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: exynos: Enable both EHCI and XHCI on snow
Simon Glass [Wed, 25 Mar 2015 18:22:58 +0000 (12:22 -0600)]
dm: usb: exynos: Enable both EHCI and XHCI on snow

Since we can support both controllers now, enable this in the device tree.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: exynos: Enable both USB ports on snow
Simon Glass [Wed, 25 Mar 2015 18:22:57 +0000 (12:22 -0600)]
dm: usb: exynos: Enable both USB ports on snow

Switch snow over to use both EHCI and XHCI at the same time.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: exynos: Use driver model for USB
Simon Glass [Wed, 25 Mar 2015 18:22:56 +0000 (12:22 -0600)]
dm: usb: exynos: Use driver model for USB

Convert Exynos boards over to use driver model for USB. This does not remove
any unnecessary code so far.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: exynos: Adjust XHCI driver to support driver model
Simon Glass [Wed, 25 Mar 2015 18:22:55 +0000 (12:22 -0600)]
dm: usb: exynos: Adjust XHCI driver to support driver model

Support driver model in the exynos XHCI driver.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: Rename the XHCI HCD to U-Boot
Simon Glass [Wed, 25 Mar 2015 18:22:54 +0000 (12:22 -0600)]
dm: usb: Rename the XHCI HCD to U-Boot

This should be "U-Boot", not "u-boot".

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: Support driver model in XHCI
Simon Glass [Wed, 25 Mar 2015 18:22:53 +0000 (12:22 -0600)]
dm: usb: Support driver model in XHCI

Add driver model support in the XHCI support code so that it can be used by
XHCI USB drivers.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: xhci: Factor out common init/uninit
Simon Glass [Wed, 25 Mar 2015 18:22:52 +0000 (12:22 -0600)]
dm: usb: xhci: Factor out common init/uninit

Since driver model will want to use most of the same code for XHCI init
and uninit, put it in a separate function.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: xhci: Use explicit parameters for xhci_setup_addressable_virt_dev()
Simon Glass [Wed, 25 Mar 2015 18:22:51 +0000 (12:22 -0600)]
dm: usb: xhci: Use explicit parameters for xhci_setup_addressable_virt_dev()

This function should not be delving into struct usb_device. Pass in the
parameters it needs directly.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: xhci: Use explicit parameters for xhci_alloc_virt_device()
Simon Glass [Wed, 25 Mar 2015 18:22:50 +0000 (12:22 -0600)]
dm: usb: xhci: Use explicit parameters for xhci_alloc_virt_device()

This function should not be delving into struct usb_device. Pass in the
parameters it needs directly.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: xhci: Use a function to get xhci_ctrl
Simon Glass [Wed, 25 Mar 2015 18:22:49 +0000 (12:22 -0600)]
dm: usb: xhci: Use a function to get xhci_ctrl

Rather than getting this directly from struct usb_device, call a function
to obtain it. This will make it possible for driver model to provide it
another way.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: tegra: Add driver model support to tegra EHCI
Simon Glass [Wed, 25 Mar 2015 18:22:48 +0000 (12:22 -0600)]
dm: usb: tegra: Add driver model support to tegra EHCI

Update this driver with driver model support for USB.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: tegra: Move most of init/uninit into a function
Simon Glass [Wed, 25 Mar 2015 18:22:47 +0000 (12:22 -0600)]
dm: usb: tegra: Move most of init/uninit into a function

We want to use mostly the same init and uninit code for driver model, so move
the common part into two functions.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: tegra: Tidy up error handling and a static function
Simon Glass [Wed, 25 Mar 2015 18:22:46 +0000 (12:22 -0600)]
dm: usb: tegra: Tidy up error handling and a static function

Try to return useful error numbers where possible. Also avoid swallowing
an error number when it is returned by a called function.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
9 years agodm: usb: tegra: Remove the port_addr_clear_csc variable
Simon Glass [Wed, 25 Mar 2015 18:22:45 +0000 (12:22 -0600)]
dm: usb: tegra: Remove the port_addr_clear_csc variable

This variable is a bit of a hack. We can obtain the same information from
the normal device config. This will fit better with driver model, where
global variables are best avoided.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>