oweals/busybox.git
16 years agomdev: do not follow symlinks in /sys (as was intended prior to rev 18811).
Denis Vlasenko [Sun, 6 Jul 2008 07:00:11 +0000 (07:00 -0000)]
mdev: do not follow symlinks in /sys (as was intended prior to rev 18811).
If this breaks things, please document why!
mdev,init: use shared code for fd sanitization

function                                             old     new   delta
bb_daemonize_or_rexec                                155     172     +17
mdev_main                                            500     505      +5
init_main                                            907     856     -51
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/1 up/down: 22/-51)            Total: -29 bytes

16 years agohush: support "for v; do ... done" syntax (implied 'in "$@"')
Denis Vlasenko [Sat, 5 Jul 2008 20:29:59 +0000 (20:29 -0000)]
hush: support "for v; do ... done" syntax (implied 'in "$@"')

16 years agohush: fix a case where "$@" must expand to no word at all
Denis Vlasenko [Sat, 5 Jul 2008 17:40:04 +0000 (17:40 -0000)]
hush: fix a case where "$@" must expand to no word at all

16 years ago*: rename ATTRIBUTE_XXX to just XXX.
Denis Vlasenko [Sat, 5 Jul 2008 09:18:54 +0000 (09:18 -0000)]
*: rename ATTRIBUTE_XXX to just XXX.

16 years agoman: fix inverted cat/man bool variable
Denis Vlasenko [Sat, 5 Jul 2008 08:50:08 +0000 (08:50 -0000)]
man: fix inverted cat/man bool variable

16 years agoman: code shrink
Denis Vlasenko [Sat, 5 Jul 2008 08:38:41 +0000 (08:38 -0000)]
man: code shrink

function                                             old     new   delta
man_main                                             725     765     +40
show_manpage                                         112       -    -112
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 1/0 up/down: 40/-112)           Total: -72 bytes

16 years agoman: support cat pages too (by Jason Curl <jcurlnews AT arcor.de>)
Denis Vlasenko [Fri, 4 Jul 2008 21:58:00 +0000 (21:58 -0000)]
man: support cat pages too (by Jason Curl <jcurlnews AT arcor.de>)

function                                             old     new   delta
show_manpage                                           -     112    +112
run_pipe                                              89     102     +13
man_main                                             721     725      +4

16 years agoman: fix missed NULL termination of an array
Denis Vlasenko [Fri, 4 Jul 2008 21:57:11 +0000 (21:57 -0000)]
man: fix missed NULL termination of an array

function                                             old     new   delta
man_main                                             741     721     -20

16 years agolibbb/recursive_action.c: fix slight error in prev commit
Denis Vlasenko [Fri, 4 Jul 2008 10:29:30 +0000 (10:29 -0000)]
libbb/recursive_action.c: fix slight error in prev commit

16 years agomodutils: optional modutils-small by Vladimir Dronnikov.
Denis Vlasenko [Fri, 4 Jul 2008 10:25:44 +0000 (10:25 -0000)]
modutils: optional modutils-small by Vladimir Dronnikov.
 15kb smaller than standard one.
libbb/recursive_action.c: commented-out code for aborting the scan.

16 years agoawk: another smallish code shrink
Denis Vlasenko [Wed, 2 Jul 2008 22:47:49 +0000 (22:47 -0000)]
awk: another smallish code shrink

16 years agowebpage: fix typos
Denis Vlasenko [Wed, 2 Jul 2008 11:34:49 +0000 (11:34 -0000)]
webpage: fix typos

16 years agouname,individual: fix improper printf usage
Denis Vlasenko [Wed, 2 Jul 2008 11:14:59 +0000 (11:14 -0000)]
uname,individual: fix improper printf usage
uname,awk: small code shrink

function                                             old     new   delta
uname_main                                           175     166      -9
nvalloc                                              167     157     -10
evaluate                                            6381    6370     -11
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-30)             Total: -30 bytes

16 years ago- fix trivial exploit vector when setXid
Ned Ludd [Wed, 2 Jul 2008 00:12:06 +0000 (00:12 -0000)]
- fix trivial exploit vector when setXid

16 years agosendmail: fix wrong vfork usage here too
Denis Vlasenko [Tue, 1 Jul 2008 16:09:07 +0000 (16:09 -0000)]
sendmail: fix wrong vfork usage here too
*: shorten error texts

function                                             old     new   delta
launch_helper                                          -     151    +151
vfork_or_die                                          20       -     -20
sendgetmail_main                                    1946    1848     -98
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 0/1 up/down: 151/-118)           Total: 33 bytes

16 years agorevert last two commits. vfork cannot be used in subroutine,
Denis Vlasenko [Tue, 1 Jul 2008 15:59:42 +0000 (15:59 -0000)]
revert last two commits. vfork cannot be used in subroutine,
it trashes stack on return

16 years ago- wrap overlong lines
Bernhard Reutner-Fischer [Tue, 1 Jul 2008 12:20:20 +0000 (12:20 -0000)]
- wrap overlong lines

16 years ago*: introduce and use xfork()
Denis Vlasenko [Tue, 1 Jul 2008 11:11:24 +0000 (11:11 -0000)]
*: introduce and use xfork()

function                                             old     new   delta
xfork                                                  -      20     +20
msh_main                                            1377    1380      +3
mod_process                                          455     446      -9
forkexit_or_rexec                                     30      17     -13
expand_variables                                    1434    1421     -13
open_transformer                                      91      76     -15
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 1/4 up/down: 23/-50)            Total: -27 bytes

16 years agoadd missing file
Denis Vlasenko [Tue, 1 Jul 2008 10:55:45 +0000 (10:55 -0000)]
add missing file

16 years ago*: introduce and use xvfork()
Denis Vlasenko [Tue, 1 Jul 2008 10:40:41 +0000 (10:40 -0000)]
*: introduce and use xvfork()

function                                             old     new   delta
time_main                                           1052    1285    +233
crontab_main                                         623     856    +233
ifupdown_main                                       2202    2403    +201
xvfork                                                 -      20     +20
passwd_main                                         1049    1053      +4
grave                                               1068    1066      -2
script_main                                          935     921     -14
vfork_or_die                                          20       -     -20
vfork_compressor                                     206     175     -31
open_as_user                                         109       -    -109
popen2                                               218       -    -218
edit_file                                            910     690    -220
run_command                                          268       -    -268
------------------------------------------------------------------------------
(add/remove: 1/4 grow/shrink: 4/4 up/down: 691/-882)         Total: -191 bytes

16 years agossd: fix missed + in prev commit
Denis Vlasenko [Tue, 1 Jul 2008 10:05:12 +0000 (10:05 -0000)]
ssd: fix missed + in prev commit

16 years agossd: do not stat -x EXECUTABLE, it is not needed anymore
Denis Vlasenko [Tue, 1 Jul 2008 10:00:46 +0000 (10:00 -0000)]
ssd: do not stat -x EXECUTABLE, it is not needed anymore
ssd: use PATH
ssd: fix -a without -x case
ssd: fix help text
ssd: CLOSE_EXTRA_FDS in MMU case too
ssd: add testsuite

16 years agoawk: fix a case with multiple -f options. simplify -f file reading.
Denis Vlasenko [Tue, 1 Jul 2008 01:57:36 +0000 (01:57 -0000)]
awk: fix a case with multiple -f options. simplify -f file reading.

function                                             old     new   delta
parse_expr                                           833     841      +8
qrealloc                                              33      36      +3
next_input_file                                      203     198      -5
afopen                                                22       -     -22
ftello                                                41       -     -41
ftell                                                 41       -     -41
__GI_ftell                                            41       -     -41
awk_main                                            1002     944     -58
------------------------------------------------------------------------------
(add/remove: 0/4 grow/shrink: 2/2 up/down: 11/-208)          Total: -197 bytes
   text    data     bss     dec     hex filename
 804232     610    6804  811646   c627e busybox_old
 804120     610    6804  811534   c620e busybox_unstripped

16 years agocrond: use execlp instead of execl
Denis Vlasenko [Mon, 30 Jun 2008 15:48:34 +0000 (15:48 -0000)]
crond: use execlp instead of execl

16 years agosendmail: from Vladimir:
Denis Vlasenko [Mon, 30 Jun 2008 13:30:21 +0000 (13:30 -0000)]
sendmail: from Vladimir:
Here comes the third part of compatibility patch for sendmail.
* Introduced new safe_getdomainname() -- will it be useful?
* Fixed SEGV if sender address is missed. Should snoop for sender address in mail headers?
* More compat: use HOSTNAME instead of HOST when no server is explicitly specified.
* crond: fixed mail recipient address.

function                                             old     new   delta
safe_getdomainname                                     -      56     +56
sendgetmail_main                                    1937    1946      +9
grep_file                                            846     850      +4
crond_main                                          1423    1425      +2
xstrtoull_range_sfx                                  295     296      +1
utoa_to_buf                                          110     108      -2
passwd_main                                         1053    1049      -4
sv_main                                             1234    1228      -6
parse_expr                                           841     833      -8
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 4/4 up/down: 72/-20)             Total: 52 bytes

16 years agonmeter: tiny shrink
Denis Vlasenko [Mon, 30 Jun 2008 07:33:52 +0000 (07:33 -0000)]
nmeter: tiny shrink

16 years agolibiproute: print_route() always uses stdout, do not pass FILE pointer to it.
Denis Vlasenko [Sun, 29 Jun 2008 06:22:40 +0000 (06:22 -0000)]
libiproute: print_route() always uses stdout, do not pass FILE pointer to it.
libiproute: Use FAST_FUNC

function                                             old     new   delta
iprule_modify                                        884     905     +21
ipaddr_modify                                       1289    1310     +21
rtnl_send                                             53      69     +16
xrtnl_wilddump_request                               109     124     +15
xrtnl_dump_filter                                    394     403      +9
rtnl_talk                                            534     539      +5
print_addrinfo                                      1369    1374      +5
iproute_modify                                      1017    1020      +3
iprule_list                                           81      83      +2
xrtnl_open                                           163     161      -2
parse_rtattr                                          89      87      -2
ipaddr_list_or_flush                                2176    2174      -2
addattr_l                                             91      88      -3
flush_update                                         116     108      -8
iproute_list_or_flush                               1285    1263     -22
iproute_get                                          878     852     -26
print_route                                         1913    1752    -161
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 9/8 up/down: 97/-226)          Total: -129 bytes

16 years agofdisk: cosmetics, and removal of dead data
Denis Vlasenko [Sun, 29 Jun 2008 05:16:45 +0000 (05:16 -0000)]
fdisk: cosmetics, and removal of dead data

16 years agofdisk: move more data to struct globals; shrink code
Denis Vlasenko [Sun, 29 Jun 2008 05:10:47 +0000 (05:10 -0000)]
fdisk: move more data to struct globals; shrink code

function                                             old     new   delta
nowarn                                                 1       -      -1
listing                                                1       -      -1
dos_compatible_flag                                    1       -      -1
warn_cylinders                                        44      42      -2
open_list_and_close                                  364     362      -2
fdisk_fatal                                           41      38      -3
verify                                              1053    1049      -4
user_sectors                                           4       -      -4
user_heads                                             4       -      -4
user_cylinders                                         4       -      -4
pt_sectors                                             4       -      -4
pt_heads                                               4       -      -4
kern_sectors                                           4       -      -4
kern_heads                                             4       -      -4
ext_index                                              4       -      -4
total_number_of_sectors                                8       -      -8
extended_offset                                        8       -      -8
create_doslabel                                      129     120      -9
write_table                                          225     211     -14
delete_partition                                     445     431     -14
set_partition                                        476     459     -17
list_disk_geometry                                   247     229     -18
unable_to_write                                       19       -     -19
add_partition                                       2515    2486     -29
get_boot                                            1709    1636     -73
fdisk_main                                          2812    2679    -133
------------------------------------------------------------------------------
(add/remove: 0/14 grow/shrink: 0/12 up/down: 0/-388)         Total: -388 bytes
   text    data     bss     dec     hex filename
 804634     611    6852  812097   c6441 busybox_old
 804298     610    6804  811712   c62c0 busybox_unstripped

16 years agolibbb: shrink monotonic_XXX functions, introduce monotonic_ns
Denis Vlasenko [Sun, 29 Jun 2008 02:25:53 +0000 (02:25 -0000)]
libbb: shrink monotonic_XXX functions, introduce monotonic_ns
(unused for now)

function                                             old     new   delta
get_mono                                               -      31     +31
sv_main                                             1228    1234      +6
expand                                              1693    1697      +4
get_address                                          178     181      +3
utoa_to_buf                                          108     110      +2
builtin_exit                                          46      48      +2
qrealloc                                              36      33      -3
qgravechar                                           109     106      -3
ash_main                                            1383    1380      -3
grep_file                                            850     846      -4
popstring                                            140     134      -6
monotonic_us                                          85      60     -25
monotonic_sec                                         41      16     -25
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 5/7 up/down: 48/-69)            Total: -21 bytes

16 years agowget: "support" -t and -T by ignoring them
Denis Vlasenko [Sun, 29 Jun 2008 00:32:35 +0000 (00:32 -0000)]
wget: "support" -t and -T by ignoring them

16 years agonmeter: tiny shrink
Denis Vlasenko [Sat, 28 Jun 2008 23:42:03 +0000 (23:42 -0000)]
nmeter: tiny shrink

16 years agonmeter: cosmetics
Denis Vlasenko [Sat, 28 Jun 2008 23:33:02 +0000 (23:33 -0000)]
nmeter: cosmetics

16 years agonmeter: code shrink
Denis Vlasenko [Sat, 28 Jun 2008 23:30:37 +0000 (23:30 -0000)]
nmeter: code shrink

function                                             old     new   delta
init_delay                                            61      64      +3
init_cpu                                              86      82      -4
init_int                                              63      57      -6
nmeter_main                                          679     667     -12
init_if                                               88      63     -25
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/4 up/down: 3/-47)             Total: -44 bytes

16 years agosendmail: another update from the maintainer
Denis Vlasenko [Sat, 28 Jun 2008 21:46:41 +0000 (21:46 -0000)]
sendmail: another update from the maintainer

function                                             old     new   delta
sendgetmail_main                                    1894    1937     +43
crond_main                                          1416    1423      +7
packed_usage                                       24540   24470     -70
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/1 up/down: 50/-70)            Total: -20 bytes

16 years agolineedit: document prompt handling
Denis Vlasenko [Sat, 28 Jun 2008 21:03:43 +0000 (21:03 -0000)]
lineedit: document prompt handling

16 years agobunzip2: make proper fix for the problem "fixed" in rev. 22521
Denis Vlasenko [Sat, 28 Jun 2008 18:10:09 +0000 (18:10 -0000)]
bunzip2: make proper fix for the problem "fixed" in rev. 22521
 Thanks for Rob Landley <rob@landley.net>

16 years agolibunarchive: stop using static data in archivers - archive_handle_t
Denis Vlasenko [Sat, 28 Jun 2008 05:04:09 +0000 (05:04 -0000)]
libunarchive: stop using static data in archivers - archive_handle_t
 can trivially provide space for that.
rpm: code shrink
tar: simplify autodetection of bz2/.gz

function                                             old     new   delta
static.not_first                                       1       -      -1
static.end                                             1       -      -1
bb_makedev                                            51      49      -2
static.saved_hardlinks_created                         4       -      -4
static.saved_hardlinks                                 4       -      -4
longname                                               4       -      -4
linkname                                               4       -      -4
hash_file                                            251     247      -4
get_header_tar                                      1528    1521      -7
rpm_main                                            1711    1697     -14
get_header_cpio                                      965     944     -21
------------------------------------------------------------------------------
(add/remove: 0/6 grow/shrink: 0/5 up/down: 0/-66)             Total: -66 bytes
   text    data     bss     dec     hex filename
 804926     611    6868  812405   c6575 busybox_old
 804878     611    6852  812341   c6535 busybox_unstripped

16 years agofix FAST_FUNC fallout
Denis Vlasenko [Sat, 28 Jun 2008 04:58:55 +0000 (04:58 -0000)]
fix FAST_FUNC fallout

16 years agobuild system fixlet to ease blackfin build
Denis Vlasenko [Sat, 28 Jun 2008 04:00:01 +0000 (04:00 -0000)]
build system fixlet to ease blackfin build

16 years agotouch: support -r REF_FILE if ENABLE_DESKTOP (needed for blackfin compile)
Denis Vlasenko [Sat, 28 Jun 2008 01:18:09 +0000 (01:18 -0000)]
touch: support -r REF_FILE if ENABLE_DESKTOP (needed for blackfin compile)

function                                             old     new   delta
touch_main                                           136     221     +85

16 years agostat: pointers are not 0L, they are NULL
Denis Vlasenko [Fri, 27 Jun 2008 22:31:07 +0000 (22:31 -0000)]
stat: pointers are not 0L, they are NULL
man: better error handling

16 years agoman: mimic "no manual entry for 'bogus'" message and exitcode
Denis Vlasenko [Fri, 27 Jun 2008 22:05:21 +0000 (22:05 -0000)]
man: mimic "no manual entry for 'bogus'" message and exitcode

16 years agosupport gzip -t and bzip2 -t
Denis Vlasenko [Fri, 27 Jun 2008 21:52:41 +0000 (21:52 -0000)]
support gzip -t and bzip2 -t

16 years agosendmail: update from maintainer
Denis Vlasenko [Fri, 27 Jun 2008 21:24:08 +0000 (21:24 -0000)]
sendmail: update from maintainer

16 years agocpio: fix -m to actually work as expected (Pascal Bellard)
Denis Vlasenko [Fri, 27 Jun 2008 15:52:07 +0000 (15:52 -0000)]
cpio: fix -m to actually work as expected (Pascal Bellard)

function                                             old     new   delta
cpio_main                                           1140    1153     +13

16 years agounlzma: fix memory leak (Pascal Bellard)
Denis Vlasenko [Fri, 27 Jun 2008 15:48:45 +0000 (15:48 -0000)]
unlzma: fix memory leak (Pascal Bellard)

16 years agoadd stdcall to FAST_FUNC
Denis Vlasenko [Fri, 27 Jun 2008 04:30:48 +0000 (04:30 -0000)]
add stdcall to FAST_FUNC

   text    data     bss     dec     hex filename
 804476     611    6868  811955   c63b3 busybox_old
 804373     611    6868  811852   c634c busybox_unstripped

16 years agovi: fix vda's thinko
Denis Vlasenko [Fri, 27 Jun 2008 04:06:13 +0000 (04:06 -0000)]
vi: fix vda's thinko

16 years agoexpand comment about FAST_FUNC
Denis Vlasenko [Fri, 27 Jun 2008 03:55:18 +0000 (03:55 -0000)]
expand comment about FAST_FUNC

16 years ago*: introduce and use FAST_FUNC: regparm on i386, otherwise no-on
Denis Vlasenko [Fri, 27 Jun 2008 02:52:20 +0000 (02:52 -0000)]
*: introduce and use FAST_FUNC: regparm on i386, otherwise no-on

   text    data     bss     dec     hex filename
 808035     611    6868  815514   c719a busybox_old
 804472     611    6868  811951   c63af busybox_unstripped

16 years agoash: improve comments
Denis Vlasenko [Fri, 27 Jun 2008 00:29:34 +0000 (00:29 -0000)]
ash: improve comments

16 years agoash: fix very weak $RANDOM generator; and move even more things
Denis Vlasenko [Fri, 27 Jun 2008 00:24:11 +0000 (00:24 -0000)]
ash: fix very weak $RANDOM generator; and move even more things
 out of data/bss

   text    data     bss     dec     hex filename
 807935     611    6884  815430   c7146 busybox_old
 808035     611    6868  815514   c719a busybox_unstripped

16 years agoash: move stuff out of data/bss
Denis Vlasenko [Fri, 27 Jun 2008 00:23:18 +0000 (00:23 -0000)]
ash: move stuff out of data/bss

   text    data     bss     dec     hex filename
 807939     611    6900  815450   c715a busybox_old
 807935     611    6884  815430   c7146 busybox_unstripped

16 years agoprint_flags: fix trivial thinko
Denis Vlasenko [Thu, 26 Jun 2008 22:40:02 +0000 (22:40 -0000)]
print_flags: fix trivial thinko
vi: fix reversed checks for underflow

16 years agobunzip2: fix an uncompression error. Add the example to testsuite.
Denis Vlasenko [Thu, 26 Jun 2008 20:27:42 +0000 (20:27 -0000)]
bunzip2: fix an uncompression error. Add the example to testsuite.

16 years agostyle fixes, no code changes
Denis Vlasenko [Thu, 26 Jun 2008 14:32:57 +0000 (14:32 -0000)]
style fixes, no code changes

16 years agoopen_transformer: fix bug of calling exit instead of _exit
Denis Vlasenko [Thu, 26 Jun 2008 03:26:57 +0000 (03:26 -0000)]
open_transformer: fix bug of calling exit instead of _exit
open_transformer: don't leak compressed descriptor anymore
recursive_action: tiny shrink

16 years agob[un]zip2, g[un]zip: unlink destination if -f is given. Closes 3854
Denis Vlasenko [Wed, 25 Jun 2008 20:54:45 +0000 (20:54 -0000)]
b[un]zip2, g[un]zip: unlink destination if -f is given. Closes 3854

16 years agoAnnounce 1.10.4 and 1.11.0
Denis Vlasenko [Wed, 25 Jun 2008 15:58:00 +0000 (15:58 -0000)]
Announce 1.10.4 and 1.11.0

16 years agobusybox: do not print help to fd 2, print it to fd 1
Denis Vlasenko [Wed, 25 Jun 2008 12:15:46 +0000 (12:15 -0000)]
busybox: do not print help to fd 2, print it to fd 1
 otherwise this can break scripts

16 years agoupdate defconfig
Denis Vlasenko [Wed, 25 Jun 2008 10:59:44 +0000 (10:59 -0000)]
update defconfig

16 years agoStart 1.12.x
Denis Vlasenko [Wed, 25 Jun 2008 10:18:16 +0000 (10:18 -0000)]
Start 1.12.x

16 years agoThis is 1.11.0
Denis Vlasenko [Wed, 25 Jun 2008 10:16:17 +0000 (10:16 -0000)]
This is 1.11.0

16 years agomkfs_minix, fsck_minix: code shrink
Denis Vlasenko [Wed, 25 Jun 2008 10:00:58 +0000 (10:00 -0000)]
mkfs_minix, fsck_minix: code shrink

function                                             old     new   delta
fsck_minix_main                                     3092    3094      +2
next                                                 539     538      -1
get_free_block                                       165     164      -1
check_zone_nr2                                       121     120      -1
alarm_intr                                            94      93      -1
recursive_check2                                     587     583      -4
recursive_check                                      587     583      -4
mkfs_minix_main                                     2974    2968      -6
map_block                                            237     231      -6
map_block2                                           341     333      -8
bad_zone                                              64      56      -8
write_block                                          619     610      -9
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/11 up/down: 2/-49)            Total: -47 bytes

16 years agowhitespace fixes. no code changes
Denis Vlasenko [Wed, 25 Jun 2008 09:53:17 +0000 (09:53 -0000)]
whitespace fixes. no code changes

16 years agomount: fix mishandling of proto=tcp/udp
Denis Vlasenko [Tue, 24 Jun 2008 21:39:32 +0000 (21:39 -0000)]
mount: fix mishandling of proto=tcp/udp

function                                             old     new   delta
singlemount                                         4729    4695     -34

16 years agomount: code shrink without logic changes. Added a comment
Denis Vlasenko [Tue, 24 Jun 2008 18:59:59 +0000 (18:59 -0000)]
mount: code shrink without logic changes. Added a comment
on possible mismatch with util-linux in -o remount handling.

function                                             old     new   delta
mount_main                                           995     953     -42
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-42)             Total: -42 bytes

16 years agochanges in comments only
Denis Vlasenko [Tue, 24 Jun 2008 16:08:22 +0000 (16:08 -0000)]
changes in comments only

16 years agovi: fix yet another vda's thinko
Denis Vlasenko [Tue, 24 Jun 2008 14:10:41 +0000 (14:10 -0000)]
vi: fix yet another vda's thinko

16 years agohush: ifdef out parts which are not needed
Denis Vlasenko [Tue, 24 Jun 2008 00:50:07 +0000 (00:50 -0000)]
hush: ifdef out parts which are not needed
if neither loops nor ifs are supported. Code savings:

function                                             old     new   delta
parse_stream                                        1758    1757      -1
checkjobs                                            335     318     -17
done_pipe                                             74      52     -22
expand_variables                                    1437    1407     -30
run_list                                            1232    1189     -43
parse_and_run_stream                                 328     267     -61
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/6 up/down: 0/-174)           Total: -174 bytes

16 years agohush: kill some old unused fields; small code shrink
Denis Vlasenko [Tue, 24 Jun 2008 00:47:58 +0000 (00:47 -0000)]
hush: kill some old unused fields; small code shrink

function                                             old     new   delta
builtin_exit                                          48      47      -1
checkjobs                                            351     335     -16
checkjobs_and_fg_shell                                60      35     -25
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-42)             Total: -42 bytes

16 years agofix breakage found by randomconfig
Denis Vlasenko [Mon, 23 Jun 2008 22:31:52 +0000 (22:31 -0000)]
fix breakage found by randomconfig

16 years agohush: trivial fix in debug code
Denis Vlasenko [Mon, 23 Jun 2008 16:28:53 +0000 (16:28 -0000)]
hush: trivial fix in debug code

16 years agoash: trivial code readability fixes
Denis Vlasenko [Mon, 23 Jun 2008 13:24:19 +0000 (13:24 -0000)]
ash: trivial code readability fixes

16 years agoash: improve readability of the code. No real code changes.
Denis Vlasenko [Mon, 23 Jun 2008 13:06:34 +0000 (13:06 -0000)]
ash: improve readability of the code. No real code changes.

16 years agoash: optional support for $'...\t...\n...' bashism
Denis Vlasenko [Mon, 23 Jun 2008 01:52:30 +0000 (01:52 -0000)]
ash: optional support for $'...\t...\n...' bashism

function                                             old     new   delta
readtoken1                                          2824    3172    +348
static.C_escapes                                       -      18     +18
parse_command                                       1504    1500      -4
SIT                                                   89      83      -6
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 1/2 up/down: 366/-10)           Total: 356 bytes

16 years agotrim usage text
Denis Vlasenko [Sun, 22 Jun 2008 20:14:00 +0000 (20:14 -0000)]
trim usage text

16 years agomdoprobe: fix SEGV bug (by Vlad Dronnikov)
Denis Vlasenko [Sun, 22 Jun 2008 16:59:46 +0000 (16:59 -0000)]
mdoprobe: fix SEGV bug (by Vlad Dronnikov)

16 years agovi: fix obvious thinko's
Denis Vlasenko [Sun, 22 Jun 2008 16:38:53 +0000 (16:38 -0000)]
vi: fix obvious thinko's

16 years agowget: accept code 204.
Denis Vlasenko [Sun, 22 Jun 2008 16:28:02 +0000 (16:28 -0000)]
wget: accept code 204.

16 years agovi: fix vda's breakage (by Cristian Ionescu-Idbohrn)
Denis Vlasenko [Sun, 22 Jun 2008 13:20:42 +0000 (13:20 -0000)]
vi: fix vda's breakage (by Cristian Ionescu-Idbohrn)

16 years agoash: minor shrink (mostly smallints) and variable renaming
Denis Vlasenko [Sun, 22 Jun 2008 13:16:23 +0000 (13:16 -0000)]
ash: minor shrink (mostly smallints) and variable renaming

function                                             old     new   delta
optschanged                                           85      91      +6
tryexec                                              115     118      +3
xxreadtoken                                          290     292      +2
raise_error_unexpected_syntax                         75      77      +2
bltincmd                                               6       8      +2
parseheredoc                                         128     129      +1
static.is_interactive                                  4       1      -3
readtoken                                            156     153      -3
lasttoken                                              4       1      -3
evalcommand                                         1147    1144      -3
checkkwd                                               4       1      -3
back_exitstatus                                        4       1      -3
pipeline                                             282     276      -6
list                                                 369     360      -9
ash_main                                            1402    1393      -9
options                                              616     606     -10
readtoken1                                          2823    2811     -12
parse_command                                       1529    1507     -22
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 6/12 up/down: 21/-91)           Total: -70 bytes
   text    data     bss     dec     hex filename
 807603     611    6908  815122   c7012 busybox_old
 807545     611    6900  815056   c6fd0 busybox_unstripped

16 years agodpkg: trivial code shrinkage, and redo G trick correctly.
Denis Vlasenko [Sat, 21 Jun 2008 23:15:43 +0000 (23:15 -0000)]
dpkg: trivial code shrinkage, and redo G trick correctly.

function                                             old     new   delta
run_package_script_or_die                              -      72     +72
fill_package_struct                                  303     309      +6
search_package_hashtable                             122     125      +3
get_status                                           112     111      -1
status_hashtable                                       4       -      -4
set_status                                           162     158      -4
package_hashtable                                      4       -      -4
name_hashtable                                         4       -      -4
package_satisfies_dependency                         112     106      -6
search_name_hashtable                                118     110      -8
configure_package                                    121     106     -15
remove_package                                       333     317     -16
search_status_hashtable                              133     111     -22
purge_package                                        247     217     -30
unpack_package                                       552     521     -31
run_package_script                                    62       -     -62
dpkg_main                                           3991    3867    -124
------------------------------------------------------------------------------
(add/remove: 1/4 grow/shrink: 2/10 up/down: 81/-331)         Total: -250 bytes
   text    data     bss     dec     hex filename
 807972     611    6924  815507   c7193 busybox_old
 807603     611    6908  815122   c7012 busybox_unstripped

16 years agodpkg: code shrink
Denis Vlasenko [Sat, 21 Jun 2008 22:46:58 +0000 (22:46 -0000)]
dpkg: code shrink
dpkg: add documentation from bug 3644

function                                             old     new   delta
remove_package                                       318     333     +15
unpack_package                                       541     552     +11
purge_package                                        242     247      +5
all_control_list                                      55      53      -2
all_control_files                                     44      40      -4
add_split_dependencies                               709     703      -6
search_status_hashtable                              148     133     -15
search_package_hashtable                             137     122     -15
search_name_hashtable                                134     118     -16
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/6 up/down: 31/-58)            Total: -27 bytes
   text    data     bss     dec     hex filename
 808093     611    6924  815628   c720c busybox_old
 807972     611    6924  815507   c7193 busybox_unstripped

16 years agodpkg: code shrink (by Peter Korsgaard <jacmet@uclibc.org>)
Denis Vlasenko [Sat, 21 Jun 2008 22:10:52 +0000 (22:10 -0000)]
dpkg: code shrink (by Peter Korsgaard <jacmet@uclibc.org>)

function                                             old     new   delta
create_list                                          104      86     -18

16 years agovi: small code shrink
Denis Vlasenko [Sat, 21 Jun 2008 20:31:50 +0000 (20:31 -0000)]
vi: small code shrink

function                                             old     new   delta
file_insert                                          328     329      +1
colon                                               3067    3064      -3
string_insert                                         93      89      -4
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/2 up/down: 1/-7)               Total: -6 bytes

16 years agovi: fix the bug where vi never grows the edit buffer.
Denis Vlasenko [Fri, 20 Jun 2008 20:20:54 +0000 (20:20 -0000)]
vi: fix the bug where vi never grows the edit buffer.
vi: do G trick on it

function                                             old     new   delta
place_cursor                                         264     276     +12
next_tabstop                                          22      34     +12
mycmp                                                 44      52      +8
status_line                                           34      40      +6
yank_delete                                           89      92      +3
what_reg                                              34      37      +3
suspend_sig                                           63      66      +3
find_range                                           493     496      +3
redraw                                               104     106      +2
cont_sig                                              63      65      +2
Indicate_Error                                        59      61      +2
status_line_bold                                      71      72      +1
file_insert                                          327     328      +1
vi_setops                                              1       -      -1
...
cmdcnt                                                 4       -      -4
chars_to_parse                                         4       -      -4
ccol                                                   4       -      -4
dot_scroll                                            88      79      -9
stupid_insert                                         28      18     -10
winch_sig                                            102      91     -11
char_insert                                          353     336     -17
readit                                               354     336     -18
get_one_char                                         128     110     -18
init_text_buffer                                     171     152     -19
text_hole_delete                                     132     112     -20
edit_file                                            940     918     -22
get_input_line                                       198     168     -30
show_status_line                                     449     408     -41
colon                                               3112    3067     -45
vi_main                                              312     250     -62
refresh                                             1077     974    -103
do_cmd                                              4818    4483    -335
------------------------------------------------------------------------------
(add/remove: 0/38 grow/shrink: 13/20 up/down: 58/-889)       Total: -831 bytes
   text    data     bss     dec     hex filename
 809566     612    7044  817222   c7846 busybox_old
 808794     611    6924  816329   c74c9 busybox_unstripped

   text    data     bss     dec     hex filename
  18888       1     122   19011    4a43 busybox.t8/editors/vi.o
  18116       0       0   18116    46c4 busybox.t9/editors/vi.o

16 years agossd: fix comment
Denis Vlasenko [Fri, 20 Jun 2008 18:24:14 +0000 (18:24 -0000)]
ssd: fix comment

16 years agoudhcpc: change BPF filter to not use 0xffffffff as a max packet size,
Denis Vlasenko [Fri, 20 Jun 2008 12:17:59 +0000 (12:17 -0000)]
udhcpc: change BPF filter to not use 0xffffffff as a max packet size,
there are kernels which don't like big (negative when viewed as signed)
sizes.

16 years agostrrchr: actually, last one was finding "" in "any" at pos 0,
Denis Vlasenko [Wed, 18 Jun 2008 20:01:12 +0000 (20:01 -0000)]
strrchr: actually, last one was finding "" in "any" at pos 0,
should find at pos LAST...

16 years agostrrchr: bikeshed painting time!
Denis Vlasenko [Wed, 18 Jun 2008 19:49:46 +0000 (19:49 -0000)]
strrchr: bikeshed painting time!
 replace cubic running time implementation with quadratic
 make embedded test actually readable

function                                             old     new   delta
strrstr                                               42      44      +2

16 years agoash: fix "shift BIGNUM" and "read with no variable name" bugs.
Denis Vlasenko [Wed, 18 Jun 2008 19:22:19 +0000 (19:22 -0000)]
ash: fix "shift BIGNUM" and "read with no variable name" bugs.
 omg. hush testsuite helps to find bugs in ash! what next?

function                                             old     new   delta
static.arg_REPLY                                       -       8      +8
readcmd                                             1023    1021      -2
shiftcmd                                             129     125      -4
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/2 up/down: 8/-6)                Total: 2 bytes

16 years agocosmetics in hush testsuites
Denis Vlasenko [Wed, 18 Jun 2008 17:53:57 +0000 (17:53 -0000)]
cosmetics in hush testsuites

16 years agofix globbing in unquoted $* and $@
Denis Vlasenko [Wed, 18 Jun 2008 17:49:58 +0000 (17:49 -0000)]
fix globbing in unquoted $* and $@

16 years agofix trivial error with inverted exit code in ls
Denis Vlasenko [Wed, 18 Jun 2008 16:38:22 +0000 (16:38 -0000)]
fix trivial error with inverted exit code in ls

16 years agohush: fix a bug with backslashes improperly handled in unquoted variables.
Denis Vlasenko [Wed, 18 Jun 2008 16:30:42 +0000 (16:30 -0000)]
hush: fix a bug with backslashes improperly handled in unquoted variables.
 with previous patch:

function                                             old     new   delta
parse_stream                                        1638    1758    +120
expand_on_ifs                                         97     174     +77
free_pipe                                            206     237     +31
setup_redirect                                       217     220      +3
setup_redirects                                      143     144      +1
done_word                                            698     688     -10
free_strings                                          38       -     -38
expand_variables                                    1451    1403     -48
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 5/2 up/down: 232/-96)           Total: 136 bytes

16 years agohush: add testsuite for "no globbing in redirection" rule.
Denis Vlasenko [Wed, 18 Jun 2008 16:29:32 +0000 (16:29 -0000)]
hush: add testsuite for "no globbing in redirection" rule.
 simplify redirection habdling

16 years agohush: expand quote3.tests and move from hush-bugs to hush-parsing
Denis Vlasenko [Wed, 18 Jun 2008 09:22:31 +0000 (09:22 -0000)]
hush: expand quote3.tests and move from hush-bugs to hush-parsing

16 years agohush: fix last hush-bugs testcase (disappearing "", $empty"" etc)
Denis Vlasenko [Wed, 18 Jun 2008 09:20:35 +0000 (09:20 -0000)]
hush: fix last hush-bugs testcase (disappearing "", $empty"" etc)