oweals/busybox.git
16 years agodpkg: trivial code shrinkage, and redo G trick correctly.
Denis Vlasenko [Sat, 21 Jun 2008 23:15:43 +0000 (23:15 -0000)]
dpkg: trivial code shrinkage, and redo G trick correctly.

function                                             old     new   delta
run_package_script_or_die                              -      72     +72
fill_package_struct                                  303     309      +6
search_package_hashtable                             122     125      +3
get_status                                           112     111      -1
status_hashtable                                       4       -      -4
set_status                                           162     158      -4
package_hashtable                                      4       -      -4
name_hashtable                                         4       -      -4
package_satisfies_dependency                         112     106      -6
search_name_hashtable                                118     110      -8
configure_package                                    121     106     -15
remove_package                                       333     317     -16
search_status_hashtable                              133     111     -22
purge_package                                        247     217     -30
unpack_package                                       552     521     -31
run_package_script                                    62       -     -62
dpkg_main                                           3991    3867    -124
------------------------------------------------------------------------------
(add/remove: 1/4 grow/shrink: 2/10 up/down: 81/-331)         Total: -250 bytes
   text    data     bss     dec     hex filename
 807972     611    6924  815507   c7193 busybox_old
 807603     611    6908  815122   c7012 busybox_unstripped

16 years agodpkg: code shrink
Denis Vlasenko [Sat, 21 Jun 2008 22:46:58 +0000 (22:46 -0000)]
dpkg: code shrink
dpkg: add documentation from bug 3644

function                                             old     new   delta
remove_package                                       318     333     +15
unpack_package                                       541     552     +11
purge_package                                        242     247      +5
all_control_list                                      55      53      -2
all_control_files                                     44      40      -4
add_split_dependencies                               709     703      -6
search_status_hashtable                              148     133     -15
search_package_hashtable                             137     122     -15
search_name_hashtable                                134     118     -16
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/6 up/down: 31/-58)            Total: -27 bytes
   text    data     bss     dec     hex filename
 808093     611    6924  815628   c720c busybox_old
 807972     611    6924  815507   c7193 busybox_unstripped

16 years agodpkg: code shrink (by Peter Korsgaard <jacmet@uclibc.org>)
Denis Vlasenko [Sat, 21 Jun 2008 22:10:52 +0000 (22:10 -0000)]
dpkg: code shrink (by Peter Korsgaard <jacmet@uclibc.org>)

function                                             old     new   delta
create_list                                          104      86     -18

16 years agovi: small code shrink
Denis Vlasenko [Sat, 21 Jun 2008 20:31:50 +0000 (20:31 -0000)]
vi: small code shrink

function                                             old     new   delta
file_insert                                          328     329      +1
colon                                               3067    3064      -3
string_insert                                         93      89      -4
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/2 up/down: 1/-7)               Total: -6 bytes

16 years agovi: fix the bug where vi never grows the edit buffer.
Denis Vlasenko [Fri, 20 Jun 2008 20:20:54 +0000 (20:20 -0000)]
vi: fix the bug where vi never grows the edit buffer.
vi: do G trick on it

function                                             old     new   delta
place_cursor                                         264     276     +12
next_tabstop                                          22      34     +12
mycmp                                                 44      52      +8
status_line                                           34      40      +6
yank_delete                                           89      92      +3
what_reg                                              34      37      +3
suspend_sig                                           63      66      +3
find_range                                           493     496      +3
redraw                                               104     106      +2
cont_sig                                              63      65      +2
Indicate_Error                                        59      61      +2
status_line_bold                                      71      72      +1
file_insert                                          327     328      +1
vi_setops                                              1       -      -1
...
cmdcnt                                                 4       -      -4
chars_to_parse                                         4       -      -4
ccol                                                   4       -      -4
dot_scroll                                            88      79      -9
stupid_insert                                         28      18     -10
winch_sig                                            102      91     -11
char_insert                                          353     336     -17
readit                                               354     336     -18
get_one_char                                         128     110     -18
init_text_buffer                                     171     152     -19
text_hole_delete                                     132     112     -20
edit_file                                            940     918     -22
get_input_line                                       198     168     -30
show_status_line                                     449     408     -41
colon                                               3112    3067     -45
vi_main                                              312     250     -62
refresh                                             1077     974    -103
do_cmd                                              4818    4483    -335
------------------------------------------------------------------------------
(add/remove: 0/38 grow/shrink: 13/20 up/down: 58/-889)       Total: -831 bytes
   text    data     bss     dec     hex filename
 809566     612    7044  817222   c7846 busybox_old
 808794     611    6924  816329   c74c9 busybox_unstripped

   text    data     bss     dec     hex filename
  18888       1     122   19011    4a43 busybox.t8/editors/vi.o
  18116       0       0   18116    46c4 busybox.t9/editors/vi.o

16 years agossd: fix comment
Denis Vlasenko [Fri, 20 Jun 2008 18:24:14 +0000 (18:24 -0000)]
ssd: fix comment

16 years agoudhcpc: change BPF filter to not use 0xffffffff as a max packet size,
Denis Vlasenko [Fri, 20 Jun 2008 12:17:59 +0000 (12:17 -0000)]
udhcpc: change BPF filter to not use 0xffffffff as a max packet size,
there are kernels which don't like big (negative when viewed as signed)
sizes.

16 years agostrrchr: actually, last one was finding "" in "any" at pos 0,
Denis Vlasenko [Wed, 18 Jun 2008 20:01:12 +0000 (20:01 -0000)]
strrchr: actually, last one was finding "" in "any" at pos 0,
should find at pos LAST...

16 years agostrrchr: bikeshed painting time!
Denis Vlasenko [Wed, 18 Jun 2008 19:49:46 +0000 (19:49 -0000)]
strrchr: bikeshed painting time!
 replace cubic running time implementation with quadratic
 make embedded test actually readable

function                                             old     new   delta
strrstr                                               42      44      +2

16 years agoash: fix "shift BIGNUM" and "read with no variable name" bugs.
Denis Vlasenko [Wed, 18 Jun 2008 19:22:19 +0000 (19:22 -0000)]
ash: fix "shift BIGNUM" and "read with no variable name" bugs.
 omg. hush testsuite helps to find bugs in ash! what next?

function                                             old     new   delta
static.arg_REPLY                                       -       8      +8
readcmd                                             1023    1021      -2
shiftcmd                                             129     125      -4
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/2 up/down: 8/-6)                Total: 2 bytes

16 years agocosmetics in hush testsuites
Denis Vlasenko [Wed, 18 Jun 2008 17:53:57 +0000 (17:53 -0000)]
cosmetics in hush testsuites

16 years agofix globbing in unquoted $* and $@
Denis Vlasenko [Wed, 18 Jun 2008 17:49:58 +0000 (17:49 -0000)]
fix globbing in unquoted $* and $@

16 years agofix trivial error with inverted exit code in ls
Denis Vlasenko [Wed, 18 Jun 2008 16:38:22 +0000 (16:38 -0000)]
fix trivial error with inverted exit code in ls

16 years agohush: fix a bug with backslashes improperly handled in unquoted variables.
Denis Vlasenko [Wed, 18 Jun 2008 16:30:42 +0000 (16:30 -0000)]
hush: fix a bug with backslashes improperly handled in unquoted variables.
 with previous patch:

function                                             old     new   delta
parse_stream                                        1638    1758    +120
expand_on_ifs                                         97     174     +77
free_pipe                                            206     237     +31
setup_redirect                                       217     220      +3
setup_redirects                                      143     144      +1
done_word                                            698     688     -10
free_strings                                          38       -     -38
expand_variables                                    1451    1403     -48
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 5/2 up/down: 232/-96)           Total: 136 bytes

16 years agohush: add testsuite for "no globbing in redirection" rule.
Denis Vlasenko [Wed, 18 Jun 2008 16:29:32 +0000 (16:29 -0000)]
hush: add testsuite for "no globbing in redirection" rule.
 simplify redirection habdling

16 years agohush: expand quote3.tests and move from hush-bugs to hush-parsing
Denis Vlasenko [Wed, 18 Jun 2008 09:22:31 +0000 (09:22 -0000)]
hush: expand quote3.tests and move from hush-bugs to hush-parsing

16 years agohush: fix last hush-bugs testcase (disappearing "", $empty"" etc)
Denis Vlasenko [Wed, 18 Jun 2008 09:20:35 +0000 (09:20 -0000)]
hush: fix last hush-bugs testcase (disappearing "", $empty"" etc)

16 years ago- fixes from Tito
Bernhard Reutner-Fischer [Wed, 18 Jun 2008 08:32:25 +0000 (08:32 -0000)]
- fixes from Tito

16 years ago- fix includes
Bernhard Reutner-Fischer [Tue, 17 Jun 2008 12:45:39 +0000 (12:45 -0000)]
- fix includes

16 years agohush: fix $$ handling
Denis Vlasenko [Tue, 17 Jun 2008 12:28:44 +0000 (12:28 -0000)]
hush: fix $$ handling

16 years ago- improved strrstr impl from vda with testcases from Tito and vda
Bernhard Reutner-Fischer [Tue, 17 Jun 2008 12:11:34 +0000 (12:11 -0000)]
- improved strrstr impl from vda with testcases from Tito and vda

16 years agohush: fix "for a in; do echo 'I should never run'; done" bug
Denis Vlasenko [Tue, 17 Jun 2008 12:09:21 +0000 (12:09 -0000)]
hush: fix "for a in; do echo 'I should never run'; done" bug

16 years ago- remove depmod from TODO, it was recently added.
Bernhard Reutner-Fischer [Tue, 17 Jun 2008 07:52:43 +0000 (07:52 -0000)]
- remove depmod from TODO, it was recently added.
  Small touch up while at it

16 years agomove glob_and_assign.tests from hush-bugs to hush-glob
Denis Vlasenko [Tue, 17 Jun 2008 07:26:52 +0000 (07:26 -0000)]
move glob_and_assign.tests from hush-bugs to hush-glob

16 years agohush: continue fixing quoting and subst: fix glob_and_assign.tests.
Denis Vlasenko [Tue, 17 Jun 2008 07:24:29 +0000 (07:24 -0000)]
hush: continue fixing quoting and subst: fix glob_and_assign.tests.

16 years agohush: cleanup pass, the biggest is - moved builtins to the end of the file,
Denis Vlasenko [Tue, 17 Jun 2008 05:43:38 +0000 (05:43 -0000)]
hush: cleanup pass, the biggest is - moved builtins to the end of the file,
 they really annoy in the middle of parser code. no real code changes.

16 years agohush: fix memory leak. it was actually rather invloved problem.
Denis Vlasenko [Tue, 17 Jun 2008 05:11:43 +0000 (05:11 -0000)]
hush: fix memory leak. it was actually rather invloved problem.
Now finally glob/variable expansion is done IN THE RIGHT ORDER!
It opens up a possibility to cleanly fix remaining known bugs.

function                                             old     new   delta
o_save_ptr                                           115     286    +171
o_save_ptr_helper                                      -     115    +115
done_word                                            591     690     +99
o_get_last_ptr                                         -      31     +31
expand_on_ifs                                        125      97     -28
add_string_to_strings                                 28       -     -28
run_list                                            1895    1862     -33
debug_print_strings                                   42       -     -42
add_strings_to_strings                               126       -    -126
expand_variables                                    1550    1394    -156
o_debug_list                                         168       -    -168
expand_strvec_to_strvec                              388      10    -378
------------------------------------------------------------------------------
(add/remove: 2/4 grow/shrink: 2/4 up/down: 416/-959)         Total: -543 bytes

16 years agohush: fixing fallout from last big glob fix:
Denis Vlasenko [Mon, 16 Jun 2008 14:35:57 +0000 (14:35 -0000)]
hush: fixing fallout from last big glob fix:
 fix segfault; identify where we leak memory

function                                             old     new   delta
expand_strvec_to_strvec                              353     336     -17

16 years agohush: delete hush-bugs/glob_and_vars.tests for real
Denis Vlasenko [Mon, 16 Jun 2008 12:53:33 +0000 (12:53 -0000)]
hush: delete hush-bugs/glob_and_vars.tests for real

16 years agohush: fix hush-bugs/glob_and_vars.tests testcase:
Denis Vlasenko [Mon, 16 Jun 2008 12:47:11 +0000 (12:47 -0000)]
hush: fix hush-bugs/glob_and_vars.tests testcase:
 globbing is now done _after_ variable/`cmd` substitution

function                                             old     new   delta
expand_strvec_to_strvec                                7     353    +346
expand_variables                                    1348    1383     +35
add_string_to_strings                                  -      28     +28
globhack                                             114       -    -114
done_word                                            778     579    -199
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 2/1 up/down: 409/-313)           Total: 96 bytes

16 years agotftp: help compiler a bit
Denis Vlasenko [Mon, 16 Jun 2008 07:32:40 +0000 (07:32 -0000)]
tftp: help compiler a bit

16 years agotftpd: PXE server said to need to support "tsize" option
Denis Vlasenko [Mon, 16 Jun 2008 07:12:19 +0000 (07:12 -0000)]
tftpd: PXE server said to need to support "tsize" option
 (by Pascal Bellard <pascal.bellard AT ads-lu.com>).
 Conditional on blocksize option && tftpd support.

function                                             old     new   delta
tftp_protocol                                       1488    1670    +182
tftp_get_option                                        -     102    +102
tftpd_main                                           494     538     +44
tftp_main                                            252     254      +2
tftp_get_blksize                                      97       -     -97
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 3/0 up/down: 330/-97)           Total: 233 bytes

16 years agowhitespace and comment fixes, no code changes
Denis Vlasenko [Mon, 16 Jun 2008 04:09:25 +0000 (04:09 -0000)]
whitespace and comment fixes, no code changes

16 years agoeven more of help text fixes
Denis Vlasenko [Sun, 15 Jun 2008 20:15:27 +0000 (20:15 -0000)]
even more of help text fixes

16 years agofix config help text
Denis Vlasenko [Sun, 15 Jun 2008 20:14:26 +0000 (20:14 -0000)]
fix config help text

16 years ago- fix copy'n paste error.
Bernhard Reutner-Fischer [Sun, 15 Jun 2008 19:02:31 +0000 (19:02 -0000)]
- fix copy'n paste error.
  thanks, vda! :)

16 years agoSpecially for Bernhard Fischer introduce USE_BB_CRYPT
Denis Vlasenko [Sun, 15 Jun 2008 18:35:34 +0000 (18:35 -0000)]
Specially for Bernhard Fischer introduce USE_BB_CRYPT
which selects between libc/custom crypt routines.

16 years agohush: eliminate PARSEFLAG_SEMICOLON and ctx->parse_type field.
Denis Vlasenko [Sun, 15 Jun 2008 11:49:42 +0000 (11:49 -0000)]
hush: eliminate PARSEFLAG_SEMICOLON and ctx->parse_type field.

function                                             old     new   delta
parse_and_run_file                                    30      27      -3
hush_main                                            795     792      -3
initialize_context                                    45      39      -6
done_word                                            791     778     -13
parse_and_run_stream                                 375     338     -37
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/5 up/down: 0/-62)             Total: -62 bytes

16 years agouse USE_FEATURE_UDHCP_PORT instead of ifdef
Denis Vlasenko [Sun, 15 Jun 2008 09:58:53 +0000 (09:58 -0000)]
use USE_FEATURE_UDHCP_PORT instead of ifdef

16 years agoudhcpc: removing stray whitespace
Denis Vlasenko [Sun, 15 Jun 2008 09:49:21 +0000 (09:49 -0000)]
udhcpc: removing stray whitespace

16 years agofurther encrypt_des optimizations
Denis Vlasenko [Sun, 15 Jun 2008 09:48:18 +0000 (09:48 -0000)]
further encrypt_des optimizations

function                                             old     new   delta
pw_encrypt                                           943     964     +21
des_crypt                                           1512    1509      -3
u_sbox                                               512     256    -256
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/2 up/down: 21/-259)          Total: -238 bytes

16 years agocryptpw: fix "cryptpw -a des -- TEXT" case
Denis Vlasenko [Sun, 15 Jun 2008 08:12:00 +0000 (08:12 -0000)]
cryptpw: fix "cryptpw -a des -- TEXT" case
libbb/pw_encrypt_des.c: optimize

function                                             old     new   delta
cryptpw_main                                         177     157     -20
des_crypt                                           1682    1512    -170
pw_encrypt                                          1036     842    -194
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-384)           Total: -384 bytes

Run tested.

16 years ago*: use llist_pop for traverse-and-free list operation
Denis Vlasenko [Sun, 15 Jun 2008 05:40:56 +0000 (05:40 -0000)]
*: use llist_pop for traverse-and-free list operation

function                                             old     new   delta
append_file_list_to_list                             109     111      +2
udhcpc_main                                         2414    2413      -1
run_parts_main                                       325     324      -1
od_main                                             2324    2323      -1
getopt_main                                          709     707      -2
env_main                                             253     251      -2
sed_main                                             659     656      -3
ps_main                                              522     519      -3
traceroute_main                                     3960    3954      -6
sort_main                                            844     838      -6
diff_main                                            866     858      -8
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/10 up/down: 2/-33)            Total: -31 bytes

16 years agoudhcpc: reduce ifdef forest, no code changes
Denis Vlasenko [Sun, 15 Jun 2008 05:40:08 +0000 (05:40 -0000)]
udhcpc: reduce ifdef forest, no code changes

16 years agocrypt: code shrink
Denis Vlasenko [Sat, 14 Jun 2008 22:11:29 +0000 (22:11 -0000)]
crypt: code shrink

function                                             old     new   delta
des_crypt                                              -    1682   +1682
md5_crypt                                              -     627    +627
pw_encrypt                                          3608    1036   -2572
------------------------------------------------------------------------------
(add/remove: 2/0 grow/shrink: 0/1 up/down: 2309/-2572)       Total: -263 bytes

16 years agotar: fix "unused parameter 'gzip'" warning
Denis Vlasenko [Sat, 14 Jun 2008 19:38:35 +0000 (19:38 -0000)]
tar: fix "unused parameter 'gzip'" warning

16 years agohush: fix a bug where we were requiring semicolon here: (cmd;)
Denis Vlasenko [Sat, 14 Jun 2008 17:13:20 +0000 (17:13 -0000)]
hush: fix a bug where we were requiring semicolon here: (cmd;)
 also fix a bug where after error prompt is not shown.

function                                             old     new   delta
parse_stream                                        1612    1638     +26
parse_and_run_stream                                 361     375     +14
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/0 up/down: 40/0)               Total: 40 bytes

16 years agohush: add support for ':'; create testsuite entries
Denis Vlasenko [Sat, 14 Jun 2008 15:50:55 +0000 (15:50 -0000)]
hush: add support for ':'; create testsuite entries

   text    data     bss     dec     hex filename
 809569     612    7044  817225   c7849 busybox_old
 809528     612    7044  817184   c7820 busybox_unstripped

16 years agohush: support "! cmd | cmd" negation
Denis Vlasenko [Sat, 14 Jun 2008 11:00:17 +0000 (11:00 -0000)]
hush: support "! cmd | cmd" negation

function                                             old     new   delta
done_word                                            749     791     +42
run_list                                            1821    1859     +38
checkjobs                                            334     351     +17
done_pipe                                             61      74     +13
static.reserved_list                                 132     144     +12
initialize_context                                    53      45      -8
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 5/1 up/down: 122/-8)            Total: 114 bytes

16 years agoUpdate sponsors page as well
Denis Vlasenko [Sat, 14 Jun 2008 06:23:25 +0000 (06:23 -0000)]
Update sponsors page as well

16 years agoash: small cosmetic change
Denis Vlasenko [Sat, 14 Jun 2008 06:14:02 +0000 (06:14 -0000)]
ash: small cosmetic change

16 years agoash: fix ${var/s/r} handling, add testcase.
Denis Vlasenko [Sat, 14 Jun 2008 06:04:59 +0000 (06:04 -0000)]
ash: fix ${var/s/r} handling, add testcase.

16 years agodos2unix: do not destroy symlinks and mode of the file being converted.
Denis Vlasenko [Sat, 14 Jun 2008 04:28:41 +0000 (04:28 -0000)]
dos2unix: do not destroy symlinks and mode of the file being converted.

16 years agoudhcpc: kill undocumented -W, it was a no-op.
Denis Vlasenko [Fri, 13 Jun 2008 20:44:05 +0000 (20:44 -0000)]
udhcpc: kill undocumented -W, it was a no-op.
 fix option parsing in the case some CONFIG_x are off.
 disable -b on NOMMU, make backgrounding work correctly
 (if a bit differently from MMU case). Previously,
 it wasn't working at all.
 stop using global data for flags in main(), opt
 bitfield works as well.

function                                             old     new   delta
cryptpw_main                                         177     153     -24
packed_usage                                       24478   24452     -26
client_background                                     26       -     -26
udhcpc_main                                         2462    2372     -90
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 0/3 up/down: 0/-166)           Total: -166 bytes

16 years agotrivial crypt shrinkage
Denis Vlasenko [Fri, 13 Jun 2008 15:13:41 +0000 (15:13 -0000)]
trivial crypt shrinkage

function                                             old     new   delta
__md5_to64                                            27      29      +2
pw_encrypt                                          3631    3608     -23

16 years agofix typo in "Analog Devices"
Denis Vlasenko [Fri, 13 Jun 2008 13:49:59 +0000 (13:49 -0000)]
fix typo in "Analog Devices"

16 years agohttpd: fix authentication
Denis Vlasenko [Fri, 13 Jun 2008 13:20:38 +0000 (13:20 -0000)]
httpd: fix authentication

16 years agoshorten sponsor's link per its request
Denis Vlasenko [Fri, 13 Jun 2008 13:10:01 +0000 (13:10 -0000)]
shorten sponsor's link per its request

16 years agowebsite: announce sponsors.
Denis Vlasenko [Fri, 13 Jun 2008 12:06:22 +0000 (12:06 -0000)]
website: announce sponsors.

16 years agobuild system: introduce FEATURE_ASSUME_UNICODE
Denis Vlasenko [Fri, 13 Jun 2008 11:16:09 +0000 (11:16 -0000)]
build system: introduce FEATURE_ASSUME_UNICODE
ls: use it. also do G trick. with UNICODE off:

function                                             old     new   delta
ls_main                                              843     871     +28
show_color                                             1       -      -1
showdirs                                             500     497      -3
my_stat                                              100      97      -3
terminal_width                                         4       -      -4
tabstops                                               4       -      -4
status                                               122     118      -4
static.dotdir                                          4       -      -4
current_time_t                                         4       -      -4
all_fmt                                                4       -      -4
------------------------------------------------------------------------------
(add/remove: 0/6 grow/shrink: 1/3 up/down: 28/-31)             Total: -3 bytes

Also was tested with UNICODE on with glibc.

16 years agohttpd: fix bugs in authentication (by Peter Korsgaard <jacmet ATuclibc.org>)
Denis Vlasenko [Fri, 13 Jun 2008 09:55:13 +0000 (09:55 -0000)]
httpd: fix bugs in authentication (by Peter Korsgaard <jacmet ATuclibc.org>)
 we were accepting empty username; also we were always checking
 dummy user:passwd pair ":" if user gave us wrong one.

function                                             old     new   delta
check_user_passwd                                    338     319     -19

16 years agohtppd: lots of variable/function renaming in config file parsing.
Denis Vlasenko [Fri, 13 Jun 2008 09:53:06 +0000 (09:53 -0000)]
htppd: lots of variable/function renaming in config file parsing.
fixed a bug where we trashed config file's name;
otherwise, should not have any real behavioral changes.

function                                             old     new   delta
check_user_passwd                                      -     338    +338
handle_incoming_and_exit                            2661    2649     -12
parse_conf                                          1650    1536    -114
checkPerm                                            338       -    -338
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 0/2 up/down: 338/-464)         Total: -126 bytes

16 years agoReinstate DEBUG_PESSIMIZE (by Christian Ionescu-Idbohrn)
Denis Vlasenko [Thu, 12 Jun 2008 20:23:03 +0000 (20:23 -0000)]
Reinstate DEBUG_PESSIMIZE (by Christian Ionescu-Idbohrn)

16 years agomake pw_encrypt() return malloc'ed string.
Denis Vlasenko [Thu, 12 Jun 2008 16:56:52 +0000 (16:56 -0000)]
make pw_encrypt() return malloc'ed string.

   text    data     bss     dec     hex filename
 759802     604    6684  767090   bb472 busybox_old
 759804     604    6676  767084   bb46c busybox_unstripped

16 years agouclibc insists on having 70k static buffer for crypt.
Denis Vlasenko [Thu, 12 Jun 2008 16:55:59 +0000 (16:55 -0000)]
uclibc insists on having 70k static buffer for crypt.
For bbox it's not acceptable. Roll our own des and md5 crypt
implementation. Against older uclibc:

   text    data     bss     dec     hex filename
 759945     604    6684  767233   bb501 busybox_old
 759766     604    6684  767054   bb44e busybox_unstripped

so, we still save on code size.

16 years ago- make the first arg of the filter function passed to rtnl_dump_filter constant
Bernhard Reutner-Fischer [Thu, 12 Jun 2008 15:54:49 +0000 (15:54 -0000)]
- make the first arg of the filter function passed to rtnl_dump_filter constant
  to match normal iproute. No obj-code changes.

16 years agohush: speed up o_addX{chr,str}
Denis Vlasenko [Thu, 12 Jun 2008 13:31:04 +0000 (13:31 -0000)]
hush: speed up o_addX{chr,str}

function                                             old     new   delta
o_addQstr                                              -     162    +162
o_addQchr                                              -      89     +89
o_addstr                                               -      58     +58
o_addqchr                                             50      81     +31
expand_on_ifs                                        103      97      -6
add_till_backquote                                    92      82     -10
expand_variables                                    1281    1217     -64
parse_stream                                        1675    1609     -66
o_addqstr                                            155       -    -155
------------------------------------------------------------------------------
(add/remove: 3/1 grow/shrink: 1/4 up/down: 340/-301)           Total: 39 bytes
   text    data     bss     dec     hex filename
 759870     604    6684  767158   bb4b6 busybox_old
 759909     604    6684  767197   bb4dd busybox_unstripped

16 years agohush: fix for nested $()s with escapes + testsuite
Denis Vlasenko [Thu, 12 Jun 2008 12:58:20 +0000 (12:58 -0000)]
hush: fix for nested $()s with escapes + testsuite

16 years agologger: "clean up" a dirty hack a bit
Denis Vlasenko [Wed, 11 Jun 2008 15:43:19 +0000 (15:43 -0000)]
logger: "clean up" a dirty hack a bit

16 years agohush: more backtick and quoting fixes...
Denis Vlasenko [Tue, 10 Jun 2008 22:39:37 +0000 (22:39 -0000)]
hush: more backtick and quoting fixes...

16 years agohush: fix escaping of \[*?; add testsuites for these and for globbing
Denis Vlasenko [Tue, 10 Jun 2008 20:13:40 +0000 (20:13 -0000)]
hush: fix escaping of \[*?; add testsuites for these and for globbing

16 years agohush: fix yet another fallout
Denis Vlasenko [Tue, 10 Jun 2008 18:27:50 +0000 (18:27 -0000)]
hush: fix yet another fallout
hush: move fixed testsuites out of hush-bugs/*

16 years agohush: fix some fallout from prev commits, add testsuite
Denis Vlasenko [Tue, 10 Jun 2008 18:06:24 +0000 (18:06 -0000)]
hush: fix some fallout from prev commits, add testsuite

16 years agohush: search/and/replace style cleanups, no code changes
Denis Vlasenko [Tue, 10 Jun 2008 18:05:12 +0000 (18:05 -0000)]
hush: search/and/replace style cleanups, no code changes

16 years agohush: fix two nasty bugs:
Denis Vlasenko [Tue, 10 Jun 2008 18:04:32 +0000 (18:04 -0000)]
hush: fix two nasty bugs:
hush-bugs/tick2.tests: ok
hush-bugs/tick.tests: ok

function                                             old     new   delta
parse_stream                                        1332    1557    +225
b_addptr                                               -      97     +97
add_till_backquote                                     -      82     +82
b_addstr                                               -      58     +58
b_grow_by                                              -      50     +50
setup_string_in_str                                    -      29     +29
expand_variables                                    1196    1199      +3
expand_on_ifs                                        100      97      -3
b_addqchr                                             57      50      -7
parse_and_run_string                                  48      31     -17
lookup_param                                          27       -     -27
b_addchr                                              75      45     -30
count_ifs                                             44       -     -44
process_command_subs                                 222       -    -222
------------------------------------------------------------------------------
(add/remove: 5/3 grow/shrink: 2/4 up/down: 544/-350)          Total: 194 bytes
   text    data     bss     dec     hex filename
 759354     604    6684  766642   bb2b2 busybox_old
 759534     604    6684  766822   bb366 busybox_unstripped

16 years agohush: fix a memory leak in NOMMU case
Denis Vlasenko [Tue, 10 Jun 2008 16:19:39 +0000 (16:19 -0000)]
hush: fix a memory leak in NOMMU case

16 years agoless: fix a case when regexp matches ""
Denis Vlasenko [Mon, 9 Jun 2008 16:02:39 +0000 (16:02 -0000)]
less: fix a case when regexp matches ""
hush: remove wrong comment, expand another one

16 years agoreword the error msg so people realize that they broke it, they buy it
Mike Frysinger [Mon, 9 Jun 2008 09:38:45 +0000 (09:38 -0000)]
reword the error msg so people realize that they broke it, they buy it

16 years agocosmetics
Denis Vlasenko [Mon, 9 Jun 2008 07:58:53 +0000 (07:58 -0000)]
cosmetics

16 years agomsh_function.patch: picked it up in the wild.
Denis Vlasenko [Mon, 9 Jun 2008 07:50:25 +0000 (07:50 -0000)]
msh_function.patch: picked it up in the wild.
Fixed allocation bugs (it was allocating
one too small vectors) but it still is very buggy,
thus not applied.

16 years agomsh: style cleanups. No code changes.
Denis Vlasenko [Mon, 9 Jun 2008 07:44:19 +0000 (07:44 -0000)]
msh: style cleanups. No code changes.

16 years agomktemp: make default tempfile template shorter;
Denis Vlasenko [Sun, 8 Jun 2008 20:40:33 +0000 (20:40 -0000)]
mktemp: make default tempfile template shorter;
 make help text more understandable

16 years agohush: add yet another bug to testsuite :(
Denis Vlasenko [Sun, 8 Jun 2008 16:47:09 +0000 (16:47 -0000)]
hush: add yet another bug to testsuite :(

16 years agoifenslave: small shrink
Denis Vlasenko [Sun, 8 Jun 2008 08:01:12 +0000 (08:01 -0000)]
ifenslave: small shrink
   text    data     bss     dec     hex filename
 809731     624    7060  817415   c7907 busybox_old
 809629     624    7060  817313   c78a1 busybox_unstripped

16 years agoip: make numeric table work: "ip route list table 255". closes bug 3664.
Denis Vlasenko [Sun, 8 Jun 2008 00:25:55 +0000 (00:25 -0000)]
ip: make numeric table work: "ip route list table 255". closes bug 3664.

function                                             old     new   delta
iproute_list_or_flush                               1270    1300     +30

16 years agoifenslave: tiny shrink
Denis Vlasenko [Sun, 8 Jun 2008 00:24:43 +0000 (00:24 -0000)]
ifenslave: tiny shrink

   text    data     bss     dec     hex filename
   2221       0       0    2221     8ad busybox.t5/networking/ifenslave.o
   2215       0       0    2215     8a7 busybox.t6/networking/ifenslave.o

16 years agodefine CLOCK_MONOTONIC to 1 if it is not defined
Denis Vlasenko [Sat, 7 Jun 2008 23:43:43 +0000 (23:43 -0000)]
define CLOCK_MONOTONIC to 1 if it is not defined

16 years agoifenslave: further shrink by suppressing excessive inlining
Denis Vlasenko [Sat, 7 Jun 2008 22:14:25 +0000 (22:14 -0000)]
ifenslave: further shrink by suppressing excessive inlining
ifenslave: reorder functions to avoid forward declarations

function                                             old     new   delta
enslave                                                -     531    +531
get_drv_info                                           -     176    +176
ifenslave_main                                      1411     671    -740
------------------------------------------------------------------------------
(add/remove: 2/0 grow/shrink: 0/1 up/down: 707/-740)          Total: -33 bytes
   text    data     bss     dec     hex filename
 809737     624    7060  817421   c790d busybox_old
 809704     624    7060  817388   c78ec busybox_unstripped

16 years agoifenslave: fix improper longopts definition
Denis Vlasenko [Sat, 7 Jun 2008 22:13:04 +0000 (22:13 -0000)]
ifenslave: fix improper longopts definition
ifenslave: shrink

function                                             old     new   delta
set_hwaddr                                             -      45     +45
set_ifrname_and_do_ioctl                               -      26     +26
set_mtu                                                -      25     +25
ioctl_on_skfd                                          -      13     +13
static.ifenslave_longopts                             31      34      +3
set_if_up                                             39      36      -3
set_if_down                                           39      36      -3
set_if_flags                                          38      26     -12
static.ifra                                           32      16     -16
get_slave_flags                                       40      24     -16
get_if_settings                                       98      67     -31
set_slave_mtu                                         37       -     -37
set_slave_hwaddr                                      52       -     -52
set_master_hwaddr                                     52       -     -52
ifenslave_main                                      1566    1411    -155
------------------------------------------------------------------------------
(add/remove: 4/3 grow/shrink: 1/7 up/down: 112/-377)         Total: -265 bytes
   text    data     bss     dec     hex filename
 810002     624    7060  817686   c7a16 busybox_old
 809737     624    7060  817421   c790d busybox_unstripped

16 years agoadd libbb/print_flags.c...
Denis Vlasenko [Sat, 7 Jun 2008 15:11:08 +0000 (15:11 -0000)]
add libbb/print_flags.c...

16 years agolibbb: introduce and use print_flags().
Denis Vlasenko [Sat, 7 Jun 2008 15:10:29 +0000 (15:10 -0000)]
libbb: introduce and use print_flags().
Mostly by Natanael Copa <natanael.copa AT gmail.com>

function                                             old     new   delta
print_e2flags                                          -     189    +189
print_flags_separated                                  -      86     +86
static.flag_labels                                     -      60     +60
static.dma_wmode_masks                                 -      32     +32
static.flag_masks                                      -      28     +28
static.arp_labels                                      -      16     +16
static.arp_masks                                       -      12     +12
ls_main                                              836     843      +7
...
popstring                                            140     134      -6
arp_show                                             740     708     -32
print_flags                                          189      25    -164
ipaddr_list_or_flush                                2396    2170    -226
process_dev                                         5306    4706    -600
------------------------------------------------------------------------------
(add/remove: 10/0 grow/shrink: 5/10 up/down: 458/-1043)      Total: -585 bytes
   text    data     bss     dec     hex filename
 810564     624    7060  818248   c7c48 busybox_old
 810002     624    7060  817686   c7a16 busybox_unstripped

16 years agoUpdate a link to cross-compiling HOWTO.
Denis Vlasenko [Sat, 7 Jun 2008 13:59:27 +0000 (13:59 -0000)]
Update a link to cross-compiling HOWTO.

16 years agoFix trivial problems: "make clean" cleaning too much
Denis Vlasenko [Sat, 7 Jun 2008 12:23:44 +0000 (12:23 -0000)]
Fix trivial problems: "make clean" cleaning too much
and add #include to pull in __be32 typedef.

16 years agogrep: make "-f -" work (+ testsuite)
Denis Vlasenko [Sat, 7 Jun 2008 05:19:31 +0000 (05:19 -0000)]
grep: make "-f -" work (+ testsuite)
diff: small code shrink

function                                             old     new   delta
grep_main                                            722     714      -8
diffreg                                             1825    1793     -32
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-40)             Total: -40 bytes

16 years agoBuild system: track -Wl,-elf2flt in CFLAGS_busybox too.
Denis Vlasenko [Fri, 6 Jun 2008 16:11:12 +0000 (16:11 -0000)]
Build system: track -Wl,-elf2flt in CFLAGS_busybox too.
Document in comments that it generally should be thers,
not in LDFLAGS

16 years agoklogd: make help text more understandable
Denis Vlasenko [Fri, 6 Jun 2008 16:08:04 +0000 (16:08 -0000)]
klogd: make help text more understandable
klogd: by using a register instead of global variable, shrink code a bit

function                                             old     new   delta
klogd_main                                           372     362     -10
packed_usage                                       24504   24486     -18
   text    data     bss     dec     hex filename
 808464     642    7180  816286   c749e busybox_old
 808422     642    7180  816244   c7474 busybox_unstripped

16 years ago- fix compilation on standard-conforming compilers
Bernhard Reutner-Fischer [Fri, 6 Jun 2008 10:31:39 +0000 (10:31 -0000)]
- fix compilation on standard-conforming compilers

16 years ago- fix copy'n paste error for the release date
Bernhard Reutner-Fischer [Fri, 6 Jun 2008 08:40:28 +0000 (08:40 -0000)]
- fix copy'n paste error for the release date

16 years agoip: support for the LOWER_UP flag by Natanael Copa <natanael.copa@gmail.com>.
Denis Vlasenko [Thu, 5 Jun 2008 14:01:04 +0000 (14:01 -0000)]
ip: support for the LOWER_UP flag by Natanael Copa <natanael.copa@gmail.com>.
~50 bytes code growth.

16 years agowhich: -a support (needed for bfin uclibc build script)
Denis Vlasenko [Thu, 5 Jun 2008 13:33:59 +0000 (13:33 -0000)]
which: -a support (needed for bfin uclibc build script)

real support (with CONFIG_DESKTOP=y): 120+ bytes:
   text    data     bss     dec     hex filename
 807958     624    7036  815618   c7202 busybox_old
 808085     624    7036  815745   c7281 busybox_unstripped

"fake" support (with CONFIG_DESKTOP unset): ~45 bytes:
   text    data     bss     dec     hex filename
 797790     611    6996  805397   c4a15 busybox_old
 797834     611    6996  805441   c4a41 busybox_unstripped