Glenn L McGrath [Sun, 22 Feb 2004 03:33:53 +0000 (03:33 -0000)]
Ptch by Hideki IWAMOTO, fix a bug preventing tftp from getting or
putting more than 0xffff blocks.
Glenn L McGrath [Sun, 22 Feb 2004 02:58:57 +0000 (02:58 -0000)]
Return 1 upon failure
Glenn L McGrath [Sun, 22 Feb 2004 00:27:34 +0000 (00:27 -0000)]
No need to check proxy env variable twice, ignore proxy env variable if
its set to 0
Glenn L McGrath [Sat, 21 Feb 2004 09:20:56 +0000 (09:20 -0000)]
Sometimes i get carried away with the use of function pointers, im sure
it seemed like a good idea at the time.
Glenn L McGrath [Sat, 21 Feb 2004 07:49:54 +0000 (07:49 -0000)]
Use return instead of exit, use == instead of & ==, left justify labels,
adjustment of whitespace.
Eric Andersen [Fri, 20 Feb 2004 09:55:37 +0000 (09:55 -0000)]
Document missing cp options
Glenn L McGrath [Fri, 20 Feb 2004 02:34:42 +0000 (02:34 -0000)]
Fix up hard links
Glenn L McGrath [Fri, 20 Feb 2004 02:25:18 +0000 (02:25 -0000)]
A strict interpretation of the ustar format requires the type flag to be
interpreted, we cannot depend on the file type being set in the mode
field.
Glenn L McGrath [Thu, 19 Feb 2004 08:48:30 +0000 (08:48 -0000)]
Add extra comments, freakout if a pax archive is encoutered.
Eric Andersen [Thu, 19 Feb 2004 01:52:29 +0000 (01:52 -0000)]
Chris Larson (kergoth) writes:
As Manuel points out, this is a flawed fix, and doesnt fix the
following:
mkdir -p cpa cpb cpc
cp -a cpa cpa/cpb/cpc
Attached what appears to be a more sane fix. Apply on top of previous.
Please confirm sanity.
Eric Andersen [Thu, 19 Feb 2004 00:44:08 +0000 (00:44 -0000)]
Chris Larson (kergoth) writes:
I was adding -s/--symbolic-link support to busybox cp when I noticed a
bug with -r/-a. Test case:
mkdir -p test/out
cd test
busybox cp -a * out/
Will never return until we run out of open files or similar.
Coreutils cp on the other hand will error with "cannot copy a directory,
`out', into itself, `out'". Patch attached.
Glenn L McGrath [Wed, 18 Feb 2004 13:19:58 +0000 (13:19 -0000)]
Dont use same variable and struct name
Glenn L McGrath [Wed, 18 Feb 2004 13:12:53 +0000 (13:12 -0000)]
Formatting
Glenn L McGrath [Wed, 18 Feb 2004 12:58:00 +0000 (12:58 -0000)]
remove debugging
Manuel Novoa III [Wed, 18 Feb 2004 10:14:17 +0000 (10:14 -0000)]
Patch from OpenWrt.
Rob Landley [Wed, 18 Feb 2004 09:54:15 +0000 (09:54 -0000)]
Add -i option to sed, to edit files in-place.
Manuel Novoa III [Wed, 18 Feb 2004 09:40:41 +0000 (09:40 -0000)]
Fix vstype[] to match VS* defines. Patch from OpenWrt by mbm.
Eric Andersen [Tue, 17 Feb 2004 20:08:11 +0000 (20:08 -0000)]
Remove the unused CONFIG_FEATURE_HTTPD_SET_CGI_VARS_TO_ENV option.
Eric Andersen [Tue, 17 Feb 2004 20:04:34 +0000 (20:04 -0000)]
Mark Lord writes:
The config file processing for inetd in busybox-1.00-pre7 and newer
is broken -- the saved command argv[] values overwrite each other.
Patch to fix it is attached.
Cheers
--
Mark Lord
Real-Time Remedies Inc.
Glenn L McGrath [Tue, 17 Feb 2004 12:22:21 +0000 (12:22 -0000)]
Add the -r option, patch from Rob with some help from myself.
Glenn L McGrath [Tue, 17 Feb 2004 12:04:13 +0000 (12:04 -0000)]
Remove debugging
Glenn L McGrath [Tue, 17 Feb 2004 11:55:06 +0000 (11:55 -0000)]
Dont strip trailing '/' until _after_ i test to set if its there !
Manuel Novoa III [Tue, 17 Feb 2004 10:16:21 +0000 (10:16 -0000)]
Patch from Florian Schirmer <jolt@tuxbox.org>. When I rewrote the parser,
I overlooked the case of someone wanting to use a valid but empty suid
config file.
Glenn L McGrath [Tue, 17 Feb 2004 07:58:04 +0000 (07:58 -0000)]
Woops, im getting ahead of myself, we dont have the -r (refernece)
option yet
Glenn L McGrath [Tue, 17 Feb 2004 07:51:31 +0000 (07:51 -0000)]
define option names to be clearer, simplify nested if statements, remove
un-needed if statement, minor indenting change
Eric Andersen [Sat, 14 Feb 2004 21:33:39 +0000 (21:33 -0000)]
Avoid naming conflict with symbol in newer glibc headers
Eric Andersen [Fri, 13 Feb 2004 08:09:43 +0000 (08:09 -0000)]
Accomodate the fact that newer libc versions may in fact not
contain query_module and friends and more
Eric Andersen [Tue, 10 Feb 2004 01:30:21 +0000 (01:30 -0000)]
oops. Leave the default feature set enbled for now...
Eric Andersen [Tue, 10 Feb 2004 01:28:36 +0000 (01:28 -0000)]
Initial effort at disabling job control as well
Eric Andersen [Tue, 10 Feb 2004 01:07:45 +0000 (01:07 -0000)]
Support disabling pipe and redirect support
Eric Andersen [Mon, 9 Feb 2004 10:57:04 +0000 (10:57 -0000)]
Update URL
Eric Andersen [Mon, 9 Feb 2004 10:01:01 +0000 (10:01 -0000)]
Buffalo appears to have resolved their GPL problems
Eric Andersen [Fri, 6 Feb 2004 10:36:08 +0000 (10:36 -0000)]
Richard Kojedzinszky writes:
Hi All,
I aplogoize for the mistake, but i have just recognized that somehow the
last patch I sent in was wrong, and a '0' was instead of a '-1'. Because
of this, vi does behave the wrong way. So again, it should be the last
patch for vi. This is for pre7.
Eric Andersen [Fri, 6 Feb 2004 10:33:19 +0000 (10:33 -0000)]
Patch from vodz, based on bug report from Richard Kojedzinszky:
Richard,
>I have a problem, which I can reproduce now. I am using pre7 version of
>busybox, and the tab completion works fine. I mean, with an empty command
>line I press the TAB twice, and ash shows me the available commands. But
>when i process the profile file below, as
> $ . /etc/profile
>then it stops working, and the double-tab lists the directories available
>from the cwd, and not the commands. Has someone else meet this problem
>before, or am i doing something wrong?
>
>This is my '/etc/profile':
>- ---
># System profile
>
>PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin
>export PATH
>trap ":" INT QUIT TERM
>
>export PS1="\h \w # "
Thanks. Patch attached.
--w
vodz
Eric Andersen [Fri, 6 Feb 2004 07:16:36 +0000 (07:16 -0000)]
Make the loop support stuff be much less evil, and make it cope
with 2.6.x asm/posix_types.h, which has done singularly evil thing
by yanking __kernel_dev_t and renaming it. The loop interface was
really poorly designed in the first place. The new 64 bit loop
interface looks to be somewhat less horrible, too bad it is only
present in 2.6.x kernels.
-Erik
Eric Andersen [Fri, 6 Feb 2004 05:26:58 +0000 (05:26 -0000)]
Eliminate use of a kernel scsi header file.
Prevent potentially misaligned accesses while indexing a pointer
to the partition table, which would be a bad thing on i.e. arm.
Manuel Novoa III [Thu, 5 Feb 2004 14:45:58 +0000 (14:45 -0000)]
Make sure stdlib.h is always included before dmalloc.h to avoid problems
parsing problems.
Eric Andersen [Thu, 5 Feb 2004 13:52:03 +0000 (13:52 -0000)]
Vladimir N. Oleynik writes:
Hi, Glenn.
Current CVS "ls" applet have small problem: some options
ignoring. Last patch attached ;-)
--w
vodz
Eric Andersen [Thu, 5 Feb 2004 13:49:29 +0000 (13:49 -0000)]
Vladimir N. Oleynik writes:
Ok. I found my mistake :(
The trivial patch attached.
--w
vodz
Eric Andersen [Thu, 5 Feb 2004 00:18:26 +0000 (00:18 -0000)]
Elaborate on CONFIG_SELINUX, and explain that most people should
not enbable this option.
Eric Andersen [Wed, 4 Feb 2004 12:07:40 +0000 (12:07 -0000)]
Grammar fix
Eric Andersen [Wed, 4 Feb 2004 11:59:48 +0000 (11:59 -0000)]
Minor grammar fixup
Eric Andersen [Wed, 4 Feb 2004 11:44:58 +0000 (11:44 -0000)]
Bump version number for release
Eric Andersen [Wed, 4 Feb 2004 11:19:44 +0000 (11:19 -0000)]
Richard Kojedzinszky writes:
Hi,
I've noticed the bug also, and here is another patch for it. I hope it'll
not introduce more bugs. Not too nice, but works for me.
Here it is for busybox-1.00-pre6
Eric Andersen [Wed, 4 Feb 2004 11:10:28 +0000 (11:10 -0000)]
Joe.C writes:
Hi,
When httpd connection is closed, bosybox httpd will
not stop reading from CGI program. This patch fix this
problem. It check the return value of bb_full_write and
stop reading from CGI if the connection is closed.
Please apply this patch.
Joe.C
Eric Andersen [Wed, 4 Feb 2004 11:01:19 +0000 (11:01 -0000)]
Jean Wolter writes:
Hello,
when calling seq with
seq 1 1
it generates an "endless" list of numbers until the counter wraps and
reaches 1 again. The follwoing small patch should introduce the
expected behavior (output of 1 and termination):
regards,
Jean
Eric Andersen [Wed, 4 Feb 2004 10:57:46 +0000 (10:57 -0000)]
Rob Landley writes:
While building glibc with busybox as part of the development environment, I
found a bug in glibc's regexec can throw sed into an endless loop. This
fixes it. Should I put an #ifdef around it or something? (Note, this patch
also contains the "this is not gnu sed 4.0" hack I posted earlier, which is
also needed to build glibc...)
Eric Andersen [Wed, 4 Feb 2004 10:48:37 +0000 (10:48 -0000)]
The variable 'complementaly' used to be allocated with calloc, which zeroed it
out during the allocation process. When vodz changed it to be allocated on the
stack, he forgot to explicitly zero it, leaving its value filled with whatever
used to be sitting on the stack. It would garbage values, depending on the
garbage that happened to be sitting on the stack when the function was called.
The result was that applets using bb_getopt_ulflags() were showing
unpredictable behavior (such as segfaults), which naturally broke many things.
Glenn L McGrath [Wed, 4 Feb 2004 08:27:57 +0000 (08:27 -0000)]
Bug fix from Tito.
Glenn L McGrath [Wed, 4 Feb 2004 08:24:39 +0000 (08:24 -0000)]
Vodz last_patch_125_2, this patch have:
- synced with dash 0.4.21
- better handle trap "cmds..." SIGINT (strange, i make bad hack for ash
and cmdedit, but this work only with this...)
- may be haven`t problem with Ctrl-D
Manuel Novoa III [Sun, 1 Feb 2004 10:03:05 +0000 (10:03 -0000)]
Rewrite parse_config_file(). Among the old version's problems:
No checking for lines that were too long.
No checking that fgets returning NULL was actually due to EOF.
Various whitespace handling inconsistencies.
Bloat (switches and multiple identical function calls).
Failure to check for trailing characters in some cases.
Dynamicly allocated memory was not free()d on error.
Given that this controls suid/sgid behavior, the sloppy coding was
really inexcusable. :-(
Manuel Novoa III [Sun, 1 Feb 2004 07:34:28 +0000 (07:34 -0000)]
Use bb_xstrdup() instead of strdup().
Glenn L McGrath [Sat, 31 Jan 2004 08:08:57 +0000 (08:08 -0000)]
Fix http proxy use, bytes were swapped
Eric Andersen [Sat, 31 Jan 2004 06:11:39 +0000 (06:11 -0000)]
Mention changes to the daily snapshots
Eric Andersen [Sat, 31 Jan 2004 05:44:07 +0000 (05:44 -0000)]
Update docs for release
Eric Andersen [Sat, 31 Jan 2004 05:27:17 +0000 (05:27 -0000)]
Bump version for release
Eric Andersen [Fri, 30 Jan 2004 23:45:53 +0000 (23:45 -0000)]
Use standard C99 types
Eric Andersen [Fri, 30 Jan 2004 22:59:50 +0000 (22:59 -0000)]
Use proper C99 types
Eric Andersen [Fri, 30 Jan 2004 22:56:20 +0000 (22:56 -0000)]
Fixup use of 'u_int' to instead use 'unsigned int'
Eric Andersen [Fri, 30 Jan 2004 22:54:20 +0000 (22:54 -0000)]
s/u_int/uint/g
Eric Andersen [Fri, 30 Jan 2004 22:52:27 +0000 (22:52 -0000)]
s/u_int/unsigned int/g
s/u_short/unsigned short/g
Eric Andersen [Fri, 30 Jan 2004 22:40:05 +0000 (22:40 -0000)]
Use proper C99 types
Eric Andersen [Fri, 30 Jan 2004 22:31:58 +0000 (22:31 -0000)]
Use proper C99 types throughout. So not use silly typedefs.
Eric Andersen [Fri, 30 Jan 2004 22:24:32 +0000 (22:24 -0000)]
Avoid symbol naming conflict with libm
Manuel Novoa III [Fri, 30 Jan 2004 21:44:20 +0000 (21:44 -0000)]
Support new uClibc stdio core.
Eric Andersen [Thu, 29 Jan 2004 22:33:28 +0000 (22:33 -0000)]
Apply a couple of optimizations
Eric Andersen [Tue, 27 Jan 2004 20:17:39 +0000 (20:17 -0000)]
Teach busybox ps to get the correct uid when displaying stuff
Glenn L McGrath [Tue, 27 Jan 2004 09:22:20 +0000 (09:22 -0000)]
New applet, seq. No options, just the basics.
Glenn L McGrath [Tue, 27 Jan 2004 07:36:07 +0000 (07:36 -0000)]
Align using spaces to furthurest character and then one tab, now they
should always be aligned.
Eric Andersen [Mon, 26 Jan 2004 08:23:36 +0000 (08:23 -0000)]
A few little updates, mostly cosmetic
Eric Andersen [Mon, 26 Jan 2004 07:59:42 +0000 (07:59 -0000)]
Sigh. TRENDware has released source -- only for busybox and udhcp.
So despite their not providing kernel source, they have compiled with
the requirements for busybox at least...
Eric Andersen [Mon, 26 Jan 2004 07:17:30 +0000 (07:17 -0000)]
Pascal Brisset writes:
uuencode fails to encode binary data because it right-shifts
bytes as signed chars and keeps the duplicated sign bits.
The original base64_encode() from wget/http.c is broken as well,
but it is only used to encode ascii data.
-- Pascal
Manuel Novoa III [Sun, 25 Jan 2004 19:47:10 +0000 (19:47 -0000)]
Be stricter when converting strings to integers. Should fix the problem
reported by Rob.
Glenn L McGrath [Sun, 25 Jan 2004 08:46:10 +0000 (08:46 -0000)]
Fix compile error when tab completion disabled
Glenn L McGrath [Sun, 25 Jan 2004 05:50:28 +0000 (05:50 -0000)]
Add the -r option as a synonym of -R
Glenn L McGrath [Sun, 25 Jan 2004 05:48:28 +0000 (05:48 -0000)]
Add the -h, --dereference option for archive creation.
Glenn L McGrath [Fri, 23 Jan 2004 21:57:16 +0000 (21:57 -0000)]
Enable long options, adds 150 bytes.
Glenn L McGrath [Fri, 23 Jan 2004 21:43:49 +0000 (21:43 -0000)]
Correct check for only one of K or S options
Glenn L McGrath [Fri, 23 Jan 2004 21:40:19 +0000 (21:40 -0000)]
Check valid options were given
Glenn L McGrath [Fri, 23 Jan 2004 20:28:53 +0000 (20:28 -0000)]
Dont change ownership unless we created the directory.
Glenn L McGrath [Fri, 23 Jan 2004 10:57:00 +0000 (10:57 -0000)]
Remove unneeded conditions and logic, fix bug where ownership didnt
change.
Dont use bb_make_directory it doesnt have the features, and its ugly to
work around it.
Glenn L McGrath [Thu, 22 Jan 2004 12:42:23 +0000 (12:42 -0000)]
last_patch_124 from Vodz, fix an ash bug when alt-1 was pressed, debian
bug #228915
Glenn L McGrath [Thu, 22 Jan 2004 09:04:58 +0000 (09:04 -0000)]
Check one and only one of start, stop are given.
Remove some global variables.
#define some getopt values.
Glenn L McGrath [Thu, 22 Jan 2004 07:10:13 +0000 (07:10 -0000)]
Vodz, last_patch_123, patch have new version getopt_ulflags.
- size reduced 34 bytes
- don`t use dynamic memory allocation
- small indent correction.
Glenn L McGrath [Wed, 21 Jan 2004 11:36:44 +0000 (11:36 -0000)]
Patch from Atsushi Nemoto, recent MIPS kernel headers
does not provide PAGE_SHIFT for userland (because now mips-linux kernel
supports PAGESIZE other than 4K).
Glenn L McGrath [Wed, 21 Jan 2004 10:59:45 +0000 (10:59 -0000)]
Patch by Richard Kojedzinszky, when using END at end of lines it was
skipping to next line, cw command was leaving one char in buffer
Glenn L McGrath [Tue, 20 Jan 2004 15:32:39 +0000 (15:32 -0000)]
Redo getconfigent, save 150 bytes, still small memory leak when
parsing invalid entries.
Glenn L McGrath [Tue, 20 Jan 2004 12:57:18 +0000 (12:57 -0000)]
Patch from Tito, reduce size, merge functions that are only used once.
Eric Andersen [Sun, 18 Jan 2004 18:18:33 +0000 (18:18 -0000)]
Stephane Billiart writes:
bb_lookup_port now takes 3 parameters but rdate has not been modified
accordingly and fails to compile in the current CVS version.
The modification below fixes the problem.
Now, RFC868 allows both UDP and TCP implementations of the time protocol
so this may not work if someone defines a udp time service other than 37
but who would do that?
Glenn L McGrath [Sun, 18 Jan 2004 08:58:06 +0000 (08:58 -0000)]
Fix up a couple of bugs i introduced in yesterdays cleanup.
Glenn L McGrath [Sun, 18 Jan 2004 05:41:30 +0000 (05:41 -0000)]
Fix a bug where `ls -le` would print the time twice.
Glenn L McGrath [Sun, 18 Jan 2004 05:15:16 +0000 (05:15 -0000)]
Use bb_getopt_ulflags, save 200-300 bytes
Glenn L McGrath [Sat, 17 Jan 2004 23:07:14 +0000 (23:07 -0000)]
Patch from Leif Lindholm (slightly modified by me), to fix http
redirection.
Example of incorrect behaviour was the following url, busybox wget didnt
get redirected to the busybox url as it should.
http://freshmeat.net/redir/busybox/953/url_homepage/www.busybox.net
Glenn L McGrath [Sat, 17 Jan 2004 05:03:31 +0000 (05:03 -0000)]
Modify bb_lookup_port to allow the protocol to be specified, allowing
/etc/services support for inetd, netcat and tftp.
Glenn L McGrath [Sat, 17 Jan 2004 03:24:05 +0000 (03:24 -0000)]
Patch from Arthur Othieno, clarify common options between dpkg and dpkg-deb
Glenn L McGrath [Sat, 17 Jan 2004 03:20:46 +0000 (03:20 -0000)]
The functions setconfig, enter and bump_nofile were only called once, marge them into the calling
function.
Glenn L McGrath [Sat, 17 Jan 2004 02:47:45 +0000 (02:47 -0000)]
Use 1 line for function name and return value,
remove dofork define/variable,
dont check pid value is < or > than 0 if we know it is 0.
Glenn L McGrath [Sat, 17 Jan 2004 01:44:32 +0000 (01:44 -0000)]
Remove some defined statements
Glenn L McGrath [Sat, 17 Jan 2004 01:26:53 +0000 (01:26 -0000)]
Changed #define names for common features (superficial)
Glenn L McGrath [Sat, 17 Jan 2004 00:34:31 +0000 (00:34 -0000)]
Use bb_get_chomped_line_from_file