Dr. Stephen Henson [Wed, 17 Feb 2010 19:43:08 +0000 (19:43 +0000)]
OR default SSL_OP_LEGACY_SERVER_CONNECT so existing options are preserved
Dr. Stephen Henson [Wed, 17 Feb 2010 18:37:47 +0000 (18:37 +0000)]
Allow renegotiation if SSL_OP_LEGACY_SERVER_CONNECT is set as well as
initial connection to unpatched servers. There are no additional security
concerns in doing this as clients don't see renegotiation during an
attack anyway.
Dr. Stephen Henson [Wed, 17 Feb 2010 14:32:01 +0000 (14:32 +0000)]
PR: 2100
Submitted by: James Baker <jbaker@tableausoftware.com> et al.
Workaround for slow Heap32Next on some versions of Windows.
Dr. Stephen Henson [Tue, 16 Feb 2010 14:19:42 +0000 (14:19 +0000)]
PR: 2171
Submitted by: Tomas Mraz <tmraz@redhat.com>
Since SSLv2 doesn't support renegotiation at all don't reject it if
legacy renegotiation isn't enabled.
Also can now use SSL2 compatible client hello because RFC5746 supports it.
Dr. Stephen Henson [Mon, 15 Feb 2010 19:40:45 +0000 (19:40 +0000)]
The "block length" for CFB mode was incorrectly coded as 1 all the time. It
should be the number of feedback bits expressed in bytes. For CFB1 mode set
this to 1 by rounding up to the nearest multiple of 8.
Dr. Stephen Henson [Mon, 15 Feb 2010 19:25:37 +0000 (19:25 +0000)]
Correct ECB mode EVP_CIPHER definition: IV length is 0
Dr. Stephen Henson [Mon, 15 Feb 2010 19:02:53 +0000 (19:02 +0000)]
PR: 2164
Submitted by: "Noszticzius, Istvan" <inoszticzius@rightnow.com>
Don't clear the output buffer: ciphers should correctly the same input
and output buffers.
Dr. Stephen Henson [Fri, 12 Feb 2010 22:02:07 +0000 (22:02 +0000)]
update references to new RI RFC
Dr. Stephen Henson [Tue, 9 Feb 2010 14:18:15 +0000 (14:18 +0000)]
Fix memory leak in ENGINE autoconfig code. Improve error logging.
Dr. Stephen Henson [Tue, 9 Feb 2010 14:13:30 +0000 (14:13 +0000)]
update year
Dr. Stephen Henson [Thu, 4 Feb 2010 01:10:24 +0000 (01:10 +0000)]
Only use bufferoverflowu.lib when needed
Dr. Stephen Henson [Tue, 2 Feb 2010 14:19:54 +0000 (14:19 +0000)]
tolerate broken CMS/PKCS7 implementations using signature OID instead of digest
Dr. Stephen Henson [Tue, 2 Feb 2010 14:03:07 +0000 (14:03 +0000)]
make no-rsa no-dsa compile again
Dr. Stephen Henson [Mon, 1 Feb 2010 16:48:40 +0000 (16:48 +0000)]
PR: 2160
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Make session tickets work with DTLS.
Dr. Stephen Henson [Mon, 1 Feb 2010 12:44:21 +0000 (12:44 +0000)]
PR: 2159
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Typo in PR#1949 bug, oops!
Dr. Stephen Henson [Thu, 28 Jan 2010 17:53:11 +0000 (17:53 +0000)]
In engine_table_select() don't clear out entire error queue: just clear
out any we added using ERR_set_mark() and ERR_pop_to_mark() otherwise
errors from other sources (e.g. SSL library) can be wiped.
Dr. Stephen Henson [Wed, 27 Jan 2010 18:53:59 +0000 (18:53 +0000)]
reword RI description
Dr. Stephen Henson [Wed, 27 Jan 2010 17:50:47 +0000 (17:50 +0000)]
update documentation to reflect new renegotiation options
Dr. Stephen Henson [Wed, 27 Jan 2010 16:06:36 +0000 (16:06 +0000)]
Some shells print out the directory name if CDPATH is set breaking the
pod2man test. Use ./util instead to avoid this.
Dr. Stephen Henson [Wed, 27 Jan 2010 14:04:51 +0000 (14:04 +0000)]
typo
Dr. Stephen Henson [Wed, 27 Jan 2010 14:03:26 +0000 (14:03 +0000)]
stop warnings in fips_test_suite application
Dr. Stephen Henson [Wed, 27 Jan 2010 13:32:31 +0000 (13:32 +0000)]
stop missing prototype warnings
Dr. Stephen Henson [Wed, 27 Jan 2010 13:21:34 +0000 (13:21 +0000)]
eliminate some warnings in fips build
Dr. Stephen Henson [Wed, 27 Jan 2010 00:51:24 +0000 (00:51 +0000)]
Bypass algorithm blocking with TLS MD5+SHA1 signature in FIPS mode by
calling underlying method directly.
Dr. Stephen Henson [Tue, 26 Jan 2010 19:40:36 +0000 (19:40 +0000)]
PR: 1949
Submitted by: steve@openssl.org
More robust fix and workaround for PR#1949. Don't try to work out if there
is any write pending data as this can be unreliable: always flush.
Dr. Stephen Henson [Tue, 26 Jan 2010 18:08:42 +0000 (18:08 +0000)]
PR: 2138
Submitted by: Kevin Regan <k.regan@f5.com>
Clear stat structure if -DPURIFY is set to avoid problems on some
platforms which include unitialised fields.
Dr. Stephen Henson [Tue, 26 Jan 2010 13:24:08 +0000 (13:24 +0000)]
Fix VC++ warning (change had already been made to other branches).
Dr. Stephen Henson [Tue, 26 Jan 2010 12:29:32 +0000 (12:29 +0000)]
Typo
Dr. Stephen Henson [Mon, 25 Jan 2010 16:08:52 +0000 (16:08 +0000)]
Update OID table too.
Dr. Stephen Henson [Mon, 25 Jan 2010 16:08:01 +0000 (16:08 +0000)]
PR: 2149
Submitted by: Douglas Stebila <douglas@stebila.ca>
Fix wap OIDs.
Dr. Stephen Henson [Sun, 24 Jan 2010 13:52:38 +0000 (13:52 +0000)]
oops revert test code from previous commit
Dr. Stephen Henson [Sun, 24 Jan 2010 13:50:57 +0000 (13:50 +0000)]
The fix for PR#1949 unfortunately broke cases where the BIO_CTRL_WPENDING
ctrl is incorrectly implemented (e.g. some versions of Apache). As a workaround
call both BIO_CTRL_INFO and BIO_CTRL_WPENDING if it returns zero. This should
both address the original bug and retain compatibility with the old behaviour.
Dr. Stephen Henson [Fri, 22 Jan 2010 18:49:43 +0000 (18:49 +0000)]
If legacy renegotiation is not permitted then send a fatal alert if a patched
server attempts to renegotiate with an unpatched client.
Dr. Stephen Henson [Wed, 20 Jan 2010 18:22:04 +0000 (18:22 +0000)]
change versions back to 0.9.8m-dev
Dr. Stephen Henson [Wed, 20 Jan 2010 17:26:02 +0000 (17:26 +0000)]
prepare for release
Dr. Stephen Henson [Wed, 20 Jan 2010 17:16:52 +0000 (17:16 +0000)]
update TABLE
Dr. Stephen Henson [Wed, 20 Jan 2010 16:35:30 +0000 (16:35 +0000)]
make update
Dr. Stephen Henson [Wed, 20 Jan 2010 14:04:29 +0000 (14:04 +0000)]
Support -L options in VC++ link.
Andy Polyakov [Tue, 19 Jan 2010 21:45:45 +0000 (21:45 +0000)]
rand_win.c: handel GetTickCount wrap-around [from HEAD].
Andy Polyakov [Tue, 19 Jan 2010 21:45:16 +0000 (21:45 +0000)]
x86_64-xlate.pl: refine sign extension logic when handling lea [from HEAD].
PR: 2094,2095
Dr. Stephen Henson [Tue, 19 Jan 2010 19:10:53 +0000 (19:10 +0000)]
revert patch
Dr. Stephen Henson [Tue, 19 Jan 2010 19:10:03 +0000 (19:10 +0000)]
PR: 2144
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Better fix for PR#2144
Andy Polyakov [Sun, 17 Jan 2010 19:43:49 +0000 (19:43 +0000)]
Valgrind fix to aes-x86_64.pl in 0.9.8. For reference, newer aes-x86_64.pl
don't suffer from the problem after Win64 SEH support was added.
PR: 2075
Submitted by: Peter Klotz
Dr. Stephen Henson [Sat, 16 Jan 2010 19:45:46 +0000 (19:45 +0000)]
PR: 2144
Submitted by: steve@openssl.org
Fix DTLS connection so new_session is reset if we read second client hello:
new_session is used to detect renegotiation.
Dr. Stephen Henson [Sat, 16 Jan 2010 19:18:31 +0000 (19:18 +0000)]
PR: 2133
Submitted by: steve@openssl.org
Add missing DTLS state strings.
Dr. Stephen Henson [Sat, 16 Jan 2010 19:02:43 +0000 (19:02 +0000)]
Add strings for DTLS protocol versions
Dr. Stephen Henson [Thu, 14 Jan 2010 17:44:46 +0000 (17:44 +0000)]
PR: 1618
Submitted by: steve@openssl.org
Fix bug in 0.9.8-stable time handling in ca.c . NB: this only handles cases
where times are not being checked or printed properly. Issues relating to
time_t becoming negative or wrapping around are *NOT* addressed. OpenSSL
1.0.0 and later does fix these issues by using its own time routines.
Dr. Stephen Henson [Wed, 13 Jan 2010 19:08:45 +0000 (19:08 +0000)]
Fix version handling so it can cope with a major version >3.
Although it will be many years before TLS v2.0 or later appears old versions
of servers have a habit of hanging around for a considerable time so best
if we handle this properly now.
Dr. Stephen Henson [Wed, 13 Jan 2010 18:45:03 +0000 (18:45 +0000)]
Modify compression code so it avoids using ex_data free functions. This
stops applications that call CRYPTO_free_all_ex_data() prematurely leaking
memory.
Dr. Stephen Henson [Thu, 7 Jan 2010 19:09:32 +0000 (19:09 +0000)]
Simplify RI+SCSV logic:
1. Send SCSV is not renegotiating, never empty RI.
2. Send RI if renegotiating.
Andy Polyakov [Thu, 7 Jan 2010 11:22:25 +0000 (11:22 +0000)]
x86_64-xlate.pl: new gas requires sign extention in lea instruction
[from HEAD].
PR: 2094,2095
Andy Polyakov [Thu, 7 Jan 2010 11:04:49 +0000 (11:04 +0000)]
util/pl/VC-32.pl: bufferoverflowu.lib only when actually needed [from HEAD].
PR: 2086
Dr. Stephen Henson [Wed, 6 Jan 2010 18:02:07 +0000 (18:02 +0000)]
correct error codes
Dr. Stephen Henson [Wed, 6 Jan 2010 17:59:41 +0000 (17:59 +0000)]
Updates to conform with draft-ietf-tls-renegotiation-03.txt:
1. Add provisional SCSV value.
2. Don't send SCSV and RI at same time.
3. Fatal error is SCSV received when renegotiating.
Dr. Stephen Henson [Tue, 5 Jan 2010 17:50:12 +0000 (17:50 +0000)]
Typo
Dr. Stephen Henson [Tue, 5 Jan 2010 17:33:20 +0000 (17:33 +0000)]
PR: 2132
Submitted by: steve
Fix bundled pod2man.pl to handle alternative comment formats.
Dr. Stephen Henson [Sun, 27 Dec 2009 23:03:40 +0000 (23:03 +0000)]
Update RI to match latest spec.
MCSV is now called SCSV.
Don't send SCSV if renegotiating.
Also note if RI is empty in debug messages.
Dr. Stephen Henson [Fri, 25 Dec 2009 14:11:18 +0000 (14:11 +0000)]
Traditional Yuletide commit ;-)
Add Triple DES CFB1 and CFB8 to algorithm list and NID translation.
Bodo Möller [Tue, 22 Dec 2009 11:45:57 +0000 (11:45 +0000)]
Constify crypto/cast.
Bodo Möller [Tue, 22 Dec 2009 10:59:03 +0000 (10:59 +0000)]
Constify crypto/cast.
Dr. Stephen Henson [Thu, 17 Dec 2009 16:38:18 +0000 (16:38 +0000)]
Ooops, engage ENGINE initialisation code correctly in FIPS builds.
Dr. Stephen Henson [Thu, 17 Dec 2009 15:42:25 +0000 (15:42 +0000)]
Alert to use is now defined in spec: update code
Dr. Stephen Henson [Wed, 16 Dec 2009 20:34:20 +0000 (20:34 +0000)]
New option to enable/disable connection to unpatched servers
Dr. Stephen Henson [Mon, 14 Dec 2009 01:32:47 +0000 (01:32 +0000)]
add another missed case
Dr. Stephen Henson [Mon, 14 Dec 2009 01:28:51 +0000 (01:28 +0000)]
simplify RI error code and catch extra error case ignored before
Dr. Stephen Henson [Mon, 14 Dec 2009 01:09:01 +0000 (01:09 +0000)]
Allow initial connection (but no renegoriation) to servers which don't support
RI.
Ben Laurie [Sat, 12 Dec 2009 11:10:25 +0000 (11:10 +0000)]
Missing newline.
Dr. Stephen Henson [Fri, 11 Dec 2009 00:22:12 +0000 (00:22 +0000)]
Move SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION out of SSL_OP_ALL
Dr. Stephen Henson [Wed, 9 Dec 2009 18:17:21 +0000 (18:17 +0000)]
clarify docs
Dr. Stephen Henson [Wed, 9 Dec 2009 18:01:07 +0000 (18:01 +0000)]
Document option clearning functions.
Initial secure renegotiation documentation.
Dr. Stephen Henson [Wed, 9 Dec 2009 13:41:50 +0000 (13:41 +0000)]
PR: 2124
Submitted by: Jan Pechanec <Jan.Pechanec@Sun.COM>
Check for memory allocation failures.
Dr. Stephen Henson [Wed, 9 Dec 2009 13:15:01 +0000 (13:15 +0000)]
Add ctrls to clear options and mode.
Change RI ctrl so it doesn't clash.
Dr. Stephen Henson [Tue, 8 Dec 2009 19:05:49 +0000 (19:05 +0000)]
Send no_renegotiation alert as required by spec.
Dr. Stephen Henson [Tue, 8 Dec 2009 13:47:28 +0000 (13:47 +0000)]
Add ctrl and macro so we can determine if peer support secure renegotiation.
Fix SSL_CIPHER initialiser for mcsv
Dr. Stephen Henson [Tue, 8 Dec 2009 13:15:38 +0000 (13:15 +0000)]
Add support for magic cipher suite value (MCSV). Make secure renegotiation
work in SSLv3: initial handshake has no extensions but includes MCSV, if
server indicates RI support then renegotiation handshakes include RI.
NB: current MCSV value is bogus for testing only, will be updated when we
have an official value.
Change mismatch alerts to handshake_failure as required by spec.
Also have some debugging fprintfs so we can clearly see what is going on
if OPENSSL_RI_DEBUG is set.
Dr. Stephen Henson [Wed, 2 Dec 2009 15:27:19 +0000 (15:27 +0000)]
PR: 2111
Submitted by: Martin Olsson <molsson@opera.com>
Check for bn_wexpand errors in bn_mul.c
Dr. Stephen Henson [Wed, 2 Dec 2009 14:39:12 +0000 (14:39 +0000)]
Replace the broken SPKAC certification with the correct version.
Dr. Stephen Henson [Tue, 1 Dec 2009 17:40:46 +0000 (17:40 +0000)]
PR: 2115
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Approved by: steve@openssl.org
Add Renegotiation extension to DTLS, fix DTLS ClientHello processing bug.
Dr. Stephen Henson [Tue, 1 Dec 2009 17:32:16 +0000 (17:32 +0000)]
PR: 1432
Submitted by: "Andrzej Chmielowiec" <achmielowiec@enigma.com.pl>, steve@openssl.org
Approved by: steve@openssl.org
Truncate hash if it is too large: as required by FIPS 186-3.
Dr. Stephen Henson [Sun, 29 Nov 2009 13:44:59 +0000 (13:44 +0000)]
typo
Bodo Möller [Thu, 26 Nov 2009 18:35:33 +0000 (18:35 +0000)]
(whitespace)
Bodo Möller [Thu, 26 Nov 2009 17:30:07 +0000 (17:30 +0000)]
The version numbering may change, again; so be careful about what we
announce in CHANGES.
Bodo Möller [Thu, 26 Nov 2009 17:28:27 +0000 (17:28 +0000)]
Remove attribution -- this wasn't my patch, I only edited and applied it.
Bodo Möller [Thu, 26 Nov 2009 17:25:38 +0000 (17:25 +0000)]
Remove obsolete information about a change for 0.9.7n.
(No further releases from the 0.9.7 branch are planned. Note that the
"deleted" change is also in 0.9.8f.)
Dr. Stephen Henson [Wed, 18 Nov 2009 15:08:49 +0000 (15:08 +0000)]
Servers can't end up talking SSLv2 with legacy renegotiation disabled
Dr. Stephen Henson [Wed, 18 Nov 2009 14:43:27 +0000 (14:43 +0000)]
Don't use SSLv2 compatible client hello if we don't tolerate legacy renegotiation
Dr. Stephen Henson [Wed, 18 Nov 2009 14:24:00 +0000 (14:24 +0000)]
Include a more meaningful error message when rejecting legacy renegotiation
Dr. Stephen Henson [Fri, 13 Nov 2009 14:14:46 +0000 (14:14 +0000)]
PR: 2094
Submitted by: Arkadiusz Miskiewicz <arekm@maven.pl>
Approved by: steve@openssl.org
Fix for out range of signed 32bit displacement error on newer binutils.
Dr. Stephen Henson [Fri, 13 Nov 2009 14:09:45 +0000 (14:09 +0000)]
PR: 2084
Submitted by: Mike Frysinger <vapier@gentoo.org>
Approved by: steve@openssl.org
Parallel build fix.
Dr. Stephen Henson [Fri, 13 Nov 2009 14:09:09 +0000 (14:09 +0000)]
PR: 2101
Submitted by: Doug Kaufman <dkaufman@rahul.net>
Approved by: steve@openssl.org
Fixes for tests in cms-test.pl
Richard Levitte [Thu, 12 Nov 2009 16:59:18 +0000 (16:59 +0000)]
Updated from 1.0.0-stable.
Dr. Stephen Henson [Tue, 10 Nov 2009 01:53:02 +0000 (01:53 +0000)]
PR: 1686
Submitted by: Hanno BÃ\83¶ck <hanno@hboeck.de>
Approved by: steve@openssl.org
Create engines dir if it doesn't already exist.
Dr. Stephen Henson [Tue, 10 Nov 2009 01:00:37 +0000 (01:00 +0000)]
PR: 2091
Submitted by: Martin Kaiser <lists@kaiser.cx>, Stephen Henson
Approved by: steve@openssl.org
If an OID has no short name or long name return the numerical representation.
Dr. Stephen Henson [Tue, 10 Nov 2009 00:46:57 +0000 (00:46 +0000)]
check new_der for NULL too
Dr. Stephen Henson [Tue, 10 Nov 2009 00:40:42 +0000 (00:40 +0000)]
PR: 2090
Submitted by: Martin Kaiser <lists@kaiser.cx>, Stephen Henson
Approved by: steve@openssl.org
Improve error checking in asn1_gen.c
Dr. Stephen Henson [Mon, 9 Nov 2009 18:21:57 +0000 (18:21 +0000)]
Fix wrong function codes and duplicate codes
Dr. Stephen Henson [Mon, 9 Nov 2009 14:14:26 +0000 (14:14 +0000)]
Remove BF_PTR2 from configuration: it doesn't improve performance any more and causes gcc warnings about arrays out of range
Dr. Stephen Henson [Sun, 8 Nov 2009 17:07:42 +0000 (17:07 +0000)]
use OPENSSL_assert() and not assert()
Ben Laurie [Sun, 8 Nov 2009 14:51:54 +0000 (14:51 +0000)]
First cut of renegotiation extension.
Dr. Stephen Henson [Sun, 8 Nov 2009 14:30:22 +0000 (14:30 +0000)]
Re-revert (re-insert?) temporary change that made renegotiation work again
and add a proper fix: specifically if it is a new session don't send the old
TLS ticket, send a zero length ticket to request a new session.