Jelle Hermsen [Sat, 29 Sep 2012 11:14:57 +0000 (13:14 +0200)]
Changed a couple of ifdefs for __FreeBSD__ to CSRG_BASED. These are all clearcut cases. I left the ones I had doubts about, or where I wasn't sure about the OpenBSD side of things to look at later.
David J.McBrayer [Mon, 1 Oct 2012 16:29:20 +0000 (12:29 -0400)]
-Updated README.dtlogin -Update "# Provides:" in dtlogin LSB init script
Marcin Cieslak [Wed, 3 Oct 2012 00:33:48 +0000 (02:33 +0200)]
Remove missing xmbind and uil from UDB
Remove xmbind and uil utilities we
do not build and install from the
packing lists.
Marcin Cieslak [Tue, 2 Oct 2012 16:03:41 +0000 (18:03 +0200)]
dtfile: Fix crash when trying to open filter dialog
On 64-bit machine dtfile crashes when opening
list of file types to filter in Encaps.c:
_DtShowDialog (parent=0x805c80900, map_parent=0x0, top_rec=0x805ce3600,
dialog_data=0x805db25e0, change_proc=0x4489f0 <FilterChange+16>,
change_data=0x805ce3600, close_proc=0x4489c0 <FilterClose+16>,
close_data=0x805ce3600, workspaces=0x0, iconify_state=0 '\0',
ignoreCache=0 '\0', title=0x0, classHints=0x0) at Encaps.c:531
531 ResetFlag(NULL,fr->close);
Jon Trulson [Tue, 2 Oct 2012 01:27:36 +0000 (19:27 -0600)]
linux.cf: use -fno-strict-aliasing, define DefaultGcc2i386Opt, use indenting to improve readability
Marcin Cieslak [Tue, 2 Oct 2012 00:10:35 +0000 (02:10 +0200)]
Use -O2 -fno-strict-aliasing optimization for FreeBSD
- Switching from -O to -O2 after the dthelp problem
has been resolved
- Introducing -fno-strict-aliasing (currently FreeBSD's
default) to avoid silent change of behaviour of legacy code.
http://thiemonagel.de/2010/01/no-strict-aliasing/
http://jeffreystedfast.blogspot.de/2010/01/weird-bugs-due-to-gcc-44-and-strict.html
Analysis of C99 aliasing (we are not C99 yet):
http://davmac.wordpress.com/2010/02/26/c99-revisited/
Marcin Cieslak [Tue, 2 Oct 2012 00:10:34 +0000 (02:10 +0200)]
Don't break help with gcc -O2
libDtHelp is unable to read SDL help files
with -ftree-store-ccp optimization which
is enabled by -O2 on gcc 4.2.1.
GifUtils.c and decompress.c didn't work
properly with -ftree-store-ccp enabled.
GifUtils.c was repaired by fixing
those warnings:
GifUtils.c: In function 'create_pixmap':
GifUtils.c:1093: warning: return makes integer from pointer without a cast
GifUtils.c:1110: warning: return makes integer from pointer without a cast
GifUtils.c:1215: warning: return makes integer from pointer without a cast
GifUtils.c: In function 'gif_to_pixmap':
GifUtils.c:1242: warning: return makes integer from pointer without a cast
decompress.c didn't generate warnings, but the
only effect of the -ftree-store-cpp was to introduce
this change:
addq $1, %rax
movq %rax, (%rbx)
.L90:
- cmpl $157, %edx
+ cmpl $-99, %edx
jne .L86
movl 8(%rbx), %eax
subl $1, %eax
Which corresponds to this source code:
bufioI.h
57 #define BufFileGet(f) ((f)->left-- ? *(f)->bufp++ : (*(f)->io) (f))
42 int (*io)(/* BufFilePtr f */);
decompress.c
53 #ifdef NO_UCHAR
54 typedef char char_type;
55 #else
56 typedef unsigned char char_type;
57 #endif /* UCHAR */
58
59 static char_type magic_header[] = { "\037\235" }; /* 1F 9D */
131 if ((BufFileGet(f) != (magic_header[0] & 0xFF)) ||
132 (BufFileGet(f) != (magic_header[1] & 0xFF)))
133 {
134 return 0;
135 }
BufFileGet() returns (int), so the (unsigned char) constants
got promoted to (int) with sign extension; therefore constant
157 decimal (0x9D) became -99 decimal, sign extended
(0xffffff9D), and the comparison was always false.
Tested using:
$ gcc -v
Using built-in specs.
Target: amd64-undermydesk-freebsd
Configured with: FreeBSD/amd64 system compiler
Thread model: posix
gcc version 4.2.1
20070831 patched [FreeBSD]
Running on:
FreeBSD 10.0-CURRENT (r240948M)
built Wed Sep 26 23:33:08 CEST 2012
Marcin Cieslak [Sat, 29 Sep 2012 22:16:33 +0000 (00:16 +0200)]
dtcreate: Don't crash when clicking "Find Set..."
dtcreate crashed on 64-bit system when clicking
"Find Set.." button.
Crash happens in libXm:
new_w=0x805db4300, args=0x7fffffffb430, num_args=0x7fffffffb3dc)
at Form.c:1955
$1 = {att = {{type = 4 '\004', w = 0x805db3700, percent = 0, offset = 0,
value = 0, tempValue = 0}, {type = 1 '\001', w = 0x0, percent = 0,
offset = 10, value = 0, tempValue = 0}, {type = 3 '\003',
w = 0x805db3700, percent = 0, offset = 0, value = 0, tempValue = 0}, {
type = 3 '\003', w = 0x800000000, percent = 0, offset = 10, value = 0,
tempValue = 0}}, next_sibling = 0x0, sorted = 0 '\0',
resizable = 1 '\001', preferred_width = 0, preferred_height = 0}
(...)
at icon_selection_dialog.c:1768
1767 /* Creation of icon_scrolled_win */
1768 icon_scrolled_win = XtVaCreateManagedWidget( "icon_scrolled_win",
1769 xmScrolledWindowWidgetClass,
1770 icon_selection_dialog,
1771 XmNscrollingPolicy, XmAUTOMATIC,
1772 /* XmNnavigationType, XmTAB_GROUP, */
1773 XmNx, 282,
1774 XmNy, 84,
1775 XmNscrollBarDisplayPolicy, XmAS_NEEDED,
1776 XmNrightOffset, 10,
1777 XmNrightAttachment, XmATTACH_FORM,
1778 XmNtopOffset, 0,
1779 XmNtopWidget, icon_container_label,
1780 XmNtopAttachment, XmATTACH_WIDGET,
1781 XmNleftOffset, 0,
1782 XmNleftWidget, icon_container_label,
1783 XmNleftAttachment, XmATTACH_OPPOSITE_WIDGET,
1784 XmNbottomOffset, 10,
1785 XmNbottomWidget, XmATTACH_NONE,
1786 XmNbottomAttachment, XmATTACH_WIDGET,
1787 NULL );
What happens here is that ConstraintInitialize receives
four constraints, the last one is this:
{ type = 3 '\003', /* XmATTACH_WIDGET */
w = 0x800000000, /* malformed XmATTACH_NONE ???
percent = 0,
offset = 10, /* specified as XmNbottomOffset */
value = 0,
tempValue = 0}
XmATTACH_* values are defined in <Xm/Xm.h> as follows:
505 enum{ XmATTACH_NONE, XmATTACH_FORM,
506 XmATTACH_OPPOSITE_FORM, XmATTACH_WIDGET,
507 XmATTACH_OPPOSITE_WIDGET, XmATTACH_POSITION,
508 XmATTACH_SELF
509 } ;
What is not clear to why XmATTACH_NONE - which should be (int)0 -
becomes 0x800000000 - looks like a 64 bit bug somewhere.
Providing a long value on None (0L) as in this change fixes the
problem.
I understand is that it possible to use such an "empty" widget
is to create additional space at the bottom of the newly created
"icon_scrolled_win".
What needs to be clarified - shouldn't be such an (int) value be
automatically promoted to (long) (or XtArgVal, XtPointer, ...)
and preserve the value 0? Lots of parameters seem to be
passed as ints (for example dimensions) and they do not
appear to cause any trouble.
Jon Trulson [Sun, 30 Sep 2012 02:46:27 +0000 (20:46 -0600)]
XmPrivate.h: never try to build this automatically.
XmPrivate must be generated manually. For this you work, you must
have a freshly compiled openmotif tree, and MLIBSRC must be pointing
to it.
Otherwise, it's possible during the includes phase for an attempt to
be made to regenerate this file, which will fail on the vast majority
of systems out there.
So, to regenerate,
cd include/Xm
rm XmPrivate.h
make XmPrivate.h
Marcin Cieslak [Sat, 29 Sep 2012 22:16:31 +0000 (00:16 +0200)]
dtcreate: Add missing prototypes and more (64-bit)
- Fix missing prototypes
- Fix some 64-bit related problems (XtVaGetValues)
- Fix crash on dtcreate startup in create_applicationShell1()
- Add XmeFlushIconFileCache() prototype from <Xm/IconFileP.h>
Marcin Cieslak [Sat, 29 Sep 2012 20:23:33 +0000 (22:23 +0200)]
XmPrivate.h: Avoid whitespace problems (IMPROVED)
When applying a patch, "git am" strips
trailing whitespace, although they are
present in the git formatted-patch.
This way the committed file will be
slightly different than the file re-generated
by extractprototype.h
It shouldn't hurt, but next run of
extractprototype.h will add trailing spaces
again and the resulting diff on XmPrivate.h
will include more changes than actually
needed.
This may break some viscious circle after
applying the patch, so enabling regeneration
on LinuxArchitecture again.
This patch does not add XmeFlushIconFileCache()
needed by dtcreate.
Frederic Koehler [Fri, 28 Sep 2012 18:22:27 +0000 (14:22 -0400)]
dtcreate: Avoid trying to reuse closed help window
This fixes a segfault when trying to go to help a second
time, after closing the first window.
Frederic Koehler [Fri, 28 Sep 2012 18:21:12 +0000 (14:21 -0400)]
dthelp: Avoid undefined behaviour in strcpy
Technically strcpy's ranges cannot overlap at all,
although in practice this is usually not an issue.
Does quiet a valgrind warning, however.
Marcin Cieslak [Fri, 28 Sep 2012 14:38:08 +0000 (16:38 +0200)]
dtfile: fix crash in RecheckFlag (64bit)
Jelle Hermsen [Thu, 27 Sep 2012 01:03:27 +0000 (03:03 +0200)]
Teach ToolTalk config about NetBSD and adds HAS_STATVFS identifier which is consequently used in tt_file_system.C, because NetBSD switched to the POSIX/XOpen statvfs() calls in 2004.
James Woodcock [Thu, 6 Sep 2012 19:47:11 +0000 (20:47 +0100)]
Use the system strcasestr() on Linux.
James Woodcock [Thu, 6 Sep 2012 19:24:13 +0000 (20:24 +0100)]
Older Linux installations do not have svcfd_create().
svcfd_create() is only called if OPT_UNIX_SOCKET_RPC is defined, so a #ifdef
round that code should be OK.
James Woodcock [Thu, 6 Sep 2012 19:22:36 +0000 (20:22 +0100)]
Use RPC_ANYSOCK instead of the magic number -1.
James Woodcock [Fri, 10 Aug 2012 10:42:16 +0000 (11:42 +0100)]
Remove unnecessary extern modifier from struct declaration.
Marcin Cieslak [Thu, 27 Sep 2012 08:32:50 +0000 (10:32 +0200)]
Use typedef XDR from <rpc/xdr.h>
__rpc_xdr is no longer available on FreeBSD 10.
(XDR is typedef'd as "struct XDR" and not "struct __rpc_xdr").
By the way, why did we ever need this? Probably
it should be removed. Leaving for __OpenBSD__ for now.
Marcin Cieslak [Thu, 27 Sep 2012 08:27:43 +0000 (10:27 +0200)]
dticon: fix typo in the last commit
Marcin Cieslak [Wed, 26 Sep 2012 10:29:40 +0000 (12:29 +0200)]
Update vendor logo for FreeBSD
- Improved font rendering and anti-aliasing
by hand
- Let dticon recognize .bm file as X bitmap
Marcin Cieslak [Wed, 26 Sep 2012 10:14:53 +0000 (12:14 +0200)]
dticon: make XVaGetValues() call 64-bit compliant
Marcin Cieslak [Wed, 26 Sep 2012 10:14:52 +0000 (12:14 +0200)]
dtstyle: XVaGetValues() calls
Pascal Stumpf [Mon, 24 Sep 2012 19:50:19 +0000 (21:50 +0200)]
Add csu objects to shared libraries on OpenBSD.
This is required by recent changes to the stack protector code in gcc,
generating references to __guard_local instead of __guard, defined in
crtbeginS.o.
This is a temporary solution; strictly speaking, we shouldn't invoke ld
directly at all but use cc instead.
Marcin Cieslak [Tue, 25 Sep 2012 13:12:13 +0000 (15:12 +0200)]
Dtlogin logo for FreeBSD
Install black and white and 128-color custom logos for FreeBSD.
The FreeBSD logo based on the artwork provided by The FreeBSD Foundation:
http://www.freebsd.org/logo/logo-basic.png
The mark FreeBSD is a registered trademark of The FreeBSD Foundation
is are used by Common Desktop Enviroment (CDE) with
the permission of The FreeBSD Foundation.
The FreeBSD Logo is a trademark of The FreeBSD Foundation and is used
by Common Desktop Environment (CDE) with the permission of
The FreeBSD Foundation.
Use of logo subject to Trademark Usage Terms and Conditions:
http://www.freebsdfoundation.org/documents/Guidelines.shtml
Marcin Cieslak [Tue, 25 Sep 2012 14:50:23 +0000 (16:50 +0200)]
Don't make /var group writable
* Use 0755 permissions for /var (not 0775)
- this makes sendmail unhappy
* Don't change permissions on /var on dtlogin startup
Marcin Cieslak [Tue, 25 Sep 2012 13:41:18 +0000 (15:41 +0200)]
Install /usr/local/libdata/ldconfig/cde for FreeBSD
I mean really this time. Please.
Anthony Perkins [Tue, 25 Sep 2012 13:32:40 +0000 (13:32 +0000)]
Corrected font aliases for "-b&h-lucidasans" on FreeBSD.
The following patch gets the Lucida Sans font working on my FreeBSD system. Before applying this, title bars and menu bars are displayed in the "-misc-fixed" font. This is on FreeBSD 9.0-RELEASE-p3.
Marcin Cieslak [Tue, 25 Sep 2012 00:59:06 +0000 (00:59 +0000)]
FreeBSD: Add /usr/dt/lib to runtime linker - update
On Mon, 24 Sep 2012, Jon Trulson wrote:
> On Tue, 25 Sep 2012, Marcin Cieslak wrote:
>
> Applied.
I'm sorry - it turns out this one does not fully
work as expected.
This one is better (it's relative to the old master)
- so it might cause a conflict:
Jon Trulson [Tue, 25 Sep 2012 01:20:56 +0000 (19:20 -0600)]
Revert "FreeBSD: Add /usr/dt/lib to runtime linker"
This reverts commit
91f228411ea3017dd445aa3834c29fe970cfd94f.
Updated patch.
Marcin Cieslak [Mon, 24 Sep 2012 23:52:12 +0000 (01:52 +0200)]
2 warnings fixed (64-bit)
Fix XtVaGetValues() output for 64-bit
Fix filename comparison in Dts.c
Marcin Cieslak [Mon, 24 Sep 2012 23:48:27 +0000 (01:48 +0200)]
FreeBSD: Add /usr/dt/lib to runtime linker
Create $LOCALBASE/libdata/ldconfig/cde
which points the runtime linker to /usr/dt/lib
There is no need to invoke ldconfig manually
after this.
Marcin Cieslak [Mon, 24 Sep 2012 16:11:36 +0000 (18:11 +0200)]
dtpdm: XtVaGetValues, XtPointer, XtArgVal, ...
Make XtVaGetValues return variables safe for 64-bit
Marcin Cieslak [Mon, 24 Sep 2012 15:52:58 +0000 (17:52 +0200)]
157 warnings: remove -DXK_MISCELLANY from Makefiles
Fixes the following warning:
In file included from ../../../imports/x11/include/X11/Xutil.h:54,
from ../../../imports/x11/include/X11/Intrinsic.h:54,
from Action.c:64:
../../../imports/x11/include/X11/keysym.h:49:1: warning: "XK_MISCELLANY" redefined
<command-line>: warning: this is the location of the previous definition
<keysym.h> which includes all key symbols and loads <keysymdef.h>
is automaticlly included by the X Toolkit.
This patch removes #include <keysymdef.h> whenever not needed,
and adds #define XK_MISCALLANY in the source code where required.
Marcin Cieslak [Mon, 24 Sep 2012 11:36:17 +0000 (13:36 +0200)]
dtmail: fix warning: comparison is always false
This warning was caused by a typo:
warning: comparison is always false due to limited range of data type
Marcin Cieslak [Mon, 24 Sep 2012 11:36:16 +0000 (13:36 +0200)]
dtmail: fix warning: NULL used in arithmetic
NULL != NULL makes no sense, really...
Marcin Cieslak [Mon, 24 Sep 2012 11:36:15 +0000 (13:36 +0200)]
dtmail: warning: 'DtMailBoolean' is promoted to (int)
Fix this warning:
RFCTransport.C: In function 'long unsigned int writeToFileDesc(const char*, int,
__va_list_tag*)':
RFCTransport.C:91: warning: 'DtMailBoolean' is promoted to 'int' when passed thr
ough '...'
RFCTransport.C:91: warning: (so you should pass 'int' not 'DtMailBoolean' to 'va
_arg')
RFCTransport.C:91: note: if this code is reached, the program will abort
Marcin Cieslak [Mon, 24 Sep 2012 11:36:14 +0000 (13:36 +0200)]
dtmail: Fix XtVaGetValues() return value storage
At least one crash was caused by this
on the 64-bit system
Marcin Cieslak [Mon, 24 Sep 2012 11:36:13 +0000 (13:36 +0200)]
Get rid of unpleasant cast, it causes SIGSEGV
Having a difficult choice between unplasant
cast to get a void * into an enumeration type
and "Something's wrong here" double cast
I decided for the latter.
At least it does not crash when the legal
value of zero is passed as the argument.
Marcin Cieslak [Mon, 24 Sep 2012 01:15:21 +0000 (03:15 +0200)]
dtpad: kill one warning
Marcin Cieslak [Mon, 24 Sep 2012 01:15:20 +0000 (03:15 +0200)]
dtpad: Use XtArgVal for int conversion
Avoid overwrite of local variables when using
short (int, etc.) types with XtVaGetValues().
Cast XtPointer using (XtArgVal) without
the need to use C99 <stdint.h> and friends.
Marcin Cieslak [Mon, 24 Sep 2012 01:15:19 +0000 (03:15 +0200)]
dtpad: Fix 64-bit crash on file open/save
Fix SIGSEGV because of implicit declaration
of _XmStringUngenerate.
The error message reported to the user was:
TT_ERR_PROCID The process id passed is not valid.
Marcin Cieslak [Mon, 24 Sep 2012 01:15:18 +0000 (03:15 +0200)]
BSD: Remove libXX.so symlink before installing
Now we can run "make" in "lib/tt" again
and the symlink will be recreated.
Marcin Cieslak [Mon, 24 Sep 2012 01:15:04 +0000 (03:15 +0200)]
dtprintinfo: sym2num needs ksh
Marcin Cieslak [Mon, 24 Sep 2012 01:15:03 +0000 (03:15 +0200)]
dtprintinfo: Use 64-bit values for XtVaGetValues() pointers
XtArgVal should be a type that encompasses XtPointer
and long integer types. In the X.org implementation
it is currently defined as (long).
Don't use (unsigned int *) instead of (Window *).
Marcin Cieslak [Mon, 24 Sep 2012 01:15:02 +0000 (03:15 +0200)]
dtprintinfo: Use CUPS lpq for FreeBSD
Use /usr/local/bin/lpq from CUPS for FreeBSD
for now; this prevents immediate dtprintinfo
crash.
In the future we should handle both built-in
/usr/bin/lpq as well as CUPS /usr/local/bin/lpq
output in separate functions.
Code to support CUPS should probably shared between
other operating systems.
Marcin Cieslak [Mon, 24 Sep 2012 01:15:01 +0000 (03:15 +0200)]
Fix logic in dtprintinfo
Fix values for true/false and boolean type
Marcin Cieslak [Mon, 24 Sep 2012 01:14:34 +0000 (03:14 +0200)]
dtfile: fix pointer to integer conversion
Use XtArgVal (usually (long)) to convert
(XtPointer) to (int) and back.
This provides safe way to convert and
avoids compiler warning.
Jon Trulson [Mon, 24 Sep 2012 01:32:17 +0000 (19:32 -0600)]
contrib/xinetd: xinetd file for cmsd and ttsdbserver
mailling list post from: Ecmel Ercan <ecmel.ercan@gmail.com>
Marcin Cieslak [Fri, 21 Sep 2012 20:44:28 +0000 (22:44 +0200)]
dttypes should not crash on 64-bit system
Casting (int) to (char **) will not
prevent crash on a 64-bit system.
A proper ANSI prototype has been added.
Marcin Cieslak [Sat, 22 Sep 2012 10:05:57 +0000 (12:05 +0200)]
Fix dtfile crash on 64 bit
When asking for data using XtVaGetValue()
make sure that there is enough place for
the return value (which is sometimes XtPointer).
Providing pointer to (int) is not enough.
Cast XtPointer into requested int types
directly, which unfortunately introduces
compilation warning:
cast from pointer to integer of different size
Jon Trulson [Tue, 18 Sep 2012 16:14:33 +0000 (10:14 -0600)]
Xm/Imakefile: never try to regen XmPrivate.h on linux systems. It will always fail.
Jon Trulson [Tue, 18 Sep 2012 16:07:11 +0000 (10:07 -0600)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Marcin Cieslak [Tue, 18 Sep 2012 02:02:28 +0000 (04:02 +0200)]
dtfile: Add missing prototypes
Add missing prototypes and header files to the dtfile
code in order to move closer towards 64-bit compatibility.
Extract the following functions from Motif internal headers:
_XmGetWidgetExtData
_XmRecordEvent
_XmStringUngenerate
_XmTextFieldSetDestination
_XmGetActiveTopLevelMenu
Extract manually prototypes of the obsolete Motif interface:
_XmHighlightBorder
_XmUnhighlightBorder
Remove XmPrivate.h if extractprototype.awk fails
Make the following header files available via -I:
codelibs/boolean.h
codelibs/pathutils.h
codelibs/shellutils.h
and remove shellutils.h from dtwm directory.
Peter Howkins [Tue, 18 Sep 2012 11:00:05 +0000 (12:00 +0100)]
dtudcexch/dtudcfonted: Resolve 78 compiler warnings.
Peter Howkins [Tue, 18 Sep 2012 10:59:42 +0000 (11:59 +0100)]
Merge branch 'master' of ssh://localhost:3333/p/cdesktopenv/code
Jon Trulson [Tue, 18 Sep 2012 00:26:14 +0000 (18:26 -0600)]
CDE-MAN.udb: add /usr/dt/man symlink for linux, like freebsd
Jon Trulson [Tue, 18 Sep 2012 00:23:31 +0000 (18:23 -0600)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Marcin Cieslak [Mon, 17 Sep 2012 10:45:40 +0000 (12:45 +0200)]
Improve MANPATH control
* Revert changes to programs/dtsearchpath/libCliSrv/UnixEnv.C
introduced by
c3cb5b8aa6997138dfa06da39142bf793baeae60
that could have produced disappearing Application Manager
icons on FreeBSD
* Introduce SearchPath:useSystemPath() virtual method to tell
dtsearchpath to leave some environment variables alone.
It is currently overriden for FreeBSD only if the MANPATH
is empty (system default). Other operating systems
might want to override it if they prefer to have distribution
specific control of a search path in effect.
* Symlink /usr/dt/share/man to /usr/dt/man for FreeBSD
This allows dtsearchpath to actually include /usr/dt/man
in the MANPATH when MANPATH override is in effect.
Peter Howkins [Mon, 17 Sep 2012 15:28:55 +0000 (16:28 +0100)]
dtterm: Resolve 4 compiler warnings
Peter Howkins [Mon, 17 Sep 2012 13:56:06 +0000 (14:56 +0100)]
dtstyle: Resolve 28 compiler warnings.
Marcin Cieslak [Mon, 10 Sep 2012 02:38:04 +0000 (04:38 +0200)]
BSD: Add /usr/local/bin to the default PATH on login
Marcin Cieslak [Mon, 10 Sep 2012 02:21:16 +0000 (04:21 +0200)]
FreeBSD: Don't set MANPATH, use OS configuration
- make installer to set up man(1) paths using /usr/local/etc/man.d/*
- don't override empty/unset MANPATH with compiled in default
Mike Stroyan [Sun, 9 Sep 2012 21:44:45 +0000 (15:44 -0600)]
Don't use fstat for readable pipe chars in dtexec.
The dtexec code assumes that fstat reports pipe's readable chars.
Linux always reports 0 for st_size of a pipe.
Instead read one character when select reports readable.
Note EOF when select says readable but read returns 0.
Marcin Cieslak [Fri, 7 Sep 2012 21:04:44 +0000 (23:04 +0200)]
FreeBSD: Fix dtlogin failsafe session
We need to have /usr/local as the proper
X11 prefix to start mwm and xterm
Jon Trulson [Thu, 6 Sep 2012 19:33:58 +0000 (13:33 -0600)]
add HISTORY file
Jon Trulson [Thu, 6 Sep 2012 18:36:14 +0000 (12:36 -0600)]
dtlogin: enable building on FreeBSD
Jon Trulson [Thu, 6 Sep 2012 18:12:15 +0000 (12:12 -0600)]
Update README file
Marcin Cieslak [Thu, 6 Sep 2012 11:45:11 +0000 (13:45 +0200)]
Allow building on FreeBSD
- build shared libraries with major number only (libtt.so.2)
- don't build dtlogin and dtinfo
FreeBSD support for the installer:
- work around awk issue
- create post_install FreeBSD scripts
- install only cmsd on /etc/inetd.conf
skip dtspc and ttdbserver for now
Note to users: please check
if you are affected by awk bug
in udbParseLib.awk if you can.
Jon Trulson [Thu, 6 Sep 2012 01:38:24 +0000 (19:38 -0600)]
Update CONTRIBUTORS file.
Ulrich Wilkens [Wed, 5 Sep 2012 14:49:35 +0000 (16:49 +0200)]
Fix for __va_copy on FreeBSD i386.
Ulrich Wilkens [Wed, 5 Sep 2012 14:26:28 +0000 (16:26 +0200)]
Fixes for dtlogin and dtcm on FreeBSD.
Jon Trulson [Tue, 4 Sep 2012 01:50:10 +0000 (19:50 -0600)]
linux.cf: add libtirpc support. Disabled by default.
Currently on Linux, you must run rpcbind in insecure mode (-i) in
order for ttsession to register with rpcbind (the portmapper). This
is because, on most systems, libc contains an older sun-based rpc
library embedded within it. The sun-rpc code does not know how to
authenticate with rpcbind when run as a non-privileged user.
Using libtirpc, ttsession can register with rpcbind without requiring
it to be run in insecure mode. You must have the libtirpc-dev, or
equivalent package installed to use it.
If you want to try this:
- install libtirpc-dev or equivalent
- if your rpcbind process is already running in insecure mode (-i
option), remove that option and restart it.
- edit config/host.def, (create if it doesn't exist) and add:
#define HasTIRPCLib YES
- rebuild CDE (make World). It's probably a good idea to remove
/usr/dt/* beforehand to avoid contamination.
Some linux systems seem to incorporate tirpc directly into libc (as
all of the BSD's do AFAIK) so this may not be needed.
I know that at least on Ubuntu systems defining HasTIRPCLib to YES is
required in order to run rpcbind without -i.
Jon Trulson [Mon, 3 Sep 2012 21:12:57 +0000 (15:12 -0600)]
message catalogs: fix comment lines, also remove linux hack in merge.c
According to the spec, blank lines in message catalogs or lines
beginning with '$ ' are valid comments.
However, there were many cases where lines in the message catalogs
contained just a single '$', without the required space after it.
Under linux, this caused 126766 error lines (in my builds) of the
form:
... unknown directive `': line ignored
This also causes gencat to exit with a non-0 exit code. Even though
gencat says it ignores the line, it really doesn't.
An early porting change to programs/localized/util/merge.c was made to
ignore this return value on linux. This hack has now been removed.
Build logs are a lot smaller and cleaner now.
Peter Howkins [Sat, 1 Sep 2012 20:35:10 +0000 (21:35 +0100)]
libDtSvc: Resolve 89 compiler warnings.
Peter Howkins [Sat, 1 Sep 2012 19:54:23 +0000 (20:54 +0100)]
libDtSearch: Resolve 26 compiler warnings.
Peter Howkins [Sat, 1 Sep 2012 19:37:02 +0000 (20:37 +0100)]
dtpdmd: Resolving warnings.
Peter Howkins [Sat, 1 Sep 2012 17:30:13 +0000 (18:30 +0100)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Jon Trulson [Sat, 1 Sep 2012 01:57:29 +0000 (19:57 -0600)]
installCDE: remove \c from installing... Log lines
Jon Trulson [Fri, 31 Aug 2012 22:31:26 +0000 (16:31 -0600)]
linux.cf: add some gcc system include paths to makedepend. Shaves about 5150 more warnings off (makedepend) :)
This is on ubuntu. You may wany to add additional -I... entries for
other linux systems, if the ones I added for i386 and x86_64 don't
help.
Peter Howkins [Fri, 31 Aug 2012 20:41:32 +0000 (21:41 +0100)]
dtpdm: Resolve 4 compiler warnings
Peter Howkins [Fri, 31 Aug 2012 18:07:47 +0000 (19:07 +0100)]
build: linux.cf, remove the space in the -isystem include of the X11 headers
this was causing build failures on the make depend step.
Peter Howkins [Fri, 31 Aug 2012 17:35:20 +0000 (18:35 +0100)]
build: on linux include the X11 and Xm headers with -isystem rather than -I,
this means the compiler treats them as system headers and does not give you
excessive warnings from them. This is used because X11 does not like the
-ansi and -pedantic warnings that CDE is compiled with.
Jon Trulson [Fri, 31 Aug 2012 02:23:33 +0000 (20:23 -0600)]
include: remove includes:: XmPrivate.h from includes Imakefile
Having this dependancy in here is a problem. Depending on how the src
is packaged, or, unpacked, an attempt could be made to regenerate this
file, which cannot succeed unless imports/motif is setup to point to a
compiled motif tree.
This file can be manually regenerated by removing XmPrivate.h, and then
doing a 'make XmPrivate.h' in the include/Xm dir.
Jon Trulson [Fri, 31 Aug 2012 02:22:04 +0000 (20:22 -0600)]
dthelp: fix build failure introduced by commit
71f8af6943b9f0ea6d290c1497bf1b3a78be18c0
Tsk Tsk Peter :)
Jon Trulson [Fri, 31 Aug 2012 02:19:23 +0000 (20:19 -0600)]
Marcin Cieslak [Thu, 30 Aug 2012 23:17:48 +0000 (01:17 +0200)]
DtWidget: Improve portability of Motif interface
- Add missing includes and prototypes
- Improve type compatibility
- Use <Xm/XmPrivate.h> for unofficial libXm headers
With this patch, dtpad no longer crashes on startup
on FreeBSD/amd64 because of a truncated 64-bit pointer.
Marcin Cieslak [Thu, 30 Aug 2012 23:17:47 +0000 (01:17 +0200)]
Fix warnings in dtwm
- Improve pointer/int compatibility
- Include unpublished Dt headers in Dt
- Use <Xm/XmPrivate.h> for unpublished Motif functions
There are still warnings left generated because
ElementValue.parsed_value should really be a union.
There are also some warnings left because of XtPointer
casting and some unused variables and functions.
Marcin Cieslak [Thu, 30 Aug 2012 23:17:46 +0000 (01:17 +0200)]
Introduce <Xm/XmPrivate.h>
We need ANSI C prototypes of certain Motif
functions that are not published in the official
header files.
<Xm/XmPrivate.h> header file contains
the prototypes extracted from the Motif source.
To re-create <Xm/XmPrivate.h>:
1) Make sure you have sources of libXm
(lib/Xm directory of the Motif distribution)
accessible via imports/motif/lib/Xm
2) rm include/Xm/XmPrivate.h
3) make includes
Peter Howkins [Thu, 30 Aug 2012 21:40:55 +0000 (22:40 +0100)]
dtpad: Resolve 6 compiler warnings.
Peter Howkins [Thu, 30 Aug 2012 21:30:36 +0000 (22:30 +0100)]
dtlogin: Resolve 7 compiler warnings.
Peter Howkins [Thu, 30 Aug 2012 21:19:49 +0000 (22:19 +0100)]
dtlogin: Resolve all -Wformat-security warnings
Peter Howkins [Thu, 30 Aug 2012 21:15:13 +0000 (22:15 +0100)]
dtimsstart: Resolve 3 compiler warnings.
Peter Howkins [Thu, 30 Aug 2012 20:38:11 +0000 (21:38 +0100)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Peter Howkins [Thu, 30 Aug 2012 20:37:25 +0000 (21:37 +0100)]
dthelp: Resolve 106 compiler warnings.
Marcin Cieslak [Thu, 30 Aug 2012 20:27:15 +0000 (22:27 +0200)]
Define AMD64Architecture for FreeBSD
Marcin Cieslak [Thu, 30 Aug 2012 19:57:07 +0000 (21:57 +0200)]
Rudimentary LSBBitOrder for FreeBSD
Jon Trulson [Thu, 30 Aug 2012 19:53:37 +0000 (13:53 -0600)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Peter Howkins [Thu, 30 Aug 2012 18:57:56 +0000 (19:57 +0100)]
dthello: Resolve 5 compiler warnings.