oweals/busybox.git
16 years agodhcp: heed TODO item - divorced options from their string descriptions
Denis Vlasenko [Thu, 29 Nov 2007 08:17:45 +0000 (08:17 -0000)]
dhcp: heed TODO item - divorced options from their string descriptions
code shrink while at it.

function                                             old     new   delta
dhcp_option_strings                                    -     258    +258
udhcp_run_script                                    1135    1174     +39
dhcp_option_lengths                                    -      11     +11
udhcp_add_simple_option                               93      92      -1
packet_num                                             4       -      -4
read_opt                                             746     739      -7
udhcp_option_lengths                                  11       -     -11
udhcpc_main                                         2590    2494     -96
dhcp_options                                         490      70    -420
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 1/4 up/down: 308/-539)         Total: -231 bytes
   text    data     bss     dec     hex filename
 775309     929    9100  785338   bfbba busybox_old
 775098     929    9084  785111   bfad7 busybox_unstripped

16 years agosysctl: add -e: supress warnings about invalid key (Jeremy Kerr <jk@ozlabs.org>)
Denis Vlasenko [Thu, 29 Nov 2007 06:40:28 +0000 (06:40 -0000)]
sysctl: add -e: supress warnings about invalid key (Jeremy Kerr <jk@ozlabs.org>)
code shrink:

   text    data     bss     dec     hex filename
 775565     929    9100  785594   bfcba busybox_old
 775296     929    9100  785325   bfbad busybox_unstripped

16 years agoFurther optimize applet tables; prettify build output
Denis Vlasenko [Thu, 29 Nov 2007 03:31:20 +0000 (03:31 -0000)]
Further optimize applet tables; prettify build output

   text    data     bss     dec     hex filename
 775923     929    9100  785952   bfe20 busybox_old
 775565     929    9100  785594   bfcba busybox_unstripped

16 years agotouch: accept and ignore -f
Denis Vlasenko [Wed, 28 Nov 2007 19:25:32 +0000 (19:25 -0000)]
touch: accept and ignore -f

16 years agodhcpc: let server know we don't like oversized packets.
Denis Vlasenko [Wed, 28 Nov 2007 19:23:12 +0000 (19:23 -0000)]
dhcpc: let server know we don't like oversized packets.
add TODO comment

16 years agoforgotten part of previous commit
Denis Vlasenko [Wed, 28 Nov 2007 06:49:42 +0000 (06:49 -0000)]
forgotten part of previous commit

16 years agoreorganize applet table. Eliminates pointers to names.
Denis Vlasenko [Wed, 28 Nov 2007 06:49:03 +0000 (06:49 -0000)]
reorganize applet table. Eliminates pointers to names.
Should be a big win for libbusybox. busybox wins too:

   text    data     bss     dec     hex filename
 776524     929    9100  786553   c0079 busybox_old
 775903     929    9100  785932   bfe0c busybox_unstripped

16 years agoip route: add comment, no code changes
Denis Vlasenko [Tue, 27 Nov 2007 09:42:33 +0000 (09:42 -0000)]
ip route: add comment, no code changes

16 years agoiproute: fix a bug where "ip r flush table main" was rejected,
Denis Vlasenko [Mon, 26 Nov 2007 18:29:52 +0000 (18:29 -0000)]
iproute: fix a bug where "ip r flush table main" was rejected,
add "ip r flush cache" (however I'm unsure it is really valid syntax)
Add a few comments and stop mixing params and params' keywords.

16 years agofix vda's testsuite bogons, part 2
Denis Vlasenko [Mon, 26 Nov 2007 07:23:27 +0000 (07:23 -0000)]
fix vda's testsuite bogons, part 2

16 years agofix vda's testsuite bogons, part 1
Denis Vlasenko [Mon, 26 Nov 2007 07:23:09 +0000 (07:23 -0000)]
fix vda's testsuite bogons, part 1

16 years agotestsuite: add tests for cut and grep;
Denis Vlasenko [Mon, 26 Nov 2007 05:38:20 +0000 (05:38 -0000)]
testsuite: add tests for cut and grep;
slight improvements to infrastructure

16 years agoash: make code simpler, and do not do close(-1) - it's rude
Denis Vlasenko [Mon, 26 Nov 2007 05:37:07 +0000 (05:37 -0000)]
ash: make code simpler, and do not do close(-1) - it's rude

16 years agozcip: simplify code a bit
Denis Vlasenko [Sun, 25 Nov 2007 12:53:25 +0000 (12:53 -0000)]
zcip: simplify code a bit

16 years agozcip: use low-order 4 bytes of MAC as random seed, not 4 high-order
Denis Vlasenko [Sun, 25 Nov 2007 12:40:56 +0000 (12:40 -0000)]
zcip: use low-order 4 bytes of MAC as random seed, not 4 high-order
arping: fix wrong roundtrip calculation
arping,zcip: cleanups and code shrink

run                                                  389     402     +13
arp                                                  195     188      -7
zcip_main                                           1524    1495     -29
arping_main                                         1874    1823     -51
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/3 up/down: 13/-87)            Total: -74 bytes
   text    data     bss     dec     hex filename
 776587     929    9100  786616   c00b8 busybox_old
 776499     929    9100  786528   c0060 busybox_unstripped

16 years agocttyhack should be in /bin, not /usr/bin
Denis Vlasenko [Sun, 25 Nov 2007 07:58:42 +0000 (07:58 -0000)]
cttyhack should be in /bin, not /usr/bin

16 years agowhich: fix testsuite failure
Denis Vlasenko [Sun, 25 Nov 2007 04:54:13 +0000 (04:54 -0000)]
which: fix testsuite failure
pidof: do not output empty line if nothing found
testsuite: disable false positive

16 years agodhcpc: cope with buggy DHCP servers which send oversized packets
Denis Vlasenko [Sun, 25 Nov 2007 03:15:24 +0000 (03:15 -0000)]
dhcpc: cope with buggy DHCP servers which send oversized packets
(Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn@axis.com>)

17 years agoAnnounce 1.8.2 and 1.7.4
Denis Vlasenko [Sat, 24 Nov 2007 04:49:07 +0000 (04:49 -0000)]
Announce 1.8.2 and 1.7.4

17 years agostty: reorganize data tables - save 0.5k
Denis Vlasenko [Sat, 24 Nov 2007 04:32:49 +0000 (04:32 -0000)]
stty: reorganize data tables - save 0.5k

function                                             old     new   delta
mode_name                                              -     496    +496
control_name                                           -      91     +91
stty_main                                           1235    1255     +20
find_mode                                             45      63     +18
find_control                                          45      63     +18
do_display                                           482     493     +11
wrapf                                                165     166      +1
set_mode                                             761     759      -2
max_col                                                4       -      -4
device_name                                            4       -      -4
control_info                                         153      34    -119
mode_info                                           1700     680   -1020
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 5/3 up/down: 655/-1149)        Total: -494 bytes
   text    data     bss     dec     hex filename
 777037     937    9100  787074   c0282 busybox_old
 776551     929    9100  786580   c0094 busybox_unstripped

17 years agoremove echo_main -> bb_echo indirection
Denis Vlasenko [Sat, 24 Nov 2007 02:23:51 +0000 (02:23 -0000)]
remove echo_main -> bb_echo indirection

17 years agohush: fix segfault in "echo $@" when we have no arguments
Denis Vlasenko [Sat, 24 Nov 2007 00:22:42 +0000 (00:22 -0000)]
hush: fix segfault in "echo $@" when we have no arguments

17 years agofix buglets found by randomconfig
Denis Vlasenko [Fri, 23 Nov 2007 23:39:01 +0000 (23:39 -0000)]
fix buglets found by randomconfig

17 years agoupdate defconfig
Denis Vlasenko [Fri, 23 Nov 2007 23:37:19 +0000 (23:37 -0000)]
update defconfig

17 years agokill lash. "lash" builtin still exists, but it runs hush.
Denis Vlasenko [Fri, 23 Nov 2007 23:28:55 +0000 (23:28 -0000)]
kill lash. "lash" builtin still exists, but it runs hush.

17 years agoAdd an RFC for future ipv6 ftp work
Denis Vlasenko [Fri, 23 Nov 2007 21:43:40 +0000 (21:43 -0000)]
Add an RFC for future ipv6 ftp work

17 years agohush: implement echo builtin
Denis Vlasenko [Fri, 23 Nov 2007 21:20:21 +0000 (21:20 -0000)]
hush: implement echo builtin

builtin_echo                                           -      36     +36
bltins                                               384     396     +12
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 1/0 up/down: 48/0)               Total: 48 bytes

17 years agohush: fix $ expansion in redirections, add testcase for that
Denis Vlasenko [Fri, 23 Nov 2007 21:08:38 +0000 (21:08 -0000)]
hush: fix $ expansion in redirections, add testcase for that

17 years agohush: implement test builtin
Denis Vlasenko [Fri, 23 Nov 2007 13:11:42 +0000 (13:11 -0000)]
hush: implement test builtin

17 years agohush: plug memory leak
Denis Vlasenko [Fri, 23 Nov 2007 12:50:54 +0000 (12:50 -0000)]
hush: plug memory leak

17 years agoarping: fix help text (-i -> -I), and shorten it a bit
Denis Vlasenko [Fri, 23 Nov 2007 09:27:05 +0000 (09:27 -0000)]
arping: fix help text (-i -> -I), and shorten it a bit

17 years agoarping: fix a bug where there is implicit count of 4G;
Denis Vlasenko [Fri, 23 Nov 2007 09:15:26 +0000 (09:15 -0000)]
arping: fix a bug where there is implicit count of 4G;
eliminate data/bss usage; code shrink

function                                             old     new   delta
timeout_us                                             4       -      -4
static.start                                           4       -      -4
src                                                    4       -      -4
sock                                                   4       -      -4
sent                                                   4       -      -4
req_recv                                               4       -      -4
received                                               4       -      -4
last                                                   4       -      -4
dst                                                    4       -      -4
count                                                  4       -      -4
brd_sent                                               4       -      -4
brd_recv                                               4       -      -4
catcher                                              375     365     -10
me                                                    20       -     -20
he                                                    20       -     -20
arping_main                                         1941    1874     -67
------------------------------------------------------------------------------
(add/remove: 0/14 grow/shrink: 0/2 up/down: 0/-165)          Total: -165 bytes
   text    data     bss     dec     hex filename
 783035     941    9244  793220   c1a84 busybox_old
 782907     937    9156  793000   c19a8 busybox_unstripped

17 years agocut: add proper stdout error handling, fix "-" handling;
Denis Vlasenko [Fri, 23 Nov 2007 07:26:15 +0000 (07:26 -0000)]
cut: add proper stdout error handling, fix "-" handling;
modest code shrink

17 years agologread: add forgotten INIT_G();
Denis Vlasenko [Fri, 23 Nov 2007 03:41:20 +0000 (03:41 -0000)]
logread: add forgotten INIT_G();

17 years agologread: eliminate usage of data/bss
Denis Vlasenko [Fri, 23 Nov 2007 03:39:45 +0000 (03:39 -0000)]
logread: eliminate usage of data/bss
ifup: don't remove virtual iface prefixes (eth0:0)

function                                             old     new   delta
shbuf                                                  4       -      -4
SMrup                                                  6       -      -6
SMrdn                                                 12       -     -12
static.label_buf                                      20       4     -16
get_var                                              158     140     -18
------------------------------------------------------------------------------
(add/remove: 0/3 grow/shrink: 0/2 up/down: 0/-56)             Total: -56 bytes
   text    data     bss     dec     hex filename
 783501     962    9260  793723   c1c7b busybox_old
 783483     942    9244  793669   c1c45 busybox_unstripped

17 years agodhcp: stop using magic constants; use (htonl(CONST) != a) - it's smaller
Denis Vlasenko [Fri, 23 Nov 2007 00:08:54 +0000 (00:08 -0000)]
dhcp: stop using magic constants; use (htonl(CONST) != a) - it's smaller

function                                             old     new   delta
udhcp_get_packet                                     146     134     -12
get_raw_packet                                       368     353     -15

17 years agoudhcpc: remove -W option, -A can be reused for that
Denis Vlasenko [Thu, 22 Nov 2007 21:41:14 +0000 (21:41 -0000)]
udhcpc: remove -W option, -A can be reused for that
help texts: trimmed a bit

static.udhcpc_longopts                               227     209     -18
udhcpc_main                                         2633    2590     -43
packed_usage                                       22927   22871     -56
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-117)           Total: -117 bytes

17 years agofix a thinko in build system
Denis Vlasenko [Thu, 22 Nov 2007 20:09:41 +0000 (20:09 -0000)]
fix a thinko in build system

17 years agoash: fix bug where redirection of closed fd was leaving it open afterwards.
Denis Vlasenko [Thu, 22 Nov 2007 08:16:57 +0000 (08:16 -0000)]
ash: fix bug where redirection of closed fd was leaving it open afterwards.

redirect                                             983    1024     +41
bb_echo                                              276     301     +25
popredir                                             118     132     +14
evalcommand                                         1163    1176     +13
bbunpack                                             358     366      +8
echocmd                                               13       5      -8
echo_main                                             13       5      -8
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 5/2 up/down: 101/-16)            Total: 85 bytes
   text    data     bss     dec     hex filename
 774999     962    9236  785197   bfb2d busybox_old
 775084     962    9236  785282   bfb82 busybox_unstripped

17 years agosestatus: new SELinux applet (KaiGai Kohei <kaigai@ak.jp.nec.com>)
Denis Vlasenko [Thu, 22 Nov 2007 01:10:41 +0000 (01:10 -0000)]
sestatus: new SELinux applet (KaiGai Kohei <kaigai@ak.jp.nec.com>)

17 years agodhcpc: cleanup and comments; fix buggy timeout handling in corner cases.
Denis Vlasenko [Thu, 22 Nov 2007 01:00:00 +0000 (01:00 -0000)]
dhcpc: cleanup and comments; fix buggy timeout handling in corner cases.
-25 bytes.

17 years agoudhcpc: an option to perform ARP check (Jonas Danielsson <jonas.danielsson@axis.com>)
Denis Vlasenko [Thu, 22 Nov 2007 00:58:49 +0000 (00:58 -0000)]
udhcpc: an option to perform ARP check (Jonas Danielsson <jonas.danielsson@axis.com>)
configurable, ~+300 bytes when on.

17 years agocleanup comments and coding style and rewrite the mdev.conf parser to use common...
Mike Frysinger [Mon, 19 Nov 2007 09:04:22 +0000 (09:04 -0000)]
cleanup comments and coding style and rewrite the mdev.conf parser to use common busybox functions and call strdup() less often ... saves a ~few hundred bytes

17 years agoip: stop propagating argc; optimize ip_parse_common_args
Denis Vlasenko [Sun, 18 Nov 2007 22:56:25 +0000 (22:56 -0000)]
ip: stop propagating argc; optimize ip_parse_common_args

function                                             old     new   delta
find_pair                                            167     187     +20
static.families                                        -      17     +17
die_must_be_on_off                                     -      11     +11
...
on_off                                                33      22     -11
do_ipaddr                                            103      90     -13
do_iptunnel                                         1001     986     -15
iproute_list_or_flush                               1237    1217     -20
static.ip_common_commands                             43      22     -21
do_iproute                                          2217    2193     -24
parse_args                                          1444    1414     -30
ip_do                                                 47      16     -31
do_iprule                                            994     963     -31
ip_main                                              153     113     -40
ipaddr_modify                                       1357    1305     -52
ipaddr_list_or_flush                                2543    2490     -53
ip_parse_common_args                                 294     159    -135
------------------------------------------------------------------------------
(add/remove: 4/1 grow/shrink: 4/24 up/down: 85/-563)         Total: -478 bytes
   text    data     bss     dec     hex filename
 775561     966    9236  785763   bfd63 busybox_old
 775073     962    9236  785271   bfb77 busybox_unstripped

17 years agostty: mark variable as static
Denis Vlasenko [Sun, 18 Nov 2007 11:47:25 +0000 (11:47 -0000)]
stty: mark variable as static

17 years agomake output a little more friendly
Mike Frysinger [Sun, 18 Nov 2007 06:42:56 +0000 (06:42 -0000)]
make output a little more friendly

17 years agomerge from upstream for systems that dont integrate libintl into their C library:
Mike Frysinger [Sun, 18 Nov 2007 06:17:52 +0000 (06:17 -0000)]
merge from upstream for systems that dont integrate libintl into their C library:

commit aa1e5ef5c1d95e7ebf0821d9ba27debe43a87a22
Author: Sam Ravnborg <sam@ravnborg.org>
Date:   Sun Aug 12 23:15:44 2007 +0200

    kbuild: check if we can link gettext not just compile

    cygwin provides the header file but the lib file needs
    to be added manually. A generic fix is to check if
    we can compile and link a program that uses gettext()
    and if it fails fall back to NO_NLS.

    International users of cygwin may have to specify
    HOST_LOADLIBES := "-lintl" on the make command line.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
17 years agoexported symbols may be weak, so allow symbols marked as W
Mike Frysinger [Sun, 18 Nov 2007 06:13:58 +0000 (06:13 -0000)]
exported symbols may be weak, so allow symbols marked as W

17 years agosyslogd: use DEV_CONSOLE consistently
Denis Vlasenko [Sun, 18 Nov 2007 05:43:05 +0000 (05:43 -0000)]
syslogd: use DEV_CONSOLE consistently
init: remove obsolete comment

17 years agohexdump: add hd alias, add -R option
Denis Vlasenko [Sun, 18 Nov 2007 05:36:50 +0000 (05:36 -0000)]
hexdump: add hd alias, add -R option

17 years agoadd comment clarifying busybox's use of non-standard tar header
Paul Fox [Sat, 17 Nov 2007 19:11:05 +0000 (19:11 -0000)]
add comment clarifying busybox's use of non-standard tar header

17 years agotar: fix a case where glibc detects bogus buffer overrun
Denis Vlasenko [Fri, 16 Nov 2007 20:35:30 +0000 (20:35 -0000)]
tar: fix a case where glibc detects bogus buffer overrun
     which is not really there!

17 years agodmesg,klogd: make code more readable
Denis Vlasenko [Fri, 16 Nov 2007 20:18:54 +0000 (20:18 -0000)]
dmesg,klogd: make code more readable
libbb: explain why we declare klogctl
libbb: move defs around so that order makes more sense

17 years ago- use standard-imposed constants some more
Bernhard Reutner-Fischer [Fri, 16 Nov 2007 12:39:16 +0000 (12:39 -0000)]
- use standard-imposed constants some more

17 years ago- remove most of the forward declarations. No obj-code changes.
Bernhard Reutner-Fischer [Fri, 16 Nov 2007 12:20:30 +0000 (12:20 -0000)]
- remove most of the forward declarations. No obj-code changes.

17 years ago- add note about SUSv3 missing options.
Bernhard Reutner-Fischer [Fri, 16 Nov 2007 11:52:42 +0000 (11:52 -0000)]
- add note about SUSv3 missing options.

17 years agowho: add -a (by Tito)
Denis Vlasenko [Fri, 16 Nov 2007 05:24:43 +0000 (05:24 -0000)]
who: add -a (by Tito)

17 years agolash: fix compile-time warning
Denis Vlasenko [Thu, 15 Nov 2007 17:47:45 +0000 (17:47 -0000)]
lash: fix compile-time warning

17 years agodf: add -a
Denis Vlasenko [Thu, 15 Nov 2007 09:02:12 +0000 (09:02 -0000)]
df: add -a
df: don't special case rootfs and /dev/root

function                                             old     new   delta
df_main                                              746     684     -62
find_block_device                                    111       -    -111
find_block_device_in_dir                             243       -    -243
------------------------------------------------------------------------------
(add/remove: 0/2 grow/shrink: 0/1 up/down: 0/-416)           Total: -416 bytes

17 years agodf: add -i (conditional on CONFIG)
Denis Vlasenko [Thu, 15 Nov 2007 07:02:55 +0000 (07:02 -0000)]
df: add -i (conditional on CONFIG)
uasge: trim a bit

17 years agocosmetic change in message text
Denis Vlasenko [Thu, 15 Nov 2007 00:57:40 +0000 (00:57 -0000)]
cosmetic change in message text

17 years agobad syntax error should go to stderr
Paul Fox [Wed, 14 Nov 2007 23:48:35 +0000 (23:48 -0000)]
bad syntax error should go to stderr

17 years agoIntroduce FEATURE_PREFER_IPV4_ADDRESS. If selected, we have:
Denis Vlasenko [Wed, 14 Nov 2007 10:18:33 +0000 (10:18 -0000)]
Introduce FEATURE_PREFER_IPV4_ADDRESS. If selected, we have:
function                                             old     new   delta
str2sockaddr                                         328     344     +16

17 years agotr: more of code shrink (getopt32-ification)
Denis Vlasenko [Tue, 13 Nov 2007 22:23:57 +0000 (22:23 -0000)]
tr: more of code shrink (getopt32-ification)
runtest: cleanup. Method of getting $applets was truly bizarre

function                                             old     new   delta
tr_main                                              655     527    -128

17 years agotr: better comments, small code shrink
Denis Vlasenko [Tue, 13 Nov 2007 22:22:29 +0000 (22:22 -0000)]
tr: better comments, small code shrink

function                                             old     new   delta
expand                                              2232    2230      -2
tr_main                                              677     655     -22

17 years agotr: properly detect read errors (Fernando Silveira <fsilveira@gmail.com>)
Denis Vlasenko [Tue, 13 Nov 2007 17:51:40 +0000 (17:51 -0000)]
tr: properly detect read errors (Fernando Silveira <fsilveira@gmail.com>)
readprofile: use xwrite

function                                             old     new   delta
tr_main                                              679     677      -2
readprofile_main                                    1964    1944     -20

17 years agotrylink: accomodate older versions of ld
Denis Vlasenko [Tue, 13 Nov 2007 17:36:12 +0000 (17:36 -0000)]
trylink: accomodate older versions of ld

17 years agowho: code shrink by Tito <farmatito@tiscali.it>
Denis Vlasenko [Tue, 13 Nov 2007 17:26:21 +0000 (17:26 -0000)]
who: code shrink by Tito <farmatito@tiscali.it>

function                                             old     new   delta
who_main                                             271     259     -12

17 years agoadd sed mini-doc
Denis Vlasenko [Tue, 13 Nov 2007 17:13:31 +0000 (17:13 -0000)]
add sed mini-doc

17 years agosed: support GNU-like '\t' escape in substitutions
Denis Vlasenko [Tue, 13 Nov 2007 16:48:10 +0000 (16:48 -0000)]
sed: support GNU-like '\t' escape in substitutions

17 years agoinetd: revert bogus fix for bug 1562; shrink inetd a bit
Denis Vlasenko [Mon, 12 Nov 2007 21:21:35 +0000 (21:21 -0000)]
inetd: revert bogus fix for bug 1562; shrink inetd a bit

function                                             old     new   delta
dupconfig                                            159     146     -13
getconfigent                                        1123    1073     -50

17 years agoopen_transformer: do not duplicate "<program> -cf -"
Denis Vlasenko [Mon, 12 Nov 2007 02:13:12 +0000 (02:13 -0000)]
open_transformer: do not duplicate "<program> -cf -"

   text    data     bss     dec     hex filename
 677858     738    7236  685832   a7708 busybox_old
 677804     738    7236  685778   a76d2 busybox_unstripped

17 years agogzip: fix a case where tar xzf fails (we use uninitialized fd)
Denis Vlasenko [Mon, 12 Nov 2007 01:44:49 +0000 (01:44 -0000)]
gzip: fix a case where tar xzf fails (we use uninitialized fd)

17 years agowho: fix wrong date/time field size
Denis Vlasenko [Sun, 11 Nov 2007 06:35:41 +0000 (06:35 -0000)]
who: fix wrong date/time field size

17 years agoAnnounce 1.8.1
Denis Vlasenko [Sat, 10 Nov 2007 03:24:21 +0000 (03:24 -0000)]
Announce 1.8.1

17 years agoinit: fix bug 1584: improper check for fork error
Denis Vlasenko [Sat, 10 Nov 2007 01:57:35 +0000 (01:57 -0000)]
init: fix bug 1584: improper check for fork error

17 years agoumount: stop using excessive aounts of stack. Surprisingly,
Denis Vlasenko [Sat, 10 Nov 2007 01:45:03 +0000 (01:45 -0000)]
umount: stop using excessive aounts of stack. Surprisingly,
code shrank a lot too

function                                             old     new   delta
umount_main                                          751     640    -111

17 years agolineedit: stop using both data/bss and tons of stack.
Denis Vlasenko [Sat, 10 Nov 2007 01:35:47 +0000 (01:35 -0000)]
lineedit: stop using both data/bss and tons of stack.
stack usage was ~10 kb!
unfortunately, noticeable code size growth:
   text    data     bss     dec     hex filename
   9252      12     181    9445    24e5 busybox.t7/libbb/lineedit.o
   9714       4       0    9718    25f6 busybox.t8/libbb/lineedit.o

17 years ago*: remove superfluous "?" in option parsing
Denis Vlasenko [Sat, 10 Nov 2007 01:32:18 +0000 (01:32 -0000)]
*: remove superfluous "?" in option parsing

17 years agoreadlink: realpath requires PATH_MAX, bb_common_bufsiz1 can be too small
Denis Vlasenko [Sat, 10 Nov 2007 01:31:19 +0000 (01:31 -0000)]
readlink: realpath requires PATH_MAX, bb_common_bufsiz1 can be too small
umount: don't actually need char[2 * PATH_MAX] for realpath

17 years agosyslogd: support "symlink to symlink" for /dev/log; reduce stack usage
Denis Vlasenko [Sat, 10 Nov 2007 01:28:19 +0000 (01:28 -0000)]
syslogd: support "symlink to symlink" for /dev/log; reduce stack usage

function                                             old     new   delta
create_socket                                          -     134    +134
syslogd_main                                        1132     865    -267
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/1 up/down: 134/-267)         Total: -133 bytes
   text    data     bss     dec     hex filename
 775603     974    9420  785997   bfe4d busybox_old
 775445     974    9420  785839   bfdaf busybox_unstripped

17 years ago- commentary fixes
Bernhard Reutner-Fischer [Thu, 8 Nov 2007 21:11:43 +0000 (21:11 -0000)]
- commentary fixes
- use common exit sequence for failure path:
   text    data     bss     dec     hex filename
    308       0       0     308     134 libbb/xreadlink.o.pgf
    296       0       0     296     128 libbb/xreadlink.o

17 years agoxmalloc_follow_symlinks() -- fix ELOOP issue with absolute paths,
Paul Fox [Thu, 8 Nov 2007 20:00:36 +0000 (20:00 -0000)]
xmalloc_follow_symlinks() -- fix ELOOP issue with absolute paths,
return full path in cases where path doesn't resolve to a link.
change name to better differentiate from xmalloc_readlink().

17 years agoxreadlink: code shrink
Denis Vlasenko [Thu, 8 Nov 2007 17:40:23 +0000 (17:40 -0000)]
xreadlink: code shrink
udhcp: add missing tryagain member to client_config

function                                             old     new   delta
xmalloc_readlink_follow                              169     154     -15
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-15)             Total: -15 bytes

17 years agofollow symlinks to find the true passwd file before updating.
Paul Fox [Thu, 8 Nov 2007 01:12:38 +0000 (01:12 -0000)]
follow symlinks to find the true passwd file before updating.

17 years agonew xmalloc_readlink_follow() routine to fully expand trailing symlinks
Paul Fox [Thu, 8 Nov 2007 01:11:41 +0000 (01:11 -0000)]
new xmalloc_readlink_follow() routine to fully expand trailing symlinks
to get to a "real" file (or directory).

17 years agoadd "-A N" / "--tryagain=N" option to client, to allow altering the
Paul Fox [Wed, 7 Nov 2007 16:01:28 +0000 (16:01 -0000)]
add "-A N" / "--tryagain=N" option to client, to allow altering the
default 60 second wait after failure to get a lease.

17 years agoflush typeahead before prompt
Paul Fox [Wed, 7 Nov 2007 15:51:35 +0000 (15:51 -0000)]
flush typeahead before prompt

17 years agologin: fix PAM login (was unable to complete Kerberos login)
Denis Vlasenko [Wed, 7 Nov 2007 00:23:47 +0000 (00:23 -0000)]
login: fix PAM login (was unable to complete Kerberos login)

17 years agomodprobe: fix a bug where we were entering endless loop
Denis Vlasenko [Tue, 6 Nov 2007 11:34:03 +0000 (11:34 -0000)]
modprobe: fix a bug where we were entering endless loop
syslogd: strip trailing '\n' too, not only NULs

17 years agologin: clear dangerous environment variables if started by non-root
Denis Vlasenko [Tue, 6 Nov 2007 05:26:51 +0000 (05:26 -0000)]
login: clear dangerous environment variables if started by non-root

17 years agofbset: fix buglet where we were using wrong pointer
Denis Vlasenko [Tue, 6 Nov 2007 03:05:54 +0000 (03:05 -0000)]
fbset: fix buglet where we were using wrong pointer
readahead: stop using stdio.h
*: style fixes

17 years agotelnet: use poll, it's shorter
Denis Vlasenko [Tue, 6 Nov 2007 02:23:39 +0000 (02:23 -0000)]
telnet: use poll, it's shorter
*: style fixes

17 years agounzip: hmm... gcc doesn't like ATTRIBUTE_PACKED?? Document that...
Denis Vlasenko [Tue, 6 Nov 2007 02:16:01 +0000 (02:16 -0000)]
unzip: hmm... gcc doesn't like ATTRIBUTE_PACKED?? Document that...

17 years agoinsmod: make error reporting less verbose
Denis Vlasenko [Tue, 6 Nov 2007 02:02:45 +0000 (02:02 -0000)]
insmod: make error reporting less verbose

17 years agotelnetd: fix problem with zombies (by Paul Fox <pgf@brightstareng.com>)
Denis Vlasenko [Tue, 6 Nov 2007 01:38:46 +0000 (01:38 -0000)]
telnetd: fix problem with zombies (by Paul Fox <pgf@brightstareng.com>)
syslogd: strip trailing NULs

17 years agochange safety check on zip header to allow for extra length, and
Paul Fox [Mon, 5 Nov 2007 23:09:03 +0000 (23:09 -0000)]
change safety check on zip header to allow for extra length, and
revert the header read to use the correct constant rather than
sizeof.  at least one version of gcc (armv4-linux-gcc-3.4.1) pads
the struct to 28 bytes in spite of the packing.

17 years agoswaponoff: prevent arithmetic overflow (spotted by Paul Fox <pgf@brightstareng.com>)
Denis Vlasenko [Mon, 5 Nov 2007 19:33:38 +0000 (19:33 -0000)]
swaponoff: prevent arithmetic overflow (spotted by Paul Fox <pgf@brightstareng.com>)

17 years agofix incorrect text of link-time error message. No code changes
Denis Vlasenko [Mon, 5 Nov 2007 19:31:01 +0000 (19:31 -0000)]
fix incorrect text of link-time error message. No code changes

17 years agowebpage: fix typo, remove inconsistent trailing dots
Denis Vlasenko [Mon, 5 Nov 2007 16:26:34 +0000 (16:26 -0000)]
webpage: fix typo, remove inconsistent trailing dots
Makefile: version is 1.9.0.svn now