oweals/busybox.git
14 years agoudhcpc: fix OPTION_IP_PAIR parsing
Vladislav Grishenko [Sun, 17 Oct 2010 10:27:50 +0000 (12:27 +0200)]
udhcpc: fix OPTION_IP_PAIR parsing

http://git.busybox.net/busybox/commit/?id=7d3a48a003cd645edfae2b404493688022
revealed incorrect OPTION_IP_PAIR implementation, which doesn't respect
option length and causes erroneous classful routes, composed from garbage
or first bytes from the next DHCP packet option.

Signed-off-by: Vladislav Grishenko <themiron@mail.ru>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomd5: code shrink -5 bytes
Denys Vlasenko [Sun, 17 Oct 2010 09:38:44 +0000 (11:38 +0200)]
md5: code shrink -5 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agobring md5 and sha1 names closer. no code changes
Denys Vlasenko [Sun, 17 Oct 2010 01:21:51 +0000 (03:21 +0200)]
bring md5 and sha1 names closer. no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomd5: code shrink
Denys Vlasenko [Sun, 17 Oct 2010 01:00:36 +0000 (03:00 +0200)]
md5: code shrink

function                                             old     new   delta
md5_end                                              125     104     -21

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoshaN: code shrink
Denys Vlasenko [Sat, 16 Oct 2010 23:35:16 +0000 (01:35 +0200)]
shaN: code shrink

function                                             old     new   delta
init512_lo                                            32      40      +8
init256                                               32      40      +8
sha256_begin                                          42      28     -14
sha512_begin                                          81      53     -28
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/2 up/down: 16/-42)            Total: -26 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agowhitespace fix
Denys Vlasenko [Sat, 16 Oct 2010 21:39:43 +0000 (23:39 +0200)]
whitespace fix

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agosha512: inline rotr64
Denys Vlasenko [Sat, 16 Oct 2010 21:31:15 +0000 (23:31 +0200)]
sha512: inline rotr64

function                                             old     new   delta
sha1_process_block64                                 461     446     -15

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoshaN: small code shrink
Denys Vlasenko [Sat, 16 Oct 2010 20:43:34 +0000 (22:43 +0200)]
shaN: small code shrink

function                                             old     new   delta
sha512_hash                                          134     128      -6
sha1_hash                                            114     106      -8

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomd5: fix "fast" md5 broken by prev commit
Denys Vlasenko [Sat, 16 Oct 2010 19:34:36 +0000 (21:34 +0200)]
md5: fix "fast" md5 broken by prev commit

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotestsuite: add tests for {ms5,shaN}sum
Denys Vlasenko [Sat, 16 Oct 2010 19:26:47 +0000 (21:26 +0200)]
testsuite: add tests for {ms5,shaN}sum

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomd5: code shrink; and use 64-byte temp buf, not 128-byte.
Denys Vlasenko [Sat, 16 Oct 2010 18:46:35 +0000 (20:46 +0200)]
md5: code shrink; and use 64-byte temp buf, not 128-byte.

function                                             old     new   delta
md5_hash                                             111     108      -3
md5_end                                              129     125      -4
md5_hash_block                                       459     454      -5
filter_rename_config                                 250     244      -6
md5_crypt                                            587     578      -9
popmaildir_main                                      828     816     -12
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/6 up/down: 0/-39)             Total: -39 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years ago*: pass md5/shaN context pointer as 1st arg, not last
Denys Vlasenko [Sat, 16 Oct 2010 18:45:27 +0000 (20:45 +0200)]
*: pass md5/shaN context pointer as 1st arg, not last

function                                             old     new   delta
md5_hash_block                                       458     459      +1
filter_rename_config                                 252     250      -2
md5_crypt                                            591     587      -4

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomodutils/*: move help bits into corresponding .c files
Denys Vlasenko [Fri, 15 Oct 2010 23:56:41 +0000 (01:56 +0200)]
modutils/*: move help bits into corresponding .c files

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agolibbb/md5: code shrink
Denys Vlasenko [Fri, 15 Oct 2010 23:08:32 +0000 (01:08 +0200)]
libbb/md5: code shrink

function                                             old     new   delta
md5_end                                              123     117      -6
md5_begin                                             49      42      -7
md5_hash                                             119     104     -15

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agolibbb/md5: small code shrink
Denys Vlasenko [Fri, 15 Oct 2010 16:05:51 +0000 (18:05 +0200)]
libbb/md5: small code shrink

function                                             old     new   delta
md5_end                                              151     123     -28

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agomodutils/*: move applet bits into corresponding *.c files
Denys Vlasenko [Fri, 15 Oct 2010 09:29:02 +0000 (11:29 +0200)]
modutils/*: move applet bits into corresponding *.c files

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agodate: move applet and usage bits to date.c
Denys Vlasenko [Fri, 15 Oct 2010 08:42:17 +0000 (10:42 +0200)]
date: move applet and usage bits to date.c

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoremove runit/runit_lib.c
Denys Vlasenko [Wed, 13 Oct 2010 10:53:27 +0000 (12:53 +0200)]
remove runit/runit_lib.c

function                                             old     new   delta
runsv_main                                          1770    1786     +16
svstatus_get                                         176     188     +12
sv_main                                             1180    1186      +6
runsvdir_main                                        683     689      +6
processorstart                                       385     391      +6
control                                              126     132      +6
logdir_open                                         1184    1187      +3
lock_exnb                                             14       -     -14
lock_ex                                               14       -     -14
open_write                                            17       -     -17
open_read                                             17       -     -17
------------------------------------------------------------------------------
(add/remove: 0/5 grow/shrink: 7/0 up/down: 55/-62)             Total: -7 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoinit/*: move applet/kbuild/config/help bits into applet source files
Denys Vlasenko [Tue, 12 Oct 2010 11:47:15 +0000 (13:47 +0200)]
init/*: move applet/kbuild/config/help bits into applet source files

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agotweaks to build system, mainly making menuconfig text and order clearer
Denys Vlasenko [Tue, 12 Oct 2010 02:18:05 +0000 (04:18 +0200)]
tweaks to build system, mainly making menuconfig text and order clearer

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoremove findutils/.gitignore, top-level one covers it
Denys Vlasenko [Mon, 11 Oct 2010 10:53:19 +0000 (12:53 +0200)]
remove findutils/.gitignore, top-level one covers it

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agotweak help text
Denys Vlasenko [Sat, 9 Oct 2010 19:10:32 +0000 (21:10 +0200)]
tweak help text

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agofix help text punctuation
Denys Vlasenko [Fri, 8 Oct 2010 13:04:23 +0000 (15:04 +0200)]
fix help text punctuation

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agotweak usage texts
Denys Vlasenko [Thu, 7 Oct 2010 11:25:09 +0000 (13:25 +0200)]
tweak usage texts

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agodhcprelay: code shrink, and explain its workings a bit more
Denys Vlasenko [Tue, 5 Oct 2010 23:45:24 +0000 (01:45 +0200)]
dhcprelay: code shrink, and explain its workings a bit more

function                                             old     new   delta
sendto_ip4                                             -      55     +55
dhcprelay_main                                      1059     942    -117
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/1 up/down: 55/-117)           Total: -62 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: code shrink
Denys Vlasenko [Tue, 5 Oct 2010 14:49:03 +0000 (16:49 +0200)]
awk: code shrink

function                                             old     new   delta
fsrealloc                                            112     107      -5
next_token                                           862     844     -18

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoawk: 00.123 is not a octal constant; neither is 009.123. fixing this
Denys Vlasenko [Tue, 5 Oct 2010 11:22:11 +0000 (13:22 +0200)]
awk: 00.123 is not a octal constant; neither is 009.123. fixing this

function                                             old     new   delta
my_strtod                                             80     113     +33

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agosendmail: fix assumption that headers should have a space after the colon
Vladimir Dronnikov [Mon, 4 Oct 2010 23:21:32 +0000 (01:21 +0200)]
sendmail: fix assumption that headers should have a space after the colon

Signed-off-by: Vladimir Dronnikov <dronnikov@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotune2fs: implement -c and -i options
Richard Braun [Mon, 4 Oct 2010 22:39:46 +0000 (00:39 +0200)]
tune2fs: implement -c and -i options

function                                             old     new   delta
tune2fs_main                                         165     256     +91

Signed-off-by: Richard Braun <rbraun@sceen.net>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years ago*: whitespace fixes
Denys Vlasenko [Mon, 4 Oct 2010 22:13:02 +0000 (00:13 +0200)]
*: whitespace fixes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agowc: add support for -m
Denys Vlasenko [Mon, 4 Oct 2010 15:08:14 +0000 (17:08 +0200)]
wc: add support for -m

function                                             old     new   delta
wc_main                                              601     637     +36
packed_usage                                       27357   27358      +1

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agowc: preparatory patch, no logic changes
Denys Vlasenko [Mon, 4 Oct 2010 15:04:20 +0000 (17:04 +0200)]
wc: preparatory patch, no logic changes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoman: add compatibility with man-db
Denys Vlasenko [Mon, 4 Oct 2010 12:19:59 +0000 (14:19 +0200)]
man: add compatibility with man-db

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agontpd: allow peer-less (standalone stratum 1 server) operation
Denys Vlasenko [Sun, 3 Oct 2010 23:20:44 +0000 (01:20 +0200)]
ntpd: allow peer-less (standalone stratum 1 server) operation

Based on patch by Jean-Christophe Dubois (jcd@tribudubois.net)

function                                             old     new   delta
ntp_init                                             384     399     +15
recv_and_process_client_pkt                          469     480     +11

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agopatch: tweaks
Rob Landley [Sun, 3 Oct 2010 22:49:48 +0000 (00:49 +0200)]
patch: tweaks

1) Eliminate spurious warnings about possibly reduced hunks.  Instead only
note a possible location if we don't find a non-reversed place to apply it.
(Otherwise, hunks that move code forward around within a file look reversed at
the removal site.)

2) Open the source file read-only, so we can apply patches to read-only files.

Signed-off-by: Rob Landley <rob@landley.net>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohush: remove "doesn't support brace expansion" from config help text
Denys Vlasenko [Sun, 3 Oct 2010 22:01:47 +0000 (00:01 +0200)]
hush: remove "doesn't support brace expansion" from config help text

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohush: remove brace expansion from TODO list in comments. No code changes.
Denys Vlasenko [Sun, 3 Oct 2010 15:22:52 +0000 (17:22 +0200)]
hush: remove brace expansion from TODO list in comments. No code changes.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohush: small code shrink
Denys Vlasenko [Sun, 3 Oct 2010 15:15:50 +0000 (17:15 +0200)]
hush: small code shrink

function                                             old     new   delta
expand_on_ifs                                        231     222      -9

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohush: add brace expansion testcase
Denys Vlasenko [Sun, 3 Oct 2010 15:07:57 +0000 (17:07 +0200)]
hush: add brace expansion testcase

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohush: implement brace expansion
Denys Vlasenko [Sun, 3 Oct 2010 12:28:04 +0000 (14:28 +0200)]
hush: implement brace expansion

When enabled:

function                                             old     new   delta
glob_brace                                             -     402    +402
next_brace_sub                                         -      70     +70
expand_on_ifs                                        185     231     +46
bbconfig_config_bz2                                 4923    4929      +6
o_save_ptr                                           282     140    -142
------------------------------------------------------------------------------
(add/remove: 2/0 grow/shrink: 2/1 up/down: 524/-142)          Total: 382 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohush: preparatory patch, no code changes
Denys Vlasenko [Sun, 3 Oct 2010 12:26:26 +0000 (14:26 +0200)]
hush: preparatory patch, no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agogrep: cap insane -B NUM values to MAX_INT / 8. Fixes bug 2653.
Denys Vlasenko [Sat, 2 Oct 2010 10:42:28 +0000 (12:42 +0200)]
grep: cap insane -B NUM values to MAX_INT / 8. Fixes bug 2653.

function                                             old     new   delta
grep_main                                            766     779     +13

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoMarked some more applets NOEXEC/NOFORK
Dan Fandrich [Thu, 30 Sep 2010 21:31:12 +0000 (14:31 -0700)]
Marked some more applets NOEXEC/NOFORK

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agofree: document newly added options
Denys Vlasenko [Fri, 1 Oct 2010 20:42:44 +0000 (22:42 +0200)]
free: document newly added options

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agofree: add -b/k/m/g options; remove 4 TB limitation. +100 bytes
Denys Vlasenko [Fri, 1 Oct 2010 19:57:59 +0000 (21:57 +0200)]
free: add -b/k/m/g options; remove 4 TB limitation. +100 bytes

Based on patch by Stefan Tomanek (stefan@pico.ruhr.de)

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohalt/poweroff/reboot: unify help text
Denys Vlasenko [Thu, 30 Sep 2010 21:44:08 +0000 (23:44 +0200)]
halt/poweroff/reboot: unify help text

function                                             old     new   delta
packed_usage                                       27755   27733     -22

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodeluser: use the same licensing template in the header as other files do
Denys Vlasenko [Thu, 30 Sep 2010 16:51:25 +0000 (18:51 +0200)]
deluser: use the same licensing template in the header as other files do

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoacpid: add config file and map file
Souf Oued [Sun, 26 Sep 2010 10:40:05 +0000 (12:40 +0200)]
acpid: add config file and map file

function                                             old     new   delta
acpid_main                                           434    1137    +703
find_action                                            -     204    +204
f_evt_tab                                              -      48     +48
packed_usage                                       27724   27755     +31
f_act_tab                                              -      16     +16
process_event                                        126       -    -126
------------------------------------------------------------------------------
(add/remove: 3/1 grow/shrink: 2/0 up/down: 1002/-126)         Total: 876 bytes

Signed-off-by: Souf Oued <souf_oued@yahoo.fr>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: add support for 0x21 ROUTES and 0xf9 MS_STATIC_ROUTES options
Vladislav Grishenko [Sat, 25 Sep 2010 22:15:12 +0000 (00:15 +0200)]
udhcp: add support for 0x21 ROUTES and 0xf9 MS_STATIC_ROUTES options

Signed-off-by: Vladislav Grishenko <themiron@mail.ru>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agostyle fix. no code chages
Denys Vlasenko [Sat, 25 Sep 2010 15:19:04 +0000 (17:19 +0200)]
style fix. no code chages

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: fix signal and "set -e" interaction
Denys Vlasenko [Sat, 25 Sep 2010 15:15:13 +0000 (17:15 +0200)]
ash: fix signal and "set -e" interaction

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomodprobe-simple; do not error out on "rmmod module" if module is unloaded ok
Denys Vlasenko [Sat, 25 Sep 2010 12:37:06 +0000 (14:37 +0200)]
modprobe-simple; do not error out on "rmmod module" if module is unloaded ok

...even if it wasn't found in /lib/modules/VER/

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agosleep: fix fractional arguments in non-POSIX locale
Denys Vlasenko [Fri, 24 Sep 2010 10:39:45 +0000 (12:39 +0200)]
sleep: fix fractional arguments in non-POSIX locale

function                                             old     new   delta
sleep_main                                           390     379     -11

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agowget: flush output to network before receving reply
Nguyễn Thái Ngọc Duy [Thu, 23 Sep 2010 13:18:41 +0000 (15:18 +0200)]
wget: flush output to network before receving reply

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agonbd-client: new applet
Rob Landley [Thu, 23 Sep 2010 00:03:47 +0000 (02:03 +0200)]
nbd-client: new applet

function                                             old     new   delta
nbdclient_main                                         -     537    +537
daemon                                                 -     162    +162
packed_usage                                       27682   27724     +42
applet_names                                        2355    2366     +11
bbconfig_config_bz2                                 4918    4922      +4
applet_main                                         1376    1380      +4
applet_nameofs                                       688     690      +2
applet_install_loc                                   172     173      +1
------------------------------------------------------------------------------
(add/remove: 4/0 grow/shrink: 6/0 up/down: 763/0)             Total: 763 bytes

Signed-off-by: Rob Landley <rob@landley.net>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodeluser: make it simpler, fix inability to delete user from group
Harald Becker [Wed, 22 Sep 2010 12:50:15 +0000 (14:50 +0200)]
deluser: make it simpler, fix inability to delete user from group

Also makes menuconfig order more sensible

Signed-off-by: Harald Becker <ralda@gmx.de>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: use smaller EXP_FLAG_foo constants
Denys Vlasenko [Tue, 21 Sep 2010 10:35:39 +0000 (12:35 +0200)]
hush: use smaller EXP_FLAG_foo constants

function                                             old     new   delta
expand_string_to_string                              126     124      -2
parse_stream                                        2376    2370      -6
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-8)               Total: -8 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agofix build failure for pmap
Dan Fandrich [Sun, 19 Sep 2010 15:13:21 +0000 (17:13 +0200)]
fix build failure for pmap

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoshell/math: better comment. no code changes
Denys Vlasenko [Fri, 17 Sep 2010 16:02:17 +0000 (18:02 +0200)]
shell/math: better comment. no code changes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agomove read_base64 to libbb/uuencode.c
Denys Vlasenko [Thu, 16 Sep 2010 16:10:04 +0000 (18:10 +0200)]
move read_base64 to libbb/uuencode.c

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agolibbb: merge mail and uudecode's base64 decoders
Denys Vlasenko [Thu, 16 Sep 2010 15:51:13 +0000 (17:51 +0200)]
libbb: merge mail and uudecode's base64 decoders

function                                             old     new   delta
read_base64                                            -     378    +378
uudecode_main                                        306     315      +9
parse                                                953     958      +5
read_stduu                                           250     254      +4
base64_main                                          217     219      +2
read_base64                                          358       -    -358
decode_base64                                        371       -    -371
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 4/0 up/down: 398/-729)         Total: -331 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: move shell_ver from globals to main's stack.
Denys Vlasenko [Thu, 16 Sep 2010 14:12:00 +0000 (16:12 +0200)]
hush: move shell_ver from globals to main's stack.

function                                             old     new   delta
hush_main                                            995    1011     +16
pseudo_exec_argv                                     253     251      -2
execvp_or_die                                         50      48      -2
maybe_set_to_sigexit                                  50      47      -3
hush_exit                                             78      75      -3
builtin_wait                                         274     271      -3
check_and_run_traps                                  205     200      -5
init_sigmasks                                        214     190     -24
builtin_trap                                         465     441     -24
reset_traps_to_defaults                              238     211     -27
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/9 up/down: 16/-93)            Total: -77 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agosimpler check for od
Denys Vlasenko [Thu, 16 Sep 2010 13:46:20 +0000 (15:46 +0200)]
simpler check for od

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agobuild system: test that od is present in the host system
Denys Vlasenko [Thu, 16 Sep 2010 11:23:15 +0000 (13:23 +0200)]
build system: test that od is present in the host system

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoshell/math: deconvolute and explain ?: handling. Give better error message
Denys Vlasenko [Thu, 16 Sep 2010 09:50:46 +0000 (11:50 +0200)]
shell/math: deconvolute and explain ?: handling. Give better error message

function                                             old     new   delta
arith_apply                                         1271    1283     +12

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoshell/math: return string error indicator, not integer
Denys Vlasenko [Wed, 15 Sep 2010 11:33:02 +0000 (13:33 +0200)]
shell/math: return string error indicator, not integer

function                                             old     new   delta
expand_and_evaluate_arith                             87     106     +19
expand_one_var                                      1563    1570      +7
arith                                                 12      18      +6
evaluate_string                                      678     680      +2
arith_apply                                         1269    1271      +2
builtin_umask                                        133     132      -1
ash_arith                                            118      75     -43
expand_vars_to_list                                 1094    1038     -56
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 5/3 up/down: 36/-100)           Total: -64 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agosleep: make it non-NOFORK. Fixes ^C in standalone shell
Denys Vlasenko [Tue, 14 Sep 2010 10:57:05 +0000 (12:57 +0200)]
sleep: make it non-NOFORK. Fixes ^C in standalone shell

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoshell/math.c: stop using bss variable
Denys Vlasenko [Mon, 13 Sep 2010 10:49:52 +0000 (12:49 +0200)]
shell/math.c: stop using bss variable

function                                             old     new   delta
evaluate_string                                        -     678    +678
expand_one_var                                      1543    1563     +20
builtin_type                                         114     116      +2
expand_and_evaluate_arith                             89      87      -2
prev_chk_var_recursive                                 4       -      -4
ash_arith                                            122     118      -4
arith_lookup_val                                     142     132     -10
arith                                                674      12    -662
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 2/4 up/down: 700/-682)           Total: 18 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoshell/math.c: rename arith_eval_hooks to arith_state, put error code into it
Denys Vlasenko [Mon, 13 Sep 2010 10:49:03 +0000 (12:49 +0200)]
shell/math.c: rename arith_eval_hooks to arith_state, put error code into it

function                                             old     new   delta
expand_and_evaluate_arith                             79      89     +10
arith                                                675     674      -1
arith_lookup_val                                     151     142      -9
ash_arith                                            135     122     -13
arith_apply                                         1304    1269     -35
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/4 up/down: 10/-58)            Total: -48 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoshell/math.c: small code shrink; fixed incomprehensible comments
Denys Vlasenko [Mon, 13 Sep 2010 09:11:40 +0000 (11:11 +0200)]
shell/math.c: small code shrink; fixed incomprehensible comments

function                                             old     new   delta
arith_apply                                         1334    1304     -30

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoshell: small code shrink
Denys Vlasenko [Sun, 12 Sep 2010 23:09:11 +0000 (01:09 +0200)]
shell: small code shrink

function                                             old     new   delta
arith                                                680     675      -5

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoshell: shrink arith code; and prepare for returning text error codes
Denys Vlasenko [Sun, 12 Sep 2010 22:34:26 +0000 (00:34 +0200)]
shell: shrink arith code; and prepare for returning text error codes

function                                             old     new   delta
arith                                                701     680     -21

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: optional support for history saving
Denys Vlasenko [Sun, 12 Sep 2010 15:34:13 +0000 (17:34 +0200)]
hush: optional support for history saving

function                                             old     new   delta
hush_main                                            945     995     +50

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agosmemcap: use correct tar magic
Denys Vlasenko [Sun, 12 Sep 2010 15:13:29 +0000 (17:13 +0200)]
smemcap: use correct tar magic

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years ago*: s/perror/bb_simple_perror_msg/g
Marek Polacek [Sun, 12 Sep 2010 15:06:43 +0000 (17:06 +0200)]
*: s/perror/bb_simple_perror_msg/g

function                                             old     new   delta
readLines                                            448     446      -2
doCommands                                          2449    2438     -11
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-13)             Total: -13 bytes

Signed-off-by: Marek Polacek <mmpolacek@gmail.com>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoFixed a couple of failing tar tests
Dan Fandrich [Sat, 11 Sep 2010 07:28:50 +0000 (00:28 -0700)]
Fixed a couple of failing tar tests

The tar symlinks mode test is fixed similarly to the hardlinks
test in 0d7cb4cc, and the read-only test is skipped by
SKIP_KNOWN_BUGS.

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agobusybox: add "busybox --list[-full]" to help text
Denys Vlasenko [Sun, 12 Sep 2010 14:17:37 +0000 (16:17 +0200)]
busybox: add "busybox --list[-full]" to help text

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: move the EXIT trap comment. no code changes
Denys Vlasenko [Sun, 12 Sep 2010 14:13:44 +0000 (16:13 +0200)]
hush: move the EXIT trap comment. no code changes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: fix EXIT trap display inside exit trap handler
Denys Vlasenko [Sun, 12 Sep 2010 13:38:04 +0000 (15:38 +0200)]
hush: fix EXIT trap display inside exit trap handler

function                                             old     new   delta
hush_exit                                             84      78      -6

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoshell/match.c: shrink by dropping double bool inversion
Denys Vlasenko [Sun, 12 Sep 2010 13:06:42 +0000 (15:06 +0200)]
shell/match.c: shrink by dropping double bool inversion

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: fix handling of \" in quoted/unquoted `cmd`
Denys Vlasenko [Sun, 12 Sep 2010 13:05:39 +0000 (15:05 +0200)]
hush: fix handling of \" in quoted/unquoted `cmd`

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoash: shrink by folding an if check into setprompt; unindent big block
Denys Vlasenko [Sun, 12 Sep 2010 13:04:27 +0000 (15:04 +0200)]
ash: shrink by folding an if check into setprompt; unindent big block

function                                             old     new   delta
setprompt_if                                           -      66     +66
parseheredoc                                         126     124      -2
parsecmd                                              68      66      -2
redirect                                            1254    1249      -5
xxreadtoken                                          351     343      -8
readtoken1                                          3219    3204     -15
setprompt                                             62       -     -62
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 0/5 up/down: 66/-94)            Total: -28 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoash: add missing casts to match CTLfoo; add TODO comments
Denys Vlasenko [Sun, 12 Sep 2010 13:03:16 +0000 (15:03 +0200)]
ash: add missing casts to match CTLfoo; add TODO comments

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: remove forgotten commented-out block. no code changes
Denys Vlasenko [Fri, 10 Sep 2010 13:34:53 +0000 (15:34 +0200)]
hush: remove forgotten commented-out block. no code changes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: do fewer strdups in % and hash expansions
Denys Vlasenko [Fri, 10 Sep 2010 09:06:01 +0000 (11:06 +0200)]
hush: do fewer strdups in % and hash expansions

function                                             old     new   delta
builtin_umask                                        133     132      -1
expand_one_var                                      1552    1543      -9

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: better function and parameter names
Denys Vlasenko [Fri, 10 Sep 2010 08:44:23 +0000 (10:44 +0200)]
hush: better function and parameter names

Also, trim code which isn't needed for non-bash compat.
No logic changes.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: fixes to testsuite
Denys Vlasenko [Fri, 10 Sep 2010 08:19:22 +0000 (10:19 +0200)]
hush: fixes to testsuite

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: fix var_bash5.tests failure
Denys Vlasenko [Fri, 10 Sep 2010 08:17:53 +0000 (10:17 +0200)]
hush: fix var_bash5.tests failure

function                                             old     new   delta
expand_one_var                                      1513    1552     +39
expand_pseudo_dquoted                                118     135     +17
expand_string_to_string                              110     126     +16
setup_heredoc                                        298     308     +10
expand_and_evaluate_arith                             69      79     +10
parse_stream_dquoted                                 233     241      +8
setup_redirects                                      220     225      +5
run_list                                             956     961      +5
expand_assignments                                    76      81      +5
run_pipe                                            1587    1590      +3
parse_stream                                        2371    2374      +3
builtin_umask                                        132     133      +1
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 12/0 up/down: 122/0)            Total: 122 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: fix var_bash3.tests failure
Denys Vlasenko [Fri, 10 Sep 2010 08:15:18 +0000 (10:15 +0200)]
hush: fix var_bash3.tests failure

function                                             old     new   delta
expand_one_var                                      1513    1538     +25
parse_stream_dquoted                                 233     241      +8
expand_pseudo_dquoted                                118     126      +8
setup_heredoc                                        298     303      +5
expand_and_evaluate_arith                             69      74      +5
parse_stream                                        2371    2374      +3
builtin_umask                                        132     133      +1
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 7/0 up/down: 55/0)               Total: 55 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: remove useless ESC_GLOB_CHARS clears/resotres
Denys Vlasenko [Fri, 10 Sep 2010 08:12:34 +0000 (10:12 +0200)]
hush: remove useless ESC_GLOB_CHARS clears/resotres

function                                             old     new   delta
o_addQstr                                             43     165    +122
expand_on_ifs                                        210     189     -21
expand_vars_to_list                                 1122    1094     -28
o_addqblock                                          139       -    -139
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 1/2 up/down: 122/-188)          Total: -66 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: fix a bug where expand_one_var wasn't restoring 1st char of the encoded $var
Denys Vlasenko [Thu, 9 Sep 2010 12:38:46 +0000 (14:38 +0200)]
hush: fix a bug where expand_one_var wasn't restoring 1st char of the encoded $var

function                                             old     new   delta
expand_one_var                                      1515    1513      -2
expand_vars_to_list                                 1133    1122     -11

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: make parse_dollar flag quited status regardless of glob escaping status
Denys Vlasenko [Thu, 9 Sep 2010 12:04:57 +0000 (14:04 +0200)]
hush: make parse_dollar flag quited status regardless of glob escaping status

function                                             old     new   delta
parse_stream_dquoted                                 228     233      +5
parse_stream                                        2369    2371      +2
parse_dollar                                         730     717     -13
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/1 up/down: 7/-13)              Total: -6 bytes

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: simplification in parse_stream, parse_stream_dquoted
Denys Vlasenko [Thu, 9 Sep 2010 11:32:21 +0000 (13:32 +0200)]
hush: simplification in parse_stream, parse_stream_dquoted

function                                             old     new   delta
parse_stream                                        2354    2369     +15
parse_stream_dquoted                                 250     228     -22

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: simplify parse_stream_dquoted
Denys Vlasenko [Thu, 9 Sep 2010 10:58:19 +0000 (12:58 +0200)]
hush: simplify parse_stream_dquoted

function                                             old     new   delta
parse_stream_dquoted                                 303     250     -53

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: straighten out the logic in parse_stream
Denys Vlasenko [Thu, 9 Sep 2010 10:40:03 +0000 (12:40 +0200)]
hush: straighten out the logic in parse_stream

function                                             old     new   delta
parse_stream                                        2399    2354     -45

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agoAvoid side effects in putc(), which may be implemented as a macro
Dan Fandrich [Wed, 8 Sep 2010 06:38:28 +0000 (23:38 -0700)]
Avoid side effects in putc(), which may be implemented as a macro

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: eliminate redundant parameter of expand_vars_to_list()
Denys Vlasenko [Wed, 8 Sep 2010 11:58:55 +0000 (13:58 +0200)]
hush: eliminate redundant parameter of expand_vars_to_list()

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: replace flag bytes in struct o_string with bit flags
Denys Vlasenko [Wed, 8 Sep 2010 11:44:34 +0000 (13:44 +0200)]
hush: replace flag bytes in struct o_string with bit flags

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: remove unused enum typedef
Denys Vlasenko [Wed, 8 Sep 2010 11:33:26 +0000 (13:33 +0200)]
hush: remove unused enum typedef

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
14 years agohush: fix set -- q w e; (IFS='' echo "$*"; IFS=''; echo "$*"); echo "$*"
Denys Vlasenko [Wed, 8 Sep 2010 11:31:53 +0000 (13:31 +0200)]
hush: fix set -- q w e; (IFS='' echo "$*"; IFS=''; echo "$*"); echo "$*"

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>