Jon Trulson [Sun, 28 Dec 2014 02:52:37 +0000 (19:52 -0700)]
dtsession/SmUI: fix tainted var (CID 88216)
Jon Trulson [Sun, 28 Dec 2014 02:42:21 +0000 (19:42 -0700)]
dtsession/SmSave: use absolute path to rm in system()
Jon Trulson [Sun, 28 Dec 2014 02:33:03 +0000 (19:33 -0700)]
dtsession/SmSave: get rid of use of tempnam (CID 89359)
Jon Trulson [Sun, 28 Dec 2014 02:01:30 +0000 (19:01 -0700)]
dtsession/SmRestore: redo defaultCwd detection in StartClient() to be safer
Jon Trulson [Sun, 28 Dec 2014 01:19:55 +0000 (18:19 -0700)]
dtsession/SmRestore: fixup 8 coverity issues.
Jon Trulson [Sun, 28 Dec 2014 00:50:28 +0000 (17:50 -0700)]
dtsession/SmGlobals: re-add smGD.savePath to generated paths, was lost in mkstemp changes.
Jon Trulson [Sun, 28 Dec 2014 00:24:04 +0000 (17:24 -0700)]
dtsession/SmGlobals: unlink mkstemp generated files.
Jon Trulson [Sat, 27 Dec 2014 23:12:45 +0000 (16:12 -0700)]
dtsession/SmGlobals: use of tainted string (CID 89450)
Jon Trulson [Sat, 27 Dec 2014 23:06:23 +0000 (16:06 -0700)]
dtsession/SmLock: potential null deref (CID 87561, 87957, 88181)
Jon Trulson [Sat, 27 Dec 2014 22:54:55 +0000 (15:54 -0700)]
dtsession/SmDB: error handling issues (CID 87778, 87926)
Jon Trulson [Sat, 27 Dec 2014 22:50:29 +0000 (15:50 -0700)]
dtsession/SmCommun: fix bogus check (CID 89326)
Jon Trulson [Sat, 27 Dec 2014 22:42:04 +0000 (15:42 -0700)]
dtsession/SmGlobals: fixup 17 coverity issues.
Jon Trulson [Sat, 27 Dec 2014 21:25:52 +0000 (14:25 -0700)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Jon Trulson [Sat, 27 Dec 2014 21:12:29 +0000 (14:12 -0700)]
DtXinerama: no need to check unsigned int < 0 (CID:86121)
Peter Howkins [Sat, 27 Dec 2014 20:56:29 +0000 (20:56 +0000)]
dtlogin: resolve 8 compiler warnings.
Jon Trulson [Sat, 27 Dec 2014 20:01:26 +0000 (13:01 -0700)]
dtlogin/xdmcp: fixup many warnings and a possible declaration bug
Jon Trulson [Sat, 27 Dec 2014 01:10:07 +0000 (18:10 -0700)]
dtwm/WmFP: Coverity (memory corruption, moderate)
Jon Trulson [Sat, 27 Dec 2014 00:30:50 +0000 (17:30 -0700)]
dtwm/PopUpMenu: Coverity (memory corruption, moderate)
Jon Trulson [Sat, 27 Dec 2014 00:23:16 +0000 (17:23 -0700)]
dtsession: Coverity (memory corruption, moderate)
Jon Trulson [Sat, 27 Dec 2014 00:17:58 +0000 (17:17 -0700)]
dtscreen: Coverity (memory corruption, moderate)
Jon Trulson [Sat, 27 Dec 2014 00:17:06 +0000 (17:17 -0700)]
dtprintinfo: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 23:55:46 +0000 (16:55 -0700)]
dtlogin: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 23:23:54 +0000 (16:23 -0700)]
dtlogin: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 23:19:23 +0000 (16:19 -0700)]
dtcalc: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 23:17:43 +0000 (16:17 -0700)]
dtcalc: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 23:15:53 +0000 (16:15 -0700)]
tt/mini_isam: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 23:15:25 +0000 (16:15 -0700)]
tt/mini_isam: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 23:14:35 +0000 (16:14 -0700)]
ttsession: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 23:13:07 +0000 (16:13 -0700)]
ttauth: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 23:00:55 +0000 (16:00 -0700)]
csa: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 22:59:52 +0000 (15:59 -0700)]
DtTerm: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 22:58:50 +0000 (15:58 -0700)]
DtTerm: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 22:57:47 +0000 (15:57 -0700)]
DtSvc/DtUtil2: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 22:56:10 +0000 (15:56 -0700)]
DtSvc/DtUtil1: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 22:55:02 +0000 (15:55 -0700)]
DtSvc/DtEncap: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 22:54:08 +0000 (15:54 -0700)]
DtSvc: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 22:52:33 +0000 (15:52 -0700)]
DtSearch: remove bogus debug block
Jon Trulson [Fri, 26 Dec 2014 22:50:41 +0000 (15:50 -0700)]
DtHelp: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 22:49:43 +0000 (15:49 -0700)]
DtHelp: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 22:47:59 +0000 (15:47 -0700)]
imake: Coverity (memory corruption, moderate)
Jon Trulson [Fri, 26 Dec 2014 21:24:31 +0000 (14:24 -0700)]
dtsession: Coverity (memory corruption)
Jon Trulson [Fri, 26 Dec 2014 21:22:05 +0000 (14:22 -0700)]
dtsession: Coverity (memory corruption)
Jon Trulson [Fri, 26 Dec 2014 21:14:32 +0000 (14:14 -0700)]
dtappbuilder: Coverity (memory corruption)
Jon Trulson [Fri, 26 Dec 2014 21:12:10 +0000 (14:12 -0700)]
ttauth: Coverity (memory corruption)
Jon Trulson [Fri, 26 Dec 2014 21:10:01 +0000 (14:10 -0700)]
DtWidget: Coverity (memory corruption)
Jon Trulson [Fri, 26 Dec 2014 21:08:24 +0000 (14:08 -0700)]
DtTerm: Coverity (memory corruption)
Jon Trulson [Fri, 26 Dec 2014 21:06:26 +0000 (14:06 -0700)]
DtSvc: Coverity (memory corruption)
Jon Trulson [Fri, 26 Dec 2014 21:03:17 +0000 (14:03 -0700)]
DtSvc: Coverity (memory corruption)
Jon Trulson [Fri, 26 Dec 2014 20:42:23 +0000 (13:42 -0700)]
DtHelp: Coverity (memory corruption)
Matthew Howkins [Tue, 23 Dec 2014 21:13:17 +0000 (21:13 +0000)]
libtt: Fix 'Missing return statement' errors detected by static analysis
Peter Howkins [Tue, 23 Dec 2014 22:01:51 +0000 (22:01 +0000)]
dtlogin: Resolve 27 compiler warnings
Peter Howkins [Tue, 23 Dec 2014 20:05:01 +0000 (20:05 +0000)]
libDtWidget: Resolve some static analyser warnings
prevent usage of potentially unitialised variables.
Peter Howkins [Tue, 23 Dec 2014 17:49:11 +0000 (17:49 +0000)]
dtlogin: start to resolve static analysis warnings
Also convert some K&R function declarations to ansi
Ulrich Wilkens [Thu, 20 Nov 2014 01:11:47 +0000 (02:11 +0100)]
Fix FreeBSD 10.1 build
Jon Trulson [Tue, 28 Oct 2014 19:58:32 +0000 (13:58 -0600)]
it_IT.ISO8859-1/types/_common.dt.tmsg: Apply manual one-line patch
Ulrich Wilkens [Tue, 28 Oct 2014 18:46:43 +0000 (19:46 +0100)]
OpenIndiana and Solaris port
Ulrich Wilkens [Tue, 23 Sep 2014 21:16:35 +0000 (23:16 +0200)]
Resolve many build warnings
This patch fixes many warnings from the beginning of the build up to
and including the depend stage. Nearly all warnings should be gone
even with -Wall.
Jon Trulson [Sun, 21 Sep 2014 02:10:01 +0000 (20:10 -0600)]
dtappbuilder: abmf.c: more warnings killed
Jon Trulson [Sun, 21 Sep 2014 02:00:38 +0000 (20:00 -0600)]
dttypes: use regex on linux too.
Jon Trulson [Sun, 21 Sep 2014 01:10:19 +0000 (19:10 -0600)]
dthelp: fixup some warnings with special.h(s)
Jon Trulson [Sat, 20 Sep 2014 22:39:57 +0000 (16:39 -0600)]
dtappbuilder/dtcodegen: Fix up some warnings, remove use of sys_errlist[].
Removed all the cases of sys_errlist[], no one should be using that
today. Also, correct code generation so that declarations like
'Widget w = NULL; Pixmap p = NULL;' etc, aren't produced, which is
wrong. Use '0', not NULL for these.
This should also correct the 2 mis-definitions of Pixmap that commit
6a9327f2ab0bb09a681b86a45cf4a7bf9e9c28d4 attempted to fix in ttsnoop.
dtappbuilder still needs a lot of work.
Jon Trulson [Wed, 17 Sep 2014 00:09:21 +0000 (18:09 -0600)]
Revert "ttsnoop: NULL is not 0"
This reverts commit
6a9327f2ab0bb09a681b86a45cf4a7bf9e9c28d4.
The real fix for this (and other issues) needs to be done in dtcodegen.
Jon Trulson [Sun, 14 Sep 2014 20:25:55 +0000 (14:25 -0600)]
ttsnoop: NULL is not 0
This fix is a bit of a hack, I just moved the declarations into the
'user code' portion of main().
dtcodegen needs to be fixed so as not to generate this type of code in
the first place.
Jon Trulson [Sun, 14 Sep 2014 20:20:21 +0000 (14:20 -0600)]
dtmail: MotifCmds.C: NULL is not False
Jon Trulson [Fri, 12 Sep 2014 16:44:13 +0000 (10:44 -0600)]
Add new Dtlogo from Jeff Pierquet. Original renamed to TOGDtlogo.pm
Ulrich Wilkens [Thu, 11 Sep 2014 17:27:53 +0000 (19:27 +0200)]
Fix panel right click
Jon Trulson [Sun, 24 Aug 2014 22:48:07 +0000 (16:48 -0600)]
contrib/rc/freebsd: Add FreeBSD start script from Douglas Carmichael
Jon Trulson [Sun, 27 Jul 2014 22:48:19 +0000 (16:48 -0600)]
Update HISTORY file for 2.2.2 release
Jon Trulson [Sun, 27 Jul 2014 19:44:35 +0000 (13:44 -0600)]
Fixup UDB databases to fix a problem introduced with FreeBSD 10 patch.
The symbol hp-ux is used to tag files for installation on HP machines
in the UDB databases. To ensure the correct release streams are
defined, these symbols (hp-ux, linux, freebsd, etc) are undef'd so
that they are not evaluated in the context of db file generation by
the preprocessor.
A change in the FreeBSD 10 patch disabled this, possibly due to
'hp-ux' being an invalid cpp symbol on FreeBSD 10 machines, which now
use clang by default.
Undefining these cpp symbols is actually required, otherwise linux,
for example, is defined as a '1' in the generated databases, which
will not match the release stream name 'linux', therefore all of the
files tagged as 'linux' are never installed.
To fix this, revert the change made in the FreeBSD 10 patch, and
rename all occurances of 'hp-ux' to 'hpux' in the UDB files to avoid
the potential for cpp trouble when hp-ux is specified.
As a result of this change, 'hpux' is now the name of the release
stream for hp machines, not 'hp-ux'.
Ulrich Wilkens [Sun, 27 Jul 2014 14:48:57 +0000 (16:48 +0200)]
FreeBSD 10 clang port
Jon Trulson [Wed, 23 Jul 2014 22:16:57 +0000 (16:16 -0600)]
Version change to 2.2.2
Jon Trulson [Wed, 23 Jul 2014 00:19:22 +0000 (18:19 -0600)]
site.def: create new DtDocLocalesToBuild define
This would allow different locales to be specified for
programs/localization (DtLocalesToBuild) and doc/
(DtDocLocalesToBuild).
This would be useful for 'partial' translations like the Greek el_GR
locale, where message catalogs, actions, or other items are localized,
but documentation like the help system and dtinfo are not.
Jon Trulson [Tue, 22 Jul 2014 22:42:55 +0000 (16:42 -0600)]
el_GR _common.dt.tmsg: fix corrupted msg line at line 1763
Jon Trulson [Sun, 20 Jul 2014 00:33:12 +0000 (18:33 -0600)]
contrib/: add desktop2dt from Isaac Dunham
Jon Trulson [Sun, 20 Jul 2014 00:25:32 +0000 (18:25 -0600)]
Added additional info to vcal2xapia/README
Jon Trulson [Sun, 20 Jul 2014 00:22:39 +0000 (18:22 -0600)]
contrib/: add vcal2xapia from Edmond Orignac
Jon Trulson [Sat, 19 Jul 2014 23:48:38 +0000 (17:48 -0600)]
fr_FR.ISO8859-1/types/_common.dt.tmsg: Fix up a couple of backslash errors.
Reported by Edmond Orignac.
Eugene Doudine [Sat, 3 May 2014 18:02:50 +0000 (21:02 +0300)]
Fixes the bug, which caused dtterm to show stripes of wrong color between text lines when using fontsets that include fonts of slightly different heights.
The cause of the bug was that X*DrawImageString draws background
according to the extents of the given string, not to extents of the font set,
which determine terminal line height.
Now, when such a situation is detected, the background is cleared before
drawing the characters.
Eugene Doudine [Tue, 15 Apr 2014 15:39:43 +0000 (18:39 +0300)]
Fixes a small bug in grid registration: when an object is placed over another object (can be done manually) and then removed from there, the registration of the covered object is removed as well (that is it's cell is considered empty).
The patch converts desktop_grid[] from Boolean array into array of
counters of objects, which are placed on cells. When object is
placed on /removed from the screen the counter gets incremented/decremented.
Eugene Doudine [Tue, 15 Apr 2014 14:25:49 +0000 (17:25 +0300)]
Fixes several issues with grid registration of the dtwm panel on dtfile startup and on workspace addition:
The panel registration code rather stupidly assumed that display
size is always 1280x1024 pixels. Because of this, depending on screen
size, the panel could be registered somewhere in the center of the screen
or completely or partially beyond of it.
The panels were registered only on startup, not those, which were added
from UI.
The fix moves panel registration into separate routine and removes assumption
about display size. The fix yet is not complete since it still makes assumption
about panel's geometry: from dtfile there is still no way to find out
dinamically the size of panel and it's location.
Eugene Doudine [Tue, 15 Apr 2014 13:50:21 +0000 (16:50 +0300)]
Fixes the off-by-one bug in RegisterInGrid(), which caused dtfile's desktop icons on the right edge of the screen (if desktop width is not a multiple of icon with) to be registered on the next workspace or (in the case of the last workspace) beyond the desktop_grid array (possibly causing segfaults).
On small screens segfaults could be also triggered without any icons on dtfile
startup if dtwm panel (or part of it) was registered beyond the screen when
RegisterInGrid() was called by InitializeDesktopGrid().
The patch also makes grid registration work for large objects (larger than
2 cells in any direction, like dtwm panel or icon with long file name).
Previously only rectangle vertices were registered.
Jon Trulson [Sun, 6 Apr 2014 22:59:56 +0000 (16:59 -0600)]
dtappbuilder: bil_store.c: don't return local variables
Jon Trulson [Sun, 6 Apr 2014 22:55:45 +0000 (16:55 -0600)]
ttsnoop.C.src: NULL is not 0
Jon Trulson [Sun, 6 Apr 2014 22:54:31 +0000 (16:54 -0600)]
WMSaveSession.C: NULL is not 0
Jon Trulson [Sun, 6 Apr 2014 22:53:05 +0000 (16:53 -0600)]
SendMsgDialog.C: NULL is not 0
Jon Trulson [Sun, 6 Apr 2014 22:51:16 +0000 (16:51 -0600)]
RoamMenuWindow.C: NULL is not 0
Jon Trulson [Sun, 6 Apr 2014 22:49:24 +0000 (16:49 -0600)]
RoamInterruptibleCmd.C: NULL is not 0
Jon Trulson [Sun, 6 Apr 2014 22:48:40 +0000 (16:48 -0600)]
AttachArea.C: NULL is not 0, sprintf needs a format
Jon Trulson [Sun, 6 Apr 2014 22:46:09 +0000 (16:46 -0600)]
InterruptibleCmd.C, WorkingDialogManager.C: NULL is not 0
Jon Trulson [Sun, 6 Apr 2014 00:09:01 +0000 (18:09 -0600)]
dtsession: screensaver don't pass random attributes to XScreenSaverSetAttributes()
This should fix the "tiny window appearing in the screensavers"
problem.
Ulrich Wilkens [Tue, 1 Apr 2014 02:45:33 +0000 (04:45 +0200)]
Fix dtinfo search engine
Jon Trulson [Tue, 25 Mar 2014 01:54:37 +0000 (19:54 -0600)]
xtclient.c: fix debug statement regarding fd number
Jon Trulson [Tue, 25 Mar 2014 01:38:20 +0000 (19:38 -0600)]
linux.cf: with fds_bits fixes, stop using _POSIX_C_SOURCE=199309L and _XOPEN_SOURCE defines
Jon Trulson [Tue, 25 Mar 2014 01:37:09 +0000 (19:37 -0600)]
xtclient.c, spcd_event.c: stop referencing fds_bits directly
Jon Trulson [Tue, 25 Mar 2014 00:26:10 +0000 (18:26 -0600)]
cleanup: eliminate missing sentinel warnings
Jon Trulson [Mon, 24 Mar 2014 23:49:19 +0000 (17:49 -0600)]
dtcm/rfp.c: NULL is not 0
Jon Trulson [Mon, 24 Mar 2014 23:48:01 +0000 (17:48 -0600)]
dtcm/reminders.c: NULL is not 0
Jon Trulson [Mon, 24 Mar 2014 23:15:40 +0000 (17:15 -0600)]
linux: build with thread safety and REENTRANT enabled.
There was a check in linux.cf for the Linux libc version that didn't
work, since these were never set anywhere. Presumably current Xorg
imake sets these, but since we aren't using that... (yet)
As a result, the build assumed that thread-safe API's were not
supported. Setting the default libc major version to '6' allows the
proper build to take place. libc5 was never threadsafe and no one has
probably used it in over 10 years.
As a result, some earlier porting fixes that referenced '__fds_bits'
on linux systems had to be reverted as these are not valid in an MT
environment. They are also not neccessary when building in such an
environment, as the normal 'fds_bits' works fine.
This patch defintely needs testing on many linux systems.
Jon Trulson [Mon, 24 Mar 2014 22:34:58 +0000 (16:34 -0600)]
linux.cf: turn off writable strings warnings (write-strings)
There are about 1900 of them, if someone wants to go fix them, please
be my guest. :)
Jon Trulson [Mon, 24 Mar 2014 21:54:43 +0000 (15:54 -0600)]
cleanup: eliminate "implicit declaration" warnings.
Also fixed a potential core/memory corruption in dticon.