Jon Trulson [Thu, 12 Apr 2018 17:58:34 +0000 (11:58 -0600)]
dtfile/FileOp: CID 175228
Jon Trulson [Thu, 12 Apr 2018 17:45:38 +0000 (11:45 -0600)]
dtfile/FileDialog: CID 175220
Jon Trulson [Thu, 12 Apr 2018 17:30:59 +0000 (11:30 -0600)]
dtfile/SharedProcs: CID 175229
Jon Trulson [Thu, 12 Apr 2018 17:21:06 +0000 (11:21 -0600)]
dtfile/dtcopy/sharedFuncs: CID 175225
Jon Trulson [Thu, 12 Apr 2018 17:10:42 +0000 (11:10 -0600)]
dtfile/Desktop: CID 175219,175222,175223,175226,175227
Peter Howkins [Thu, 12 Apr 2018 00:38:02 +0000 (01:38 +0100)]
lidtsvc: coverity fixes
Peter Howkins [Wed, 11 Apr 2018 23:04:13 +0000 (00:04 +0100)]
libtt: resolve coverity issues related to double close()
Peter Howkins [Wed, 11 Apr 2018 22:37:34 +0000 (23:37 +0100)]
ttsnoop: resolve some compiler warnings
Jon Trulson [Wed, 11 Apr 2018 22:12:52 +0000 (16:12 -0600)]
dtfile/Encaps: CID 174844
Jon Trulson [Wed, 11 Apr 2018 22:06:20 +0000 (16:06 -0600)]
dtfile/Main: CID 89623
Jon Trulson [Wed, 11 Apr 2018 22:04:16 +0000 (16:04 -0600)]
dtfile/dtcopy/dosync: CID 89374
Jon Trulson [Wed, 11 Apr 2018 22:01:55 +0000 (16:01 -0600)]
dtfile/Menu: CID 89222
Jon Trulson [Wed, 11 Apr 2018 21:57:03 +0000 (15:57 -0600)]
dtfile/dtcopy/fsrtns: CID 88868,88128
Jon Trulson [Wed, 11 Apr 2018 21:50:43 +0000 (15:50 -0600)]
dtfile/Directory: CID 88835,89096,89446,89469,89498
Jon Trulson [Wed, 11 Apr 2018 21:41:51 +0000 (15:41 -0600)]
dtfile/Command: CID 88819
Jon Trulson [Wed, 11 Apr 2018 21:36:16 +0000 (15:36 -0600)]
linux.cf: Add -Wno-unused-result to C flags
There are several hundred of these and unless you intend to fix them,
they are just compiler noise. If someone does want to go back and
redo all of these, then they can just re-enable this warning.
Jon Trulson [Wed, 11 Apr 2018 21:27:54 +0000 (15:27 -0600)]
dtfile/FileOp: CID 88744,89337,89546
Jon Trulson [Wed, 11 Apr 2018 21:10:22 +0000 (15:10 -0600)]
dtfile/Trash: CID 88638,88815,89061,89614
Jon Trulson [Wed, 11 Apr 2018 20:46:57 +0000 (14:46 -0600)]
dtfile/Help: CID 88598
Jon Trulson [Wed, 11 Apr 2018 20:22:06 +0000 (14:22 -0600)]
dtfile/FileMgr: CID 88441,89025,174801
Jon Trulson [Wed, 11 Apr 2018 20:04:49 +0000 (14:04 -0600)]
dtfile/Find: CID 88258,87250
Jon Trulson [Wed, 11 Apr 2018 19:53:39 +0000 (13:53 -0600)]
dtfile/IconWindow: CID 88242,88702,89030
Jon Trulson [Wed, 11 Apr 2018 19:41:47 +0000 (13:41 -0600)]
dtfile/dtcopy/sharedFuncs: CID 88204,88291,88852,88861,88876
Jon Trulson [Wed, 11 Apr 2018 18:59:58 +0000 (12:59 -0600)]
dtfile/File: CID 88195,88595,88627,88794
Jon Trulson [Wed, 11 Apr 2018 18:46:57 +0000 (12:46 -0600)]
dtfile/SharedProcs: CID 88158,88337,89104,89118
Jon Trulson [Wed, 11 Apr 2018 18:29:07 +0000 (12:29 -0600)]
dtfile/FileDialog: CID 88141,88451,88658,89058
Jon Trulson [Wed, 11 Apr 2018 18:23:33 +0000 (12:23 -0600)]
dtfile/Desktop: CID 88133,88159,88339,88798,89331,89466
Jon Trulson [Wed, 11 Apr 2018 17:53:39 +0000 (11:53 -0600)]
dtfile/Prefs: CID 88095,88407,89162,89164,89283,89445
Peter Howkins [Wed, 11 Apr 2018 18:31:03 +0000 (19:31 +0100)]
libtt: Resolve coverity warnings
Peter Howkins [Wed, 11 Apr 2018 17:05:06 +0000 (18:05 +0100)]
dtpad: resove coverity issues
Jon Trulson [Wed, 11 Apr 2018 01:05:56 +0000 (19:05 -0600)]
Reimplement reverted commit 7fa35c to fix readlink() issues
Original implementation:
Commit:
7fa35cA
dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink
That commit caused dtfile to be unable to resolve symbolic links and
was later reverted. This commit reimplements the fixes correctly, and
should hopefully still resolve the coverity issues as well.
Peter Howkins [Wed, 11 Apr 2018 01:07:55 +0000 (02:07 +0100)]
dthelp: more coverity fixes
Jon Trulson [Tue, 10 Apr 2018 22:30:25 +0000 (16:30 -0600)]
dthelp/FormatUtils: fix coredump in dthelpgen due to free() of a bad address
Jon Trulson [Tue, 10 Apr 2018 19:28:55 +0000 (13:28 -0600)]
installCDE/linux: don't try to edit/modify /etc/inetd.conf if it does not exist
Modern systems use xinetd anyway, so this code just creates useless
junk and error messages on installation.
Jon Trulson [Tue, 10 Apr 2018 18:51:30 +0000 (12:51 -0600)]
Remove admin/man, *nameswitch; none of this is pertinent anymore
Jon Trulson [Tue, 10 Apr 2018 18:50:06 +0000 (12:50 -0600)]
Remove admin/bin; none of this is pertinent anymore
Jon Trulson [Tue, 10 Apr 2018 18:37:05 +0000 (12:37 -0600)]
Remove admin/BuildTools; none of this is pertinent anymore
Jon Trulson [Tue, 10 Apr 2018 18:32:28 +0000 (12:32 -0600)]
Remove admin/BuildTools/fnrclone/; obsolete junk
Jon Trulson [Thu, 5 Apr 2018 21:44:37 +0000 (15:44 -0600)]
Revert "dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink"
This reverts commit
7fa35c29c4559ce8b4ca4d4b5f0216a5305bb6ea.
Jon Trulson [Thu, 5 Apr 2018 19:28:04 +0000 (13:28 -0600)]
dtfile/sharedFuncs: CID 88085; resource leak
Jon Trulson [Thu, 5 Apr 2018 18:49:06 +0000 (12:49 -0600)]
dtfile: define MAX_PATH to PATH_MAX rather than 1024, also CID 87557
Peter Howkins [Thu, 5 Apr 2018 17:16:10 +0000 (18:16 +0100)]
dtinfo/dtinfogen: Fix segfault introduced by over zealously fixing coverity resource leak
Peter Howkins [Wed, 4 Apr 2018 21:42:06 +0000 (22:42 +0100)]
dtinfo: fix coverity issues related to null checks after dereference
Peter Howkins [Wed, 4 Apr 2018 21:07:10 +0000 (22:07 +0100)]
dtinfo: Fix coverity issues for resource leaks
Peter Howkins [Wed, 4 Apr 2018 19:37:13 +0000 (20:37 +0100)]
dtspcd: Cov 89547, 175089
Peter Howkins [Wed, 4 Apr 2018 19:16:24 +0000 (20:16 +0100)]
config/util: resolve coverity issues
Peter Howkins [Wed, 4 Apr 2018 18:48:23 +0000 (19:48 +0100)]
libdtterm: Resolve coverity issues
Peter Howkins [Wed, 4 Apr 2018 15:50:19 +0000 (16:50 +0100)]
dsdm: cov 86572, free mem in error condition
Peter Howkins [Wed, 4 Apr 2018 15:37:12 +0000 (16:37 +0100)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Peter Howkins [Wed, 4 Apr 2018 15:33:45 +0000 (16:33 +0100)]
dtwm: cov 175166, check for pointer
Jon Trulson [Wed, 4 Apr 2018 02:59:48 +0000 (20:59 -0600)]
dtfile/SharedProcs.c: rework coverity 174852 fix to unbreak dtfile
Jon Trulson [Tue, 3 Apr 2018 18:55:23 +0000 (12:55 -0600)]
fontaliases: use copy rather than symlink since bdftopcf can't handle those
bdftopcf specifically will not read symbolic links. This causes it to
fail when creating the programs/fontaliases/*/C/dtinfo.pcf.Z file and
subsequently, the fonts.dir file.
So, we add a new Imake macro: CopySourceFile(), to copy rather than
symlink the dtinfo.bdf file so these operations can complete
successfully. The dtinfo.bdf file is only 5KB, so there's very little
impact having an extra copy created during a build.
Jon Trulson [Tue, 3 Apr 2018 01:38:14 +0000 (19:38 -0600)]
Disable building of dtudcfonted and dtudcexch
This software has a variety of problems, like including renamed X11
header files, and other nuttery.
These programs also have a very limited use, I doubt most people even
know what they are for or will miss them.
This commit prevents them from being built and installed. If no-one
volunteers to get these into decent shape after the next release, they
will be removed from the repository.
Jon Trulson [Tue, 3 Apr 2018 00:43:14 +0000 (18:43 -0600)]
dtcm/dssw.c: fix typo
Jon Trulson [Tue, 3 Apr 2018 00:23:22 +0000 (18:23 -0600)]
dtudcfonted/gpftobdf.c: Coverity CID 175168; NULL deref
Jon Trulson [Tue, 3 Apr 2018 00:07:54 +0000 (18:07 -0600)]
dtcalc/ds_xlib.c: Coverity CID 175167; uninit value
Jon Trulson [Mon, 2 Apr 2018 22:55:34 +0000 (16:55 -0600)]
dtcm/dssw.c: Coverity CID 88672; dest buf too small
Jon Trulson [Mon, 2 Apr 2018 22:50:24 +0000 (16:50 -0600)]
dtsr/dtsrclean.c: Coverity CID 86876; dest buf too small
Jon Trulson [Mon, 2 Apr 2018 22:37:40 +0000 (16:37 -0600)]
libDtSearch/dtsrapi.c: Coverity CID 86857; dest buf too small
Peter Howkins [Mon, 2 Apr 2018 21:10:46 +0000 (22:10 +0100)]
libdtsvc: Resolve coverity warnings related to 'dereference before null check' related to free()
Peter Howkins [Mon, 2 Apr 2018 20:31:50 +0000 (21:31 +0100)]
libdtsvc: Compiler warning prevention
Peter Howkins [Mon, 2 Apr 2018 19:32:56 +0000 (20:32 +0100)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Peter Howkins [Mon, 2 Apr 2018 19:29:28 +0000 (20:29 +0100)]
dtmail: resolve 'deference before null check' errors related to if(!NULL) checks around free() calls
Jon Trulson [Mon, 2 Apr 2018 18:22:32 +0000 (12:22 -0600)]
dtwm/WmResource.c: remove errant ')' added in previous commit
Peter Howkins [Mon, 2 Apr 2018 17:08:40 +0000 (18:08 +0100)]
dtwm: Resolve coverity warnings
Jon Trulson [Mon, 2 Apr 2018 00:41:11 +0000 (18:41 -0600)]
dtcreate/fileio.c: coverity CID 175094; dref bef NULL
Jon Trulson [Mon, 2 Apr 2018 00:35:14 +0000 (18:35 -0600)]
dtcreate/CreateActionAppShell.c: coverity CID 175092; uninit ptr read
Jon Trulson [Mon, 2 Apr 2018 00:33:00 +0000 (18:33 -0600)]
dtcalc: remove MAX_PATH, use standard PATH_MAX
Jon Trulson [Mon, 2 Apr 2018 00:30:10 +0000 (18:30 -0600)]
dtcalc/ds_xlib.c: coverity CID 175093; wrong sizeof/bad free
Jon Trulson [Mon, 2 Apr 2018 00:06:10 +0000 (18:06 -0600)]
dtudcfonted/_faludcInf.c: coverity CIDs 175096,175092; uninit ptr read
Jon Trulson [Sun, 1 Apr 2018 20:38:05 +0000 (14:38 -0600)]
dtudcfonted/gpftobdf.c: coverity CIDs 87073,87008,87029,86919,86898,86715; uninit scalar
Jon Trulson [Sun, 1 Apr 2018 20:25:34 +0000 (14:25 -0600)]
libtt/isrepair.c: coverity CID 86705; uninit ptr read
Jon Trulson [Sun, 1 Apr 2018 20:21:57 +0000 (14:21 -0600)]
dtfile/File.c: coverity CID 88919; uninit array read
Jon Trulson [Sun, 1 Apr 2018 20:16:18 +0000 (14:16 -0600)]
dthelp/Initialize.c: coverity CID 89569; unbounded src buf
Jon Trulson [Sun, 1 Apr 2018 20:04:25 +0000 (14:04 -0600)]
dtcm/props.c: coverity CID 88573; unbounded src buf
Jon Trulson [Sun, 1 Apr 2018 19:54:22 +0000 (13:54 -0600)]
dtexec,DtSvc/MsgLog.c: coverity CID 89585; resource leak
Jon Trulson [Sun, 1 Apr 2018 19:45:48 +0000 (13:45 -0600)]
dtudcfonted/getfname.c: coverity CID 86392; insecure readlink
Jon Trulson [Sun, 1 Apr 2018 19:43:48 +0000 (13:43 -0600)]
dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink
Jon Trulson [Sun, 1 Apr 2018 01:12:32 +0000 (19:12 -0600)]
dtfile/SharedProcs.c: coverity CID 174852; int overflow
Jon Trulson [Sun, 1 Apr 2018 01:05:35 +0000 (19:05 -0600)]
libtt/tt_file_system.C: coverity CID 86024; array vs singlton
Jon Trulson [Sun, 1 Apr 2018 00:55:56 +0000 (18:55 -0600)]
dtmail/MsgScrollingList.C: coverity CID 87360; memset no effect
Jon Trulson [Sun, 1 Apr 2018 00:53:29 +0000 (18:53 -0600)]
dtinfo/OutlineListViewMotif.C: coverity CID 87754; memset truncated
Jon Trulson [Sun, 1 Apr 2018 00:36:22 +0000 (18:36 -0600)]
csa/match.c: coverity CID 87204; bad free; WTF
Jon Trulson [Sun, 1 Apr 2018 00:21:14 +0000 (18:21 -0600)]
dthelp/helpgen.c: coverity CID 175085; use after free
Jon Trulson [Sun, 1 Apr 2018 00:11:14 +0000 (18:11 -0600)]
dtfile/Help.c: coverity CID 88484; use after free
Jon Trulson [Sun, 1 Apr 2018 00:08:02 +0000 (18:08 -0600)]
libtt/process.c: coverity CID 87051; use after free
Jon Trulson [Sun, 1 Apr 2018 00:02:11 +0000 (18:02 -0600)]
libtt/db_server_svc.C: coverity CID 87060; string overflow
Jon Trulson [Sat, 31 Mar 2018 23:52:27 +0000 (17:52 -0600)]
dthelp/htag/malloc: coverity CID 86955; use after free
Jon Trulson [Sat, 31 Mar 2018 23:46:53 +0000 (17:46 -0600)]
dtmail/DtMailRc.C: coverity CID 88975; use after free
Jon Trulson [Sat, 31 Mar 2018 23:34:40 +0000 (17:34 -0600)]
dtfile/Main.c: coverity CID 89623; uninit var
Jon Trulson [Sat, 31 Mar 2018 23:25:35 +0000 (17:25 -0600)]
dtfile/sharedFuncs.c: coverity CID 88625; use after free
Jon Trulson [Sat, 31 Mar 2018 23:21:34 +0000 (17:21 -0600)]
dtfile/SharedProcs.c: coverity CID 89068; use after free
Jon Trulson [Sat, 31 Mar 2018 20:42:22 +0000 (14:42 -0600)]
dtinfo/MixedGen.C: coverity CID 89495; use after free
Jon Trulson [Sat, 31 Mar 2018 20:24:13 +0000 (14:24 -0600)]
dtspcd: coverity CID 174742; potential NULL derefs
Jon Trulson [Sat, 31 Mar 2018 20:17:36 +0000 (14:17 -0600)]
dtinfo/DtSR: coverity CID 88552; memory corruption
Jon Trulson [Sat, 31 Mar 2018 20:07:28 +0000 (14:07 -0600)]
dtinfo/TextParser.C: coverity CID 89054; mem corruption
Peter Howkins [Fri, 30 Mar 2018 23:15:05 +0000 (00:15 +0100)]
libDtWidget: Resolve some Coverity warnings
Peter Howkins [Fri, 30 Mar 2018 22:48:00 +0000 (23:48 +0100)]
dtpdmd: Resolve some coverity warnings
Peter Howkins [Fri, 30 Mar 2018 22:35:39 +0000 (23:35 +0100)]
dtcreate: Resolve coverity issues
Peter Howkins [Fri, 30 Mar 2018 21:09:47 +0000 (22:09 +0100)]
dtudcfonted: Resolve further coverity issues