oweals/cde.git
6 years agodtappbuilder: Further coverity, resource leaks, copy intofixed size buffer and derefe...
Peter Howkins [Sat, 28 Apr 2018 01:51:10 +0000 (02:51 +0100)]
dtappbuilder: Further coverity, resource leaks, copy intofixed size buffer and dereference before null checl

6 years agoSmall spelling fixes
chase [Tue, 24 Apr 2018 05:41:14 +0000 (22:41 -0700)]
Small spelling fixes

6 years agoRewrite csh scripts in sh, use sh instead of csh in scripts
chase [Tue, 24 Apr 2018 02:49:30 +0000 (19:49 -0700)]
Rewrite csh scripts in sh, use sh instead of csh in scripts

6 years agodtappbuilder: Fix for very wrong sized buffer
Peter Howkins [Thu, 26 Apr 2018 00:50:33 +0000 (01:50 +0100)]
dtappbuilder: Fix for very wrong sized buffer

6 years agodtappbuilder: Coverity fixes for mising return value and copy into fixed size buffer
Peter Howkins [Thu, 26 Apr 2018 00:36:02 +0000 (01:36 +0100)]
dtappbuilder: Coverity fixes for mising return value and copy into fixed size buffer

6 years agodtappbuilder: Resolve all compiler warnings
Peter Howkins [Tue, 24 Apr 2018 20:55:56 +0000 (21:55 +0100)]
dtappbuilder: Resolve all compiler warnings

6 years agodtlogin: Two additional coverity fixes
Peter Howkins [Tue, 24 Apr 2018 02:57:35 +0000 (03:57 +0100)]
dtlogin: Two additional coverity fixes

6 years agodtinfo: Extra fixes for previous believed fixed things (coverity)
Peter Howkins [Tue, 24 Apr 2018 02:25:54 +0000 (03:25 +0100)]
dtinfo: Extra fixes for previous believed fixed things (coverity)

6 years agodtsr: Coverity fixes for string buffer issues
Peter Howkins [Tue, 24 Apr 2018 02:03:06 +0000 (03:03 +0100)]
dtsr: Coverity fixes for string buffer issues

6 years agodtmail: Further Coverity fixes
Peter Howkins [Tue, 24 Apr 2018 01:38:56 +0000 (02:38 +0100)]
dtmail: Further Coverity fixes

6 years agolibtt: Fixes for Coverity fixes that I thought I'd already fixed.
Peter Howkins [Mon, 23 Apr 2018 23:05:56 +0000 (00:05 +0100)]
libtt: Fixes for Coverity fixes that I thought I'd already fixed.

6 years agodtpdm: Coverity 87632, 87664, 87923
Peter Howkins [Mon, 23 Apr 2018 02:43:48 +0000 (03:43 +0100)]
dtpdm: Coverity 87632, 87664, 87923

6 years agoMerge branch 'cde-fixups-1' of ssh://git.code.sf.net/p/cdesktopenv/code into cde...
Peter Howkins [Mon, 23 Apr 2018 01:21:30 +0000 (02:21 +0100)]
Merge branch 'cde-fixups-1' of ssh://git.code.sf.net/p/cdesktopenv/code into cde-fixups-1

6 years agodtinfo: Fix coverity warning related to using delete not delete []
Peter Howkins [Mon, 23 Apr 2018 01:20:23 +0000 (02:20 +0100)]
dtinfo: Fix coverity warning related to using delete not delete []

6 years agoMore spelling fixes
chase [Wed, 18 Apr 2018 01:10:17 +0000 (18:10 -0700)]
More spelling fixes

6 years agoFix various spelling errors
chase [Tue, 17 Apr 2018 12:25:38 +0000 (05:25 -0700)]
Fix various spelling errors

6 years agolibtt: Further coverity fixes
Peter Howkins [Fri, 20 Apr 2018 21:57:47 +0000 (22:57 +0100)]
libtt: Further coverity fixes

6 years agodtmail: resolve coverity warnings related to uninitialised members in C++ classes
Peter Howkins [Fri, 20 Apr 2018 01:36:24 +0000 (02:36 +0100)]
dtmail: resolve coverity warnings related to uninitialised members in C++ classes

6 years agonsgmls: resolve coverity warnings related to uninitialed members in C++ classes
Peter Howkins [Fri, 20 Apr 2018 00:00:01 +0000 (01:00 +0100)]
nsgmls: resolve coverity warnings related to uninitialed members in C++ classes

6 years agodtinfo: Resolve coverity warnings related to uninitialised members of classes
Peter Howkins [Thu, 19 Apr 2018 22:25:47 +0000 (23:25 +0100)]
dtinfo: Resolve coverity warnings related to uninitialised members of classes

6 years agolibtt: Coverity fixes related to uninitialised fields in classes.
Peter Howkins [Wed, 18 Apr 2018 00:28:03 +0000 (01:28 +0100)]
libtt: Coverity fixes related to uninitialised fields in classes.

6 years agovarious: You cannot use the destination of snprintf as one of the srcs, undefined
Peter Howkins [Sat, 14 Apr 2018 00:23:48 +0000 (01:23 +0100)]
various: You cannot use the destination of snprintf as one of the srcs, undefined

6 years agodtwm: Fix window menus caused by using destination as param to snprintf
Peter Howkins [Fri, 13 Apr 2018 23:32:03 +0000 (00:32 +0100)]
dtwm: Fix window menus caused by using destination as param to snprintf

6 years agodthelp: coverity fixes
Peter Howkins [Fri, 13 Apr 2018 19:26:23 +0000 (20:26 +0100)]
dthelp: coverity fixes

6 years agolibtt: More coverity fixes
Peter Howkins [Fri, 13 Apr 2018 18:08:50 +0000 (19:08 +0100)]
libtt: More coverity fixes

6 years agoEnable TIRPC support for Linux
Jon Trulson [Thu, 12 Apr 2018 00:48:53 +0000 (18:48 -0600)]
Enable TIRPC support for Linux

This is enabled by default.  To disable, add:

in the config/cf/site.def or host.def file.

You will need to have the libtirpc-dev package installed.

The benefit is that you will no longer need to run rpcbind in insecure
mode (the -i option).  There are other benefits we may be able to take
advantage of in the future, like supporting IPV6 for ToolTalk.

6 years agodtlogin: coverity fixes
Peter Howkins [Thu, 12 Apr 2018 23:54:04 +0000 (00:54 +0100)]
dtlogin: coverity fixes

6 years agodtterm: coverity fixes
Peter Howkins [Thu, 12 Apr 2018 20:29:49 +0000 (21:29 +0100)]
dtterm: coverity fixes

6 years agodtbuilder/Imakefile: fix clean target to remove dtbuilder executable
Jon Trulson [Thu, 12 Apr 2018 19:38:38 +0000 (13:38 -0600)]
dtbuilder/Imakefile: fix clean target to remove dtbuilder executable

6 years agodtfile/FileOp: CID 175228
Jon Trulson [Thu, 12 Apr 2018 17:58:34 +0000 (11:58 -0600)]
dtfile/FileOp: CID 175228

6 years agodtfile/FileDialog: CID 175220
Jon Trulson [Thu, 12 Apr 2018 17:45:38 +0000 (11:45 -0600)]
dtfile/FileDialog: CID 175220

6 years agodtfile/SharedProcs: CID 175229
Jon Trulson [Thu, 12 Apr 2018 17:30:59 +0000 (11:30 -0600)]
dtfile/SharedProcs: CID 175229

6 years agodtfile/dtcopy/sharedFuncs: CID 175225
Jon Trulson [Thu, 12 Apr 2018 17:21:06 +0000 (11:21 -0600)]
dtfile/dtcopy/sharedFuncs: CID 175225

6 years agodtfile/Desktop: CID 175219,175222,175223,175226,175227
Jon Trulson [Thu, 12 Apr 2018 17:10:42 +0000 (11:10 -0600)]
dtfile/Desktop: CID 175219,175222,175223,175226,175227

6 years agolidtsvc: coverity fixes
Peter Howkins [Thu, 12 Apr 2018 00:38:02 +0000 (01:38 +0100)]
lidtsvc: coverity fixes

6 years agolibtt: resolve coverity issues related to double close()
Peter Howkins [Wed, 11 Apr 2018 23:04:13 +0000 (00:04 +0100)]
libtt: resolve coverity issues related to double close()

6 years agottsnoop: resolve some compiler warnings
Peter Howkins [Wed, 11 Apr 2018 22:37:34 +0000 (23:37 +0100)]
ttsnoop: resolve some compiler warnings

6 years agodtfile/Encaps: CID 174844
Jon Trulson [Wed, 11 Apr 2018 22:12:52 +0000 (16:12 -0600)]
dtfile/Encaps: CID 174844

6 years agodtfile/Main: CID 89623
Jon Trulson [Wed, 11 Apr 2018 22:06:20 +0000 (16:06 -0600)]
dtfile/Main: CID 89623

6 years agodtfile/dtcopy/dosync: CID 89374
Jon Trulson [Wed, 11 Apr 2018 22:04:16 +0000 (16:04 -0600)]
dtfile/dtcopy/dosync: CID 89374

6 years agodtfile/Menu: CID 89222
Jon Trulson [Wed, 11 Apr 2018 22:01:55 +0000 (16:01 -0600)]
dtfile/Menu: CID 89222

6 years agodtfile/dtcopy/fsrtns: CID 88868,88128
Jon Trulson [Wed, 11 Apr 2018 21:57:03 +0000 (15:57 -0600)]
dtfile/dtcopy/fsrtns: CID 88868,88128

6 years agodtfile/Directory: CID 88835,89096,89446,89469,89498
Jon Trulson [Wed, 11 Apr 2018 21:50:43 +0000 (15:50 -0600)]
dtfile/Directory: CID 88835,89096,89446,89469,89498

6 years agodtfile/Command: CID 88819
Jon Trulson [Wed, 11 Apr 2018 21:41:51 +0000 (15:41 -0600)]
dtfile/Command: CID 88819

6 years agolinux.cf: Add -Wno-unused-result to C flags
Jon Trulson [Wed, 11 Apr 2018 21:36:16 +0000 (15:36 -0600)]
linux.cf: Add -Wno-unused-result to C flags

There are several hundred of these and unless you intend to fix them,
they are just compiler noise.  If someone does want to go back and
redo all of these, then they can just re-enable this warning.

6 years agodtfile/FileOp: CID 88744,89337,89546
Jon Trulson [Wed, 11 Apr 2018 21:27:54 +0000 (15:27 -0600)]
dtfile/FileOp: CID 88744,89337,89546

6 years agodtfile/Trash: CID 88638,88815,89061,89614
Jon Trulson [Wed, 11 Apr 2018 21:10:22 +0000 (15:10 -0600)]
dtfile/Trash: CID 88638,88815,89061,89614

6 years agodtfile/Help: CID 88598
Jon Trulson [Wed, 11 Apr 2018 20:46:57 +0000 (14:46 -0600)]
dtfile/Help: CID 88598

6 years agodtfile/FileMgr: CID 88441,89025,174801
Jon Trulson [Wed, 11 Apr 2018 20:22:06 +0000 (14:22 -0600)]
dtfile/FileMgr: CID 88441,89025,174801

6 years agodtfile/Find: CID 88258,87250
Jon Trulson [Wed, 11 Apr 2018 20:04:49 +0000 (14:04 -0600)]
dtfile/Find: CID 88258,87250

6 years agodtfile/IconWindow: CID 88242,88702,89030
Jon Trulson [Wed, 11 Apr 2018 19:53:39 +0000 (13:53 -0600)]
dtfile/IconWindow: CID 88242,88702,89030

6 years agodtfile/dtcopy/sharedFuncs: CID 88204,88291,88852,88861,88876
Jon Trulson [Wed, 11 Apr 2018 19:41:47 +0000 (13:41 -0600)]
dtfile/dtcopy/sharedFuncs: CID 88204,88291,88852,88861,88876

6 years agodtfile/File: CID 88195,88595,88627,88794
Jon Trulson [Wed, 11 Apr 2018 18:59:58 +0000 (12:59 -0600)]
dtfile/File: CID 88195,88595,88627,88794

6 years agodtfile/SharedProcs: CID 88158,88337,89104,89118
Jon Trulson [Wed, 11 Apr 2018 18:46:57 +0000 (12:46 -0600)]
dtfile/SharedProcs: CID 88158,88337,89104,89118

6 years agodtfile/FileDialog: CID 88141,88451,88658,89058
Jon Trulson [Wed, 11 Apr 2018 18:29:07 +0000 (12:29 -0600)]
dtfile/FileDialog: CID 88141,88451,88658,89058

6 years agodtfile/Desktop: CID 88133,88159,88339,88798,89331,89466
Jon Trulson [Wed, 11 Apr 2018 18:23:33 +0000 (12:23 -0600)]
dtfile/Desktop: CID 88133,88159,88339,88798,89331,89466

6 years agodtfile/Prefs: CID 88095,88407,89162,89164,89283,89445
Jon Trulson [Wed, 11 Apr 2018 17:53:39 +0000 (11:53 -0600)]
dtfile/Prefs: CID 88095,88407,89162,89164,89283,89445

6 years agolibtt: Resolve coverity warnings
Peter Howkins [Wed, 11 Apr 2018 18:31:03 +0000 (19:31 +0100)]
libtt: Resolve coverity warnings

6 years agodtpad: resove coverity issues
Peter Howkins [Wed, 11 Apr 2018 17:05:06 +0000 (18:05 +0100)]
dtpad: resove coverity issues

6 years agoReimplement reverted commit 7fa35c to fix readlink() issues
Jon Trulson [Wed, 11 Apr 2018 01:05:56 +0000 (19:05 -0600)]
Reimplement reverted commit 7fa35c to fix readlink() issues

Original implementation:

Commit: 7fa35cA
dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink

That commit caused dtfile to be unable to resolve symbolic links and
was later reverted.  This commit reimplements the fixes correctly, and
should hopefully still resolve the coverity issues as well.

6 years agodthelp: more coverity fixes
Peter Howkins [Wed, 11 Apr 2018 01:07:55 +0000 (02:07 +0100)]
dthelp: more coverity fixes

6 years agodthelp/FormatUtils: fix coredump in dthelpgen due to free() of a bad address
Jon Trulson [Tue, 10 Apr 2018 22:30:25 +0000 (16:30 -0600)]
dthelp/FormatUtils: fix coredump in dthelpgen due to free() of a bad address

6 years agoinstallCDE/linux: don't try to edit/modify /etc/inetd.conf if it does not exist
Jon Trulson [Tue, 10 Apr 2018 19:28:55 +0000 (13:28 -0600)]
installCDE/linux: don't try to edit/modify /etc/inetd.conf if it does not exist

Modern systems use xinetd anyway, so this code just creates useless
junk and error messages on installation.

6 years agoRemove admin/man, *nameswitch; none of this is pertinent anymore
Jon Trulson [Tue, 10 Apr 2018 18:51:30 +0000 (12:51 -0600)]
Remove admin/man, *nameswitch; none of this is pertinent anymore

6 years agoRemove admin/bin; none of this is pertinent anymore
Jon Trulson [Tue, 10 Apr 2018 18:50:06 +0000 (12:50 -0600)]
Remove admin/bin; none of this is pertinent anymore

6 years agoRemove admin/BuildTools; none of this is pertinent anymore
Jon Trulson [Tue, 10 Apr 2018 18:37:05 +0000 (12:37 -0600)]
Remove admin/BuildTools; none of this is pertinent anymore

6 years agoRemove admin/BuildTools/fnrclone/; obsolete junk
Jon Trulson [Tue, 10 Apr 2018 18:32:28 +0000 (12:32 -0600)]
Remove admin/BuildTools/fnrclone/; obsolete junk

6 years agoRevert "dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink"
Jon Trulson [Thu, 5 Apr 2018 21:44:37 +0000 (15:44 -0600)]
Revert "dtfile: coverity CIDs 88363,88405,89140,89612; insecure readlink"

This reverts commit 7fa35c29c4559ce8b4ca4d4b5f0216a5305bb6ea.

6 years agodtfile/sharedFuncs: CID 88085; resource leak
Jon Trulson [Thu, 5 Apr 2018 19:28:04 +0000 (13:28 -0600)]
dtfile/sharedFuncs: CID 88085; resource leak

6 years agodtfile: define MAX_PATH to PATH_MAX rather than 1024, also CID 87557
Jon Trulson [Thu, 5 Apr 2018 18:49:06 +0000 (12:49 -0600)]
dtfile: define MAX_PATH to PATH_MAX rather than 1024, also CID 87557

6 years agodtinfo/dtinfogen: Fix segfault introduced by over zealously fixing coverity resource...
Peter Howkins [Thu, 5 Apr 2018 17:16:10 +0000 (18:16 +0100)]
dtinfo/dtinfogen: Fix segfault introduced by over zealously fixing coverity resource leak

6 years agodtinfo: fix coverity issues related to null checks after dereference
Peter Howkins [Wed, 4 Apr 2018 21:42:06 +0000 (22:42 +0100)]
dtinfo: fix coverity issues related to null checks after dereference

6 years agodtinfo: Fix coverity issues for resource leaks
Peter Howkins [Wed, 4 Apr 2018 21:07:10 +0000 (22:07 +0100)]
dtinfo: Fix coverity issues for resource leaks

6 years agodtspcd: Cov 89547, 175089
Peter Howkins [Wed, 4 Apr 2018 19:37:13 +0000 (20:37 +0100)]
dtspcd: Cov 89547, 175089

6 years agoconfig/util: resolve coverity issues
Peter Howkins [Wed, 4 Apr 2018 19:16:24 +0000 (20:16 +0100)]
config/util: resolve coverity issues

6 years agolibdtterm: Resolve coverity issues
Peter Howkins [Wed, 4 Apr 2018 18:48:23 +0000 (19:48 +0100)]
libdtterm: Resolve coverity issues

6 years agodsdm: cov 86572, free mem in error condition
Peter Howkins [Wed, 4 Apr 2018 15:50:19 +0000 (16:50 +0100)]
dsdm: cov 86572, free mem in error condition

6 years agoMerge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Peter Howkins [Wed, 4 Apr 2018 15:37:12 +0000 (16:37 +0100)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code

6 years agodtwm: cov 175166, check for pointer
Peter Howkins [Wed, 4 Apr 2018 15:33:45 +0000 (16:33 +0100)]
dtwm: cov 175166, check for pointer

6 years agodtfile/SharedProcs.c: rework coverity 174852 fix to unbreak dtfile
Jon Trulson [Wed, 4 Apr 2018 02:59:48 +0000 (20:59 -0600)]
dtfile/SharedProcs.c: rework coverity 174852 fix to unbreak dtfile

6 years agofontaliases: use copy rather than symlink since bdftopcf can't handle those
Jon Trulson [Tue, 3 Apr 2018 18:55:23 +0000 (12:55 -0600)]
fontaliases: use copy rather than symlink since bdftopcf can't handle those

bdftopcf specifically will not read symbolic links.  This causes it to
fail when creating the programs/fontaliases/*/C/dtinfo.pcf.Z file and
subsequently, the fonts.dir file.

So, we add a new Imake macro: CopySourceFile(), to copy rather than
symlink the dtinfo.bdf file so these operations can complete
successfully.  The dtinfo.bdf file is only 5KB, so there's very little
impact having an extra copy created during a build.

6 years agoDisable building of dtudcfonted and dtudcexch
Jon Trulson [Tue, 3 Apr 2018 01:38:14 +0000 (19:38 -0600)]
Disable building of dtudcfonted and dtudcexch

This software has a variety of problems, like including renamed X11
header files, and other nuttery.

These programs also have a very limited use, I doubt most people even
know what they are for or will miss them.

This commit prevents them from being built and installed.  If no-one
volunteers to get these into decent shape after the next release, they
will be removed from the repository.

6 years agodtcm/dssw.c: fix typo
Jon Trulson [Tue, 3 Apr 2018 00:43:14 +0000 (18:43 -0600)]
dtcm/dssw.c: fix typo

6 years agodtudcfonted/gpftobdf.c: Coverity CID 175168; NULL deref
Jon Trulson [Tue, 3 Apr 2018 00:23:22 +0000 (18:23 -0600)]
dtudcfonted/gpftobdf.c: Coverity CID 175168; NULL deref

6 years agodtcalc/ds_xlib.c: Coverity CID 175167; uninit value
Jon Trulson [Tue, 3 Apr 2018 00:07:54 +0000 (18:07 -0600)]
dtcalc/ds_xlib.c: Coverity CID 175167; uninit value

6 years agodtcm/dssw.c: Coverity CID 88672; dest buf too small
Jon Trulson [Mon, 2 Apr 2018 22:55:34 +0000 (16:55 -0600)]
dtcm/dssw.c: Coverity CID 88672; dest buf too small

6 years agodtsr/dtsrclean.c: Coverity CID 86876; dest buf too small
Jon Trulson [Mon, 2 Apr 2018 22:50:24 +0000 (16:50 -0600)]
dtsr/dtsrclean.c: Coverity CID 86876; dest buf too small

6 years agolibDtSearch/dtsrapi.c: Coverity CID 86857; dest buf too small
Jon Trulson [Mon, 2 Apr 2018 22:37:40 +0000 (16:37 -0600)]
libDtSearch/dtsrapi.c: Coverity CID 86857; dest buf too small

6 years agolibdtsvc: Resolve coverity warnings related to 'dereference before null check' relate...
Peter Howkins [Mon, 2 Apr 2018 21:10:46 +0000 (22:10 +0100)]
libdtsvc: Resolve coverity warnings related to 'dereference before null check' related to free()

6 years agolibdtsvc: Compiler warning prevention
Peter Howkins [Mon, 2 Apr 2018 20:31:50 +0000 (21:31 +0100)]
libdtsvc: Compiler warning prevention

6 years agoMerge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Peter Howkins [Mon, 2 Apr 2018 19:32:56 +0000 (20:32 +0100)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code

6 years agodtmail: resolve 'deference before null check' errors related to if(!NULL) checks...
Peter Howkins [Mon, 2 Apr 2018 19:29:28 +0000 (20:29 +0100)]
dtmail: resolve 'deference before null check' errors related to if(!NULL) checks around free() calls

6 years agodtwm/WmResource.c: remove errant ')' added in previous commit
Jon Trulson [Mon, 2 Apr 2018 18:22:32 +0000 (12:22 -0600)]
dtwm/WmResource.c: remove errant ')' added in previous commit

6 years agodtwm: Resolve coverity warnings
Peter Howkins [Mon, 2 Apr 2018 17:08:40 +0000 (18:08 +0100)]
dtwm: Resolve coverity warnings

6 years agodtcreate/fileio.c: coverity CID 175094; dref bef NULL
Jon Trulson [Mon, 2 Apr 2018 00:41:11 +0000 (18:41 -0600)]
dtcreate/fileio.c: coverity CID 175094; dref bef NULL

6 years agodtcreate/CreateActionAppShell.c: coverity CID 175092; uninit ptr read
Jon Trulson [Mon, 2 Apr 2018 00:35:14 +0000 (18:35 -0600)]
dtcreate/CreateActionAppShell.c: coverity CID 175092; uninit ptr read

6 years agodtcalc: remove MAX_PATH, use standard PATH_MAX
Jon Trulson [Mon, 2 Apr 2018 00:33:00 +0000 (18:33 -0600)]
dtcalc: remove MAX_PATH, use standard PATH_MAX

6 years agodtcalc/ds_xlib.c: coverity CID 175093; wrong sizeof/bad free
Jon Trulson [Mon, 2 Apr 2018 00:30:10 +0000 (18:30 -0600)]
dtcalc/ds_xlib.c: coverity CID 175093; wrong sizeof/bad free

6 years agodtudcfonted/_faludcInf.c: coverity CIDs 175096,175092; uninit ptr read
Jon Trulson [Mon, 2 Apr 2018 00:06:10 +0000 (18:06 -0600)]
dtudcfonted/_faludcInf.c: coverity CIDs 175096,175092; uninit ptr read

6 years agodtudcfonted/gpftobdf.c: coverity CIDs 87073,87008,87029,86919,86898,86715; uninit...
Jon Trulson [Sun, 1 Apr 2018 20:38:05 +0000 (14:38 -0600)]
dtudcfonted/gpftobdf.c: coverity CIDs 87073,87008,87029,86919,86898,86715; uninit scalar