Rob Landley [Tue, 10 Jan 2006 06:19:56 +0000 (06:19 -0000)]
Don't return 0 when there's an error.
Rob Landley [Tue, 10 Jan 2006 05:30:28 +0000 (05:30 -0000)]
With -a, the jump to mount_it_now can skip the initialization of f, and
if we don't zero it after closing it we re-close a filehandle that isn't
open, and since this is a file _pointer_ it segfaults on a double free.
Yeah, subtle bug. I need to break this out into separate functions if I can
figure out how to avoid making the code larger while doing so. Part of
the general -a and -o remount work I need to do, but that's after 1.1.0...
Rob Landley [Tue, 10 Jan 2006 02:37:20 +0000 (02:37 -0000)]
Both atime and diratime should switch _off_ the corresponding no* flag.
Mike Frysinger [Tue, 10 Jan 2006 01:43:40 +0000 (01:43 -0000)]
upgrade ZyXEL from hall of shame to hall of [product] fame
"Vladimir N. Oleynik" [Mon, 9 Jan 2006 13:28:31 +0000 (13:28 -0000)]
removed a warning about an unused pargv in bb_getopt_ulflags. Noticed by Tito
Rob Landley [Mon, 9 Jan 2006 05:26:58 +0000 (05:26 -0000)]
Bug 112, return value of awk should be /256. In reality, we should probably
be using WEXITSTATUS(), but until I can figure out why the heck that would
want to do (*(int *) &(status)) on the value, I'm happy just fixing the bug we
actually see.
Rob Landley [Mon, 9 Jan 2006 03:45:43 +0000 (03:45 -0000)]
Fix bug 603: "chown :root thingy" should work now.
Rob Landley [Mon, 9 Jan 2006 03:07:44 +0000 (03:07 -0000)]
Bug 547: writing out the tar file header before we confirm we can actually
open and read from the file isn't something we can recover from after the
fact. Resequence things to check first, write second.
Rob Landley [Mon, 9 Jan 2006 01:07:24 +0000 (01:07 -0000)]
Minor cosmetic fix from Tito.
Rob Landley [Mon, 9 Jan 2006 00:54:46 +0000 (00:54 -0000)]
Why we didn't take a watchdog.c suggestion this time 'round, in case anybody
comes up with a fix...
Mike Frysinger [Sun, 8 Jan 2006 11:15:53 +0000 (11:15 -0000)]
declare const for fun
Mike Frysinger [Sun, 8 Jan 2006 11:15:34 +0000 (11:15 -0000)]
Tito writes:
Somehow while applying the bb_do_delay patch a change slipped
in libbb.h that broke compilation.
libbb.h Line 355
extern char bb_path_mtab_file[];
This conflicts with mtab_file.c
#if defined(CONFIG_FEATURE_MTAB_SUPPORT)
const char bb_path_mtab_file[] = "/etc/mtab";
#else
const char bb_path_mtab_file[] = "/proc/mounts";
#endif
Rob Landley [Fri, 6 Jan 2006 20:59:09 +0000 (20:59 -0000)]
patch from tito: consolidate delay functions as bb_do_delay()
Rob Landley [Fri, 6 Jan 2006 20:28:05 +0000 (20:28 -0000)]
Bug 624 wants quoted char support for printf, so you can do something like:
printf '%d\n' '"x"'
and have it print out 120. This is the smallest implementation I can think
of at the moment.
Rob Landley [Fri, 6 Jan 2006 18:22:05 +0000 (18:22 -0000)]
No, we _want_ the suid and sgid bits reverted by chown, for security reasons.
They mean something different when the user they're switching to is different,
so if you still want suid you reset it afterwards. This is a safety feature.
Bernhard Reutner-Fischer [Wed, 4 Jan 2006 13:35:09 +0000 (13:35 -0000)]
- better wording
Mike Frysinger [Wed, 4 Jan 2006 07:31:19 +0000 (07:31 -0000)]
use MAP_PRIVATE instead of MAP_SHARED for uClinux systems (see Bug 550)
Mike Frysinger [Wed, 4 Jan 2006 00:13:22 +0000 (00:13 -0000)]
Jason Schoon writes:
Here is a patch for kill that I posted long ago, but forgot about
until today. This allows kill to specify a negative process/group
(such as -1). The shell already had this fix applied by Vodz some
time ago.
Mike Frysinger [Wed, 4 Jan 2006 00:11:26 +0000 (00:11 -0000)]
import nios2 support from microtronix
Mike Frysinger [Wed, 4 Jan 2006 00:04:08 +0000 (00:04 -0000)]
make mount usage a bit more terse
Mike Frysinger [Tue, 3 Jan 2006 23:59:17 +0000 (23:59 -0000)]
just use bb_xfopen()
Mike Frysinger [Tue, 3 Jan 2006 23:59:01 +0000 (23:59 -0000)]
fix comment documentation
Bernhard Reutner-Fischer [Thu, 29 Dec 2005 21:17:05 +0000 (21:17 -0000)]
- silence warning about unused param
needs revisit later on like many others to use ATTRIBUTE_UNUSED from platform.h
Bernhard Reutner-Fischer [Thu, 29 Dec 2005 16:53:47 +0000 (16:53 -0000)]
- use HOSTCC instead of a hardcoded cc
"Vladimir N. Oleynik" [Mon, 26 Dec 2005 17:26:59 +0000 (17:26 -0000)]
remove buffer overflow by Erik and decodeString problem by Glenn, add error check of decodeString as Apache
Rob Landley [Wed, 21 Dec 2005 17:00:25 +0000 (17:00 -0000)]
When you went "losetup -d /dev/loop0 /dev/loop1" the error message was strange.
Rob Landley [Wed, 21 Dec 2005 16:53:57 +0000 (16:53 -0000)]
Trying to losetup a device as a regular user shouldn't result in an endless
loop, and the error messages should display correctly now.
Rob Landley [Wed, 21 Dec 2005 16:33:41 +0000 (16:33 -0000)]
Second attempt to simplify the login menu. Shadow password stuff at the top,
with no dependencies (since depending on 9 of the 13 apps in the menu gets
a bit silly). And fix my attempt to make internal shadow password support
automatically depend on internal password support plus shadow password
support.
Bernhard Reutner-Fischer [Wed, 21 Dec 2005 15:07:30 +0000 (15:07 -0000)]
- fix check for group and user, remove some whitespace while at it.
Rob Landley [Tue, 20 Dec 2005 17:25:51 +0000 (17:25 -0000)]
Fix chroot, leave console alone if -c not specified, and yank debug code.
(I still haven't set up a test environment to confirm this works...)
Rob Landley [Tue, 20 Dec 2005 17:18:01 +0000 (17:18 -0000)]
Some minor cleanups/bugfixes split off from the big remount work:
Shorten GPL boilerplate.
Enabling FEATURE_CLEAN_UP broke things in two places.
Move the NFS with uClibc check to nfsmount.c
Rob Landley [Tue, 20 Dec 2005 15:25:25 +0000 (15:25 -0000)]
Shadow password support went beyond the dependency event horizon, just make
it an independent menu. And make internal shadow password support a subset
of the other internal password function support.
Rob Landley [Tue, 20 Dec 2005 15:23:20 +0000 (15:23 -0000)]
Actually, static buffers look like _this_...
"Vladimir N. Oleynik" [Tue, 20 Dec 2005 11:02:54 +0000 (11:02 -0000)]
remove debug feature for production
Rob Landley [Mon, 19 Dec 2005 16:30:33 +0000 (16:30 -0000)]
Make a few warnings go away.
Rob Landley [Mon, 19 Dec 2005 16:29:19 +0000 (16:29 -0000)]
Do an svn log -v, the information in this changelog is stunningly
obsolete.
Rob Landley [Mon, 19 Dec 2005 02:52:48 +0000 (02:52 -0000)]
Shadow password support involves vlock too.
Rob Landley [Mon, 19 Dec 2005 02:50:10 +0000 (02:50 -0000)]
Patch from Tito to make vlock much smaller.
Rob Landley [Sun, 18 Dec 2005 20:34:41 +0000 (20:34 -0000)]
strncmp isn't automatically superior to strcmp. Especially when it isn't
used right.
Rob Landley [Sat, 17 Dec 2005 10:54:17 +0000 (10:54 -0000)]
Sigh. Left the debug path in. Fixed.
Rob Landley [Sat, 17 Dec 2005 10:52:30 +0000 (10:52 -0000)]
Added /etc/mdev.conf support. Adds about 1.9k to mdev.
Rob Landley [Fri, 16 Dec 2005 21:33:10 +0000 (21:33 -0000)]
Bug 601: When we fork an archiver and feed stuff to it through a pipe, if
we don't close the pipe the child process won't exit, and we'll hang in
waitpid().
Rob Landley [Fri, 16 Dec 2005 08:03:34 +0000 (08:03 -0000)]
Ahem. Vladimir checked in a different fix bug didn't close out the bug.
Reverting...
Rob Landley [Fri, 16 Dec 2005 08:02:11 +0000 (08:02 -0000)]
Less would segfault if it had no tty. (Bug 600.)
Rob Landley [Fri, 16 Dec 2005 06:18:06 +0000 (06:18 -0000)]
I screwed up the last commit: if dt is null when ENABLE_MULTIPLE_OPTIONS is
off, we'd dereference the null. Oops.
Rob Landley [Fri, 16 Dec 2005 06:12:46 +0000 (06:12 -0000)]
Stephane Billiart said:
the attached patch makes applet list in busybox.links
correctly include tr and watchdog.
Currently, they don't appear because they are prefixed
with ENABLE_ in include/applets.h
"Vladimir N. Oleynik" [Thu, 15 Dec 2005 12:01:49 +0000 (12:01 -0000)]
sync license from mainstream
"Vladimir N. Oleynik" [Thu, 15 Dec 2005 11:53:22 +0000 (11:53 -0000)]
fopen(TTY...) to bb_xfopen(), close bug 600
Bernhard Reutner-Fischer [Thu, 15 Dec 2005 11:47:16 +0000 (11:47 -0000)]
- Stephane Billiart writes:
Fix the compilation of head and tail.
thanks!
Bernhard Reutner-Fischer [Thu, 15 Dec 2005 11:44:31 +0000 (11:44 -0000)]
- remove duplicate entry for switch_root
Rob Landley [Thu, 15 Dec 2005 08:04:17 +0000 (08:04 -0000)]
Add a fflush(stdout).
Rob Landley [Thu, 15 Dec 2005 07:42:13 +0000 (07:42 -0000)]
Better use of the ENABLE guards.
Rob Landley [Thu, 15 Dec 2005 07:25:54 +0000 (07:25 -0000)]
The rest of Yann E. Morin's install revamp.
Rob Landley [Thu, 15 Dec 2005 06:51:52 +0000 (06:51 -0000)]
Eliminate unnecessary allocation from md5sum that was leaked without ever being used.
Rob Landley [Thu, 15 Dec 2005 05:42:55 +0000 (05:42 -0000)]
Fix -g and -p options. Patch from Traceman. (I don't know who that is,
it's the darn bug generator again.)
Rob Landley [Thu, 15 Dec 2005 05:29:48 +0000 (05:29 -0000)]
Patch from dlively (whoever that is, see bug 591) to fix
"ip link set <dev> addr".
Bernhard Reutner-Fischer [Wed, 14 Dec 2005 14:13:15 +0000 (14:13 -0000)]
- several functions depend on IPv4 or IPv6 od IPX support.
removes warning about unused code for allbareconfig.
Bernhard Reutner-Fischer [Wed, 14 Dec 2005 08:32:44 +0000 (08:32 -0000)]
- remove warning (thanks Yann E. MORIN) and switch to ENABLE_
- typo: s/begining/beginning/g
"Vladimir N. Oleynik" [Tue, 13 Dec 2005 13:24:23 +0000 (13:24 -0000)]
remove sigsetmask, noticed by Bernhard
Bernhard Reutner-Fischer [Tue, 13 Dec 2005 11:52:46 +0000 (11:52 -0000)]
- check if CC supports -funsigned-char
- add CC_MAJOR and CC_MINOR variables. (gcc centric for now)
Bernhard Reutner-Fischer [Tue, 13 Dec 2005 10:48:45 +0000 (10:48 -0000)]
- wrap label GET_COUNT in #if ENABLE_FEATURE_FANCY_applet to avoid warning
about unused label.
Bernhard Reutner-Fischer [Tue, 13 Dec 2005 10:28:25 +0000 (10:28 -0000)]
- do away with superfluous keyword.
"Vladimir N. Oleynik" [Tue, 13 Dec 2005 08:44:41 +0000 (08:44 -0000)]
remove strange bloat dup2() usage, sync this code with mainstream login-utils, size reduce
Rob Landley [Tue, 13 Dec 2005 08:21:33 +0000 (08:21 -0000)]
Nothing to see here. Move along.
Not buying it, eh?
I know I said new features before 1.1, but, well... (I was weak!)
The config file and hotplug modes aren't implemented yet. Might take a stab at
those tomorrow. (I _should_ go back to focusing on the bug triage list.)
Rob Landley [Tue, 13 Dec 2005 04:06:22 +0000 (04:06 -0000)]
Minor fix: if(CONFIG) breaks the build when that CONFIG is disabled, it has
to be if(ENABLE). (Make allbareconfig is a good testing thing.)
Rob Landley [Mon, 12 Dec 2005 19:38:44 +0000 (19:38 -0000)]
Patch from Yann E. Morin, something to do with bugs 276 and 272.
Bernhard Reutner-Fischer [Mon, 12 Dec 2005 11:20:39 +0000 (11:20 -0000)]
- typo: s/sucess/success/g
What's up with loginutils/su.c line 42: "SYSLOG_SUCESS" ? Please have a look..
Bernhard Reutner-Fischer [Mon, 12 Dec 2005 10:21:35 +0000 (10:21 -0000)]
- fix zcip for IMA compile mode.
rename usage() to zcip_usage, make struct arp_packet static. This applet is
not ISO C89 compatible due to the use of C99-style comments ("c++ comments).
Rob Landley [Mon, 12 Dec 2005 07:04:59 +0000 (07:04 -0000)]
Flush output to log promptly (bug 389).
Rob Landley [Mon, 12 Dec 2005 07:02:15 +0000 (07:02 -0000)]
Flush input when prompting for a password (bug 373).
Rob Landley [Mon, 12 Dec 2005 06:58:53 +0000 (06:58 -0000)]
Bug 310: be consistent about stat/lstat and chown/lchown to avoid accidentally
modifying permissions or ownership when twiddling symlinks.
Rob Landley [Mon, 12 Dec 2005 06:52:45 +0000 (06:52 -0000)]
Uninitialized variable causing intermittent syntax errors (bug 449).
Rob Landley [Mon, 12 Dec 2005 06:49:33 +0000 (06:49 -0000)]
printf() arguments shouldn't be passed straight from user supplied data.
(Security thingy.)
Rob Landley [Mon, 12 Dec 2005 04:28:17 +0000 (04:28 -0000)]
Change CONFIG_MODPROBE_MULTIPOLE_OPTIONS to
CONFIG_FEATURE_MODPROBE_MULTIPLE_OPTIONS.
Rob Landley [Sun, 11 Dec 2005 20:20:05 +0000 (20:20 -0000)]
Patch from Yann E. Morin to reorganize module config options.
Rob Landley [Sun, 11 Dec 2005 20:14:12 +0000 (20:14 -0000)]
Make insmod quiet by default (patch from Yann E. Morin).
Rob Landley [Sun, 11 Dec 2005 20:12:24 +0000 (20:12 -0000)]
Yann E. Morin's update to modprobe usage.
Rob Landley [Sun, 11 Dec 2005 19:46:50 +0000 (19:46 -0000)]
Patch from Yann E. Morin to make rmmod report failure properly.
Glenn L McGrath [Sun, 11 Dec 2005 03:09:05 +0000 (03:09 -0000)]
Add build options to control SuS compatability, allows numeric
option handling to be disabled.
Defaults to enabled, so no changes in default behaviour
Bernhard Reutner-Fischer [Sat, 10 Dec 2005 20:13:54 +0000 (20:13 -0000)]
- remove unused variable have_read_stdin
- use FLAG_WIDTH
Paul Fox [Thu, 8 Dec 2005 18:48:20 +0000 (18:48 -0000)]
avoid mixed declarations, to support older compilers just a little longer.
Rob Landley [Wed, 7 Dec 2005 23:17:28 +0000 (23:17 -0000)]
Macro was wrong, name(void) vs name(x), and apparently gcc 2.95 cares about
matching up macro arguments even when the macro substitutes to nothing...
Rob Landley [Wed, 7 Dec 2005 22:45:28 +0000 (22:45 -0000)]
uClibc can't handle anonymous MAP_SHARED. Since we're treating it as
read only data anyway, MAP_PRIVATE shouldn't make a major difference.
Rob Landley [Tue, 6 Dec 2005 22:48:29 +0000 (22:48 -0000)]
Tito is using broken kernel headers that pollute the namespace with every
CONFIG_ symbol in the kernel, and this clashes with busybox's CONFIG_TR
and CONFIG_WATCHDOG, causing applets.h to barf if they're not switched
on (since the broken headers don't affect kconfig or the makefiles).
Since such broken kernel headers are common enough to crop up every few
months, a simple work around is to move TR and WATCHDOG from CONFIG_
to ENABLE_ early.
"Vladimir N. Oleynik" [Tue, 6 Dec 2005 12:20:57 +0000 (12:20 -0000)]
reduce 3 warning if compile with -W
"Vladimir N. Oleynik" [Tue, 6 Dec 2005 12:00:39 +0000 (12:00 -0000)]
restore compare_string_array new interface (make broken by landley)
Rob Landley [Fri, 2 Dec 2005 18:27:39 +0000 (18:27 -0000)]
Install links patch from Yann E. Morin. (Another thing hanging around in my
tree forever. Tweaked the docs a bit.)
Rob Landley [Fri, 2 Dec 2005 17:57:23 +0000 (17:57 -0000)]
If we really _need_ an #ifdef like this, then we should be using the libbb
getopt infrastructure instead.
Rob Landley [Fri, 2 Dec 2005 17:55:45 +0000 (17:55 -0000)]
Another cleanup patch that's been in my tree for a while. Again I think it's
originally from Bernhard Fischer...
Rob Landley [Fri, 2 Dec 2005 17:54:01 +0000 (17:54 -0000)]
A cleanup patch I've had lying around in my tree for a while, I think it
was from Bernhard Fischer?
"Vladimir N. Oleynik" [Fri, 2 Dec 2005 10:10:28 +0000 (10:10 -0000)]
reduce signedness warning
"Vladimir N. Oleynik" [Fri, 2 Dec 2005 10:06:04 +0000 (10:06 -0000)]
reduce signedness warning
"Vladimir N. Oleynik" [Fri, 2 Dec 2005 09:46:04 +0000 (09:46 -0000)]
remove warnings if compile with -W, use ENABLE_FEATURE vs CONFIG_FEATURE
Rob Landley [Thu, 1 Dec 2005 17:01:43 +0000 (17:01 -0000)]
Make char default to "unsigned" on all platforms so we have a consistent base
to deal with all the new gcc 4.0.2 warnings from.
Rob Landley [Tue, 29 Nov 2005 23:47:10 +0000 (23:47 -0000)]
Fix losetup so that it A) actually works again, B) has much better error
messages, C) can show the current association (if any) when called
with only one argument. Update the documentation a lot too.
Remind me to add a test suite for this thing. I think I've figured out
how to handle root-only testsuites...
"Vladimir N. Oleynik" [Tue, 29 Nov 2005 12:32:33 +0000 (12:32 -0000)]
getopt -> getopt_ulflags. noticed by Rob Sullivan
Mike Frysinger [Tue, 29 Nov 2005 02:53:52 +0000 (02:53 -0000)]
update license
Mike Frysinger [Tue, 29 Nov 2005 02:52:25 +0000 (02:52 -0000)]
ShaneAnderson writes in Bug 565:
need to include .config file before setting CROSS otherwise
TARGET_ARCH isnt set properly
Paul Fox [Mon, 28 Nov 2005 21:06:00 +0000 (21:06 -0000)]
add "-C" format to hexdump
fixes bug #113 and satisfies a personal need at the same time.
output compares identically to util-linux version. (with
exception of whitespace differences on last lines of output with
non-uniform length, which are neither fixed nor worsened by this
change.)
Paul Fox [Mon, 28 Nov 2005 18:07:53 +0000 (18:07 -0000)]
fix bug #474:
0000474: vi crashes often
problem was that the buffer used for "." command ("last_modifying_cmd")
wasn't being maintined correctly -- the recording code was walking back
over the front of that buffer when a repeatable insert command
included backspacing (e.g. "i\b\b\bfoo"). the fix is to simply
record the backspaces along with the rest of the command.
also, cleaned up start_new_cmd_q() slightly.