Dr. Stephen Henson [Thu, 31 Jan 2013 14:14:25 +0000 (14:14 +0000)]
The cbc functions shouldn't be inside #ifdef OPENSSL_NO_TLSEXT
Ben Laurie [Mon, 28 Jan 2013 17:34:33 +0000 (17:34 +0000)]
Update DTLS code to match CBC decoding in TLS.
This change updates the DTLS code to match the constant-time CBC
behaviour in the TLS.
(cherry picked from commit
9f27de170d1b7bef3d46d41382dc4dafde8b3900)
(cherry picked from commit
5e4ca556e970edb8a7f364fcb6ee6818a965a60b)
Conflicts:
ssl/d1_enc.c
ssl/d1_pkt.c
ssl/s3_pkt.c
Ben Laurie [Mon, 28 Jan 2013 17:33:18 +0000 (17:33 +0000)]
Don't crash when processing a zero-length, TLS >= 1.1 record.
The previous CBC patch was bugged in that there was a path through enc()
in s3_pkt.c/d1_pkt.c which didn't set orig_len. orig_len would be left
at the previous value which could suggest that the packet was a
sufficient length when it wasn't.
(cherry picked from commit
6cb19b7681f600b2f165e4adc57547b097b475fd)
(cherry picked from commit
2c948c1bb218f4ae126e14fd3453d42c62b93235)
Conflicts:
ssl/s3_enc.c
Ben Laurie [Wed, 30 Jan 2013 16:56:30 +0000 (16:56 +0000)]
Fixups.
Ben Laurie [Mon, 28 Jan 2013 18:24:55 +0000 (18:24 +0000)]
Oops. Add missing file.
(cherry picked from commit
014265eb02e26f35c8db58e2ccbf100b0b2f0072)
(cherry picked from commit
7721c53e5e9fe4c90be420d7613559935a96a4fb)
Ben Laurie [Mon, 28 Jan 2013 17:31:49 +0000 (17:31 +0000)]
Make CBC decoding constant time.
This patch makes the decoding of SSLv3 and TLS CBC records constant
time. Without this, a timing side-channel can be used to build a padding
oracle and mount Vaudenay's attack.
This patch also disables the stitched AESNI+SHA mode pending a similar
fix to that code.
In order to be easy to backport, this change is implemented in ssl/,
rather than as a generic AEAD mode. In the future this should be changed
around so that HMAC isn't in ssl/, but crypto/ as FIPS expects.
(cherry picked from commit
e130841bccfc0bb9da254dc84e23bc6a1c78a64e)
Conflicts:
crypto/evp/c_allc.c
ssl/ssl_algs.c
ssl/ssl_locl.h
ssl/t1_enc.c
(cherry picked from commit
3622239826698a0e534dcf0473204c724bb9b4b4)
Conflicts:
ssl/d1_enc.c
ssl/s3_enc.c
ssl/s3_pkt.c
ssl/ssl3.h
ssl/ssl_algs.c
ssl/t1_enc.c
Andy Polyakov [Sat, 19 Jan 2013 12:20:21 +0000 (13:20 +0100)]
.gitignore adjustments
Ben Laurie [Mon, 28 Jan 2013 17:30:38 +0000 (17:30 +0000)]
Add and use a constant-time memcmp.
This change adds CRYPTO_memcmp, which compares two vectors of bytes in
an amount of time that's independent of their contents. It also changes
several MAC compares in the code to use this over the standard memcmp,
which may leak information about the size of a matching prefix.
(cherry picked from commit
2ee798880a246d648ecddadc5b91367bee4a5d98)
Conflicts:
crypto/crypto.h
ssl/t1_lib.c
(cherry picked from commit
dc406b59f3169fe191e58906df08dce97edb727c)
Conflicts:
crypto/crypto.h
ssl/d1_pkt.c
ssl/s3_pkt.c
Ben Laurie [Wed, 30 Jan 2013 15:40:23 +0000 (15:40 +0000)]
Add target so I can build.
Dr. Stephen Henson [Thu, 24 Jan 2013 13:30:42 +0000 (13:30 +0000)]
Don't try and verify signatures if key is NULL (CVE-2013-0166)
Add additional check to catch this in ASN1_item_verify too.
Dr. Stephen Henson [Wed, 23 Jan 2013 01:04:36 +0000 (01:04 +0000)]
Don't include comp.h in cmd_cd.c if OPENSSL_NO_COMP set
Dr. Stephen Henson [Sun, 20 Jan 2013 01:16:25 +0000 (01:16 +0000)]
Don't include comp.h if no-comp set.
Dr. Stephen Henson [Fri, 11 Jan 2013 23:21:19 +0000 (23:21 +0000)]
Add .gitignore
Dr. Stephen Henson [Mon, 10 Dec 2012 16:45:39 +0000 (16:45 +0000)]
PR: 2888
Reported by: Daniel Black <daniel.black@openquery.com>
Support renewing session tickets (backport from HEAD).
Dr. Stephen Henson [Tue, 4 Dec 2012 17:26:36 +0000 (17:26 +0000)]
check mval for NULL too
Dr. Stephen Henson [Mon, 3 Dec 2012 16:33:54 +0000 (16:33 +0000)]
fix leak
Dr. Stephen Henson [Thu, 29 Nov 2012 19:16:01 +0000 (19:16 +0000)]
PR: 2803
Submitted by: jean-etienne.schwartz@bull.net
In OCSP_basic_varify return an error if X509_STORE_CTX_init fails.
Dr. Stephen Henson [Wed, 21 Nov 2012 14:01:38 +0000 (14:01 +0000)]
PR: 2908
Submitted by: Dmitry Belyavsky <beldmit@gmail.com>
Fix DH double free if parameter generation fails.
Dr. Stephen Henson [Mon, 19 Nov 2012 20:07:23 +0000 (20:07 +0000)]
correct docs
Dr. Stephen Henson [Sun, 18 Nov 2012 15:20:40 +0000 (15:20 +0000)]
PR: 2880
Submitted by: "Florian Rüchel" <florian.ruechel@ruhr-uni-bochum.de>
Correctly handle local machine keys in the capi ENGINE.
Andy Polyakov [Tue, 16 Oct 2012 08:22:55 +0000 (08:22 +0000)]
aix[64]-cc: get MT support right [from HEAD].
PR: 2896
Bodo Möller [Fri, 5 Oct 2012 20:51:47 +0000 (20:51 +0000)]
Fix EC_KEY initialization race.
Submitted by: Adam Langley
Dr. Stephen Henson [Fri, 5 Oct 2012 13:02:31 +0000 (13:02 +0000)]
backport OCSP fix enhancement
Ben Laurie [Fri, 5 Oct 2012 13:00:17 +0000 (13:00 +0000)]
Update CHANGES for OCSP fix.
Ben Laurie [Fri, 5 Oct 2012 12:50:24 +0000 (12:50 +0000)]
Backport OCSP fix.
Bodo Möller [Mon, 24 Sep 2012 19:50:07 +0000 (19:50 +0000)]
Fix Valgrind warning.
Submitted by: Adam Langley
Richard Levitte [Mon, 24 Sep 2012 18:49:09 +0000 (18:49 +0000)]
* Configure: make the debug-levitte-linux{elf,noasm} less extreme.
Richard Levitte [Fri, 21 Sep 2012 13:08:32 +0000 (13:08 +0000)]
* ssl/t1_enc.c (tls1_change_cipher_state): Stupid bug. Fortunately in
debugging code that's seldom used.
Dr. Stephen Henson [Tue, 11 Sep 2012 13:45:42 +0000 (13:45 +0000)]
fix memory leak
Richard Levitte [Thu, 5 Jul 2012 09:06:20 +0000 (09:06 +0000)]
Remove duplicate symbol in crypto/symhacks.h
Have the new names start in column 48, that makes it easy to see when
the 31 character limit is reached (on a 80 column display, do the math)
Dr. Stephen Henson [Fri, 11 May 2012 13:49:15 +0000 (13:49 +0000)]
PR: 2813
Reported by: Constantine Sapuntzakis <csapuntz@gmail.com>
Fix possible deadlock when decoding public keys.
Dr. Stephen Henson [Thu, 10 May 2012 16:01:11 +0000 (16:01 +0000)]
prepare for next version
Dr. Stephen Henson [Thu, 10 May 2012 14:38:52 +0000 (14:38 +0000)]
update FAQ
Dr. Stephen Henson [Thu, 10 May 2012 14:36:07 +0000 (14:36 +0000)]
prepare for 0.9.8x release
Dr. Stephen Henson [Thu, 10 May 2012 14:35:13 +0000 (14:35 +0000)]
update NEWS
Dr. Stephen Henson [Thu, 10 May 2012 14:33:11 +0000 (14:33 +0000)]
Sanity check record length before skipping explicit IV in DTLS
to fix DoS attack.
Thanks to Codenomicon for discovering this issue using Fuzz-o-Matic
fuzzing as a service testing platform.
(CVE-2012-2333)
Dr. Stephen Henson [Thu, 10 May 2012 13:27:57 +0000 (13:27 +0000)]
Reported by: Solar Designer of Openwall
Make sure tkeylen is initialised properly when encrypting CMS messages.
Richard Levitte [Fri, 4 May 2012 10:43:17 +0000 (10:43 +0000)]
Correct environment variable is OPENSSL_ALLOW_PROXY_CERTS.
Dr. Stephen Henson [Mon, 23 Apr 2012 21:15:22 +0000 (21:15 +0000)]
prepare for next version
Dr. Stephen Henson [Mon, 23 Apr 2012 21:03:04 +0000 (21:03 +0000)]
update STATUS
Dr. Stephen Henson [Mon, 23 Apr 2012 20:51:18 +0000 (20:51 +0000)]
correct STATUS
Dr. Stephen Henson [Mon, 23 Apr 2012 20:49:21 +0000 (20:49 +0000)]
correct NEWS
Dr. Stephen Henson [Mon, 23 Apr 2012 20:45:29 +0000 (20:45 +0000)]
prepare form 0.9.8w release
Dr. Stephen Henson [Mon, 23 Apr 2012 20:43:35 +0000 (20:43 +0000)]
update NEWS
Dr. Stephen Henson [Mon, 23 Apr 2012 20:35:55 +0000 (20:35 +0000)]
The fix for CVE-2012-2110 did not take into account that the
'len' argument to BUF_MEM_grow and BUF_MEM_grow_clean is an
int in OpenSSL 0.9.8, making it still vulnerable. Fix by
rejecting negative len parameter.
Thanks to the many people who reported this bug and to Tomas Hoger
<thoger@redhat.com> for supplying the fix.
Dr. Stephen Henson [Sun, 22 Apr 2012 13:31:46 +0000 (13:31 +0000)]
correct error code
Dr. Stephen Henson [Sun, 22 Apr 2012 13:22:38 +0000 (13:22 +0000)]
correct old FAQ answers, sync with HEAD
Dr. Stephen Henson [Thu, 19 Apr 2012 17:03:28 +0000 (17:03 +0000)]
prepare for next version
Dr. Stephen Henson [Thu, 19 Apr 2012 12:05:18 +0000 (12:05 +0000)]
update FAQ
Dr. Stephen Henson [Thu, 19 Apr 2012 11:39:03 +0000 (11:39 +0000)]
prepare for 0.9.8v release
Dr. Stephen Henson [Thu, 19 Apr 2012 11:37:17 +0000 (11:37 +0000)]
update NEWS
Dr. Stephen Henson [Thu, 19 Apr 2012 11:36:09 +0000 (11:36 +0000)]
Check for potentially exploitable overflows in asn1_d2i_read_bio
BUF_mem_grow and BUF_mem_grow_clean. Refuse attempts to shrink buffer
in CRYPTO_realloc_clean.
Thanks to Tavis Ormandy, Google Security Team, for discovering this
issue and to Adam Langley <agl@chromium.org> for fixing it. (CVE-2012-2110)
Dr. Stephen Henson [Sun, 15 Apr 2012 16:48:34 +0000 (16:48 +0000)]
use /fixed argument when linking FIPS targets to disable address space layout randomization
Dr. Stephen Henson [Sat, 31 Mar 2012 18:02:23 +0000 (18:02 +0000)]
PR: 2778(part)
Submitted by: John Fitzgibbon <john_fitzgibbon@yahoo.com>
Time is always encoded as 4 bytes, not sizeof(Time).
Dr. Stephen Henson [Sun, 18 Mar 2012 18:18:30 +0000 (18:18 +0000)]
Always use SSLv23_{client,server}_method in s_client.c and s_server.c,
the old code came from SSLeay days before TLS was even supported.
Dr. Stephen Henson [Mon, 12 Mar 2012 16:35:13 +0000 (16:35 +0000)]
prepare for next version
Dr. Stephen Henson [Mon, 12 Mar 2012 15:25:53 +0000 (15:25 +0000)]
corrected fix to PR#2711 and also cover mime_param_cmp
Dr. Stephen Henson [Mon, 12 Mar 2012 15:01:44 +0000 (15:01 +0000)]
correct FAQ
Dr. Stephen Henson [Mon, 12 Mar 2012 14:53:14 +0000 (14:53 +0000)]
prepare for release
Dr. Stephen Henson [Mon, 12 Mar 2012 14:52:14 +0000 (14:52 +0000)]
update NEWS
Dr. Stephen Henson [Mon, 12 Mar 2012 14:51:45 +0000 (14:51 +0000)]
Fix for CMS/PKCS7 MMA. If RSA decryption fails use a random key and
continue with symmetric decryption process to avoid leaking timing
information to an attacker.
Thanks to Ivan Nestlerode <inestlerode@us.ibm.com> for discovering
this issue. (CVE-2012-0884)
Dr. Stephen Henson [Mon, 12 Mar 2012 14:50:55 +0000 (14:50 +0000)]
fix error code
Dr. Stephen Henson [Mon, 12 Mar 2012 12:46:52 +0000 (12:46 +0000)]
manually patch missing part of PR#2756
Dr. Stephen Henson [Fri, 9 Mar 2012 15:51:56 +0000 (15:51 +0000)]
PR: 2756
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Fix DTLS timeout handling.
Dr. Stephen Henson [Thu, 8 Mar 2012 14:01:44 +0000 (14:01 +0000)]
check return value of BIO_write in PKCS7_decrypt
Dr. Stephen Henson [Wed, 7 Mar 2012 15:14:16 +0000 (15:14 +0000)]
PR: 2755
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reduce MTU after failed transmissions. [0.9.8 version of patch]
Dr. Stephen Henson [Tue, 6 Mar 2012 19:08:30 +0000 (19:08 +0000)]
return failure code if I/O error
Dr. Stephen Henson [Tue, 6 Mar 2012 18:25:33 +0000 (18:25 +0000)]
revert PR#2755: it breaks compilation
Dr. Stephen Henson [Tue, 6 Mar 2012 13:45:47 +0000 (13:45 +0000)]
PR: 2755
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reduce MTU after failed transmissions.
Dr. Stephen Henson [Tue, 6 Mar 2012 13:37:52 +0000 (13:37 +0000)]
PR: 2696 Submitted by: Rob Austein <sra@hactrn.net>
Fix inverted range problem in RFC3779 code.
Thanks to Andrew Chi for generating test cases for this bug.
[from HEAD]
Dr. Stephen Henson [Tue, 6 Mar 2012 13:22:32 +0000 (13:22 +0000)]
oops, revert unrelated patches
Dr. Stephen Henson [Tue, 6 Mar 2012 13:20:20 +0000 (13:20 +0000)]
PR: 2748
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Fix possible DTLS timer deadlock.
Dr. Stephen Henson [Tue, 28 Feb 2012 14:47:36 +0000 (14:47 +0000)]
Fix memory leak cause by race condition when creating public keys.
Thanks to Ivan Nestlerode <inestlerode@us.ibm.com> for reporting this bug.
Dr. Stephen Henson [Mon, 27 Feb 2012 16:26:32 +0000 (16:26 +0000)]
free headers after use in error message
Dr. Stephen Henson [Mon, 27 Feb 2012 15:23:20 +0000 (15:23 +0000)]
Detect symmetric crypto errors in PKCS7_decrypt.
Thanks to Ivan Nestlerode <inestlerode@us.ibm.com> for reporting this bug.
Dr. Stephen Henson [Thu, 23 Feb 2012 21:50:13 +0000 (21:50 +0000)]
PR: 2711
Submitted by: Tomas Mraz <tmraz@redhat.com>
Tolerate bad MIME headers in parser.
Dr. Stephen Henson [Thu, 16 Feb 2012 15:21:17 +0000 (15:21 +0000)]
Fix bug in CVE-2011-4619: check we have really received a client hello
before rejecting multiple SGC restarts.
Dr. Stephen Henson [Sat, 11 Feb 2012 23:12:34 +0000 (23:12 +0000)]
PR: 2703
Submitted by: Alexey Melnikov <alexey.melnikov@isode.com>
Fix some memory and resource leaks in CAPI ENGINE.
Dr. Stephen Henson [Sat, 11 Feb 2012 23:07:32 +0000 (23:07 +0000)]
PR: 2705
Submitted by: Alexey Melnikov <alexey.melnikov@isode.com>
Only create ex_data indices once for CAPI engine.
Dr. Stephen Henson [Fri, 20 Jan 2012 23:24:17 +0000 (23:24 +0000)]
fix Visual Studio 2010 warning [from HEAD] (original by appro)
Dr. Stephen Henson [Wed, 18 Jan 2012 14:27:13 +0000 (14:27 +0000)]
prepare for next version
Dr. Stephen Henson [Wed, 18 Jan 2012 13:15:37 +0000 (13:15 +0000)]
update FAQ
Dr. Stephen Henson [Wed, 18 Jan 2012 13:14:49 +0000 (13:14 +0000)]
prepare for release
Dr. Stephen Henson [Wed, 18 Jan 2012 13:13:31 +0000 (13:13 +0000)]
update NEWS
Dr. Stephen Henson [Wed, 18 Jan 2012 13:12:08 +0000 (13:12 +0000)]
Fix for DTLS DoS issue introduced by fix for CVE-2011-4109.
Thanks to Antonio Martin, Enterprise Secure Access Research and
Development, Cisco Systems, Inc. for discovering this bug and
preparing a fix. (CVE-2012-0050)
Dr. Stephen Henson [Tue, 17 Jan 2012 14:18:26 +0000 (14:18 +0000)]
fix CHANGES entry
Dr. Stephen Henson [Tue, 10 Jan 2012 14:37:00 +0000 (14:37 +0000)]
fix warning
Bodo Möller [Thu, 5 Jan 2012 13:15:29 +0000 (13:15 +0000)]
Fix usage indentation
Bodo Möller [Thu, 5 Jan 2012 10:21:49 +0000 (10:21 +0000)]
Fix for builds without DTLS support.
Submitted by: Brian Carlstrom
Dr. Stephen Henson [Wed, 4 Jan 2012 23:56:13 +0000 (23:56 +0000)]
update for next version
Dr. Stephen Henson [Wed, 4 Jan 2012 19:23:07 +0000 (19:23 +0000)]
update FAQ
Dr. Stephen Henson [Wed, 4 Jan 2012 19:20:49 +0000 (19:20 +0000)]
prepare for 0.9.8s release
Dr. Stephen Henson [Wed, 4 Jan 2012 19:16:11 +0000 (19:16 +0000)]
update NEWS
Dr. Stephen Henson [Wed, 4 Jan 2012 19:12:39 +0000 (19:12 +0000)]
make update
Dr. Stephen Henson [Wed, 4 Jan 2012 19:10:16 +0000 (19:10 +0000)]
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>, Michael Tuexen <tuexen@fh-muenster.de>
Reviewed by: steve
Fix for DTLS plaintext recovery attack discovered by Nadhem Alfardan and
Kenny Paterson.
Dr. Stephen Henson [Wed, 4 Jan 2012 19:00:28 +0000 (19:00 +0000)]
Fix double free in policy check code (CVE-2011-4109)
Dr. Stephen Henson [Wed, 4 Jan 2012 18:54:17 +0000 (18:54 +0000)]
Clear bytes used for block padding of SSL 3.0 records. (CVE-2011-4576)
Dr. Stephen Henson [Wed, 4 Jan 2012 18:52:18 +0000 (18:52 +0000)]
Only allow one SGC handshake restart for SSL/TLS. (CVE-2011-4619)
Dr. Stephen Henson [Wed, 4 Jan 2012 18:45:18 +0000 (18:45 +0000)]
stop warning
Dr. Stephen Henson [Wed, 4 Jan 2012 18:44:20 +0000 (18:44 +0000)]
Prevent malformed RFC3779 data triggering an assertion failure (CVE-2011-4577)