Glenn L McGrath [Wed, 29 Oct 2003 04:50:35 +0000 (04:50 -0000)]
fix a bug where `which' doesn't check whether the file passed as an argument
is a regular file, patch by Arthur Othieno
Glenn L McGrath [Wed, 29 Oct 2003 04:46:30 +0000 (04:46 -0000)]
make CONFIG_FEATURE_UNARCHIVE_TAPE common between itar and cpio, patch
by Arthur Othieno
Glenn L McGrath [Wed, 29 Oct 2003 03:40:47 +0000 (03:40 -0000)]
"A few references to sourcefiles and URLs in docs/contributing.txt had
gone stale" - Peter Korsgaard
Glenn L McGrath [Wed, 29 Oct 2003 03:37:54 +0000 (03:37 -0000)]
Use the return value from uncompress_bunzip, fix some typo
Glenn L McGrath [Tue, 28 Oct 2003 23:32:12 +0000 (23:32 -0000)]
Add some error messages, use xmalloc instead of malloc
Glenn L McGrath [Tue, 28 Oct 2003 23:04:50 +0000 (23:04 -0000)]
Fix a logic error, the old bunzip code returned non-zero for success,
new code returns 0 for success.
Glenn L McGrath [Tue, 28 Oct 2003 10:44:58 +0000 (10:44 -0000)]
Conditionally compile some files.
This hides a bug related to the new bunzip code in the tar and dpkg[-deb]
applets.
It will also reduce compile time a little as some unused files wont be
compiled.
Eric Andersen [Thu, 23 Oct 2003 06:52:01 +0000 (06:52 -0000)]
Another bzip2 update and speedup from Manuel Novoa III, with some
additional changes (primarily lots of comments) from Rob Landley.
Eric Andersen [Wed, 22 Oct 2003 22:29:08 +0000 (22:29 -0000)]
the dc applet now needs libm
-Erik
Eric Andersen [Wed, 22 Oct 2003 11:36:55 +0000 (11:36 -0000)]
sigh
Eric Andersen [Wed, 22 Oct 2003 11:24:39 +0000 (11:24 -0000)]
Goetz Bock writes:
Dear list,
during my quest do pack busybox into an RPM, I've fixed a small bug
(missing \n) in dc's usage. And added two additional operations: mod and
exp/power.
Feel free to drop them.
Eric Andersen [Wed, 22 Oct 2003 10:56:47 +0000 (10:56 -0000)]
last_patch116 from vodz:
Stephane,
>Using busybox+uclibc, crond syslog messages look like:
>
>Oct 9 09:04:46 soekris cron.notice crond[347]: ^Icrond 2.3.2 dillon,
>started, log level 8
Thanks for testing.
>The attached patch corrects the problem.
Your patch is not correct.
Correct patch attached.
Also. Last patch have
- add "Broken pipe" message to ash.c
- busybox ash synced with dash_0.4.18
--w
vodz
Eric Andersen [Wed, 22 Oct 2003 10:38:22 +0000 (10:38 -0000)]
Tomasz Motylewski reported that the 'which' applet does not find
files when the full file PATH is specified.
This patch from Arthur Othieno fixes it.
Eric Andersen [Wed, 22 Oct 2003 10:34:15 +0000 (10:34 -0000)]
Patch from Arthur Othieno for style-guide.txt conformance
Eric Andersen [Wed, 22 Oct 2003 10:30:53 +0000 (10:30 -0000)]
Patch from Arthur Othieno for docs/style-guide.txt conformance.
Eric Andersen [Wed, 22 Oct 2003 10:26:38 +0000 (10:26 -0000)]
Patch from Arthur Othieno to fix a compiler warning
Eric Andersen [Wed, 22 Oct 2003 10:23:04 +0000 (10:23 -0000)]
make this a little bit less messy
Eric Andersen [Wed, 22 Oct 2003 10:19:01 +0000 (10:19 -0000)]
Update mail location
Eric Andersen [Wed, 22 Oct 2003 10:18:24 +0000 (10:18 -0000)]
Disable any buffering to stdout
Eric Andersen [Wed, 22 Oct 2003 10:10:50 +0000 (10:10 -0000)]
Tito writes:
Hi to all,
I'm sorry but I didn't spot this big fat bug until now,
Matteo Croce emailed me about it.
Please apply this patch as the devfsd applet is broken
and works only on a system booted with a standard devfsd
( the test I mostly did :-( ), but if used at boot time
it DOESN'T WORK.
Thanks in advance and please apply
Tito
Eric Andersen [Wed, 22 Oct 2003 09:58:56 +0000 (09:58 -0000)]
Andreas Mohr writes:
the busybox menuconfig triggered my "inacceptable number of spelling mistakes"
upper level, so I decided to make a patch ;-)
I also improved some wording to describe some things in a better way.
Many thanks for an incredible piece of software!
Andreas Mohr, random OSS developer
Eric Andersen [Tue, 21 Oct 2003 06:45:29 +0000 (06:45 -0000)]
Do a better job of dealing with screwy s390 abi changes
Eric Andersen [Mon, 20 Oct 2003 05:40:40 +0000 (05:40 -0000)]
ccording to this:
http://sources.redhat.com/ml/binutils/2003-01/msg00290.html
The name R_390_GOTOFF was changed to R_390_GOTOFF32.
-Erik
Eric Andersen [Sat, 18 Oct 2003 01:59:46 +0000 (01:59 -0000)]
Manuel Novoa III writes:
Hello Rob,
Here's a patch to your bunzip-3.c file. Nice work btw.
One minor bug fix... checking for error return when read()ing.
Some size/performance optimizations as well. One instance of
memset() seems unnecssary. You might want to take a look.
Anyway, on my machine, decompressing linux-2.6.0-test7.tar.bz2
to /dev/null gave the following times:
bunzip-3.c bzcat (system) bunzip-3.c (patched)
real 0m24.420s 0m22.725s 0m20.701s
user 0m23.930s 0m22.170s 0m20.180s
sys 0m0.070s 0m0.080s 0m0.140s
Size of the patched version is comparable (slightly larger or
smaller depending on compiler flags).
Manuel
Eric Andersen [Sat, 18 Oct 2003 01:58:35 +0000 (01:58 -0000)]
Rob Landley's new micro-bunzip version 3. Rob writes:
The API for using partial writes, as described in my last message, sucked.
So here's a patch against my last patch that changes things so that
write_bunzip_data calls read_bunzip_data itself behind the scenes whenever
necessary. So usage is now just start_bunzip(), write_bunzip_data() until it
returns a negative number, and then the cleanup at the end of
uncompressStream.
It adds 32 bytes to the executable, but it should allow the caller (tar) to be
simplified enough to compensate. Total -Os stripped exe size now 6856 bytes.
Rob
P.S. I attached the whole C file so you don't have to keep incremental
patches straight if you don't want to. :)
P.S. In the version I'm banging on now, I've simplified the license to just
LGPL. I read the OSL a bit more closely and the patent termination clause
would have bit IBM in their counter-suit of SCO if the code in question had
been OSL instead of GPL, and I've decided I just don't want to beta-test
legal code right now.
Tim Riker [Fri, 17 Oct 2003 18:54:55 +0000 (18:54 -0000)]
old gcc
Eric Andersen [Sat, 11 Oct 2003 18:47:20 +0000 (18:47 -0000)]
Paul Mundt (lethal) writes:
Erik,
The format for /proc/meminfo has changed between 2.4 and 2.6, quite considerably.
In addition to the removal of the two-line summary that was present in 2.4,
MemShared was also removed. Presently (at least in busybox CVS HEAD), top fails
to parse this correctly and spews forth a:
top: failed to read 'meminfo'
message. This patch switches around some of the semantics a little to do sane
parsing for both 2.4 and 2.6. Also, in the event that the summary gets yanked
from 2.4, this patch will deal with that as well. With this patch, I'm able
to run top correctly on 2.6.0-test7 (tested on sh).
Please apply.
procps/top.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++------------
1 files changed, 48 insertions(+), 12 deletions(-)
Glenn L McGrath [Fri, 10 Oct 2003 23:15:23 +0000 (23:15 -0000)]
Vodz last_patch_117, update options for new xargs
Glenn L McGrath [Fri, 10 Oct 2003 12:10:18 +0000 (12:10 -0000)]
Vods versions of xargs
Eric Andersen [Thu, 9 Oct 2003 21:19:21 +0000 (21:19 -0000)]
I don't need to have my email adder listed twice
Eric Andersen [Thu, 9 Oct 2003 21:02:23 +0000 (21:02 -0000)]
Do not use kernel headers
Glenn L McGrath [Thu, 9 Oct 2003 13:40:17 +0000 (13:40 -0000)]
Fix an ommision preventing building, patch by Tito.
Glenn L McGrath [Thu, 9 Oct 2003 13:25:00 +0000 (13:25 -0000)]
example devfs config file, patch from Tito.
Glenn L McGrath [Thu, 9 Oct 2003 11:46:23 +0000 (11:46 -0000)]
New applet, devfsd, by Matteo Croce and Tito
Glenn L McGrath [Thu, 9 Oct 2003 11:38:45 +0000 (11:38 -0000)]
Patch from Steven Scholz, fix some warnings
Glenn L McGrath [Thu, 9 Oct 2003 11:06:45 +0000 (11:06 -0000)]
Bugfix for xargs
Eric Andersen [Thu, 9 Oct 2003 09:43:18 +0000 (09:43 -0000)]
Arnd Ben Otto writes:
Hi Eric
I have written a small patch for the Busybox syslogd. With this patch
one can limit the size of the messagfile. As soon as the limit is
reached the syslogd can rotate or purge the messagefile(s) on his own.
There is no necessity to use an external rotatescript.
Even if logread does something similar, its very handy to have some
messagefile after your box crash.
I wrote this patch initial vor BB 0.6x where no cron daemon was avail.
Now I adapted it for the new Version and i hope it is still useful. At
least I still use it :-)
bye
Arnd
Eric Andersen [Thu, 9 Oct 2003 08:35:42 +0000 (08:35 -0000)]
We did not have a safe_write, which is the analog to safe_read. Convert
full_write to use safe_write internally, which is needed to guarantee proper
behavior, i.e. when writing to a pipe.
Eric Andersen [Thu, 9 Oct 2003 08:18:36 +0000 (08:18 -0000)]
Fix some warnings that have crept in recently
Glenn L McGrath [Thu, 9 Oct 2003 07:28:22 +0000 (07:28 -0000)]
Patch from Tito, size optimisation and fix error in exit code of -V
option
Glenn L McGrath [Thu, 9 Oct 2003 07:22:59 +0000 (07:22 -0000)]
Comaptability with gcc-2.95
Glenn L McGrath [Mon, 6 Oct 2003 13:23:06 +0000 (13:23 -0000)]
Vodz last_patch_105 without his xargs patch which doenst apply cleanly
Glenn L McGrath [Sat, 4 Oct 2003 14:44:27 +0000 (14:44 -0000)]
Add the x, n, s and E options, remove -r as its expected behaviour.
Glenn L McGrath [Sat, 4 Oct 2003 05:27:56 +0000 (05:27 -0000)]
Patch from Rob Landley;
Moving on to building diffutils, busybox sed needs this patch to get
past the first problem. (Passing it a multi-line command line argument
with -e works, but if you don't use -e it doesn't break up the multiple
lines...)
Glenn L McGrath [Sat, 4 Oct 2003 00:05:47 +0000 (00:05 -0000)]
Woops, the previous patch reversal wasnt complete, breaking everything.
Glenn L McGrath [Fri, 3 Oct 2003 13:21:10 +0000 (13:21 -0000)]
Reverse my previous changes and make a note about why its dont this way
Glenn L McGrath [Fri, 3 Oct 2003 13:15:44 +0000 (13:15 -0000)]
Dont mix xarg options with utility option, fixes example of
`echo "README" | xargs ls -al`
Dont specify a path for the default behaviour of echo
args allocated space for an extra ptr
Use defines for the different options
Glenn L McGrath [Fri, 3 Oct 2003 10:50:56 +0000 (10:50 -0000)]
Vodz, last_patch_114
- env vars CONTENT_TYPE, CONTENT_LENGTH, HTTPD_REFERER, REMOTE_USER and
AUTH_TYPE(Basic always).
- POST data pipied now (previous version have loading into memory may be
big size data and reducing with hardcoded limit)
- removed $CGI_foo environment variables, else my have rubbish
enviroment if POST data have big binary file
Glenn L McGrath [Fri, 3 Oct 2003 08:28:59 +0000 (08:28 -0000)]
Patch by Rob Landley, fix warning
Glenn L McGrath [Fri, 3 Oct 2003 07:51:30 +0000 (07:51 -0000)]
argc has already been decremented
Glenn L McGrath [Fri, 3 Oct 2003 03:25:30 +0000 (03:25 -0000)]
Patch from Rob Landley, Simplify organisation of arguments.
Glenn L McGrath [Thu, 2 Oct 2003 14:33:23 +0000 (14:33 -0000)]
Fix -C option when creating tar files.
Need to chdir after the tar file is opened, so make common tar filename
parsing and send the file descriptor rather than filename to
writeTarFile.
Modify the verboseFlag operation to determine wether to display on
stderr or stdout at display time, simpler than doing it in tar_main.
Glenn L McGrath [Wed, 1 Oct 2003 11:33:46 +0000 (11:33 -0000)]
Thomas Lundquist, update for current structure
Glenn L McGrath [Wed, 1 Oct 2003 10:26:23 +0000 (10:26 -0000)]
Patch from Rob Landley to fix backrefs
Glenn L McGrath [Wed, 1 Oct 2003 06:45:11 +0000 (06:45 -0000)]
Patch by Rob Landley, fix "newline after edit command"
Glenn L McGrath [Wed, 1 Oct 2003 03:06:16 +0000 (03:06 -0000)]
Patch by Rob Landley, work in progress update, fixes lots of bugs,
introduces a few others (but they are being worked on)
Glenn L McGrath [Fri, 26 Sep 2003 10:45:55 +0000 (10:45 -0000)]
Patch by Guillaume Morin
Fix two race conditions, as described at.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=212764
Glenn L McGrath [Fri, 26 Sep 2003 01:03:16 +0000 (01:03 -0000)]
Patch from Fillod Stephane
Add follow mode to logread, ala "tail -f /var/log/messages"
Note: output to a slow serial terminal can have side effects
on syslog because of the semaphore. In such case, define
RC_LOGREAD.
Glenn L McGrath [Fri, 26 Sep 2003 00:49:05 +0000 (00:49 -0000)]
add size parameter to syslogd -C
Patch by Padraig, resubmitted by Fillod Stephane
Glenn L McGrath [Fri, 26 Sep 2003 00:33:18 +0000 (00:33 -0000)]
Patch by Fillod Stephane, declare variables as static to not clobber
busybox namespace
Glenn L McGrath [Wed, 24 Sep 2003 15:48:29 +0000 (15:48 -0000)]
Use a variable for the config files, makes it easier to syncronise with
debian builds
Glenn L McGrath [Wed, 24 Sep 2003 15:30:44 +0000 (15:30 -0000)]
Syncronise with debian busybox-cvs package
Glenn L McGrath [Wed, 24 Sep 2003 10:23:39 +0000 (10:23 -0000)]
Fix some typo's, remove some extra free statements
Glenn L McGrath [Wed, 24 Sep 2003 05:00:29 +0000 (05:00 -0000)]
Add the -d option
Glenn L McGrath [Wed, 24 Sep 2003 03:22:57 +0000 (03:22 -0000)]
Add the "install" applet, move get_ug_id to libbb as its used by chown,
chgrp and install.
Glenn L McGrath [Sat, 20 Sep 2003 00:59:35 +0000 (00:59 -0000)]
Patch by Steinar H. Gunderson to fix debian bug #211675.
Linking to my_getgrnam from libpwdgrp wasnt working, instead it was
trying to use functionality from glibc, which pulled in libnss.
Glenn L McGrath [Wed, 17 Sep 2003 00:22:26 +0000 (00:22 -0000)]
Patch by Junio C Hamano to workaround a gcc compiler bug.
The construct certain vintages of GCC (the one I have trouble
with is 3.2.3) have trouble with looks like the following:
static struct st a;
static struct st *p = &a;
struct st { int foo; };
static void init(void) { a.foo = 0; }
The problem disappears if we move the struct declaration up to
let the compiler know the shape of the struct before the first
definition uses it, like this:
struct st { int foo; }; /* this has been moved up */
static struct st a;
static struct st *p = &a;
static void init(void) { a.foo = 0; }
Glenn L McGrath [Tue, 16 Sep 2003 05:25:43 +0000 (05:25 -0000)]
Configuration option to define wether to follows GNU sed's behaviour
or the posix standard.
Put the cleanup code back the way it was.
Glenn L McGrath [Tue, 16 Sep 2003 01:46:36 +0000 (01:46 -0000)]
Fix a bug that creapt in recently with substitution subprinting, and add
a test for it.
Glenn L McGrath [Tue, 16 Sep 2003 00:50:36 +0000 (00:50 -0000)]
Compile get_terminal_width_height
Glenn L McGrath [Mon, 15 Sep 2003 15:00:43 +0000 (15:00 -0000)]
Patch from Stephane Billiart to fix an unused variable warning.
Glenn L McGrath [Mon, 15 Sep 2003 14:42:39 +0000 (14:42 -0000)]
Patch from Bastian Blank to fix a problem when runing find under ash.
"If the shell is compiled with -DJOBS, this is all fine -- find wasn't
stopped (it was killed), so it correctly uses WTERMSIG instead of WSTOPSIG.
However, if the shell _isn't_ compiled with -DJOBS (which it isn't in d-i),
only WSTOPSIG is used, which extracts the high byte instead of the low
byte from the status code. Since the status code is 13 (SIGPIPE), "st"
suddenly gets the value 0, which is equivalent to SIGEXIT. Thus, ash prints
out "EXIT" on find's exit."
Glenn L McGrath [Mon, 15 Sep 2003 14:22:37 +0000 (14:22 -0000)]
Patch from Tito, Reduces the size of busybox's strings applet from 1900 to
1788 bytes (for strings.o).
Glenn L McGrath [Mon, 15 Sep 2003 12:07:48 +0000 (12:07 -0000)]
Fix a simple mistake with pattern space, and add a test for it
Glenn L McGrath [Mon, 15 Sep 2003 12:00:19 +0000 (12:00 -0000)]
Patch by Jean Wolter to fix a bug where a script wouldnt be executed
unless it had #!/bin/sh in the first line
"It correctly locates the script, tries to execute it via execve which
fails. After that it tries to hand it over to /bin/sh which fails too,
since ash
- neither provides the absolute pathname to /bin/sh
- nor tries to lookup the script via PATH if called as "sh script"
"
Glenn L McGrath [Mon, 15 Sep 2003 09:22:04 +0000 (09:22 -0000)]
Fix some memory allocation problems
----------------------------------------------------------------------
Eric Andersen [Mon, 15 Sep 2003 08:33:45 +0000 (08:33 -0000)]
Be entirely consistant when using ioctl(0, TIOCGWINSZ, &winsize)
to ensure proper fallback behavior on, i.e. serial consoles.
-Erik
Eric Andersen [Mon, 15 Sep 2003 08:13:43 +0000 (08:13 -0000)]
fix function prototype
Eric Andersen [Mon, 15 Sep 2003 08:12:53 +0000 (08:12 -0000)]
Needs prototype for close()
Eric Andersen [Mon, 15 Sep 2003 08:11:29 +0000 (08:11 -0000)]
comparison was always false due to limited range of data types.
Carefully cast to unsigned long long prior to multiply to get
the expected result.
Eric Andersen [Mon, 15 Sep 2003 08:06:15 +0000 (08:06 -0000)]
Do not shadow the global name 'accept'
Glenn L McGrath [Mon, 15 Sep 2003 06:28:45 +0000 (06:28 -0000)]
Add a test for the 'P' command and fix current implementation so it
doesnt permanently modify the pattern space.
Glenn L McGrath [Mon, 15 Sep 2003 06:12:53 +0000 (06:12 -0000)]
A test and fix for the sed 'n' command
Glenn L McGrath [Mon, 15 Sep 2003 05:53:28 +0000 (05:53 -0000)]
Test for use of newline in regex's, this feature is used by most
configure scripts.
Glenn L McGrath [Mon, 15 Sep 2003 05:42:05 +0000 (05:42 -0000)]
Fix for the sed-append-next-line test
Glenn L McGrath [Mon, 15 Sep 2003 05:35:47 +0000 (05:35 -0000)]
Test the N command
Glenn L McGrath [Mon, 15 Sep 2003 04:55:29 +0000 (04:55 -0000)]
Fix recursion problem
Glenn L McGrath [Mon, 15 Sep 2003 04:41:17 +0000 (04:41 -0000)]
Check sed doesnt go into an infinite loop (yes it does)
Glenn L McGrath [Mon, 15 Sep 2003 03:37:32 +0000 (03:37 -0000)]
Update Matteo Croce's email address
Glenn L McGrath [Sun, 14 Sep 2003 16:28:08 +0000 (16:28 -0000)]
Memory cleanups and fix for `echo "foo" | sed 's/foo/bar/;H;q'`
Glenn L McGrath [Sun, 14 Sep 2003 15:24:18 +0000 (15:24 -0000)]
Cleanup memory usage
Glenn L McGrath [Sun, 14 Sep 2003 11:10:08 +0000 (11:10 -0000)]
Update sed branch tests
Glenn L McGrath [Sun, 14 Sep 2003 09:38:24 +0000 (09:38 -0000)]
Add two new tests, sed-recurses-properly should always work
Glenn L McGrath [Sun, 14 Sep 2003 08:52:53 +0000 (08:52 -0000)]
The previous fix for 's/a/1/;s/b/2/;t one;p;:one;p' broke the case of
echo fooba | ./busybox sed -n 's/foo//;s/bar/found/p'
I really need to start adding these tests to the testsuite.
keep the substituted and altered flags seperate
Glenn L McGrath [Sun, 14 Sep 2003 07:59:28 +0000 (07:59 -0000)]
Preserve substitution flag value within the current line.
Fixed the following testcase
# cat strings |./busybox sed -n -f test3.sed
1
1
2
c
c
# cat strings
a
b
c
Glenn L McGrath [Sun, 14 Sep 2003 06:01:14 +0000 (06:01 -0000)]
Fix branching commands.
If a label isnt specified, jump to end of script, not the last command
in the script.
Print an error and exit if you try and jump to a non-existant label
Works for the following testcase
# cat strings
a
b
c
d
e
f
g
# cat strings | ./busybox sed -n '/d/b;p'
a
b
c
e
f
g
Glenn L McGrath [Sun, 14 Sep 2003 04:06:12 +0000 (04:06 -0000)]
Patch from Rob Landley
Fixed a memory leak in add_cmd/add_cmd_str by moving the allocation
of sed_cmd down to where it's actually first needed.
In get_address, if index_of_next_unescaped_regexp_delim ever failed, we
wouldn't notice because the return value was added to idx, which was
already guaranteed to be > 0. (This is buried in the changes made when
I redid get_address to be based on pointer arithmetic, because all the tests
were gratuitously dereferencing with a constant zero, which wasn't obvious.)
Comment in parse_regex_delim was wrong: 's' and 'y' both call it.
The reason "sed_cmd->num_backrefs = 0;" isn't needed is that sed_cmd was
allocated with cmalloc, which zeroes memory.
Different handling of space after \ in i...
Different handling of pattern "s/a/b s/c/d"
Cool, resursive reads don't cause a crash. :)
Fixed "sed -f blah filename - < filename" since GNU sed was handling
both - and filenames on the same line. (You can even list - more than
once, although it's immediate EOF...)
Glenn L McGrath [Sun, 14 Sep 2003 02:37:46 +0000 (02:37 -0000)]
Stupid typo
Glenn L McGrath [Sun, 14 Sep 2003 01:25:31 +0000 (01:25 -0000)]
Fix some memory allocation problems
Glenn L McGrath [Sat, 13 Sep 2003 15:12:22 +0000 (15:12 -0000)]
Fix the following testcase by disabling global substitution if the regex
is anchored to the start of line, there can be only one subst.
echo "aah" | sed 's/^a/b/g'