Rob Landley [Sun, 25 Jun 2006 15:29:12 +0000 (15:29 -0000)]
Fix a possible race condition if two processes try to claim the same loop
device at the same time. We should only CLR_FD if the set status fails,
not if the SET_FD fails.
Rob Landley [Sun, 25 Jun 2006 00:34:52 +0000 (00:34 -0000)]
A few patches from Erik Hovland, turning strncpy() into safe_strncpy() and
removing some unnecessary code.
Rob Landley [Sat, 24 Jun 2006 22:55:13 +0000 (22:55 -0000)]
Add a test from Glenn.
Rob Landley [Sat, 24 Jun 2006 22:39:19 +0000 (22:39 -0000)]
Document mount's new error return conventions.
Rob Landley [Sat, 24 Jun 2006 21:27:36 +0000 (21:27 -0000)]
The logic to make cp -d or -P treat things like regular files should only
trigger for symlinks, not for device nodes. This should fix "cp -a /dev ."
to work as expected (when run by root, anyway).
While I was there, cleanup headers and make an #ifdef go away...
Rob Landley [Sat, 24 Jun 2006 17:55:02 +0000 (17:55 -0000)]
Slowly pulling more common headers into libbb.h. Andre pointed out that
older uClibc didn't include sys/socket.h from netinet/in.h, so add an
explicit #include for that too...
Rob Landley [Thu, 22 Jun 2006 22:28:29 +0000 (22:28 -0000)]
Clean up.
Rob Landley [Thu, 22 Jun 2006 22:05:00 +0000 (22:05 -0000)]
Patch from Shaun Jackman to replace CFLAGS_EXTRA with .config.mak
Rob Landley [Thu, 22 Jun 2006 18:48:34 +0000 (18:48 -0000)]
CONFIG_DHCP -> CONFIG_APP_DHCP.
Mike Frysinger [Wed, 21 Jun 2006 23:03:37 +0000 (23:03 -0000)]
Jean Wolter writes: modprobe checks, whether a module is already loaded. The function used for this currently always returns 0.
Bernhard Reutner-Fischer [Wed, 21 Jun 2006 18:19:53 +0000 (18:19 -0000)]
- add note about strict ordering
Mike Frysinger [Wed, 21 Jun 2006 18:04:49 +0000 (18:04 -0000)]
Jean Wolter writes: ash uses bsearch to search in the list of built-in commands, therefore the list of built-in commands has to be ordered. Revision 15077 introduced the source built-in and destroyed this order. And now ash doesn't find the shift command anymore.
Rob Landley [Wed, 21 Jun 2006 03:53:33 +0000 (03:53 -0000)]
Patch from Paul Fox to improve mount's error handling behavior, which I beat
on a bit.
Rob Landley [Wed, 21 Jun 2006 02:39:57 +0000 (02:39 -0000)]
Andre (armcc2200@yahoo) patched a bug where successful mounts could sometimes
produce an error, due to a missing rc assignment.
Rob Landley [Wed, 21 Jun 2006 01:49:17 +0000 (01:49 -0000)]
Aurelien Jacobs pointed out inline functions that could be removed. Doing so
shrank the code a bit.
Rob Landley [Wed, 21 Jun 2006 01:15:36 +0000 (01:15 -0000)]
Remove pointless "inline" wrapper around get_terminal_width_height().
Rob Landley [Wed, 21 Jun 2006 00:52:31 +0000 (00:52 -0000)]
Zubicaray reported a bug in vi that causes it to eat 100% cpu when you close
an xterm it's running in. The vi signal behavior would catch and restarts lots
of signals, like SIGHUP, that should just kill the thing. (Leftover behavior
from when it would segfault all the time.) Filtered out the more obviously
bad ones. If it segfaults, we should find and fix the problem.
Mike Frysinger [Tue, 20 Jun 2006 23:03:27 +0000 (23:03 -0000)]
only enable count_bit functions when actually needed to fix warning reported by Bernhard Fischer
Rob Landley [Tue, 20 Jun 2006 22:38:00 +0000 (22:38 -0000)]
Since rangecoder is just a bunch of C functions, move it into the one user
(decompress_unlzma.c). Also a slight #include cleanup, and I've been meaning
to put #include <unistd.h> into libbb.h since it's so darn common...
Rob Landley [Tue, 20 Jun 2006 21:35:26 +0000 (21:35 -0000)]
Cleanup patch from Shaun Jackman converting %m to perror.
Rob Landley [Tue, 20 Jun 2006 21:13:29 +0000 (21:13 -0000)]
Patch by Robert P. Day to remove obsolete alias code that the 2.4 and 2.6
Linux kernels don't do anymore.
Mike Frysinger [Tue, 20 Jun 2006 20:37:01 +0000 (20:37 -0000)]
assign default debug level to the MSHDEBUG define
Rob Landley [Tue, 20 Jun 2006 17:43:01 +0000 (17:43 -0000)]
I broke allbareconfig with half-finished cleanups I'd forgotten weren't done.
Got both to a decent stopping point. (There's a lot more cleanup to do on ls.c
but now is not the time...)
Rob Landley [Tue, 20 Jun 2006 16:43:05 +0000 (16:43 -0000)]
The type changed too.
Peter Kjellerstedt [Tue, 20 Jun 2006 16:35:37 +0000 (16:35 -0000)]
Use the new names for tty_baud_to_value() and tty_value_to_baud() again.
Rob Landley [Tue, 20 Jun 2006 16:17:24 +0000 (16:17 -0000)]
Revert the last two patches to go back to a state before this file was
controversial.
Rob Landley [Tue, 20 Jun 2006 15:52:52 +0000 (15:52 -0000)]
Patch by Robert P. Day to make structs use c99 initializers.
Rob Landley [Tue, 20 Jun 2006 14:57:00 +0000 (14:57 -0000)]
Patch from Robert P. J. Day cleaning up some unnecessary preprocessor
directives.
Rob Landley [Tue, 20 Jun 2006 14:09:20 +0000 (14:09 -0000)]
Amrein-Marie Christophe pointed out that Mandrake changed its name.
Rob Landley [Mon, 19 Jun 2006 03:20:03 +0000 (03:20 -0000)]
Make some 64 bit warnings go away on x86-64.
Rob Landley [Sun, 18 Jun 2006 23:59:03 +0000 (23:59 -0000)]
Undo all of the ugliness and some of the bloat from 15412.
Rob Landley [Sun, 18 Jun 2006 20:20:07 +0000 (20:20 -0000)]
skip_whitespace() shouldn't claim its return value is const, it doesn't know
that and callers wind up typecasting it back.
Rob Landley [Sun, 18 Jun 2006 15:23:13 +0000 (15:23 -0000)]
Make this slightly more readable, and expose the hypocrasy of a comment that
says "our implementation makes it impossible to use blocksizes smaller than
22 octets" right above a check for blocksize < 8.
Mike Frysinger [Sat, 17 Jun 2006 22:41:28 +0000 (22:41 -0000)]
danf writes: stty doesn't support baud rates > 460800 bps, the attached patch adds support for all baud rates supported by Linux 2.6.16 on x86.
Rob Landley [Fri, 16 Jun 2006 22:29:03 +0000 (22:29 -0000)]
Make it so Erik has to forward me less email.
Bernhard Reutner-Fischer [Fri, 16 Jun 2006 17:19:39 +0000 (17:19 -0000)]
- add cross-reference generation target.
Experimental.
Bernhard Reutner-Fischer [Fri, 16 Jun 2006 16:37:07 +0000 (16:37 -0000)]
- do away with the fwd-decls of functions. Should not contain any code changes
AFAICT.
Rob Landley [Fri, 16 Jun 2006 16:35:53 +0000 (16:35 -0000)]
Revert svn 15333. If you vfork, you must either exec or exit. (The parent is
blocked until you do so.)
Rob Landley [Fri, 16 Jun 2006 15:08:59 +0000 (15:08 -0000)]
This directory was fallout from the great feature freeze of 2003, which led
up to the 1.00 release. I just moved what was left of it to
http://busybox.net/~landley/pending because it does _not_ belong in the
tree anymore.
Bernhard Reutner-Fischer [Fri, 16 Jun 2006 14:03:23 +0000 (14:03 -0000)]
- hide CONFIG_GETOPT_LONG for the 1.2.0 release. Turned on per default.
I will revisit this and make sure that run-parts and ifupdown are fixed; hdparm needs treatment too..
Bernhard Reutner-Fischer [Fri, 16 Jun 2006 12:45:29 +0000 (12:45 -0000)]
- add patch to provide a target 'html' to build a cross-reference of the source
Bernhard Reutner-Fischer [Fri, 16 Jun 2006 12:28:39 +0000 (12:28 -0000)]
- add needed includes and include busybox.h needed for the ATTRIBUTE define.
Rob Landley [Fri, 16 Jun 2006 04:25:19 +0000 (04:25 -0000)]
Remove warnings caused by #include <sys/mount.h> in platform.h. Apparently
we redefine a lot of stuff from standard header files...
Rob Landley [Thu, 15 Jun 2006 22:11:10 +0000 (22:11 -0000)]
Patch from Rich Felker:
- duplicated format bit 14 forced LIST_EXEC always-on
- -p option was behaving just like -F (SUSv3 says -p only shows / for
dirs, not other special symbols)
- tests for LIST_EXEC in color functions were nonsense (constant
tests). i assume they were supposed to be (all_fmt & LIST_EXEC)
however having coloring of executable files depend on -F seems
undesirable.
Bernhard Reutner-Fischer [Thu, 15 Jun 2006 21:56:28 +0000 (21:56 -0000)]
- use shorter boilerplate, more accurate header guard
- don't use multi-line string literals
Bernhard Reutner-Fischer [Thu, 15 Jun 2006 21:39:34 +0000 (21:39 -0000)]
- drats.
Bernhard Reutner-Fischer [Thu, 15 Jun 2006 21:35:35 +0000 (21:35 -0000)]
- let the scripts be prerequisites of the files the generate
- make sure that bbconfig isn't too stupid
Rob Landley [Thu, 15 Jun 2006 20:50:38 +0000 (20:50 -0000)]
Fix bug found by Joey Hess and forwarded by Bastian Bunk. Add Joey Hess's
test case to the testsuite, plus another one that would have been broken by
the first attempt at a fix.
Rob Landley [Thu, 15 Jun 2006 20:07:57 +0000 (20:07 -0000)]
Don't do workarounds for broken shells. Busybox is about to grow a shell that
we can run our own testsuite under, and I want it to handle the full range of
strange and peverted behavior you can find in real world shell scripts.
In the meantime, I'll just say #!/bin/bash in places that may care.
Rob Landley [Thu, 15 Jun 2006 17:34:57 +0000 (17:34 -0000)]
Jens Michaelsen pointed out that Linksys' firmware download side moved.
Rob Landley [Thu, 15 Jun 2006 16:00:42 +0000 (16:00 -0000)]
We came up with our own names for ATTRIBUTE_*, so why check if they're already
#defined? Also remove a check for a gcc version older than RH9 (if non-linux
needs that #define they can put it in their section.)
Rob Landley [Thu, 15 Jun 2006 15:49:36 +0000 (15:49 -0000)]
Patch from Yann Morin to put BLKGETSIZE64 in platform.h had rather a lot of
fallout due to the #include <sys/mount.h>. Removed that #include from various
applets and fixed up those that were unhappy when that #include was made
because they'd block copied stuff out of it. (Sigh.)
Rob Landley [Thu, 15 Jun 2006 15:04:53 +0000 (15:04 -0000)]
Help text update for libbb, talking about make standalone.
Bernhard Reutner-Fischer [Wed, 14 Jun 2006 17:33:57 +0000 (17:33 -0000)]
- there is no "CONFIG_STANDALONE" in the repository. Also iff there was a
CONFIG_STANDALONE, we'd need to toggle this on per default.
Bernhard Reutner-Fischer [Wed, 14 Jun 2006 17:32:11 +0000 (17:32 -0000)]
- rename CONFIG_FEATURE_TFTP_DEBUG to CONFIG_DEBUG_TFTP
Bernhard Reutner-Fischer [Wed, 14 Jun 2006 17:29:10 +0000 (17:29 -0000)]
- rename CONFIG_FEATURE_TFTP_DEBUG to CONFIG_DEBUG_TFTP so it's off in defconfig
- expand the cmd_get/cmd_put macros
- Jason Schoon writes: unlink only if non-stdio
Bernhard Reutner-Fischer [Wed, 14 Jun 2006 16:51:50 +0000 (16:51 -0000)]
- correct typo
Bernhard Reutner-Fischer [Wed, 14 Jun 2006 16:36:45 +0000 (16:36 -0000)]
- minor size tweak
text data bss dec hex filename
613 0 0 613 265 loginutils/su.o.orig
605 0 0 605 25d loginutils/su.o
Bernhard Reutner-Fischer [Wed, 14 Jun 2006 16:17:50 +0000 (16:17 -0000)]
- minor shrinkage
Rob Landley [Wed, 14 Jun 2006 01:51:16 +0000 (01:51 -0000)]
Attempt at fixing bug 836, vaguely based on patch from somebody named
clausmuus, forwarded to me by Yann E. Morin.
Rob Landley [Wed, 14 Jun 2006 01:27:01 +0000 (01:27 -0000)]
Upgrade the standalone shell code to use CONFIG_BUSYBOX_EXEC_PATH.
Rob Landley [Wed, 14 Jun 2006 01:24:33 +0000 (01:24 -0000)]
Attempt at fixing bug 815 by upgrading bb_spawn() so that builtins are at
the start of the path. (This should be under the same config option as
the standalone shell, but right now that's buried in the shell menu.)
Also add the ability to specify CONFIG_BUSYBOX_EXEC_PATH with /proc/self/exe
as an overrideable default.
Rob Landley [Tue, 13 Jun 2006 21:30:09 +0000 (21:30 -0000)]
Don't break allbareconfig.
Rob Landley [Tue, 13 Jun 2006 19:01:30 +0000 (19:01 -0000)]
Patch from Shaun Jackman to detect "name=value" variable assignments. Random
cleanup at the end by me to make some unrelated #ifdefs go away...
Rob Landley [Tue, 13 Jun 2006 18:50:20 +0000 (18:50 -0000)]
Make lash smaller. (Use llist_t for file closing, and different allocation
functions.)
Rob Landley [Tue, 13 Jun 2006 18:31:04 +0000 (18:31 -0000)]
Rewrite of dmesg, smaller and simpler.
Rob Landley [Tue, 13 Jun 2006 18:28:33 +0000 (18:28 -0000)]
Random cleanup of platform.h.
Rob Landley [Tue, 13 Jun 2006 18:27:16 +0000 (18:27 -0000)]
Work around a persistent uClibc bug, since 0.9.29 still hasn't shipped.
Poked to do this by Jason Schoon.
Rob Landley [Tue, 13 Jun 2006 17:10:26 +0000 (17:10 -0000)]
Patch from Denis Vlasenko:
* Rename a var: statbytes -> transferred
* cursize == transferred, always. Nuke cursize.
* Make progressmeter() a nop if !CONFIG_FEATURE_WGET_STATUSBAR
(reduces #ifdef forest)
* double elapsed -> int elapsed
* Do not sprintf to buf first and then write(STDERR) it,
just fprintf directly to stderr
* Progress bar printing code made smaller
* Style fixes
Rob Landley [Tue, 13 Jun 2006 16:44:26 +0000 (16:44 -0000)]
Whitespace cleanup from Denis Vlasenko.
Rob Landley [Tue, 13 Jun 2006 16:17:16 +0000 (16:17 -0000)]
Use -ffunction-sections -fdata-sections --gc-sections if the compiler supports
it. If nothing else, this gives us better granularity in bloatcheck.
Rob Landley [Tue, 13 Jun 2006 16:09:16 +0000 (16:09 -0000)]
Use xstat() instead of if(stat()) die()
Rob Landley [Tue, 13 Jun 2006 15:31:39 +0000 (15:31 -0000)]
Patch from Denis Vlasenko, tweak error messages.
Rob Landley [Tue, 13 Jun 2006 15:12:14 +0000 (15:12 -0000)]
Minor size shrinkage.
Rob Landley [Tue, 13 Jun 2006 14:54:42 +0000 (14:54 -0000)]
Patch from Denis Vlasenko: unlzma was make files with mode 777. Tweak
everything to do stat() and use xopen3().
Rob Landley [Tue, 13 Jun 2006 14:37:14 +0000 (14:37 -0000)]
Fix from Paul Fox to make compressed help text notice config changes.
Bernhard Reutner-Fischer [Tue, 13 Jun 2006 14:20:17 +0000 (14:20 -0000)]
- make VERBOSE= and V= work equally; use BUILD_VERBOSE internally.
- move the link flags to cmd_link* so they are printed when requesting verbose output
Bernhard Reutner-Fischer [Mon, 12 Jun 2006 14:34:01 +0000 (14:34 -0000)]
- fix stupid typo from last checkin
Bernhard Reutner-Fischer [Sun, 11 Jun 2006 18:04:23 +0000 (18:04 -0000)]
- remove superfluous CONFIG_BEGIN and CONFIG_END
Bernhard Reutner-Fischer [Sun, 11 Jun 2006 17:24:01 +0000 (17:24 -0000)]
- add fancy mode to start-stop-daemon to support --oknodo and --verbose
Bernhard Reutner-Fischer [Sun, 11 Jun 2006 16:41:10 +0000 (16:41 -0000)]
- invert logic for nocheck_targets to exclude the empty default target.
Bernhard Reutner-Fischer [Sat, 10 Jun 2006 14:58:33 +0000 (14:58 -0000)]
- don't check for toolchain-setting for make targets that don't need them
- we already depend on sed, so do away with tr. Avoids pulling in yet another
dependency.
Bernhard Reutner-Fischer [Sat, 10 Jun 2006 14:32:56 +0000 (14:32 -0000)]
- revert incorrect select change
Bernhard Reutner-Fischer [Sat, 10 Jun 2006 14:15:03 +0000 (14:15 -0000)]
- fix two segfaults (reported by Horst Kronstorfer)
- remove dangling file if get fails (spotted and fixed by Jason Schoon)
- shrink it (Bernhard Fischer)
Thanks, all!
text data bss dec hex filename
2684 0 0 2684 a7c networking/tftp.o.orig
2748 0 0 2748 abc networking/tftp.o.allfixed
2666 0 0 2666 a6a networking/tftp.o.+shrink
Bernhard Reutner-Fischer [Sat, 10 Jun 2006 11:39:09 +0000 (11:39 -0000)]
- use bb_xbind
Thanks Erik Hovland
Bernhard Reutner-Fischer [Sat, 10 Jun 2006 11:29:44 +0000 (11:29 -0000)]
- use bb_xchdir instead of ignoring eventual errors of chdir
Thanks to Erik Hovland
Bernhard Reutner-Fischer [Sat, 10 Jun 2006 11:04:43 +0000 (11:04 -0000)]
- fix bug #887, in bb_get_chomped_line_from_file(), the last char was removed
unconditionally, even if it was not a newline.
This was apparently broken by r14254
- whitespace while at it.
Paul Fox [Fri, 9 Jun 2006 12:25:10 +0000 (12:25 -0000)]
add ordering warning on enum Location
Bernhard Reutner-Fischer [Fri, 9 Jun 2006 07:12:27 +0000 (07:12 -0000)]
- make sure that we see string_insert only if we need it.
Paul Fox [Thu, 8 Jun 2006 21:48:47 +0000 (21:48 -0000)]
remove leading "Enable" from the config option text. not only is it
redundant, but it made the menuconfig shortcut mechanism mostly
useless, since so many of the entries started with 'E'.
Paul Fox [Thu, 8 Jun 2006 21:37:26 +0000 (21:37 -0000)]
made "test" an ash built-in.
moved the contents of libbb/bb_echo.c back into coreutils/echo.c,
which is a more reasonable place for them than libbb. this
forces anyone who wants echo and test to be builtin to ash to
also have them available as applets. their cost is very small,
and the number of people who wouldn't want them as applets is
also very small.
added warning about shell builtins vs. CONFIG_FEATURE_SH_STANDALONE_SHELL,
which conflicts with their use.
thanks to nathanael copa for debugging help.
some string size optimization in test.c may have been lost with
this commit, but this is a good new baseline.
Rob Landley [Thu, 8 Jun 2006 14:19:48 +0000 (14:19 -0000)]
Patch from Erik Hovland, via Tito.
Rob Landley [Thu, 8 Jun 2006 14:11:36 +0000 (14:11 -0000)]
Some day, maybe gcc will be able to optimize out static functions that are
never used so we don't have to #ifdef them. Wouldn't that be nice?
Mike Frysinger [Wed, 7 Jun 2006 21:58:57 +0000 (21:58 -0000)]
need prototype for new vfork_daemon()
Mike Frysinger [Wed, 7 Jun 2006 21:48:43 +0000 (21:48 -0000)]
initial support for no-mmu systems
Mike Frysinger [Wed, 7 Jun 2006 21:48:30 +0000 (21:48 -0000)]
sometimes daemonizing and vfork()/exit() is ok
Mike Frysinger [Wed, 7 Jun 2006 21:47:34 +0000 (21:47 -0000)]
bb_xdaemon() isnt available on no-mmu systems
Mike Frysinger [Wed, 7 Jun 2006 21:37:59 +0000 (21:37 -0000)]
comment all fields
Mike Frysinger [Wed, 7 Jun 2006 21:37:49 +0000 (21:37 -0000)]
hint at where the Magic comes from
Bernhard Reutner-Fischer [Wed, 7 Jun 2006 21:26:09 +0000 (21:26 -0000)]
- do away with the comment that noted that the current implementation
unly supports linux.