Bodo Möller [Thu, 7 Dec 2000 22:06:09 +0000 (22:06 +0000)]
Fix some things that look like bugs.
One problem that looked like a problem in bn_recp.c at first turned
out to be a BN_mul bug. An example is given in bn_recp.c; finding
the bug responsible for this is left as an exercise.
Bodo Möller [Thu, 7 Dec 2000 11:11:10 +0000 (11:11 +0000)]
TEST_MUL and TEST_SQR added.
Bodo Möller [Thu, 7 Dec 2000 08:48:58 +0000 (08:48 +0000)]
Sign-related fixes (and tests).
BN_mod_exp_mont does not work properly yet if modulus m
is negative (we want computations to be carried out
modulo |m|).
Bodo Möller [Thu, 7 Dec 2000 07:55:26 +0000 (07:55 +0000)]
Move 'q->neg = 0' to those places where it is needed
(just in cases someone uses a negative modulus)
Bodo Möller [Wed, 6 Dec 2000 21:33:58 +0000 (21:33 +0000)]
BN_mod_sqrt documentation/comment
Ulf Möller [Wed, 6 Dec 2000 16:39:09 +0000 (16:39 +0000)]
Don't check for bc at all. We can now run a meaningful test even if
it is missing.
Ulf Möller [Wed, 6 Dec 2000 16:30:23 +0000 (16:30 +0000)]
remove a comment that shouldn't have been there any more
Bodo Möller [Wed, 6 Dec 2000 12:25:33 +0000 (12:25 +0000)]
Faster BN_mod_sqrt algorithm for p == 5 (8).
Bodo Möller [Wed, 6 Dec 2000 12:24:27 +0000 (12:24 +0000)]
Printing "verify ..." should not be counted as a test for the
"xxx tests passed" message.
Richard Levitte [Wed, 6 Dec 2000 10:58:13 +0000 (10:58 +0000)]
During the self test, we only want to know what bctest says on
stderr...
Richard Levitte [Wed, 6 Dec 2000 10:54:31 +0000 (10:54 +0000)]
Have the self test use bctest to check that bc is sane.
Bodo Möller [Wed, 6 Dec 2000 10:32:55 +0000 (10:32 +0000)]
Use bc's "print" feature whenever it is available,
not just on certain platforms.
Bodo Möller [Wed, 6 Dec 2000 09:53:29 +0000 (09:53 +0000)]
Add a comment.
Bodo Möller [Wed, 6 Dec 2000 09:48:57 +0000 (09:48 +0000)]
Workaround for broken (or missing) bc.
Ulf Möller [Wed, 6 Dec 2000 04:48:50 +0000 (04:48 +0000)]
remove useless instruction
Ulf Möller [Wed, 6 Dec 2000 04:16:38 +0000 (04:16 +0000)]
Intel assembler version for bn_sub_part_words(). I haven't got
reliable timings yet, please try it out!
Ulf Möller [Wed, 6 Dec 2000 04:14:37 +0000 (04:14 +0000)]
another fix for the debug print
Ulf Möller [Wed, 6 Dec 2000 04:14:30 +0000 (04:14 +0000)]
test_mod_mul is useful, let's run it more often.
Ulf Möller [Wed, 6 Dec 2000 00:19:09 +0000 (00:19 +0000)]
move constants for debug functions to end of file
Richard Levitte [Tue, 5 Dec 2000 19:18:51 +0000 (19:18 +0000)]
Update the internal docs.
Lutz Jänicke [Tue, 5 Dec 2000 16:47:22 +0000 (16:47 +0000)]
Typo and additional information about cert-chain building.
Lutz Jänicke [Tue, 5 Dec 2000 16:45:26 +0000 (16:45 +0000)]
Add EXAMPLES for SSL_CIPHER_description() output.
Bodo Möller [Tue, 5 Dec 2000 10:30:21 +0000 (10:30 +0000)]
Discuss http://www.shoup.net/papers/oaep.ps.Z
Richard Levitte [Tue, 5 Dec 2000 08:16:25 +0000 (08:16 +0000)]
On Windows, Rainbow uses _stdcall convention under Windows.
Spotted by plin <plin@rainbow.com>
Ulf Möller [Tue, 5 Dec 2000 06:38:45 +0000 (06:38 +0000)]
push the flags too
Ulf Möller [Tue, 5 Dec 2000 05:39:43 +0000 (05:39 +0000)]
looks like it works now
Ulf Möller [Tue, 5 Dec 2000 05:10:05 +0000 (05:10 +0000)]
save registers in the debug output code (return value is overwritten too)
Ulf Möller [Tue, 5 Dec 2000 04:39:39 +0000 (04:39 +0000)]
more of the same: add printf() for perlasm.
Ulf Möller [Tue, 5 Dec 2000 03:57:58 +0000 (03:57 +0000)]
minor modification to the previous change
Ulf Möller [Tue, 5 Dec 2000 03:51:46 +0000 (03:51 +0000)]
PERLASM - the wierdest programming language since Intercal.
add debug output facilities.
Ulf Möller [Tue, 5 Dec 2000 02:00:40 +0000 (02:00 +0000)]
Use assert as in the rest of the BN library.
Bodo Möller [Mon, 4 Dec 2000 19:04:55 +0000 (19:04 +0000)]
Improve formatting.
Richard Levitte [Mon, 4 Dec 2000 17:17:03 +0000 (17:17 +0000)]
It's completely unnecessary to add a compression algorithm that is
really undefined.
Spotted by Jeffrey Altman <jaltman@columbia.edu>
Richard Levitte [Mon, 4 Dec 2000 17:11:59 +0000 (17:11 +0000)]
Remove the last bn_wexpand()s that made us break constness. Of
course, that means we need to handle the cases where the two arrays to
bn_mul_recursive() and bn_mul_part_recursive() differ in size.
I haven't yet changed the comments that describe bn_mul_recursive()
and bn_mul_part_recursive(). I want this to be tested by more people
before I consider this change final. Please test away!
Bodo Möller [Mon, 4 Dec 2000 09:24:54 +0000 (09:24 +0000)]
Change error message to "bignum too long"
Geoff Thorpe [Mon, 4 Dec 2000 04:54:59 +0000 (04:54 +0000)]
Sync up with a minor change in lhash.h
Geoff Thorpe [Mon, 4 Dec 2000 04:52:38 +0000 (04:52 +0000)]
ANSI C doesn't allow trailing semi-colons after a function's closing brace
so these macros probably shouldn't be used like that at all. So, this
change removes the misleading comment and also adds an implicit trailing
semi-colon to the DECLARE macros so they too don't require one.
Geoff Thorpe [Mon, 4 Dec 2000 04:35:04 +0000 (04:35 +0000)]
Update the documentation to the current state of the LHASH changes. There
will probably be more when the lh_doall[_arg] callbacks are similarly
tidied up, but this 'pod' should now be current.
Geoff Thorpe [Mon, 4 Dec 2000 03:35:35 +0000 (03:35 +0000)]
Make a note of the LHASH changes.
Geoff Thorpe [Mon, 4 Dec 2000 03:02:44 +0000 (03:02 +0000)]
Make the remaining LHASH macro changes. This should leave no remaining
cases of function pointer casting in lh_new() calls - and leave only the
lh_doall and lh_doall_arg cases to be finished.
Ben Laurie [Sun, 3 Dec 2000 10:04:22 +0000 (10:04 +0000)]
Fix warnings.
Bodo Möller [Sun, 3 Dec 2000 09:55:08 +0000 (09:55 +0000)]
include <limits.h>
Bodo Möller [Sun, 3 Dec 2000 09:39:04 +0000 (09:39 +0000)]
Don't allow BIGNUMs to become so large that computations with dmax
might overflow.
Geoff Thorpe [Sat, 2 Dec 2000 23:16:54 +0000 (23:16 +0000)]
Use the new LHASH macros to declare type-safe wrapper functions that can
be used as the hash/compare callbacks without function pointer casting.
For now, this is just happening in the apps/ directory whilst a few people
check the approach. The rest of the library will be moved across to the
same idea if there's no problems with this.
Geoff Thorpe [Sat, 2 Dec 2000 23:08:59 +0000 (23:08 +0000)]
Next step in tidying up the LHASH code. This commit defines DECLARE and
IMPLEMENT macros for defining wrapper functions for "hash" and "cmp" callbacks
that are specific to the underlying item type in a hash-table. This prevents
function pointer casting altogether, and also provides some type-safety
because the macro does per-variable casting from the (void *) type used in
LHASH itself to the type declared in the macro - and if that doesn't match the
prototype expected by the "hash" or "cmp" function then a compiler error will
result.
NB: IMPLEMENT macros are not required unless predeclared forms are required
(either in a header file, or further up in a C file than the implementation
needs to be). The DECLARE macros must occur after the type-specific hash/cmp
callbacks are declared. Also, the IMPLEMENT and DECLARE macros are such that
they can be prefixed with "static" if desired and a trailing semi-colon should
be appended (making it look more like a regular declaration and easier on
auto-formatting text-editors too).
Now that these macros are defined, I will next be commiting changes to a
number of places in the library where the casting was doing bad things. After
that, the final step will be to make the analogous changes for the lh_doall
and lh_doall_arg functions (more specifically, their callback parameters).
Richard Levitte [Sat, 2 Dec 2000 21:16:13 +0000 (21:16 +0000)]
Add a comment to explain the purpose of bn_cmp_part_words().
Ulf Möller [Sat, 2 Dec 2000 20:51:47 +0000 (20:51 +0000)]
last commit was wrong. Now it works. :)
Ulf Möller [Sat, 2 Dec 2000 19:34:42 +0000 (19:34 +0000)]
argl
Ulf Möller [Sat, 2 Dec 2000 18:50:31 +0000 (18:50 +0000)]
remember the problem with ftime()
Ulf Möller [Sat, 2 Dec 2000 16:20:04 +0000 (16:20 +0000)]
forgot to remove the loop variable
Ulf Möller [Sat, 2 Dec 2000 16:13:27 +0000 (16:13 +0000)]
Loops like this one:
if (bp == NULL)
for (j=0; j<10000; j++)
BN_add(&c,&a,&b);
seem to be pretty useless, and bp never is NULL anyway.
Ulf Möller [Sat, 2 Dec 2000 08:11:55 +0000 (08:11 +0000)]
Move the rijndael "test" to the bf and cast tests.
Ulf Möller [Sat, 2 Dec 2000 07:50:30 +0000 (07:50 +0000)]
Note the bntest change.
The *_part_words functions are not static.
Ulf Möller [Sat, 2 Dec 2000 07:32:57 +0000 (07:32 +0000)]
New function BN_bntest_rand() to detect more BN library bugs.
The bn_cmp_part_words bug was only caught in the BN_mod_mul() test,
not in the BN_mul() test, so apparently the choice of parameters in
some cases is bad.
Ulf Möller [Sat, 2 Dec 2000 07:28:43 +0000 (07:28 +0000)]
Fix bn_cmp_part_words() and move it to bn_lib.c.
Ulf Möller [Sat, 2 Dec 2000 07:20:47 +0000 (07:20 +0000)]
remove unused static function
Geoff Thorpe [Fri, 1 Dec 2000 20:31:52 +0000 (20:31 +0000)]
First step in tidying up the LHASH code. The callback prototypes (and
casts) used in the lhash code are about as horrible and evil as they can
be. For starters, the callback prototypes contain empty parameter lists.
Yuck.
This first change defines clearer prototypes - including "typedef"'d
function pointer types to use as "hash" and "compare" callbacks, as well as
the callbacks passed to the lh_doall and lh_doall_arg iteration functions.
Now at least more explicit (and clear) casting is required in all of the
dependant code - and that should be included in this commit.
The next step will be to hunt down and obliterate some of the function
pointer casting being used when it's not necessary - a particularly evil
variant exists in the implementation of lh_doall.
Richard Levitte [Fri, 1 Dec 2000 17:44:33 +0000 (17:44 +0000)]
Write a first HOWTO on how to create certificates. This is currently
a draft.
Richard Levitte [Fri, 1 Dec 2000 16:49:53 +0000 (16:49 +0000)]
Correct a mail address...
Richard Levitte [Fri, 1 Dec 2000 14:40:45 +0000 (14:40 +0000)]
Document the addition of Kerberos stuff.
Richard Levitte [Fri, 1 Dec 2000 14:33:19 +0000 (14:33 +0000)]
Typo corrected.
Bodo Möller [Fri, 1 Dec 2000 09:41:21 +0000 (09:41 +0000)]
functionality for BN_mod_sqrt timings
Bodo Möller [Fri, 1 Dec 2000 08:48:42 +0000 (08:48 +0000)]
"make depend"
Bodo Möller [Fri, 1 Dec 2000 08:46:47 +0000 (08:46 +0000)]
update
Ulf Möller [Fri, 1 Dec 2000 02:47:50 +0000 (02:47 +0000)]
GPL FAQ.
I hope this adequately summarizes the results of all those disussions.
Ulf Möller [Fri, 1 Dec 2000 01:53:08 +0000 (01:53 +0000)]
Borland C fix.
Ulf Möller [Fri, 1 Dec 2000 01:51:04 +0000 (01:51 +0000)]
typo
Richard Levitte [Fri, 1 Dec 2000 01:11:54 +0000 (01:11 +0000)]
Recognise Darwin as well. For now, have it do exactly the same thing as for Rhapsody
Bodo Möller [Thu, 30 Nov 2000 23:41:58 +0000 (23:41 +0000)]
COMP_zlib should always be declared, even if it is not functional.
Don't dump core in ssltest.
Bodo Möller [Thu, 30 Nov 2000 22:58:27 +0000 (22:58 +0000)]
Fix the recently introduced test that checks if the result is 0
Richard Levitte [Thu, 30 Nov 2000 22:53:34 +0000 (22:53 +0000)]
First tentative impementation of Kerberos 5 cryptos and keys for SSL/TLS. Implemented by Vern Staats <staatsvr@asc.hpc.mil>, further hacked and distributed by Jeffrey Altman <jaltnab@columbia.edu>
Bodo Möller [Thu, 30 Nov 2000 22:34:57 +0000 (22:34 +0000)]
Fix BN_rshift, which caused lots of trouble.
Bodo Möller [Thu, 30 Nov 2000 21:03:13 +0000 (21:03 +0000)]
Remove randomness from the test. These constants give me a segment
violation in test_kron on a 32 bit system.
Bodo Möller [Thu, 30 Nov 2000 20:03:24 +0000 (20:03 +0000)]
BN_mod_exp(r,a,p,m,ctx) should not be called with r == p.
But even if this is avoided, there are still segmentation violations
(during one of the BN_free()s at the end of test_kron
in some cases, in other cases during BN_kronecker, or
later in BN_sqrt; choosing a different exponentiation
algorithm in bntest.c appears to influence when the SIGSEGV
takes place).
Bodo Möller [Thu, 30 Nov 2000 19:35:51 +0000 (19:35 +0000)]
It's "#elif", not "#elsif".
Richard Levitte [Thu, 30 Nov 2000 17:41:01 +0000 (17:41 +0000)]
A few bug fixes for Windows.
Bodo Möller [Thu, 30 Nov 2000 17:35:17 +0000 (17:35 +0000)]
Changes to Lenka's Montgomery implementation.
Submitted by: Lenka Fibikova
Richard Levitte [Thu, 30 Nov 2000 13:04:14 +0000 (13:04 +0000)]
New format for the FAQ. We now have different sections for different
types of questions. Hopefully, that'll make them easier to spot, and
specially, easier to refer to.
Bodo Möller [Thu, 30 Nov 2000 12:53:53 +0000 (12:53 +0000)]
Corrections to the comments in BN_mod_inverse.
Richard Levitte [Thu, 30 Nov 2000 12:53:15 +0000 (12:53 +0000)]
The compression method may be undefined for some reason that has
generated errors. Therefore, print whatever error there may be...
Richard Levitte [Thu, 30 Nov 2000 12:22:35 +0000 (12:22 +0000)]
Simplify and provide the possibility to clean a compression method.
Richard Levitte [Thu, 30 Nov 2000 12:21:33 +0000 (12:21 +0000)]
comp_methods in a SSL_CTX points at an internal database. Do *not*
free that, since it's shared by all SSL_CTX's, present and future.
Richard Levitte [Thu, 30 Nov 2000 12:19:54 +0000 (12:19 +0000)]
Turn off memory checking when loading new compression algorithms.
Richard Levitte [Thu, 30 Nov 2000 12:18:10 +0000 (12:18 +0000)]
COMP_METHOD has a new argument since some time back...
Richard Levitte [Thu, 30 Nov 2000 11:57:31 +0000 (11:57 +0000)]
Make it possible to test SSL compression
Richard Levitte [Thu, 30 Nov 2000 11:56:00 +0000 (11:56 +0000)]
Change c_zlib further to allow loading a shared zlib on all operating
systems where such an operation is supported.
Bodo Möller [Thu, 30 Nov 2000 11:47:04 +0000 (11:47 +0000)]
BN_mod_exp problems ...
Richard Levitte [Thu, 30 Nov 2000 10:25:45 +0000 (10:25 +0000)]
Changes to c_zlib.c to make ZLIB.DLL dynamically loadable under
Windows. Really, this should probably be done on Unix as well, but
that will be a later story...
Bodo Möller [Thu, 30 Nov 2000 09:45:26 +0000 (09:45 +0000)]
Move reduction step from BN_mod_exp to BN_mod_exp_mont_word.
Fix BN_mod_exp_simple for a==0 (mod m).
Skip useless round in BN_mod_sqrt (1 is always a square, no need
to test BN_kronecker for it).
Geoff Thorpe [Thu, 30 Nov 2000 01:34:26 +0000 (01:34 +0000)]
* Fix a slight bug in the state-machine. This caused the client end of a
tunnel to not pro-actively close down when failing an SSL handshake.
* Change the cert-chain callback - originally this was the same one used in
s_client and s_server but the output's as ugly as sin, so I've prettied
tunala's copy output up a bit (and made the output level configurable).
* Remove the superfluous "errors" from the SSL state callback - these are just
non-blocking side-effects.
Bodo Möller [Thu, 30 Nov 2000 00:43:41 +0000 (00:43 +0000)]
bn_modfs.c is no longer needed, a BN_sqrt implementation
exists in bn_sqrt.c now
Bodo Möller [Thu, 30 Nov 2000 00:37:49 +0000 (00:37 +0000)]
Fix bntest.c problem -- one of the primes got lost
Bodo Möller [Thu, 30 Nov 2000 00:33:18 +0000 (00:33 +0000)]
Handle special cases correctly in exponentation functions.
test_bn still fails in the BN_sqrt test because
small primes appear to turn into zero for no
obvious reason, leading to "div by zero" errors.
Bodo Möller [Thu, 30 Nov 2000 00:20:20 +0000 (00:20 +0000)]
BN_mod_sqrt
Bodo Möller [Thu, 30 Nov 2000 00:18:19 +0000 (00:18 +0000)]
BN_sqrt
Ulf Möller [Wed, 29 Nov 2000 22:37:14 +0000 (22:37 +0000)]
Add a warning about the usage of the montgomery functions (if the inputs
are not reduced modulo m, the outputs won't be either).
Geoff Thorpe [Wed, 29 Nov 2000 20:02:00 +0000 (20:02 +0000)]
Amend the original CHANGES log entry. The ex_data handling has been
similarly modified now on DH and DSA.
Bodo Möller [Wed, 29 Nov 2000 19:59:59 +0000 (19:59 +0000)]
BN_legendre is no longer needed now that OpenSSL has BN_kronecker.
Geoff Thorpe [Wed, 29 Nov 2000 19:59:45 +0000 (19:59 +0000)]
Do to DH and DSA what has already been done to RSA. This involves moving
the initialisation and cleanup of "ex_data" elements to before an init()
handler and after a finish() handler respectively.
Bodo Möller [Wed, 29 Nov 2000 19:29:47 +0000 (19:29 +0000)]
mark a bug