oweals/busybox.git
16 years agowatchdog: add -T option
Denis Vlasenko [Sun, 7 Sep 2008 23:22:08 +0000 (23:22 -0000)]
watchdog: add -T option
 function                                             old     new   delta
 watchdog_main                                        159     219     +60
mdev: support match by major,minor. See bug 4714.
 +100 bytes.

16 years agoifenslave: on uclibc at least, net/if.h + linux/if_bonding.h dont coexist
Denis Vlasenko [Sat, 6 Sep 2008 14:52:28 +0000 (14:52 -0000)]
ifenslave: on uclibc at least, net/if.h + linux/if_bonding.h dont coexist

16 years agoifenslave: wants net/if.h
Denis Vlasenko [Sat, 6 Sep 2008 14:42:27 +0000 (14:42 -0000)]
ifenslave: wants net/if.h

16 years agoinstall: shrink -D code. By Bernhard.
Denis Vlasenko [Sat, 6 Sep 2008 14:35:08 +0000 (14:35 -0000)]
install: shrink -D code. By Bernhard.

function                                             old     new   delta
install_main                                         726     707     -19

16 years agomodprobe-small: make insmod command line compatible
Denis Vlasenko [Sat, 6 Sep 2008 14:14:01 +0000 (14:14 -0000)]
modprobe-small: make insmod command line compatible

function                                             old     new   delta
modprobe_main                                        326     435    +109
moderror                                               -      52     +52
process_module                                       577     530     -47

16 years ago- commentary typo fix
Bernhard Reutner-Fischer [Fri, 5 Sep 2008 11:46:43 +0000 (11:46 -0000)]
- commentary typo fix

16 years agoawk: add a comment
Denis Vlasenko [Fri, 5 Sep 2008 04:59:02 +0000 (04:59 -0000)]
awk: add a comment

16 years ago- uncomment tc for now
Bernhard Reutner-Fischer [Thu, 4 Sep 2008 16:16:47 +0000 (16:16 -0000)]
- uncomment tc for now

16 years ago- add WIP stub for tc.
Bernhard Reutner-Fischer [Thu, 4 Sep 2008 13:22:58 +0000 (13:22 -0000)]
- add WIP stub for tc.
  Printing worked at some point. Modify/Delete needs some refacturing.

16 years ago- mention that we ignore -v, -b, -c
Bernhard Reutner-Fischer [Thu, 4 Sep 2008 09:33:23 +0000 (09:33 -0000)]
- mention that we ignore -v, -b, -c

16 years agokbd_mode: fix non-ASCII letters in comments
Denis Vlasenko [Wed, 3 Sep 2008 21:54:46 +0000 (21:54 -0000)]
kbd_mode: fix non-ASCII letters in comments
install: support -D

16 years agoawk: improve nadling of negative numbers in bitwise ops;
Denis Vlasenko [Tue, 2 Sep 2008 09:00:23 +0000 (09:00 -0000)]
awk: improve nadling of negative numbers in bitwise ops;
 fix handling of octal costants. add test for it

function                                             old     new   delta
getvar_i_int                                           -      93     +93
my_strtod                                              -      84     +84
qrealloc                                              33      36      +3
getvar_i                                              99      95      -4
next_token                                           979     919     -60
evaluate                                            6359    5627    -732
------------------------------------------------------------------------------
(add/remove: 2/0 grow/shrink: 1/3 up/down: 180/-796)         Total: -616 bytes

16 years ago- pass "Accept:" and "Accept-Language:" header to CGI scripts (Alina Friedrichsen)
Bernhard Reutner-Fischer [Mon, 1 Sep 2008 15:30:49 +0000 (15:30 -0000)]
- pass "Accept:" and "Accept-Language:" header to CGI scripts (Alina Friedrichsen)

Alina writes:
With this patch the BusyBox httpd pass the "Accept:" and
"Accept-Language:" header by the environment variables to the
CGI-Script, so this can make Content Negotiation to deliver the page in
the language, which was selected by the user in the browser settings,
and/or serve the XHTML page with the right MIME-Type
application/xhtml+xml to user agents which support it und text/html
which don't.

(Needed e.g. for OpenWrt LuCI.)

Signed-off-by: Alina Friedrichsen <x-alina at gmx dot net>
16 years ago- remove excess whitespace (Vladimir Dronnikov)
Bernhard Reutner-Fischer [Mon, 1 Sep 2008 15:26:12 +0000 (15:26 -0000)]
- remove excess whitespace (Vladimir Dronnikov)

16 years ago- halt's -w depends on FEATURE_WTMP (Vladimir Dronnikov)
Bernhard Reutner-Fischer [Mon, 1 Sep 2008 15:24:52 +0000 (15:24 -0000)]
- halt's -w depends on FEATURE_WTMP (Vladimir Dronnikov)

16 years ago- add ether-wake to the hardcoded(argh!) list of APPLET_ODDNAME
Bernhard Reutner-Fischer [Mon, 1 Sep 2008 15:23:04 +0000 (15:23 -0000)]
- add ether-wake to the hardcoded(argh!) list of APPLET_ODDNAME

16 years agoinsmod: fix detection of open failure
Denis Vlasenko [Sun, 31 Aug 2008 21:56:48 +0000 (21:56 -0000)]
insmod: fix detection of open failure

16 years agobuild system: fix "Possible unintended interpolation of @host"
Denis Vlasenko [Sun, 31 Aug 2008 21:29:35 +0000 (21:29 -0000)]
build system: fix "Possible unintended interpolation of @host"
 message

16 years agobuild system: echo and test features may be enabled
Denis Vlasenko [Fri, 29 Aug 2008 08:37:07 +0000 (08:37 -0000)]
build system: echo and test features may be enabled
 even if these applets are enabled as ash builtins only
testsuite: add some awk tests

16 years agoawk: bitwise ops cast oprands and results to unsigned long,
Denis Vlasenko [Thu, 28 Aug 2008 23:16:58 +0000 (23:16 -0000)]
awk: bitwise ops cast oprands and results to unsigned long,
 not signed. closes 4774.

16 years agoawk: support hex constants
Denis Vlasenko [Thu, 28 Aug 2008 22:59:23 +0000 (22:59 -0000)]
awk: support hex constants

16 years agodf: add support for more options, add some coreutils 6.10 compat.
Denis Vlasenko [Thu, 28 Aug 2008 22:42:52 +0000 (22:42 -0000)]
df: add support for more options, add some coreutils 6.10 compat.
 by Bernhard Reutner-Fischer

function                                             old     new   delta
df_main                                              664     795    +131
packed_usage                                       24812   24862     +50
make_human_readable_str                              213     262     +49
static.ignored_mounts                                  -       8      +8
static.unit_chars                                      -       7      +7
static.zero_and_units                                  6       -      -6
------------------------------------------------------------------------------
(add/remove: 2/1 grow/shrink: 3/0 up/down: 245/-6)            Total: 239 bytes

16 years agoinsmod: mix xmalloc with xrealloc_vector more carefully
Denis Vlasenko [Thu, 28 Aug 2008 21:38:10 +0000 (21:38 -0000)]
insmod: mix xmalloc with xrealloc_vector more carefully

16 years ago- forgot to pass in the HOST_EXTRACFLAGS
Bernhard Reutner-Fischer [Thu, 28 Aug 2008 14:29:54 +0000 (14:29 -0000)]
- forgot to pass in the HOST_EXTRACFLAGS

16 years agoinsmod: shrink
Denis Vlasenko [Wed, 27 Aug 2008 22:29:43 +0000 (22:29 -0000)]
insmod: shrink

function                                             old     new   delta
obj_allocate_commons                                 488     462     -26
insmod_main                                         3830    3714    -116

16 years agocksum: respect CONFIG_LFS=y. Adds 36 bytes in this case.
Denis Vlasenko [Wed, 27 Aug 2008 21:31:23 +0000 (21:31 -0000)]
cksum: respect CONFIG_LFS=y. Adds 36 bytes in this case.

16 years ago- pull check-lxdialog from linux-2.6.26
Bernhard Reutner-Fischer [Wed, 27 Aug 2008 07:39:57 +0000 (07:39 -0000)]
- pull check-lxdialog from linux-2.6.26

16 years agotrylink: make messages less confusing
Denis Vlasenko [Tue, 26 Aug 2008 20:09:08 +0000 (20:09 -0000)]
trylink: make messages less confusing

16 years agomodprobe-small: support "blacklist" keyword in /etc/modules/<modulename>
Denis Vlasenko [Tue, 26 Aug 2008 01:32:33 +0000 (01:32 -0000)]
modprobe-small: support "blacklist" keyword in /etc/modules/<modulename>

16 years agoreinstate sponsor's links
Denis Vlasenko [Mon, 25 Aug 2008 22:03:41 +0000 (22:03 -0000)]
reinstate sponsor's links

16 years agofbset: fix mode matching code: original code may trigger false positive.
Denis Vlasenko [Sun, 24 Aug 2008 16:25:40 +0000 (16:25 -0000)]
fbset: fix mode matching code: original code may trigger false positive.
 E.g. fbset -n '16bit'
 succeeded at 'mode "640x480 16bit"' and that is wrong.
 Also parser is rewritten. By Vladimir.

function                                             old     new   delta
static.syncs                                           -      20     +20
g_options                                              4       -      -4
g_cmdoptions                                         432     385     -47
fbset_main                                          1842    1642    -200

16 years agoping: SO_RCVBUF must be bigger than packet size,
Denis Vlasenko [Sun, 24 Aug 2008 00:02:18 +0000 (00:02 -0000)]
ping: SO_RCVBUF must be bigger than packet size,
 otherwise large ping packets might fail to be received.

16 years agohexdump: fix SEGV in hexdump -e ""
Denis Vlasenko [Sat, 23 Aug 2008 23:15:48 +0000 (23:15 -0000)]
hexdump: fix SEGV in hexdump -e ""

16 years agosetarch: do not try to use non-existent data in argv[]
Denis Vlasenko [Sat, 23 Aug 2008 23:15:17 +0000 (23:15 -0000)]
setarch: do not try to use non-existent data in argv[]

16 years agotweak web page
Denis Vlasenko [Fri, 22 Aug 2008 11:16:52 +0000 (11:16 -0000)]
tweak web page

16 years ago- move some older news to the news archive (the main page was once again over 30kib...
Bernhard Reutner-Fischer [Fri, 22 Aug 2008 08:45:01 +0000 (08:45 -0000)]
- move some older news to the news archive (the main page was once again over 30kib big)

16 years ago- reformat help text
Bernhard Reutner-Fischer [Fri, 22 Aug 2008 08:25:26 +0000 (08:25 -0000)]
- reformat help text

16 years agoAnnounce 1.11.2
Denis Vlasenko [Thu, 21 Aug 2008 22:10:47 +0000 (22:10 -0000)]
Announce 1.11.2

16 years ago- print the documentation per default
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 21:15:28 +0000 (21:15 -0000)]
- print the documentation per default

16 years ago- document rmdir args
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 20:52:55 +0000 (20:52 -0000)]
- document rmdir args

16 years ago- document rmmod -w and -f arguments
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 20:18:55 +0000 (20:18 -0000)]
- document rmmod -w and -f arguments

16 years agofix xargs -e help text
Denis Vlasenko [Thu, 21 Aug 2008 19:59:30 +0000 (19:59 -0000)]
fix xargs -e help text

16 years ago- tweak markup. No relevant changes
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 16:08:06 +0000 (16:08 -0000)]
- tweak markup. No relevant changes

16 years ago- cleanup urls
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 14:37:14 +0000 (14:37 -0000)]
- cleanup urls

16 years ago- fix typo
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 14:14:36 +0000 (14:14 -0000)]
- fix typo

16 years ago- fix markup
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 14:10:55 +0000 (14:10 -0000)]
- fix markup

16 years ago- do not advertise the standalone udhcpd. It is actively maintained in busybox only.
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 14:08:44 +0000 (14:08 -0000)]
- do not advertise the standalone udhcpd. It is actively maintained in busybox only.

16 years ago- fix markup
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 14:00:25 +0000 (14:00 -0000)]
- fix markup

16 years ago- add doc-clean target
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 13:47:20 +0000 (13:47 -0000)]
- add doc-clean target

16 years ago- add note about CONFIG_CROSS_COMPILER_PREFIX while cleanup up markup.
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 13:37:47 +0000 (13:37 -0000)]
- add note about CONFIG_CROSS_COMPILER_PREFIX while cleanup up markup.

16 years ago- fix typo of mine
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 13:32:14 +0000 (13:32 -0000)]
- fix typo of mine

16 years ago- improve documentation a bit
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 13:22:44 +0000 (13:22 -0000)]
- improve documentation a bit

16 years ago- some more nitpicks
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 12:52:45 +0000 (12:52 -0000)]
- some more nitpicks

16 years ago- some more markup fixes
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 12:42:39 +0000 (12:42 -0000)]
- some more markup fixes

16 years ago- fix typo
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 12:27:42 +0000 (12:27 -0000)]
- fix typo

16 years agomore of pointless beautifuing on the web page
Denis Vlasenko [Thu, 21 Aug 2008 12:24:02 +0000 (12:24 -0000)]
more of pointless beautifuing on the web page

16 years agotrim webpage text a bit
Denis Vlasenko [Thu, 21 Aug 2008 12:07:38 +0000 (12:07 -0000)]
trim webpage text a bit

16 years ago- drop outdated paragraph (which additionally contained some mistyped html-like junk)
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 11:54:23 +0000 (11:54 -0000)]
- drop outdated paragraph (which additionally contained some mistyped html-like junk)

16 years ago- misc. minor tweaks
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 11:52:12 +0000 (11:52 -0000)]
- misc. minor tweaks

16 years ago- point people to the current stable branch
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 11:43:36 +0000 (11:43 -0000)]
- point people to the current stable branch

16 years ago- tweak markup
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 11:38:22 +0000 (11:38 -0000)]
- tweak markup

16 years agomore cosmetic fixes on the website
Denis Vlasenko [Thu, 21 Aug 2008 11:36:24 +0000 (11:36 -0000)]
more cosmetic fixes on the website

16 years agocosmetic fixes on the webpage
Denis Vlasenko [Thu, 21 Aug 2008 11:34:57 +0000 (11:34 -0000)]
cosmetic fixes on the webpage

16 years ago- tweak markup
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 11:34:46 +0000 (11:34 -0000)]
- tweak markup

16 years ago- bump copyright year
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 11:23:42 +0000 (11:23 -0000)]
- bump copyright year

16 years ago- fix markup
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 11:19:52 +0000 (11:19 -0000)]
- fix markup

16 years ago- fix some wrong markup.
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 10:54:55 +0000 (10:54 -0000)]
- fix some wrong markup.
  sed -i -e 's, href=\([^"][^>]*\)>, href="\1">,g' *.html
  The proper way to specify an attribute is to quote the val: theattrib="val"

16 years ago- correct release date for 1.12.0 and fix a few typos
Bernhard Reutner-Fischer [Thu, 21 Aug 2008 10:35:26 +0000 (10:35 -0000)]
- correct release date for 1.12.0 and fix a few typos

16 years agoannounce 1.12.0
Denis Vlasenko [Thu, 21 Aug 2008 10:19:28 +0000 (10:19 -0000)]
announce 1.12.0

16 years agoBump version to 1.13.0.svn
Denis Vlasenko [Wed, 20 Aug 2008 23:30:42 +0000 (23:30 -0000)]
Bump version to 1.13.0.svn

16 years agoThis is 1.12.0 1_12_0
Denis Vlasenko [Wed, 20 Aug 2008 23:29:10 +0000 (23:29 -0000)]
This is 1.12.0

16 years agogetopt32: do not return pointer to alloca() areas
Denis Vlasenko [Wed, 20 Aug 2008 23:03:38 +0000 (23:03 -0000)]
getopt32: do not return pointer to alloca() areas

16 years agoenvdir: fix "envdir with no params" case
Denis Vlasenko [Wed, 20 Aug 2008 22:19:27 +0000 (22:19 -0000)]
envdir: fix "envdir with no params" case

16 years agofindfs: make it use setuid-ness of busybox binary
Denis Vlasenko [Wed, 20 Aug 2008 08:50:02 +0000 (08:50 -0000)]
findfs: make it use setuid-ness of busybox binary

16 years agofsck: use getmntent_r instead of open-coded parsing. By Vladimir
Denis Vlasenko [Wed, 20 Aug 2008 02:38:48 +0000 (02:38 -0000)]
fsck: use getmntent_r instead of open-coded parsing. By Vladimir

function                                             old     new   delta
create_fs_device                                     125     158     +33
parse_word                                            41       -     -41
parse_escape                                          55       -     -55
fsck_main                                           2246    1893    -353
------------------------------------------------------------------------------
(add/remove: 0/2 grow/shrink: 1/1 up/down: 33/-449)          Total: -416 bytes

16 years agolinedit: fix use-after-free
Denis Vlasenko [Wed, 20 Aug 2008 00:46:32 +0000 (00:46 -0000)]
linedit: fix use-after-free

16 years agolibbb: getopt32() should not ever touch argv[0] (even read)
Denis Vlasenko [Wed, 20 Aug 2008 00:15:42 +0000 (00:15 -0000)]
libbb: getopt32() should not ever touch argv[0] (even read)

16 years agolibbb: fix mishandling of "all argv are opts" in getopt32()
Denis Vlasenko [Wed, 20 Aug 2008 00:12:22 +0000 (00:12 -0000)]
libbb: fix mishandling of "all argv are opts" in getopt32()

function                                             old     new   delta
top_main                                            1100    1095      -5
getopt32                                            1398    1361     -37
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-42)             Total: -42 bytes

16 years agoifupdown: fixes for shutdown of DHCP-managed interfaces
Denis Vlasenko [Tue, 19 Aug 2008 23:02:23 +0000 (23:02 -0000)]
ifupdown: fixes for shutdown of DHCP-managed interfaces
 from Wade Berrier <wberrier AT gmail.com>

16 years agoUpdating defconfig, fixing a typo in Config.in
Denis Vlasenko [Tue, 19 Aug 2008 22:26:05 +0000 (22:26 -0000)]
Updating defconfig, fixing a typo in Config.in

16 years ago- add new applet rdev (Grant Erickson)
Bernhard Reutner-Fischer [Tue, 19 Aug 2008 11:28:52 +0000 (11:28 -0000)]
- add new applet rdev (Grant Erickson)
- fixes and shrink (me)

16 years agoshowkey: new applet by Vladimir
Denis Vlasenko [Sun, 17 Aug 2008 14:17:48 +0000 (14:17 -0000)]
showkey: new applet by Vladimir

16 years agosetfont: new applet by Vladimir
Denis Vlasenko [Sun, 17 Aug 2008 14:12:26 +0000 (14:12 -0000)]
setfont: new applet by Vladimir

16 years agolibbb: use ptsname_r, it's smaller
Denis Vlasenko [Sun, 17 Aug 2008 12:47:19 +0000 (12:47 -0000)]
libbb: use ptsname_r, it's smaller

function                                             old     new   delta
xgetpty                                               91      81     -10
ptsname                                               33       -     -33

   text    data     bss     dec     hex filename
 793828     592    6692  801112   c3958 busybox_old
 793796     592    6660  801048   c3918 busybox_unstripped

16 years agoash: fix "(cat < file)" hang introduced by rev 22944.
Denis Vlasenko [Sat, 16 Aug 2008 11:48:02 +0000 (11:48 -0000)]
ash: fix "(cat < file)" hang introduced by rev 22944.

16 years agocut: fix buffer overflow (bug 4544).
Denis Vlasenko [Fri, 15 Aug 2008 21:20:23 +0000 (21:20 -0000)]
cut: fix buffer overflow (bug 4544).

16 years agochpst: fix "envdir dir" case (bug 4574).
Denis Vlasenko [Fri, 15 Aug 2008 21:03:17 +0000 (21:03 -0000)]
chpst: fix "envdir dir" case (bug 4574).

16 years agoarp: without -H <type>, assume "ether". closes 4564
Denis Vlasenko [Fri, 15 Aug 2008 20:14:23 +0000 (20:14 -0000)]
arp: without -H <type>, assume "ether". closes 4564

16 years agoinstall: fix long option not taking params (bug 4584)
Denis Vlasenko [Fri, 15 Aug 2008 19:56:24 +0000 (19:56 -0000)]
install: fix long option not taking params (bug 4584)

16 years agomkdir: fix "uname 0222; mkdir foo/bar" case
Denis Vlasenko [Fri, 15 Aug 2008 19:18:35 +0000 (19:18 -0000)]
mkdir: fix "uname 0222; mkdir foo/bar" case
 (by Doug Graham <dgraham AT nortel.com>)

function                                             old     new   delta
bb_make_directory                                    291     280     -11

16 years agonmeter: fix read past the end if a buffer. Closes 4594
Denis Vlasenko [Thu, 14 Aug 2008 21:57:43 +0000 (21:57 -0000)]
nmeter: fix read past the end if a buffer. Closes 4594

16 years agoifupdown: fixes for custom MAC address, by Wade Berrier <wberrier AT gmail.com>
Denis Vlasenko [Tue, 12 Aug 2008 01:35:34 +0000 (01:35 -0000)]
ifupdown: fixes for custom MAC address, by Wade Berrier <wberrier AT gmail.com>

16 years agosendmail: work around (bogus) gcc warning
Denis Vlasenko [Sun, 10 Aug 2008 20:46:39 +0000 (20:46 -0000)]
sendmail: work around (bogus) gcc warning

16 years agofix byte-swapping of compressed help on big-endian machines
Denis Vlasenko [Sat, 9 Aug 2008 20:31:57 +0000 (20:31 -0000)]
fix byte-swapping of compressed help on big-endian machines

16 years agooptimize config_read() (by Timo Teras <timo.teras AT iki.fi>)
Denis Vlasenko [Sat, 9 Aug 2008 17:16:40 +0000 (17:16 -0000)]
optimize config_read() (by Timo Teras <timo.teras AT iki.fi>)

function                                             old     new   delta
bb_get_chunk_with_continuation                         -     176    +176
find_pair                                            169     187     +18
...
process_stdin                                        443     433     -10
config_read                                          549     456     -93
bb_get_chunk_from_file                               139       7    -132
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 7/7 up/down: 215/-254)          Total: -39 bytes

16 years agogrep: option to use GNU regex matching instead of POSIX one.
Denis Vlasenko [Sat, 9 Aug 2008 16:15:14 +0000 (16:15 -0000)]
grep: option to use GNU regex matching instead of POSIX one.
 This fixes problems with NULs in files being scanned, but
 costs +800 bytes. The same can be done to sed (TODO).

16 years ago- support relatime / norelatime
Bernhard Reutner-Fischer [Wed, 6 Aug 2008 18:14:38 +0000 (18:14 -0000)]
- support relatime / norelatime

16 years ago- fix typo
Bernhard Reutner-Fischer [Wed, 6 Aug 2008 17:39:30 +0000 (17:39 -0000)]
- fix typo

16 years agomodprobe-small: fix infinite looping, by Timo Teras
Denis Vlasenko [Wed, 6 Aug 2008 09:41:09 +0000 (09:41 -0000)]
modprobe-small: fix infinite looping, by Timo Teras

16 years agofix bug 4464 for real. I am dumb.
Denis Vlasenko [Wed, 6 Aug 2008 08:44:09 +0000 (08:44 -0000)]
fix bug 4464 for real. I am dumb.