Richard Levitte [Sat, 21 Dec 2002 23:49:21 +0000 (23:49 +0000)]
Stop a possible memory leak.
(I wonder why s2_connect() handles the initial buffer allocation slightly
differently...)
PR: 416
Richard Levitte [Fri, 20 Dec 2002 18:21:35 +0000 (18:21 +0000)]
Make AES_ENCRYPT and AES_DECRYPT macros instead of static constants.
PR: 411
Andy Polyakov [Fri, 20 Dec 2002 18:11:30 +0000 (18:11 +0000)]
Fix for "shift count too large" when compiling for hpux-parisc2 and
irix-mips. The bug was introduced with accelerated support for x86_64.
My fault! Fixed now.
Richard Levitte [Fri, 20 Dec 2002 16:38:36 +0000 (16:38 +0000)]
More accurate comments.
Richard Levitte [Fri, 20 Dec 2002 16:38:06 +0000 (16:38 +0000)]
A little debugging.
Richard Levitte [Fri, 20 Dec 2002 15:28:42 +0000 (15:28 +0000)]
Propagate MAKEDEPPROG to the subdirs under crypto/.
Lutz Jänicke [Fri, 20 Dec 2002 12:48:00 +0000 (12:48 +0000)]
Fix Kerberos5/SSL interaction
Submitted by: "Kenneth R. Robinette" <support@securenetterm.com>
Reviewed by:
PR:
Richard Levitte [Fri, 20 Dec 2002 09:39:34 +0000 (09:39 +0000)]
Keep the internal lowercase 'surname', for programmer's sake.
Richard Levitte [Fri, 20 Dec 2002 09:24:17 +0000 (09:24 +0000)]
Be consistent with capitalisation of object names.
Richard Levitte [Fri, 20 Dec 2002 09:18:18 +0000 (09:18 +0000)]
Be consistent with capitalisation of object names.
Richard Levitte [Fri, 20 Dec 2002 07:51:03 +0000 (07:51 +0000)]
There was a mixup between INSTALLTOP and OPENSSLDIR...
Richard Levitte [Thu, 19 Dec 2002 22:10:12 +0000 (22:10 +0000)]
We stupidly had a separate LIBKRB5 variable for KRB5 library dependencies,
and then didn't support it very well. And that when there already is a
useful variable for exactly this kind of thing; EX_LIBS...
Richard Levitte [Thu, 19 Dec 2002 21:56:40 +0000 (21:56 +0000)]
Because the contents of openssl.pc may have to change when a configuration
has been performed (and possibly changed), have it depend on Makefile.ssl.
Richard Levitte [Thu, 19 Dec 2002 21:55:48 +0000 (21:55 +0000)]
Small tweaks for code consistency.
Richard Levitte [Thu, 19 Dec 2002 21:13:29 +0000 (21:13 +0000)]
To avoid any future programming glitches, let's make each and every
assignment (modulo those I missed) individual statements.
Richard Levitte [Thu, 19 Dec 2002 19:42:53 +0000 (19:42 +0000)]
I have no idea what possesed me to compile s_socket.c as POSIXly code.
Incidently, it now compiles so much better without _POSIX_C_SOURCE.
Richard Levitte [Thu, 19 Dec 2002 19:39:30 +0000 (19:39 +0000)]
If _XOPEN_SOURCE_EXTENDED or _XOPEN_SOURCE are defined, _POSIX_C_SOURCE gets
defined in DECC$TYPES.H. If _POSIX_C_SOURCE is defined, certain types do
not get defined (u_char, u_int, ...). DECC.H gets included by assert.h
and others. Now, in6.h uses the types u_char, u_int and so on, and gets
included as part of other header inclusions, and will of course fail because
of the missing types.
On the other hand, _XOPEN_SOURCE_EXTENDED is needed to get gethostname()
properly declared...
Solution: define _XOPEN_SOURCE_EXTENDED much later, so DECC$TYPES.H has
a chance to be included *first*, so the otherwise missing types get defined
properly.
Personal: *mumble* *mumble*
Richard Levitte [Thu, 19 Dec 2002 17:44:42 +0000 (17:44 +0000)]
It was pointed out to me that .pc files are normally stored in
${prefix}/lib/pkgconfig, not ${prefix}/lib/pkginfo.
Richard Levitte [Thu, 19 Dec 2002 17:42:23 +0000 (17:42 +0000)]
It was pointed out to me that .pc files are normally stored in
${prefix}/lib/pkgconfig, not ${prefix}/lib/pkginfo.
Richard Levitte [Wed, 18 Dec 2002 10:24:02 +0000 (10:24 +0000)]
Update the current status
Andy Polyakov [Wed, 18 Dec 2002 09:42:51 +0000 (09:42 +0000)]
Better wording?
Andy Polyakov [Wed, 18 Dec 2002 09:03:48 +0000 (09:03 +0000)]
Fix for RT#405, Solaris refuses to invoke preprocessor if egrep returns 1.
Linux for example doesn't exhibit this behaviour, but I add "exit 0" to all
potentially affected rules, just to be on the safe side.
Andy Polyakov [Tue, 17 Dec 2002 08:05:49 +0000 (08:05 +0000)]
Make "perl des-586.pl a.out" work, see RT#402
Andy Polyakov [Mon, 16 Dec 2002 23:35:17 +0000 (23:35 +0000)]
'a=b c=$a; echo $c' doesn't necessarily prints "b", '' vs. "", $s in
Makefiles... I suppose it wasn't tested very much...
Richard Levitte [Mon, 16 Dec 2002 20:33:38 +0000 (20:33 +0000)]
Transfer the Solaris shared library building changes from
0.9.7-stable.
Richard Levitte [Mon, 16 Dec 2002 06:06:03 +0000 (06:06 +0000)]
Protect loading routines with a lock.
PR: 373
Richard Levitte [Sun, 15 Dec 2002 20:59:24 +0000 (20:59 +0000)]
Synchronise with Makefiles.
Andy Polyakov [Sun, 15 Dec 2002 16:01:21 +0000 (16:01 +0000)]
Always forget this one...
Andy Polyakov [Sun, 15 Dec 2002 10:06:27 +0000 (10:06 +0000)]
DES PIC-ification. "Cygwin" companion. Problem was that preprocessor macro
is not expanded if prepended with a $-sign.
Richard Levitte [Sun, 15 Dec 2002 06:45:43 +0000 (06:45 +0000)]
Make sure manual pages are properly linked to on systems that have case
insensitive file names, as well as those that do not have symlinks.
Incidently, both these cases apply on DOS/Windows...
Richard Levitte [Sun, 15 Dec 2002 05:59:13 +0000 (05:59 +0000)]
Update the make system for installations:
- define a HERE variable to indicate where the source tree is (used
very little right now)
- make more use of copying and making attribute changes to {file}.new,
and then move it to {file}
- use 'mv -f' to avoid all those questions to the user when the file
in question doesn't have write attributes for that user.
Richard Levitte [Sun, 15 Dec 2002 05:54:56 +0000 (05:54 +0000)]
Don't define macros in terms of asm() when __STRICT_ANSI is defined.
Richard Levitte [Sun, 15 Dec 2002 05:54:26 +0000 (05:54 +0000)]
Bring des_locl.h at the same level as in the 0.9.7 branch.
Don't define macros in terms of asm() when __STRICT_ANSI is defined.
Andy Polyakov [Sun, 15 Dec 2002 00:47:47 +0000 (00:47 +0000)]
Ooops! No ROTATE on some platforms after x86_64 performance patch...
Andy Polyakov [Sat, 14 Dec 2002 23:14:00 +0000 (23:14 +0000)]
As you might have noticed I tried to change for . prefix, because it's
the one to be used to denote local labels in single function scope.
Problem is that SHA uses same label set across functions, therefore I
have to switch back to $ prefix.
Andy Polyakov [Sat, 14 Dec 2002 21:46:46 +0000 (21:46 +0000)]
Solaris shared build fix-ups. See RT#238,239 for details.
Andy Polyakov [Sat, 14 Dec 2002 20:52:19 +0000 (20:52 +0000)]
New DETECT_GNU_LD procedure.
Andy Polyakov [Sat, 14 Dec 2002 20:42:05 +0000 (20:42 +0000)]
x86_64 performance patch.
Andy Polyakov [Sat, 14 Dec 2002 17:54:30 +0000 (17:54 +0000)]
DES PIC-ification. Windows companion.
Geoff Thorpe [Fri, 13 Dec 2002 22:01:46 +0000 (22:01 +0000)]
The ampersand is not required in these constructs, and was giving AIX
warnings.
Reported by: Bernhard Simon.
Andy Polyakov [Fri, 13 Dec 2002 17:56:14 +0000 (17:56 +0000)]
IA-32 assembler modules (primarily DES) PIC-ification. Idea is to keep
shared libraries shared.
Richard Levitte [Fri, 13 Dec 2002 07:30:53 +0000 (07:30 +0000)]
OK, there's at least one application author who has provided dynamic locking
callbacks
Richard Levitte [Thu, 12 Dec 2002 22:12:02 +0000 (22:12 +0000)]
BIO_new_bio_pair() was unnecessarily described in it's own page as well as in
BIO_s_bio.pod. The most logical is to move everything needed from
BIO_new_bio_pair.pod to BIO_s_bio.pod (including the nice example)
and toss BIO_new_bio_pair.pod. I hope I got all the info over properly.
PR: 370
Richard Levitte [Thu, 12 Dec 2002 22:08:49 +0000 (22:08 +0000)]
BIO_set_nbio() is enumerated, but not explained. Remove it from enumeration
since it's both enumerated and explained in BIO_s_connect.pod.
PR: 370
Richard Levitte [Thu, 12 Dec 2002 19:40:55 +0000 (19:40 +0000)]
I forgot one item I intend to work on.
Richard Levitte [Thu, 12 Dec 2002 18:43:10 +0000 (18:43 +0000)]
Skip DH-specific tests when no-dh has been configured.
PR: 353
Richard Levitte [Thu, 12 Dec 2002 17:40:15 +0000 (17:40 +0000)]
Document the modifications in 0.9.7 that will make the hw_ncipher.c
engine work properly even in bad situations.
Geoff Thorpe [Wed, 11 Dec 2002 19:07:03 +0000 (19:07 +0000)]
Make 'tunala' link with zlib if possible (so it works if openssl was
configured with zlib support).
Richard Levitte [Wed, 11 Dec 2002 08:56:35 +0000 (08:56 +0000)]
In CRYPTO_lock(), check that the application cares about locking (provided
callbacks) before attempting to lock.
Richard Levitte [Wed, 11 Dec 2002 08:33:31 +0000 (08:33 +0000)]
sk_*_push() returns the number of items on the stack, not the index of the
pushed item. The index is the number of items - 1. And if a NULL item was
found, actually use it.
Finally, provide a little bit of safety in CRYPTO_lock() by asserting the a
requested dynamic lock really must exist, instead of just being silent about it
Richard Levitte [Wed, 11 Dec 2002 07:37:54 +0000 (07:37 +0000)]
Let's not forget the other places where HEADER_DES_H and HEADER_DES_OLD_H
were defined.
Richard Levitte [Wed, 11 Dec 2002 07:24:43 +0000 (07:24 +0000)]
Let's not forget the other places where HEADER_DES_H and HEADER_DES_OLD_H
were defined.
Richard Levitte [Wed, 11 Dec 2002 06:59:16 +0000 (06:59 +0000)]
Since HEADER_DES_H has been the protector of des.h since libdes
(before SSLeay, maybe?), it's better to have that macro protect
the compatibility header des_old.h. In the new des.h, let's use
a slightly different protecting macro.
The rationale is that there are application that might include (via
other header files, perhaps) both an old libdes des.h and OpenSSL's
des.h. Whichever comes first would overshadow the other because of
the clash in protecting macro. This fix solves that problem.
Geoff Thorpe [Wed, 11 Dec 2002 03:34:26 +0000 (03:34 +0000)]
This stops a compiler warning from -Wmissing-prototypes.
(Noticed by Nils Larsch)
Lutz Jänicke [Tue, 10 Dec 2002 18:48:14 +0000 (18:48 +0000)]
Update -Olimit setting.
Submitted by: Bernhard Simon <simon@zid.tuwien.ac.at>
Reviewed by:
PR:
Ralf S. Engelschall [Tue, 10 Dec 2002 12:01:39 +0000 (12:01 +0000)]
test commit (just removing tailing blanks) #2 after migration
Ralf S. Engelschall [Tue, 10 Dec 2002 10:51:18 +0000 (10:51 +0000)]
test commit (removing trailing blanks) after migration
Ralf S. Engelschall [Tue, 10 Dec 2002 10:49:22 +0000 (10:49 +0000)]
test blank-line commit after migration -- just ignore
Richard Levitte [Tue, 10 Dec 2002 08:26:05 +0000 (08:26 +0000)]
A memset() too many got converted into a OPENSSL_cleanse().
PR: 393
Andy Polyakov [Mon, 9 Dec 2002 13:43:38 +0000 (13:43 +0000)]
BN_sqr test failure entry.
Lutz Jänicke [Mon, 9 Dec 2002 08:49:58 +0000 (08:49 +0000)]
Fix wrong URI.
Submitted by: assar@kth.se
Reviewed by:
PR: 390
Richard Levitte [Mon, 9 Dec 2002 02:19:27 +0000 (02:19 +0000)]
make update
Richard Levitte [Mon, 9 Dec 2002 02:18:16 +0000 (02:18 +0000)]
Hmm, Geoff's change made things quite interesting. We can now give
users the option of disabling deprecated functions, which should of
course be reflected in libeay.num and .def files. Quite nice,
actually.
Geoff Thorpe [Sun, 8 Dec 2002 16:45:26 +0000 (16:45 +0000)]
Nils Larsch submitted;
- a patch to fix a memory leak in rsa_gen.c
- a note about compiler warnings with unions
- a note about improving structure element names
This applies his patch and implements a solution to the notes.
Richard Levitte [Sun, 8 Dec 2002 09:31:41 +0000 (09:31 +0000)]
Since it's defined in draft-ietf-tls-compression-04.txt, let's make
ZLIB a known compression method, with the identity 1.
Geoff Thorpe [Sun, 8 Dec 2002 05:38:44 +0000 (05:38 +0000)]
Undefine OPENSSL_NO_DEPRECATED inside openssl application code if we are
being built with it defined - it is not a symbol to affect how openssl
itself builds, but to alter the way openssl headers can be used from an API
point of view. The "deprecated" function wrappers will always remain inside
OpenSSL at least as long as they're still being used internally. :-)
The exception is dsaparam which has been updated to the BN_GENCB-based
functions to test the new functionality. If GENCB_TEST is defined, dsaparam
will support a "-timebomb <n>" switch to cancel parameter-generation if it
gets as far as 'n' seconds without completion.
Geoff Thorpe [Sun, 8 Dec 2002 05:24:31 +0000 (05:24 +0000)]
This is a first-cut at improving the callback mechanisms used in
key-generation and prime-checking functions. Rather than explicitly passing
callback functions and caller-defined context data for the callbacks, a new
structure BN_GENCB is defined that encapsulates this; a pointer to the
structure is passed to all such functions instead.
This wrapper structure allows the encapsulation of "old" and "new" style
callbacks - "new" callbacks return a boolean result on the understanding
that returning FALSE should terminate keygen/primality processing. The
BN_GENCB abstraction will allow future callback modifications without
needing to break binary compatibility nor change the API function
prototypes. The new API functions have been given names ending in "_ex" and
the old functions are implemented as wrappers to the new ones. The
OPENSSL_NO_DEPRECATED symbol has been introduced so that, if defined,
declaration of the older functions will be skipped. NB: Some
openssl-internal code will stick with the older callbacks for now, so
appropriate "#undef" logic will be put in place - this is in case the user
is *building* openssl (rather than *including* its headers) with this
symbol defined.
There is another change in the new _ex functions; the key-generation
functions do not return key structures but operate on structures passed by
the caller, the return value is a boolean. This will allow for a smoother
transition to having key-generation as "virtual function" in the various
***_METHOD tables.
Geoff Thorpe [Sun, 8 Dec 2002 05:19:43 +0000 (05:19 +0000)]
Fix a warning, and do some constification as a lucky side-effect :-)
Richard Levitte [Sun, 8 Dec 2002 02:41:11 +0000 (02:41 +0000)]
Since it's defined in draft-ietf-tls-compression-04.txt, let's make
ZLIB a known compression method, with the identity 1.
Richard Levitte [Sun, 8 Dec 2002 02:39:38 +0000 (02:39 +0000)]
Implement a stateful variant if the ZLIB compression method. The old
stateless variant is kept, but isn't used anywhere.
Richard Levitte [Sat, 7 Dec 2002 20:03:42 +0000 (20:03 +0000)]
Forgot one.
Richard Levitte [Sat, 7 Dec 2002 20:02:20 +0000 (20:02 +0000)]
Add a few items I intend to work on for 0.9.8 and on.
Andy Polyakov [Fri, 6 Dec 2002 17:18:10 +0000 (17:18 +0000)]
Workaround for GCC-ia64 compiler bug.
Submitted by: <appro>
Reviewed by:
PR:
Richard Levitte [Fri, 6 Dec 2002 08:50:06 +0000 (08:50 +0000)]
Some compilers are quite picky about non-void functions that don't return
anything.
Richard Levitte [Fri, 6 Dec 2002 08:43:41 +0000 (08:43 +0000)]
Apparently, bash is more forgiving than sh. To be backward
compatible, don't use ==, use = instead...
Richard Levitte [Fri, 6 Dec 2002 00:39:03 +0000 (00:39 +0000)]
Keep NEWS in HEAD up to date.
Richard Levitte [Thu, 5 Dec 2002 23:01:17 +0000 (23:01 +0000)]
Keep STATUS in HEAD up to date.
Richard Levitte [Thu, 5 Dec 2002 21:50:13 +0000 (21:50 +0000)]
Merge in relevant changes from the OpenSSL 0.9.6h release.
Richard Levitte [Thu, 5 Dec 2002 21:07:26 +0000 (21:07 +0000)]
SSL_CERT_FILE should be used in place of the system default file, not as
a first alternative to try
Richard Levitte [Thu, 5 Dec 2002 20:50:25 +0000 (20:50 +0000)]
Corrected DJGPP patch
Andy Polyakov [Thu, 5 Dec 2002 13:17:52 +0000 (13:17 +0000)]
linux64-sparcv9 support finally debugged and tested.
Submitted by:
Reviewed by:
PR:
Richard Levitte [Thu, 5 Dec 2002 10:16:28 +0000 (10:16 +0000)]
Make sure to implement the cryptodev engine only when /dev/crypto exists.
Richard Levitte [Thu, 5 Dec 2002 01:55:48 +0000 (01:55 +0000)]
make update
Richard Levitte [Thu, 5 Dec 2002 01:42:14 +0000 (01:42 +0000)]
Declare another general file.
Richard Levitte [Thu, 5 Dec 2002 01:35:04 +0000 (01:35 +0000)]
Allow users to modify /MD to /MT.
PR: 380
Richard Levitte [Thu, 5 Dec 2002 01:20:47 +0000 (01:20 +0000)]
Make sure using SSL_CERT_FILE actually works, and has priority over system defaults.
PR: 376
Richard Levitte [Thu, 5 Dec 2002 00:56:58 +0000 (00:56 +0000)]
If an application supports static locks, it MUST support dynamic locks as
well to be able to use the CHIL engine.
PR: 281
Richard Levitte [Thu, 5 Dec 2002 00:05:48 +0000 (00:05 +0000)]
PR: 381
Richard Levitte [Thu, 5 Dec 2002 00:04:30 +0000 (00:04 +0000)]
Only check for a result buffer if the allocated string is a prompt string.
PR: 381
Richard Levitte [Wed, 4 Dec 2002 22:54:02 +0000 (22:54 +0000)]
Do not implement RC4 stuff if RC4 is disabled. Concequently, apply the same
rule for SHA stuff.
PR: 381
Richard Levitte [Wed, 4 Dec 2002 22:48:01 +0000 (22:48 +0000)]
gethostname() is more a BSD feature than an XOPEN one.
PR: 379
Richard Levitte [Wed, 4 Dec 2002 19:13:43 +0000 (19:13 +0000)]
Correct a few typos that I introduced after applying DJGPP patches.
Bodo Möller [Wed, 4 Dec 2002 17:43:01 +0000 (17:43 +0000)]
In ECPKParameters_print, output the private key length correctly
(length of the order of the group, not length of the actual key, which
will be shorter in some cases).
Submitted by: Nils Larsch
Bodo Möller [Wed, 4 Dec 2002 17:38:40 +0000 (17:38 +0000)]
Don't compute timings here, we can do this elsewhere.
Include X9.62 signature examples.
Submitted by: Nils Larsch
Lutz Jänicke [Wed, 4 Dec 2002 13:30:58 +0000 (13:30 +0000)]
Missing ")"
Submitted by: Christian Hohnstaedt <chohnstaedt@innominate.com>
Reviewed by:
PR:
Richard Levitte [Wed, 4 Dec 2002 09:54:10 +0000 (09:54 +0000)]
DJGPP patches.
PR: 347
Richard Levitte [Wed, 4 Dec 2002 09:17:43 +0000 (09:17 +0000)]
Add support for x86_64.
PR: 348
Richard Levitte [Wed, 4 Dec 2002 08:24:18 +0000 (08:24 +0000)]
A gcc 3.0 bug is triggered by our code. Add a section about it in PROBLEMS.
PR: 375
Dr. Stephen Henson [Wed, 4 Dec 2002 00:49:46 +0000 (00:49 +0000)]
Make ASN1_TYPE_get() work for V_ASN1_NULL type.
Dr. Stephen Henson [Wed, 4 Dec 2002 00:16:00 +0000 (00:16 +0000)]
Typo in X509v3_get_ext_by_critical