Dr. Stephen Henson [Mon, 23 Apr 2012 20:35:55 +0000 (20:35 +0000)]
The fix for CVE-2012-2110 did not take into account that the
'len' argument to BUF_MEM_grow and BUF_MEM_grow_clean is an
int in OpenSSL 0.9.8, making it still vulnerable. Fix by
rejecting negative len parameter.
Thanks to the many people who reported this bug and to Tomas Hoger
<thoger@redhat.com> for supplying the fix.
Dr. Stephen Henson [Sun, 22 Apr 2012 13:31:46 +0000 (13:31 +0000)]
correct error code
Dr. Stephen Henson [Sun, 22 Apr 2012 13:22:38 +0000 (13:22 +0000)]
correct old FAQ answers, sync with HEAD
Dr. Stephen Henson [Thu, 19 Apr 2012 17:03:28 +0000 (17:03 +0000)]
prepare for next version
Dr. Stephen Henson [Thu, 19 Apr 2012 12:05:18 +0000 (12:05 +0000)]
update FAQ
Dr. Stephen Henson [Thu, 19 Apr 2012 11:39:03 +0000 (11:39 +0000)]
prepare for 0.9.8v release
Dr. Stephen Henson [Thu, 19 Apr 2012 11:37:17 +0000 (11:37 +0000)]
update NEWS
Dr. Stephen Henson [Thu, 19 Apr 2012 11:36:09 +0000 (11:36 +0000)]
Check for potentially exploitable overflows in asn1_d2i_read_bio
BUF_mem_grow and BUF_mem_grow_clean. Refuse attempts to shrink buffer
in CRYPTO_realloc_clean.
Thanks to Tavis Ormandy, Google Security Team, for discovering this
issue and to Adam Langley <agl@chromium.org> for fixing it. (CVE-2012-2110)
Dr. Stephen Henson [Sun, 15 Apr 2012 16:48:34 +0000 (16:48 +0000)]
use /fixed argument when linking FIPS targets to disable address space layout randomization
Dr. Stephen Henson [Sat, 31 Mar 2012 18:02:23 +0000 (18:02 +0000)]
PR: 2778(part)
Submitted by: John Fitzgibbon <john_fitzgibbon@yahoo.com>
Time is always encoded as 4 bytes, not sizeof(Time).
Dr. Stephen Henson [Sun, 18 Mar 2012 18:18:30 +0000 (18:18 +0000)]
Always use SSLv23_{client,server}_method in s_client.c and s_server.c,
the old code came from SSLeay days before TLS was even supported.
Dr. Stephen Henson [Mon, 12 Mar 2012 16:35:13 +0000 (16:35 +0000)]
prepare for next version
Dr. Stephen Henson [Mon, 12 Mar 2012 15:25:53 +0000 (15:25 +0000)]
corrected fix to PR#2711 and also cover mime_param_cmp
Dr. Stephen Henson [Mon, 12 Mar 2012 15:01:44 +0000 (15:01 +0000)]
correct FAQ
Dr. Stephen Henson [Mon, 12 Mar 2012 14:53:14 +0000 (14:53 +0000)]
prepare for release
Dr. Stephen Henson [Mon, 12 Mar 2012 14:52:14 +0000 (14:52 +0000)]
update NEWS
Dr. Stephen Henson [Mon, 12 Mar 2012 14:51:45 +0000 (14:51 +0000)]
Fix for CMS/PKCS7 MMA. If RSA decryption fails use a random key and
continue with symmetric decryption process to avoid leaking timing
information to an attacker.
Thanks to Ivan Nestlerode <inestlerode@us.ibm.com> for discovering
this issue. (CVE-2012-0884)
Dr. Stephen Henson [Mon, 12 Mar 2012 14:50:55 +0000 (14:50 +0000)]
fix error code
Dr. Stephen Henson [Mon, 12 Mar 2012 12:46:52 +0000 (12:46 +0000)]
manually patch missing part of PR#2756
Dr. Stephen Henson [Fri, 9 Mar 2012 15:51:56 +0000 (15:51 +0000)]
PR: 2756
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Fix DTLS timeout handling.
Dr. Stephen Henson [Thu, 8 Mar 2012 14:01:44 +0000 (14:01 +0000)]
check return value of BIO_write in PKCS7_decrypt
Dr. Stephen Henson [Wed, 7 Mar 2012 15:14:16 +0000 (15:14 +0000)]
PR: 2755
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reduce MTU after failed transmissions. [0.9.8 version of patch]
Dr. Stephen Henson [Tue, 6 Mar 2012 19:08:30 +0000 (19:08 +0000)]
return failure code if I/O error
Dr. Stephen Henson [Tue, 6 Mar 2012 18:25:33 +0000 (18:25 +0000)]
revert PR#2755: it breaks compilation
Dr. Stephen Henson [Tue, 6 Mar 2012 13:45:47 +0000 (13:45 +0000)]
PR: 2755
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reduce MTU after failed transmissions.
Dr. Stephen Henson [Tue, 6 Mar 2012 13:37:52 +0000 (13:37 +0000)]
PR: 2696 Submitted by: Rob Austein <sra@hactrn.net>
Fix inverted range problem in RFC3779 code.
Thanks to Andrew Chi for generating test cases for this bug.
[from HEAD]
Dr. Stephen Henson [Tue, 6 Mar 2012 13:22:32 +0000 (13:22 +0000)]
oops, revert unrelated patches
Dr. Stephen Henson [Tue, 6 Mar 2012 13:20:20 +0000 (13:20 +0000)]
PR: 2748
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Fix possible DTLS timer deadlock.
Dr. Stephen Henson [Tue, 28 Feb 2012 14:47:36 +0000 (14:47 +0000)]
Fix memory leak cause by race condition when creating public keys.
Thanks to Ivan Nestlerode <inestlerode@us.ibm.com> for reporting this bug.
Dr. Stephen Henson [Mon, 27 Feb 2012 16:26:32 +0000 (16:26 +0000)]
free headers after use in error message
Dr. Stephen Henson [Mon, 27 Feb 2012 15:23:20 +0000 (15:23 +0000)]
Detect symmetric crypto errors in PKCS7_decrypt.
Thanks to Ivan Nestlerode <inestlerode@us.ibm.com> for reporting this bug.
Dr. Stephen Henson [Thu, 23 Feb 2012 21:50:13 +0000 (21:50 +0000)]
PR: 2711
Submitted by: Tomas Mraz <tmraz@redhat.com>
Tolerate bad MIME headers in parser.
Dr. Stephen Henson [Thu, 16 Feb 2012 15:21:17 +0000 (15:21 +0000)]
Fix bug in CVE-2011-4619: check we have really received a client hello
before rejecting multiple SGC restarts.
Dr. Stephen Henson [Sat, 11 Feb 2012 23:12:34 +0000 (23:12 +0000)]
PR: 2703
Submitted by: Alexey Melnikov <alexey.melnikov@isode.com>
Fix some memory and resource leaks in CAPI ENGINE.
Dr. Stephen Henson [Sat, 11 Feb 2012 23:07:32 +0000 (23:07 +0000)]
PR: 2705
Submitted by: Alexey Melnikov <alexey.melnikov@isode.com>
Only create ex_data indices once for CAPI engine.
Dr. Stephen Henson [Fri, 20 Jan 2012 23:24:17 +0000 (23:24 +0000)]
fix Visual Studio 2010 warning [from HEAD] (original by appro)
Dr. Stephen Henson [Wed, 18 Jan 2012 14:27:13 +0000 (14:27 +0000)]
prepare for next version
Dr. Stephen Henson [Wed, 18 Jan 2012 13:15:37 +0000 (13:15 +0000)]
update FAQ
Dr. Stephen Henson [Wed, 18 Jan 2012 13:14:49 +0000 (13:14 +0000)]
prepare for release
Dr. Stephen Henson [Wed, 18 Jan 2012 13:13:31 +0000 (13:13 +0000)]
update NEWS
Dr. Stephen Henson [Wed, 18 Jan 2012 13:12:08 +0000 (13:12 +0000)]
Fix for DTLS DoS issue introduced by fix for CVE-2011-4109.
Thanks to Antonio Martin, Enterprise Secure Access Research and
Development, Cisco Systems, Inc. for discovering this bug and
preparing a fix. (CVE-2012-0050)
Dr. Stephen Henson [Tue, 17 Jan 2012 14:18:26 +0000 (14:18 +0000)]
fix CHANGES entry
Dr. Stephen Henson [Tue, 10 Jan 2012 14:37:00 +0000 (14:37 +0000)]
fix warning
Bodo Möller [Thu, 5 Jan 2012 13:15:29 +0000 (13:15 +0000)]
Fix usage indentation
Bodo Möller [Thu, 5 Jan 2012 10:21:49 +0000 (10:21 +0000)]
Fix for builds without DTLS support.
Submitted by: Brian Carlstrom
Dr. Stephen Henson [Wed, 4 Jan 2012 23:56:13 +0000 (23:56 +0000)]
update for next version
Dr. Stephen Henson [Wed, 4 Jan 2012 19:23:07 +0000 (19:23 +0000)]
update FAQ
Dr. Stephen Henson [Wed, 4 Jan 2012 19:20:49 +0000 (19:20 +0000)]
prepare for 0.9.8s release
Dr. Stephen Henson [Wed, 4 Jan 2012 19:16:11 +0000 (19:16 +0000)]
update NEWS
Dr. Stephen Henson [Wed, 4 Jan 2012 19:12:39 +0000 (19:12 +0000)]
make update
Dr. Stephen Henson [Wed, 4 Jan 2012 19:10:16 +0000 (19:10 +0000)]
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>, Michael Tuexen <tuexen@fh-muenster.de>
Reviewed by: steve
Fix for DTLS plaintext recovery attack discovered by Nadhem Alfardan and
Kenny Paterson.
Dr. Stephen Henson [Wed, 4 Jan 2012 19:00:28 +0000 (19:00 +0000)]
Fix double free in policy check code (CVE-2011-4109)
Dr. Stephen Henson [Wed, 4 Jan 2012 18:54:17 +0000 (18:54 +0000)]
Clear bytes used for block padding of SSL 3.0 records. (CVE-2011-4576)
Dr. Stephen Henson [Wed, 4 Jan 2012 18:52:18 +0000 (18:52 +0000)]
Only allow one SGC handshake restart for SSL/TLS. (CVE-2011-4619)
Dr. Stephen Henson [Wed, 4 Jan 2012 18:45:18 +0000 (18:45 +0000)]
stop warning
Dr. Stephen Henson [Wed, 4 Jan 2012 18:44:20 +0000 (18:44 +0000)]
Prevent malformed RFC3779 data triggering an assertion failure (CVE-2011-4577)
Dr. Stephen Henson [Wed, 4 Jan 2012 14:25:10 +0000 (14:25 +0000)]
Submitted by: Adam Langley <agl@chromium.org>
Reviewed by: steve
Fix memory leaks.
Dr. Stephen Henson [Mon, 26 Dec 2011 19:38:28 +0000 (19:38 +0000)]
PR: 2326
Submitted by: Tianjie Mao <tjmao@tjmao.net>
Reviewed by: steve
Fix incorrect comma expressions and goto f_err as alert has been set.
Andy Polyakov [Fri, 9 Dec 2011 14:28:48 +0000 (14:28 +0000)]
x86-mont.pl: fix bug in integer-only squaring path [from HEAD].
PR: 2648
Dr. Stephen Henson [Tue, 6 Dec 2011 00:01:09 +0000 (00:01 +0000)]
The default CN prompt message can be confusing when often the CN needs to
be the server FQDN: change it.
[Reported by PSW Group]
Bodo Möller [Fri, 2 Dec 2011 12:50:44 +0000 (12:50 +0000)]
Resolve a stack set-up race condition (if the list of compression
methods isn't presorted, it will be sorted on first read).
Submitted by: Adam Langley
Bodo Möller [Fri, 2 Dec 2011 12:40:25 +0000 (12:40 +0000)]
Fix ecdsatest.c.
Submitted by: Emilia Kasper
Bodo Möller [Fri, 2 Dec 2011 12:23:57 +0000 (12:23 +0000)]
Fix BIO_f_buffer().
Submitted by: Adam Langley
Reviewed by: Bodo Moeller
Andy Polyakov [Sat, 5 Nov 2011 10:17:06 +0000 (10:17 +0000)]
ppc.pl: fix bug in bn_mul_comba4 [from HEAD].
PR: 2636
Submitted by: Charles Bryant
Dr. Stephen Henson [Thu, 27 Oct 2011 13:06:26 +0000 (13:06 +0000)]
PR: 2628
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reviewed by: steve
Send alert instead of assertion failure for incorrectly formatted DTLS
fragments.
Dr. Stephen Henson [Wed, 26 Oct 2011 16:42:48 +0000 (16:42 +0000)]
PR: 2632
Submitted by: emmanuel.azencot@bull.net
Reviewed by: steve
Return -1 immediately if not affine coordinates as BN_CTX has not been
set up.
Bodo Möller [Wed, 19 Oct 2011 14:57:59 +0000 (14:57 +0000)]
BN_BLINDING multi-threading fix.
Submitted by: Emilia Kasper (Google)
Bodo Möller [Wed, 19 Oct 2011 13:53:41 +0000 (13:53 +0000)]
Oops: this change (cvs.openssl.org/chngview?cn=21503)
wasn't right for 0.9.8-stable (it's actually a fix for
http://cvs.openssl.org/chngview?cn=14494, which introduced
SSL_CTRL_SET_MAX_SEND_FRAGMENT).
Bodo Möller [Thu, 13 Oct 2011 13:24:13 +0000 (13:24 +0000)]
Clarify warning
Bodo Möller [Thu, 13 Oct 2011 13:04:40 +0000 (13:04 +0000)]
In ssl3_clear, preserve s3->init_extra along with s3->rbuf.
Submitted by: Bob Buckholz <bbuckholz@google.com>
Dr. Stephen Henson [Sun, 9 Oct 2011 00:56:18 +0000 (00:56 +0000)]
PR: 2482
Submitted by: Rob Austein <sra@hactrn.net>
Reviewed by: steve
Don't allow inverted ranges in RFC3779 code, discovered by Frank Ellermann.
Dr. Stephen Henson [Mon, 26 Sep 2011 17:05:00 +0000 (17:05 +0000)]
fix signed/unsigned warning
Dr. Stephen Henson [Fri, 23 Sep 2011 21:49:08 +0000 (21:49 +0000)]
use keyformat for -x509toreq, don't hard code PEM
Dr. Stephen Henson [Fri, 23 Sep 2011 13:40:06 +0000 (13:40 +0000)]
PR: 2606
Submitted by: Christoph Viethen <cv@kawo2.rwth-aachen.de>
Reviewed by: steve
Handle timezones correctly in UTCTime.
Dr. Stephen Henson [Fri, 23 Sep 2011 13:35:32 +0000 (13:35 +0000)]
PR: 2602
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reviewed by: steve
Fix DTLS bug which prevents manual MTU setting
Dr. Stephen Henson [Fri, 23 Sep 2011 13:13:02 +0000 (13:13 +0000)]
PR: 2347
Submitted by: Tomas Mraz <tmraz@redhat.com>
Reviewed by: steve
Fix usage message.
Bodo Möller [Mon, 5 Sep 2011 10:25:15 +0000 (10:25 +0000)]
(EC)DH memory handling fixes.
Submitted by: Adam Langley
Bodo Möller [Mon, 5 Sep 2011 09:56:48 +0000 (09:56 +0000)]
Fix memory leak on bad inputs.
Bodo Möller [Mon, 5 Sep 2011 09:52:58 +0000 (09:52 +0000)]
Move OPENSSL_init declaration out of auto-generated code section
(it is not auto-generated).
Dr. Stephen Henson [Fri, 2 Sep 2011 11:20:49 +0000 (11:20 +0000)]
PR: 2576
Submitted by: Doug Goldstein <cardoe@gentoo.org>
Reviewed by: steve
Include header file stdlib.h which is needed on some platforms to get
getenv() declaration.
Dr. Stephen Henson [Thu, 1 Sep 2011 15:03:10 +0000 (15:03 +0000)]
PR: 2340
Submitted by: "Mauro H. Leggieri" <mxmauro@caiman.com.ar>
Reviewed by: steve
Stop warnings if OPENSSL_NO_DGRAM is defined.
Dr. Stephen Henson [Thu, 1 Sep 2011 14:23:41 +0000 (14:23 +0000)]
make timing attack protection unconditional
Dr. Stephen Henson [Thu, 1 Sep 2011 14:01:36 +0000 (14:01 +0000)]
PR: 2573
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reviewed by: steve
Fix DTLS buffering and decryption bug.
Dr. Stephen Henson [Thu, 1 Sep 2011 13:48:48 +0000 (13:48 +0000)]
PR: 2588
Submitted by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Reviewed by: steve
Close file pointer.
Dr. Stephen Henson [Thu, 1 Sep 2011 13:37:11 +0000 (13:37 +0000)]
PR: 2586
Submitted by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Reviewed by: steve
Fix brace mismatch.
Dr. Stephen Henson [Wed, 20 Jul 2011 15:20:19 +0000 (15:20 +0000)]
PR: 2559
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reviewed by: steve
Fix DTLS socket error bug
Dr. Stephen Henson [Wed, 20 Jul 2011 15:17:20 +0000 (15:17 +0000)]
PR: 2555
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reviewed by: steve
Fix DTLS sequence number bug
Dr. Stephen Henson [Wed, 20 Jul 2011 15:12:58 +0000 (15:12 +0000)]
PR: 2550
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reviewed by: steve
Fix DTLS HelloVerifyRequest Timer bug
Andy Polyakov [Fri, 15 Jul 2011 19:59:31 +0000 (19:59 +0000)]
config: detect if assembler supports --noexecstack and pass it down [from HEAD].
Dr. Stephen Henson [Thu, 14 Jul 2011 12:01:08 +0000 (12:01 +0000)]
PR: 2556 (partial)
Reported by: Daniel Marschall <daniel-marschall@viathinksoft.de>
Reviewed by: steve
Fix OID routines.
Check on encoding leading zero rejection should start at beginning of
encoding.
Allow for initial digit when testing when to use BIGNUMs which can increase
first value by 2 * 40.
Andy Polyakov [Wed, 13 Jul 2011 06:25:15 +0000 (06:25 +0000)]
perlasm/cbc.pl: fix tail processing bug [from HEAD].
PR: 2557
Dr. Stephen Henson [Wed, 22 Jun 2011 15:46:37 +0000 (15:46 +0000)]
PR: 2471
Submitted by: Corinna Vinschen
util/cygwin.sh: maintainer's update [from HEAD].
Dr. Stephen Henson [Wed, 22 Jun 2011 15:39:19 +0000 (15:39 +0000)]
PR: 2470
Submitted by: Corinna Vinschen <vinschen@redhat.com>
Reviewed by: steve
Don't call ERR_remove_state from DllMain.
Dr. Stephen Henson [Wed, 22 Jun 2011 15:29:36 +0000 (15:29 +0000)]
PR: 2543
Submitted by: Robin Seggelmann <seggelmann@fh-muenster.de>
Reviewed by: steve
Correctly handle errors in DTLSv1_handle_timeout()
Dr. Stephen Henson [Wed, 22 Jun 2011 15:23:20 +0000 (15:23 +0000)]
PR: 2540
Submitted by: emmanuel.azencot@bull.net
Reviewed by: steve
Prevent infinite loop in BN_GF2m_mod_inv().
Dr. Stephen Henson [Wed, 22 Jun 2011 15:15:20 +0000 (15:15 +0000)]
correctly encode OIDs near 2^32
Andy Polyakov [Mon, 6 Jun 2011 19:58:21 +0000 (19:58 +0000)]
rc4_skey.c [0.9.8]: at some point rc4_skey and x86[_64]cpuid were modified
to examine bit#20 on x86[_64], but it was erroneously reverted to bit#28
in 2008 in process of FIPS integration.
Dr. Stephen Henson [Wed, 25 May 2011 15:15:43 +0000 (15:15 +0000)]
PR: 2529
Submitted by: Marcus Meissner <meissner@suse.de>
Reviewed by: steve
Call ssl_new() to reallocate SSL BIO internals if we want to replace
the existing internal SSL structure.
Dr. Stephen Henson [Wed, 25 May 2011 15:06:32 +0000 (15:06 +0000)]
PR: 2527
Submitted by: Marcus Meissner <meissner@suse.de>
Reviewed by: steve
Set cnf to NULL to avoid possible double free.
Dr. Stephen Henson [Wed, 25 May 2011 14:52:54 +0000 (14:52 +0000)]
Fix the ECDSA timing attack mentioned in the paper at:
http://eprint.iacr.org/2011/232.pdf
Thanks to the original authors Billy Bob Brumley and Nicola Tuveri for
bringing this to our attention.