oweals/busybox.git
15 years agosed: fix handling of 1d;1,3p and 1d;1,REGEXp
Denys Vlasenko [Tue, 30 Jun 2009 17:19:37 +0000 (19:19 +0200)]
sed: fix handling of 1d;1,3p and 1d;1,REGEXp

function                                             old     new   delta
process_files                                       2084    2173     +89

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agowget: fix redirection from HTTP to FTP server
Denys Vlasenko [Sun, 28 Jun 2009 01:33:57 +0000 (03:33 +0200)]
wget: fix redirection from HTTP to FTP server

while at it, sanitize redirection in general; add printout
of every redirection hop; make sure we won't print any non-ASCII
garbage from remote server in error meesages.

function                                             old     new   delta
sanitize_string                                        -      14     +14
parse_url                                            294     301      +7
gethdr                                               190     197      +7
wget_main                                           2326    2331      +5
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 3/0 up/down: 33/0)               Total: 33 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agowget: remove strange *&var construct.
Denys Vlasenko [Sat, 27 Jun 2009 23:23:35 +0000 (01:23 +0200)]
wget: remove strange *&var construct.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agowget: code shrink by splitting main() into easier-to-optimize functions
Denys Vlasenko [Sat, 27 Jun 2009 23:02:24 +0000 (01:02 +0200)]
wget: code shrink by splitting main() into easier-to-optimize functions

function                                             old     new   delta
retrieve_file_data                                     -     356    +356
wget_main                                           2793    2326    -467
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/1 up/down: 356/-467)         Total: -111 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoUpdate a comment, no code changes
Denys Vlasenko [Sat, 27 Jun 2009 20:09:28 +0000 (22:09 +0200)]
Update a comment, no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agodevice matching against UUIDs: do not try floppies
Denys Vlasenko [Sat, 27 Jun 2009 19:58:25 +0000 (21:58 +0200)]
device matching against UUIDs: do not try floppies

function                                             old     new   delta
uuidcache_check_device                               255     292     +37

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agotrylink: don't use ld --gc-sections if ld doesn't support it
Denys Vlasenko [Fri, 26 Jun 2009 22:24:35 +0000 (00:24 +0200)]
trylink: don't use ld --gc-sections if ld doesn't support it

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoprintf: (allegedly) fix testsuite failure
Denys Vlasenko [Fri, 26 Jun 2009 22:07:23 +0000 (00:07 +0200)]
printf: (allegedly) fix testsuite failure

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcpc: fix a read error loop (e.g.: device is down) blocking TERM
Denys Vlasenko [Fri, 26 Jun 2009 21:23:16 +0000 (23:23 +0200)]
udhcpc: fix a read error loop (e.g.: device is down) blocking TERM

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoupdates for supporting Linux kernel build and initrd utilities
Denys Vlasenko [Thu, 25 Jun 2009 23:55:45 +0000 (01:55 +0200)]
updates for supporting Linux kernel build and initrd utilities

cpio: --verbose, --quiet, --to-stdout
test: make 64-bit math enable-able for hush too
dnsdomainname: alias to hostname -d
hostname: support --fqdn, --domain, --file

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agomdev: fix the case when move rule deletes node with name == device_name
Denys Vlasenko [Sun, 21 Jun 2009 23:31:12 +0000 (01:31 +0200)]
mdev: fix the case when move rule deletes node with name == device_name

Signed-off-by: Jean Wolter <jw5@os.inf.tu-dresden.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agotrim/regularize usage texts. -92 bytes
Denys Vlasenko [Sat, 20 Jun 2009 01:59:02 +0000 (03:59 +0200)]
trim/regularize usage texts. -92 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: fix trivial compile error
Denys Vlasenko [Fri, 19 Jun 2009 11:51:29 +0000 (13:51 +0200)]
udhcp: fix trivial compile error

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agomkswap: remove configuration for v0 support
Denys Vlasenko [Fri, 19 Jun 2009 11:45:01 +0000 (13:45 +0200)]
mkswap: remove configuration for v0 support

mkswap hasn't had v0 support since commit
d893b120bae5a9bdef4cfda2df5e62867d6b1cd0; it doesn't seem to make sense
to offer it for configuration.

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agomkswap: separate UUID feature
Denys Vlasenko [Fri, 19 Jun 2009 11:14:48 +0000 (13:14 +0200)]
mkswap: separate UUID feature

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agogetopt: FEATURE_GETOPT_LONG for -l; rename GETOPT_LONG to LONG_OPTS
Denys Vlasenko [Fri, 19 Jun 2009 10:10:38 +0000 (12:10 +0200)]
getopt: FEATURE_GETOPT_LONG for -l; rename GETOPT_LONG to LONG_OPTS

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agomount: support -i; pass through -f and -n to helpers as necessary
Denys Vlasenko [Fri, 19 Jun 2009 09:48:29 +0000 (11:48 +0200)]
mount: support -i; pass through -f and -n to helpers as necessary

function                                             old     new   delta
mount_it_now                                         298     345     +47
singlemount                                          776     772      -4

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agomkswap: accidentally committed wrong patch. fix it up
Denys Vlasenko [Fri, 19 Jun 2009 09:00:52 +0000 (11:00 +0200)]
mkswap: accidentally committed wrong patch. fix it up

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agomkswap: improve randomness of UUID generation set version/variant bits
Denys Vlasenko [Fri, 19 Jun 2009 07:49:01 +0000 (09:49 +0200)]
mkswap: improve randomness of UUID generation set version/variant bits

function                                             old     new   delta
mkswap_main                                          317     410     +93

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoprintf: fix exit code on conversion error
Denys Vlasenko [Thu, 18 Jun 2009 20:22:04 +0000 (22:22 +0200)]
printf: fix exit code on conversion error

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agomkswap: generate UUID if CONFIG_DESKTOP=y. +110 bytes
Denys Vlasenko [Thu, 18 Jun 2009 19:55:47 +0000 (21:55 +0200)]
mkswap: generate UUID if CONFIG_DESKTOP=y. +110 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agotweak to config wording, no code changes
Denys Vlasenko [Thu, 18 Jun 2009 17:59:51 +0000 (19:59 +0200)]
tweak to config wording, no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agotweak Config texts and some broken English elsewhere
Denys Vlasenko [Thu, 18 Jun 2009 11:23:58 +0000 (13:23 +0200)]
tweak Config texts and some broken English elsewhere

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agofsync: new applet by Pekka Pessi (Pekka.Pessi AT nokia.com)
Denys Vlasenko [Thu, 18 Jun 2009 06:20:02 +0000 (08:20 +0200)]
fsync: new applet by Pekka Pessi (Pekka.Pessi AT nokia.com)

function                                             old     new   delta
fsync_main                                             -     128    +128
fdatasync                                              -      39     +39
packed_usage                                       26596   26622     +26
applet_names                                        2098    2104      +6
applet_main                                         1240    1244      +4
applet_nameofs                                       620     622      +2
applet_install_loc                                   155     156      +1
------------------------------------------------------------------------------
(add/remove: 2/0 grow/shrink: 5/0 up/down: 206/0)             Total: 206 bytes

Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agomodprobe: do not use ->probed_name blidly
Denys Vlasenko [Wed, 17 Jun 2009 18:33:50 +0000 (20:33 +0200)]
modprobe: do not use ->probed_name blidly

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agomodprobe: correct exitcode handling and error messages with respect to -q
Denys Vlasenko [Wed, 17 Jun 2009 16:46:06 +0000 (18:46 +0200)]
modprobe: correct exitcode handling and error messages with respect to -q

function                                             old     new   delta
do_modprobe                                          319     339     +20
bb_delete_module                                      10      26     +16
moderror                                              62      71      +9
bb_init_module                                       112     119      +7
modprobe_main                                        488     494      +6
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 5/0 up/down: 58/0)               Total: 58 bytes

Signed-off-by: Gilles Espinasse <g.esp@free.fr>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoswitch_root: allow /init to be a symlink; add doc (thanks Rob!)
Denys Vlasenko [Wed, 17 Jun 2009 12:03:24 +0000 (14:03 +0200)]
switch_root: allow /init to be a symlink; add doc (thanks Rob!)

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: cosmetics in arpping.c, no code changes
Denys Vlasenko [Wed, 17 Jun 2009 11:56:50 +0000 (13:56 +0200)]
udhcp: cosmetics in arpping.c, no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: convert old-style logging in print_static_leases
Denys Vlasenko [Wed, 17 Jun 2009 11:44:04 +0000 (13:44 +0200)]
udhcp: convert old-style logging in print_static_leases

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: logging improvements, field and variable renames
Denys Vlasenko [Wed, 17 Jun 2009 11:24:03 +0000 (13:24 +0200)]
udhcp: logging improvements, field and variable renames

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoexamples/udhcp/udhcpd.conf: update
Denys Vlasenko [Wed, 17 Jun 2009 11:22:26 +0000 (13:22 +0200)]
examples/udhcp/udhcpd.conf: update

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcpc: fix format of one log message
Denys Vlasenko [Wed, 17 Jun 2009 09:58:11 +0000 (11:58 +0200)]
udhcpc: fix format of one log message

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: shorten mac len from 16 to 6 in lease file
Denys Vlasenko [Wed, 17 Jun 2009 09:57:09 +0000 (11:57 +0200)]
udhcp: shorten mac len from 16 to 6 in lease file

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: change UDHCP_DEBUG into int, make verbosity selectable with -v
Denys Vlasenko [Wed, 17 Jun 2009 09:54:52 +0000 (11:54 +0200)]
udhcp: change UDHCP_DEBUG into int, make verbosity selectable with -v

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: add a few TODOs
Denys Vlasenko [Tue, 16 Jun 2009 10:05:21 +0000 (12:05 +0200)]
udhcp: add a few TODOs

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: rename server/client_config.arp to server_mac and client_mac
Denys Vlasenko [Tue, 16 Jun 2009 10:04:23 +0000 (12:04 +0200)]
udhcp: rename server/client_config.arp to server_mac and client_mac

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: cleanup of static lease handling
Denys Vlasenko [Tue, 16 Jun 2009 10:03:12 +0000 (12:03 +0200)]
udhcp: cleanup of static lease handling

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: rename sprintip to sprint_nip, siaddr to siaddr_nip
Denys Vlasenko [Tue, 16 Jun 2009 08:25:35 +0000 (10:25 +0200)]
udhcp: rename sprintip to sprint_nip, siaddr to siaddr_nip

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: rename giaddr to gateway_nip and server to server_nip
Denys Vlasenko [Tue, 16 Jun 2009 08:23:55 +0000 (10:23 +0200)]
udhcp: rename giaddr to gateway_nip and server to server_nip

"nip" stands for "IP in network order"

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcp: rename fields in struct dhcpOfferedAddr
Denys Vlasenko [Tue, 16 Jun 2009 08:23:01 +0000 (10:23 +0200)]
udhcp: rename fields in struct dhcpOfferedAddr

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoudhcpd: don't fail ARP check if returned MAC matches client's one
Denys Vlasenko [Tue, 16 Jun 2009 08:20:27 +0000 (10:20 +0200)]
udhcpd: don't fail ARP check if returned MAC matches client's one

Also, do not unicast replies to yiaddr.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoinstall: compat fix for mode of created files.
Denys Vlasenko [Mon, 15 Jun 2009 16:13:51 +0000 (18:13 +0200)]
install: compat fix for mode of created files.

By Mat Hostetter (mhostetter AT tilera.com)

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoseq: fix input handling in non-C locales
Denys Vlasenko [Mon, 15 Jun 2009 13:47:58 +0000 (15:47 +0200)]
seq: fix input handling in non-C locales

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agovi: do not accept uppercase comments (compat). Closes bug 397.
Denys Vlasenko [Mon, 15 Jun 2009 10:44:11 +0000 (12:44 +0200)]
vi: do not accept uppercase comments (compat). Closes bug 397.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agolibbb: stop using bb_strtod for now
Denys Vlasenko [Mon, 15 Jun 2009 07:50:54 +0000 (09:50 +0200)]
libbb: stop using bb_strtod for now

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoseq: fix testsuite failures
Denys Vlasenko [Mon, 15 Jun 2009 07:16:27 +0000 (09:16 +0200)]
seq: fix testsuite failures

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoash: fix . builtin
Denys Vlasenko [Sun, 14 Jun 2009 17:42:12 +0000 (19:42 +0200)]
ash: fix . builtin

Also, move [[ ]] comment to test.c and expand it

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agofix or document testsuite failures
Denys Vlasenko [Sat, 13 Jun 2009 21:41:57 +0000 (23:41 +0200)]
fix or document testsuite failures

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agotest, tcpsvd, tcpsvd: shrink
Denys Vlasenko [Sat, 13 Jun 2009 20:49:08 +0000 (22:49 +0200)]
test, tcpsvd, tcpsvd: shrink

function                                             old     new   delta
nexpr                                                825     826      +1
tcpudpsvd_main                                      1830    1822      -8
test_main                                            257     247     -10
binop                                                584     525     -59
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/3 up/down: 1/-77)             Total: -76 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agofix permissions in testsuite
Denys Vlasenko [Sat, 13 Jun 2009 14:35:20 +0000 (16:35 +0200)]
fix permissions in testsuite

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoUpdate POSIX compliance table
Denys Vlasenko [Fri, 12 Jun 2009 13:32:51 +0000 (15:32 +0200)]
Update POSIX compliance table

Signed-off-by: Max Panasenkov <panmax@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoreadlink: support -n, -v, -s and -q too if support for -f is requested
Denys Vlasenko [Fri, 12 Jun 2009 11:16:21 +0000 (13:16 +0200)]
readlink: support -n, -v, -s and -q too if support for -f is requested

function                                             old     new   delta
readlink_main                                        104     135     +31
packed_usage                                       26322   26321      -1
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 31/-1)              Total: 30 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoash: revert over-zealous usage of FAST_FUNC
Denys Vlasenko [Thu, 11 Jun 2009 17:30:19 +0000 (19:30 +0200)]
ash: revert over-zealous usage of FAST_FUNC

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoadded comments about [[ ]] to ash and hush. no code changes
Denys Vlasenko [Wed, 10 Jun 2009 12:09:48 +0000 (14:09 +0200)]
added comments about [[ ]] to ash and hush. no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: add HUSH_BASH_COMPAT, make [[ special handling depend on it
Denys Vlasenko [Wed, 10 Jun 2009 11:39:35 +0000 (13:39 +0200)]
hush: add HUSH_BASH_COMPAT, make [[ special handling depend on it

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agotelnetd: more compact version of the fix for stray open fds
Denys Vlasenko [Wed, 10 Jun 2009 11:38:08 +0000 (13:38 +0200)]
telnetd: more compact version of the fix for stray open fds

function                                             old     new   delta
telnetd_main                                        1520    1527      +7
make_new_session                                     510     416     -94
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 7/-94)             Total: -87 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agotelnetd: properly close fds in child
Denys Vlasenko [Tue, 9 Jun 2009 21:01:24 +0000 (23:01 +0200)]
telnetd: properly close fds in child

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: specially handle [[ - suppress globbing & multiword expansion
Denys Vlasenko [Tue, 9 Jun 2009 16:40:52 +0000 (18:40 +0200)]
hush: specially handle [[ - suppress globbing & multiword expansion

It's a bashism, but is surprisingly easy to do and costs very little code.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agorandomconfig fixes
Denys Vlasenko [Tue, 9 Jun 2009 16:40:07 +0000 (18:40 +0200)]
randomconfig fixes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agodiff: tiny compat tweak
Denys Vlasenko [Tue, 9 Jun 2009 10:55:13 +0000 (12:55 +0200)]
diff: tiny compat tweak

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: drop REDIRECT_INVALID; other minor tweaks
Denys Vlasenko [Sun, 7 Jun 2009 14:05:04 +0000 (16:05 +0200)]
hush: drop REDIRECT_INVALID; other minor tweaks

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: fix a segfault in export builtin
Denys Vlasenko [Sun, 7 Jun 2009 14:04:17 +0000 (16:04 +0200)]
hush: fix a segfault in export builtin

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agostop using non-standard macro, use WEXITSTATUS instead
Denys Vlasenko [Sun, 7 Jun 2009 14:02:00 +0000 (16:02 +0200)]
stop using non-standard macro, use WEXITSTATUS instead

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: make builtins work in pipes (eval ... | ...) on NOMMU
Denys Vlasenko [Sat, 6 Jun 2009 18:59:55 +0000 (20:59 +0200)]
hush: make builtins work in pipes (eval ... | ...) on NOMMU

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoifupdown: if $PATH is not set, do not set it to "" in children
Denys Vlasenko [Fri, 5 Jun 2009 19:53:11 +0000 (21:53 +0200)]
ifupdown: if $PATH is not set, do not set it to "" in children

Also random code shrink:

function                                             old     new   delta
set_environ                                          328     330      +2
static.label_buf                                       4       -      -4
startup_PATH                                           4       -      -4
my_environ                                             4       -      -4
ifupdown_main                                       2148    2134     -14
setlocalenv                                          117      90     -27
get_var                                              139     112     -27
------------------------------------------------------------------------------
(add/remove: 0/3 grow/shrink: 1/3 up/down: 2/-80)             Total: -78 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoftpd: allow multiple -S options to increase verbosity too, like -v
Denys Vlasenko [Fri, 5 Jun 2009 18:42:40 +0000 (20:42 +0200)]
ftpd: allow multiple -S options to increase verbosity too, like -v

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoprintf: accept negative numbers for %x; sh: overflowed numbers are 0
Denys Vlasenko [Fri, 5 Jun 2009 14:24:29 +0000 (16:24 +0200)]
printf: accept negative numbers for %x; sh: overflowed numbers are 0

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoinetd: comment why we redirect stderr to network
Denys Vlasenko [Fri, 5 Jun 2009 13:35:36 +0000 (15:35 +0200)]
inetd: comment why we redirect stderr to network

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years ago*: reduce #ifdef forest
Denys Vlasenko [Fri, 5 Jun 2009 12:55:26 +0000 (14:55 +0200)]
*: reduce #ifdef forest

Remove unnecessary #if statements from the "more", "script", and
"scriptreplay" commands.  Bloatcheck says 0 bytes changed.

Signed-off-by: Rob Landley <rob@landley.net>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years ago*: add FAST_FUNC to function ptrs where it makes sense
Denys Vlasenko [Fri, 5 Jun 2009 10:06:05 +0000 (12:06 +0200)]
*: add FAST_FUNC to function ptrs where it makes sense

function                                             old     new   delta
evalcommand                                         1195    1209     +14
testcmd                                                -      10     +10
printfcmd                                              -      10     +10
echocmd                                                -      10     +10
func_exec                                            270     276      +6
echo_dg                                              104     109      +5
store_nlmsg                                           85      89      +4
pseudo_exec_argv                                     195     198      +3
dotcmd                                               287     290      +3
machtime_stream                                       29      31      +2
discard_stream                                        24      26      +2
argstr                                              1299    1301      +2
killcmd                                              108     109      +1
evalfor                                              226     227      +1
daytime_stream                                        43      44      +1
run_list                                            2544    2543      -1
lookupvar                                             62      61      -1
ipaddr_modify                                       1310    1309      -1
...
parse_stream                                        2254    2245      -9
evalpipe                                             356     347      -9
collect_if                                           210     197     -13
read_opt                                             869     851     -18
handle_dollar                                        681     658     -23
print_addrinfo                                      1342    1303     -39
iterate_on_dir                                       156      59     -97
print_route                                         1709    1609    -100
------------------------------------------------------------------------------
(add/remove: 3/0 grow/shrink: 12/130 up/down: 74/-767)       Total: -693 bytes
   text    data     bss     dec     hex filename
 841748     467    7872  850087   cf8a7 busybox_old
 841061     467    7872  849400   cf5f8 busybox_unstripped

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoftpd: fix a case when with -w unknown commands are ignored with no error code
Denys Vlasenko [Thu, 4 Jun 2009 17:03:20 +0000 (19:03 +0200)]
ftpd: fix a case when with -w unknown commands are ignored with no error code

Signed-off-by: Stefan Seyfried <seife@suse.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agorename CONFIG_FEATURE_TAR_GZIP
Bernhard Reutner-Fischer [Wed, 3 Jun 2009 18:35:26 +0000 (20:35 +0200)]
rename CONFIG_FEATURE_TAR_GZIP

  CONFIG_FEATURE_TAR_GZIP was renamed to CONFIG_FEATURE_SEAMLESS_GZ.
  Adjust testsuite accordingly.

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
15 years agotweak docs
Denys Vlasenko [Wed, 3 Jun 2009 13:19:03 +0000 (15:19 +0200)]
tweak docs

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: document a TODO in export builtin
Denys Vlasenko [Wed, 3 Jun 2009 12:43:56 +0000 (14:43 +0200)]
hush: document a TODO in export builtin

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: fix a case when backgrounded cmd makes shell hang
Denys Vlasenko [Wed, 3 Jun 2009 12:37:30 +0000 (14:37 +0200)]
hush: fix a case when backgrounded cmd makes shell hang

Signed-off-by: Bayram Kurumahmut <kbayram@ubicom.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: add support for local builtin
Denys Vlasenko [Wed, 3 Jun 2009 10:47:26 +0000 (12:47 +0200)]
hush: add support for local builtin

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agobloat-o-meter: touchup argv handling
Mike Frysinger [Mon, 1 Jun 2009 20:37:27 +0000 (16:37 -0400)]
bloat-o-meter: touchup argv handling

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Reported-by: Matt Mackall <mpm@selenic.com>
15 years agobloat-o-meter: fix tab/space mixing
Mike Frysinger [Mon, 1 Jun 2009 20:34:11 +0000 (16:34 -0400)]
bloat-o-meter: fix tab/space mixing

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agohush_test: stop mixing tabs/spaces for indentation
Mike Frysinger [Mon, 1 Jun 2009 20:33:05 +0000 (16:33 -0400)]
hush_test: stop mixing tabs/spaces for indentation

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agogitignore: add debugging related files
Mike Frysinger [Mon, 1 Jun 2009 18:15:04 +0000 (14:15 -0400)]
gitignore: add debugging related files

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agohush: unify syntax_error_unterm_{ch,str} a bit
Mike Frysinger [Mon, 1 Jun 2009 18:14:36 +0000 (14:14 -0400)]
hush: unify syntax_error_unterm_{ch,str} a bit

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agohush: push down expansion var in handle_dollar()
Mike Frysinger [Mon, 1 Jun 2009 18:13:39 +0000 (14:13 -0400)]
hush: push down expansion var in handle_dollar()

Declare the variable in the scope it is used rather than the entire
function scope so it's obvious it is only used there.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agohush: add support for special vars in braces
Mike Frysinger [Mon, 1 Jun 2009 18:09:09 +0000 (14:09 -0400)]
hush: add support for special vars in braces

Some people like to use ${?} rather than $?, so make sure we support all
the special single char vars that use this form.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agohush_test: filter test output to avoid C lib differences
Mike Frysinger [Mon, 1 Jun 2009 18:08:09 +0000 (14:08 -0400)]
hush_test: filter test output to avoid C lib differences

The getopt function in some C libraries wraps the option in single quotes
while others do not.  Avoid the issue by running sed on the output and
strip all quotes.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agolineedit: fix warning about unused label when VI editing is disabled
Mike Frysinger [Mon, 1 Jun 2009 18:02:49 +0000 (14:02 -0400)]
lineedit: fix warning about unused label when VI editing is disabled

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agonc, hush: cosmetic cleanups, no code changes
Denys Vlasenko [Mon, 1 Jun 2009 09:26:30 +0000 (11:26 +0200)]
nc, hush: cosmetic cleanups, no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoread_key: drop optimization where we read 3 bytes at once
Denys Vlasenko [Fri, 29 May 2009 08:39:06 +0000 (10:39 +0200)]
read_key: drop optimization where we read 3 bytes at once

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohust: trivial simplification in builtin_type
Denys Vlasenko [Thu, 28 May 2009 15:07:22 +0000 (17:07 +0200)]
hust: trivial simplification in builtin_type

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: fix bug 353 (wrong handling of \x in assignments)
Denys Vlasenko [Thu, 28 May 2009 14:49:11 +0000 (16:49 +0200)]
hush: fix bug 353 (wrong handling of \x in assignments)

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: optimize type builtin a bit more
Denys Vlasenko [Thu, 28 May 2009 07:58:43 +0000 (09:58 +0200)]
hush: optimize type builtin a bit more

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: optimize type builtin a bit
Denys Vlasenko [Thu, 28 May 2009 07:45:50 +0000 (09:45 +0200)]
hush: optimize type builtin a bit

function                                             old     new   delta
builtin_type                                         130     125      -5

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoonly build common libarchive objs when needed
Mike Frysinger [Thu, 28 May 2009 04:47:14 +0000 (00:47 -0400)]
only build common libarchive objs when needed

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agomodprobe: fix more bugs in modprobe -r
Denys Vlasenko [Thu, 28 May 2009 01:54:29 +0000 (03:54 +0200)]
modprobe: fix more bugs in modprobe -r

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agocpio.tests: fix false positive
Denys Vlasenko [Thu, 28 May 2009 00:03:29 +0000 (02:03 +0200)]
cpio.tests: fix false positive

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: implement `type`
Mike Frysinger [Wed, 27 May 2009 21:06:25 +0000 (17:06 -0400)]
hush: implement `type`

Implement support for the POSIX `type` command.  Only POSIX stuff is
supported here, no bash extensions like -p or -P.

In the process, split the $PATH searching code out of builtin_source() and
into its own find_in_path() function so we don't duplicate it.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agohush: remove outdated TODO and superfluous macro; fix compile breakage
Denys Vlasenko [Wed, 27 May 2009 12:39:35 +0000 (14:39 +0200)]
hush: remove outdated TODO and superfluous macro; fix compile breakage

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agoPOSIX conformance documentation for busybox
David Krakov [Tue, 26 May 2009 23:42:34 +0000 (19:42 -0400)]
POSIX conformance documentation for busybox

Attached a start for POSIX conformance documentation for busybox (see
TODO file and discussion last week).
A table of all options as defined by POSIX and as implemented by
busybox (see for a FreeBSD example
http://people.freebsd.org/~schweikh/posix-utilities.html).

Only the tools that are stand-alone applets are documented (not ash
built-ins as 'read'), as there are multiple shells.
When there are two versions (echo) the stand-alone version was
checked. I think this may be the wrong way to go, as most users will
probably use the built-in version - but which shell?

The table was auto-generated by running, for each POSIX utility,
latest git allyesconfig* "busybox <tool> --help" and parsing the
output, and comparing that to tool options extracted from its man page
at http://www.opengroup.org/onlinepubs/9699919799/.
This means that it the usage string is not correct, the table is also
wrong. I noticed that for 'kill', for example, the usage string does
not mention the -s, -q, -o options.
For each option is set whether it exists in busybox and if it is, is
it compliant to the standard. Of course, checking compliance can only
be done manually - a process which will probably take some time (see
'cat' for example).

I didn't post the auto-generation script (python, ugly) because the
table will now change manually; I can post it if there is anyone
interested.

As for the tools not implemented by busybox at all, I think most of
them are indeed fairly esotetic. Some I was suprised to see missing
are link, file, newgrp, unlink.

* Well, almost allyesconfig - but nothing very POSIX-y was disabled.

Signed-off-by: David Krakov <krakov@gmail.org>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
15 years agohush: tweak comment
Denys Vlasenko [Tue, 26 May 2009 12:39:41 +0000 (14:39 +0200)]
hush: tweak comment

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agohush: rename last_waitpid_was_0 to we_have_children
Denys Vlasenko [Tue, 26 May 2009 12:34:10 +0000 (14:34 +0200)]
hush: rename last_waitpid_was_0 to we_have_children

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
15 years agomodprobe: fix modprobe -r. closes bug 315
Denys Vlasenko [Tue, 26 May 2009 10:48:34 +0000 (12:48 +0200)]
modprobe: fix modprobe -r. closes bug 315

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>