oweals/busybox.git
14 years agolibbb: make index_in_substrings return -1 on ambiguous matches
Denys Vlasenko [Fri, 2 Apr 2010 22:52:16 +0000 (00:52 +0200)]
libbb: make index_in_substrings return -1 on ambiguous matches

function                                             old     new   delta
index_in_substrings                                   67      93     +26

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibpwdgrp: comment out unused data
Denys Vlasenko [Fri, 2 Apr 2010 10:12:43 +0000 (12:12 +0200)]
libpwdgrp: comment out unused data

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohttpd: fix proxy mode bug (annoying but harmless), better help text
Denys Vlasenko [Fri, 2 Apr 2010 08:40:58 +0000 (10:40 +0200)]
httpd: fix proxy mode bug (annoying but harmless), better help text

function                                             old     new   delta
cgi_io_loop_and_exit                                 594     635     +41
packed_usage                                       26815   26841     +26
handle_incoming_and_exit                            2745    2739      -6

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotestsuite fixes
Chris Metcalf [Fri, 2 Apr 2010 07:57:27 +0000 (09:57 +0200)]
testsuite fixes

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoifplugd: more robust interface name match check
Denys Vlasenko [Fri, 2 Apr 2010 05:04:44 +0000 (07:04 +0200)]
ifplugd: more robust interface name match check

function                                             old     new   delta
check_existence_through_netlink                      278     308     +30

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomdev: add "!" syntax support
Denys Vlasenko [Fri, 2 Apr 2010 04:47:14 +0000 (06:47 +0200)]
mdev: add "!" syntax support

Based on the patch by Steve Bennett <steveb@workware.net.au>

function                                             old     new   delta
make_device                                         1640    1673     +33

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoclean up redundant, commented-out and misplaced includes
Denys Vlasenko [Thu, 1 Apr 2010 13:09:44 +0000 (15:09 +0200)]
clean up redundant, commented-out and misplaced includes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agofix Config.in tab usage
Denys Vlasenko [Wed, 31 Mar 2010 14:03:56 +0000 (16:03 +0200)]
fix Config.in tab usage

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agosyslogd: make maximum message length configurable
Janne Kiviluoto [Wed, 31 Mar 2010 13:58:58 +0000 (15:58 +0200)]
syslogd: make maximum message length configurable

Signed-off-by: Janne Kiviluoto <janne.kiviluoto@bluegiga.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibpwdgrp: comment out more unused functions
Denys Vlasenko [Wed, 31 Mar 2010 12:43:58 +0000 (14:43 +0200)]
libpwdgrp: comment out more unused functions

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibpwdgrp: comment out functions with UNUSED_SINCE_WE_AVOID_STATIC_BUFS
Denys Vlasenko [Wed, 31 Mar 2010 10:38:17 +0000 (12:38 +0200)]
libpwdgrp: comment out functions with UNUSED_SINCE_WE_AVOID_STATIC_BUFS

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibpwdgrp: style cleanups
Denys Vlasenko [Wed, 31 Mar 2010 10:37:43 +0000 (12:37 +0200)]
libpwdgrp: style cleanups

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibpwdgrp: code style fixes, no real code changes
Denys Vlasenko [Wed, 31 Mar 2010 08:31:51 +0000 (10:31 +0200)]
libpwdgrp: code style fixes, no real code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibpwdgrp: can't depend on strlen(line_buff) != 0
Denys Vlasenko [Wed, 31 Mar 2010 08:24:37 +0000 (10:24 +0200)]
libpwdgrp: can't depend on strlen(line_buff) != 0

function                                             old     new   delta
bb__pgsreader                                        188     202     +14

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodpkg: remove redundant check
Denys Vlasenko [Tue, 30 Mar 2010 14:20:34 +0000 (16:20 +0200)]
dpkg: remove redundant check

function                                             old     new   delta
dpkg_main                                           4008    3991     -17

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoifplugd: code shrink; expanded comments
Maxim Kryzhanovsky [Tue, 30 Mar 2010 13:49:57 +0000 (15:49 +0200)]
ifplugd: code shrink; expanded comments

Signed-off-by: Maxim Kryzhanovsky <xmaks@email.cz>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodpkg: better check for validity of options
Denys Vlasenko [Tue, 30 Mar 2010 13:03:26 +0000 (15:03 +0200)]
dpkg: better check for validity of options

function                                             old     new   delta
dpkg_main                                           3980    4008     +28

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodpkg: support config file overwrite options
Kim B. Heino [Mon, 29 Mar 2010 12:18:27 +0000 (14:18 +0200)]
dpkg: support config file overwrite options

function                                             old     new   delta
filter_rename_config                                   -     244    +244
static.dpkg_longopts                                   -     112    +112
dpkg_main                                           3901    3980     +79
unpack_package                                       515     587     +72
append_control_file_to_llist                           -      72     +72
data_extract_all_prefix                               88     116     +28
------------------------------------------------------------------------------
(add/remove: 3/0 grow/shrink: 3/0 up/down: 607/0)             Total: 607 bytes

Signed-off-by: Kim B. Heino <Kim.Heino@bluegiga.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoprovide safe_gethostname() for non-linux systems
Denys Vlasenko [Mon, 29 Mar 2010 09:20:00 +0000 (11:20 +0200)]
provide safe_gethostname() for non-linux systems

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibbb: locate PAGE_SIZE on Hurd
Denys Vlasenko [Mon, 29 Mar 2010 09:02:00 +0000 (11:02 +0200)]
libbb: locate PAGE_SIZE on Hurd

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoifplugd: code shrink
Maxim Kryzhanovsky [Mon, 29 Mar 2010 07:09:05 +0000 (09:09 +0200)]
ifplugd: code shrink

   text    data     bss     dec     hex filename
 840048     453    6828  847329   cede1 busybox_old
 839915     453    6828  847196   ced5c busybox_unstripped

Signed-off-by: Maxim Kryzhanovsky <xmaks@email.cz>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years ago"make release" should delete .git directory too
Denys Vlasenko [Sun, 28 Mar 2010 18:26:40 +0000 (20:26 +0200)]
"make release" should delete .git directory too

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agocpio test: fix false positive with DESKTOP off
Denys Vlasenko [Sun, 28 Mar 2010 18:07:42 +0000 (20:07 +0200)]
cpio test: fix false positive with DESKTOP off

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agousage: random tweaks to help texts
Denys Vlasenko [Sat, 27 Mar 2010 23:30:35 +0000 (00:30 +0100)]
usage: random tweaks to help texts

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodumpleases: better help text
Denys Vlasenko [Sat, 27 Mar 2010 23:02:20 +0000 (00:02 +0100)]
dumpleases: better help text

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcpd: fix -v/-P mixup
Denys Vlasenko [Sat, 27 Mar 2010 22:24:57 +0000 (23:24 +0100)]
udhcpd: fix -v/-P mixup

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: abort if we see unknown option, and show valid options if so
Denys Vlasenko [Sat, 27 Mar 2010 22:23:41 +0000 (23:23 +0100)]
udhcp: abort if we see unknown option, and show valid options if so

function                                             old     new   delta
udhcp_option_idx                                       -      77     +77
udhcp_str2optset                                     366     351     -15
udhcpc_main                                         2845    2801     -44
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/2 up/down: 77/-59)             Total: 18 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agosysctl: tiny code shrink
Denys Vlasenko [Sat, 27 Mar 2010 04:02:00 +0000 (05:02 +0100)]
sysctl: tiny code shrink

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoHurd compat fixes. Mostly dealing with absent PATH_MAX
Jérémie Koenig [Fri, 26 Mar 2010 18:08:53 +0000 (19:08 +0100)]
Hurd compat fixes. Mostly dealing with absent PATH_MAX

Signed-off-by: Jérémie Koenig <jk@jk.fr.eu.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agovi: fix NUM + "$" handling
Denys Vlasenko [Fri, 26 Mar 2010 15:10:14 +0000 (16:10 +0100)]
vi: fix NUM + "$" handling

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: line up builtin table. no code changes
Denys Vlasenko [Fri, 26 Mar 2010 14:53:33 +0000 (15:53 +0100)]
ash: line up builtin table. no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: trap with bad signal name should not abort
Denys Vlasenko [Fri, 26 Mar 2010 14:52:24 +0000 (15:52 +0100)]
ash: trap with bad signal name should not abort

function                                             old     new   delta
trapcmd                                              236     271     +35

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agounicode: s/FEATURE_ASSUME_UNICODE/UNICODE_SUPPORT, add UNICODE_USING_LOCALE
Denys Vlasenko [Fri, 26 Mar 2010 13:06:56 +0000 (14:06 +0100)]
unicode: s/FEATURE_ASSUME_UNICODE/UNICODE_SUPPORT, add UNICODE_USING_LOCALE

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agounicode: optional table for better handling of neutral bidi chars
Tomas Heinrich [Fri, 26 Mar 2010 12:13:24 +0000 (13:13 +0100)]
unicode: optional table for better handling of neutral bidi chars

Off:
function                                             old     new   delta
unicode_bidi_isrtl                                     -      55     +55
isrtl_str                                             51      65     +14
unicode_isrtl                                         55       -     -55
read_line_input                                     5003    4937     -66
------------------------------------------------------------------------------
(add/remove: 1/4 grow/shrink: 1/1 up/down: 69/-121)           Total: -52 bytes

On:
function                                             old     new   delta
static.neutral_b                                       -     320    +320
static.neutral_p                                       -     142    +142
unicode_bidi_isrtl                                     -      55     +55
unicode_bidi_is_neutral_wchar                          -      55     +55
isrtl_str                                             51      59      +8
unicode_isrtl                                         55       -     -55
read_line_input                                     5003    4937     -66
------------------------------------------------------------------------------
(add/remove: 4/4 grow/shrink: 1/1 up/down: 580/-121)          Total: 459 bytes

Signed-off-by: Tomas Heinrich <heinrich.tomas@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: cosmetic cleanups; one case of s/full_read/xread/
Denys Vlasenko [Fri, 26 Mar 2010 09:09:34 +0000 (10:09 +0100)]
udhcp: cosmetic cleanups; one case of s/full_read/xread/

function                                             old     new   delta
dumpleases_main                                      632     623      -9

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agounexpand: fix "a b"\n" input case
Tomas Heinrich [Fri, 26 Mar 2010 08:46:07 +0000 (09:46 +0100)]
unexpand: fix "a b"\n" input case

Signed-off-by: Tomas Heinrich <heinrich.tomas@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years ago[un]expand: account for different character widths. +16 bytes.
Tomas Heinrich [Fri, 26 Mar 2010 08:40:47 +0000 (09:40 +0100)]
[un]expand: account for different character widths. +16 bytes.

Signed-off-by: Tomas Heinrich <heinrich.tomas@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: pass pointer to whole packet to "add option" functions
Denys Vlasenko [Fri, 26 Mar 2010 08:32:09 +0000 (09:32 +0100)]
udhcp: pass pointer to whole packet to "add option" functions

This is needed for "overflow option" support

function                                             old     new   delta
udhcp_find_option                                      -      34     +34
udhcp_add_binary_option                               94     106     +12
write_leases                                         227     223      -4
udhcp_init_header                                     86      82      -4
send_release                                         104      99      -5
init_packet                                           87      81      -6
add_client_options                                   160     154      -6
add_server_options                                   100      92      -8
udhcpd_main                                         1964    1954     -10
udhcpc_main                                         2859    2837     -22
find_option                                           34       -     -34
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 1/8 up/down: 46/-99)            Total: -53 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: move options.c to common.c; disable unused bool and s16 option code
Denys Vlasenko [Fri, 26 Mar 2010 07:35:24 +0000 (08:35 +0100)]
udhcp: move options.c to common.c; disable unused bool and s16 option code

function                                             old     new   delta
udhcp_add_binary_option                                -      94     +94
udhcp_str2nip                                          -      42     +42
len_of_option_as_string                               12      10      -2
dhcp_option_lengths                                   12      10      -2
udhcpc_main                                         2859    2851      -8
read_nip                                              42       -     -42
xmalloc_optname_optval                               590     536     -54
udhcp_str2optset                                     443     366     -77
udhcp_add_option_string                               86       -     -86
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 0/5 up/down: 136/-271)         Total: -135 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcpc: add -x OPT:VAL option
Denys Vlasenko [Thu, 25 Mar 2010 19:32:38 +0000 (20:32 +0100)]
udhcpc: add -x OPT:VAL option

function                                             old     new   delta
udhcp_str2optset                                       -     443    +443
add_client_options                                     -     160    +160
udhcpc_main                                         2753    2857    +104
packed_usage                                       26670   26689     +19
attach_option                                        380     385      +5
udhcpd_main                                         1964    1965      +1
udhcp_add_option_string                               94      86      -8
add_param_req_option                                 128       -    -128
read_opt                                             443       -    -443
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 4/1 up/down: 732/-579)          Total: 153 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoupdate defconfig
Bernhard Reutner-Fischer [Thu, 25 Mar 2010 13:15:24 +0000 (14:15 +0100)]
update defconfig

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
14 years agoremove ar write support from TODO
Bernhard Reutner-Fischer [Thu, 25 Mar 2010 13:15:04 +0000 (14:15 +0100)]
remove ar write support from TODO

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
14 years agoudhcp: add testing bits to dns en/decoder
Denys Vlasenko [Wed, 24 Mar 2010 15:43:16 +0000 (16:43 +0100)]
udhcp: add testing bits to dns en/decoder

we had two bugs there at least, must have testing

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: we call DNS name encoder with NULL, this can SEGV. added a check
Denys Vlasenko [Wed, 24 Mar 2010 15:11:32 +0000 (16:11 +0100)]
udhcp: we call DNS name encoder with NULL, this can SEGV. added a check

function                                             old     new   delta
dname_enc                                            418     415      -3

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: fix DNS domanin codec bug: bad compression flag checks
Denys Vlasenko [Wed, 24 Mar 2010 14:06:23 +0000 (15:06 +0100)]
udhcp: fix DNS domanin codec bug: bad compression flag checks

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years ago*: merge some common strings
Denys Vlasenko [Tue, 23 Mar 2010 15:25:17 +0000 (16:25 +0100)]
*: merge some common strings

   text   data    bss    dec    hexfilename
 838650   8009      0 846659  ceb43busybox_old
 838519   8009      0 846528  ceac0busybox_unstripped

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: handle errors in read_staticlease
Denys Vlasenko [Tue, 23 Mar 2010 14:43:08 +0000 (15:43 +0100)]
udhcp: handle errors in read_staticlease

also gets rid of ether-aton's static buffer in ether-wake:
   text   data    bss    dec    hexfilename
 838664    441   7572 846677  ceb55busybox_old
 838650    441   7564 846655  ceb3fbusybox_unstripped

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agobrctl: fixing stp parameters incompatibility
Maciek Borzecki [Tue, 23 Mar 2010 04:18:38 +0000 (05:18 +0100)]
brctl: fixing stp parameters incompatibility

function                                             old     new   delta
static.stp_opts                                        -      23     +23
brctl_main                                          1148    1169     +21
packed_usage                                       26786   26794      +8
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 2/0 up/down: 52/0)               Total: 52 bytes

Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolsusb: 2.6.32 compat
Souf Oued [Tue, 23 Mar 2010 04:06:37 +0000 (05:06 +0100)]
lsusb: 2.6.32 compat

Signed-off-by: Souf Oued <souf_oued@yahoo.fr>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: code shrink
Denys Vlasenko [Tue, 23 Mar 2010 03:31:38 +0000 (04:31 +0100)]
udhcp: code shrink

function                                             old     new   delta
attach_option                                          -     380    +380
read_opt                                             859     443    -416
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/1 up/down: 380/-416)          Total: -36 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: remove two unused fields
Denys Vlasenko [Tue, 23 Mar 2010 01:17:52 +0000 (02:17 +0100)]
udhcp: remove two unused fields

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash,hush: make it possible to build them individually
Denys Vlasenko [Tue, 23 Mar 2010 00:08:26 +0000 (01:08 +0100)]
ash,hush: make it possible to build them individually

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodate,touch: accept Jan 7 00:00:00 2010 format
Alexander Shishkin [Mon, 22 Mar 2010 17:22:33 +0000 (18:22 +0100)]
date,touch: accept Jan 7 00:00:00 2010 format

function                                             old     new   delta
parse_datestr                                        618     647     +29

Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: make rfc derived doc more readable (but it still is contradictory)
Denys Vlasenko [Mon, 22 Mar 2010 14:22:14 +0000 (15:22 +0100)]
udhcp: make rfc derived doc more readable (but it still is contradictory)

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: merge options.h into common.h, script.c into dhcpc.c
Denys Vlasenko [Mon, 22 Mar 2010 13:29:13 +0000 (14:29 +0100)]
udhcp: merge options.h into common.h, script.c into dhcpc.c

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcpc: do not test for srand init, just do it at the start
Denys Vlasenko [Mon, 22 Mar 2010 12:44:09 +0000 (13:44 +0100)]
udhcpc: do not test for srand init, just do it at the start

function                                             old     new   delta
udhcpc_main                                         2855    2867     +12
static.initialized                                     1       -      -1
client_background                                     32      31      -1
perform_release                                      124     122      -2
random_xid                                            38       -     -38
------------------------------------------------------------------------------
(add/remove: 0/2 grow/shrink: 1/2 up/down: 12/-42)            Total: -30 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: merge clientpacket.c into dhcpc.c
Denys Vlasenko [Mon, 22 Mar 2010 12:43:12 +0000 (13:43 +0100)]
udhcp: merge clientpacket.c into dhcpc.c

function                                             old     new   delta
udhcpc_main                                         2569    2855    +286
perform_release                                      122     124      +2
client_background                                     31      32      +1
init_packet                                          156      88     -68
send_decline                                         114       -    -114
send_discover                                        121       -    -121
send_select                                          130       -    -130
------------------------------------------------------------------------------
(add/remove: 0/4 grow/shrink: 3/1 up/down: 289/-433)         Total: -144 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcpc: merge clientsocket.c into dhcpc.c. +4 bytes.
Denys Vlasenko [Mon, 22 Mar 2010 12:42:13 +0000 (13:42 +0100)]
udhcpc: merge clientsocket.c into dhcpc.c. +4 bytes.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoflock: should not be selected by default
Denys Vlasenko [Sun, 21 Mar 2010 18:12:03 +0000 (19:12 +0100)]
flock: should not be selected by default

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotouch: do not ignore argument of -d/-t option
Mikhail Gusarov [Sun, 21 Mar 2010 08:22:47 +0000 (14:22 +0600)]
touch: do not ignore argument of -d/-t option

Previously -d/-t was no-op due to wrong handling of args passed to
utimes(2).

Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodhcpd: apparently, sometimes IP is in ciaddr, not requested_ip...
Denys Vlasenko [Sun, 21 Mar 2010 05:46:09 +0000 (06:46 +0100)]
dhcpd: apparently, sometimes IP is in ciaddr, not requested_ip...

also revert the part which appempted to "fix" that in client

function                                             old     new   delta
udhcpd_main                                         1949    1964     +15
send_renew                                           142     105     -37
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 15/-37)            Total: -22 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcpd: untangle incredibly messy handling of DHCPREQUEST
Denys Vlasenko [Sun, 21 Mar 2010 05:15:28 +0000 (06:15 +0100)]
udhcpd: untangle incredibly messy handling of DHCPREQUEST

Also fixes attacks possible via DHCPDECLINE / DHCPRELEASE

function                                             old     new   delta
udhcpd_main                                         1846    1949    +103
send_renew                                           105     142     +37
send_NAK                                              61       -     -61
send_ACK                                             180       -    -180
------------------------------------------------------------------------------
(add/remove: 0/2 grow/shrink: 2/0 up/down: 140/-241)         Total: -101 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: tweak udhcpd.conf example and comments. no code changes
Denys Vlasenko [Sun, 21 Mar 2010 01:22:07 +0000 (02:22 +0100)]
udhcp: tweak udhcpd.conf example and comments. no code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: code shrink; disable time and log server options
Denys Vlasenko [Sat, 20 Mar 2010 23:43:11 +0000 (00:43 +0100)]
udhcp: code shrink; disable time and log server options

function                                             old     new   delta
add_server_options                                     -     100    +100
udhcp_add_simple_option                               92      90      -2
nobody_responds_to_arp                                88      85      -3
dhcp_options                                          66      62      -4
udhcp_add_option_string                              104      94     -10
udhcp_run_script                                     665     654     -11
dhcp_option_strings                                  203     188     -15
static.blank_chaddr                                   16       -     -16
send_ACK                                             211     180     -31
add_bootp_options                                     61       -     -61
udhcpd_main                                         1925    1846     -79
------------------------------------------------------------------------------
(add/remove: 1/2 grow/shrink: 0/8 up/down: 100/-232)         Total: -132 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcpc: make it possible to disable vendor id; improve help text
Denys Vlasenko [Sat, 20 Mar 2010 17:06:23 +0000 (18:06 +0100)]
udhcpc: make it possible to disable vendor id; improve help text

function                                             old     new   delta
init_packet                                          135     139      +4
packed_usage                                       26789   26786      -3
alloc_dhcp_option                                     67      63      -4
udhcpc_main                                         2467    2447     -20
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/3 up/down: 4/-27)             Total: -23 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcpd: remove five more options which do not make sense or not supported
Denys Vlasenko [Sat, 20 Mar 2010 06:12:21 +0000 (07:12 +0100)]
udhcpd: remove five more options which do not make sense or not supported

requestip, vendorclass, clientid are client-side variables,
          they do not make sense as udhcpd opts
dhcptype  is the packet type (not interesting, it's always 5)
userclass needs parser support in order to work

function                                             old     new   delta
dhcp_options                                          68      66      -2
read_opt                                             865     859      -6
dhcp_option_strings                                  253     203     -50
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-58)             Total: -58 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcpd: remove redundant code in send_offer()
Denys Vlasenko [Sat, 20 Mar 2010 02:49:27 +0000 (03:49 +0100)]
udhcpd: remove redundant code in send_offer()

static_lease_nip and lease pointer are canculated in the caller,
no need to calculate them again. lease_time_sec calculation
is also redundant: it is assigned to later, w/o being used
in between.

function                                             old     new   delta
udhcpd_main                                         1956    1925     -31

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: move serverpacket.c into dhcpd.c, no other changes
Denys Vlasenko [Sat, 20 Mar 2010 02:48:11 +0000 (03:48 +0100)]
udhcp: move serverpacket.c into dhcpd.c, no other changes

function                                             old     new   delta
udhcpd_main                                         1480    1956    +476
send_inform                                           83       -     -83
send_offer                                           376       -    -376
------------------------------------------------------------------------------
(add/remove: 0/3 grow/shrink: 1/0 up/down: 476/-459)           Total: 17 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoflock: better help text
Denys Vlasenko [Fri, 19 Mar 2010 23:07:11 +0000 (00:07 +0100)]
flock: better help text

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcp: remove support for some really old and odd options
Denys Vlasenko [Fri, 19 Mar 2010 22:42:23 +0000 (23:42 +0100)]
udhcp: remove support for some really old and odd options

function                                             old     new   delta
dhcp_options                                          72      68      -4
dhcp_option_strings                                  271     253     -18

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotar: optional support for restoring selinux context
J. Tang [Fri, 19 Mar 2010 13:48:51 +0000 (14:48 +0100)]
tar: optional support for restoring selinux context

function                                             old     new   delta
get_header_tar                                      1690    1976    +286
data_extract_all                                     821     881     +60
.rodata                                           151446  151503     +57
get_header_cpio                                     1044    1077     +33
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/0 up/down: 436/0)             Total: 436 bytes

Signed-off-by: J. Tang <tang@jtang.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibbb/copyfd.c: don't mmap a largish buffer if we only want to copy a few kb
Denys Vlasenko [Fri, 19 Mar 2010 13:34:30 +0000 (14:34 +0100)]
libbb/copyfd.c: don't mmap a largish buffer if we only want to copy a few kb

function                                             old     new   delta
bb_full_fd_action                                    283     295     +12

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoflock: new applet
Timo Teras [Thu, 18 Mar 2010 21:45:35 +0000 (22:45 +0100)]
flock: new applet

function                                             old     new   delta
flock_main                                             -     253    +253
packed_usage                                       26466   26498     +32
applet_names                                        2170    2176      +6
applet_main                                         1280    1284      +4
applet_nameofs                                       640     642      +2
applet_install_loc                                   160     161      +1
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 5/0 up/down: 298/0)             Total: 298 bytes

Signed-off-by: Timo Teras <timo.teras@iki.fi>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years ago*: code shrink and better "died from signal" reporting from wait4pid
Denys Vlasenko [Thu, 18 Mar 2010 21:44:00 +0000 (22:44 +0100)]
*: code shrink and better "died from signal" reporting from wait4pid

function                                             old     new   delta
parse                                                964     967      +3
udhcp_run_script                                     670     665      -5
singlemount                                          911     906      -5
mount_it_now                                         360     355      -5
inotifyd_main                                        521     516      -5
xspawn                                                21       -     -21
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 1/4 up/down: 3/-41)             Total: -38 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolineedit: first shot at optional unicode bidi input support
Tomas Heinrich [Thu, 18 Mar 2010 17:35:37 +0000 (18:35 +0100)]
lineedit: first shot at optional unicode bidi input support

function                                             old     new   delta
read_line_input                                     4886    5003    +117
in_uint16_table                                        -      97     +97
in_interval_table                                      -      78     +78
static.rtl_b                                           -      68     +68
unicode_isrtl                                          -      55     +55
isrtl_str                                              -      51     +51
static.rtl_p                                           -      42     +42
unicode_conv_to_printable2                           633     477    -156
------------------------------------------------------------------------------
(add/remove: 6/0 grow/shrink: 1/1 up/down: 508/-156)          Total: 352 bytes

Signed-off-by: Tomas Heinrich <heinrich.tomas@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibbb/loop: comment out u32 hack
Denys Vlasenko [Thu, 18 Mar 2010 13:38:21 +0000 (14:38 +0100)]
libbb/loop: comment out u32 hack

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agobrctl: Fix comment
Bernhard Reutner-Fischer [Wed, 17 Mar 2010 10:23:04 +0000 (11:23 +0100)]
brctl: Fix comment

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
14 years agobrctl: fix parsing of timespec to allow 0 (setfd, sethello..)
Maciek Borzecki [Tue, 16 Mar 2010 11:41:29 +0000 (12:41 +0100)]
brctl: fix parsing of timespec to allow 0 (setfd, sethello..)

Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomdev: fix a trivial SEGV
Denys Vlasenko [Tue, 16 Mar 2010 17:37:19 +0000 (18:37 +0100)]
mdev: fix a trivial SEGV

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibbb/getopt32.c: clear applet_long_options and opt_complementary after use
Denys Vlasenko [Tue, 16 Mar 2010 16:57:53 +0000 (17:57 +0100)]
libbb/getopt32.c: clear applet_long_options and opt_complementary after use

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoinclude/fix_u32.h: try harder to not cause redefinition errors
Denys Vlasenko [Tue, 16 Mar 2010 00:22:35 +0000 (01:22 +0100)]
include/fix_u32.h: try harder to not cause redefinition errors

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotar compability modes for dpkg
Kim B. Heino [Mon, 8 Mar 2010 07:19:51 +0000 (09:19 +0200)]
tar compability modes for dpkg

I've found couple of deb files which require old tar compability modes
to be unpacked. This patch allows me to enable them for dpkg without
enabling tar.

Signed-off-by: Kim B. Heino <Kim.Heino@bluegiga.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoar: add archive creation support
Alexander Shishkin [Mon, 15 Mar 2010 14:38:09 +0000 (15:38 +0100)]
ar: add archive creation support

function                                             old     new   delta
ar_main                                              184     542    +358
output_ar_header                                       -     166    +166
copy_data                                              -      54     +54
filter_replaceable                                     -      19     +19
get_header_ar                                        409     414      +5
header_verbose_list_ar                                85      88      +3
static.msg_unsupported_err                            28       -     -28
------------------------------------------------------------------------------
(add/remove: 3/1 grow/shrink: 3/0 up/down: 605/-28)           Total: 577 bytes

Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agofbsplash: reinstate drawing of over/undersized images; shrink
Denys Vlasenko [Sun, 14 Mar 2010 22:59:54 +0000 (23:59 +0100)]
fbsplash: reinstate drawing of over/undersized images; shrink

Based on the patch by Nuno Lucas <ntlucas@gmail.com>

function                                             old     new   delta
fbsplash_main                                        938     864     -74

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agobeep: the -d option takes milliseconds not microseconds
Natanael Copa [Sun, 14 Mar 2010 14:32:49 +0000 (15:32 +0100)]
beep: the -d option takes milliseconds not microseconds

Signed-off-by: Natanael Copa <natanael.copa@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotestsuite: don't run grep NUL tests when we know the would fail
Denys Vlasenko [Sat, 13 Mar 2010 23:51:56 +0000 (00:51 +0100)]
testsuite: don't run grep NUL tests when we know the would fail

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: fix quadratic matching slowdown is ${v/*foo*/repl} (really bad one)
Denys Vlasenko [Sat, 13 Mar 2010 15:19:04 +0000 (16:19 +0100)]
ash: fix quadratic matching slowdown is ${v/*foo*/repl} (really bad one)

It is especially bad with patterns starting with "*".

With ASH_OPTIMIZE_FOR_SIZE=y, only those are optimized, +few bytes:
   text    data     bss     dec     hex filename
 836337     441    7564  844342   ce236 busybox_old
 836341     441    7564  844346   ce23a busybox_unstripped

With ASH_OPTIMIZE_FOR_SIZE off, we also optimize patterns _ending_ with "*",
which costs about 80 bytes:
   text    data     bss     dec     hex filename
 836656     441    7564  844661   ce375 busybox_old
 836732     441    7564  844737   ce3c1 busybox_unstripped

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotailk: fix error detected by testsuite
Denys Vlasenko [Fri, 12 Mar 2010 21:16:25 +0000 (22:16 +0100)]
tailk: fix error detected by testsuite

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: code shrink
Denys Vlasenko [Fri, 12 Mar 2010 20:32:13 +0000 (21:32 +0100)]
awk: code shrink

function                                             old     new   delta
evaluate                                            3550    3487     -63

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: code shrink
Denys Vlasenko [Fri, 12 Mar 2010 20:05:09 +0000 (21:05 +0100)]
awk: code shrink

function                                             old     new   delta
hash_find                                            233     234      +1
evaluate                                            3899    3550    -349

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: style fixes
Denys Vlasenko [Fri, 12 Mar 2010 20:04:47 +0000 (21:04 +0100)]
awk: style fixes

function                                             old     new   delta
hash_find                                            234     233      -1
awk_printf                                           457     453      -4

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: code shrink
Denys Vlasenko [Fri, 12 Mar 2010 15:57:06 +0000 (16:57 +0100)]
awk: code shrink

function                                             old     new   delta
exec_builtin                                        1538    1489     -49

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolineedit: fix another corner case with bad unicode input
Denys Vlasenko [Thu, 11 Mar 2010 20:17:55 +0000 (21:17 +0100)]
lineedit: fix another corner case with bad unicode input

function                                             old     new   delta
read_key                                             607     646     +39
readit                                                50      55      +5
getch_nowait                                         290     295      +5
hash_find                                            233     234      +1
xstrtoul_range_sfx                                   231     230      -1
passwd_main                                         1058    1056      -2
builtin_exit                                          45      43      -2
cmp_main                                             649     645      -4
lineedit_read_key                                    257     245     -12
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/5 up/down: 50/-21)             Total: 29 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: code shrink
Denys Vlasenko [Thu, 11 Mar 2010 11:44:25 +0000 (12:44 +0100)]
awk: code shrink

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: code shrink; style fixes
Denys Vlasenko [Thu, 11 Mar 2010 11:41:55 +0000 (12:41 +0100)]
awk: code shrink; style fixes

function                                             old     new   delta
next_token                                           932     862     -70

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: be more paranoid when freeing loop variable; make code less obfuscated
Denys Vlasenko [Thu, 11 Mar 2010 11:13:18 +0000 (12:13 +0100)]
awk: be more paranoid when freeing loop variable; make code less obfuscated

function                                             old     new   delta
nvfree                                               149     170     +21
next_token                                           928     932      +4
getvar_i                                              95      94      -1
skip_spaces                                           51      45      -6
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/2 up/down: 25/-7)              Total: 18 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: add two tests we currently fail
Denys Vlasenko [Thu, 11 Mar 2010 07:27:53 +0000 (08:27 +0100)]
awk: add two tests we currently fail

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: simple code shrink
Denys Vlasenko [Wed, 10 Mar 2010 18:21:54 +0000 (19:21 +0100)]
awk: simple code shrink

function                                             old     new   delta
awk_getline                                          710     724     +14
awk_printf                                           455     457      +2
hash_find                                            234     233      -1
qrealloc                                              33      31      -2
handle_special                                       499     482     -17
awk_sub                                              641     601     -40
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/4 up/down: 16/-60)            Total: -44 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoawk: fix the case where nested "for" loops with the same variable misbehave
Denys Vlasenko [Wed, 10 Mar 2010 18:20:32 +0000 (19:20 +0100)]
awk: fix the case where nested "for" loops with the same variable misbehave

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agopopmaildir: give examples in help text. +91 byte
Denys Vlasenko [Wed, 10 Mar 2010 12:01:14 +0000 (13:01 +0100)]
popmaildir: give examples in help text. +91 byte

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>