oweals/busybox.git
18 years agotar: add support for FEATURE_TAR_GNU_EXTENSIONS so than we can save
Denis Vlasenko [Sat, 25 Nov 2006 23:56:50 +0000 (23:56 -0000)]
tar: add support for FEATURE_TAR_GNU_EXTENSIONS so than we can save
long names now. We were able to read such tars, but not create.
+275 bytes. Without FEATURE_TAR_GNU_EXTENSIONS: -25 bytes.

We still cannot unpack Linux kernels, but not for long ;)

18 years agotee: fix bug: argv[-1] is a no-no!
Denis Vlasenko [Sat, 25 Nov 2006 23:50:28 +0000 (23:50 -0000)]
tee: fix bug: argv[-1] is a no-no!
bb_full_fd_action: optimize
die_if_ferror: "<applet>: filename" isn't a good err msg, add "..I/O error"

18 years agotar: small fix and small optimization
Denis Vlasenko [Sat, 25 Nov 2006 23:47:32 +0000 (23:47 -0000)]
tar: small fix and small optimization

18 years agosmall improvements in str -> num convertors
Denis Vlasenko [Sat, 25 Nov 2006 14:49:04 +0000 (14:49 -0000)]
small improvements in str -> num convertors

18 years agotar: abort if tarring up file larger that 64Gb
Denis Vlasenko [Sat, 25 Nov 2006 14:48:09 +0000 (14:48 -0000)]
tar: abort if tarring up file larger that 64Gb
(otherwise we will produce garbled tarfile)

18 years agodd: support >2gb values for seek, skip, count
Denis Vlasenko [Sat, 25 Nov 2006 14:46:21 +0000 (14:46 -0000)]
dd: support >2gb values for seek, skip, count

18 years agoregularize str -> num convertors
Denis Vlasenko [Sat, 25 Nov 2006 14:44:13 +0000 (14:44 -0000)]
regularize str -> num convertors

18 years agosmall optimization
Denis Vlasenko [Fri, 24 Nov 2006 22:42:44 +0000 (22:42 -0000)]
small optimization

18 years agotar: fix multiple -t and/or -v options handling.
Denis Vlasenko [Fri, 24 Nov 2006 21:55:55 +0000 (21:55 -0000)]
tar: fix multiple -t and/or -v options handling.
do not process list of files to tar up in reverse order.

18 years agotar: sanitize option handling
Denis Vlasenko [Fri, 24 Nov 2006 21:54:44 +0000 (21:54 -0000)]
tar: sanitize option handling

18 years agotar: buglet fix
Denis Vlasenko [Fri, 24 Nov 2006 18:53:13 +0000 (18:53 -0000)]
tar: buglet fix

18 years agotar: fix and sanitize handling of long filenames/linknames
Denis Vlasenko [Fri, 24 Nov 2006 17:21:44 +0000 (17:21 -0000)]
tar: fix and sanitize handling of long filenames/linknames
(GNU extensions 'K' and 'L').
We correctly handle them when untarring now, but unfortunately
we still don't use them when tarring! That stupid 100 char limit
is still there!
The biggest problem is that we don't support 'pax' tar format.
Linux kernel tarballs are in this format... shame

18 years agohunt down improper include <>, make mkswap output 4Gb+ friendly
Denis Vlasenko [Fri, 24 Nov 2006 15:38:03 +0000 (15:38 -0000)]
hunt down improper include <>, make mkswap output 4Gb+ friendly

18 years agosvn add makedev.c. Forgot as usual... :(
Denis Vlasenko [Fri, 24 Nov 2006 15:06:28 +0000 (15:06 -0000)]
svn add makedev.c. Forgot as usual... :(

18 years agotar: small fixes:
Denis Vlasenko [Fri, 24 Nov 2006 14:59:45 +0000 (14:59 -0000)]
tar: small fixes:
* size-optimize mapping code
* kill double close

18 years agotar: cache [ug]id->username/groupname mappings. Cuts down amount
Denis Vlasenko [Fri, 24 Nov 2006 14:57:31 +0000 (14:57 -0000)]
tar: cache [ug]id->username/groupname mappings. Cuts down amount
of open/read/close of /etc/passwd and /etc/group
dramatically (we were rereading those for each untarred file!!!)

18 years agotar: cry murder and bail out if file shrinks under us while we tar it up
Denis Vlasenko [Fri, 24 Nov 2006 14:55:23 +0000 (14:55 -0000)]
tar: cry murder and bail out if file shrinks under us while we tar it up

18 years agoglibc makedev() is a large inline. Save 700+ bytes by wrapping it
Denis Vlasenko [Fri, 24 Nov 2006 14:54:27 +0000 (14:54 -0000)]
glibc makedev() is a large inline. Save 700+ bytes by wrapping it
into a function.

18 years agoheader_verbose_list: stop truncating file size in listing
Denis Vlasenko [Fri, 24 Nov 2006 14:53:18 +0000 (14:53 -0000)]
header_verbose_list: stop truncating file size in listing

18 years agotar:
Denis Vlasenko [Fri, 24 Nov 2006 14:51:01 +0000 (14:51 -0000)]
tar:
* unpack: handle tar header fields which are not NUL terminated
* pack: handle 4+GB files correctly
* pack: refuse to store 101+ softlinks (was truncating link
  target name)
* pack: mask mode with 07777

18 years agomd5sum: make -c grok formats like "68b329da9893e34099c7d8ad5cb9c940 *foo".
Denis Vlasenko [Thu, 23 Nov 2006 15:59:12 +0000 (15:59 -0000)]
md5sum: make -c grok formats like "68b329da9893e34099c7d8ad5cb9c940 *foo".
Also eradicate 95 bytes of bloat.

18 years agoifupdown:
Denis Vlasenko [Thu, 23 Nov 2006 15:08:37 +0000 (15:08 -0000)]
ifupdown:
ifconfig said to set iface up before it processes hw %hwaddress%,
which then of course fails. Thus we run two separate ifconfig

18 years agoifupdown: save some 100+ bytes of code in addstr()
Denis Vlasenko [Thu, 23 Nov 2006 15:07:38 +0000 (15:07 -0000)]
ifupdown: save some 100+ bytes of code in addstr()

18 years agowget: -O - still outputs progressbar (to stderr)
Denis Vlasenko [Thu, 23 Nov 2006 13:10:23 +0000 (13:10 -0000)]
wget: -O - still outputs progressbar (to stderr)
Noticed dead code. -100 bytes.

18 years agoadd "wpad" DHCP option. Spotted some optimization opportunities: -80 bytes
Denis Vlasenko [Thu, 23 Nov 2006 12:57:49 +0000 (12:57 -0000)]
add "wpad" DHCP option. Spotted some optimization opportunities: -80 bytes

18 years agointroduce setsockopt_reuseaddr(int fd), setsockopt_broadcast(int fd),
Denis Vlasenko [Wed, 22 Nov 2006 23:22:06 +0000 (23:22 -0000)]
introduce setsockopt_reuseaddr(int fd), setsockopt_broadcast(int fd),
use them where appropriate. 200 bytes saved

18 years ago- add FIXME to brokenness in the installer..
Bernhard Reutner-Fischer [Wed, 22 Nov 2006 18:40:06 +0000 (18:40 -0000)]
- add FIXME to brokenness in the installer..

18 years ago- fix typo
Bernhard Reutner-Fischer [Wed, 22 Nov 2006 18:21:08 +0000 (18:21 -0000)]
- fix typo

18 years agofix double merge
Denis Vlasenko [Wed, 22 Nov 2006 17:42:06 +0000 (17:42 -0000)]
fix double merge

18 years ago- update TODOs
Bernhard Reutner-Fischer [Wed, 22 Nov 2006 16:48:29 +0000 (16:48 -0000)]
- update TODOs

18 years ago- revert r15563 (pull current version of taskset off the busybox_scratch branch)
Bernhard Reutner-Fischer [Wed, 22 Nov 2006 16:39:48 +0000 (16:39 -0000)]
- revert r15563 (pull current version of taskset off the busybox_scratch branch)

18 years agotelnetd: move generic stuff into libbb. It will make it easy
Denis Vlasenko [Wed, 22 Nov 2006 16:10:39 +0000 (16:10 -0000)]
telnetd: move generic stuff into libbb. It will make it easy
to make other server applets IPv6-aware too.

18 years agotelnetd: if FEATURE_IPV6 is on, telnet will NOT work on IPv4
Denis Vlasenko [Wed, 22 Nov 2006 15:57:52 +0000 (15:57 -0000)]
telnetd: if FEATURE_IPV6 is on, telnet will NOT work on IPv4
which is kind of stupid

18 years agotelnetd: we were having telnetd with is ONLY inetd or ONLY standalone.
Denis Vlasenko [Wed, 22 Nov 2006 15:54:52 +0000 (15:54 -0000)]
telnetd: we were having telnetd with is ONLY inetd or ONLY standalone.
What if I need to have both?? This patch introduces
CONFIG_FEATURE_TELNETD_STANDALONE: y - both, n - only inetd.

18 years ago- reinstate "make checkhelp"
Bernhard Reutner-Fischer [Wed, 22 Nov 2006 09:39:48 +0000 (09:39 -0000)]
- reinstate "make checkhelp"

18 years ago#if HAVE_AFINET6 -> #ifdef HAVE_AFINET6
Denis Vlasenko [Wed, 22 Nov 2006 02:12:07 +0000 (02:12 -0000)]
#if HAVE_AFINET6 -> #ifdef HAVE_AFINET6

18 years agohttpd: comment on QUERY_STRING
Denis Vlasenko [Tue, 21 Nov 2006 21:35:14 +0000 (21:35 -0000)]
httpd: comment on QUERY_STRING

18 years agohttpd: add link to docs
Denis Vlasenko [Tue, 21 Nov 2006 21:23:21 +0000 (21:23 -0000)]
httpd: add link to docs

18 years agoxgethostbyname: more readable
Denis Vlasenko [Tue, 21 Nov 2006 20:35:22 +0000 (20:35 -0000)]
xgethostbyname: more readable

18 years agobb_INET_default[] is really just a const "default",
Denis Vlasenko [Tue, 21 Nov 2006 20:34:21 +0000 (20:34 -0000)]
bb_INET_default[] is really just a const "default",
nothing INET-specific

18 years agoifconfig: looks like char host[128] is not really needed.
Denis Vlasenko [Tue, 21 Nov 2006 20:32:38 +0000 (20:32 -0000)]
ifconfig: looks like char host[128] is not really needed.

18 years agowget: yet another contortion for proftpd's PASV response.
Denis Vlasenko [Tue, 21 Nov 2006 19:10:26 +0000 (19:10 -0000)]
wget: yet another contortion for proftpd's PASV response.

18 years ago- add 'ip rule' support. First take..
Bernhard Reutner-Fischer [Tue, 21 Nov 2006 15:36:08 +0000 (15:36 -0000)]
- add 'ip rule' support. First take..
   text    data     bss     dec     hex filename
   2999       0       0    2999     bb7 networking/libiproute/iprule.o

18 years agoifconfig: preparatory patch, no code changes
Denis Vlasenko [Tue, 21 Nov 2006 14:26:37 +0000 (14:26 -0000)]
ifconfig: preparatory patch, no code changes

18 years agoinsmod: set STRVERSIONLEN = 64, convert #ifdef CONFIG to #if ENABLE,
Denis Vlasenko [Tue, 21 Nov 2006 14:12:53 +0000 (14:12 -0000)]
insmod: set STRVERSIONLEN = 64, convert #ifdef CONFIG to #if ENABLE,
stop using CONFIG_ prefix for non-config-system variables

18 years agoinsmod_ng_main: -80 bytes. Stopp mmapping, use xmalloc_open_read_close().
Denis Vlasenko [Tue, 21 Nov 2006 11:58:14 +0000 (11:58 -0000)]
insmod_ng_main: -80 bytes. Stopp mmapping, use xmalloc_open_read_close().

18 years ago- style fixes
Bernhard Reutner-Fischer [Tue, 21 Nov 2006 11:23:11 +0000 (11:23 -0000)]
- style fixes

18 years agowget: add TODO
Denis Vlasenko [Tue, 21 Nov 2006 11:15:58 +0000 (11:15 -0000)]
wget: add TODO

18 years agowget: fix ftp PASV mode ("numeric" check was too strict)
Denis Vlasenko [Tue, 21 Nov 2006 11:04:31 +0000 (11:04 -0000)]
wget: fix ftp PASV mode ("numeric" check was too strict)

18 years ago- update defconfig
Bernhard Reutner-Fischer [Tue, 21 Nov 2006 10:53:05 +0000 (10:53 -0000)]
- update defconfig

18 years agowget: reduce likelihood of ETA overflow (especially with !LFS)
Denis Vlasenko [Tue, 21 Nov 2006 10:43:02 +0000 (10:43 -0000)]
wget: reduce likelihood of ETA overflow (especially with !LFS)

18 years agohttpd: slight reduction of #ifdef forest
Denis Vlasenko [Tue, 21 Nov 2006 10:15:25 +0000 (10:15 -0000)]
httpd: slight reduction of #ifdef forest
few other applets: #ifdef CONFIG_ -> #if ENABLE_
traceroute: fix exposed bugs
defconfig: update

18 years agocpio: (allegedly) fix bug 0001095:
Denis Vlasenko [Tue, 21 Nov 2006 00:55:46 +0000 (00:55 -0000)]
cpio: (allegedly) fix bug 0001095:
"cpio hardlink support and possible memory leak fix"

18 years agohttpd: fix cgi-bin/index.cgi support, add example of it,
Denis Vlasenko [Tue, 21 Nov 2006 00:12:09 +0000 (00:12 -0000)]
httpd: fix cgi-bin/index.cgi support, add example of it,
stat: fix end-of-line if format is specified (wasn't printing it),
      fix %z (time) format to match coreutils 6.3

18 years agohttpd: LC_TIME locale _must_ be POSIX to httpd! We speak over the net!
Denis Vlasenko [Tue, 21 Nov 2006 00:09:37 +0000 (00:09 -0000)]
httpd: LC_TIME locale _must_ be POSIX to httpd! We speak over the net!

18 years agohttpd: add support for directory indexer (cgi-bin/index.cgi)
Denis Vlasenko [Tue, 21 Nov 2006 00:08:39 +0000 (00:08 -0000)]
httpd: add support for directory indexer (cgi-bin/index.cgi)

18 years agohttpd: get rid of big, useless blocks (deindent,
Denis Vlasenko [Tue, 21 Nov 2006 00:07:31 +0000 (00:07 -0000)]
httpd: get rid of big, useless blocks (deindent,
bring code under 80 columns)

18 years agohttpd: More robust Content-length: parsing,
Denis Vlasenko [Tue, 21 Nov 2006 00:06:28 +0000 (00:06 -0000)]
httpd: More robust Content-length: parsing,
code reorganization (less indented)

18 years agodhcprelay: new applet
Denis Vlasenko [Mon, 20 Nov 2006 19:40:36 +0000 (19:40 -0000)]
dhcprelay: new applet

18 years agoadd compile-time check for correct DHCP packet size
Denis Vlasenko [Mon, 20 Nov 2006 01:13:09 +0000 (01:13 -0000)]
add compile-time check for correct DHCP packet size

18 years agologin: use %s - we know that string is not too long there
Denis Vlasenko [Mon, 20 Nov 2006 00:48:22 +0000 (00:48 -0000)]
login: use %s - we know that string is not too long there
ping[6]: use getopt32: smaller (-50 bytes) and handles -c6 correctly
(was requiring '-c 6' with mandatory space)

18 years agomount: if FILE* is NULL, it's not wise to use it.
Denis Vlasenko [Sun, 19 Nov 2006 17:34:57 +0000 (17:34 -0000)]
mount: if FILE* is NULL, it's not wise to use it.

18 years agosvlogd: log full lines to stderr too, and also stop using stdio for that
Denis Vlasenko [Sun, 19 Nov 2006 17:33:54 +0000 (17:33 -0000)]
svlogd: log full lines to stderr too, and also stop using stdio for that

18 years agomkdir: style fix
Denis Vlasenko [Sun, 19 Nov 2006 13:53:50 +0000 (13:53 -0000)]
mkdir: style fix

18 years agorodata cleanup. "unable to" == "cannot". -300 bytes
Denis Vlasenko [Sat, 18 Nov 2006 22:04:09 +0000 (22:04 -0000)]
rodata cleanup. "unable to" == "cannot". -300 bytes

18 years agosmall fixes: using fd-based io instead of FILE*-based,
Denis Vlasenko [Sat, 18 Nov 2006 22:03:26 +0000 (22:03 -0000)]
small fixes: using fd-based io instead of FILE*-based,
missed O_TRUNC, etc

18 years agoudhcp: fix indentation and style.
Denis Vlasenko [Sat, 18 Nov 2006 19:51:32 +0000 (19:51 -0000)]
udhcp: fix indentation and style.
Eliminate (group) a lot of smallish *.h files
Remove lots of unneeded #includes

18 years agoAdd names of people historically linked to bbox project
Denis Vlasenko [Sat, 18 Nov 2006 16:30:04 +0000 (16:30 -0000)]
Add names of people historically linked to bbox project

18 years agonc: fix --help text
Denis Vlasenko [Sat, 18 Nov 2006 02:17:37 +0000 (02:17 -0000)]
nc: fix --help text

18 years agoadd -Wundef, fix uncovered bugs
Denis Vlasenko [Fri, 17 Nov 2006 20:29:00 +0000 (20:29 -0000)]
add -Wundef, fix uncovered bugs

18 years agoforgot about avn add... :(
Denis Vlasenko [Fri, 17 Nov 2006 18:58:49 +0000 (18:58 -0000)]
forgot about avn add... :(

18 years agorunit: add runsv, runsvdir and sv. Oh yes.
Denis Vlasenko [Fri, 17 Nov 2006 18:58:16 +0000 (18:58 -0000)]
runit: add runsv, runsvdir and sv. Oh yes.
It even seems to work. +11K. :(

18 years agohttpd: make Bernhard happier
Denis Vlasenko [Fri, 17 Nov 2006 18:26:57 +0000 (18:26 -0000)]
httpd: make Bernhard happier

18 years ago- Set INSTALL_OPTS according to the config.
Bernhard Reutner-Fischer [Fri, 17 Nov 2006 13:54:29 +0000 (13:54 -0000)]
- Set INSTALL_OPTS according to the config.

18 years ago- fix generation of the busybox.links install script inputfile
Bernhard Reutner-Fischer [Fri, 17 Nov 2006 13:17:04 +0000 (13:17 -0000)]
- fix generation of the busybox.links install script inputfile

18 years ago- typo fix
Bernhard Reutner-Fischer [Fri, 17 Nov 2006 12:47:50 +0000 (12:47 -0000)]
- typo fix

18 years ago- end may be used uninitialized.
Bernhard Reutner-Fischer [Fri, 17 Nov 2006 11:28:00 +0000 (11:28 -0000)]
- end may be used uninitialized.
- TODO: should eventually use skip_whitespace there

18 years agohttpd: reduce ifdef forest. comment out redundant PATH setting
Denis Vlasenko [Thu, 16 Nov 2006 18:04:43 +0000 (18:04 -0000)]
httpd: reduce ifdef forest. comment out redundant PATH setting

18 years agohttpd:
Denis Vlasenko [Thu, 16 Nov 2006 16:20:12 +0000 (16:20 -0000)]
httpd:
fix union aliasing bug
symptom: wget of non-existent file gets redirected to /text/html/something
on second and subsequend wget attempts
fix double-free bug
symptom: glibc caught double-free (we didn't NULL config->xxx ptrs after free)

18 years agohttpd: add -i (inetd) and -f (foreground) otions.
Denis Vlasenko [Thu, 16 Nov 2006 16:17:02 +0000 (16:17 -0000)]
httpd: add -i (inetd) and -f (foreground) otions.
-i makes possible to run httpd in both inetd and standalone mode
without recompile (or need to have two different binaries)

18 years agohttpd: stop being silly with setenv
Denis Vlasenko [Thu, 16 Nov 2006 16:12:09 +0000 (16:12 -0000)]
httpd: stop being silly with setenv

18 years agosvlogd: new applet. +9k. Still too big, but it was 12k yesterday.
Denis Vlasenko [Thu, 16 Nov 2006 02:27:24 +0000 (02:27 -0000)]
svlogd: new applet. +9k. Still too big, but it was 12k yesterday.

18 years agoremove duplicate flag decls
Mike Frysinger [Wed, 15 Nov 2006 21:52:10 +0000 (21:52 -0000)]
remove duplicate flag decls

18 years agoumount: umount -a shouldn't stop on first failure
Denis Vlasenko [Sun, 12 Nov 2006 17:23:45 +0000 (17:23 -0000)]
umount: umount -a shouldn't stop on first failure

18 years agohttpd: cosmetic fixes (the bug which was being hunted down
Denis Vlasenko [Fri, 10 Nov 2006 23:28:57 +0000 (23:28 -0000)]
httpd: cosmetic fixes (the bug which was being hunted down
turned out to be nonexistent :)

18 years agowget: fix error message.
Denis Vlasenko [Fri, 10 Nov 2006 23:25:53 +0000 (23:25 -0000)]
wget: fix error message.
Bad:
wget http://127.0.0.1:81/fgdg/Makefile
Connecting to 127.0.0.1[127.0.0.1]:81
: HTTP/1.0 404 Not Foundror 404 Not Found
Good:
wget http://127.0.0.1:81/fgdg/Makefile
Connecting to 127.0.0.1[127.0.0.1]:81
get: server returned error: HTTP/1.0 404 Not Found

nslookup: fix my mistake
applets: make Bernhard Fischer <rep.nop@aon.at> happy :)

18 years agoadd && !defined(__UCLIBC__) to static link warning check
Denis Vlasenko [Thu, 9 Nov 2006 00:00:12 +0000 (00:00 -0000)]
add && !defined(__UCLIBC__) to static link warning check

18 years agosmall ipv6 doc changes; nslookup a tiny bit smaller
Denis Vlasenko [Tue, 7 Nov 2006 19:05:43 +0000 (19:05 -0000)]
small ipv6 doc changes; nslookup a tiny bit smaller

18 years agogetty: remove ancient termio support (was using termois anyway)
Denis Vlasenko [Tue, 7 Nov 2006 01:52:10 +0000 (01:52 -0000)]
getty: remove ancient termio support (was using termois anyway)

18 years agohttpd: sendCgi() forked child needs to close opened
Denis Vlasenko [Sun, 5 Nov 2006 19:47:33 +0000 (19:47 -0000)]
httpd: sendCgi() forked child needs to close opened
server socket and accepted socket

18 years agorename: compare_string_array -> index_in_str_array
Denis Vlasenko [Sun, 5 Nov 2006 18:05:09 +0000 (18:05 -0000)]
rename: compare_string_array -> index_in_str_array
introduce index_in_substr_array and use it in
iproute2

18 years agops: add documentation on POSIX ps
Denis Vlasenko [Sun, 5 Nov 2006 00:47:38 +0000 (00:47 -0000)]
ps: add documentation on POSIX ps

18 years agousage.h: stop using ancient USAGE_xxx (we have USE_xx now)
Denis Vlasenko [Sun, 5 Nov 2006 00:46:35 +0000 (00:46 -0000)]
usage.h: stop using ancient USAGE_xxx (we have USE_xx now)

18 years agops: implement POSIX-like options, most notably -o
Denis Vlasenko [Sun, 5 Nov 2006 00:45:47 +0000 (00:45 -0000)]
ps: implement POSIX-like options, most notably -o
(activated by CONFIG_DESKTOP)

18 years agosmart_ulltoa5: make available in libbb
Denis Vlasenko [Sun, 5 Nov 2006 00:44:39 +0000 (00:44 -0000)]
smart_ulltoa5: make available in libbb

18 years agoreplace /proc scanning code by more versatile one.
Denis Vlasenko [Sun, 5 Nov 2006 00:43:51 +0000 (00:43 -0000)]
replace /proc scanning code by more versatile one.
Use it where appropriate.
Stop scanning /etc/passwd *for every process*!!! (uid->username)
top: reduce memory usage - we won't save unneeded fields
from /proc info anymore. Downside: ~+250 bytes of code

18 years agotop: improve CPU% calculation
Denis Vlasenko [Sun, 5 Nov 2006 00:38:51 +0000 (00:38 -0000)]
top: improve CPU% calculation
style fixes

18 years agoFix kbuild bugs noticed by Bernhard Fischer <rep.nop@aon.at>
Denis Vlasenko [Thu, 2 Nov 2006 22:09:37 +0000 (22:09 -0000)]
Fix kbuild bugs noticed by Bernhard Fischer <rep.nop@aon.at>

18 years agoUnneeded code removed, usused field "unsigned pscpu" removed
Denis Vlasenko [Wed, 1 Nov 2006 20:20:37 +0000 (20:20 -0000)]
Unneeded code removed, usused field "unsigned pscpu" removed

18 years agomostly style fixes
Denis Vlasenko [Wed, 1 Nov 2006 10:25:35 +0000 (10:25 -0000)]
mostly style fixes