Mike Frysinger [Thu, 14 Apr 2005 02:49:22 +0000 (02:49 -0000)]
add aliases == and [[ for = and [ to support more bash scripts
Peter Kjellerstedt [Wed, 6 Apr 2005 10:56:57 +0000 (10:56 -0000)]
Removed the incorrect and confusing facility argument specified with
openlog() as the correct facility will be specified with syslog()
anyway.
Eric Andersen [Thu, 31 Mar 2005 18:15:42 +0000 (18:15 -0000)]
Point to osuosl
Peter Kjellerstedt [Wed, 30 Mar 2005 16:36:40 +0000 (16:36 -0000)]
Corrected the list of section names in add_ksymoops_symbols() so
that the bss and sbss sections can be correctly identified.
Mike Frysinger [Wed, 30 Mar 2005 06:29:41 +0000 (06:29 -0000)]
amd64 is rela, not rel
Mike Frysinger [Fri, 4 Mar 2005 01:34:23 +0000 (01:34 -0000)]
Shaun Jackman writes: Fix typo. Use __NR_umount2 instead of __NR_pivot_root.
Mike Frysinger [Fri, 4 Mar 2005 01:33:17 +0000 (01:33 -0000)]
Shaun Jackman writes: Newlib uses both __getopt_initialized and optind to track initialization of getopt()
Mike Frysinger [Fri, 4 Mar 2005 01:27:18 +0000 (01:27 -0000)]
add some more comments
Mike Frysinger [Fri, 4 Mar 2005 01:10:56 +0000 (01:10 -0000)]
newlib fixe from Shaun Jackman
Mike Frysinger [Fri, 4 Mar 2005 01:09:43 +0000 (01:09 -0000)]
newlib fixe from Shaun Jackman
Manuel Novoa III [Wed, 2 Mar 2005 04:10:46 +0000 (04:10 -0000)]
Bandaid to make "gzip file1 file2 ..." set the decompression lengths correctly
in the 2nd and later headers. But this and gunzip really need to be rewritten.
Manuel Novoa III [Tue, 1 Mar 2005 19:29:29 +0000 (19:29 -0000)]
When filling the bit buffer, gzip decompression apparently never checked for end of file, causing it to hang on corrupted input.
Eric Andersen [Mon, 21 Feb 2005 22:04:21 +0000 (22:04 -0000)]
Update buildroot pointers
Eric Andersen [Sun, 13 Feb 2005 22:20:35 +0000 (22:20 -0000)]
remove whitespace
Eric Andersen [Sun, 13 Feb 2005 22:17:44 +0000 (22:17 -0000)]
remove whitespace
Eric Andersen [Sun, 13 Feb 2005 22:15:59 +0000 (22:15 -0000)]
Remove whitespace
Manuel Novoa III [Sun, 13 Feb 2005 20:14:05 +0000 (20:14 -0000)]
Add 'nice' and replace 'renice' with a new implementation.
Eric Andersen [Fri, 11 Feb 2005 19:06:51 +0000 (19:06 -0000)]
Takeharu KATO writes:
Hi,
I found that gcc in cvs (HEAD in 2005/02/11) reject the gzip source
in the busybox.
This is caused by changing gcc's error handling behavior(
The gcc check the function prototype more strictly).
I show the compilation log as follow:
-- compilation log
-- compilation log
To fix the problem, apply the patch which is attached with this
mail.
Please take a look the patch and apply the patch into svn repository.
Ned Ludd [Thu, 10 Feb 2005 00:44:31 +0000 (00:44 -0000)]
- no need to check if JOBS is defined. Config.in ensures it.
Ned Ludd [Wed, 9 Feb 2005 21:07:23 +0000 (21:07 -0000)]
- add ash read -t timeout support. initial code provided by Tim Yamin on Oct/21/2004 on the busybox mailing list. Edited his code a little to keep syntax highlighers happy and make it optional when CONFIG_ASH_TIMEOUT is defined
Eric Andersen [Wed, 9 Feb 2005 18:25:10 +0000 (18:25 -0000)]
fix typo
Eric Andersen [Wed, 9 Feb 2005 06:44:36 +0000 (06:44 -0000)]
update
Eric Andersen [Wed, 9 Feb 2005 06:41:13 +0000 (06:41 -0000)]
Cut-n-paste strikes again
Eric Andersen [Wed, 9 Feb 2005 03:52:46 +0000 (03:52 -0000)]
Remove mention of CVS and instead point to Subversion
Eric Andersen [Mon, 31 Jan 2005 13:05:02 +0000 (13:05 -0000)]
Update the bug submission stuff to point to bugs.busybox.net
Rob Landley [Mon, 24 Jan 2005 07:03:37 +0000 (07:03 -0000)]
Add me as sort maintainer.
Rob Landley [Mon, 24 Jan 2005 07:00:02 +0000 (07:00 -0000)]
Sort rewrite to be SUSv3 compliant. New config option, updated help, and
a couple of infrastructure bits.
Rob Landley [Mon, 24 Jan 2005 06:56:24 +0000 (06:56 -0000)]
Much bigger to-do list.
Eric Andersen [Fri, 14 Jan 2005 17:08:13 +0000 (17:08 -0000)]
fix spelling
Eric Andersen [Thu, 13 Jan 2005 17:23:28 +0000 (17:23 -0000)]
minor doc cleanup
Eric Andersen [Thu, 13 Jan 2005 17:15:34 +0000 (17:15 -0000)]
Mention the new bug tracking system
Mike Frysinger [Fri, 7 Jan 2005 00:56:47 +0000 (00:56 -0000)]
cp: make -P a synonym for -d
Eric Andersen [Tue, 4 Jan 2005 20:37:55 +0000 (20:37 -0000)]
Dear andersen:
Is the change on libbb/loop.c which you commited in 2005/1/3 effective
really?
The __GLIBC__ macro and __UCLIBC__ macro are defined in
feature.h in glibc source, so the change may not be effective.
If you want to check this with __GLIBC__, feature.h header is needed.
Some architectures(e.g. PPC series) need to include linux/posix_types.h
in stead of asm/posix_types.h, so the patch which is attached with
this mail include <linux/posix_types.h>.
Eric Andersen [Mon, 3 Jan 2005 05:50:01 +0000 (05:50 -0000)]
perhaps a better fix
Mike Frysinger [Sun, 26 Dec 2004 09:13:32 +0000 (09:13 -0000)]
alpha/parisc support
Eric Andersen [Mon, 20 Dec 2004 18:10:03 +0000 (18:10 -0000)]
fix typo
Rob Landley [Fri, 17 Dec 2004 05:23:36 +0000 (05:23 -0000)]
Minor in-passing crapectomy.
Rob Landley [Thu, 9 Dec 2004 23:12:00 +0000 (23:12 -0000)]
Workaround for uClibc-specific header problem described here:
http://www.busybox.net/lists/busybox/2004-December/013276.html
Rob
Ned Ludd [Wed, 8 Dec 2004 16:47:28 +0000 (16:47 -0000)]
- CONFIG_FEATURE_READLINK_FOLLOW readlink -f patch from Colin Watson <cjwatson@debian.org> on busybox mailing list 08/11/04
Mike Frysinger [Mon, 6 Dec 2004 14:59:45 +0000 (14:59 -0000)]
merge from udhcp module
Rob Landley [Thu, 25 Nov 2004 07:21:47 +0000 (07:21 -0000)]
Hiroshi found another bug. Currently sed's $ triggers at end of every file,
and with multiple files SuSv3 says it should only trigger at the end of the
LAST file.
The trivial fix I tried first broke if the last file is empty. Fixing this
properly required restructuring things to create a file list (actually a
FILE * list), and then processing it all in one go. (There's probably a
smaller way to do this, merging with append_list perhaps. But let's get
the behavior correct first.)
Note that editing files in place (-i) needs the _old_ behavior, with $
triggering at the end of each file.
Here's a test of all the things this patch fixed. gnu and busybox seds produce
the same results with this patch, and different without it.
echo -n -e "1one\n1two\n1three" > ../test1
echo -n > ../test2
echo -e "3one\n3two\n3three" > ../test3
sed -n "$ p" ../test1 ../test2 ../test3
sed -n "$ p" ../test1 ../test2
sed -i -n "$ p" ../test1 ../test2 ../test3
Rob Landley [Tue, 16 Nov 2004 12:07:04 +0000 (12:07 -0000)]
Don't document compiler warnings. _FIX_ compiler warnings.
Peter Kjellerstedt [Tue, 2 Nov 2004 09:05:22 +0000 (09:05 -0000)]
Correct the install-hardlinks target the same way as was already done
for the install target.
Rob Landley [Sat, 30 Oct 2004 07:04:10 +0000 (07:04 -0000)]
Alright, I guess I should be in this too...
Rob Landley [Sat, 30 Oct 2004 06:54:19 +0000 (06:54 -0000)]
Hiroshi Ito found some bugs. The 'c' command (cut and paste) was hardwired
to not put a newline at the end (which was backwards, it should have been
hardwired _to_ put a newline at the end, whether or not the input line
ended with a newline). Test case for that:
echo | sed -e '$ctest'
And then this would segfault:
echo | sed -e 'g'
Because pattern_space got freed but the dead pointer was only overwritten
in an if statement that didn't trigger if the hold space was empty. Oops.
While debugging it, I found out that the hold space is persistent between
multiple input files, so I promoted it to a global and added it to the
memory cleanup. The relevant test case (to compare with That Other Sed) is:
echo -n woo > woo
sed -e h -e g woo
echo "fish" | sed -e '/woo/h' -e "izap" -e 's/woo/thingy/' -e '/fish/g' woo -
And somebody gratuitously stuck in a c99 int8_t type for something that's just
a flag, so I grouped the darn ints.
Eric Andersen [Wed, 27 Oct 2004 02:39:46 +0000 (02:39 -0000)]
1.00 is stable
Eric Andersen [Mon, 18 Oct 2004 06:31:18 +0000 (06:31 -0000)]
mention scratchbox and openembedded
Eric Andersen [Wed, 13 Oct 2004 17:45:57 +0000 (17:45 -0000)]
egor duda writes:
egor duda wrote:
>Ok, here's an updated patch.
>'make check' should work now, and one make creates Makefile in build
>directory, so one can run 'make' in build directory after that.
ahem. It looks like i'm slightly late with it but... Here's a little
addition to make 'make O=/some/where PREFIX=/some/where/else install'
work. Sorry for delay :(
egor
Eric Andersen [Wed, 13 Oct 2004 09:42:10 +0000 (09:42 -0000)]
prepare for release
Eric Andersen [Wed, 13 Oct 2004 07:25:01 +0000 (07:25 -0000)]
return failure when nslookup fails
Eric Andersen [Wed, 13 Oct 2004 07:18:05 +0000 (07:18 -0000)]
Simon Poole writes:
Erik,
Attached is a patch for the udhcpc sample scripts, to correct the order in
which routers are applied if the DHCP server provides more than one (as per
section 3.5 of RFC2132).
Apologies for not being on the mailing list and thanks for your continued
efforts.
Simon.
Eric Andersen [Wed, 13 Oct 2004 06:25:52 +0000 (06:25 -0000)]
Make certain clients of bb_make_directory default to honoring
the user's umask
Eric Andersen [Mon, 11 Oct 2004 20:52:16 +0000 (20:52 -0000)]
Patch from David Daney:
It seems that date -s MMDDHHMMYYYY.ss
will ignore the .ss part. This patch tries to fix the problem.
David Daney.
Eric Andersen [Fri, 8 Oct 2004 11:11:02 +0000 (11:11 -0000)]
oops
Eric Andersen [Fri, 8 Oct 2004 10:54:20 +0000 (10:54 -0000)]
unmerged fix
Eric Andersen [Fri, 8 Oct 2004 10:52:33 +0000 (10:52 -0000)]
Bump version
Eric Andersen [Fri, 8 Oct 2004 10:52:08 +0000 (10:52 -0000)]
Fix the supported architectures section
Eric Andersen [Fri, 8 Oct 2004 10:50:08 +0000 (10:50 -0000)]
Add an initial FAQ
Eric Andersen [Fri, 8 Oct 2004 09:43:34 +0000 (09:43 -0000)]
Fix CONFIG_ASH_MATH_SUPPORT_64 so it actually works
Eric Andersen [Fri, 8 Oct 2004 08:57:35 +0000 (08:57 -0000)]
Patch from Claus Klein to increase, and make more apparent
the hard coded limit on the number of mounts
Eric Andersen [Fri, 8 Oct 2004 08:49:26 +0000 (08:49 -0000)]
Wade Berrier writes:
Hello,
Here's a patch for a first attempt at static leases for udhcpd.
Included in the tarball are 2 files (static_leases.c, static_leases.h)
and a patch against the latest cvs.
In the config file you can configure static leases with the following
format:
static_lease 00:60:08:11:CE:4E 192.168.0.54
static_lease 00:60:08:11:CE:3E 192.168.0.44
Comments/suggestions/improvements are welcome.
Wade
Eric Andersen [Fri, 8 Oct 2004 08:27:40 +0000 (08:27 -0000)]
Patch from Denis Vlasenko to fix a problem where
wget http://1.2.3.4/abc/ loses last '/'
Eric Andersen [Fri, 8 Oct 2004 08:21:54 +0000 (08:21 -0000)]
Hiroshi Ito writes:
Hello, all.
Busybox init does not handle removed inittab entry correctly.
# I'm sorry about my poor english, but you can find
# what I would like to say from patch, isn't it?
even if you apply this path,
when yoy try to change a command line option in inittab,
you have to do following steps.
1. remove old line from initrd
2. send HUP signal to init
3. kill old proces which is invoked from init.
4. append new line to inittab
5. send HUP signal to init, again
patch is against current CVS + last patch witch I send it last.
Eric Andersen [Fri, 8 Oct 2004 08:17:39 +0000 (08:17 -0000)]
Hiroshi Ito writes:
"kill -HUP 1" reloads inittab, and when I append one line to inittab
and send HUP signal two times, It will starts 2 process.
patch against current CVS is attached.
Eric Andersen [Fri, 8 Oct 2004 08:14:58 +0000 (08:14 -0000)]
Hiroshi Ito writes:
ash
"unset OLDPWD; cd -" causes segmentation fault.
( OLDPWD is not set when sh is invoked from getty. )
patch against current CVS is attached.
Eric Andersen [Fri, 8 Oct 2004 08:10:57 +0000 (08:10 -0000)]
Hiroshi Ito writes:
Hello
I'm using busy box on mipsel machine.
"grep -f file" will cause segmentation fault.
Vladimir N. Oleynik writes:
Hiroshi,
Thank for bug report, but your patch is full broken.
Worked patch attached.
(really changes is zero initialize, and indent correcting).
--w
vodz
Eric Andersen [Fri, 8 Oct 2004 08:07:40 +0000 (08:07 -0000)]
Tito writes:
Hi to all,
This patch contains just some fixes for some misleading
comments in my_getpwuid.c and my_getug.c.
The code is untouched so this patch will not
cause troubles.
Please apply.
Thanks in advance and Ciao,
Tito
Eric Andersen [Fri, 8 Oct 2004 08:03:29 +0000 (08:03 -0000)]
last_patch139.gz from Vladimir N. Oleynik:
>I also don't mean to disagree about leaving 30x status codes until after
>1.0. In fact, although redirecting http://host/dir to http://host/dir/
>with a 301 is common practice (e.g. Apache, IIS), AFAIK it isn't
>actually required (or mentioned) by the HTTP specs.
Ok.
Attached patch have 302 and 408 implemented features.
--w
vodz
Eric Andersen [Fri, 8 Oct 2004 07:58:30 +0000 (07:58 -0000)]
As noticed by egor duda, current_menu is declared as 'extern struct menu
*current_menu;' in scripts/config/lkc.h line 63, and this conflicts with
static definition in mconf.c.
Eric Andersen [Fri, 8 Oct 2004 07:46:08 +0000 (07:46 -0000)]
egor duda writes:
Hi!
I've created a patch to busybox' build system to allow building it in
separate tree in a manner similar to kbuild from kernel version 2.6.
That is, one runs command like
'make O=/build/some/where/for/specific/target/and/options'
and everything is built in this exact directory, provided that it exists.
I understand that applyingc such invasive changes during 'release
candidates' stage of development is at best unwise. So, i'm currently
asking for comments about this patch, starting from whether such thing
is needed at all to whether it coded properly.
'make check' should work now, and one make creates Makefile in build
directory, so one can run 'make' in build directory after that.
One possible caveat is that if we build in some directory other than
source one, the source directory should be 'distclean'ed first.
egor
Eric Andersen [Fri, 8 Oct 2004 07:21:58 +0000 (07:21 -0000)]
Patch from Michael Tokarev:
Scenario:
touch x -- creates plain file name `x'
mkdir x -- exits successefully
libbb/make_directory.c, bb_make_directory(), contains
the following code:
if (mkdir(path, 0777) < 0) {
/* If we failed for any other reason than the directory
* already exists, output a diagnostic and return -1.*/
if (errno != EEXIST) {
fail_msg = "create";
umask(mask);
break;
}
/* Since the directory exists, don't attempt to change
* permissions if it was the full target. Note that
* this is not an error conditon. */
if (!c) {
umask(mask);
return 0;
}
}
The assumption that EEXIST error is due to that the *directory*
already exists is wrong: any file type with that name will cause
this error to be returned. Proper way IMHO will be is to stat()
the path and check whenever this is really a directory. Below
(attached) is a patch to fix this issue.
Eric Andersen [Thu, 7 Oct 2004 00:35:59 +0000 (00:35 -0000)]
Make it more apparent that archive creation is not supported
Glenn L McGrath [Thu, 30 Sep 2004 00:24:21 +0000 (00:24 -0000)]
Patch from William Barsse to fix a segfault when multiple files are specified.
Glenn L McGrath [Fri, 24 Sep 2004 09:24:27 +0000 (09:24 -0000)]
Patch from Dmitry Zakharov to fix a bug triggered by freeswan's scripts.
Glenn L McGrath [Fri, 24 Sep 2004 09:18:55 +0000 (09:18 -0000)]
Patch from Egor Duda
Attached patch prevents modprobe from trying to call 'insmod (null)'
whenever nonexistent module is either passed to modprobe via command
line or mentioned in modules.dep
this replaces cryptic error
sh: Syntax error: word unexpected (expecting ")")
with
modprobe: module some-module not found.
egor.
Glenn L McGrath [Fri, 24 Sep 2004 09:09:44 +0000 (09:09 -0000)]
Fix a typo
Glenn L McGrath [Fri, 24 Sep 2004 02:36:44 +0000 (02:36 -0000)]
Remove this error message at Vodz request, it was misleading.
Glenn L McGrath [Fri, 24 Sep 2004 02:04:13 +0000 (02:04 -0000)]
Patch from David Daney to make the -i option work with -l.
Eric Andersen [Fri, 24 Sep 2004 01:25:39 +0000 (01:25 -0000)]
A bit of extra explanation regarding STANDALONE
Eric Andersen [Thu, 23 Sep 2004 20:08:46 +0000 (20:08 -0000)]
Add some notes on how to make telnetd actually work
Glenn L McGrath [Wed, 15 Sep 2004 03:24:32 +0000 (03:24 -0000)]
Add a missing brace, patch by Hideki IWAMOTO
Glenn L McGrath [Wed, 15 Sep 2004 03:04:08 +0000 (03:04 -0000)]
Tito writes,
"This patch fixes all the bugs in id previously spotted by vodz and me.
The binary size increased a bit, but now it should work as expected."
Glenn L McGrath [Wed, 15 Sep 2004 02:39:09 +0000 (02:39 -0000)]
Only write to shadow file is shadow passwords are enabled. Patch by magicfox modified by myself to retain check for shadow file access.
Glenn L McGrath [Wed, 15 Sep 2004 02:05:23 +0000 (02:05 -0000)]
Patch by Felipe Kellermann, use the common escape handling function and remove some unused code.
Glenn L McGrath [Tue, 14 Sep 2004 19:14:00 +0000 (19:14 -0000)]
remove a cut/paste mistake, i better get some sleep.
Glenn L McGrath [Tue, 14 Sep 2004 18:56:52 +0000 (18:56 -0000)]
Apply patch from Felipe Kellermann to simlify logic of sort functions.
I reversed the result of the sort functions to make the big numbers go to the top.
Glenn L McGrath [Tue, 14 Sep 2004 18:12:13 +0000 (18:12 -0000)]
Patch by Felipe Kellermann, fix a bug introduced in the last patch by adding a condition around the remote logging, also adds some comments.
Glenn L McGrath [Tue, 14 Sep 2004 17:24:59 +0000 (17:24 -0000)]
Patch from Felipe Kellermann, remove some unnecessary dups, i declared a few extra const's also.
Glenn L McGrath [Tue, 14 Sep 2004 16:23:56 +0000 (16:23 -0000)]
Patch from Felipe Kellermann, adds missing applet usage options, removes usage
for options that are currently not implemented and fixes typos.
Glenn L McGrath [Tue, 14 Sep 2004 16:08:02 +0000 (16:08 -0000)]
Patch from tito to add argument checking.
Glenn L McGrath [Tue, 14 Sep 2004 13:59:44 +0000 (13:59 -0000)]
I have to assume both Avaks and LSILogic are deliberatly ignoring me.
Eric Andersen [Wed, 8 Sep 2004 20:13:05 +0000 (20:13 -0000)]
Fixup URL
Eric Andersen [Wed, 8 Sep 2004 10:56:06 +0000 (10:56 -0000)]
Felipe Kellermann writes:
The Togg's sysklogd patch to use sendto() on remote logging is formatting
strangely (using `<' and '>' surrounding the `msg' string message). This
is OK, but this is not the standard way of formatting this message.
So this patch does the following:
o Fix the formatting to the standard way.
o Uses `MAXLINE' when needed;
o Don't loop sending messages without a "sleeping time",
I'm now doing `now = 1', `now <<= 1';
o Don't die on `init_RemoteLog' when starting up (feature!)
We're now trying to connect every time we have an invalid fd;
o Removes one static uneeded variable.
o Removes two automatic uneeded variables.
Eric Andersen [Wed, 8 Sep 2004 10:01:07 +0000 (10:01 -0000)]
Patrick Huesmann noticed BusyBox would not link when
CONFIG_FEATURE_COMMAND_EDITING was defined *and*
CONFIG_FEATURE_COMMAND_TAB_COMPLETION was undefined.
Vladimir N. Oleynik writes:
Its declare always, also if CONFIG_FEATURE_COMMAND_TAB_COMPLETION
undefined.
Patch to CVS version attached.
--w
vodz
Eric Andersen [Thu, 2 Sep 2004 23:13:10 +0000 (23:13 -0000)]
Jonas Holmberg from axis dot com writes:
This patch makes msh handle variable expansion within backticks more
correctly.
Current behaviour (wrong):
--------------------------
BusyBox v1.00-rc3 (2004.08.26-11:51+0000) Built-in shell (msh)
Enter 'help' for a list of built-in commands.
$ A='`echo hello`'
$ echo $A
`echo hello`
$ echo `echo $A`
hello
$
New behaviour (correct):
------------------------
BusyBox v1.00-rc3 (2004.08.26-11:51+0000) Built-in shell (msh)
Enter 'help' for a list of built-in commands.
$ A='`echo hello`'
$ echo $A
`echo hello`
$ echo `echo $A`
`echo hello`
$
The current behaviour (wrong according to standards) was actually my
fault. msh handles backticks by executing a subshell (which makes it
work on MMU-less systems). Executing a subshell makes it hard to only
expand variables once in the parent. Therefore I export all variables
that will be expanded within the backticks and let the subshell handle
the expansion instead.
The bug was found while searching for security leaks in CGI-scripts.
Current behaviour of msh makes it easy to expand backticks by mistake
in $QUERY_STRING. I recommend appling the patch before release of bb
1.00.
/Jonas
Eric Andersen [Thu, 2 Sep 2004 23:11:53 +0000 (23:11 -0000)]
No longer needed
Eric Andersen [Thu, 2 Sep 2004 23:03:25 +0000 (23:03 -0000)]
Based on patches from Mike Frysinger, add insmod support for
sparc and ia64 (itanium).
Also, reorganize the insmod architecture support code to be
alphasorted and less messy.
Update the readme to list current insmod arch support.
Eric Andersen [Thu, 2 Sep 2004 22:22:17 +0000 (22:22 -0000)]
Tito writes:
The second patch contains:
1) a size optimization for adduser.c
2) removes a warning about an unused variable in syslogd.c if CONFIG_FEATURE_REMOTE_LOG is not set
3)cosmetic fixes for addgroup_full_usage and adduser_full_usage
Ciao,
Tito
Eric Andersen [Thu, 2 Sep 2004 22:21:41 +0000 (22:21 -0000)]
Tito writes:
Hi Erik,
Hi to all,
This is part five of the my_get*id story.
I've tweaked a bit this two functions to make them more flexible,
but this changes will not affect existing code.
Now they work so:
1) my_getpwuid( char *user, uid_t uid, int bufsize)
if bufsize is > 0 char *user cannot be set to NULL
on success username is written on static allocated buffer
on failure uid as string is written to buffer and NULL is returned
if bufsize is = 0 char *user can be set to NULL
on success username is returned
on failure NULL is returned
if bufsize is < 0 char *user can be set to NULL
on success username is returned
on failure an error message is printed and the program exits
2) 1) my_getgrgid( char *group, uid_t uid, int bufsize)
if bufsize is > 0 char *group cannot be set to NULL
on success groupname is written on static allocated buffer
on failure gid as string is written to buffer and NULL is returned
if bufsize is = 0 char *group can be set to NULL
on success groupname is returned
on failure NULL is returned
if bufsize is < 0 char *group can be set to nULL
on success groupname is returned
on failure an error message is printed and the program exits
This changes were needed mainly for my new id applet.
It is somewhat bigger then the previous but matches the behaviour of GNU id
and is capable to handle usernames of whatever length.
BTW: at a first look it seems to me that it will integrate well (with just a few changes)
with the pending patch in patches/id_groups_alias.patch.
The increase in size is balanced by the removal of my_getpwnamegid.c
from libbb as this was used only in previous id applet and by size optimizations
made possible in whoami.c and in passwd.c.
I know that we are in feature freeze but I think that i've tested it enough
(at least I hope so.......).
Eric Andersen [Sat, 28 Aug 2004 00:43:07 +0000 (00:43 -0000)]
Fixup some warnings