oweals/busybox.git
13 years agoUse the _unlocked stdio macros only when they're all available
Dan Fandrich [Thu, 30 Jun 2011 00:59:17 +0000 (02:59 +0200)]
Use the _unlocked stdio macros only when they're all available

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agolibbb.h: tweak _unlocked hack
Denys Vlasenko [Thu, 30 Jun 2011 00:44:27 +0000 (02:44 +0200)]
libbb.h: tweak _unlocked hack

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoUse the built-in getline on more systems that don't have it
Dan Fandrich [Wed, 29 Jun 2011 06:03:27 +0000 (23:03 -0700)]
Use the built-in getline on more systems that don't have it

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoplatform.c: provide getline implementation
Timo Teras [Wed, 29 Jun 2011 00:19:58 +0000 (02:19 +0200)]
platform.c: provide getline implementation

Signed-off-by: Timo Teras <timo.teras@iki.fi>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agovi: fix regex search, make it selectable in config
Walter Harms [Mon, 27 Jun 2011 00:59:37 +0000 (02:59 +0200)]
vi: fix regex search, make it selectable in config

function                                             old     new   delta
char_search                                          134     214     +80
find_pair                                            187     169     -18
mycmp                                                 37       -     -37

Signed-off-by: Walter Harms <wharms@bfs.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoid: correct getgroups usage
Denys Vlasenko [Wed, 22 Jun 2011 14:42:36 +0000 (16:42 +0200)]
id: correct getgroups usage

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agogroups: make it NOEXEC
Denys Vlasenko [Wed, 22 Jun 2011 02:17:49 +0000 (04:17 +0200)]
groups: make it NOEXEC

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agols: fix HAVE_STRVERSCMP check; add check for older uclibc versions
Denys Vlasenko [Tue, 21 Jun 2011 15:12:52 +0000 (17:12 +0200)]
ls: fix HAVE_STRVERSCMP check; add check for older uclibc versions

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agogroups: new applet
Tito Ragusa [Tue, 21 Jun 2011 15:11:40 +0000 (17:11 +0200)]
groups: new applet

Signed-off-by: Tito Ragusa <farmatito@tiscali.it>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoAdd HAVE_STRVERSCMP, guard the only usage of strverscmp with #ifdef
Denys Vlasenko [Tue, 21 Jun 2011 14:38:29 +0000 (16:38 +0200)]
Add HAVE_STRVERSCMP, guard the only usage of strverscmp with #ifdef

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agosetserial: added missing \n in help text
Dan Fandrich [Mon, 20 Jun 2011 08:22:18 +0000 (10:22 +0200)]
setserial: added missing \n in help text

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agolibbb: use _unlocked variants of stdio I/O.
Denys Vlasenko [Mon, 20 Jun 2011 08:06:28 +0000 (10:06 +0200)]
libbb: use _unlocked variants of stdio I/O.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoparse_config: use getline. BIG speedup with glibc (~40%).
Timo Teras [Mon, 20 Jun 2011 07:49:56 +0000 (09:49 +0200)]
parse_config: use getline. BIG speedup with glibc (~40%).

function                                             old     new   delta
config_read                                          559     604     +45
getline                                                -      23     +23
config_close                                          29      49     +20
find_pair                                            169     187     +18
showmode                                             330     338      +8
hash_find                                            233     234      +1
builtin_umask                                        133     132      -1
lzo1x_optimize                                      1434    1429      -5
test_main                                            253     247      -6
buffer_fill_and_print                                196     179     -17
create_J                                            1849    1826     -23
config_free_data                                      37       -     -37
------------------------------------------------------------------------------
(add/remove: 3/1 grow/shrink: 5/5 up/down: 138/-89)            Total: 26 bytes

Signed-off-by: Timo Teras <timo.teras@iki.fi>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agomodprobe: use hash table. speeds up significantly if modprobe.dep is large
Timo Teras [Mon, 20 Jun 2011 07:38:13 +0000 (09:38 +0200)]
modprobe: use hash table. speeds up significantly if modprobe.dep is large

function                                             old     new   delta
helper_get_module                                    106     157     +51
config_file_action                                   413     431     +18
modprobe_main                                        690     706     +16
do_modprobe                                          580     588      +8
add_probe                                             81      83      +2
load_modules_dep                                     192     190      -2
get_or_add_modentry                                   10       -     -10
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 5/1 up/down: 95/-12)             Total: 83 bytes

Signed-off-by: Timo Teras <timo.teras@iki.fi>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agodiff: disable debug code; remove unsupported --dry-run from help text
Denys Vlasenko [Sat, 18 Jun 2011 23:40:31 +0000 (01:40 +0200)]
diff: disable debug code; remove unsupported --dry-run from help text

function                                             old     new   delta
packed_usage                                       28623   28602     -21
do_line                                              121      91     -30
patch_main                                          2086    1923    -163
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-214)           Total: -214 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agolibbb/read_cmdline: prepend {comm} if different from argv0. Closes 3835.
Denys Vlasenko [Sat, 18 Jun 2011 13:51:16 +0000 (15:51 +0200)]
libbb/read_cmdline: prepend {comm} if different from argv0. Closes 3835.

function                                             old     new   delta
read_cmdline                                         114     233    +119

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoprocps: remove PSSCAN_STAT define, users were using it incorrectly
Denys Vlasenko [Sat, 18 Jun 2011 13:49:47 +0000 (15:49 +0200)]
procps: remove PSSCAN_STAT define, users were using it incorrectly

Also contains small cleanups ps.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agofix false positive in parse test
Denys Vlasenko [Sat, 18 Jun 2011 07:29:21 +0000 (09:29 +0200)]
fix false positive in parse test

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoparse_config: make test applet easier to enable; fix its code
Denys Vlasenko [Sat, 18 Jun 2011 07:23:09 +0000 (09:23 +0200)]
parse_config: make test applet easier to enable; fix its code

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agolibbb: split bb_get_chunk_from_file and bb_get_chunk_with_continuation
Denys Vlasenko [Fri, 17 Jun 2011 01:37:43 +0000 (03:37 +0200)]
libbb: split bb_get_chunk_from_file and bb_get_chunk_with_continuation

This also moves bb_get_chunk_with_continuation into its sole user,
parse_config.c.
This allows to optimize both functions separately,
they need to be optimized for speed.
(this need was highlighted by slow modprobe caused in part by slow
bb_get_chunk_with_continuation in config parser).

function                                             old     new   delta
bb_get_chunk_from_file                                 7     130    +123
config_read                                          457     558    +101
bb_get_chunk_with_continuation                       194       -    -194
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 2/0 up/down: 224/-194)           Total: 30 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoinetd: check if RPC is available
Bernhard Reutner-Fischer [Wed, 15 Jun 2011 07:38:43 +0000 (09:38 +0200)]
inetd: check if RPC is available

It would be better to have FEATURE_HAVE_RPC be user-selectable and
depend mount.nfs and inetd-rpc on it instead of the current, backward,
way.

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
13 years agols: fix comment about -p (it's compatible now)
Denys Vlasenko [Mon, 13 Jun 2011 00:24:18 +0000 (02:24 +0200)]
ls: fix comment about -p (it's compatible now)

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agols: make -v and -X actually work as intended
Denys Vlasenko [Mon, 13 Jun 2011 00:13:42 +0000 (02:13 +0200)]
ls: make -v and -X actually work as intended

function                                             old     new   delta
strverscmp                                             -     236    +236
sortcmp                                              186     254     +68
static.result_type                                     -      60     +60
static.next_state                                     12      16      +4

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoiplink: tweak includes to work on android
Denys Vlasenko [Sun, 12 Jun 2011 15:15:16 +0000 (17:15 +0200)]
iplink: tweak includes to work on android

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agopkill/pgrep: support extended regular expressions
Wade Berrier [Wed, 8 Jun 2011 21:46:55 +0000 (15:46 -0600)]
pkill/pgrep: support extended regular expressions

Done by enabling the REG_EXTENDED and REG_NOSUB regex flags,
which also increases compatibility with the procps versions.

Signed-off-by: Wade Berrier <wade_berrier@appsig.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoReplaced __u32 etc. with standard uint32_t style types
Daniel Fandrich [Thu, 9 Jun 2011 22:44:44 +0000 (15:44 -0700)]
Replaced __u32 etc. with standard uint32_t style types

Signed-off-by: Daniel Fandrich <dfandrich@intrinsyc.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years ago*: simplify Ethernet header includes
Dan Fandrich [Fri, 10 Jun 2011 03:17:59 +0000 (05:17 +0200)]
*: simplify Ethernet header includes

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agobuild system: delete generated files on "make mrproper"
Denys Vlasenko [Tue, 7 Jun 2011 08:01:58 +0000 (10:01 +0200)]
build system: delete generated files on "make mrproper"

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agofbset: apply modelines. Closes 3823
Denys Vlasenko [Mon, 6 Jun 2011 02:21:39 +0000 (04:21 +0200)]
fbset: apply modelines. Closes 3823

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agofix breakage caused by 'remove "Options:" string from help texts' commit
Denys Vlasenko [Sun, 5 Jun 2011 13:07:31 +0000 (15:07 +0200)]
fix breakage caused by 'remove "Options:" string from help texts' commit

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years ago*: remove "Options:" string from help texts
Denys Vlasenko [Sun, 5 Jun 2011 01:58:28 +0000 (03:58 +0200)]
*: remove "Options:" string from help texts

function                                             old     new   delta
packed_usage                                       28706   28623     -83

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoiostat: code shrink
Maksym Kryzhanovskyy [Sun, 5 Jun 2011 01:37:14 +0000 (03:37 +0200)]
iostat: code shrink

function                                             old     new   delta
iostat_main                                         2048    2400    +352
is_partition                                          48       -     -48
print_stats_dev_struct                               350       -    -350

Signed-off-by: Maksym Kryzhanovskyy <xmaks@email.cz>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoudhcpc: allow -O OPT take numeric params
Denys Vlasenko [Sat, 4 Jun 2011 03:07:16 +0000 (05:07 +0200)]
udhcpc: allow -O OPT take numeric params

function                                             old     new   delta
udhcpc_main                                         2623    2654     +31

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoappletlib.c: do not use PAGE_SIZE for malloc tweaking
Denys Vlasenko [Fri, 3 Jun 2011 19:39:42 +0000 (21:39 +0200)]
appletlib.c: do not use PAGE_SIZE for malloc tweaking

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoplatform.h: support for build under Android
Dan Fandrich [Fri, 3 Jun 2011 18:51:58 +0000 (20:51 +0200)]
platform.h: support for build under Android

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoonly compile obscure.c when needed
Dan Fandrich [Fri, 3 Jun 2011 18:28:14 +0000 (20:28 +0200)]
only compile obscure.c when needed

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoreplace nonstandard unsigned typedefs
Dan Fandrich [Fri, 3 Jun 2011 18:25:17 +0000 (20:25 +0200)]
replace nonstandard unsigned typedefs

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: better comment. No code changes
Denys Vlasenko [Wed, 1 Jun 2011 10:47:07 +0000 (12:47 +0200)]
hush: better comment. No code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: fix a corner case of empty "do \n done" structure
Denys Vlasenko [Tue, 31 May 2011 15:35:45 +0000 (17:35 +0200)]
hush: fix a corner case of empty "do \n done" structure

The structure is:

    while cmd; do
    done

bash doesn't accept it at all. We were accepting it but execution
was buggy.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agomakedevs: fix help-text
Bernhard Reutner-Fischer [Mon, 30 May 2011 21:00:47 +0000 (23:00 +0200)]
makedevs: fix help-text

pull
http://git.buildroot.net/buildroot/commit/?id=99ead3c2ead605d6504b9abad111778dc2a93ae6

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
13 years agofix !ENABLE_FEATURE_GETOPT_LONG build. Closes 3775
Denys Vlasenko [Sun, 29 May 2011 02:24:13 +0000 (04:24 +0200)]
fix !ENABLE_FEATURE_GETOPT_LONG build. Closes 3775

When compiling with !ENABLE_FEATURE_GETOPT_LONG, busybox still tries
to include getopt.h which is not available; for example with uClibc
when !UCLIBC_HAS_GETOPT_LONG.  getopt.h is only required
for the _long set of functions.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agofuser: fix inverted access() check. Closes 3799.
Denys Vlasenko [Sun, 29 May 2011 00:03:38 +0000 (02:03 +0200)]
fuser: fix inverted access() check. Closes 3799.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agosetconsole: open console for writing rather than reading
Peter Korsgaard [Thu, 26 May 2011 15:51:37 +0000 (17:51 +0200)]
setconsole: open console for writing rather than reading

The console passed to TIOCCONS has to be writable, otherwise future
console writes will fail.

This presumably used to work, but in current kernels (see
drivers/tty/tty_io.c:redirected_tty_write) console writes are sent to
vfs_write(device), which checks if the device is writable. A quick look
in the linux git history doesn't show any recent changes to either tty_io
or vfs_write.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agonmeter: trim help text
Denys Vlasenko [Thu, 26 May 2011 07:00:23 +0000 (09:00 +0200)]
nmeter: trim help text

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agosyslogd,klogd: better help text
Denys Vlasenko [Wed, 25 May 2011 09:58:56 +0000 (11:58 +0200)]
syslogd,klogd: better help text

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agofuser: code shrink
Maksym Kryzhanovskyy [Mon, 23 May 2011 01:39:48 +0000 (03:39 +0200)]
fuser: code shrink

function                                             old     new   delta
scan_proc_net_or_maps                                  -     427    +427
scan_recursive                                         -     380    +380
search_dev_inode                                      74      71      -3
add_pid                                               39       -     -39
scan_link                                             46       -     -46
scan_dir_links                                        76       -     -76
scan_pid_maps                                        222       -    -222
fuser_main                                           871     297    -574
------------------------------------------------------------------------------
(add/remove: 2/4 grow/shrink: 0/2 up/down: 807/-960)         Total: -153 bytes

Signed-off-by: Maksym Kryzhanovskyy <xmaks@email.cz>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agolibbb.h: small reordering
Denys Vlasenko [Mon, 23 May 2011 01:39:08 +0000 (03:39 +0200)]
libbb.h: small reordering

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agofind: cater for libc w/o FNM_CASEFOLD
Denys Vlasenko [Sun, 22 May 2011 22:40:54 +0000 (00:40 +0200)]
find: cater for libc w/o FNM_CASEFOLD

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agofind: implement -ipath
Bogdan Harjoc [Sun, 22 May 2011 01:50:21 +0000 (03:50 +0200)]
find: implement -ipath

Signed-off-by: Bogdan Harjoc <harjoc@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoreformime: do not require \r\n
Denys Vlasenko [Sun, 22 May 2011 01:46:33 +0000 (03:46 +0200)]
reformime: do not require \r\n

function                                             old     new   delta
parse                                                958    1063    +105
packed_usage                                       28691   28712     +21

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoadduser: better logic for choosing addgroup -g/--gid
Denys Vlasenko [Sat, 21 May 2011 19:32:40 +0000 (21:32 +0200)]
adduser: better logic for choosing addgroup -g/--gid

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoadduser: prefer to call addgroup --gid, not non-std addgroup -g
Denys Vlasenko [Sat, 21 May 2011 17:57:58 +0000 (19:57 +0200)]
adduser: prefer to call addgroup --gid, not non-std addgroup -g

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agood: code shrink
Denys Vlasenko [Sat, 21 May 2011 17:15:55 +0000 (19:15 +0200)]
od: code shrink

function                                             old     new   delta
od_main                                             2147    2132     -15

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agood: another fix for --strings
Denys Vlasenko [Sat, 21 May 2011 16:47:51 +0000 (18:47 +0200)]
od: another fix for --strings

function                                             old     new   delta
od_main                                             2139    2147      +8

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agood: fix -S NUM to not print chars >0x80
Denys Vlasenko [Sat, 21 May 2011 16:38:59 +0000 (18:38 +0200)]
od: fix -S NUM to not print chars >0x80

function                                             old     new   delta
write_block                                          433     431      -2
print_ascii                                          217     215      -2
check_and_close                                      104      96      -8
od_main                                             2164    2139     -25

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agood: code shrink
Denys Vlasenko [Sat, 21 May 2011 16:38:40 +0000 (18:38 +0200)]
od: code shrink

function                                             old     new   delta
exit_code                                              -       1      +1
open_next_file                                        73      72      -1
limit_bytes_to_format                                  1       -      -1
ioerror                                                1       -      -1
flag_pseudo_start                                      1       -      -1
flag_dump_strings                                      1       -      -1
od_main                                             2275    2164    -111

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agood: code shrink, fix "od --traditional FILE"
Denys Vlasenko [Sat, 21 May 2011 15:43:06 +0000 (17:43 +0200)]
od: code shrink, fix "od --traditional FILE"

function                                             old     new   delta
parse_old_offset                                     107     125     +18
packed_usage                                       28715   28691     -24
od_main                                             2312    2275     -37

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agolineedit: fix rare SEGV; mark a few FIXMEs
Alexey Fomenko [Fri, 20 May 2011 02:26:29 +0000 (04:26 +0200)]
lineedit: fix rare SEGV; mark a few FIXMEs

Signed-off-by: Alexey Fomenko <ext-alexey.fomenko@nokia.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agowarning removal
Cristian Ionescu-Idbohrn [Fri, 20 May 2011 01:52:36 +0000 (03:52 +0200)]
warning removal

Signed-off-by: Cristian Ionescu-Idbohrn <cii@axis.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agotail: optimize "tail -c HUGENUM REGULAR_FILE". Closes 3763.
Denys Vlasenko [Thu, 19 May 2011 22:30:04 +0000 (00:30 +0200)]
tail: optimize "tail -c HUGENUM REGULAR_FILE". Closes 3763.

function                                             old     new   delta
tail_main                                           1541    1547      +6

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agotop: display sort indicator in memory display
Denys Vlasenko [Wed, 18 May 2011 10:11:19 +0000 (12:11 +0200)]
top: display sort indicator in memory display

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agobusybox.conf: code shrink
Denys Vlasenko [Mon, 16 May 2011 12:30:26 +0000 (14:30 +0200)]
busybox.conf: code shrink

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agobusybox.conf: USER.GROUP is _optional_
Denys Vlasenko [Mon, 16 May 2011 11:53:19 +0000 (13:53 +0200)]
busybox.conf: USER.GROUP is _optional_

function                                             old     new   delta
main                                                 785     809     +24

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agomain: make busybox.conf mode handling less obscure
Denys Vlasenko [Mon, 16 May 2011 11:19:25 +0000 (13:19 +0200)]
main: make busybox.conf mode handling less obscure

function                                             old     new   delta
static.mode_mask                                       -      20     +20
main                                                 782     785      +3
static.mode_chars                                     15      13      -2
run_applet_no_and_exit                               450     441      -9
mode_mask                                             24       -     -24
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 1/2 up/down: 41/-53)            Total: -12 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agomain: free suid_config list after use
Denys Vlasenko [Mon, 16 May 2011 10:21:31 +0000 (12:21 +0200)]
main: free suid_config list after use

function                                             old     new   delta
run_applet_no_and_exit                               438     450     +12
ifupdown_main                                       2147    2149      +2
writeFileToTarball                                  1325    1326      +1
pidof_main                                           244     245      +1
last_main                                            896     897      +1
grep_main                                            779     780      +1
find_list_entry2                                     121     122      +1
tar_main                                             835     833      -2
llist_unlink                                          28      26      -2
llist_rev                                             23      21      -2
main                                                 791     782      -9
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 7/4 up/down: 19/-15)              Total: 4 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agovi.c: remove warning: variable 'sp' set but not used
Cristian Ionescu-Idbohrn [Mon, 16 May 2011 01:53:43 +0000 (03:53 +0200)]
vi.c: remove warning: variable 'sp' set but not used

Signed-off-by: Cristian Ionescu-Idbohrn <cii@axis.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoThe [-Wunused-but-set-variable] warnings
Cristian Ionescu-Idbohrn [Mon, 16 May 2011 01:53:00 +0000 (03:53 +0200)]
The [-Wunused-but-set-variable] warnings

networking/ntpd.c:1748:19: warning: variable 'version' set but not used

Signed-off-by: Cristian Ionescu-Idbohrn <cii@axis.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agodc: do not advertise ops disabled in .config
Denys Vlasenko [Sun, 15 May 2011 22:13:18 +0000 (00:13 +0200)]
dc: do not advertise ops disabled in .config

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agosimplify parsing of /etc/busybox.conf
Denys Vlasenko [Sun, 15 May 2011 22:01:08 +0000 (00:01 +0200)]
simplify parsing of /etc/busybox.conf

function                                             old     new   delta
parse_config_file                                    799     667    -132

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agotweak config help text
Denys Vlasenko [Sat, 14 May 2011 13:23:55 +0000 (15:23 +0200)]
tweak config help text

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: fix misparsing of "... do eval a= ...". Closes 3721
Denys Vlasenko [Sat, 14 May 2011 09:27:36 +0000 (11:27 +0200)]
hush: fix misparsing of "... do eval a= ...". Closes 3721

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agotop: better indicator of selected field in mem view
Denys Vlasenko [Fri, 13 May 2011 23:32:09 +0000 (01:32 +0200)]
top: better indicator of selected field in mem view

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agofix "variable 'foo' set but not used" warnings
Denys Vlasenko [Fri, 13 May 2011 18:57:01 +0000 (20:57 +0200)]
fix "variable 'foo' set but not used" warnings

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agols: code shrink
Denys Vlasenko [Fri, 13 May 2011 15:55:08 +0000 (17:55 +0200)]
ls: code shrink

function                                             old     new   delta
sort_and_display_files                                 -     427    +427
scan_and_display_dirs_recur                          497     488      -9
ls_main                                              765     735     -30
display_files                                        422       -    -422
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 0/2 up/down: 427/-461)          Total: -34 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agols: reorder and rename functions. No code changes
Denys Vlasenko [Fri, 13 May 2011 15:28:46 +0000 (17:28 +0200)]
ls: reorder and rename functions. No code changes

function                                             old     new   delta
display_single                                         -     931    +931
scan_and_display_dirs_recur                            -     497    +497
display_files                                          -     422    +422
showfiles                                            422       -    -422
showdirs                                             497       -    -497
list_single                                          931       -    -931
------------------------------------------------------------------------------
(add/remove: 3/3 grow/shrink: 0/0 up/down: 1850/-1850)          Total: 0 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agols: reduce memory consumption and speed up (don't do redundant [l]stat)
Denys Vlasenko [Fri, 13 May 2011 15:28:09 +0000 (17:28 +0200)]
ls: reduce memory consumption and speed up (don't do redundant [l]stat)

function                                             old     new   delta
my_stat                                              110     278    +168
splitdnarray                                         120     118      -2
ls_main                                              769     765      -4
list_single                                          961     931     -30
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/3 up/down: 168/-36)           Total: 132 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agols: avoid forward declaration. No code changes
Denys Vlasenko [Fri, 13 May 2011 15:27:36 +0000 (17:27 +0200)]
ls: avoid forward declaration. No code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agols: code shrink
Denys Vlasenko [Fri, 13 May 2011 15:27:15 +0000 (17:27 +0200)]
ls: code shrink

function                                             old     new   delta
list_single                                          990     961     -29

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agopasswd: shorter help text
Denys Vlasenko [Fri, 13 May 2011 01:31:45 +0000 (03:31 +0200)]
passwd: shorter help text

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoadduser: safe username passing to passwd/addgroup
Denys Vlasenko [Fri, 13 May 2011 01:19:01 +0000 (03:19 +0200)]
adduser: safe username passing to passwd/addgroup

passwd: support creating SHA passwords
random code shrink

function                                             old     new   delta
crypt_make_pw_salt                                     -      87     +87
adduser_main                                         883     904     +21
...
crypt_make_salt                                       99      89     -10
chpasswd_main                                        329     312     -17
packed_usage                                       28731   28691     -40
passwd_main                                         1070    1000     -70
cryptpw_main                                         310     224     -86
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 4/12 up/down: 154/-288)        Total: -134 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: install signal handlers with filled sigmask
Denys Vlasenko [Thu, 12 May 2011 21:06:20 +0000 (23:06 +0200)]
hush: install signal handlers with filled sigmask

function                                             old     new   delta
install_sighandler                                     -      39     +39
hush_main                                           1001    1031     +30
builtin_trap                                         386     392      +6
install_sighandlers                                  121     123      +2
switch_off_special_sigs                               87      86      -1
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 3/1 up/down: 77/-1)              Total: 76 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoinetd: add FIXMEs
Denys Vlasenko [Thu, 12 May 2011 21:05:27 +0000 (23:05 +0200)]
inetd: add FIXMEs

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agolibbb.h: use inlined sigfillset, sigemptyset, sigisemptyset on uclibc
Denys Vlasenko [Thu, 12 May 2011 21:03:18 +0000 (23:03 +0200)]
libbb.h: use inlined sigfillset, sigemptyset, sigisemptyset on uclibc

   text    data     bss     dec     hex filename
 875879     493    7584  883956   d7cf4 busybox_old
 875879     493    7584  883956   d7cf4 busybox_unstripped

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agols: fix help text: -w N is optional
Denys Vlasenko [Thu, 12 May 2011 16:44:51 +0000 (18:44 +0200)]
ls: fix help text: -w N is optional

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agols: fix -p help text, improve comments and define names
Denys Vlasenko [Thu, 12 May 2011 16:40:59 +0000 (18:40 +0200)]
ls: fix -p help text, improve comments and define names

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: fixes and small shrink for HUSH_JOB!=y
Denys Vlasenko [Thu, 12 May 2011 11:12:47 +0000 (13:12 +0200)]
hush: fixes and small shrink for HUSH_JOB!=y

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: remove one sigprocmask from exit path
Denys Vlasenko [Thu, 12 May 2011 08:59:18 +0000 (10:59 +0200)]
hush: remove one sigprocmask from exit path

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: add forgotten {} in multi-statement if.
Denys Vlasenko [Thu, 12 May 2011 07:50:12 +0000 (09:50 +0200)]
hush: add forgotten {} in multi-statement if.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agotrim help text
Denys Vlasenko [Thu, 12 May 2011 01:14:12 +0000 (03:14 +0200)]
trim help text

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: fix login shell's signal handling; add -l option so that it's easier to test
Denys Vlasenko [Thu, 12 May 2011 00:10:33 +0000 (02:10 +0200)]
hush: fix login shell's signal handling; add -l option so that it's easier to test

function                                             old     new   delta
hush_main                                            958    1001     +43
install_special_sighandlers                           47      52      +5
packed_usage                                       28752   28741     -11
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/1 up/down: 48/-11)             Total: 37 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: replace signal handling machinery
Denys Vlasenko [Wed, 11 May 2011 21:56:11 +0000 (23:56 +0200)]
hush: replace signal handling machinery

With new version of signal handling, read builtin should be less buggy
wrt signals.

function                                             old     new   delta
install_sighandlers                                    -     121    +121
switch_off_special_sigs                                -      84     +84
pick_sighandler                                        -      58     +58
install_special_sighandlers                            -      47     +47
builtin_wait                                         284     319     +35
record_pending_signo                                   -      21     +21
execvp_or_die                                         43      48      +5
file_get                                             290     288      -2
run_list                                            1004     998      -6
static.zero_timespec                                   8       -      -8
sigprocmask_set                                       14       -     -14
sigwaitinfo                                           23       -     -23
record_signal                                         23       -     -23
__GI_sigwaitinfo                                      23       -     -23
sigtimedwait                                          25       -     -25
builtin_trap                                         417     392     -25
__GI_sigtimedwait                                     25       -     -25
hush_main                                           1003     965     -38
check_and_run_traps                                  263     217     -46
__rt_sigtimedwait                                     52       -     -52
reset_traps_to_defaults                              213     126     -87
init_sigmasks                                        198       -    -198
builtin_read                                         536     197    -339
------------------------------------------------------------------------------
(add/remove: 5/10 grow/shrink: 2/7 up/down: 371/-934)        Total: -563 bytes
   text    data     bss     dec     hex filename
 903075     936   17736  921747   e1093 busybox_old
 902547     936   17736  921219   e0e83 busybox_unstripped

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: use SA_RESTARTed signal handlers across read.
Denys Vlasenko [Wed, 11 May 2011 09:49:21 +0000 (11:49 +0200)]
hush: use SA_RESTARTed signal handlers across read.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agofbset: abort on unknown options. closes 3121
Denys Vlasenko [Mon, 9 May 2011 01:57:27 +0000 (03:57 +0200)]
fbset: abort on unknown options. closes 3121

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agopam link error with SHARED_BUSYBOX and LIBBUSYBOX enabled
Steve Iribarne [Sun, 8 May 2011 23:42:12 +0000 (01:42 +0200)]
pam link error with SHARED_BUSYBOX and LIBBUSYBOX enabled

Signed-off-by: Steve Iribarne <siribarne@grid-net.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: add tests for interrupting read
Denys Vlasenko [Sun, 8 May 2011 23:05:33 +0000 (01:05 +0200)]
hush: add tests for interrupting read

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: code shrink
Denys Vlasenko [Sun, 8 May 2011 22:52:15 +0000 (00:52 +0200)]
hush: code shrink

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: make read builtin interruptible.
Denys Vlasenko [Sun, 8 May 2011 19:23:43 +0000 (21:23 +0200)]
hush: make read builtin interruptible.

function                                             old     new   delta
builtin_read                                         185     471    +286
check_and_run_traps                                  200     262     +62
nonblock_immune_read                                  73     119     +46
sigismember                                            -      44     +44
record_signal                                          -      21     +21
sigisemptyset                                          -      16     +16
...
------------------------------------------------------------------------------
(add/remove: 5/0 grow/shrink: 7/5 up/down: 483/-46)           Total: 437 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agolibbb: nonblock_safe_read->nonblock_immune_read, remove unused param of xmalloc_reads
Denys Vlasenko [Sun, 8 May 2011 19:21:10 +0000 (21:21 +0200)]
libbb: nonblock_safe_read->nonblock_immune_read, remove unused param of xmalloc_reads

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agohush: fix incorrect PS2 dispaly and trap handling while reading command
Denys Vlasenko [Sun, 8 May 2011 19:20:01 +0000 (21:20 +0200)]
hush: fix incorrect PS2 dispaly and trap handling while reading command

The fix affects only !ENABLE_FEATURE_EDITING configuration

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
13 years agoiostat: code shrink ~0.5k
Maksym Kryzhanovskyy [Sat, 7 May 2011 02:37:22 +0000 (04:37 +0200)]
iostat: code shrink ~0.5k

Signed-off-by: Maksym Kryzhanovskyy <xmaks@email.cz>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>