oweals/busybox.git
18 years agosed: getopt_ulflags'isation
Denis Vlasenko [Fri, 22 Sep 2006 08:56:03 +0000 (08:56 -0000)]
sed: getopt_ulflags'isation

18 years agohostname: getopt_ulflags'isation
Denis Vlasenko [Fri, 22 Sep 2006 08:53:14 +0000 (08:53 -0000)]
hostname: getopt_ulflags'isation

18 years agotelnetd: getopt_ulflags'isation
Denis Vlasenko [Fri, 22 Sep 2006 08:50:29 +0000 (08:50 -0000)]
telnetd: getopt_ulflags'isation

18 years agoadjtimex: getopt_ulflags'isation
Denis Vlasenko [Fri, 22 Sep 2006 08:47:54 +0000 (08:47 -0000)]
adjtimex: getopt_ulflags'isation

18 years agologger: getopt_ulflags'isation
Denis Vlasenko [Fri, 22 Sep 2006 08:44:58 +0000 (08:44 -0000)]
logger: getopt_ulflags'isation

18 years agogetopt: fix whitespace damage
Denis Vlasenko [Fri, 22 Sep 2006 08:42:06 +0000 (08:42 -0000)]
getopt: fix whitespace damage

18 years agoreadprofile: getopt_ulflags'isation
Denis Vlasenko [Fri, 22 Sep 2006 08:39:49 +0000 (08:39 -0000)]
readprofile: getopt_ulflags'isation

18 years agoipcs: fix my recent breakage
Denis Vlasenko [Fri, 22 Sep 2006 08:30:52 +0000 (08:30 -0000)]
ipcs: fix my recent breakage

18 years ago- add new applet resize.
Bernhard Reutner-Fischer [Fri, 22 Sep 2006 08:18:41 +0000 (08:18 -0000)]
- add new applet resize.
   text    data     bss     dec     hex filename
    185       0       0     185      b9 console-tools/resize.o
    255       0       0     255      ff console-tools/resize.o.print

18 years agoChange license statements (and clean up headers) on some of the files that
Rob Landley [Fri, 22 Sep 2006 02:52:41 +0000 (02:52 -0000)]
Change license statements (and clean up headers) on some of the files that
Erik or I are primary copyright holders on.

18 years ago- update and expand TODO a little bit
Bernhard Reutner-Fischer [Thu, 21 Sep 2006 22:58:38 +0000 (22:58 -0000)]
- update and expand TODO a little bit

18 years ago- pull r15578 from busybox_scratch branch:
Bernhard Reutner-Fischer [Thu, 21 Sep 2006 22:10:24 +0000 (22:10 -0000)]
- pull r15578 from busybox_scratch branch:
  - fix bug where it would behave wrong if ./nohup.out was not writable.
  - debloat and make it readable while at it.
$ size coreutils/nohup.o*
   text    data     bss     dec     hex filename
    362       0       0     362     16a coreutils/nohup.o.trunk
    344       0       0     344     158 coreutils/nohup.o
$ make bloatcheck
function                                             old     new   delta
nohup_main                                           324     310     -14
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-14)             Total: -14 bytes

18 years ago- silence gcc warning about a funcptr possibly being used uninitialized.
Bernhard Reutner-Fischer [Thu, 21 Sep 2006 20:40:56 +0000 (20:40 -0000)]
- silence gcc warning about a funcptr possibly being used uninitialized.
  This is a perfect example on where we should NOT care if the functor is not
  initialized since the result will not be what the user may expect.
  Safe bet would be to init to NULL, but let's try normal uu for good measure.
- fix commentary typo while at it.

18 years agomount: nfs mount should enable bb_error-to-syslog support
Denis Vlasenko [Thu, 21 Sep 2006 12:30:16 +0000 (12:30 -0000)]
mount: nfs mount should enable bb_error-to-syslog support

18 years ago- gcc-2.95 doesn't support -static-libgcc
Bernhard Reutner-Fischer [Thu, 21 Sep 2006 11:54:51 +0000 (11:54 -0000)]
- gcc-2.95 doesn't support -static-libgcc
- remove Winline

18 years agomount: make Rob happy by reinstating #defines
Denis Vlasenko [Thu, 21 Sep 2006 11:13:08 +0000 (11:13 -0000)]
mount: make Rob happy by reinstating #defines

18 years agoTeach get_terminal_width_height to fall back to $LINES and $COLUMNS when
Rob Landley [Wed, 20 Sep 2006 22:06:01 +0000 (22:06 -0000)]
Teach get_terminal_width_height to fall back to $LINES and $COLUMNS when
used via things like a serial console.

18 years agoThe version checked into the tree is a snapshot of an unifinished applet, and
Rob Landley [Wed, 20 Sep 2006 21:57:36 +0000 (21:57 -0000)]
The version checked into the tree is a snapshot of an unifinished applet, and
you just made lots of ">>>>>>> mine" lines show up in my working copy of this.

Please don't do that again.

18 years agoThe Software Freedom Law Center wants us to add a copyright notice to the
Rob Landley [Wed, 20 Sep 2006 21:41:13 +0000 (21:41 -0000)]
The Software Freedom Law Center wants us to add a copyright notice to the
generated binaries, to make copyright enforcement easier.  Our liason with
them (Bradley Kuhn) suggested the following text:

> Copyright (C) YEAR-2006  Erik Andersen, Rob Landley, and others.
> Licensed under GPLv2.  See source distribution for full notice.

And the busybox help message seems the least offensive place to put it.  (At
some point in the future, I need to strip 128 bytes from the binary to feel
good about this, though. :)

Minor header file cleanup while I was there, since libbb.h already #includes
most of that stuff...

18 years agoLicense clarification.
Rob Landley [Wed, 20 Sep 2006 20:01:29 +0000 (20:01 -0000)]
License clarification.

18 years ago- fix documentation for the command-line options of ipcs. Closes #1036
Bernhard Reutner-Fischer [Wed, 20 Sep 2006 15:56:53 +0000 (15:56 -0000)]
- fix documentation for the command-line options of ipcs. Closes #1036

18 years ago- fix embarrassing typo of mine. Closes bug #1038
Bernhard Reutner-Fischer [Wed, 20 Sep 2006 15:29:13 +0000 (15:29 -0000)]
- fix embarrassing typo of mine. Closes bug #1038

18 years agoipcs: fix output (misaligned columns)
Denis Vlasenko [Tue, 19 Sep 2006 17:43:56 +0000 (17:43 -0000)]
ipcs: fix output (misaligned columns)

18 years agoipcs: getopt_ulflag'ification, -170 bytes
Denis Vlasenko [Tue, 19 Sep 2006 17:40:31 +0000 (17:40 -0000)]
ipcs: getopt_ulflag'ification, -170 bytes

18 years agostty: fix few bugs found in testing
Denis Vlasenko [Tue, 19 Sep 2006 15:12:12 +0000 (15:12 -0000)]
stty: fix few bugs found in testing

18 years agogetty: oops... removing duplicate #include <syslog.h>
Denis Vlasenko [Tue, 19 Sep 2006 14:47:54 +0000 (14:47 -0000)]
getty: oops... removing duplicate #include <syslog.h>

18 years agostty: reorder code, reducing need in forward declarations.
Denis Vlasenko [Tue, 19 Sep 2006 14:31:44 +0000 (14:31 -0000)]
stty: reorder code, reducing need in forward declarations.
added few missed bits of error checking for parameters.

18 years agostty: convert "enum mode_type" into unnamed enum
Denis Vlasenko [Tue, 19 Sep 2006 14:24:23 +0000 (14:24 -0000)]
stty: convert "enum mode_type" into unnamed enum
(reduces code obfuscation); deindent set_mode;
add _or_die suffixes to few functions

18 years agostty: reduce #ifdef forest
Denis Vlasenko [Tue, 19 Sep 2006 14:20:22 +0000 (14:20 -0000)]
stty: reduce #ifdef forest

18 years agostty: simplify linewrapping code a bit
Denis Vlasenko [Tue, 19 Sep 2006 14:19:42 +0000 (14:19 -0000)]
stty: simplify linewrapping code a bit

18 years agostty: style fixes
Denis Vlasenko [Tue, 19 Sep 2006 14:17:10 +0000 (14:17 -0000)]
stty: style fixes

18 years agostty: fix a longstanding FIXME (was able to die half-way setting term params)
Denis Vlasenko [Tue, 19 Sep 2006 14:16:28 +0000 (14:16 -0000)]
stty: fix a longstanding FIXME (was able to die half-way setting term params)

18 years agomount: fstabname needs to be const char*
Denis Vlasenko [Tue, 19 Sep 2006 14:14:12 +0000 (14:14 -0000)]
mount: fstabname needs to be const char*

18 years agomount: fix warning (printf field width of * wants int, not size_t)
Denis Vlasenko [Tue, 19 Sep 2006 14:07:52 +0000 (14:07 -0000)]
mount: fix warning (printf field width of * wants int, not size_t)

18 years agogetty: #include <syslog.h>
Denis Vlasenko [Tue, 19 Sep 2006 13:50:55 +0000 (13:50 -0000)]
getty: #include <syslog.h>

18 years agochange char *string = "foo" -> char string[] = "foo"
Denis Vlasenko [Tue, 19 Sep 2006 09:55:09 +0000 (09:55 -0000)]
change char *string = "foo"  -> char string[] = "foo"
function                                             old     new   delta
xsetenv                                               45      44      -1
iproute_list_or_flush                               1834    1833      -1
ipaddr_modify                                       1915    1914      -1
ipaddr_list_or_flush                                1861    1860      -1
invarg                                                39      38      -1
do_set                                              1259    1258      -1
bb_verror_msg                                        268     267      -1
create_icmp_socket                                   142     140      -2
create_icmp6_socket                                  142     140      -2
bb_full_fd_action                                    324     322      -2
bb_path_mtab_file                                     10       -     -10
.rodata                                           214796  214720     -76
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 0/11 up/down: 0/-99)            Total: -99 bytes

18 years agowhitespace cleanup
Denis Vlasenko [Sun, 17 Sep 2006 16:28:10 +0000 (16:28 -0000)]
whitespace cleanup

18 years agomount: style fixlet
Denis Vlasenko [Sun, 17 Sep 2006 15:51:52 +0000 (15:51 -0000)]
mount: style fixlet

18 years agostyle fixes
Denis Vlasenko [Sun, 17 Sep 2006 15:45:48 +0000 (15:45 -0000)]
style fixes

18 years agomount: revert mount --bind to using "bind" as fstype.
Denis Vlasenko [Sun, 17 Sep 2006 15:39:22 +0000 (15:39 -0000)]
mount: revert mount --bind to using "bind" as fstype.

18 years agomount: mount_it_now() - char *dir is not really needed.
Denis Vlasenko [Sun, 17 Sep 2006 15:09:48 +0000 (15:09 -0000)]
mount: mount_it_now() - char *dir is not really needed.

18 years agomount: fix "duplicate mount options in mtab" bug
Denis Vlasenko [Sun, 17 Sep 2006 15:08:12 +0000 (15:08 -0000)]
mount: fix "duplicate mount options in mtab" bug

18 years agomount: nfs_strerror's static buffer was bigger than needed.
Denis Vlasenko [Sun, 17 Sep 2006 15:06:34 +0000 (15:06 -0000)]
mount: nfs_strerror's static buffer was bigger than needed.

18 years agomount: getopt_ulflag'ification
Denis Vlasenko [Sun, 17 Sep 2006 15:05:31 +0000 (15:05 -0000)]
mount: getopt_ulflag'ification

18 years agomount: style fixes
Denis Vlasenko [Sun, 17 Sep 2006 15:04:35 +0000 (15:04 -0000)]
mount: style fixes

18 years agomount: fix bugs: free(mp->mnt_fsname) of non-malloced ptr;
Denis Vlasenko [Sun, 17 Sep 2006 15:04:01 +0000 (15:04 -0000)]
mount: fix bugs: free(mp->mnt_fsname) of non-malloced ptr;
check for "more than 2 arguments" was actually checking for -2.

18 years agomount: use bb_simplify_path as appropriate
Denis Vlasenko [Sun, 17 Sep 2006 15:01:53 +0000 (15:01 -0000)]
mount: use bb_simplify_path as appropriate

18 years agomount: style fixes
Denis Vlasenko [Sun, 17 Sep 2006 15:00:58 +0000 (15:00 -0000)]
mount: style fixes

18 years agologin: apply fixes + getopt_ulflag'ification by Bernhard
Denis Vlasenko [Sun, 17 Sep 2006 14:45:09 +0000 (14:45 -0000)]
login: apply fixes + getopt_ulflag'ification by Bernhard

18 years ago- Steven Scholz pointed out that ssd's make-pid doesn't take an argument.
Bernhard Reutner-Fischer [Fri, 15 Sep 2006 19:25:18 +0000 (19:25 -0000)]
- Steven Scholz pointed out that ssd's make-pid doesn't take an argument.

18 years agomount: reorder things, fix NFS-less mount.
Denis Vlasenko [Fri, 15 Sep 2006 15:12:00 +0000 (15:12 -0000)]
mount: reorder things, fix NFS-less mount.

18 years agoUnbreak allbareconfig.
Rob Landley [Fri, 15 Sep 2006 04:10:05 +0000 (04:10 -0000)]
Unbreak allbareconfig.

18 years agoSo, in the cornucopia of superfulous warning directives I didn't add to the
Rob Landley [Fri, 15 Sep 2006 04:08:25 +0000 (04:08 -0000)]
So, in the cornucopia of superfulous warning directives I didn't add to the
tree, we have the warning about failed inlines (which with our inline
limit set to zero means any usage of the "inline" keyword at all).  Note
that setting the inline limit to zero, and using -Werror, both predated
adding the warning about inlines to the tree.  So whatever checkin added
that did nothing but break the tree.  But oh well.

The second category of superfluous warnings is warning about functions with
no previous declaration.  Apparently, if you add ALWAYS_INLINE to an empty
function definition, it considers the sucker undeclared as far as the
warning is concerned.  (I.E. it's a buggy warning.  I try not to ask the
compiler to generate warnings it can't competently generate.)

This is why I removed "inline" (unbreak allbareconfig), and couldn't replace it
with "ALWAYS_INLINE" (still broke allbareconfig).

18 years agoUnbreak allbareconfig.
Rob Landley [Fri, 15 Sep 2006 04:01:03 +0000 (04:01 -0000)]
Unbreak allbareconfig.

We've had -Werror in the tree for quite a while, so adding #warning
somewhat counterproductve way to make comments on the code that belong on the
mailing list anyway.

18 years agoStrangely, using // in the comments I added was not a persistent accident.
Rob Landley [Thu, 14 Sep 2006 19:52:07 +0000 (19:52 -0000)]
Strangely, using // in the comments I added was not a persistent accident.

18 years agologin: eliminate forward decls and #ifdefs
Denis Vlasenko [Thu, 14 Sep 2006 17:03:18 +0000 (17:03 -0000)]
login: eliminate forward decls and #ifdefs

18 years agoumount: do not try to close FILE* which is NULL.
Denis Vlasenko [Thu, 14 Sep 2006 16:40:46 +0000 (16:40 -0000)]
umount: do not try to close FILE* which is NULL.

18 years agomount: -o remount should not add lines to /etc/mtab
Denis Vlasenko [Thu, 14 Sep 2006 16:09:27 +0000 (16:09 -0000)]
mount: -o remount should not add lines to /etc/mtab

18 years agomount: move code from nfsmount.c into mount.c
Denis Vlasenko [Thu, 14 Sep 2006 15:46:33 +0000 (15:46 -0000)]
mount: move code from nfsmount.c into mount.c

18 years ago- make sure that the 'build' dir exists even if we are about to build just one applet.
Bernhard Reutner-Fischer [Thu, 14 Sep 2006 15:07:48 +0000 (15:07 -0000)]
- make sure that the 'build' dir exists even if we are about to build just one applet.

18 years ago- do away with silly comment and do the Right Thing wrt building the archives.
Bernhard Reutner-Fischer [Thu, 14 Sep 2006 15:04:31 +0000 (15:04 -0000)]
- do away with silly comment and do the Right Thing wrt building the archives.
  You have to provide the absolute path to the objdir/target.ext you want to build, as can be seen in the respective makefiles..

18 years agomount: fix mtab support (but it is still rather buggy)
Denis Vlasenko [Thu, 14 Sep 2006 13:19:19 +0000 (13:19 -0000)]
mount: fix mtab support (but it is still rather buggy)

18 years agosvn 15355 replaced "BusyBox is licensed under the GNU General Public Public
Rob Landley [Thu, 14 Sep 2006 05:59:32 +0000 (05:59 -0000)]
svn 15355 replaced "BusyBox is licensed under the GNU General Public Public
License" with "BusyBox is licensed under the GNU General Public
License version 2 or later... (This is the same license the Linux kernel
is under...)"  Except that the Linux kernel isn't under GPLv2 or later,
it's just under GPLv2.

Now they match again.

18 years agoMore code from kernel developers, and therefore licensed under GPLv2 only.
Rob Landley [Thu, 14 Sep 2006 05:27:28 +0000 (05:27 -0000)]
More code from kernel developers, and therefore licensed under GPLv2 only.
Clarify the license boilerplate.

On an unrelated note, this could use busyboxification.  check_mount() looks
reusable and ask() is generic...

18 years agoAdd Larry Doolittle's ntpclient, plus some formatting tweaks.
Rob Landley [Wed, 13 Sep 2006 19:54:36 +0000 (19:54 -0000)]
Add Larry Doolittle's ntpclient, plus some formatting tweaks.

18 years ago- fix copy'n paste errors that got introduced when switching to the shorter boilerplate.
Bernhard Reutner-Fischer [Wed, 13 Sep 2006 16:39:19 +0000 (16:39 -0000)]
- fix copy'n paste errors that got introduced when switching to the shorter boilerplate.
  No object code changes.

18 years ago- r16075 broke for de-selected FEATURE_UTMP; Partial fix that wants some more cleanup...
Bernhard Reutner-Fischer [Wed, 13 Sep 2006 15:42:47 +0000 (15:42 -0000)]
- r16075 broke for de-selected FEATURE_UTMP; Partial fix that wants some more cleanup (see FIXME in the patch).

18 years agoRevert duplicate patch.
Rob Landley [Tue, 12 Sep 2006 22:42:03 +0000 (22:42 -0000)]
Revert duplicate patch.

I don't know why patch decided to apply this even though it was already in
the tree.  I thought the other hunks failed because they were totally
unrelated leakage from Bernhard's tree (which they are; was the a reason
for bundling them in with this fix?  Do they have something to do with
the GCC 2.95 fix?  I suspect they prevent me from backporting this
patch to 1.2.2 because the header consolidation into libbb.h hadn't
been done yet, and no I'm not fixing it up: if that's the case then
this patch won't be in 1.2.2 due to extraneous changes bundled with it that
prevent a clean backport without rolling a new patch).

18 years agoRemove pointless "const". Bloatcheck says 0 bytes difference.
Rob Landley [Tue, 12 Sep 2006 21:42:17 +0000 (21:42 -0000)]
Remove pointless "const".  Bloatcheck says 0 bytes difference.

18 years agoFix from Bernhard for somebody trying to limp along with gcc 2.95.4.
Rob Landley [Tue, 12 Sep 2006 20:29:22 +0000 (20:29 -0000)]
Fix from Bernhard for somebody trying to limp along with gcc 2.95.4.

18 years agoRandom cleanup hanging around my tree.
Rob Landley [Tue, 12 Sep 2006 20:28:34 +0000 (20:28 -0000)]
Random cleanup hanging around my tree.

18 years ago- small trivia to be gentle to gcc-2.95.x which had no va_copy but only __va_copy.
Bernhard Reutner-Fischer [Tue, 12 Sep 2006 13:27:55 +0000 (13:27 -0000)]
- small trivia to be gentle to gcc-2.95.x which had no va_copy but only __va_copy.

18 years ago- fix warning about discarding qualifiers in initialization
Bernhard Reutner-Fischer [Tue, 12 Sep 2006 13:25:16 +0000 (13:25 -0000)]
- fix warning about discarding qualifiers in initialization

18 years agonfsmount: sanitize it. It had a rather peculiar idea of implementing "bg"
Denis Vlasenko [Mon, 11 Sep 2006 17:42:44 +0000 (17:42 -0000)]
nfsmount: sanitize it. It had a rather peculiar idea of implementing "bg"
option - it was going to return a special flag back to caller and
expecting caller to call it again with special parameter! Also
caller was charged with calling mount() syscall...

mount: mtab support was non-functional. Enabling it revealed serious bug
which is not fixed yet.

18 years ago- convert a few xopen3(,,0) into xopen(,). Also peruse the fact that xopen defaults...
Bernhard Reutner-Fischer [Mon, 11 Sep 2006 16:01:40 +0000 (16:01 -0000)]
- convert a few xopen3(,,0) into xopen(,). Also peruse the fact that xopen defaults to 0777 on it's own, so we don't need to xopen3(,,0777).
  Saves a few bytes:
$ size busybox.old busybox                                text    data     bss     dec     hex filename
 839676    8780  243592 1092048  10a9d0 busybox.old
 839660    8780  243592 1092032  10a9c0 busybox
$ make CC=gcc-4.2-HEAD bloatcheck
function                                             old     new   delta
static.vconfig_main                                  281     279      -2
static.rx_main                                      1076    1074      -2
static.mt_main                                       294     292      -2
static.gzip_main                                     753     751      -2
static.mkfs_minix_main                              4034    4030      -4
static.unzip_main                                   1771    1766      -5
static.crontab_main                                 1513    1507      -6
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-23)             Total: -23 bytes

18 years ago- merge xstat.c into xfuncs.c
Bernhard Reutner-Fischer [Mon, 11 Sep 2006 09:18:09 +0000 (09:18 -0000)]
- merge xstat.c into xfuncs.c

18 years ago- Tito pointed out that Rob forgot to add e2fsprogs/blkid/list.c
Bernhard Reutner-Fischer [Mon, 11 Sep 2006 09:16:12 +0000 (09:16 -0000)]
- Tito pointed out that Rob forgot to add e2fsprogs/blkid/list.c

18 years agoBuild fixes for gcc 4.0 with -Werror, from Tito.
Rob Landley [Mon, 11 Sep 2006 01:34:21 +0000 (01:34 -0000)]
Build fixes for gcc 4.0 with -Werror, from Tito.

18 years agoError reporting fix for sulogin, plus remove help entries for options we never
Rob Landley [Mon, 11 Sep 2006 00:34:01 +0000 (00:34 -0000)]
Error reporting fix for sulogin, plus remove help entries for options we never
implemented.  (Plus a bit more of bbsh leaking in from my tree, but it
shouldn't hurt anything and I'm lazy...)

18 years agonfsmount: remove some really old code (for kernels 1.x!) + small cleanups.
Denis Vlasenko [Sun, 10 Sep 2006 18:48:16 +0000 (18:48 -0000)]
nfsmount: remove some really old code (for kernels 1.x!) + small cleanups.

18 years agonfsmount: delete nfsmount.h
Denis Vlasenko [Sun, 10 Sep 2006 18:40:18 +0000 (18:40 -0000)]
nfsmount: delete nfsmount.h

18 years agonfsmount: nfsmount.h merged into nfsmount.c
Denis Vlasenko [Sun, 10 Sep 2006 18:38:17 +0000 (18:38 -0000)]
nfsmount: nfsmount.h merged into nfsmount.c

18 years agonfsmount: style fix
Denis Vlasenko [Sun, 10 Sep 2006 18:28:23 +0000 (18:28 -0000)]
nfsmount: style fix

18 years agoipcs: silly trick with strings. saves ~200 bytes.
Denis Vlasenko [Sun, 10 Sep 2006 18:26:51 +0000 (18:26 -0000)]
ipcs: silly trick with strings. saves ~200 bytes.

18 years agoCleanup headers and replace the zero padding with an even smaller version.
Rob Landley [Sun, 10 Sep 2006 03:20:37 +0000 (03:20 -0000)]
Cleanup headers and replace the zero padding with an even smaller version.
One of the pads turned out to be unnecessary: sizeof(struct TarHeader) is
TAR_BLOCK_SIZE, the padding's in the struct.  The others could be done inline
with bb_common_bufsiz1.

This is a cleanup I did to Denis' patch long ago, but got sidetracked by
what turned into svn 15660.

18 years agosulogin: minor cleanup.
Denis Vlasenko [Sat, 9 Sep 2006 14:00:58 +0000 (14:00 -0000)]
sulogin: minor cleanup.

18 years agosetkeycodes: something horrible happened here
Denis Vlasenko [Sat, 9 Sep 2006 13:23:04 +0000 (13:23 -0000)]
setkeycodes: something horrible happened here
to indentation... fixed now

18 years agotop: fixed wrong comment, made error message more clear
Denis Vlasenko [Sat, 9 Sep 2006 12:55:02 +0000 (12:55 -0000)]
top: fixed wrong comment, made error message more clear

18 years agotar: fix "xopen with O_CREAT" warning, improve zero padding write
Denis Vlasenko [Sat, 9 Sep 2006 12:49:03 +0000 (12:49 -0000)]
tar: fix "xopen with O_CREAT" warning, improve zero padding write
(was doing zillions of 1-byte write syscalls)

18 years agoxopen3(O_RDONLY) -> xopen(O_RDONLY).
Denis Vlasenko [Sat, 9 Sep 2006 12:25:20 +0000 (12:25 -0000)]
xopen3(O_RDONLY) -> xopen(O_RDONLY).

18 years agousing [xa]sprintf for string concatenation is neat and saves
Denis Vlasenko [Sat, 9 Sep 2006 12:24:19 +0000 (12:24 -0000)]
using [xa]sprintf for string concatenation is neat and saves
~100 bytes according to bloatcheck. Also this fixes bug in rpm

18 years agowget: wrap one atrociously long line (around 200 chars long!).
Denis Vlasenko [Sat, 9 Sep 2006 12:20:57 +0000 (12:20 -0000)]
wget: wrap one atrociously long line (around 200 chars long!).

18 years agoudhcp: FEATURE_UDHCP_SYSLOG should be selected only if
Denis Vlasenko [Sat, 9 Sep 2006 12:18:46 +0000 (12:18 -0000)]
udhcp: FEATURE_UDHCP_SYSLOG should be selected only if
udhcp[cd] really are going to use it.

18 years agologin: use some ideas from util-linux's login.
Denis Vlasenko [Fri, 8 Sep 2006 17:56:52 +0000 (17:56 -0000)]
login: use some ideas from util-linux's login.
O_NONBLOCKing output on login timeout.
fchmod instead of chmod (latter is racy).
is_my_tty() is not needed anymore after race is fixed
(is_my_tty() was racy too anyway...).

18 years agofew random readability enhansements. No code changes
Denis Vlasenko [Fri, 8 Sep 2006 17:31:55 +0000 (17:31 -0000)]
few random readability enhansements. No code changes

18 years agologin: make it saner and smaller by ~0.5k.
Denis Vlasenko [Fri, 8 Sep 2006 17:29:53 +0000 (17:29 -0000)]
login: make it saner and smaller by ~0.5k.

18 years agologin: small fixes like \n removal, bb_error_msg'ification, etc.
Denis Vlasenko [Fri, 8 Sep 2006 17:26:20 +0000 (17:26 -0000)]
login: small fixes like \n removal, bb_error_msg'ification, etc.

18 years agologin: previous commit comment was wrong :)
Denis Vlasenko [Fri, 8 Sep 2006 17:25:04 +0000 (17:25 -0000)]
login: previous commit comment was wrong :)
That commit added login script support.
Now _this commit_ is a style fix. Sorry....

18 years agologin: style fixes
Denis Vlasenko [Fri, 8 Sep 2006 17:22:45 +0000 (17:22 -0000)]
login: style fixes

18 years agoShrinkage/cleanup from Tito.
Rob Landley [Fri, 8 Sep 2006 17:22:05 +0000 (17:22 -0000)]
Shrinkage/cleanup from Tito.