oweals/busybox.git
16 years agoftpgetput: add comment about EPSV (extended PASV).
Denis Vlasenko [Fri, 28 Mar 2008 22:11:49 +0000 (22:11 -0000)]
ftpgetput: add comment about EPSV (extended PASV).
Fix bug where we were using lstat instead of stat.
Added many TODOs.

16 years agocopy_file: handle "cp /dev/foo file" (almost) compatibly to coreutils.
Denis Vlasenko [Fri, 28 Mar 2008 17:49:31 +0000 (17:49 -0000)]
copy_file: handle "cp /dev/foo file" (almost) compatibly to coreutils.
(almost because we do not copy mode, which is probably wasn't intended).
+61 bytes.

16 years agofbsplash: move to /sbin; small shrink
Denis Vlasenko [Fri, 28 Mar 2008 11:17:35 +0000 (11:17 -0000)]
fbsplash: move to /sbin; small shrink

function                                             old     new   delta
fb_drawprogressbar                                   413     423     +10
fbsplash_main                                       1146    1121     -25

16 years agofix a few stray unguarded strdup's
Denis Vlasenko [Fri, 28 Mar 2008 02:24:59 +0000 (02:24 -0000)]
fix a few stray unguarded strdup's

16 years agowhitespace fixes
Denis Vlasenko [Fri, 28 Mar 2008 01:00:09 +0000 (01:00 -0000)]
whitespace fixes

16 years agomdev: plug a few memory and fd leaks; simplify code a bit
Denis Vlasenko [Thu, 27 Mar 2008 22:45:44 +0000 (22:45 -0000)]
mdev: plug a few memory and fd leaks; simplify code a bit

16 years agomdev: add testsuite entry
Denis Vlasenko [Thu, 27 Mar 2008 20:49:26 +0000 (20:49 -0000)]
mdev: add testsuite entry

16 years agoopenvt: fix gross mismatch between us and "standard" openvt.
Denis Vlasenko [Thu, 27 Mar 2008 16:26:35 +0000 (16:26 -0000)]
openvt: fix gross mismatch between us and "standard" openvt.
  standard one even has different syntax!
  std: "openvt -c 12", we: "openvt 12"
  std: "openvt top", we: complain that "top" is not a number.
openvt: implement -c -w -s (-l -f -v are also accepted but ingnored)

openvt_main                                          188     343    +155
vfork_child                                            -      67     +67
not_vt_fd                                              -      23     +23
packed_usage                                       23932   23952     +20
------------------------------------------------------------------------------
(add/remove: 2/0 grow/shrink: 2/0 up/down: 265/0)             Total: 265 bytes
   text    data     bss     dec     hex filename
 801344     641    7380  809365   c5995 busybox_old
 801617     641    7380  809638   c5aa6 busybox_unstripped

16 years agofbsplash: support this usage:
Denis Vlasenko [Thu, 27 Mar 2008 13:14:29 +0000 (13:14 -0000)]
fbsplash: support this usage:

mkfifo cmd_pipe
fbsplash -f cmd_pipe .... &
...
echo 33 >cmd_pipe
...
echo 66 >cmd_pipe

Code size: fbsplash_main +116 bytes :(

16 years agofbsplash: fix broken handling of buffered case:
Denis Vlasenko [Wed, 26 Mar 2008 20:06:24 +0000 (20:06 -0000)]
fbsplash: fix broken handling of buffered case:
"{echo 45; echo 33; } | { sleep 1; fbsplash -f - ...; }"

function                                             old     new   delta
fb_drawprogressbar                                     -     413    +413
xmalloc_fgetline                                       -      46     +46
xmalloc_reads                                        184     183      -1
xmalloc_getline                                       46       -     -46
fbsplash_main                                       1472    1030    -442
------------------------------------------------------------------------------
(add/remove: 2/1 grow/shrink: 0/2 up/down: 459/-489)          Total: -30 bytes
   text    data     bss     dec     hex filename
 801181     641    7380  809202   c58f2 busybox_old
 801151     641    7380  809172   c58d4 busybox_unstripped

16 years ago*: more uniform naming: s/xmalloc_getline/xmalloc_fgetline/
Denis Vlasenko [Wed, 26 Mar 2008 20:04:27 +0000 (20:04 -0000)]
*: more uniform naming: s/xmalloc_getline/xmalloc_fgetline/

16 years ago- add fbsplash and CONFIG_ASH_BASH_COMPAT to defconfig
Bernhard Reutner-Fischer [Wed, 26 Mar 2008 16:15:13 +0000 (16:15 -0000)]
- add fbsplash and CONFIG_ASH_BASH_COMPAT to defconfig

16 years agofbsplash: cosmetic comment and Config text fixes; rename .ini -> .cfg
Denis Vlasenko [Wed, 26 Mar 2008 15:12:11 +0000 (15:12 -0000)]
fbsplash: cosmetic comment and Config text fixes; rename .ini -> .cfg

16 years agofbsplash: shrink, better help text; inifile cannot specify image now;
Denis Vlasenko [Wed, 26 Mar 2008 14:57:49 +0000 (14:57 -0000)]
fbsplash: shrink, better help text; inifile cannot specify image now;
image can come from stdin

function                                             old     new   delta
packed_usage                                       23872   23932     +60
static.param_names                                     -      57     +57
fbsplash_main                                       1525    1472     -53
static.param_value                                   100       -    -100
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 1/1 up/down: 117/-153)          Total: -36 bytes
   text    data     bss     dec     hex filename
 801202     641    7380  809223   c5907 busybox_old
 801181     641    7380  809202   c58f2 busybox_unstripped

16 years agopatch: add support for -R. ~ +110 byte. By Pascal Bellard <pascal.bellard AT ads...
Denis Vlasenko [Wed, 26 Mar 2008 13:32:30 +0000 (13:32 -0000)]
patch: add support for -R. ~ +110 byte. By Pascal Bellard <pascal.bellard AT ads-lu.com>
fbsplash: new applet by Michele Sanges <michele.sanges AT otomelara.it

function                                             old     new   delta
fbsplash_main                                          -    1525   +1525
fb_drawfullrectangle                                   -     118    +118
static.param_value                                     -     100    +100
packed_usage                                       23776   23872     +96
applet_names                                        1843    1852      +9
applet_main                                         1120    1124      +4
read_line_input                                     3156    3158      +2
applet_nameofs                                       560     562      +2
applet_install_loc                                   140     141      +1
------------------------------------------------------------------------------
(add/remove: 3/0 grow/shrink: 6/0 up/down: 1857/0)           Total: 1857 bytes
   text    data     bss     dec     hex filename
 799233     641    7380  807254   c5156 busybox_old
 801202     641    7380  809223   c5907 busybox_unstripped

16 years agopatch: fix vda's thinko: we need to open new_filename.orig, always!
Denis Vlasenko [Tue, 25 Mar 2008 14:15:39 +0000 (14:15 -0000)]
patch: fix vda's thinko: we need to open new_filename.orig, always!
plug memory leak; add testsuite

patch_main                                          1009     988     -21

16 years agoash: support for && and || in [[ expr ]]; add testsuite checks
Denis Vlasenko [Tue, 25 Mar 2008 07:49:43 +0000 (07:49 -0000)]
ash: support for && and || in [[ expr ]]; add testsuite checks

16 years agoifupdown: support for %retries% (L. Gabriel Somlo <somlo AT cmu.edu>)
Denis Vlasenko [Tue, 25 Mar 2008 06:10:14 +0000 (06:10 -0000)]
ifupdown: support for %retries% (L. Gabriel Somlo <somlo AT cmu.edu>)

16 years agoudhcp: build fix for ppc kernel 2.4.36
Denis Vlasenko [Tue, 25 Mar 2008 06:04:58 +0000 (06:04 -0000)]
udhcp: build fix for ppc kernel 2.4.36

16 years agolpd: small shrink
Denis Vlasenko [Tue, 25 Mar 2008 06:03:19 +0000 (06:03 -0000)]
lpd: small shrink

lpd_main     761     747     -14

16 years agoash: comment about [[; code style fixes. No code changes.
Denis Vlasenko [Tue, 25 Mar 2008 05:51:41 +0000 (05:51 -0000)]
ash: comment about [[; code style fixes. No code changes.

16 years agohelp text shrinkage
Denis Vlasenko [Tue, 25 Mar 2008 03:17:04 +0000 (03:17 -0000)]
help text shrinkage

16 years agodate: even more of help text shrink
Denis Vlasenko [Tue, 25 Mar 2008 02:49:11 +0000 (02:49 -0000)]
date: even more of help text shrink

16 years agodate: make help text more understandable; small shrink
Denis Vlasenko [Tue, 25 Mar 2008 02:43:34 +0000 (02:43 -0000)]
date: make help text more understandable; small shrink

   text    data     bss     dec     hex filename
 799025     641    7380  807046   c5086 busybox_old
 799009     641    7380  807030   c5076 busybox_unstripped

16 years agoash: optional bash-like pattern subst and substring opts
Denis Vlasenko [Tue, 25 Mar 2008 01:17:40 +0000 (01:17 -0000)]
ash: optional bash-like pattern subst and substring opts
(by James Simmons <jsimmons AT infradead.org>)
TODO: write testsuite!

BASH_COMPAT off:
scanleft                                             101     262    +161
subevalvar                                           346     335     -11
BASH_COMPAT on:
subevalvar                                           346    1397   +1051
scanleft                                             101     262    +161
readtoken1                                          2739    2807     +68
cmdputs                                              397     399      +2
static.vstype                                         64      48     -16
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/1 up/down: 1282/-16)         Total: 1266 bytes

16 years agoash: add read -u; fix read -t and read -n; add testsuite entries.
Denis Vlasenko [Tue, 25 Mar 2008 00:07:12 +0000 (00:07 -0000)]
ash: add read -u; fix read -t and read -n; add testsuite entries.

16 years agolpd: debugging by Vladimir: he found vda's breakage (trashed s[0])!
Denis Vlasenko [Mon, 24 Mar 2008 21:19:51 +0000 (21:19 -0000)]
lpd: debugging by Vladimir: he found vda's breakage (trashed s[0])!

16 years agodiff: add testsuite entry for it
Denis Vlasenko [Mon, 24 Mar 2008 20:33:47 +0000 (20:33 -0000)]
diff: add testsuite entry for it

16 years agodiff: improve comments (no code chages)
Denis Vlasenko [Mon, 24 Mar 2008 18:40:32 +0000 (18:40 -0000)]
diff: improve comments (no code chages)

16 years agopatch: support for patches without dates and generated with -U1; shrink
Denis Vlasenko [Mon, 24 Mar 2008 18:18:03 +0000 (18:18 -0000)]
patch: support for patches without dates and generated with -U1; shrink

function                                             old     new   delta
extract_filename                                       -      92     +92
extract_filename_and_free_line                        70       -     -70
patch_main                                          1096    1009     -87
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 0/1 up/down: 92/-157)           Total: -65 bytes

16 years agodiff: exclude D_EMPTY code if there is no support for -r
Denis Vlasenko [Mon, 24 Mar 2008 16:55:13 +0000 (16:55 -0000)]
diff: exclude D_EMPTY code if there is no support for -r

function                                             old     new   delta
diffreg                                             1808    1825     +17
files_differ                                         189     166     -23

16 years agodiff: fix small bug; don't make a copy for "/dev/null" case
Denis Vlasenko [Mon, 24 Mar 2008 16:28:47 +0000 (16:28 -0000)]
diff: fix small bug; don't make a copy for "/dev/null" case

16 years agodiff: reordering and renaming of variables
Denis Vlasenko [Mon, 24 Mar 2008 16:19:21 +0000 (16:19 -0000)]
diff: reordering and renaming of variables

function                                             old     new   delta
diff_main                                            843     848      +5
get_recursive_dirlist                                177     180      +3
add_to_dirlist                                        64      66      +2
change                                               329     326      -3
files_differ                                         182     176      -6
diffreg                                             1823    1808     -15
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/3 up/down: 10/-24)            Total: -14 bytes

16 years agodiff: make a few variables local
Denis Vlasenko [Mon, 24 Mar 2008 15:04:24 +0000 (15:04 -0000)]
diff: make a few variables local

function                                             old     new   delta
diffreg                                             1844    1823     -21

16 years agodiff: make it work on pipes etc (needed for kernel compile)
Denis Vlasenko [Mon, 24 Mar 2008 14:44:59 +0000 (14:44 -0000)]
diff: make it work on pipes etc (needed for kernel compile)

function                                             old     new   delta
get_recursive_dirlist                                  -     177    +177
make_temp                                              -     144    +144
diffreg                                             1818    1844     +26
files_differ                                         175     182      +7
diff_main                                            842     843      +1
get_dir                                              177       -    -177
------------------------------------------------------------------------------
(add/remove: 2/1 grow/shrink: 3/0 up/down: 355/-177)          Total: 178 bytes

16 years agodiff: shrink
Denis Vlasenko [Mon, 24 Mar 2008 14:44:20 +0000 (14:44 -0000)]
diff: shrink

function                                             old     new   delta
check                                                678    1607    +929
files_differ                                           -     175    +175
do_diff                                              436     433      -3
asciifile                                             94      90      -4
print_only                                            23      16      -7
diff_main                                            868     842     -26
prepare                                              339     301     -38
print_status                                         316     178    -138
diffreg                                             2993    1818   -1175
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 1/7 up/down: 1104/-1391)       Total: -287 bytes

16 years ago*: whitespace fixes, no code changes
Denis Vlasenko [Mon, 24 Mar 2008 02:18:03 +0000 (02:18 -0000)]
*: whitespace fixes, no code changes

16 years agolpr: add more accurate comments
Denis Vlasenko [Mon, 24 Mar 2008 02:05:58 +0000 (02:05 -0000)]
lpr: add more accurate comments
*: trailing whitespace removal

16 years agolpd: much safer against malicious input. Does not fork anymore,
Denis Vlasenko [Mon, 24 Mar 2008 01:52:52 +0000 (01:52 -0000)]
lpd: much safer against malicious input. Does not fork anymore,
as this is not needed.

16 years agolpd: fix OOM vulnerability (was eating arbitrarily large commands)
Denis Vlasenko [Mon, 24 Mar 2008 00:04:42 +0000 (00:04 -0000)]
lpd: fix OOM vulnerability (was eating arbitrarily large commands)

16 years agolpd: maintainer's update: now with spool helpers
Denis Vlasenko [Sun, 23 Mar 2008 23:40:18 +0000 (23:40 -0000)]
lpd: maintainer's update: now with spool helpers

function                                             old     new   delta
exec_helper                                            -     227    +227
sane                                                  66     117     +51
packed_usage                                       23806   23828     +22
lpd_main                                             486     504     +18
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 3/0 up/down: 318/0)             Total: 318 bytes

16 years agopatch: shrink by Pascal Bellard <pascal.bellard AT ads-lu.com> (-80 bytes)
Denis Vlasenko [Sun, 23 Mar 2008 22:55:25 +0000 (22:55 -0000)]
patch: shrink by Pascal Bellard <pascal.bellard AT ads-lu.com> (-80 bytes)
*: removal of #include <getopt.h>

16 years agopscan: fix a typo in help text
Denis Vlasenko [Sun, 23 Mar 2008 18:44:59 +0000 (18:44 -0000)]
pscan: fix a typo in help text

16 years agopscan: add -c, -b: report closed, blocked ports
Denis Vlasenko [Sun, 23 Mar 2008 14:46:14 +0000 (14:46 -0000)]
pscan: add -c, -b: report closed, blocked ports

16 years agotail: fix fallout from tail -c optimization
Denis Vlasenko [Sun, 23 Mar 2008 03:28:40 +0000 (03:28 -0000)]
tail: fix fallout from tail -c optimization

16 years agobump version to 1.11.0.svn
Denis Vlasenko [Sat, 22 Mar 2008 17:46:43 +0000 (17:46 -0000)]
bump version to 1.11.0.svn

16 years agotaskset: fix false failure in testsuite
Denis Vlasenko [Sat, 22 Mar 2008 17:46:16 +0000 (17:46 -0000)]
taskset: fix false failure in testsuite

16 years agowebpage: typo fix
Denis Vlasenko [Fri, 21 Mar 2008 21:22:24 +0000 (21:22 -0000)]
webpage: typo fix

16 years agoBump version to 1.10.0 and announce it on website. 1_10_0
Denis Vlasenko [Fri, 21 Mar 2008 20:50:37 +0000 (20:50 -0000)]
Bump version to 1.10.0 and announce it on website.

16 years agoupdate defconfig
Denis Vlasenko [Fri, 21 Mar 2008 20:37:16 +0000 (20:37 -0000)]
update defconfig

16 years agowebsite: fix double include of menubar
Denis Vlasenko [Fri, 21 Mar 2008 20:06:42 +0000 (20:06 -0000)]
website: fix double include of menubar

16 years agowebpage: fix English
Denis Vlasenko [Fri, 21 Mar 2008 18:52:18 +0000 (18:52 -0000)]
webpage: fix English

16 years agowebsite: announce stable point releases
Denis Vlasenko [Fri, 21 Mar 2008 18:41:21 +0000 (18:41 -0000)]
website: announce stable point releases

16 years ago*: fix build problems found with randomconfig
Denis Vlasenko [Fri, 21 Mar 2008 18:29:01 +0000 (18:29 -0000)]
*: fix build problems found with randomconfig

16 years agoscripts/bb_release: release script (I nearly lost it last time)
Denis Vlasenko [Fri, 21 Mar 2008 09:56:19 +0000 (09:56 -0000)]
scripts/bb_release: release script (I nearly lost it last time)
website: update links to latest releases

16 years ago*: use fopen_or_warn in few more places
Denis Vlasenko [Thu, 20 Mar 2008 21:19:35 +0000 (21:19 -0000)]
*: use fopen_or_warn in few more places

16 years agolet top build without TERMIOS enabled
Paul Fox [Thu, 20 Mar 2008 16:05:02 +0000 (16:05 -0000)]
let top build without TERMIOS enabled

16 years agotermios can be used by either top or more.
Paul Fox [Thu, 20 Mar 2008 16:04:36 +0000 (16:04 -0000)]
termios can be used by either top or more.

16 years agoinetd: use change_identity().
Denis Vlasenko [Thu, 20 Mar 2008 15:12:58 +0000 (15:12 -0000)]
inetd: use change_identity().
libbb: shrink our internal initgroups().
httpd: remove stray 'else' and 'index_page = "index.html"'

function                                             old     new   delta
httpd_main                                           750     743      -7
inetd_main                                          2033    2011     -22
bb_internal_initgroups                               251     228     -23
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-52)             Total: -52 bytes

16 years agosmall NOMMU fixes
Denis Vlasenko [Thu, 20 Mar 2008 14:04:30 +0000 (14:04 -0000)]
small NOMMU fixes

16 years agohdparm: do not lie about supporting -q (quiet)
Denis Vlasenko [Thu, 20 Mar 2008 13:44:50 +0000 (13:44 -0000)]
hdparm: do not lie about supporting -q (quiet)
hdparm: interpret_standby() shrink
hdparm: make HDIO_GET/SET_QDMA #ifdef more complete
 (by Joe Krahn <krahn AT niehs.nih.gov>)

function                                             old     new   delta
packed_usage                                       23798   23776     -22
process_dev                                         5342    5315     -27

16 years agogcc compat fix and warning suppression
Denis Vlasenko [Thu, 20 Mar 2008 13:13:09 +0000 (13:13 -0000)]
gcc compat fix and warning suppression
by Joe Krahn <krahn AT niehs.nih.gov>

16 years agoudhcp: fix wrong order of args here: index_in_strings(opt, dhcp_option_strings);
Denis Vlasenko [Thu, 20 Mar 2008 12:47:01 +0000 (12:47 -0000)]
udhcp: fix wrong order of args here: index_in_strings(opt, dhcp_option_strings);
code shrink while at it:

function                                             old     new   delta
read_config                                          406     323     -83

16 years agotftpd: small trivial shrink
Denis Vlasenko [Wed, 19 Mar 2008 23:37:32 +0000 (23:37 -0000)]
tftpd: small trivial shrink

tftpd_main                                           502     488     -14

16 years agodie_if_bad_username: shrink: 88 -> 77 bytes
Denis Vlasenko [Wed, 19 Mar 2008 23:25:00 +0000 (23:25 -0000)]
die_if_bad_username: shrink:  88 -> 77 bytes

16 years ago...and actually adding new file now...
Denis Vlasenko [Wed, 19 Mar 2008 23:15:55 +0000 (23:15 -0000)]
...and actually adding new file now...

16 years agoadduser/addgroup: check username for invalid chars
Denis Vlasenko [Wed, 19 Mar 2008 23:15:26 +0000 (23:15 -0000)]
adduser/addgroup: check username for invalid chars
(by Tito <farmatito AT tiscali.it>). +129 bytes when enabled.

16 years ago*: s/BB_SIGS_FATAL/BB_FATAL_SIGS/ (latter proved easier to remember)
Denis Vlasenko [Wed, 19 Mar 2008 19:38:46 +0000 (19:38 -0000)]
*: s/BB_SIGS_FATAL/BB_FATAL_SIGS/ (latter proved easier to remember)
top: fix "top </dev/null" case (by Cristian Ionescu-Idbohrn)

16 years agoifupdown: make it NOMMU-capable
Denis Vlasenko [Wed, 19 Mar 2008 16:24:17 +0000 (16:24 -0000)]
ifupdown: make it NOMMU-capable

16 years agotftpd: fix download: we must change user AFTER bind
Denis Vlasenko [Wed, 19 Mar 2008 13:24:13 +0000 (13:24 -0000)]
tftpd: fix download: we must change user AFTER bind

tftp_protocol                                       1466    1468      +2

16 years agotftpd: options -c (allow _new_ files to be uploaded) and -u USER
Denis Vlasenko [Wed, 19 Mar 2008 13:07:00 +0000 (13:07 -0000)]
tftpd: options -c (allow _new_ files to be uploaded) and -u USER

function                                             old     new   delta
tftp_protocol                                       1316    1466    +150
packed_usage                                       23774   23798     +24
tftpd_main                                           509     502      -7
tftp_main                                            311     252     -59
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/2 up/down: 174/-66)           Total: 108 bytes
   text    data     bss     dec     hex filename
 797700     641    7380  805721   c4b59 busybox_old
 797833     641    7380  805854   c4bde busybox_unstripped

16 years agotftp(d): a bit more verbose error reporting
Denis Vlasenko [Wed, 19 Mar 2008 09:43:50 +0000 (09:43 -0000)]
tftp(d): a bit more verbose error reporting

16 years agotftpd: make it emit error packets
Denis Vlasenko [Wed, 19 Mar 2008 05:00:05 +0000 (05:00 -0000)]
tftpd: make it emit error packets
telnetd: use login always, not "sometimes login, sometimes shell"

   text    data     bss     dec     hex filename
 797612     641    7380  805633   c4b01 busybox_old
 797695     641    7380  805716   c4b54 busybox_unstripped

16 years agounlzma: shrink by Pascal Bellard <pascal.bellard AT ads-lu.com>
Denis Vlasenko [Tue, 18 Mar 2008 03:13:25 +0000 (03:13 -0000)]
unlzma: shrink by Pascal Bellard <pascal.bellard AT ads-lu.com>

16 years agomount: #ifdef out MOUNT_LABEL code parts if it is not selected
Denis Vlasenko [Tue, 18 Mar 2008 01:44:52 +0000 (01:44 -0000)]
mount: #ifdef out MOUNT_LABEL code parts if it is not selected

16 years agopatch: don't trash permissions of patched file
Denis Vlasenko [Tue, 18 Mar 2008 01:38:04 +0000 (01:38 -0000)]
patch: don't trash permissions of patched file

16 years agotftpd: make open() check r/w permissions instead of doing it ourself.
Denis Vlasenko [Tue, 18 Mar 2008 01:13:11 +0000 (01:13 -0000)]
tftpd: make open() check r/w permissions instead of doing it ourself.
Add -r "prohibit upload" opt for those lazy people who run tftpd as root.
-40 bytes.

16 years agotftpd: fix bugs spotted by Vladimir
Denis Vlasenko [Tue, 18 Mar 2008 00:11:46 +0000 (00:11 -0000)]
tftpd: fix bugs spotted by Vladimir

16 years agoinit: do not close all descriptors > 2. We were doing it - sometimes.
Denis Vlasenko [Mon, 17 Mar 2008 22:01:42 +0000 (22:01 -0000)]
init: do not close all descriptors > 2. We were doing it - sometimes.
Good choices are "do it, always" or "don't do it". Second is smaller.

16 years agoremove alarm() calls which were functioning as a primitive
Paul Fox [Mon, 17 Mar 2008 15:28:07 +0000 (15:28 -0000)]
remove alarm() calls which were functioning as a primitive
watchdog function, presumably to catch infinite loop bugs.
(control-C can do the same thing, and the alarms were too short in
any case.)  also, switch to sigsetjmp/siglongjmp in order to allow
repeated use of control-C -- otherwise it works once, then not again.

16 years agoinit: do not use bb_sanitize_stdio(), "/dev/null" may be missing (yet)
Denis Vlasenko [Mon, 17 Mar 2008 13:26:51 +0000 (13:26 -0000)]
init: do not use bb_sanitize_stdio(), "/dev/null" may be missing (yet)

16 years agohttpd: small fixlet for POST upload - skip
Denis Vlasenko [Mon, 17 Mar 2008 12:58:19 +0000 (12:58 -0000)]
httpd: small fixlet for POST upload - skip
whitespace between "Content-length:" and number

16 years agoremove extra spaces in help text; delete duplicate #define
Denis Vlasenko [Mon, 17 Mar 2008 09:37:24 +0000 (09:37 -0000)]
remove extra spaces in help text; delete duplicate #define

16 years agobrctl: eliminate stray data object
Denis Vlasenko [Mon, 17 Mar 2008 09:33:45 +0000 (09:33 -0000)]
brctl: eliminate stray data object
brctl: use constant fd to reduce parameter passing
runsvdir: do not use data/bss
od: reuse bb_argv_dash
last: do not go into endless loop on read error
mount: make it not fail scripts/find_bad_common_bufsiz check
dc: add INIT_G() (no-op for dc, but we want uniform usage of "G trick")

function                                             old     new   delta
runsvdir_main                                       1646    1672     +26
set_pgrp                                               1       -      -1
exitsoon                                               1       -      -1
check                                                679     678      -1
svnum                                                  4       -      -4
svdir                                                  4       -      -4
sv                                                     4       -      -4
stamplog                                               4       -      -4
rploglen                                               4       -      -4
rplog                                                  4       -      -4
mount_main                                           995     988      -7
static.default_file_list                               8       -      -8
pfd                                                    8       -      -8
logpipe                                                8       -      -8
static.info                                           20       -     -20
brctl_main                                           767     739     -28
------------------------------------------------------------------------------
(add/remove: 0/12 grow/shrink: 1/3 up/down: 26/-106)          Total: -80 bytes
   text    data     bss     dec     hex filename
 793327     662    7412  801401   c3a79 busybox_old
 793329     641    7372  801342   c3a3e busybox_unstripped

16 years ago*: fix various kinds of damage to letter 'c' in Arkadiusz Mickiewicz' surname.
Denis Vlasenko [Mon, 17 Mar 2008 09:29:43 +0000 (09:29 -0000)]
*: fix various kinds of damage to letter 'c' in Arkadiusz Mickiewicz' surname.
chrt,taskset,dc,eject: shrink
crontab: call "vi" with just name, no path
watchdog: intercept all fatal signals

function                                             old     new   delta
xstrtoull_range                                        -      35     +35
static.sg_commands                                     -      18     +18
packed_usage                                       23698   23712     +14
watchdog_main                                        148     151      +3
crontab_main                                         637     638      +1
base                                                   1       -      -1
static.ps                                              4       -      -4
pointer                                                4       -      -4
stack_machine                                         99      92      -7
run_command                                          273     260     -13
eject_main                                           360     343     -17
static.C                                              30      12     -18
ptok                                                  61      38     -23
xstrtol_range                                         27       -     -27
get_token                                             35       -     -35
taskset_main                                         586     550     -36
chrt_main                                            411     372     -39
dc_main                                              158     117     -41
time_main                                           1127    1037     -90
------------------------------------------------------------------------------
(add/remove: 2/5 grow/shrink: 3/9 up/down: 71/-355)          Total: -284 bytes
   text    data     bss     dec     hex filename
 793680     662    7420  801762   c3be2 busybox_old
 793327     662    7412  801401   c3a79 busybox_unstripped

16 years agovolume_id: disable detection routines which are not setting label and uuid anyway
Denis Vlasenko [Mon, 17 Mar 2008 09:25:05 +0000 (09:25 -0000)]
volume_id: disable detection routines which are not setting label and uuid anyway

function                                             old     new   delta
static.warn                                            1       -      -1
static.drive_name_string                              14      12      -2
static.offsets                                         8       -      -8
static.sectors                                        10       -     -10
fs2                                                   60      48     -12
raid2                                                 16       -     -16
uuidcache_init                                       704     677     -27
raid1                                                 32       -     -32
volume_id_probe_all                                  198     158     -40
volume_id_probe_lvm1                                  58       -     -58
volume_id_probe_highpoint_37x_raid                    63       -     -63
volume_id_probe_hpfs                                  67       -     -67
volume_id_probe_minix                                 74       -     -74
volume_id_probe_lvm2                                  78       -     -78
volume_id_probe_silicon_medley_raid                   97       -     -97
volume_id_probe_via_raid                             101       -    -101
volume_id_probe_highpoint_45x_raid                   104       -    -104
volume_id_probe_nvidia_raid                          108       -    -108
volume_id_probe_lsi_mega_raid                        108       -    -108
volume_id_probe_intel_software_raid                  108       -    -108
volume_id_probe_ufs                                  126       -    -126
volume_id_probe_promise_fasttrack_raid               144       -    -144
------------------------------------------------------------------------------
(add/remove: 0/18 grow/shrink: 0/4 up/down: 0/-1384)        Total: -1384 bytes
   text    data     bss     dec     hex filename
 794244     662    7420  802326   c3e16 busybox_old
 792698     662    7420  800780   c380c busybox_unstripped

16 years agovolude_id: remove unused fields and functions which were setting them
Denis Vlasenko [Mon, 17 Mar 2008 09:21:26 +0000 (09:21 -0000)]
volude_id: remove unused fields and functions which were setting them

function                                             old     new   delta
uuidcache_init                                       567     704    +137
findfs_main                                            -     125    +125
packed_usage                                       23662   23694     +32
static.drive_name_string                               -      14     +14
applet_names                                        1815    1822      +7
applet_main                                         1104    1108      +4
volume_id_open_node                                   35      38      +3
applet_nameofs                                       552     554      +2
get_devname_from_label                                78      79      +1
applet_install_loc                                   138     139      +1
volume_id_set_label_unicode16                         31      27      -4
volume_id_set_label_string                            74      70      -4
get_devname_from_uuid                                 63      59      -4
fs1                                                   12       8      -4
volume_id_set_unicode16                              209     202      -7
volume_id_free_buffer                                 71      56     -15
free_volume_id                                        52      37     -15
volume_id_probe_luks                                  97      79     -18
volume_id_set_usage_part                              21       -     -21
volume_id_probe_ufs                                  148     126     -22
volume_id_probe_lsi_mega_raid                        131     108     -23
volume_id_probe_highpoint_45x_raid                   127     104     -23
volume_id_probe_highpoint_37x_raid                    87      63     -24
volume_id_set_usage                                   28       -     -28
volume_id_probe_romfs                                121      93     -28
volume_id_set_label_raw                               30       -     -30
volume_id_probe_promise_fasttrack_raid               174     144     -30
volume_id_set_uuid                                   373     342     -31
volume_id_probe_xfs                                  122      91     -31
volume_id_probe_jfs                                  138     107     -31
volume_id_probe_ocfs2                                139     107     -32
volume_id_probe_lvm1                                  90      58     -32
volume_id_probe_cramfs                               106      63     -43
volume_id_probe_via_raid                             145     101     -44
volume_id_probe_intel_software_raid                  153     108     -45
volume_id_probe_minix                                121      74     -47
volume_id_probe_udf                                  682     632     -50
volume_id_probe_nvidia_raid                          158     108     -50
volume_id_probe_lvm2                                 128      78     -50
volume_id_probe_hpfs                                 117      67     -50
volume_id_probe_ext                                  143      93     -50
volume_id_probe_linux_raid                           191     139     -52
volume_id_probe_sysv                                 244     187     -57
volume_id_probe_silicon_medley_raid                  158      97     -61
usage_to_string                                       64       -     -64
volume_id_probe_linux_swap                           263     198     -65
volume_id_get_buffer                                 372     307     -65
volume_id_probe_iso9660                              412     332     -80
volume_id_probe_hfs_hfsplus                          888     806     -82
volume_id_probe_ntfs                                 396     294    -102
volume_id_probe_vfat                                 980     872    -108
volume_id_probe_reiserfs                             417     268    -149
dev_get_major_minor                                  175       -    -175
uuidcache_check_device                               692     499    -193
volume_id_probe_mac_partition_map                    697       -    -697
------------------------------------------------------------------------------
(add/remove: 2/6 grow/shrink: 8/39 up/down: 326/-2836)      Total: -2510 bytes
   text    data     bss     dec     hex filename
 797220     662    7420  805302   c49b6 busybox_old
 794244     662    7420  802326   c3e16 busybox_unstripped

16 years agoselinux/*: -Wunused-parameter fixes
Denis Vlasenko [Mon, 17 Mar 2008 09:19:26 +0000 (09:19 -0000)]
selinux/*: -Wunused-parameter fixes
runsv: make it NOMMU-capable

function                                             old     new   delta
startservice                                         291     313     +22
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/0 up/down: 22/0)               Total: 22 bytes

16 years agosvn add/svn rm to actually move tcp/udpsvd...
Denis Vlasenko [Mon, 17 Mar 2008 09:17:27 +0000 (09:17 -0000)]
svn add/svn rm to actually move tcp/udpsvd...

16 years ago*: mode tcp/udpsvd to networking, delete ipsvd/*
Denis Vlasenko [Mon, 17 Mar 2008 09:13:22 +0000 (09:13 -0000)]
*: mode tcp/udpsvd to networking, delete ipsvd/*
*/Config.in: fixes to text
svlogd: make it NOMMU capable

function                                             old     new   delta
processorstart                                       378     420     +42
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/0 up/down: 42/0)               Total: 42 bytes
   text    data     bss     dec     hex filename
 797153     662    7420  805235   c4973 busybox_old
 797196     662    7420  805278   c499e busybox_unstripped

16 years agotftpd: new applet (mostly using existing code for tftp)
Denis Vlasenko [Mon, 17 Mar 2008 09:10:39 +0000 (09:10 -0000)]
tftpd: new applet (mostly using existing code for tftp)

function                                             old     new   delta
tftp_protocol                                          -    1173   +1173
tftpd_main                                             -     500    +500
tftp_option_get                                        -     102    +102
packed_usage                                       23650   23662     +12
applet_names                                        1809    1815      +6
applet_main                                         1100    1104      +4
applet_nameofs                                       550     552      +2
tftp_main                                            302     301      -1
get_nport                                             32       -     -32
tftp                                                1172       -   -1172
------------------------------------------------------------------------------
(add/remove: 3/2 grow/shrink: 4/1 up/down: 1799/-1205)        Total: 594 bytes
   text    data     bss     dec     hex filename
 796479     662    7420  804561   c46d1 busybox_old
 797153     662    7420  805235   c4973 busybox_unstripped

16 years ago*: shrink: use Vladimir's "o+" specifier instead of xatou(opt_param)
Denis Vlasenko [Mon, 17 Mar 2008 09:09:09 +0000 (09:09 -0000)]
*: shrink: use Vladimir's "o+" specifier instead of xatou(opt_param)

function                                             old     new   delta
getopt32                                            1370    1385     +15
sulogin_main                                         490     494      +4
realpath_main                                         84      86      +2
sleep_main                                            76      77      +1
mt_main                                              256     257      +1
printenv_main                                         75      74      -1
fdformat_main                                        546     545      -1
usleep_main                                           44      42      -2
setlogcons_main                                       77      75      -2
ed_main                                             2654    2649      -5
deallocvt_main                                        69      64      -5
addgroup_main                                        373     368      -5
mkfs_minix_main                                     2989    2982      -7
tail_main                                           1221    1213      -8
sv_main                                             1254    1241     -13
du_main                                              348     328     -20
tftp_main                                            325     302     -23
split_main                                           581     558     -23
nc_main                                             1000     977     -23
diff_main                                            891     868     -23
arping_main                                         1797    1770     -27
ls_main                                              893     847     -46
od_main                                             2797    2750     -47
readprofile_main                                    1944    1895     -49
tcpudpsvd_main                                      1973    1922     -51
udhcpc_main                                         2590    2513     -77
grep_main                                            824     722    -102
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 5/22 up/down: 23/-560)         Total: -537 bytes
   text    data     bss     dec     hex filename
 796973     658    7428  805059   c48c3 busybox_old
 796479     662    7420  804561   c46d1 busybox_unstripped

16 years ago*: shrink by using [f]open_or_warn_stdin where appropriate
Denis Vlasenko [Mon, 17 Mar 2008 09:07:36 +0000 (09:07 -0000)]
*: shrink by using [f]open_or_warn_stdin where appropriate

function                                             old     new   delta
lsattr_main                                           62     143     +81
open_or_warn_stdin                                     -      36     +36
fclose_if_not_stdin                                   20      47     +27
xfopen_stdin                                           -      20     +20
tac_main                                             336     356     +20
cksum_main                                           249     259     +10
bb_argv_dash                                           -       8      +8
su_main                                              448     455      +7
cmp_main                                             630     633      +3
passwd_main                                         1072    1074      +2
uudecode_main                                        317     315      -2
text_yank                                            110     108      -2
handle_incoming_and_exit                            2653    2651      -2
flags                                                  5       1      -4
write_leases                                         235     230      -5
fopen_or_warn_stdin                                   48      42      -6
fold_main                                            648     642      -6
static.argv_dash                                       8       -      -8
sum_main                                             142     128     -14
tail_main                                           1237    1221     -16
sed_main                                             711     695     -16
cmp_xfopen_input                                      17       -     -17
bb_cat                                               113      96     -17
catv_main                                            328     306     -22
strings_main                                         457     434     -23
hash_file                                            298     274     -24
sum_file                                             353     325     -28
sort_main                                            904     859     -45
expand_main                                          736     686     -50
cut_main                                            1116    1065     -51
md5_sha1_sum_main                                    549     493     -56
lsattr_args                                           90       -     -90
read_stduu                                           408     255    -153
------------------------------------------------------------------------------
(add/remove: 3/3 grow/shrink: 7/20 up/down: 214/-657)        Total: -443 bytes
   text    data     bss     dec     hex filename
 797417     658    7428  805503   c4a7f busybox_old
 796973     658    7428  805059   c48c3 busybox_unstripped

16 years agoclean up TODO file. No real code changes.
Denis Vlasenko [Mon, 17 Mar 2008 09:05:21 +0000 (09:05 -0000)]
clean up TODO file. No real code changes.

16 years ago*: fix fallout from -Wunused-parameter
Denis Vlasenko [Mon, 17 Mar 2008 09:04:04 +0000 (09:04 -0000)]
*: fix fallout from -Wunused-parameter

function                                             old     new   delta
bbunpack                                             358     366      +8
passwd_main                                         1070    1072      +2
handle_incoming_and_exit                            2651    2653      +2
getpty                                                88      86      -2
script_main                                          975     972      -3
inetd_main                                          2036    2033      -3
dname_enc                                            377     373      -4
make_new_session                                     474     462     -12
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/5 up/down: 12/-24)            Total: -12 bytes
   text    data     bss     dec     hex filename
 797429     658    7428  805515   c4a8b busybox_old
 797417     658    7428  805503   c4a7f busybox_unstripped

16 years agodnsd: properly set _src_ IP:port on outgoing UDP packets
Denis Vlasenko [Mon, 17 Mar 2008 09:02:21 +0000 (09:02 -0000)]
dnsd: properly set _src_ IP:port on outgoing UDP packets

function                                             old     new   delta
send_to_from                                           -     258    +258
dnsd_main                                           1500    1568     +68
interrupt                                             17      19      +2
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 2/0 up/down: 328/0)             Total: 328 bytes
   text    data     bss     dec     hex filename
 797101     658    7428  805187   c4943 busybox_old
 797429     658    7428  805515   c4a8b busybox_unstripped

16 years ago*: add -Wunused-parameter; fix resulting breakage
Denis Vlasenko [Mon, 17 Mar 2008 09:00:54 +0000 (09:00 -0000)]
*: add -Wunused-parameter; fix resulting breakage

function                                             old     new   delta
procps_scan                                         1265    1298     +33
aliascmd                                             278     283      +5
parse_file_cmd                                       116     120      +4
dname_enc                                            373     377      +4
setcmd                                                90      93      +3
execcmd                                               57      60      +3
count_lines                                           72      74      +2
process_command_subs                                 340     339      -1
test_main                                            409     407      -2
mknod_main                                           179     177      -2
handle_incoming_and_exit                            2653    2651      -2
argstr                                              1312    1310      -2
shiftcmd                                             131     128      -3
exitcmd                                               46      43      -3
dotcmd                                               297     294      -3
breakcmd                                              86      83      -3
evalpipe                                             353     349      -4
evalcommand                                         1180    1176      -4
evalcmd                                              109     105      -4
send_tree                                            374     369      -5
mkfifo_main                                           82      77      -5
evalsubshell                                         152     147      -5
typecmd                                               75      69      -6
letcmd                                                61      55      -6
add_cmd                                             1190    1183      -7
main                                                 891     883      -8
ash_main                                            1415    1407      -8
parse_stream                                        1377    1367     -10
alloc_procps_scan                                     55       -     -55
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 7/21 up/down: 54/-148)          Total: -94 bytes
   text    data     bss     dec     hex filename
 797195     658    7428  805281   c49a1 busybox_old
 797101     658    7428  805187   c4943 busybox_unstripped

16 years agofsck: shrink (we were passing around some params which were unused)
Denis Vlasenko [Mon, 17 Mar 2008 08:59:19 +0000 (08:59 -0000)]
fsck: shrink (we were passing around some params which were unused)

function                                             old     new   delta
fsck_main                                           1807    2256    +449
fsck_device                                          196     189      -7
create_fs_device                                     131     124      -7
wait_one                                             325     309     -16
wait_many                                             52      33     -19
free_instance                                         38       -     -38
packed_usage                                       23698   23650     -48
execute                                             2508    2402    -106
check_all                                            609       -    -609
------------------------------------------------------------------------------
(add/remove: 0/2 grow/shrink: 1/6 up/down: 449/-850)         Total: -401 bytes
   text    data     bss     dec     hex filename
 797604     658    7428  805690   c4b3a busybox_old
 797195     658    7428  805281   c49a1 busybox_unstripped

16 years agohelp text: regularize format, and shrink
Denis Vlasenko [Mon, 17 Mar 2008 08:55:44 +0000 (08:55 -0000)]
help text: regularize format, and shrink
getty: shrink, and improve comments
mount: OPT_ALL is superfluous, we already have OPT_a

function                                             old     new   delta
bcode                                                 47      25     -22
getty_main                                          2503    2349    -154
packed_usage                                       23928   23698    -230
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-406)           Total: -406 bytes
   text    data     bss     dec     hex filename
 798031     658    7428  806117   c4ce5 busybox_old
 797604     658    7428  805690   c4b3a busybox_unstripped

16 years agomount: plug a hole where FEATURE_MOUNT_HELPERS could allow execution
Denis Vlasenko [Mon, 17 Mar 2008 08:46:43 +0000 (08:46 -0000)]
mount: plug a hole where FEATURE_MOUNT_HELPERS could allow execution
of arbitrary command.

function                                             old     new   delta
mount_it_now                                         266     309     +43