oweals/gnunet.git
5 years agonote about assertion actually failing
Christian Grothoff [Tue, 19 Feb 2019 00:58:16 +0000 (01:58 +0100)]
note about assertion actually failing

5 years agodo not strictly require mq non-NULL, as peerinfo service might have died already
Christian Grothoff [Tue, 19 Feb 2019 00:57:19 +0000 (01:57 +0100)]
do not strictly require mq non-NULL, as peerinfo service might have died already

5 years agofix possibility of NULL result for empty database
Christian Grothoff [Tue, 19 Feb 2019 00:51:02 +0000 (01:51 +0100)]
fix possibility of NULL result for empty database

5 years agodo not use rps in consensus test
Christian Grothoff [Tue, 19 Feb 2019 00:50:06 +0000 (01:50 +0100)]
do not use rps in consensus test

5 years agounset XDG vars in test explicitly in case test is run by hand
Christian Grothoff [Tue, 19 Feb 2019 00:14:27 +0000 (01:14 +0100)]
unset XDG vars in test explicitly in case test is run by hand

5 years agoextra sanity check for #5582
Christian Grothoff [Tue, 19 Feb 2019 00:09:32 +0000 (01:09 +0100)]
extra sanity check for #5582

5 years agoclean up python logic a bit, remove duplicate print() calls when we have log calls
Christian Grothoff [Mon, 18 Feb 2019 23:49:26 +0000 (00:49 +0100)]
clean up python logic a bit, remove duplicate print() calls when we have log calls

5 years agocleaner py code, fix test_integration_disconnect.py.in by fixing erroneous patch
Christian Grothoff [Mon, 18 Feb 2019 23:35:44 +0000 (00:35 +0100)]
cleaner py code, fix test_integration_disconnect.py.in by fixing erroneous patch

5 years agorexxnor fix for string to digit
Christian Grothoff [Mon, 18 Feb 2019 09:17:45 +0000 (10:17 +0100)]
rexxnor fix for string to digit

5 years agoadd openssl.cnf
Schanzenbach, Martin [Sun, 17 Feb 2019 21:33:17 +0000 (22:33 +0100)]
add openssl.cnf

5 years agofix indentation
Christian Grothoff [Sun, 17 Feb 2019 19:27:10 +0000 (20:27 +0100)]
fix indentation

5 years agoMerge branch 'master' of git+ssh://gnunet.org/gnunet
Schanzenbach, Martin [Sun, 17 Feb 2019 19:21:53 +0000 (20:21 +0100)]
Merge branch 'master' of git+ssh://gnunet.org/gnunet

5 years agoattempt fix #5578
Schanzenbach, Martin [Sun, 17 Feb 2019 19:21:45 +0000 (20:21 +0100)]
attempt fix #5578

5 years agoguile 1.6.4 is an optional dependency
ng0 [Sun, 17 Feb 2019 15:26:10 +0000 (15:26 +0000)]
guile 1.6.4 is an optional dependency

5 years agoMerge branch 'master' of git+ssh://gnunet.org/gnunet
Schanzenbach, Martin [Sun, 17 Feb 2019 14:46:39 +0000 (15:46 +0100)]
Merge branch 'master' of git+ssh://gnunet.org/gnunet

5 years agofix path length
Schanzenbach, Martin [Sun, 17 Feb 2019 14:44:28 +0000 (15:44 +0100)]
fix path length

5 years agofilenames can exceed 128 bytes, even in testcases
Christian Grothoff [Sun, 17 Feb 2019 14:07:24 +0000 (15:07 +0100)]
filenames can exceed 128 bytes, even in testcases

5 years agofix 128
Christian Grothoff [Sun, 17 Feb 2019 14:02:43 +0000 (15:02 +0100)]
fix 128

5 years agoadd gnunet homebrew formula
Schanzenbach, Martin [Sun, 17 Feb 2019 10:26:16 +0000 (11:26 +0100)]
add gnunet homebrew formula

5 years agoMerge branch 'master' of gnunet.org:gnunet
ng0 [Sun, 17 Feb 2019 00:42:02 +0000 (00:42 +0000)]
Merge branch 'master' of gnunet.org:gnunet

5 years agoAUTHORS: Change bugtracker URL and change GPL3 to AGPL3
ng0 [Sun, 17 Feb 2019 00:36:11 +0000 (00:36 +0000)]
AUTHORS: Change bugtracker URL and change GPL3 to AGPL3

5 years agoAUTHORS: Add myself as netbsd maintainer
ng0 [Sun, 17 Feb 2019 00:35:05 +0000 (00:35 +0000)]
AUTHORS: Add myself as netbsd maintainer

5 years agoskip if timeout not installed
Schanzenbach, Martin [Sat, 16 Feb 2019 21:15:05 +0000 (22:15 +0100)]
skip if timeout not installed

5 years agoFlorian Weimer writes:
Christian Grothoff [Sat, 16 Feb 2019 20:19:23 +0000 (21:19 +0100)]
Florian Weimer writes:

 Christian Grothoff:

> I'm seeing some _very_ odd behavior with processes hanging on exit (?)
> with GNU libc 2.28-6 on Debian (amd64 threadripper).  This seems to
> happen at random (for random tests, with very low frequency!) in the
> GNUnet (Git master) testsuite when a child process is about to exit.

It looks like you call exit from a signal handler, see
src/util/scheduler.c:

/**
 * Signal handler called for signals that should cause us to shutdown.
 */
static void
sighandler_shutdown ()
{
  static char c;
  int old_errno = errno;        /* backup errno */

  if (getpid () != my_pid)
    exit (1);                   /* we have fork'ed since the signal handler was created,
                                 * ignore the signal, see https://gnunet.org/vfork discussion */
  GNUNET_DISK_file_write (GNUNET_DISK_pipe_handle
                          (shutdown_pipe_handle, GNUNET_DISK_PIPE_END_WRITE),
                          &c, sizeof (c));
  errno = old_errno;
}

In general, this results in undefined behavior because exit (unlike
_exit) is not an async-signal-safe function.

I suspect you either call the exit function while a fork is in progress,
or since you register this signal handler multiple times for different
signals:

  sh->shc_int = GNUNET_SIGNAL_handler_install (SIGINT,
                                               &sighandler_shutdown);
  sh->shc_term = GNUNET_SIGNAL_handler_install (SIGTERM,
                                                &sighandler_shutdown);

one call to exit might interrupt another call to exit if both signals
are delivered to the process.

The deadlock you see was introduced in commit
27761a1042daf01987e7d79636d0c41511c6df3c ("Refactor atfork handlers"),
first released in glibc 2.28.  The fork deadlock will be gone (in the
single-threaded case) if Debian updates to the current
release/2.28/master branch because we backported commit
60f80624257ef84eacfd9b400bda1b5a5e8e7816 ("nptl: Avoid fork handler lock
for async-signal-safe fork [BZ #24161]") there.

But this will not help you.  Even without the deadlock, I expect you
still experience some random corruption during exit, but it's going to
be difficult to spot.

Thanks,
Florian

5 years agofix another linker error
Schanzenbach, Martin [Sat, 16 Feb 2019 20:02:11 +0000 (21:02 +0100)]
fix another linker error

5 years agoMerge branch 'master' of git+ssh://gnunet.org/gnunet
Christian Grothoff [Sat, 16 Feb 2019 20:00:41 +0000 (21:00 +0100)]
Merge branch 'master' of git+ssh://gnunet.org/gnunet

5 years agofix assertion failure reported in #5578
Christian Grothoff [Sat, 16 Feb 2019 20:00:38 +0000 (21:00 +0100)]
fix assertion failure reported in #5578

5 years agomore logger
ng0 [Sat, 16 Feb 2019 18:53:08 +0000 (18:53 +0000)]
more logger

5 years agomore logging
ng0 [Sat, 16 Feb 2019 17:47:44 +0000 (17:47 +0000)]
more logging

5 years agognunet_testing.py.in: first set of logging
ng0 [Sat, 16 Feb 2019 17:32:44 +0000 (17:32 +0000)]
gnunet_testing.py.in: first set of logging

5 years agoadd debug output to py.in
Christian Grothoff [Sat, 16 Feb 2019 15:37:02 +0000 (16:37 +0100)]
add debug output to py.in

5 years agoadd logging
Christian Grothoff [Sat, 16 Feb 2019 15:33:03 +0000 (16:33 +0100)]
add logging

5 years agocast no longer required for modern curl
Christian Grothoff [Sat, 16 Feb 2019 14:38:15 +0000 (15:38 +0100)]
cast no longer required for modern curl

5 years agomake clang shut up about #5573
Christian Grothoff [Sat, 16 Feb 2019 09:43:17 +0000 (10:43 +0100)]
make clang shut up about #5573

5 years agoMerge branch 'master' of gnunet.org:gnunet
ng0 [Fri, 15 Feb 2019 22:49:45 +0000 (22:49 +0000)]
Merge branch 'master' of gnunet.org:gnunet

5 years agotext-only variant of svg logo
ng0 [Fri, 15 Feb 2019 22:49:29 +0000 (22:49 +0000)]
text-only variant of svg logo

5 years agofix some compiler warnings
Schanzenbach, Martin [Fri, 15 Feb 2019 20:16:37 +0000 (21:16 +0100)]
fix some compiler warnings

5 years agofix dist build
Schanzenbach, Martin [Fri, 15 Feb 2019 19:55:59 +0000 (20:55 +0100)]
fix dist build

5 years agofix macos build of dist tarball
Schanzenbach, Martin [Fri, 15 Feb 2019 19:30:00 +0000 (20:30 +0100)]
fix macos build of dist tarball

5 years agoMerge branch 'master' of gnunet.org:gnunet
ng0 [Fri, 15 Feb 2019 18:59:07 +0000 (18:59 +0000)]
Merge branch 'master' of gnunet.org:gnunet

5 years agoFix bug reported by schanzen@ where bootstrap is not enough for our python2.7 script.
ng0 [Fri, 15 Feb 2019 18:58:50 +0000 (18:58 +0000)]
Fix bug reported by schanzen@ where bootstrap is not enough for our python2.7 script.

5 years agodie dv.pc
Christian Grothoff [Fri, 15 Feb 2019 18:45:03 +0000 (19:45 +0100)]
die dv.pc

5 years agofix #5571
Christian Grothoff [Fri, 15 Feb 2019 17:19:00 +0000 (18:19 +0100)]
fix #5571

5 years agofix nat-auto port conflict
Christian Grothoff [Fri, 15 Feb 2019 13:22:42 +0000 (14:22 +0100)]
fix nat-auto port conflict

5 years agoskip instead of fail hard on testbed link failures in cadet tests
Christian Grothoff [Thu, 14 Feb 2019 22:54:52 +0000 (23:54 +0100)]
skip instead of fail hard on testbed link failures in cadet tests

5 years agofix build ats
Schanzenbach, Martin [Thu, 14 Feb 2019 18:24:27 +0000 (19:24 +0100)]
fix build ats

5 years agofix HAVE_MEMRCHR
Schanzenbach, Martin [Thu, 14 Feb 2019 18:12:12 +0000 (19:12 +0100)]
fix HAVE_MEMRCHR

5 years agoREADME: we are on python3.7 now
ng0 [Thu, 14 Feb 2019 17:00:36 +0000 (17:00 +0000)]
README: we are on python3.7 now

Signed-off-by: ng0 <ng0@n0.is>
5 years agoMerge branch 'master' of gnunet.org:gnunet
ng0 [Thu, 14 Feb 2019 16:41:21 +0000 (16:41 +0000)]
Merge branch 'master' of gnunet.org:gnunet

5 years agoSwitch to python3.7 (integration-tests incomplete), continue using python2.7 for...
ng0 [Thu, 14 Feb 2019 16:41:09 +0000 (16:41 +0000)]
Switch to python3.7 (integration-tests incomplete), continue using python2.7 for gnunet-qr with an incredible annoying workaround for autotools inability to deal with 2 major python versions at the same time

Signed-off-by: ng0 <ng0@n0.is>
5 years agoDCE
Christian Grothoff [Thu, 14 Feb 2019 10:26:51 +0000 (11:26 +0100)]
DCE

5 years agofix #3329
Christian Grothoff [Thu, 14 Feb 2019 10:03:56 +0000 (11:03 +0100)]
fix #3329

5 years agomystery solved?
Christian Grothoff [Thu, 14 Feb 2019 10:00:59 +0000 (11:00 +0100)]
mystery solved?

5 years agofix uninit e_hash issue
Christian Grothoff [Thu, 14 Feb 2019 09:54:01 +0000 (10:54 +0100)]
fix uninit e_hash issue

5 years agoadd missing ignores
Christian Grothoff [Wed, 13 Feb 2019 23:02:51 +0000 (00:02 +0100)]
add missing ignores

5 years agouse disjoint UNIXPATHs and PORT for NAT
Christian Grothoff [Wed, 13 Feb 2019 22:48:48 +0000 (23:48 +0100)]
use disjoint UNIXPATHs and PORT for NAT

5 years agotrying to improve things for #5560
Christian Grothoff [Wed, 13 Feb 2019 22:42:29 +0000 (23:42 +0100)]
trying to improve things for #5560

5 years agoignore generated files, one mroe
Christian Grothoff [Wed, 13 Feb 2019 22:23:17 +0000 (23:23 +0100)]
ignore generated files, one mroe

5 years agoignore generated files, one per line
Christian Grothoff [Wed, 13 Feb 2019 22:22:58 +0000 (23:22 +0100)]
ignore generated files, one per line

5 years agoignore generated files
Christian Grothoff [Wed, 13 Feb 2019 22:22:45 +0000 (23:22 +0100)]
ignore generated files

5 years agoclarifying namestore api (#5458), fixing code duplication and a memory leak while...
Christian Grothoff [Wed, 13 Feb 2019 22:18:43 +0000 (23:18 +0100)]
clarifying namestore api (#5458), fixing code duplication and a memory leak while at it

5 years agoMerge branch 'master' of gnunet.org:gnunet
ng0 [Wed, 13 Feb 2019 21:53:41 +0000 (21:53 +0000)]
Merge branch 'master' of gnunet.org:gnunet

5 years agoattempt to fix 5560, not fixed yet. see log at https://gnunet.org/bugs/view.php?id...
ng0 [Wed, 13 Feb 2019 21:53:27 +0000 (21:53 +0000)]
attempt to fix 5560, not fixed yet. see log at https://gnunet.org/bugs/view.php?id=5560

Signed-off-by: ng0 <ng0@n0.is>
5 years agoadd handle_address_consider_verify skeleton
Christian Grothoff [Wed, 13 Feb 2019 18:42:57 +0000 (19:42 +0100)]
add handle_address_consider_verify skeleton

5 years agoimplementing libgnunettransportaddress
Christian Grothoff [Wed, 13 Feb 2019 18:31:49 +0000 (19:31 +0100)]
implementing libgnunettransportaddress

5 years agoundo accidental commit
Christian Grothoff [Wed, 13 Feb 2019 17:25:39 +0000 (18:25 +0100)]
undo accidental commit

5 years agotrying to fix #5532
Christian Grothoff [Wed, 13 Feb 2019 16:51:29 +0000 (17:51 +0100)]
trying to fix #5532

5 years agoFix dht python test failure with python3.7
ng0 [Wed, 13 Feb 2019 14:19:16 +0000 (14:19 +0000)]
Fix dht python test failure with python3.7

5 years agopogen
Christian Grothoff [Wed, 13 Feb 2019 10:00:47 +0000 (11:00 +0100)]
pogen

5 years agodv service is dead
Christian Grothoff [Tue, 12 Feb 2019 23:54:43 +0000 (00:54 +0100)]
dv service is dead

5 years agoadd more missing EXTRA_DISTs and remove dv (to be integrated with transport in TNG)
Christian Grothoff [Tue, 12 Feb 2019 23:53:06 +0000 (00:53 +0100)]
add more missing EXTRA_DISTs and remove dv (to be integrated with transport in TNG)

5 years agofixing 'make dist' issues
Christian Grothoff [Tue, 12 Feb 2019 23:45:54 +0000 (00:45 +0100)]
fixing 'make dist' issues

5 years agofixing 'make dist' issues
Christian Grothoff [Tue, 12 Feb 2019 23:43:46 +0000 (00:43 +0100)]
fixing 'make dist' issues

5 years agofixing 'make dist' issues
Christian Grothoff [Tue, 12 Feb 2019 23:42:55 +0000 (00:42 +0100)]
fixing 'make dist' issues

5 years agofixing EXTRA_DIST issues'
Christian Grothoff [Tue, 12 Feb 2019 23:42:04 +0000 (00:42 +0100)]
fixing EXTRA_DIST issues'

5 years agofix #5460
Christian Grothoff [Tue, 12 Feb 2019 15:09:20 +0000 (16:09 +0100)]
fix #5460

5 years agobug links
Christian Grothoff [Tue, 12 Feb 2019 14:12:16 +0000 (15:12 +0100)]
bug links

5 years agotox.ini: ignore bak files
ng0 [Tue, 12 Feb 2019 14:05:47 +0000 (14:05 +0000)]
tox.ini: ignore bak files

Signed-off-by: ng0 <ng0@n0.is>
5 years agointegration-tests: futurize gnunet_pyexpect
ng0 [Tue, 12 Feb 2019 11:18:20 +0000 (11:18 +0000)]
integration-tests: futurize gnunet_pyexpect

Signed-off-by: ng0 <ng0@n0.is>
5 years agointegration-tests: futurize test_reconnect_nat
ng0 [Tue, 12 Feb 2019 11:15:47 +0000 (11:15 +0000)]
integration-tests: futurize test_reconnect_nat

5 years agointegration-tests: futurize test_reconnect
ng0 [Tue, 12 Feb 2019 11:15:20 +0000 (11:15 +0000)]
integration-tests: futurize test_reconnect

5 years agointegration-tests: futurize test_integration_disconnect_nat
ng0 [Tue, 12 Feb 2019 11:14:39 +0000 (11:14 +0000)]
integration-tests: futurize test_integration_disconnect_nat

5 years agointegration-tests: futurize test_integration_disconnect
ng0 [Tue, 12 Feb 2019 11:13:15 +0000 (11:13 +0000)]
integration-tests: futurize test_integration_disconnect

5 years agointegration-tests: futurize test_integration_bootstrap_and_connect
ng0 [Tue, 12 Feb 2019 11:12:47 +0000 (11:12 +0000)]
integration-tests: futurize test_integration_bootstrap_and_connect

5 years agointegration-tests: futurize test_integration_clique
ng0 [Tue, 12 Feb 2019 11:12:06 +0000 (11:12 +0000)]
integration-tests: futurize test_integration_clique

5 years agoMerge branch 'master' of gnunet.org:gnunet
ng0 [Tue, 12 Feb 2019 11:09:26 +0000 (11:09 +0000)]
Merge branch 'master' of gnunet.org:gnunet

5 years agoutil: futurize revocation/test_local_revocation
ng0 [Tue, 12 Feb 2019 11:07:06 +0000 (11:07 +0000)]
util: futurize revocation/test_local_revocation

Signed-off-by: ng0 <ng0@n0.is>
5 years agoutil: futurize fs/test_gnunet_fs_psd
ng0 [Tue, 12 Feb 2019 11:06:35 +0000 (11:06 +0000)]
util: futurize fs/test_gnunet_fs_psd

Signed-off-by: ng0 <ng0@n0.is>
5 years agoutil: futurize consensus/consensus-simulation
ng0 [Tue, 12 Feb 2019 11:06:05 +0000 (11:06 +0000)]
util: futurize consensus/consensus-simulation

Signed-off-by: ng0 <ng0@n0.is>
5 years agoutil: futurize contrib/scripts/terminate
ng0 [Tue, 12 Feb 2019 11:05:12 +0000 (11:05 +0000)]
util: futurize contrib/scripts/terminate

Signed-off-by: ng0 <ng0@n0.is>
5 years agoutil: futurize contrib/scripts/pydiffer
ng0 [Tue, 12 Feb 2019 11:04:47 +0000 (11:04 +0000)]
util: futurize contrib/scripts/pydiffer

Signed-off-by: ng0 <ng0@n0.is>
5 years agoutil: futurize contrib/scripts/gnunet_pyexpect
ng0 [Tue, 12 Feb 2019 11:04:19 +0000 (11:04 +0000)]
util: futurize contrib/scripts/gnunet_pyexpect

Signed-off-by: ng0 <ng0@n0.is>
5 years agoutil: futurize contrib/scripts/gnunet-chk
ng0 [Tue, 12 Feb 2019 10:59:44 +0000 (10:59 +0000)]
util: futurize contrib/scripts/gnunet-chk

Signed-off-by: ng0 <ng0@n0.is>
5 years agoutil: futurize gnunet-qr
ng0 [Tue, 12 Feb 2019 10:50:13 +0000 (10:50 +0000)]
util: futurize gnunet-qr

Signed-off-by: ng0 <ng0@n0.is>
5 years agoanother issue with the #5511 patch
Christian Grothoff [Tue, 12 Feb 2019 07:37:59 +0000 (08:37 +0100)]
another issue with the #5511 patch

5 years agouse idn2.h or idna.h depending on HAVE_LIBIDN/HAVE_LIBIDN
Christian Grothoff [Mon, 11 Feb 2019 22:10:12 +0000 (23:10 +0100)]
use idn2.h or idna.h depending on HAVE_LIBIDN/HAVE_LIBIDN

5 years agoadd API for address injection
Christian Grothoff [Mon, 11 Feb 2019 20:38:36 +0000 (21:38 +0100)]
add API for address injection

5 years agoupdate ignore file
Christian Grothoff [Mon, 11 Feb 2019 20:08:41 +0000 (21:08 +0100)]
update ignore file

5 years agoexternalizing secushare logic
Christian Grothoff [Mon, 11 Feb 2019 20:07:26 +0000 (21:07 +0100)]
externalizing secushare logic

5 years agofix test failure due to bad SPDX line
Christian Grothoff [Sun, 10 Feb 2019 22:20:49 +0000 (23:20 +0100)]
fix test failure due to bad SPDX line