oweals/busybox.git
14 years agoash: fix var_leak.tests so that it actually catches the NOFORK bug
Denys Vlasenko [Tue, 18 May 2010 14:13:56 +0000 (16:13 +0200)]
ash: fix var_leak.tests so that it actually catches the NOFORK bug

+ document the bug better

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotypo fix
Denys Vlasenko [Tue, 18 May 2010 13:52:23 +0000 (15:52 +0200)]
typo fix

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: fix bug which causes signal6.tests to fail
Denys Vlasenko [Tue, 18 May 2010 13:49:07 +0000 (15:49 +0200)]
ash: fix bug which causes signal6.tests to fail

function                                             old     new   delta
trapcmd                                              271     277      +6
localcmd                                             277     275      -2

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: fix var_leak testcase
Denys Vlasenko [Tue, 18 May 2010 12:35:20 +0000 (14:35 +0200)]
ash: fix var_leak testcase

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: fix testsuite false positives
Denys Vlasenko [Tue, 18 May 2010 12:11:21 +0000 (14:11 +0200)]
ash: fix testsuite false positives

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash,hush: make bare "." set exitcode to 2
Denys Vlasenko [Tue, 18 May 2010 07:12:53 +0000 (09:12 +0200)]
ash,hush: make bare "." set exitcode to 2

function                                             old     new   delta
dotcmd                                               300     305      +5
builtin_source                                       176     171      -5

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomake scripts/gen_build_files.sh standard-clean
Denys Vlasenko [Mon, 17 May 2010 22:24:17 +0000 (00:24 +0200)]
make scripts/gen_build_files.sh standard-clean

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoshell/README: describe special builtins
Denys Vlasenko [Mon, 17 May 2010 21:51:00 +0000 (23:51 +0200)]
shell/README: describe special builtins

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohush: update bash compat todo comment
Denys Vlasenko [Mon, 17 May 2010 16:56:58 +0000 (18:56 +0200)]
hush: update bash compat todo comment

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash,hush: make "source" a synonym for . if bash compat is on
Denys Vlasenko [Mon, 17 May 2010 15:49:52 +0000 (17:49 +0200)]
ash,hush: make "source" a synonym for . if bash compat is on

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: fix ". empty_file" exitcode. +5 bytes
Denys Vlasenko [Mon, 17 May 2010 15:10:46 +0000 (17:10 +0200)]
ash: fix ". empty_file" exitcode. +5 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotypo fix
Denys Vlasenko [Mon, 17 May 2010 10:33:13 +0000 (12:33 +0200)]
typo fix

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolineedit: fix insertion deep inside line (*several lines* before end)
Denys Vlasenko [Mon, 17 May 2010 10:30:44 +0000 (12:30 +0200)]
lineedit: fix insertion deep inside line (*several lines* before end)

function                                             old     new   delta
input_backward                                       212     229     +17

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agofix false positive in signal5.tests
Denys Vlasenko [Mon, 17 May 2010 08:14:20 +0000 (10:14 +0200)]
fix false positive in signal5.tests

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: use CONFIG_FEATURE_EDITING_MAX_LEN
Denys Vlasenko [Mon, 17 May 2010 08:10:01 +0000 (10:10 +0200)]
ash: use CONFIG_FEATURE_EDITING_MAX_LEN

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotypo fix
Denys Vlasenko [Mon, 17 May 2010 07:55:13 +0000 (09:55 +0200)]
typo fix

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohush: fix hush-bugs/parse_err.tests
Denys Vlasenko [Mon, 17 May 2010 07:49:47 +0000 (09:49 +0200)]
hush: fix hush-bugs/parse_err.tests

function                                             old     new   delta
parse_stream                                        2325    2339     +14
builtin_umask                                        121     123      +2
builtin_type                                         116     114      -2

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoadd two more tests which currently fail
Denys Vlasenko [Mon, 17 May 2010 02:57:55 +0000 (04:57 +0200)]
add two more tests which currently fail

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: fix signal5.tests
Denys Vlasenko [Mon, 17 May 2010 02:42:40 +0000 (04:42 +0200)]
ash: fix signal5.tests

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolineedit: trivial simplifications. -7 bytes
Denys Vlasenko [Mon, 17 May 2010 02:05:53 +0000 (04:05 +0200)]
lineedit: trivial simplifications. -7 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: add two testcases for (not yet fixed) ash bugs
Denys Vlasenko [Mon, 17 May 2010 00:56:18 +0000 (02:56 +0200)]
ash: add two testcases for (not yet fixed) ash bugs

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoscripts/gen_build_files.sh: revert to using /bin/sh
Denys Vlasenko [Sun, 16 May 2010 23:59:16 +0000 (01:59 +0200)]
scripts/gen_build_files.sh: revert to using /bin/sh

People want busybox to build w/o bash, with /bin/sh = ash

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolineedit: fix moving backwards across lines with wide chars
Denys Vlasenko [Sun, 16 May 2010 22:45:44 +0000 (00:45 +0200)]
lineedit: fix moving backwards across lines with wide chars

function                                             old     new   delta
input_backward                                       212     208      -4

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoconsolidate ESC sequences
Denys Vlasenko [Sun, 16 May 2010 21:42:13 +0000 (23:42 +0200)]
consolidate ESC sequences

function                                             old     new   delta
bell                                                   2       -      -2
CMdown                                                 2       -      -2
Ceos                                                   4       -      -4
Ceol                                                   4       -      -4
CMup                                                   4       -      -4
SOs                                                    5       -      -5
SOn                                                    5       -      -5
CMrc                                                   9       -      -9

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agostop using LAST_SUPPORTED_WCHAR and CONFIG_LAST_SUPPORTED_WCHAR, it's confusing
Denys Vlasenko [Sun, 16 May 2010 19:15:03 +0000 (21:15 +0200)]
stop using LAST_SUPPORTED_WCHAR and CONFIG_LAST_SUPPORTED_WCHAR, it's confusing

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolineedit: partially fix wide and combining chars editing
Tomas Heinrich [Sun, 16 May 2010 18:46:53 +0000 (20:46 +0200)]
lineedit: partially fix wide and combining chars editing

Signed-off-by: Tomas Heinrich <heinrich.tomas@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agofindutils: Add Config.in and Kbuild to .gitignore
Peter Tyser [Thu, 13 May 2010 23:56:22 +0000 (18:56 -0500)]
findutils: Add Config.in and Kbuild to .gitignore

These are auto-generated files and should be ignored by git.

Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoscripts/Makefile.clean: Make Kbuild and Makefile optional
Peter Tyser [Thu, 13 May 2010 23:46:00 +0000 (18:46 -0500)]
scripts/Makefile.clean: Make Kbuild and Makefile optional

During cleaning, some directories might not have a Makefile or Kbuild
file.  Previously scripts/Makefile.clean would spit out the following
error when neither file could be found:
ptyser@petert busybox $ make mrproper
scripts/Makefile.clean:17: /home/user/busybox/findutils/Makefile: No such file or directory
make[1]: *** No rule to make target `/home/user/busybox/findutils/Makefile'.  Stop.
make: *** [_clean_findutils] Error 2

This issue can be triggered by running 'make mrproper' in a freshly
cloned busybox repository.

Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoMakefile: Clean up auto-generated Kbuild and Config.in files
Peter Tyser [Sun, 16 May 2010 00:48:21 +0000 (02:48 +0200)]
Makefile: Clean up auto-generated Kbuild and Config.in files

Previously these auto-generated files were left behind after a 'make
mrproper' was ran.

Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohush: mention PPID, RANDOM support
Denys Vlasenko [Sun, 16 May 2010 00:36:18 +0000 (02:36 +0200)]
hush: mention PPID, RANDOM support

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agosetsid: check for setsid error directly
Denys Vlasenko [Sun, 16 May 2010 00:12:56 +0000 (02:12 +0200)]
setsid: check for setsid error directly

function                                             old     new   delta
setsid_main                                           74      66      -8

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agogen_build_files.sh uses bashism, document it
Denys Vlasenko [Sat, 15 May 2010 19:08:51 +0000 (21:08 +0200)]
gen_build_files.sh uses bashism, document it

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agocttyhack: document the need to setsid
Denys Vlasenko [Sat, 15 May 2010 18:43:07 +0000 (20:43 +0200)]
cttyhack: document the need to setsid

function                                             old     new   delta
packed_usage                                       26988   27057     +69

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agogen_build_files: use raw reads (ones which don't eat backslashes)
Denys Vlasenko [Fri, 14 May 2010 18:30:44 +0000 (20:30 +0200)]
gen_build_files: use raw reads (ones which don't eat backslashes)

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agocttyhack: don't do anything if ctty is already available
Denys Vlasenko [Fri, 14 May 2010 02:08:20 +0000 (04:08 +0200)]
cttyhack: don't do anything if ctty is already available

function                                             old     new   delta
cttyhack_main                                        244     269     +25

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agorandomtest fixes
Denys Vlasenko [Wed, 12 May 2010 13:59:32 +0000 (15:59 +0200)]
randomtest fixes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agosed: fix a command with multible trailing backslashes
Denys Vlasenko [Tue, 11 May 2010 23:49:04 +0000 (01:49 +0200)]
sed: fix a command with multible trailing backslashes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolineedit: change how cmdedit_set_out_char works
Denys Vlasenko [Tue, 11 May 2010 12:49:13 +0000 (14:49 +0200)]
lineedit: change how cmdedit_set_out_char works

Rename two badly names functions, use "clear to end of screen"
to eliminate annoying problems with clearing wide/combining chars,
and such. Run tested.

function                                             old     new   delta
put_cur_glyph_and_inc_cursor                           -     124    +124
put_till_end_and_adv_cursor                            -      24     +24
input_delete                                         125     130      +5
Ceos                                                   5       4      -1
Ceol                                                   5       4      -1
input_end                                             24       -     -24
cmdedit_set_out_char                                 122       -    -122
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 1/2 up/down: 153/-148)            Total: 5 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agorandomtest fixes
Denys Vlasenko [Tue, 11 May 2010 10:02:48 +0000 (12:02 +0200)]
randomtest fixes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoifplugd: fix typo in prev commit
Denys Vlasenko [Tue, 11 May 2010 02:37:13 +0000 (04:37 +0200)]
ifplugd: fix typo in prev commit

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agorandomtest fixes
Denys Vlasenko [Tue, 11 May 2010 02:32:04 +0000 (04:32 +0200)]
randomtest fixes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agorandomtest fixes
Denys Vlasenko [Tue, 11 May 2010 01:53:57 +0000 (03:53 +0200)]
randomtest fixes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoremove duplicate comment
Denys Vlasenko [Mon, 10 May 2010 10:25:36 +0000 (12:25 +0200)]
remove duplicate comment

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomore randomconfig testsuite fixes
Denys Vlasenko [Mon, 10 May 2010 09:00:11 +0000 (11:00 +0200)]
more randomconfig testsuite fixes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agorandomconfig testsuite fixes
Denys Vlasenko [Mon, 10 May 2010 03:53:16 +0000 (05:53 +0200)]
randomconfig testsuite fixes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agogen_build_files.sh should be executable
Denys Vlasenko [Mon, 10 May 2010 02:18:42 +0000 (04:18 +0200)]
gen_build_files.sh should be executable

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agowork on adding testsuite runs to randomconfig test builds
Denys Vlasenko [Mon, 10 May 2010 02:16:43 +0000 (04:16 +0200)]
work on adding testsuite runs to randomconfig test builds

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotweak scripts/gen_build_files.sh
Denys Vlasenko [Sun, 9 May 2010 14:20:52 +0000 (16:20 +0200)]
tweak scripts/gen_build_files.sh

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotrim help text
Denys Vlasenko [Sun, 9 May 2010 02:38:22 +0000 (04:38 +0200)]
trim help text

function                                             old     new   delta
packed_usage                                       27006   26988     -18

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomake it possible to keep Config/Kbuild snippets in *.c files
Denys Vlasenko [Sun, 9 May 2010 02:22:48 +0000 (04:22 +0200)]
make it possible to keep Config/Kbuild snippets in *.c files

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotune2fs: move to e2fsprogs
Denys Vlasenko [Sat, 8 May 2010 22:13:40 +0000 (00:13 +0200)]
tune2fs: move to e2fsprogs

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoifplugd: replace potentially-leaking setenv with malloc/putenv/free
Denys Vlasenko [Sat, 8 May 2010 21:26:16 +0000 (23:26 +0200)]
ifplugd: replace potentially-leaking setenv with malloc/putenv/free

   text    data     bss     dec     hex filename
 842657     453    6828  849938   cf812 busybox_old
 842722     453    6828  850003   cf853 busybox_unstripped

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotar: support GNU 256-bit encoding in all numeric fields
Denys Vlasenko [Thu, 6 May 2010 18:08:14 +0000 (20:08 +0200)]
tar: support GNU 256-bit encoding in all numeric fields

function                                             old     new   delta
getOctal                                              63     125     +62
get_header_tar                                      1572    1496     -76
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 62/-76)            Total: -14 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoinstall lspci and lsusb to /usr/bin
Gustavo Zacarias [Thu, 6 May 2010 14:57:14 +0000 (11:57 -0300)]
install lspci and lsusb to /usr/bin

Both can be run (to some degree) by mere users.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
14 years agoadd comment about xz format support
Denys Vlasenko [Thu, 6 May 2010 15:05:22 +0000 (17:05 +0200)]
add comment about xz format support

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agorpm: make rpm -i SRPM.rpm install it to surrent dir; better help text
Denys Vlasenko [Thu, 6 May 2010 14:56:38 +0000 (16:56 +0200)]
rpm: make rpm -i SRPM.rpm install it to surrent dir; better help text

function                                             old     new   delta
rpm_main                                            1355    1358      +3
packed_usage                                       26732   26728      -4
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 3/-4)               Total: -1 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agorpm: code shrink. Now uses open_zipped's logic (factored out into setup_unzip_on_fd())
Denys Vlasenko [Thu, 6 May 2010 14:19:19 +0000 (14:19 +0000)]
rpm: code shrink. Now uses open_zipped's logic (factored out into setup_unzip_on_fd())

function                                             old     new   delta
setup_unzip_on_fd                                      -      80     +80
open_zipped                                          176     113     -63
rpm_main                                            1672    1355    -317
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/2 up/down: 80/-380)          Total: -300 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agobootchartd: better wording in comment
Denys Vlasenko [Tue, 4 May 2010 22:40:15 +0000 (00:40 +0200)]
bootchartd: better wording in comment

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agobootchartd: add missing parenthesis
Denys Vlasenko [Tue, 4 May 2010 15:34:37 +0000 (17:34 +0200)]
bootchartd: add missing parenthesis

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agobootchartd: new applet
Denys Vlasenko [Tue, 4 May 2010 13:45:25 +0000 (15:45 +0200)]
bootchartd: new applet

Usage: bootchartd start [PROG ARGS]|init|stop

Create /var/log/bootchart.tgz with boot chart data

Options:
start: start background logging; with PROG, run PROG, then kill
logging with USR1
stop: send USR1 to all bootchartd processes
init: start background logging; stop when getty/gdm is seen (for init scripts)
Under PID 1: as init, then exec $bootchart_init, /init, /sbin/init

function                                             old     new   delta
bootchartd_main                                        -     907    +907
dump_procs                                             -     353    +353
packed_usage                                       26566   26735    +169
dump_file                                              -      91     +91
static.dirs                                            -      23     +23
applet_names                                        2176    2187     +11
applet_main                                         1284    1288      +4
applet_nameofs                                       642     644      +2
------------------------------------------------------------------------------
(add/remove: 5/0 grow/shrink: 4/0 up/down: 1560/0)           Total: 1560 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agofix typo in commented-out code
Denys Vlasenko [Tue, 4 May 2010 12:59:01 +0000 (14:59 +0200)]
fix typo in commented-out code

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoifdown: use /var/run/udhcpc.%iface%.pid only if it exists
Denys Vlasenko [Sun, 2 May 2010 18:30:28 +0000 (20:30 +0200)]
ifdown: use /var/run/udhcpc.%iface%.pid only if it exists

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agorfkill: new applet
Souf Oued [Sun, 2 May 2010 16:45:02 +0000 (18:45 +0200)]
rfkill: new applet

function                                             old     new   delta
rfkill_main                                            -     683    +683
packed_usage                                       26824   26966    +142
static.rfkill_types                                    -      42     +42
applet_names                                        2216    2223      +7
applet_main                                         1300    1304      +4
applet_nameofs                                       650     652      +2

Signed-off-by: Souf Oued <souf_oued@yahoo.fr>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcpd: fix hostname truncation bug 1663
Denys Vlasenko [Sun, 2 May 2010 12:17:07 +0000 (14:17 +0200)]
udhcpd: fix hostname truncation bug 1663

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agogrep: fix -Fi
Ian Wienand [Fri, 30 Apr 2010 07:32:10 +0000 (09:32 +0200)]
grep: fix -Fi

function                                             old     new   delta
grep_file                                           1151    1169     +18

Signed-off-by: Ian Wienand <ianw@vmware.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoswapon: skip noauto entries
Lauri Kasanen [Thu, 29 Apr 2010 20:20:57 +0000 (22:20 +0200)]
swapon: skip noauto entries

Signed-off-by: Lauri Kasanen <curaga@operamail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agolibbb/lineedit: add support for preserving "broken" (non-unicode) chars
Tomas Heinrich [Thu, 29 Apr 2010 11:43:39 +0000 (13:43 +0200)]
libbb/lineedit: add support for preserving "broken" (non-unicode) chars

Signed-off-by: Tomas Heinrich <heinrich.tomas@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotelnet: prevent SEGV if we are requested TELOPT_NEW_ENVIRON.
Denys Vlasenko [Tue, 27 Apr 2010 06:54:24 +0000 (08:54 +0200)]
telnet: prevent SEGV if we are requested TELOPT_NEW_ENVIRON.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodnsd: fix unaligned access problem
Denys Vlasenko [Mon, 26 Apr 2010 12:25:33 +0000 (14:25 +0200)]
dnsd: fix unaligned access problem

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoash: refresh stack pointers after makestrspace in rmescapes
Colin Watson [Mon, 26 Apr 2010 12:21:27 +0000 (14:21 +0200)]
ash: refresh stack pointers after makestrspace in rmescapes

Without this, rmescapes sometimes returns random garbage while
performing parameter expansions such as ${foo#bar}, in the event that
the allocation of r happens to need to reallocate the stack and hence
invalidate str and p.  I'd love to provide a test case but unfortunately
it's dependent on exact stack layout, so I don't have anything simpler
than the situation described in
https://bugs.launchpad.net/ubuntu/+source/partman-base/+bug/527401/comments/23
which involved a sequence of foo="${foo#*, }" expansions on a long
string inside our RAID configuration tool.

The same fix has been in dash since 2007-09-26, contributed by Roy
Marples <uberlord@gentoo.org>.  I actually came up with it independently
almost to the character, but then synced it up with the variable naming
used in dash when I noticed that change afterwards.

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agocmp: remove history comment. it is more natural to keep it in source control
Denys Vlasenko [Mon, 26 Apr 2010 12:04:29 +0000 (14:04 +0200)]
cmp: remove history comment. it is more natural to keep it in source control

The comment was:

* Mar 16, 2003      Manuel Novoa III   (mjn3@codepoet.org)
*
* Original version majorly reworked for SUSv3 compliance, bug fixes, and
* size optimizations.  Changes include:
* 1) Now correctly distinguishes between errors and actual file differences.
* 2) Proper handling of '-' args.
* 3) Actual error checking of i/o.
* 4) Accept SUSv3 -l option.  Note that we use the slightly nicer gnu format
*    in the '-l' case.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agocmp: ifdefectomy
Rob Landley [Mon, 26 Apr 2010 12:01:14 +0000 (14:01 +0200)]
cmp: ifdefectomy

Signed-off-by: Rob Landley <rob@landley.net>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agocpio: "NNN blocks" should go to stderr
Matheus Izvekov [Mon, 26 Apr 2010 11:53:57 +0000 (13:53 +0200)]
cpio: "NNN blocks" should go to stderr

Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agofind: fix -name matching for dotfiles. -1 byte
Denys Vlasenko [Mon, 26 Apr 2010 07:54:04 +0000 (09:54 +0200)]
find: fix -name matching for dotfiles. -1 byte

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agogrep: makw -w support unconditional
Denys Vlasenko [Mon, 26 Apr 2010 06:45:44 +0000 (08:45 +0200)]
grep: makw -w support unconditional

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodate: support -d @SECONDS_SINCE_1970
Denys Vlasenko [Thu, 22 Apr 2010 04:45:28 +0000 (00:45 -0400)]
date: support -d @SECONDS_SINCE_1970

function                                             old     new   delta
parse_datestr                                        647     721     +74

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoftpd: work around LIST -aXYZ too, not only LIST -lXYZ
Denys Vlasenko [Wed, 21 Apr 2010 22:05:10 +0000 (18:05 -0400)]
ftpd: work around LIST -aXYZ too, not only LIST -lXYZ

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agobusybox --list option. +140 bytes. Rob wanted it.
Denys Vlasenko [Wed, 21 Apr 2010 01:02:57 +0000 (21:02 -0400)]
busybox --list option. +140 bytes. Rob wanted it.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agosed: fix nested {} case
Denys Vlasenko [Tue, 20 Apr 2010 08:00:03 +0000 (04:00 -0400)]
sed: fix nested {} case

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agosed: fix c cmd
Denys Vlasenko [Tue, 20 Apr 2010 02:36:07 +0000 (22:36 -0400)]
sed: fix c cmd

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agovi: discover window size even on serial consoles. optional
Denys Vlasenko [Mon, 19 Apr 2010 05:09:30 +0000 (22:09 -0700)]
vi: discover window size even on serial consoles. optional

function                                             old     new   delta
edit_file                                            671     761     +90
wh_helper                                              -      57     +57
query_screen_dimensions                               54      63      +9
ar_main                                              533     542      +9
refresh                                              767     773      +6
vi_main                                              242     243      +1
text_yank                                             56      54      -2
get_terminal_width_height                            180     135     -45
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 5/2 up/down: 172/-47)           Total: 125 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agovi: remove superfluous check on filename == ""
Denys Vlasenko [Mon, 19 Apr 2010 03:39:41 +0000 (20:39 -0700)]
vi: remove superfluous check on filename == ""

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoremove stdio from allnoconfig build
Denys Vlasenko [Mon, 19 Apr 2010 03:16:11 +0000 (20:16 -0700)]
remove stdio from allnoconfig build

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agovi: code shrink
Denys Vlasenko [Sat, 17 Apr 2010 05:13:55 +0000 (22:13 -0700)]
vi: code shrink

function                                             old     new   delta
vi_main                                              250     242      -8
colon                                               2980    2970     -10
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-18)             Total: -18 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agovi: code shrink; save/restore errno in signal handlers
Denys Vlasenko [Sat, 17 Apr 2010 03:55:52 +0000 (20:55 -0700)]
vi: code shrink; save/restore errno in signal handlers

function                                             old     new   delta
query_screen_dimensions                                -      54     +54
suspend_sig                                           50      64     +14
cont_sig                                              65      66      +1
catch_sig                                             42      32     -10
winch_sig                                             88      60     -28
edit_file                                            719     671     -48
refresh                                              848     767     -81
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 2/4 up/down: 69/-167)           Total: -98 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoadd a file which shows what builds on ancient RH9 image
Denys Vlasenko [Sat, 17 Apr 2010 02:32:12 +0000 (19:32 -0700)]
add a file which shows what builds on ancient RH9 image

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoread_key: fix buffer length calculation
Tomas Heinrich [Fri, 16 Apr 2010 21:59:51 +0000 (23:59 +0200)]
read_key: fix buffer length calculation

Signed-off-by: Tomas Heinrich <heinrich.tomas@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoar: fix a regression: "ar t arch.a" stopped shoting files
Nguyễn Thái Ngọc Duy [Thu, 15 Apr 2010 23:55:04 +0000 (16:55 -0700)]
ar: fix a regression: "ar t arch.a" stopped shoting files

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohttpd_indexcgi example: trivial fix
Denys Vlasenko [Thu, 15 Apr 2010 15:37:59 +0000 (08:37 -0700)]
httpd_indexcgi example: trivial fix

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoudhcpc: make help text better
Denys Vlasenko [Wed, 14 Apr 2010 21:04:26 +0000 (14:04 -0700)]
udhcpc: make help text better

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoloop: correct minor device number limit
Denys Vlasenko [Wed, 14 Apr 2010 20:52:41 +0000 (13:52 -0700)]
loop: correct minor device number limit

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodevmem: map two pages only if it is necessary
Denys Vlasenko [Wed, 14 Apr 2010 20:37:25 +0000 (13:37 -0700)]
devmem: map two pages only if it is necessary

function                                             old     new   delta
devmem_main                                          463     469      +6

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomount: add an optional capability to create new /dev/loopN as needed
Lauri Kasanen [Wed, 14 Apr 2010 19:31:26 +0000 (12:31 -0700)]
mount: add an optional capability to create new /dev/loopN as needed

Signed-off-by: Lauri Kasanen <curaga@operamail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agodnsd: enforce alignment on packet buffer
Denys Vlasenko [Wed, 14 Apr 2010 17:14:25 +0000 (10:14 -0700)]
dnsd: enforce alignment on packet buffer

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agomodutils-24: [mips] modutlis-24 segfault fix for 2.4 kernel modules
Ralf Rösch [Wed, 14 Apr 2010 16:45:37 +0000 (09:45 -0700)]
modutils-24: [mips] modutlis-24 segfault fix for 2.4 kernel modules

handling DWARF sections solves the problem.

This seems to be a long outstanding bug:
http://permalink.gmane.org/gmane.linux.busybox/4533
http://www.linux-mips.org/archives/linux-mips/2004-08/msg00072.html

Signed-off-by: Ralf Rösch <ralf.roesch@rw-gmbh.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agohwclock: improve, and then disable clever sync code: it's bloat
Denys Vlasenko [Wed, 14 Apr 2010 16:19:20 +0000 (09:19 -0700)]
hwclock: improve, and then disable clever sync code: it's bloat

...and hardware is too stupid to benefit from it anyway

function                                             old     new   delta
hwclock_main                                         439     319    -120

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoxargs: do not decrease orig_arg_max to negative values
Denys Vlasenko [Fri, 9 Apr 2010 12:58:40 +0000 (14:58 +0200)]
xargs: do not decrease orig_arg_max to negative values

Based on patch by Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agoExclude syslog code if FEATURE_SYSLOG is not set
Nguyễn Thái Ngọc Duy [Fri, 9 Apr 2010 12:34:28 +0000 (14:34 +0200)]
Exclude syslog code if FEATURE_SYSLOG is not set

syslog.h and syslog(...) may not exist in such configuration

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotar: fix "hardlinks to symlinks chown" bug 1519.
Denys Vlasenko [Fri, 9 Apr 2010 12:11:45 +0000 (14:11 +0200)]
tar: fix "hardlinks to symlinks chown" bug 1519.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
14 years agotar: fix mishandling of repeated hardlink in tarball; expand tests
Denys Vlasenko [Fri, 9 Apr 2010 08:52:52 +0000 (10:52 +0200)]
tar: fix mishandling of repeated hardlink in tarball; expand tests

function                                             old     new   delta
data_extract_all                                     727     767     +40
get_header_tar                                      1576    1572      -4

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>