Eric Andersen [Fri, 12 Mar 2004 22:08:13 +0000 (22:08 -0000)]
Add prototypes for safe_strtol and friends
Eric Andersen [Fri, 12 Mar 2004 22:07:10 +0000 (22:07 -0000)]
Fix awk entry, which was not showing up in BusyBox.txt for some reason
Eric Andersen [Thu, 11 Mar 2004 13:34:24 +0000 (13:34 -0000)]
Paul Mundt, lethal at linux-sh dot org writes:
Here's a follow-up replacement to the patch I sent earlier, this adjusts some
of the semantics of the dynamic variable setting. Namely, dynamic vars can hook
a set handler (which RANDOM uses to adjust the seed). They'll only lose their
dynamic status if they're unset.
I've used the same approach that bash does to come up with the random number,
mostly just for consistency.
For example:
$ echo $RANDOM
13759
$ echo $RANDOM
20057
$ echo $RANDOM
1502
$ export RANDOM=42
$ echo $RANDOM
24179
$ echo $RANDOM
2046
$ unset RANDOM
$ echo $RANDOM
$ export RANDOM=42
$ echo $RANDOM
42
$
Glenn L McGrath [Wed, 10 Mar 2004 10:47:37 +0000 (10:47 -0000)]
Patch from Thomas Frohlich to fix an option ordering bug of mine.
Glenn L McGrath [Wed, 10 Mar 2004 09:58:51 +0000 (09:58 -0000)]
When displaying the size in 1kB blocks round up if an odd number of
blocks
Glenn L McGrath [Wed, 10 Mar 2004 09:10:53 +0000 (09:10 -0000)]
Patch by Seth W. Klein, the -l switch was reversed
Manuel Novoa III [Wed, 10 Mar 2004 07:42:38 +0000 (07:42 -0000)]
In spite of the feature freeze, check in a complete rework of route which
fixes some bugs, adds some error checking, and removes _lots_ of bloat.
Text size on i386...
old new
ipv6 5425 3523
no ipv6 3143 2193
Eric Andersen [Tue, 9 Mar 2004 21:32:57 +0000 (21:32 -0000)]
Note that /proc must be mounted for filesystem type autodetection
to work. Without /proc mounted, one must explicitly specify the
type of every filesystem being mounted.
Eric Andersen [Tue, 9 Mar 2004 21:27:32 +0000 (21:27 -0000)]
David Anders (prpplague) submitted this patch to allow login to work
when the device nodes are symlinks on a read only file system.
Manuel Novoa III [Mon, 8 Mar 2004 10:54:29 +0000 (10:54 -0000)]
Fix broken sort order flags.
Manuel Novoa III [Mon, 8 Mar 2004 05:44:30 +0000 (05:44 -0000)]
My bug. :-(
Eric Andersen [Sat, 6 Mar 2004 22:11:45 +0000 (22:11 -0000)]
Fix/eliminate use of atol
Glenn L McGrath [Sat, 6 Mar 2004 09:12:55 +0000 (09:12 -0000)]
Patch from Matt Kraai to fix debian bug number 231994.
There was an extra blank line preceding the first directory.
Glenn L McGrath [Sat, 6 Mar 2004 07:38:27 +0000 (07:38 -0000)]
Woops, how did that get in there
Manuel Novoa III [Sat, 6 Mar 2004 00:32:54 +0000 (00:32 -0000)]
Don't build these support functions for uClibc, as it always supplies
versions.
Glenn L McGrath [Fri, 5 Mar 2004 15:52:57 +0000 (15:52 -0000)]
Patch from John Powers, adds multicast (rfc2090) and timeout (rfc2349)
options
Glenn L McGrath [Fri, 5 Mar 2004 14:35:00 +0000 (14:35 -0000)]
Patch from duane no-name, optionally request additional items
Glenn L McGrath [Fri, 5 Mar 2004 14:25:49 +0000 (14:25 -0000)]
Patch by Andrew Victor,
In arpping.h, fix structure alignment of "struct arpMsg".
GCC can insert padding in the structure which causes udhcpd to send an
invalid ARP packet on the network. It will then not receive a valid
reply, which can cause it to assign an IP address that's already in use
on the network.
(With kernels before 2.4.20, the "struct ethhdr" in linux/if_ether.h
wasn't marked as packed. This is also an issue if your toolchain was
built with a pre-2.4.20 kernel).
Glenn L McGrath [Fri, 5 Mar 2004 14:23:16 +0000 (14:23 -0000)]
Fix a typo, patch by Andrew Victor
Glenn L McGrath [Fri, 5 Mar 2004 13:23:40 +0000 (13:23 -0000)]
Patch from Tony J. White to allow paths to be configured
Glenn L McGrath [Fri, 5 Mar 2004 13:11:05 +0000 (13:11 -0000)]
Patch by Denis Vlasenko to add forground support.
Glenn L McGrath [Fri, 5 Mar 2004 13:04:39 +0000 (13:04 -0000)]
Fix debugging output, patch by Hideki IWAMOTO
Glenn L McGrath [Fri, 5 Mar 2004 12:55:30 +0000 (12:55 -0000)]
Patch by Felipe Kellermann to fix a compiler compatability problem
Glenn L McGrath [Fri, 5 Mar 2004 09:38:16 +0000 (09:38 -0000)]
Patch from Steven Scholz to fix compiler warnings
Glenn L McGrath [Fri, 5 Mar 2004 07:26:28 +0000 (07:26 -0000)]
New applet, eject, by Peter Willis
Glenn L McGrath [Fri, 5 Mar 2004 06:47:25 +0000 (06:47 -0000)]
Close bracket in description from Peter Willis's eject applet
Glenn L McGrath [Fri, 5 Mar 2004 05:47:19 +0000 (05:47 -0000)]
Patch from Vernon Sauder.
The off_t type is not a consistent size; it depends on the kernel options
(something about large file support). Therefore, the format string for
printing an address is not always the same.
Glenn L McGrath [Wed, 3 Mar 2004 21:12:16 +0000 (21:12 -0000)]
Fix a compile error identiefied by Steven Scholz.
Declare variables first for compatability.
Glenn L McGrath [Mon, 1 Mar 2004 08:32:49 +0000 (08:32 -0000)]
Check file has execute permission for the current user, minor formating
Glenn L McGrath [Thu, 26 Feb 2004 07:47:20 +0000 (07:47 -0000)]
Quick fix for tftp truncation bug
Glenn L McGrath [Wed, 25 Feb 2004 10:35:55 +0000 (10:35 -0000)]
Patch from Denis Dowling to fix a ocuple of usage entries
Glenn L McGrath [Wed, 25 Feb 2004 09:30:06 +0000 (09:30 -0000)]
Fix option handling, -i or -t must be given, if both ignore the -t.
Use bb_getopt_ulflags.
Eric Andersen [Tue, 24 Feb 2004 07:28:38 +0000 (07:28 -0000)]
Joe.C, joe at numa dot com dot tw writes:
Hi,
When downloading files over slow network (e.g. wireless/
internet) using IE, sometimes it will stop downloading and
show error message 'connection closed' when the download
is almost complete. This is because IE can't handle server
close connection properly.
Apache http_main.c fix this problem by close the connection
after client close the connection. This patch do exactly the
same thing. Please consider include this patch.
Joe.C
Eric Andersen [Mon, 23 Feb 2004 09:14:07 +0000 (09:14 -0000)]
Prepare for release
Glenn L McGrath [Mon, 23 Feb 2004 08:11:07 +0000 (08:11 -0000)]
bb_full_fd_action was incorrectly returning an error message causing
major breaking.
Eric Andersen [Sun, 22 Feb 2004 12:27:04 +0000 (12:27 -0000)]
Bump up version in preparation for -pre8
Eric Andersen [Sun, 22 Feb 2004 12:25:47 +0000 (12:25 -0000)]
Fernando Silveira writes:
Hi,
Well, I made this patch a long time ago (08/2002) because it was a
need of a project, but had no time to send it to you. It adds support
to `autologin' option of the telnet protocol. It has been used since
made with busybox 0.60.3 at production and I had no problems with it.
I have ported it to the HEAD revision of the CVS server (
20040211) and
I hope you enjoy and apply it to the official sources. :)
Thanks a lot!
Glenn L McGrath [Sun, 22 Feb 2004 12:17:33 +0000 (12:17 -0000)]
Fix from Paul Kortekaas for syslog -C option, size should be in kB.
Glenn L McGrath [Sun, 22 Feb 2004 11:55:09 +0000 (11:55 -0000)]
Patch from Dmitry Zakharov, this line was missedfrom the last patch
Eric Andersen [Sun, 22 Feb 2004 11:46:49 +0000 (11:46 -0000)]
For the time being, revert the changes for detecting copying
a directory into itself. It is harder to do this correctly
than it appears. Not trying at all seems a better compromise
for the time being, untill we can implement this correctly.
Glenn L McGrath [Sun, 22 Feb 2004 11:35:13 +0000 (11:35 -0000)]
Patch from Chris Larson (kergoth), to allow multiple directores to be
unmounted at once.
Glenn L McGrath [Sun, 22 Feb 2004 11:25:13 +0000 (11:25 -0000)]
Patch from Vodz, cleanup memory usage, send strdup error messages to
syslog.
Glenn L McGrath [Sun, 22 Feb 2004 11:13:28 +0000 (11:13 -0000)]
Vodz. last_patch_128
- declare applet_using as static from applets.c
- small correction to cmdedit,
previous version cleared history after Ctrl-C
- small spelling correction (by Friedrich Lobenstock)
Glenn L McGrath [Sun, 22 Feb 2004 09:45:57 +0000 (09:45 -0000)]
Patch from James Zhu, telnetd window resizing support.
Glenn L McGrath [Sun, 22 Feb 2004 09:11:33 +0000 (09:11 -0000)]
Use bb_getopt_ulflags, marginal saving, better argument checking.
Glenn L McGrath [Sun, 22 Feb 2004 08:33:37 +0000 (08:33 -0000)]
Use /var/lib/hwclock for adjtime, its really a state file rather than a
config file, so it should be in /etc, FHS mentions it also.
Glenn L McGrath [Sun, 22 Feb 2004 07:38:36 +0000 (07:38 -0000)]
Patch from Florian Schirmer. compile fix for debug builds
Glenn L McGrath [Sun, 22 Feb 2004 07:20:25 +0000 (07:20 -0000)]
Patch from Hideki IWAMOTO, output debugging messages to stderr
Glenn L McGrath [Sun, 22 Feb 2004 04:58:36 +0000 (04:58 -0000)]
remove duplicate header declarations
Glenn L McGrath [Sun, 22 Feb 2004 04:44:21 +0000 (04:44 -0000)]
Fixup braces (patch from Thomas Geulig), run through indent and manually
adjust.
Glenn L McGrath [Sun, 22 Feb 2004 04:17:26 +0000 (04:17 -0000)]
Thomas Geulig, remove duplicate header
Glenn L McGrath [Sun, 22 Feb 2004 04:12:58 +0000 (04:12 -0000)]
Update usage for ftpget and ftpput
Glenn L McGrath [Sun, 22 Feb 2004 03:33:53 +0000 (03:33 -0000)]
Ptch by Hideki IWAMOTO, fix a bug preventing tftp from getting or
putting more than 0xffff blocks.
Glenn L McGrath [Sun, 22 Feb 2004 02:58:57 +0000 (02:58 -0000)]
Return 1 upon failure
Glenn L McGrath [Sun, 22 Feb 2004 00:27:34 +0000 (00:27 -0000)]
No need to check proxy env variable twice, ignore proxy env variable if
its set to 0
Glenn L McGrath [Sat, 21 Feb 2004 09:20:56 +0000 (09:20 -0000)]
Sometimes i get carried away with the use of function pointers, im sure
it seemed like a good idea at the time.
Glenn L McGrath [Sat, 21 Feb 2004 07:49:54 +0000 (07:49 -0000)]
Use return instead of exit, use == instead of & ==, left justify labels,
adjustment of whitespace.
Eric Andersen [Fri, 20 Feb 2004 09:55:37 +0000 (09:55 -0000)]
Document missing cp options
Glenn L McGrath [Fri, 20 Feb 2004 02:34:42 +0000 (02:34 -0000)]
Fix up hard links
Glenn L McGrath [Fri, 20 Feb 2004 02:25:18 +0000 (02:25 -0000)]
A strict interpretation of the ustar format requires the type flag to be
interpreted, we cannot depend on the file type being set in the mode
field.
Glenn L McGrath [Thu, 19 Feb 2004 08:48:30 +0000 (08:48 -0000)]
Add extra comments, freakout if a pax archive is encoutered.
Eric Andersen [Thu, 19 Feb 2004 01:52:29 +0000 (01:52 -0000)]
Chris Larson (kergoth) writes:
As Manuel points out, this is a flawed fix, and doesnt fix the
following:
mkdir -p cpa cpb cpc
cp -a cpa cpa/cpb/cpc
Attached what appears to be a more sane fix. Apply on top of previous.
Please confirm sanity.
Eric Andersen [Thu, 19 Feb 2004 00:44:08 +0000 (00:44 -0000)]
Chris Larson (kergoth) writes:
I was adding -s/--symbolic-link support to busybox cp when I noticed a
bug with -r/-a. Test case:
mkdir -p test/out
cd test
busybox cp -a * out/
Will never return until we run out of open files or similar.
Coreutils cp on the other hand will error with "cannot copy a directory,
`out', into itself, `out'". Patch attached.
Glenn L McGrath [Wed, 18 Feb 2004 13:19:58 +0000 (13:19 -0000)]
Dont use same variable and struct name
Glenn L McGrath [Wed, 18 Feb 2004 13:12:53 +0000 (13:12 -0000)]
Formatting
Glenn L McGrath [Wed, 18 Feb 2004 12:58:00 +0000 (12:58 -0000)]
remove debugging
Manuel Novoa III [Wed, 18 Feb 2004 10:14:17 +0000 (10:14 -0000)]
Patch from OpenWrt.
Rob Landley [Wed, 18 Feb 2004 09:54:15 +0000 (09:54 -0000)]
Add -i option to sed, to edit files in-place.
Manuel Novoa III [Wed, 18 Feb 2004 09:40:41 +0000 (09:40 -0000)]
Fix vstype[] to match VS* defines. Patch from OpenWrt by mbm.
Eric Andersen [Tue, 17 Feb 2004 20:08:11 +0000 (20:08 -0000)]
Remove the unused CONFIG_FEATURE_HTTPD_SET_CGI_VARS_TO_ENV option.
Eric Andersen [Tue, 17 Feb 2004 20:04:34 +0000 (20:04 -0000)]
Mark Lord writes:
The config file processing for inetd in busybox-1.00-pre7 and newer
is broken -- the saved command argv[] values overwrite each other.
Patch to fix it is attached.
Cheers
--
Mark Lord
Real-Time Remedies Inc.
Glenn L McGrath [Tue, 17 Feb 2004 12:22:21 +0000 (12:22 -0000)]
Add the -r option, patch from Rob with some help from myself.
Glenn L McGrath [Tue, 17 Feb 2004 12:04:13 +0000 (12:04 -0000)]
Remove debugging
Glenn L McGrath [Tue, 17 Feb 2004 11:55:06 +0000 (11:55 -0000)]
Dont strip trailing '/' until _after_ i test to set if its there !
Manuel Novoa III [Tue, 17 Feb 2004 10:16:21 +0000 (10:16 -0000)]
Patch from Florian Schirmer <jolt@tuxbox.org>. When I rewrote the parser,
I overlooked the case of someone wanting to use a valid but empty suid
config file.
Glenn L McGrath [Tue, 17 Feb 2004 07:58:04 +0000 (07:58 -0000)]
Woops, im getting ahead of myself, we dont have the -r (refernece)
option yet
Glenn L McGrath [Tue, 17 Feb 2004 07:51:31 +0000 (07:51 -0000)]
define option names to be clearer, simplify nested if statements, remove
un-needed if statement, minor indenting change
Eric Andersen [Sat, 14 Feb 2004 21:33:39 +0000 (21:33 -0000)]
Avoid naming conflict with symbol in newer glibc headers
Eric Andersen [Fri, 13 Feb 2004 08:09:43 +0000 (08:09 -0000)]
Accomodate the fact that newer libc versions may in fact not
contain query_module and friends and more
Eric Andersen [Tue, 10 Feb 2004 01:30:21 +0000 (01:30 -0000)]
oops. Leave the default feature set enbled for now...
Eric Andersen [Tue, 10 Feb 2004 01:28:36 +0000 (01:28 -0000)]
Initial effort at disabling job control as well
Eric Andersen [Tue, 10 Feb 2004 01:07:45 +0000 (01:07 -0000)]
Support disabling pipe and redirect support
Eric Andersen [Mon, 9 Feb 2004 10:57:04 +0000 (10:57 -0000)]
Update URL
Eric Andersen [Mon, 9 Feb 2004 10:01:01 +0000 (10:01 -0000)]
Buffalo appears to have resolved their GPL problems
Eric Andersen [Fri, 6 Feb 2004 10:36:08 +0000 (10:36 -0000)]
Richard Kojedzinszky writes:
Hi All,
I aplogoize for the mistake, but i have just recognized that somehow the
last patch I sent in was wrong, and a '0' was instead of a '-1'. Because
of this, vi does behave the wrong way. So again, it should be the last
patch for vi. This is for pre7.
Eric Andersen [Fri, 6 Feb 2004 10:33:19 +0000 (10:33 -0000)]
Patch from vodz, based on bug report from Richard Kojedzinszky:
Richard,
>I have a problem, which I can reproduce now. I am using pre7 version of
>busybox, and the tab completion works fine. I mean, with an empty command
>line I press the TAB twice, and ash shows me the available commands. But
>when i process the profile file below, as
> $ . /etc/profile
>then it stops working, and the double-tab lists the directories available
>from the cwd, and not the commands. Has someone else meet this problem
>before, or am i doing something wrong?
>
>This is my '/etc/profile':
>- ---
># System profile
>
>PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin
>export PATH
>trap ":" INT QUIT TERM
>
>export PS1="\h \w # "
Thanks. Patch attached.
--w
vodz
Eric Andersen [Fri, 6 Feb 2004 07:16:36 +0000 (07:16 -0000)]
Make the loop support stuff be much less evil, and make it cope
with 2.6.x asm/posix_types.h, which has done singularly evil thing
by yanking __kernel_dev_t and renaming it. The loop interface was
really poorly designed in the first place. The new 64 bit loop
interface looks to be somewhat less horrible, too bad it is only
present in 2.6.x kernels.
-Erik
Eric Andersen [Fri, 6 Feb 2004 05:26:58 +0000 (05:26 -0000)]
Eliminate use of a kernel scsi header file.
Prevent potentially misaligned accesses while indexing a pointer
to the partition table, which would be a bad thing on i.e. arm.
Manuel Novoa III [Thu, 5 Feb 2004 14:45:58 +0000 (14:45 -0000)]
Make sure stdlib.h is always included before dmalloc.h to avoid problems
parsing problems.
Eric Andersen [Thu, 5 Feb 2004 13:52:03 +0000 (13:52 -0000)]
Vladimir N. Oleynik writes:
Hi, Glenn.
Current CVS "ls" applet have small problem: some options
ignoring. Last patch attached ;-)
--w
vodz
Eric Andersen [Thu, 5 Feb 2004 13:49:29 +0000 (13:49 -0000)]
Vladimir N. Oleynik writes:
Ok. I found my mistake :(
The trivial patch attached.
--w
vodz
Eric Andersen [Thu, 5 Feb 2004 00:18:26 +0000 (00:18 -0000)]
Elaborate on CONFIG_SELINUX, and explain that most people should
not enbable this option.
Eric Andersen [Wed, 4 Feb 2004 12:07:40 +0000 (12:07 -0000)]
Grammar fix
Eric Andersen [Wed, 4 Feb 2004 11:59:48 +0000 (11:59 -0000)]
Minor grammar fixup
Eric Andersen [Wed, 4 Feb 2004 11:44:58 +0000 (11:44 -0000)]
Bump version number for release
Eric Andersen [Wed, 4 Feb 2004 11:19:44 +0000 (11:19 -0000)]
Richard Kojedzinszky writes:
Hi,
I've noticed the bug also, and here is another patch for it. I hope it'll
not introduce more bugs. Not too nice, but works for me.
Here it is for busybox-1.00-pre6
Eric Andersen [Wed, 4 Feb 2004 11:10:28 +0000 (11:10 -0000)]
Joe.C writes:
Hi,
When httpd connection is closed, bosybox httpd will
not stop reading from CGI program. This patch fix this
problem. It check the return value of bb_full_write and
stop reading from CGI if the connection is closed.
Please apply this patch.
Joe.C
Eric Andersen [Wed, 4 Feb 2004 11:01:19 +0000 (11:01 -0000)]
Jean Wolter writes:
Hello,
when calling seq with
seq 1 1
it generates an "endless" list of numbers until the counter wraps and
reaches 1 again. The follwoing small patch should introduce the
expected behavior (output of 1 and termination):
regards,
Jean
Eric Andersen [Wed, 4 Feb 2004 10:57:46 +0000 (10:57 -0000)]
Rob Landley writes:
While building glibc with busybox as part of the development environment, I
found a bug in glibc's regexec can throw sed into an endless loop. This
fixes it. Should I put an #ifdef around it or something? (Note, this patch
also contains the "this is not gnu sed 4.0" hack I posted earlier, which is
also needed to build glibc...)
Eric Andersen [Wed, 4 Feb 2004 10:48:37 +0000 (10:48 -0000)]
The variable 'complementaly' used to be allocated with calloc, which zeroed it
out during the allocation process. When vodz changed it to be allocated on the
stack, he forgot to explicitly zero it, leaving its value filled with whatever
used to be sitting on the stack. It would garbage values, depending on the
garbage that happened to be sitting on the stack when the function was called.
The result was that applets using bb_getopt_ulflags() were showing
unpredictable behavior (such as segfaults), which naturally broke many things.