oweals/cde.git
5 years agoprograms/dtlogin: add automake file
Chase [Wed, 23 Oct 2019 19:43:28 +0000 (14:43 -0500)]
programs/dtlogin: add automake file

5 years agoprograms/dtksh: add automake files
Chase [Wed, 23 Oct 2019 19:42:30 +0000 (14:42 -0500)]
programs/dtksh: add automake files

5 years agoprograms/dtimsstart: add automake file
Chase [Wed, 23 Oct 2019 19:34:06 +0000 (14:34 -0500)]
programs/dtimsstart: add automake file

5 years agoprograms/dticon: add automake file
Chase [Wed, 23 Oct 2019 19:33:21 +0000 (14:33 -0500)]
programs/dticon: add automake file

5 years agoprograms/dthelp: add automake files
Chase [Wed, 23 Oct 2019 19:31:08 +0000 (14:31 -0500)]
programs/dthelp: add automake files

5 years agoprograms/dtinfo: add automake files
Chase [Wed, 23 Oct 2019 19:26:33 +0000 (14:26 -0500)]
programs/dtinfo: add automake files

5 years agoprograms/dthello: add automake file
Chase [Wed, 23 Oct 2019 19:25:12 +0000 (14:25 -0500)]
programs/dthello: add automake file

5 years agoprograms/dtfile: add automake files
Chase [Wed, 23 Oct 2019 19:21:06 +0000 (14:21 -0500)]
programs/dtfile: add automake files

5 years agoprograms/dtexec: add automake files
Chase [Wed, 23 Oct 2019 19:20:22 +0000 (14:20 -0500)]
programs/dtexec: add automake files

5 years agoprograms/dtdspmsg: add automake file
Chase [Wed, 23 Oct 2019 18:53:39 +0000 (13:53 -0500)]
programs/dtdspmsg: add automake file

5 years agoprograms/dtdocbook: add automake files
Chase [Wed, 23 Oct 2019 03:10:10 +0000 (22:10 -0500)]
programs/dtdocbook: add automake files

5 years agoprograms/dtdbcache: add automake files
Chase [Wed, 23 Oct 2019 03:09:11 +0000 (22:09 -0500)]
programs/dtdbcache: add automake files

5 years agoprograms/dtcreate: add automake files
Chase [Wed, 23 Oct 2019 03:01:50 +0000 (22:01 -0500)]
programs/dtcreate: add automake files

5 years agoprograms/dtconfig: add automake files
Chase [Wed, 23 Oct 2019 03:00:59 +0000 (22:00 -0500)]
programs/dtconfig: add automake files

5 years agoprograms/dtcm: add automake files
Chase [Wed, 23 Oct 2019 02:55:04 +0000 (21:55 -0500)]
programs/dtcm: add automake files

5 years agoprograms/dtcalc: add automake files
Chase [Wed, 23 Oct 2019 02:53:03 +0000 (21:53 -0500)]
programs/dtcalc: add automake files

5 years agoprograms/dtappintegrate: add automake file
Chase [Wed, 23 Oct 2019 02:41:59 +0000 (21:41 -0500)]
programs/dtappintegrate: add automake file

5 years agoprograms/dtappbuilder: add automake files
Chase [Wed, 23 Oct 2019 02:40:40 +0000 (21:40 -0500)]
programs/dtappbuilder: add automake files

5 years agoprograms/dtaction: add automake file
Chase [Wed, 23 Oct 2019 02:34:58 +0000 (21:34 -0500)]
programs/dtaction: add automake file

5 years agoprograms/dsdm: add automake files
Chase [Wed, 23 Oct 2019 02:17:34 +0000 (21:17 -0500)]
programs/dsdm: add automake files

5 years agoprograms/backdrops: add automake files
Chase [Wed, 23 Oct 2019 02:16:33 +0000 (21:16 -0500)]
programs/backdrops: add automake files

5 years agoprograms: add automake file
Chase [Wed, 23 Oct 2019 01:16:09 +0000 (20:16 -0500)]
programs: add automake file

5 years agologs: add automake files
Chase [Wed, 23 Oct 2019 01:13:03 +0000 (20:13 -0500)]
logs: add automake files

5 years agolib/tt: add automake files
Chase [Wed, 23 Oct 2019 01:03:28 +0000 (20:03 -0500)]
lib/tt: add automake files

5 years agolib/pam: add automake files:
Chase [Wed, 23 Oct 2019 01:02:44 +0000 (20:02 -0500)]
lib/pam: add automake files:

5 years agolib/csa: add automake file
Chase [Wed, 23 Oct 2019 01:00:07 +0000 (20:00 -0500)]
lib/csa: add automake file

5 years agolib: add automake file
Chase [Tue, 22 Oct 2019 23:34:59 +0000 (18:34 -0500)]
lib: add automake file

5 years agolib/DtXinerama: add automake file
Chase [Tue, 22 Oct 2019 23:34:20 +0000 (18:34 -0500)]
lib/DtXinerama: add automake file

5 years agolib/DtWidget: add automake file
Chase [Tue, 22 Oct 2019 23:31:00 +0000 (18:31 -0500)]
lib/DtWidget: add automake file

5 years agolib/DtTerm: add automake files
Chase [Tue, 22 Oct 2019 23:22:51 +0000 (18:22 -0500)]
lib/DtTerm: add automake files

5 years agolib/DtSvc: add automake files
Chase [Tue, 22 Oct 2019 23:20:04 +0000 (18:20 -0500)]
lib/DtSvc: add automake files

5 years agolib/DtSearch: add automake files
Chase [Tue, 22 Oct 2019 23:19:18 +0000 (18:19 -0500)]
lib/DtSearch: add automake files

5 years agolib/DtPrint: add automake file
Chase [Tue, 22 Oct 2019 23:16:45 +0000 (18:16 -0500)]
lib/DtPrint: add automake file

5 years agolib/DtMrm: add automake file
Chase [Tue, 22 Oct 2019 23:15:49 +0000 (18:15 -0500)]
lib/DtMrm: add automake file

5 years agolib/DtHelp: add automakefiles
Chase [Tue, 22 Oct 2019 17:05:06 +0000 (12:05 -0500)]
lib/DtHelp: add automakefiles

5 years agoinclude: add makefile
Chase [Sun, 20 Oct 2019 02:45:16 +0000 (21:45 -0500)]
include: add makefile

5 years agodoc/LANG: add makefiles
Chase [Sun, 20 Oct 2019 02:26:51 +0000 (21:26 -0500)]
doc/LANG: add makefiles

5 years agodoc/util: add automake files
Chase [Sun, 20 Oct 2019 02:16:50 +0000 (21:16 -0500)]
doc/util: add automake files

5 years agodoc/common: add makefiles
Chase [Sun, 20 Oct 2019 02:08:04 +0000 (21:08 -0500)]
doc/common: add makefiles

5 years agodoc/C: Add makefiles
Chase [Sun, 20 Oct 2019 01:35:03 +0000 (20:35 -0500)]
doc/C: Add makefiles

5 years agoAdd top level automake files
Chase [Sun, 20 Oct 2019 01:31:18 +0000 (20:31 -0500)]
Add top level automake files

5 years agottserver: fixup forward (vexing) fucntion decl's in main, get rid of **environ
Jon Trulson [Sun, 20 Oct 2019 00:36:54 +0000 (18:36 -0600)]
ttserver: fixup forward (vexing) fucntion decl's in main, get rid of **environ

5 years agoRemove all optional compile flags from dtwm that are not referenced anywhere, and...
wmoxam [Mon, 14 Oct 2019 04:31:57 +0000 (00:31 -0400)]
Remove all optional compile flags from dtwm that are not referenced anywhere, and are unlikely to ever be used

5 years agodtmail: fix extra format args warnings
Jon Trulson [Wed, 16 Oct 2019 03:22:11 +0000 (21:22 -0600)]
dtmail: fix extra format args warnings

5 years agodtmail: fix NULL char embedded in format string
Jon Trulson [Wed, 16 Oct 2019 03:12:17 +0000 (21:12 -0600)]
dtmail: fix NULL char embedded in format string

5 years ago'notdef' means it's not used, so we remove it
wmoxam [Mon, 14 Oct 2019 03:33:24 +0000 (23:33 -0400)]
'notdef' means it's not used, so we remove it

5 years agoRemove ancient HP VUE compatibility support
wmoxam [Mon, 14 Oct 2019 13:39:50 +0000 (09:39 -0400)]
Remove ancient HP VUE compatibility support

5 years agoRemove old jpeg files
Chase [Mon, 14 Oct 2019 23:46:55 +0000 (18:46 -0500)]
Remove old jpeg files

5 years agoRemove 'oldcode'
wmoxam [Mon, 14 Oct 2019 03:15:52 +0000 (23:15 -0400)]
Remove 'oldcode'

5 years agoRemove legacysun code blocks
wmoxam [Mon, 14 Oct 2019 03:12:13 +0000 (23:12 -0400)]
Remove legacysun code blocks

5 years agoRemove unused HP_EXTENSIONS code blocks
wmoxam [Mon, 14 Oct 2019 02:28:38 +0000 (22:28 -0400)]
Remove unused HP_EXTENSIONS code blocks

5 years agodtpad: emit error on catopen() failure
Jon Trulson [Mon, 14 Oct 2019 20:42:21 +0000 (14:42 -0600)]
dtpad: emit error on catopen() failure

This patch was manually added via a diff supplied from a user on the
CDE mailing list: Michele Ghisolfo <ghisolfo.m@gmail.com>

5 years agodtfile: Add scroll wheel support
Jon Trulson [Mon, 14 Oct 2019 20:34:56 +0000 (14:34 -0600)]
dtfile: Add scroll wheel support

This patch was manually added via a diff supplied from a user on the
CDE mailing list: Michele Ghisolfo <ghisolfo.m@gmail.com>

5 years agodtcalc: increase highlight thickness to match Solaris CDE
Jon Trulson [Mon, 14 Oct 2019 20:30:58 +0000 (14:30 -0600)]
dtcalc: increase highlight thickness to match Solaris CDE

This patch was manually added via a diff supplied from a user on the
CDE mailing list: Michele Ghisolfo <ghisolfo.m@gmail.com>

5 years agodtterm: add scroll wheel support
Jon Trulson [Mon, 14 Oct 2019 20:08:43 +0000 (14:08 -0600)]
dtterm: add scroll wheel support

This patch was manually added via a diff supplied from a user on the
CDE mailing list: Michele Ghisolfo <ghisolfo.m@gmail.com>

5 years agoRemove NOTDONE code
wmoxam [Mon, 14 Oct 2019 03:41:22 +0000 (23:41 -0400)]
Remove NOTDONE code

5 years agolinux: build all languages by default again
Jon Trulson [Mon, 14 Oct 2019 03:11:59 +0000 (21:11 -0600)]
linux: build all languages by default again

Someday we should be able to detect which languages are installed and
only build support for those.  Until then, build them all.

5 years agoMerge /u/jrubio/cdesktopenv/ branch discarded-qualifiers into master
Jon Trulson [Sun, 13 Oct 2019 17:09:04 +0000 (17:09 +0000)]
Merge /u/jrubio/cdesktopenv/ branch discarded-qualifiers into master

https://sourceforge.net/p/cdesktopenv/code/merge-requests/17/

5 years agoMerge /u/jrubio/cdesktopenv/ branch delete-incomplete into master
Jon Trulson [Sun, 13 Oct 2019 17:06:14 +0000 (17:06 +0000)]
Merge /u/jrubio/cdesktopenv/ branch delete-incomplete into master

https://sourceforge.net/p/cdesktopenv/code/merge-requests/18/

5 years agoget rid of the 'extern sys_errlist' and 'sys_nerr' in SysErrorMsg.
Jose Rubio [Sun, 13 Oct 2019 08:19:00 +0000 (10:19 +0200)]
get rid of the 'extern sys_errlist' and 'sys_nerr' in SysErrorMsg.

5 years agoMerge /u/jrubio/cdesktopenv/ branch incompatible-pointer-types into master 2.3.0a
Jon Trulson [Sat, 12 Oct 2019 21:43:45 +0000 (21:43 +0000)]
Merge /u/jrubio/cdesktopenv/ branch incompatible-pointer-types into master

https://sourceforge.net/p/cdesktopenv/code/merge-requests/16/

5 years agoFixes for a few -Wincompatible-pointer-types
Jose Rubio [Sat, 12 Oct 2019 20:29:44 +0000 (22:29 +0200)]
Fixes for a few -Wincompatible-pointer-types

5 years agoMerge /u/jrubio/cdesktopenv/ branch int-conversion into master
Jon Trulson [Fri, 11 Oct 2019 23:58:44 +0000 (23:58 +0000)]
Merge /u/jrubio/cdesktopenv/ branch int-conversion into master

https://sourceforge.net/p/cdesktopenv/code/merge-requests/14/

5 years agoFix to delete-incomplete warnings.
Jose Rubio [Fri, 11 Oct 2019 11:43:08 +0000 (13:43 +0200)]
Fix to delete-incomplete warnings.

5 years agoFix to compile warnings.
Jose Rubio [Fri, 11 Oct 2019 08:49:48 +0000 (10:49 +0200)]
Fix to compile warnings.

* discarded-qualifiers warnings.
* Function definitions, the .h doesn't match the .c.
* Added some include to ensure the .c has function definition.

5 years agoFix to different compile warnings.
Jose Rubio [Thu, 10 Oct 2019 17:25:07 +0000 (19:25 +0200)]
Fix to different compile warnings.

Fix to multiple int-conversion
Removal of duplicated function definition in dtudcfonted/util.h
Added XtEventHandler prototypes to mtfgui

5 years agoFix to Wenum-compare
Jose Rubio [Thu, 10 Oct 2019 15:01:56 +0000 (17:01 +0200)]
Fix to Wenum-compare

It seems the purpose is to define a constant as an anonymous enum.
that behaviour triggers the enum  compare. Let's make it a constant.

5 years agoFix openbsd compile build errors due to dependency on libiconv
Jose Rubio [Fri, 27 Sep 2019 19:54:06 +0000 (21:54 +0200)]
Fix openbsd compile build errors due to dependency on libiconv

The path to libiconv is selected in config/cf/OpenBSD.cf reusing the
same trick  as FreeBSD does.

5 years agoMerge branch 'linux-suse-tcl-link' of https://git.code.sf.net/u/jrubio/cdesktopenv...
Jose Rubio [Mon, 16 Sep 2019 12:59:24 +0000 (14:59 +0200)]
Merge branch 'linux-suse-tcl-link' of https://git.code.sf.net/u/jrubio/cdesktopenv into linux-suse-tcl-link

5 years agoLink TCL libraries and restrict tcl8.6 to SuSE only.
Jose Rubio [Sun, 15 Sep 2019 17:01:17 +0000 (19:01 +0200)]
Link TCL libraries and restrict tcl8.6 to SuSE only.

5 years agoUpdate TCL libraries link and restrict tcl8.6 only to SuSE.
Jose Rubio [Sun, 15 Sep 2019 17:01:17 +0000 (19:01 +0200)]
Update TCL libraries link and restrict tcl8.6 only to SuSE.

5 years agoMerge /u/jrubio/cdesktopenv/ branch implicit-int into master
Jon Trulson [Thu, 12 Sep 2019 22:14:19 +0000 (22:14 +0000)]
Merge /u/jrubio/cdesktopenv/ branch implicit-int into master

https://sourceforge.net/p/cdesktopenv/code/merge-requests/9/

5 years agoMerge /u/jrubio/cdesktopenv/ branch pointer-compare into master
Jon Trulson [Thu, 12 Sep 2019 22:11:52 +0000 (22:11 +0000)]
Merge /u/jrubio/cdesktopenv/ branch pointer-compare into master

https://sourceforge.net/p/cdesktopenv/code/merge-requests/8/

5 years agoMerge /u/jrubio/cdesktopenv/ branch linux_aarch64 into master
Jon Trulson [Thu, 12 Sep 2019 22:05:43 +0000 (22:05 +0000)]
Merge /u/jrubio/cdesktopenv/ branch linux_aarch64 into master

https://sourceforge.net/p/cdesktopenv/code/merge-requests/6/

5 years agoMerge /u/jrubio/cdesktopenv/ branch dtksh_include_sys_sysmacros into master
Jon Trulson [Thu, 12 Sep 2019 22:02:51 +0000 (22:02 +0000)]
Merge /u/jrubio/cdesktopenv/ branch dtksh_include_sys_sysmacros into master

https://sourceforge.net/p/cdesktopenv/code/merge-requests/10/

5 years agoFix for deprecated warnings related to gnu libc sys macros.
Jose Rubio [Thu, 12 Sep 2019 11:10:02 +0000 (13:10 +0200)]
Fix for deprecated warnings related to gnu libc sys macros.

The patch only includes sysmacros for linux, the only target with gnu libc to avoid regression issues.

5 years agoisfname.c: remove register keyword
Jon Trulson [Wed, 11 Sep 2019 23:48:06 +0000 (17:48 -0600)]
isfname.c: remove register keyword

5 years agoksh/libast: include sys/sysmacros.h in fmtdev.c for linux systems
Jon Trulson [Wed, 11 Sep 2019 23:30:55 +0000 (17:30 -0600)]
ksh/libast: include sys/sysmacros.h in fmtdev.c for linux systems

Fix scraped from CDE forum post:
https://sourceforge.net/p/cdesktopenv/discussion/general/thread/24d7511a39/

5 years agoFIX: Define Aarch64 as little endian so DtInfo compiles.
Jose Rubio [Thu, 29 Aug 2019 09:12:26 +0000 (11:12 +0200)]
FIX: Define Aarch64 as little endian so DtInfo compiles.

5 years agoFixes for warnings related to -Wimplicit-int.
Jose Rubio [Tue, 20 Aug 2019 10:52:43 +0000 (12:52 +0200)]
Fixes for warnings related to -Wimplicit-int.

5 years agoCleanup of -Wpointer-compare warnings.
Jose Rubio [Mon, 19 Aug 2019 16:02:25 +0000 (18:02 +0200)]
Cleanup of -Wpointer-compare warnings.

5 years agoAdded linux/aarch64 as valid target.
Jose Rubio [Mon, 19 Aug 2019 14:55:11 +0000 (16:55 +0200)]
Added linux/aarch64 as valid target.

5 years agodtprintinfo: remove SUID root on install
Jon Trulson [Tue, 7 May 2019 00:32:14 +0000 (18:32 -0600)]
dtprintinfo: remove SUID root on install

This program should not be SUID root.  If you need it's services, just
run

sudo dtprintinfo -populate

TODO: dtprintinfo should only create it's actions (if ever) in a
user's .dt/types/ directory and not in any system-wide dirs.  No need
for root access at all.

5 years agodtprintinfo: correct another possible buffer overflow
Jon Trulson [Tue, 7 May 2019 00:23:36 +0000 (18:23 -0600)]
dtprintinfo: correct another possible buffer overflow

5 years agodtprintinfo: Fix a potential exploitable buffer overrun
Jon Trulson [Mon, 6 May 2019 23:55:49 +0000 (17:55 -0600)]
dtprintinfo: Fix a potential exploitable buffer overrun

This fixes a potentially exploitable buffer overrun in dtprintinfo.
This was brought to my attention based on a 0day exploit released for
Solaris CDE.

The exploit code does not work (or build) on linux, and the overrun is
in the heap rather than the stack as on Solaris, but it's easy to see
how this could be exploited.

The following is the content of the advisory:

8<-----------------------------------------------------------

@Mediaservice.net (Cybaze Group) Security Advisory #2019-01 (2019-05-07)

         Title: Local privilege escalation via CDE dtprintinfo
   Application: Common Desktop Environment 2.3.0 and earlier
     Platforms: Oracle Solaris 10 1/13 (Update 11) and earlier
   Description: A local attacker can gain root privileges by exploiting
a buffer overflow in CDE dtprintinfo
        Author: Marco Ivaldi <marco.ivaldi@mediaservice.net>
   Contributor: Dave Aitel <dave.aitel@cyxtera.com> (original discovery)
 Vendor Status: <secalert_us@oracle.com> notified on 2019-05-05
<cdesktopenv-devel@lists.sourceforge.net> notified on 2019-05-05
           CVE: The Common Vulnerabilities and Exposures project has not assigned
a name to this issue yet
    References: https://lab.mediaservice.net/advisory/2019-01-cde-dtprintinfo.txt
https://github.com/0xdea/raptor_infiltrate19
https://sourceforge.net/p/cdesktopenv/wiki/Home/
https://www.oracle.com/technetwork/server-storage/solaris10/
https://www.mediaservice.net/
https://infiltratecon.com/

1. Abstract.

A buffer overflow in the DtPrinterAction::PrintActionExists() function in the
Common Desktop Environment 2.3.0 and earlier, as used in Oracle Solaris 10 1/13
(Update 11) and earlier, allows local users to gain root privileges via a long
printer name passed to dtprintinfo by a malicious lpstat program.

This is a 0day vulnerability demonstrated at #INFILTRATE19 on May 2nd, 2019 in
the talk "A bug's life: story of a Solaris 0day".

2. Example Attack Session.

bash-3.2$ cat /etc/release
                    Oracle Solaris 10 1/13 s10x_u11wos_24a X86
  Copyright (c) 1983, 2013, Oracle and/or its affiliates. All rights reserved.
                            Assembled 17 January 2013
bash-3.2$ uname -a
SunOS nostalgia 5.10 Generic_147148-26 i86pc i386 i86pc
bash-3.2$ id
uid=54322(raptor) gid=1(other)
bash-3.2$ gcc raptor_dtprintname_intel.c -o raptor_dtprintname_intel -Wall
bash-3.2$ ./raptor_dtprintname_intel 192.168.1.1:0
raptor_dtprintname_intel.c - dtprintinfo 0day, Solaris/Intel
Copyright (c) 2004-2019 Marco Ivaldi <raptor@0xdeadbeef.info>

Using SI_PLATFORM       : i86pc (5.10)
Using stack base        : 0x8047fff
Using rwx_mem address   : 0xfeffa004
Using sc address        : 0x8047f60
Using strcpy() address  : 0xfefe26a0

lpstat called with -v
lpstat called with -v
lpstat called with -d
uid=0(root) gid=1(other)

3. Affected Platforms.

All platforms shipping the Common Desktop Environment are potentially
affected. This includes:

* Oracle Solaris 10 1/13 (Update 11) and earlier [default installation]

According to the CDE Wiki, the following platforms are officially supported:

* All Official Ubuntu variants 12.04 - 18.04
* Debian 6, 7, 8, 9
* Fedora 17 at least
* Archlinux
* Red Hat
* Slackware 14.0
* OpenBSD
* NetBSD
* FreeBSD 9.2, 10.x, 11.x
* openSUSE Tumbleweed (gcc7)
* openSUSE Leap 4.2 (gcc4)
* SUSE 12 SP3 (gcc4)
* Solaris, OpenIndiana

4. Fix.

The upstream CDE maintainers have issued a patch for this vulnerability. Oracle
is investigating the issue via tracking# S1153109 and is expected to release a
fix for all affected-supported versions of Solaris via their quarterly Critical
Patch Update (CPU) program.

As a temporary workaround, it is possible to remove the setuid bit from the
dtprintinfo executable as follows:

bash-3.2# chmod -s /usr/dt/bin/dtprintinfo

5. Proof of Concept.

A working exploit for Oracle Solaris 10 1/13 (Update 11) Intel has been
developed as a proof of concept. Exploits for other Solaris versions and for
the SPARC architecture are also available. All exploits can be downloaded at:

https://github.com/0xdea/raptor_infiltrate19/
https://github.com/0xdea/exploits/

8<-----------------------------------------------------------

5 years agoNLS: fix quote issue with various OS's in C/types/_common.dt.tmsg
Jon Trulson [Sun, 24 Feb 2019 19:58:31 +0000 (12:58 -0700)]
NLS: fix quote issue with various OS's in C/types/_common.dt.tmsg

5 years agoMerge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code
Jon Trulson [Sun, 24 Feb 2019 19:56:10 +0000 (12:56 -0700)]
Merge branch 'master' of ssh://git.code.sf.net/p/cdesktopenv/code

5 years agodtdockbook/instant: Add the proper paths for TCL on NetBSD
Jon Trulson [Sun, 24 Feb 2019 19:54:42 +0000 (12:54 -0700)]
dtdockbook/instant: Add the proper paths for TCL on NetBSD

Patch submitted by Danilo Pecher <danilo.pecher@data-experts.biz>

5 years agoExplicitly initialise two more static pointers
Adam Sampson [Sat, 26 Jan 2019 00:07:36 +0000 (00:07 +0000)]
Explicitly initialise two more static pointers

"dtcm: Coverity 88006" fixed this for buf, but not for string in the
same function (and we may as well initialise string_head for consistency
too).

5 years agoDon't dereference an uninitialised pointer
Adam Sampson [Sat, 26 Jan 2019 00:05:23 +0000 (00:05 +0000)]
Don't dereference an uninitialised pointer

This was an incorrect fix in "dtcm: Coverity 88382".

5 years agoAvoid a NULL pointer dereference
Adam Sampson [Sat, 26 Jan 2019 00:03:34 +0000 (00:03 +0000)]
Avoid a NULL pointer dereference

"dtcm: Coverity 89051" fixed an instance of this on the previous line,
but not this one.

5 years agoUse iconv on linux
Chase [Sat, 12 Jan 2019 22:54:57 +0000 (16:54 -0600)]
Use iconv on linux

5 years agodefine M4Cmd
Alex Ivanov [Tue, 8 Jan 2019 19:13:32 +0000 (22:13 +0300)]
define M4Cmd

5 years agoFixed segfault for mode switching when compiled with clang
tu83 [Sun, 6 Jan 2019 17:55:19 +0000 (18:55 +0100)]
Fixed segfault for mode switching when compiled with clang

dtcalc compiled with clang segfaulted when switched
to a different mode like Deg to Rad or Financial to
Scientific. Was reproducable at least under FreeBSD/AMD64.
Fixed now.

6 years agodtcalc/calctool.h: Use include stdlib rather than extern declarations
Jon Trulson [Thu, 8 Nov 2018 21:19:25 +0000 (14:19 -0700)]
dtcalc/calctool.h: Use include stdlib rather than extern declarations

6 years agolibDtHelp: Fix another regression caused by Coverity fix, clicking 'Help Manager...
Peter Howkins [Wed, 7 Nov 2018 17:04:59 +0000 (17:04 +0000)]
libDtHelp: Fix another regression caused by Coverity fix, clicking 'Help Manager' works again.

6 years agolibDtHelp: Fix a regression with the Help Index pages caused by an overzealous Coveri...
Peter Howkins [Wed, 7 Nov 2018 01:05:56 +0000 (01:05 +0000)]
libDtHelp: Fix a regression with the Help Index pages caused by an overzealous Coverity fix

6 years agolinux: DtHelp/StringFuncs, enable real iconv() support
Jon Trulson [Mon, 5 Nov 2018 22:33:16 +0000 (15:33 -0700)]
linux: DtHelp/StringFuncs, enable real iconv() support

For some reason, the #include of iconv.h was removed, and dummy stubs
were put in place on linux systems (only).  This caused iconv() calls
to be completely ignored.

Now we use iconv() just like very other OS we support.

6 years agoMerge branch 'master' into cde-next
Jon Trulson [Sun, 4 Nov 2018 17:56:04 +0000 (10:56 -0700)]
Merge branch 'master' into cde-next

6 years agoRepair and simplify installCDE.src:CleanDaemons()
Matthew R. Trower [Tue, 30 Oct 2018 13:56:44 +0000 (08:56 -0500)]
Repair and simplify installCDE.src:CleanDaemons()