Ulrich Weber [Wed, 23 Apr 2014 12:33:04 +0000 (12:33 +0000)]
netifd: fix IPv6 Link-local DNS server
interface name must be added to Link-local IPv6
DNS servers, otherwise they are unusable.
Signed-off-by: Ulrich Weber <uw@ocedo.com>
Felix Fietkau [Mon, 21 Apr 2014 17:11:34 +0000 (19:11 +0200)]
config: add support for disabling interfaces
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 19 Apr 2014 09:58:16 +0000 (11:58 +0200)]
ubus: check the l3_dev pointer before dereferencing it
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 19 Apr 2014 09:57:50 +0000 (11:57 +0200)]
interface: ensure that l3_dev gets set whenever the proto handler marks the interface as up
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Fri, 11 Apr 2014 13:41:15 +0000 (15:41 +0200)]
interface: add support for a parameter to force setup without a carrier on the underlying device
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Thu, 10 Apr 2014 15:21:21 +0000 (17:21 +0200)]
proto-static: ensure that the l3 device is properly set
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Thu, 10 Apr 2014 11:30:54 +0000 (13:30 +0200)]
proto-shell: fix a regression with handling multiple proto updates for the same interface
Preserve the device when keep == true
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Mon, 7 Apr 2014 11:09:09 +0000 (13:09 +0200)]
proto-shell: ensure that l3_dev is always set
A link-down event clears l3_dev, so even if the proto handler does not
provide a new ifname, it still needs to be set explicitly
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 5 Apr 2014 17:58:01 +0000 (19:58 +0200)]
interface: always delete l3 dev on proto down
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 5 Apr 2014 17:57:37 +0000 (19:57 +0200)]
system-dummy: indicate link on present devices
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Mon, 31 Mar 2014 20:23:35 +0000 (22:23 +0200)]
config: ignore config parser errors
This helps with keeping routers reachable when there are typos in the
network config.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Fri, 21 Mar 2014 15:08:32 +0000 (16:08 +0100)]
ubus: use list_empty() instead of the compat wrapper
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Helmut Schaa [Thu, 20 Mar 2014 15:26:23 +0000 (16:26 +0100)]
netifd: Reload proto on topology change
Introduce a new device event "topology change" that gets signaled
by bridges on adding/removing members.
On "topology changes" the proto handlers are requested to "renew"
which is most useful for DHCP.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Felix Fietkau [Thu, 20 Mar 2014 20:02:02 +0000 (21:02 +0100)]
ubus: fix displaying interface data items
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Hans Dedecker [Thu, 20 Mar 2014 07:59:04 +0000 (08:59 +0100)]
netifd: Check interface autostart parameter when handling interface state changes
Fixes an issue when 2 interfaces make use of the same ifname (device) and one of the interfaces has autostart disabled; bringing up the other interface would also start the interface for which autostart is disabled (link_state and enabled will both be true for the autostart disabled interface and thus a setup will be launched)
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Matthias Schiffer [Tue, 4 Mar 2014 17:37:03 +0000 (18:37 +0100)]
uci: Allow setting the UCI config path on the command line
Add a -c switch which allows setting an alternative UCI path instead of using
the libuci default.
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Felix Fietkau [Tue, 11 Mar 2014 09:24:28 +0000 (10:24 +0100)]
Revert "ubus events: don't incorrectly announce an interface as being up"
Made obsolete by
b114b86c70766f67f503077ad1de013c17fbf366
This reverts commit
4d1a597f65bbb49aa843112812d5ca929478c706.
Hans Dedecker [Mon, 10 Mar 2014 15:27:53 +0000 (16:27 +0100)]
netifd: Set interface state in teardown state before launching an interface event
Interface state needs to be set in teardown state before launching an interface event otherwise the up state will be reported as true in the ubus interface notify message
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Mon, 10 Mar 2014 15:27:52 +0000 (16:27 +0100)]
netifd: Assign interface metric to route metric when route is created
Interface metric needs to be assigned to the route metric parameter at route creation time. Otherwise if the interface metric is different from 0 route_cmp will wrongly conclude the routes are different.
In this case the route will be added/deleted and could end up with the route missing in the kernel depending on the add/delete order.
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Mon, 10 Mar 2014 15:27:51 +0000 (16:27 +0100)]
netifd: Fix bridge MTU setting when a bridge member is added
Reapply bridge mtu setting as adding a bridge member will override the bridge mtu in the kernel
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Felix Fietkau [Fri, 7 Mar 2014 18:12:16 +0000 (19:12 +0100)]
proto-shell: defer init until after command line option processing
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Emanuel Taube [Fri, 7 Mar 2014 09:22:12 +0000 (10:22 +0100)]
netifd: fix bridge reloading issue
Check in the right order to decide if the bridge have to be set up.
Additionally we are consistent with setting it down.
Signed-off-by: Emanuel Taube <emanuel.taube@gmail.com>
Felix Fietkau [Fri, 7 Mar 2014 17:49:43 +0000 (18:49 +0100)]
wireless: defer init until after command line option processing
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Steven Barth [Wed, 5 Mar 2014 17:30:59 +0000 (18:30 +0100)]
ubus events: don't incorrectly announce an interface as being up
Signed-off-by: Steven Barth <steven@midlink.org>
Hans Dedecker [Tue, 11 Feb 2014 08:30:51 +0000 (08:30 +0000)]
netifd: Link layer state awareness support on interface level
The link layer state is monitored for a given interface; an interface will be setup
when both enabled and link layer active. Likewise an interface will be teared down
when either disabled or link layer down.
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Tue, 11 Feb 2014 08:30:20 +0000 (08:30 +0000)]
netifd: Link layer state awareness support on device level
Device layer is informed by netlink events regarding the link layer status. Link
layer status change results in a DEV_EVENT_LINK_UP/DEV_EVENT_LINK_DOWN broadcast
event for a given device.
Depends on uloop error callback patch.
Solves issue reported in https://dev.openwrt.org/ticket/14590
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Acked-by: Karl Vogel <karl.vogel@gmail.com>
Steven Barth [Wed, 26 Feb 2014 13:21:48 +0000 (14:21 +0100)]
Don't always assume routes & addresses are applied
Actually check netlink return values and remember failure.
Signed-off-by: Steven Barth <steven@midlink.org>
Felix Fietkau [Sun, 23 Feb 2014 08:09:21 +0000 (09:09 +0100)]
wireless: fix device config reload regression
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
John Crispin [Mon, 17 Feb 2014 12:12:26 +0000 (12:12 +0000)]
wireless: add a "get_validate" methode to ubus
Signed-off-by: John Crispin <blogic@openwrt.org>
John Crispin [Mon, 17 Feb 2014 12:12:25 +0000 (12:12 +0000)]
wireless: load and then ignore disabled devices
Signed-off-by: John Crispin <blogic@openwrt.org>
John Crispin [Mon, 17 Feb 2014 12:12:24 +0000 (12:12 +0000)]
add validation rules to proto static
Signed-off-by: John Crispin <blogic@openwrt.org>
John Crispin [Mon, 17 Feb 2014 12:12:23 +0000 (12:12 +0000)]
get_proto_handlers now also dumps the validation info
Signed-off-by: John Crispin <blogic@openwrt.org>
John Crispin [Mon, 17 Feb 2014 12:12:22 +0000 (12:12 +0000)]
make netifd_handler_parse_config honour the luci validation passed from the backend scripts
Signed-off-by: John Crispin <blogic@openwrt.org>
John Crispin [Mon, 17 Feb 2014 12:12:21 +0000 (12:12 +0000)]
add a helper to convert blobmsg types to luci validate rules
Signed-off-by: John Crispin <blogic@openwrt.org>
Steven Barth [Sun, 16 Feb 2014 11:16:57 +0000 (12:16 +0100)]
Work around warn_unused_result in recent gcc/libc
Steven Barth [Sun, 16 Feb 2014 11:10:57 +0000 (12:10 +0100)]
IPv6: work around dangling routes kernel issue
Steven Barth [Fri, 14 Feb 2014 20:09:05 +0000 (21:09 +0100)]
Fix source-restrictions of routes when no mask was provided
Hans Dedecker [Tue, 11 Feb 2014 08:31:24 +0000 (08:31 +0000)]
netifd : Fix ubus route src mask printing
Fix printing of route src mask attribute when it contains 3 digits
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Tue, 11 Feb 2014 08:29:36 +0000 (08:29 +0000)]
netifd : Disable netlink auto ack
Disable netlink auto ack when doing a delete in the get callback
handler to avoid race conditions resulting into stalled message
on the netlink socket.
Solves issue reported in https://dev.openwrt.org/ticket/14590
Signed-off-by: Karl Vogel <karl.vogel@gmail.com>
Acked-by: Hans Dedecker <dedeckeh@gmail.com>
Steven Barth [Mon, 20 Jan 2014 18:23:51 +0000 (19:23 +0100)]
Don't add unnecessary NOP policy rules
Steven Barth [Thu, 16 Jan 2014 23:41:49 +0000 (00:41 +0100)]
Remove automatically assigned IPv6 routing table
This puts IPv6 routes back into the main table where they are expected.
Instead the newly-fixed source-address restrictions should be used.
Steven Barth [Thu, 16 Jan 2014 23:39:40 +0000 (00:39 +0100)]
Add indicator-flags to ubus and hotplug update-events
Felix Fietkau [Sun, 29 Dec 2013 02:27:36 +0000 (03:27 +0100)]
wireless: fix alignment of wireless config structs - fixes segfaults on arm
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 28 Dec 2013 14:20:56 +0000 (15:20 +0100)]
wireless: cancel the script check timer
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Mon, 16 Dec 2013 10:06:57 +0000 (11:06 +0100)]
device: prevent callbacks to device users that have been cleaned up already
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 14 Dec 2013 14:51:13 +0000 (15:51 +0100)]
Revert "netifd: Link layer state support on device level"
This reverts commit
c439b52400978dd3799c66e1f632ee68d2c7c9eb.
Felix Fietkau [Sat, 14 Dec 2013 14:51:06 +0000 (15:51 +0100)]
Revert "netifd: Link layer state support on interface level"
This reverts commit
7335c3e19ea09674245dda3653d3f40705e68d6b.
Steven Barth [Thu, 12 Dec 2013 13:43:39 +0000 (14:43 +0100)]
Set dynamic interface flag after adding them so the version is preserved
Felix Fietkau [Wed, 11 Dec 2013 18:21:35 +0000 (19:21 +0100)]
wireless: remove the no_delete flag, remove virtual interfaces from the avl tree
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Wed, 11 Dec 2013 18:20:19 +0000 (19:20 +0100)]
wireless: fix handling of wdev->config_state, prevent handling of multiple state changes (reload + remove)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Wed, 11 Dec 2013 18:19:11 +0000 (19:19 +0100)]
wireless: remove freed wireless devices from the vlist avl tree
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Steven Barth [Wed, 11 Dec 2013 09:54:37 +0000 (10:54 +0100)]
IPv6: Remove IPv6 source-routing workaround (kernel is fixed)
Signed-off-by: Steven Barth <steven@midlink.org>
Felix Fietkau [Sun, 8 Dec 2013 17:57:40 +0000 (18:57 +0100)]
wireless: add back support for multiple networks per interface
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Hans Dedecker [Tue, 19 Nov 2013 11:17:09 +0000 (12:17 +0100)]
netifd: Link layer state support on interface level
Patch implements handling of link layer support on interface level.
An interface will go into the setup state when it's enabled and the
underlying link state is enabled. Vice versa an interface will go to
the down state when it's either disabled or underlying link state is
disabled.
Testing has been done with PPP, IPoE, tunnel and static interfaces
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Tue, 19 Nov 2013 11:17:08 +0000 (12:17 +0100)]
netifd: Link layer state support on device level
Patch implements link layer state awareness (aka carrier detection) in
netifd on device level.
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Tue, 19 Nov 2013 11:17:07 +0000 (12:17 +0100)]
netifd: Code style line/clean up
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Tue, 19 Nov 2013 11:17:06 +0000 (12:17 +0100)]
Tunnel don't fragment bit configurable
Make tunnel don't fragment bit configurable via UCI
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Tue, 19 Nov 2013 11:17:05 +0000 (12:17 +0100)]
netifd: Apply tunnel MTU
Tunnel MTU is applied according to the tunnel MTU UCI parameter
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Tue, 19 Nov 2013 11:17:04 +0000 (12:17 +0100)]
netifd: Don't export default route via UBUS when disabled
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Tue, 19 Nov 2013 11:17:03 +0000 (12:17 +0100)]
netifd: Export ip4table/ip6table via UBUS
Export ip4table/ip6table parameters via UBUS to facilitate
route inspection and usage by other applications
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Hans Dedecker [Tue, 19 Nov 2013 11:17:02 +0000 (12:17 +0100)]
netifd: Routing table parameter needs to be checked in route update
Routing table parameter needs to be checked in interface_update_proto_route; a route which
has an identical nexthop but a different routing table needs to be deleted and added in the
correct routing table.
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Felix Fietkau [Tue, 3 Dec 2013 14:16:43 +0000 (15:16 +0100)]
wireless: make interfaces in status an array instead of an object
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Tue, 3 Dec 2013 14:14:30 +0000 (15:14 +0100)]
wireless: prepare bridge interfaces before passing them to the setup script
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Tue, 3 Dec 2013 14:14:05 +0000 (15:14 +0100)]
wireless: add an example driver cleanup implementation
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Mon, 2 Dec 2013 16:36:44 +0000 (17:36 +0100)]
wireless: fix getting the network_bridge variable
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Mon, 2 Dec 2013 15:42:45 +0000 (16:42 +0100)]
wireless: only process setup retries in setup/up state
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Mon, 2 Dec 2013 09:52:53 +0000 (10:52 +0100)]
wireless: fix htmode handling
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Mon, 2 Dec 2013 09:39:51 +0000 (10:39 +0100)]
wireless: call an initial cleanup function
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sun, 1 Dec 2013 22:47:47 +0000 (23:47 +0100)]
wireless: fix reload of active interfaces
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sun, 1 Dec 2013 21:00:28 +0000 (22:00 +0100)]
wireless: fix issues with cancelling device setup
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sun, 1 Dec 2013 20:57:06 +0000 (21:57 +0100)]
wireless: add another debug message
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sun, 1 Dec 2013 20:47:18 +0000 (21:47 +0100)]
wireless: fix process handling if the pid exe is a symlink
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sun, 1 Dec 2013 13:42:51 +0000 (14:42 +0100)]
wireless: fix parsing of the immediate flag for kill-all
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sun, 1 Dec 2013 09:53:13 +0000 (10:53 +0100)]
wireless: add input validation for processes
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sun, 1 Dec 2013 09:28:52 +0000 (10:28 +0100)]
netifd: fix process stdin/stdout/stderr when the pipe fds overlap with standard fds
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sun, 1 Dec 2013 09:22:40 +0000 (10:22 +0100)]
wireless: fix config state handling
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sun, 1 Dec 2013 09:10:25 +0000 (10:10 +0100)]
wireless: add debug messages
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 30 Nov 2013 18:46:12 +0000 (19:46 +0100)]
wireless: add some device/vif error debug messages
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 30 Nov 2013 18:44:14 +0000 (19:44 +0100)]
wireless: fix channel check
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 30 Nov 2013 17:17:55 +0000 (18:17 +0100)]
wireless: fix use-after-free bug
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 30 Nov 2013 15:49:04 +0000 (16:49 +0100)]
wireless: show the virtual interface section name in wireless status
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 30 Nov 2013 15:40:39 +0000 (16:40 +0100)]
wireless: show the ifname in wireless status
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Fri, 29 Nov 2013 14:54:02 +0000 (15:54 +0100)]
wireless: add support for global up/down command
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Helmut Schaa [Fri, 29 Nov 2013 14:22:34 +0000 (15:22 +0100)]
netifd: Fix possible segfault in bridge code
Need to check calloc result. In case of failure the bridge member will be missing.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Felix Fietkau [Mon, 21 Oct 2013 18:15:31 +0000 (20:15 +0200)]
add initial support for handling wireless devices via scripts
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Thu, 28 Nov 2013 17:34:14 +0000 (18:34 +0100)]
utils.sh: add N (newline)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Steven Barth [Wed, 27 Nov 2013 13:52:31 +0000 (14:52 +0100)]
IPv6: add class support to regular IPv6 addresses
Felix Fietkau [Thu, 31 Oct 2013 11:20:32 +0000 (12:20 +0100)]
proto-shell: fix legacy proto_config_add_* functions, make them wrap around config_add_*
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Steven Barth [Wed, 30 Oct 2013 12:18:24 +0000 (13:18 +0100)]
IPv6: Export delegation setting via ubus
This allows foreign prefix delegators to quickly distinguish between
managed and unmanaged prefixes.
Signed-off-by: Steven Barth <steven@midlink.org>
Felix Fietkau [Tue, 29 Oct 2013 15:58:16 +0000 (16:58 +0100)]
proto-shell: replace variable length name char arrays with pointers, using calloc_a
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Tue, 29 Oct 2013 15:59:05 +0000 (16:59 +0100)]
bridge: fix stray semicolon, fixes a bug in bridge primary port reset
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Tue, 29 Oct 2013 15:11:55 +0000 (16:11 +0100)]
scripts/utils.sh: add a function for setting a variable default
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Mon, 21 Oct 2013 13:49:11 +0000 (15:49 +0200)]
utils: add a function for checking if a process given by pid is still alive
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Sat, 19 Oct 2013 14:43:22 +0000 (16:43 +0200)]
add helper function for adding/removing devices to interfaces
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Tue, 24 Sep 2013 09:56:43 +0000 (11:56 +0200)]
handler: include config.h
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Tue, 24 Sep 2013 09:53:48 +0000 (11:53 +0200)]
proto-shell: move more core to handler.c
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Tue, 24 Sep 2013 09:01:07 +0000 (11:01 +0200)]
proto-shell: move script handler config parse code to handler.c
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Tue, 24 Sep 2013 08:47:47 +0000 (10:47 +0200)]
proto-shell: move script handler dump code to handler.c
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Tue, 24 Sep 2013 08:39:15 +0000 (10:39 +0200)]
proto-shell: make handler dump code more generic
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Felix Fietkau [Tue, 22 Oct 2013 12:10:20 +0000 (14:10 +0200)]
scripts: make config_add_* parameters take multiple arguments
Signed-off-by: Felix Fietkau <nbd@openwrt.org>