Richard Levitte [Sat, 23 Jun 2001 14:51:53 +0000 (14:51 +0000)]
For the UI functions that return an int, 0 or any positive number is a
success return, any negative number is a failure. Make sure we check
the return value with that in mind.
Dr. Stephen Henson [Sat, 23 Jun 2001 12:50:06 +0000 (12:50 +0000)]
Fix hwcrhk_insert_card.
Dr. Stephen Henson [Sat, 23 Jun 2001 12:48:46 +0000 (12:48 +0000)]
Fix UI leak in apps.
Dr. Stephen Henson [Sat, 23 Jun 2001 11:51:16 +0000 (11:51 +0000)]
In UI_dup_*() function, use the duped string, not the original.
Dr. Stephen Henson [Sat, 23 Jun 2001 11:49:33 +0000 (11:49 +0000)]
Update my config entry to allow use of DSOs.
Andy Polyakov [Fri, 22 Jun 2001 19:17:42 +0000 (19:17 +0000)]
This fixes "Spurious test failures on IRIX?" reported in April. Apparently
I was wrong in conclusions about when addition starts overflowing in combaX
routines.
Dr. Stephen Henson [Thu, 21 Jun 2001 12:19:10 +0000 (12:19 +0000)]
Fix memory leak when RAND is used: need to cleanup
RANDs ENGINE reference in ENGINE_cleanup().
Richard Levitte [Wed, 20 Jun 2001 15:11:15 +0000 (15:11 +0000)]
Update my status.
Richard Levitte [Wed, 20 Jun 2001 15:00:08 +0000 (15:00 +0000)]
Since there is a way to create UI_METHODs, implement a destructor as
well.
This probably requires reference counters and locks as well. To be
implemented later.
Richard Levitte [Wed, 20 Jun 2001 06:35:46 +0000 (06:35 +0000)]
Modify "openssl engine" to handle and display internal control
commands appropriately.
Dr. Stephen Henson [Tue, 19 Jun 2001 22:30:40 +0000 (22:30 +0000)]
Change all calls to low level digest routines in the library and
applications to use EVP. Add missing calls to HMAC_cleanup() and
don't assume HMAC_CTX can be copied using memcpy().
Note: this is almost identical to the patch submitted to openssl-dev
by Verdon Walker <VWalker@novell.com> except some redundant
EVP_add_digest_()/EVP_cleanup() calls were removed and some changes
made to avoid compiler warnings.
Dr. Stephen Henson [Tue, 19 Jun 2001 17:13:48 +0000 (17:13 +0000)]
Fix memory leaks.
Richard Levitte [Tue, 19 Jun 2001 16:40:36 +0000 (16:40 +0000)]
cp is only used when DSA is built.
Richard Levitte [Tue, 19 Jun 2001 16:34:53 +0000 (16:34 +0000)]
Do a proof of concept. "openssl genrsa" will make the name of the
file part of the password prompt unless it's standard input...
More will be added...
Richard Levitte [Tue, 19 Jun 2001 16:26:30 +0000 (16:26 +0000)]
Change the common application routines to use a UI_METHOD for password
prompting, even when done through the callback.
Richard Levitte [Tue, 19 Jun 2001 16:12:18 +0000 (16:12 +0000)]
- Add the possibility to control engines through control names but
with arbitrary arguments instead of just a string.
- Change the key loaders to take a UI_METHOD instead of a callback
function pointer. NOTE: this breaks binary compatibility with
earlier versions of OpenSSL [engine].
- Addapt the nCipher code for these new conditions and add a card
insertion callback.
Richard Levitte [Tue, 19 Jun 2001 15:54:47 +0000 (15:54 +0000)]
The default flag should be for default passwords only. Otherwise,
someone having a default that is not a password will be confused.
Richard Levitte [Tue, 19 Jun 2001 15:52:00 +0000 (15:52 +0000)]
Enhance the user interface with better support for dialog box
prompting, application-defined prompts, the possibility to use
defaults (for example default passwords from somewhere else) and
interrupts/cancelations.
Dr. Stephen Henson [Tue, 19 Jun 2001 00:23:47 +0000 (00:23 +0000)]
make apps compile again
Dr. Stephen Henson [Tue, 19 Jun 2001 00:04:57 +0000 (00:04 +0000)]
Don't set pointer if add_lock_callback used.
Richard Levitte [Mon, 18 Jun 2001 06:30:12 +0000 (06:30 +0000)]
One feature wasn't quite commited yet
Richard Levitte [Mon, 18 Jun 2001 06:22:33 +0000 (06:22 +0000)]
Provide an application-common setup function for engines and use it
everywhere.
Ben Laurie [Sun, 17 Jun 2001 14:42:57 +0000 (14:42 +0000)]
Fix a memory leak (there's another around here somewhere, though).
PR:
Ben Laurie [Sat, 16 Jun 2001 21:51:26 +0000 (21:51 +0000)]
Delete a redundant line.
Bodo Möller [Fri, 15 Jun 2001 18:05:09 +0000 (18:05 +0000)]
pay attention to blocksize before attempting decryption
Bodo Möller [Mon, 11 Jun 2001 15:21:33 +0000 (15:21 +0000)]
For MSDOS, the tty filename still is "con", not "/dev/tty" ...
Andy Polyakov [Mon, 11 Jun 2001 12:47:52 +0000 (12:47 +0000)]
Get rid of "possible WAW dependency" warnings.
Submitted by:
Reviewed by:
PR:
Bodo Möller [Mon, 11 Jun 2001 09:55:54 +0000 (09:55 +0000)]
even use of default engines leaks memory
Bodo Möller [Mon, 11 Jun 2001 09:55:20 +0000 (09:55 +0000)]
Add directory name to the entry on /crypto/ui/.
Bodo Möller [Mon, 11 Jun 2001 09:54:28 +0000 (09:54 +0000)]
Earlier OpenSSL versions printed prompts to stderr.
In the new crypto/ui/, this was changed into tty (which is usually
/dev/tty), i.e. the FILE * used for reading passwords from the user.
However stdio buffering for read/write streams is not without pitfalls
(passwords would be echoed on some systems).
To avoid problems, split tty into tty_in and tty_out (which are
opened separately).
Dr. Stephen Henson [Mon, 11 Jun 2001 00:48:09 +0000 (00:48 +0000)]
Make update
Dr. Stephen Henson [Mon, 11 Jun 2001 00:45:33 +0000 (00:45 +0000)]
Initialize UI ex_data.
Dr. Stephen Henson [Mon, 11 Jun 2001 00:43:20 +0000 (00:43 +0000)]
Add support for MS CSP Name PKCS#12 attribute.
Ulf Möller [Fri, 8 Jun 2001 14:16:39 +0000 (14:16 +0000)]
more error codes fixed
Lutz Jänicke [Thu, 7 Jun 2001 17:20:50 +0000 (17:20 +0000)]
ERR_peek_error() returns "unsigned long".
Richard Levitte [Thu, 7 Jun 2001 04:42:34 +0000 (04:42 +0000)]
Use memmove() instead of memcpy() on areas that may overlap.
Spotted by Nalin Dahyabhai <nalin@redhat.com>
Richard Levitte [Wed, 6 Jun 2001 23:12:41 +0000 (23:12 +0000)]
Don't forget to initialise.
Bodo Möller [Wed, 6 Jun 2001 21:44:28 +0000 (21:44 +0000)]
OAEP fix
Bodo Möller [Wed, 6 Jun 2001 18:48:49 +0000 (18:48 +0000)]
when checking OAEP, signal just a single kind of 'decoding error'
Ulf Möller [Wed, 6 Jun 2001 17:23:23 +0000 (17:23 +0000)]
move check to avoid memory leak.
Ulf Möller [Wed, 6 Jun 2001 17:17:53 +0000 (17:17 +0000)]
make sure we don't write to seed[-1]
Richard Levitte [Tue, 5 Jun 2001 20:32:36 +0000 (20:32 +0000)]
'make update'
Richard Levitte [Tue, 5 Jun 2001 20:29:26 +0000 (20:29 +0000)]
Defining __USE_XOPEN_EXTENDED was the wrong thing. Instead, define
_XOPEN_SOURCE.
Richard Levitte [Tue, 5 Jun 2001 19:05:52 +0000 (19:05 +0000)]
A good use of the UI interface is as a password callback replacement
(for new functions...). One might still want to be able to pass down
a user-data pointer to be used by the UI. However, ex_data doesn't
quite cut it, since that means the appropriate index to it might need
to be shared between parts that aren't really related in that sense,
and would require the currently hidden (static) index holders to be
uncovered. Not a good thing. Therefore, add the possibility to add a
user-data pointer to a UI.
Richard Levitte [Tue, 5 Jun 2001 04:41:57 +0000 (04:41 +0000)]
Small detail about AIX forgotten...
Richard Levitte [Mon, 4 Jun 2001 16:34:31 +0000 (16:34 +0000)]
Accept digits in symbol names. Spotted by Brian Havard <brianh@kheldar.apana.org.au>
Richard Levitte [Mon, 4 Jun 2001 16:23:15 +0000 (16:23 +0000)]
More info on SRP.
Richard Levitte [Mon, 4 Jun 2001 06:51:43 +0000 (06:51 +0000)]
Added more info in SRP.
Richard Levitte [Fri, 1 Jun 2001 15:30:13 +0000 (15:30 +0000)]
Confusion between algorithms resolved.
Richard Levitte [Fri, 1 Jun 2001 15:29:32 +0000 (15:29 +0000)]
nCipher callbacks shall return 0 on success, something else otherwise.
Richard Levitte [Fri, 1 Jun 2001 15:21:01 +0000 (15:21 +0000)]
Stop mishandling the type number in dynlock locking
Bodo Möller [Fri, 1 Jun 2001 09:41:25 +0000 (09:41 +0000)]
Fix Bleichenbacher PKCS #1 1.5 countermeasure.
(The attack against SSL 3.1 and TLS 1.0 is impractical anyway,
otherwise this would be a security relevant patch.)
Bodo Möller [Fri, 1 Jun 2001 08:38:29 +0000 (08:38 +0000)]
increase DEFAULT_BUFFER_SIZE (4K instead of just 1K)
Richard Levitte [Thu, 31 May 2001 22:25:30 +0000 (22:25 +0000)]
Don't decrement the reference counter twice when destroying dynamic
links.
Geoff Thorpe [Thu, 31 May 2001 19:01:08 +0000 (19:01 +0000)]
Fix a memory leak in 'sk_dup' in the case a realloc() fails. Also, tidy up
a bit of weird code in sk_new.
Andy Polyakov [Wed, 30 May 2001 22:01:33 +0000 (22:01 +0000)]
Get rid of RAW dependency warnings.
Submitted by:
Reviewed by:
PR:
Richard Levitte [Wed, 30 May 2001 15:29:28 +0000 (15:29 +0000)]
Extend all the loading functions to take an engine pointer, a pass
string (some engines may have certificates protected by a PIN!) and
a description to put into error messages.
Also, have our own password callback that we can send both a password
and some prompt info to. The default password callback in EVP assumes
that the passed parameter is a password, which isn't always the right
thing, and the ENGINE code (at least the nCipher one) makes other
assumptions...
Also, in spite of having the functions to load keys, some utilities
did the loading all by themselves... That's changed too.
Richard Levitte [Wed, 30 May 2001 14:59:14 +0000 (14:59 +0000)]
A wish was expressed.
Lutz Jänicke [Tue, 29 May 2001 13:52:21 +0000 (13:52 +0000)]
Don't forget responsible person so that its clear who is to blame.
Andy Polyakov [Mon, 28 May 2001 20:02:51 +0000 (20:02 +0000)]
Assembler support for IA-64. See the source code commentary for further
details (performance numbers and accompanying discussions:-). Note that
the code is not engaged in ./Configure yet. I'll add it later this week
along with updates for .spec file.
Submitted by:
Reviewed by:
PR:
Richard Levitte [Sat, 26 May 2001 16:58:34 +0000 (16:58 +0000)]
Document the latest change in ENGINEs.
Richard Levitte [Fri, 25 May 2001 21:08:56 +0000 (21:08 +0000)]
We had the password callback for ENGINEs pretty much wrong. And
passwords that were given to the key loading functions were completely
ignored, at least in the ncipher code, and then we made the assumption
that the callback wanted a prompt as user argument.
All that is now changed, and the application author is forced to give
a callback function of type pem_callback_cb and possibly an argument
for it, just as for all other functions that want to generate password
prompting.
NOTE: this change creates binary and source incompatibilities with
previous versions of OpenSSL [engine]. It's worth it this time, to
get it right (or at least better and with a chance that it'll work).
Dr. Stephen Henson [Thu, 24 May 2001 22:58:35 +0000 (22:58 +0000)]
Add missing variable length cipher flag for Blowfish.
Only use trust settings if either trust or reject settings
are present, otherwise use compatibility mode. This stops
root CAs being rejected if they have alias of keyid set.
Richard Levitte [Tue, 22 May 2001 12:47:38 +0000 (12:47 +0000)]
VMS doesn't support more than on period in a file name
Dr. Stephen Henson [Thu, 17 May 2001 13:03:20 +0000 (13:03 +0000)]
Add examples to EVP_EncryptInit manual page.
Dr. Stephen Henson [Thu, 17 May 2001 11:47:08 +0000 (11:47 +0000)]
Fix for new UI functions under Win32.
For some unknown reason fopen("con", "w") is the
only way to make this work. Using "r+" and "w+"
causes the fopen call to fail and the fallback
(using stdin) doesn't work because writing to stdin
fails.
Richard Levitte [Thu, 17 May 2001 04:21:00 +0000 (04:21 +0000)]
Add a requirements section for OpenVMS.
Richard Levitte [Thu, 17 May 2001 04:16:19 +0000 (04:16 +0000)]
Add a few more details on what one might need. make and a development
environment were a part of a Unix operating systems, but these days
you see an increasing number of installations that do not necessarely
have these crucial parts by default, so it's needs mentioning.
Lutz Jänicke [Wed, 16 May 2001 09:43:51 +0000 (09:43 +0000)]
Add missing item(s) SSL_ERROR_WANT_CONNECT, SSL_ERROR_WANT_ACCEPT.
Richard Levitte [Wed, 16 May 2001 08:44:09 +0000 (08:44 +0000)]
New internal function OPENSSL_gmtime, which is intended to do the same
as gmtime_r() on the systems where that is defined.
Lutz Jänicke [Tue, 15 May 2001 16:02:35 +0000 (16:02 +0000)]
Increase ENTROPY_NEEDED to support Rijndael's larger key size.
Richard Levitte [Tue, 15 May 2001 15:49:54 +0000 (15:49 +0000)]
Do not forget to increment the pointers...
Richard Levitte [Tue, 15 May 2001 05:15:47 +0000 (05:15 +0000)]
Low-case the names of the system routines, since some versions of
DEC C only have them declared that way (it doesn't really matter,
since the linker is case-insensitive by default)
Richard Levitte [Mon, 14 May 2001 22:10:09 +0000 (22:10 +0000)]
branch on equal is beql, not beq...
Richard Levitte [Mon, 14 May 2001 12:23:28 +0000 (12:23 +0000)]
Make sure strdup() is properly declared.
Richard Levitte [Mon, 14 May 2001 12:22:58 +0000 (12:22 +0000)]
Make sure memset() is properly declared.
Richard Levitte [Mon, 14 May 2001 12:22:27 +0000 (12:22 +0000)]
ui was forgotten when installing libcrypto and it's headers.
Richard Levitte [Mon, 14 May 2001 12:21:16 +0000 (12:21 +0000)]
ui_compat.h was forgotten in the "symlinking" routine.
Richard Levitte [Mon, 14 May 2001 11:59:02 +0000 (11:59 +0000)]
Remove the password reading objects from LIB_DES.
Richard Levitte [Mon, 14 May 2001 11:58:08 +0000 (11:58 +0000)]
Make more short aliases for symbols that are longer than 31
characters.
Richard Levitte [Mon, 14 May 2001 11:56:47 +0000 (11:56 +0000)]
len is a size_t, which is an unsigned integer. Therefore, some
compilers will complain against the check for less than zero.
Richard Levitte [Mon, 14 May 2001 11:54:36 +0000 (11:54 +0000)]
Use ui_compat.h to get the password reading functions.
Richard Levitte [Mon, 14 May 2001 11:53:37 +0000 (11:53 +0000)]
Make it so the compiler doesn't inform me about the dollars in some
symbols.
Lutz Jänicke [Mon, 14 May 2001 09:52:44 +0000 (09:52 +0000)]
Typos.
Lutz Jänicke [Mon, 14 May 2001 09:02:38 +0000 (09:02 +0000)]
One more point to clarify, pointed out by "Greg Stark" <ghstark@pobox.com>
Richard Levitte [Sun, 13 May 2001 17:55:30 +0000 (17:55 +0000)]
It seems like the removal of "extern" before "static" wasn't a
mistake.
Richard Levitte [Sun, 13 May 2001 10:37:02 +0000 (10:37 +0000)]
Document the addition.
Richard Levitte [Sun, 13 May 2001 10:34:18 +0000 (10:34 +0000)]
A randomizer for OpenVMS, using the statistics that are easily
reachable.
It's completely untested for now. To be done in the next few days.
Richard Levitte [Sun, 13 May 2001 05:34:39 +0000 (05:34 +0000)]
Define `ok' and better error detection.
Richard Levitte [Sun, 13 May 2001 05:16:58 +0000 (05:16 +0000)]
make update
Richard Levitte [Sun, 13 May 2001 05:01:58 +0000 (05:01 +0000)]
Win16 too :-).
Richard Levitte [Sun, 13 May 2001 04:59:09 +0000 (04:59 +0000)]
des_read_password() and des_read_2passwords() can only appear if DES
is compiled.
Richard Levitte [Sun, 13 May 2001 04:48:07 +0000 (04:48 +0000)]
When doing rewrites on ssleay.num, the file was prematurely closed.
Make rewrites the default, since it works, and people get confused if
changed information doesn't get rewritten automagically.
Richard Levitte [Sun, 13 May 2001 04:40:44 +0000 (04:40 +0000)]
Move the password reading functions completely away from the DES
section.
Add ui_compat.h for inclusion by those who want the old functions and
provide all of them, not just the higher-level ones, in ui_compat.c.
Richard Levitte [Sun, 13 May 2001 04:34:57 +0000 (04:34 +0000)]
Put back a removed "extern", or many compilers will complain about
redefined variables.
Dr. Stephen Henson [Sun, 13 May 2001 00:33:55 +0000 (00:33 +0000)]
#if 0 out deleted (?) functions to stop Win32 DLL
build falling over.
Dr. Stephen Henson [Sat, 12 May 2001 23:57:41 +0000 (23:57 +0000)]
Change Win32 to use EXPORT_VAR_AS_FN.
Fix OPENSSL_IMPLEMENT_GLOBAL.
Allow Win32 to use EXPORT_VAR_AS_FN in mkdef.pl
make update.
Lutz Jänicke [Sat, 12 May 2001 09:49:02 +0000 (09:49 +0000)]
Clarify behaviour with respect to SSL/TLS records.
Dr. Stephen Henson [Sat, 12 May 2001 00:16:56 +0000 (00:16 +0000)]
Under VC++ _DLL is set to indicate that the application
will be linked against the DLL runtime library. It is
automatically set when /MD is used.
As a result OpenSSL shouldn't use _DLL to determine if
it should set OPENSSL_OPT_WINDLL because this will
cause linkage conflicts with static builds which do
include the /MD compiler switch.
Dr. Stephen Henson [Sat, 12 May 2001 00:09:04 +0000 (00:09 +0000)]
Typo.